August 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: contrib/jenkins.sh: run pylint on all *.py files

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/29238 ) Change subject: contrib/jenkins.sh: run pylint on all *.py files ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 Gerrit-Change-Number: 29238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: run pylint on all *.py files

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29238 ) Change subject: contrib/jenkins.sh: run pylint on all *.py files ...................................................................... contrib/jenkins.sh: run pylint on all *.py files Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/29238/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7e29d1d..a1d112f 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -33,7 +33,7 @@ --disable E1102 \ --disable E0401 \ --enable W0301 \ - pySim *.py + $(find . -name "*.py") # attempt to build documentation pip install sphinx -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 Gerrit-Change-Number: 29238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29236 ) Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... contrib/jenkins.sh: execute this script with -x and -e -x Print commands and their arguments as they are executed -e Exit immediately if a command exits with a non-zero status Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/29236/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ac5fba8..36bc4ae 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/sh -xe # jenkins build helper script for pysim. This is how we build on jenkins.osmocom.org # # environment variables: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: install dependencies from requirements.txt

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29237 ) Change subject: contrib/jenkins.sh: install dependencies from requirements.txt ...................................................................... contrib/jenkins.sh: install dependencies from requirements.txt Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/29237/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 36bc4ae..7e29d1d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -17,15 +17,7 @@ virtualenv -p python3 venv --system-site-packages . venv/bin/activate -pip install pytlv -pip install 'pyyaml>=5.1' -pip install cmd2==1.5 -pip install jsonpath-ng -pip install construct -pip install bidict -pip install gsm0338 -pip install termcolor -pip install colorlog +pip install -r requirements.txt # Execute automatically discovered unit tests first python -m unittest discover -v -s tests/ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 Gerrit-Change-Number: 29237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in pysim[master]: README.md: update git URLs (git -> https; gitea)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29234 ) Change subject: README.md: update git URLs (git -> https; gitea) ...................................................................... README.md: update git URLs (git -> https; gitea) Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9 --- M README.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/29234/1 diff --git a/README.md b/README.md index 9eab71c..e268d23 100644 --- a/README.md +++ b/README.md @@ -23,10 +23,10 @@ You can clone from the official Osmocom git repository using ``` -git clone git://git.osmocom.org/pysim.git +git clone https://gitea.osmocom.org/sim-card/pysim.git ``` -There is a cgit interface at <https://git.osmocom.org/pysim> +There is a web interface at <https://gitea.osmocom.org/sim-card/pysim>. Installation -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9 Gerrit-Change-Number: 29234 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in pysim[master]: README.md: update installation instructions for Debian

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29235 ) Change subject: README.md: update installation instructions for Debian ...................................................................... README.md: update installation instructions for Debian Change-Id: Icefa33570a34960a4fff145f3c1b6585d867605c --- M README.md 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/29235/1 diff --git a/README.md b/README.md index e268d23..a698653 100644 --- a/README.md +++ b/README.md @@ -47,9 +47,14 @@ - colorlog Example for Debian: -``` -apt-get install python3-pyscard python3-serial python3-pip python3-yaml python3-termcolor python3-colorlog -pip3 install -r requirements.txt +```sh +sudo apt-get install --no-install-recommends \ + pcscd libpcsclite-dev \ + python3 \ + python3-setuptools \ + python3-pyscard \ + python3-pip +pip3 install --user -r requirements.txt ``` After installing all dependencies, the pySim applications ``pySim-read.py``, ``pySim-prog.py`` and ``pySim-shell.py`` may be started directly from the cloned repository. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icefa33570a34960a4fff145f3c1b6585d867605c Gerrit-Change-Number: 29235 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: fix 'publish' target

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29233 ) Change subject: contrib/jenkins.sh: fix 'publish' target ...................................................................... contrib/jenkins.sh: fix 'publish' target Executing 'maintainer-clean' before 'publish' makes the later fail: + make -C /build/doc/manuals publish make: Entering directory '/build/doc/manuals' make: Leaving directory '/build/doc/manuals' make: *** No rule to make target 'publish'. Stop. Execute 'maintainer-clean' after 'publish', like other projects do. Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Fixes: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/33/29233/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f3331af..561d3d9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,10 +53,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Gerrit-Change-Number: 29233 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic In cases a), b), c), d), and e) we're sending one or more Measurement Reports via the A-bis/RSL, and then immediately triggering a traffic channel assignment by calling f_TC_chan_alloc_algo(), which sends an Assignment Request via the A interface. The above-mentioned messages are sent immediately all together, so it may happen that the BSC handles the Assignment Request earlier than the Measurement Report(s). In this case there will be no RxLev samples, so the BSC would fall-back to ascending allocation order. Recently we saw this race condition actually happening on Jenkins: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test-sccplite/… Let's introduce an artificial delay before sending the Assignment Request, so that the BSC has enough time to process received MRs. Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 7f4ce46..09cd717 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11666,6 +11666,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 0, ts_RSL_IE_UplinkMeas(30, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11677,6 +11678,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(48, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11688,6 +11690,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX3); f_perform_clear_test_ct(dt); @@ -11703,6 +11706,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I think this was intentional, i.e. libsmpp34 as we inherited had shown parallel_make problems. I updated the commit message. The parallel build has been fixed back in 2018. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:38:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... contrib/jenkins.sh: do not override parallel make for libsmpp34 Parallel build has been fixed [1] and re-enabled [2] back in 2018. Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 libsmpp34.git Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 libsmpp34.git --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fb858d7..e1bbad4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -35,7 +35,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp -PARALLEL_MAKE="" osmo-build-dep.sh libsmpp34 +osmo-build-dep.sh libsmpp34 osmo-build-dep.sh osmo-mgw osmo-build-dep.sh osmo-hlr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022