Attention is currently required from: neels, msuraev, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
......................................................................
Patch Set 19:
(1 comment)
File include/osmocom/smpp/smpp_smsc.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b0d5c58f_47d2fa14
PS19, Line 32: struct esme *esme;
> just 'struct esme esme;' (non-pointer) to avoid extra talloc, […]
Hi Neels, it's fine the way the patch is now, I actually pointed towards the current directon, since the idea is to decouple the structs and hide the implementation details, so allocating and freeing the struct is the usual way.
It's not like this struct is allocated tons of times per seconds in any case...
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 19
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 )
Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE
......................................................................
contrib/jenkins.sh: actually build with $PARALLEL_MAKE
Parallel build has been fixed [1] and re-enabled [2] back in 2018.
Executing $MAKE without $PARALLEL_MAKE builds the project with -j1.
Executing $MAKE with $PARALLEL_MAKE after that makes no sense,
because everything is already compiled and there is nothing to do.
Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334
Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12
Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70
---
M contrib/jenkins.sh
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 3b4e639..7a75e25 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -7,7 +7,6 @@
autoreconf --install --force
./configure --enable-sanitize --enable-werror
-$MAKE
$MAKE $PARALLEL_MAKE
$MAKE distcheck || cat-testlogs.sh
$MAKE maintainer-clean
--
To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334
Gerrit-Change-Number: 29219
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_11/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sgsn
Last lines of build log:
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2html5 to provide /usr/bin/rst2html5 (rst2html5) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2latex to provide /usr/bin/rst2latex (rst2latex) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2man to provide /usr/bin/rst2man (rst2man) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2odt to provide /usr/bin/rst2odt (rst2odt) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2odt_prepstyles to provide /usr/bin/rst2odt_prepstyles (rst2odt_prepstyles) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2pseudoxml to provide /usr/bin/rst2pseudoxml (rst2pseudoxml) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2s5 to provide /usr/bin/rst2s5 (rst2s5) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xetex to provide /usr/bin/rst2xetex (rst2xetex) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xml to provide /usr/bin/rst2xml (rst2xml) in auto mode
[ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rstpep2html to provide /usr/bin/rstpep2html (rstpep2html) in auto mode
[ 304s] [459/492] installing python3-reportlab-3.5.59-2
[ 308s] [460/492] installing g++-4:10.2.1-1+rpi1
[ 308s] update-alternatives: using /usr/bin/g++ to provide /usr/bin/c++ (c++) in auto mode
[ 308s] [461/492] installing libosmo-netif-dev-1.2.0.9.a69b.202208300052
[ 309s] [462/492] installing mount-2.36.1-8+deb11u1
[ 313s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/mount.deb' (size=177188) member 'data.tar': lzma error: compressed data is corrupt
[ 313s] dpkg-deb: error: <decompress> subprocess returned error exit status 2
[ 313s] dpkg: error processing archive .init_b_cache/mount.deb (--install):
[ 313s] cannot copy extracted data for './bin/mount' to '/bin/mount.dpkg-new': unexpected end of file or stream
[ 313s] Errors were encountered while processing:
[ 313s] .init_b_cache/mount.deb
[ 313s] exit ...
[ 313s] ### VM INTERACTION START ###
[ 314s] [ 283.479303] sysrq: SysRq : Power Off
[ 314s] [ 283.481537] reboot: Power down
[ 314s] ### VM INTERACTION END ###
[ 314s]
[ 314s] armbuild01 failed "build osmo-sgsn_1.9.0.2.fb6cf.202208300052.dsc" at Tue Aug 30 03:52:45 UTC 2022.
[ 314s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)