Change in osmo-msc[master]: Make esme struct shared
Attention is currently required from: neels, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 19: (1 comment) File include/osmocom/smpp/smpp_smsc.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b0d5c58f_47d2fa14 PS19, Line 32: struct esme *esme;
just 'struct esme esme;' (non-pointer) to avoid extra talloc, […] Hi Neels, it's fine the way the patch is now, I actually pointed towards the current directon, since the idea is to decouple the structs and hide the implementation details, so allocating and freeing the struct is the usual way. It's not like this struct is allocated tons of times per seconds in any case...
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 10:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
pespin