August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 to look at the new patch set (#2). Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Related: SYS#6093 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/29232/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/29232/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7d5492f..f4e24d7 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -291,7 +291,8 @@ talloc_free(message); #if ENABLE_PFCP - } else { + } else if (hnb_gw_is_gtp_mapping_enabled(hnb->gw)) { + /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: test both with and without PFCP [WIP]

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231 ) Change subject: hnbgw: test both with and without PFCP [WIP] ...................................................................... hnbgw: test both with and without PFCP [WIP] The "without_pfcp" test still depends on restarting osmo-hnbgw with a modified .cfg. Change-Id: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 67 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/29231/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index b440292..7ac6559 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1240,7 +1240,7 @@ } } -friend function f_tc_ps_rab_assignment(charstring id, TestHdlrParams pars) runs on ConnHdlr { +friend function f_tc_ps_rab_assignment_with_pfcp(charstring id, TestHdlrParams pars) runs on ConnHdlr { var RANAP_PDU tx; var RANAP_PDU rx; timer T := 5.0; @@ -1329,13 +1329,75 @@ f_sleep(2.0); } -testcase TC_ps_rab_assignment() runs on test_CT { +testcase TC_ps_rab_assignment_with_pfcp() runs on test_CT { var ConnHdlr vc_conn; f_init(); f_start_hnbs(); f_sleep(1.0); - vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment), t_pars(7, ps_domain := true)); + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_with_pfcp), t_pars(7, ps_domain := true)); + vc_conn.done; +} + +altstep as_disallow_pfcp() runs on ConnHdlr { + [] PFCP.receive(PDU_PFCP:?) { + setverdict(fail, "Received PFCP message, but no PFCP communication expected"); + mtc.stop; + } +} + +friend function f_tc_ps_rab_assignment_without_pfcp(charstring id, TestHdlrParams pars) runs on ConnHdlr { + var RANAP_PDU tx; + var RANAP_PDU rx; + timer T := 5.0; + + f_init_handler(pars); + + f_pfcp_register(); + activate(as_disallow_pfcp()); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + var GtpParameters gtp_pars := valueof(t_GtpParameters); + var template RAB_SetupOrModifyList rab_sml; + + /* Send RAB Assignment Request */ + rab_sml := ts_RAB_SML_ps(t_RAB_id(23), f_ts_RAB_TLA(gtp_pars.core.remote.addr), gtp_pars.core.remote.teid); + tx := valueof(ts_RANAP_RabAssReq(rab_sml)); + BSSAP.send(tx); + + /* Expect on Iuh: unmodified RAB Assignment Request */ + rx := valueof(ts_RANAP_RabAssReq(rab_sml)); + RUA.receive(rx); + + /* Send back RAB Assignment Response via Iuh */ + var template RAB_SetupOrModifiedList rab_smdl; + rab_smdl := ts_RAB_SMdL_ps(t_RAB_id(23), f_ts_RAB_TLA(gtp_pars.access.remote.addr), + gtp_pars.access.remote.teid); + tx := valueof(ts_RANAP_RabAssResp(rab_smdl)); + RUA.send(tx); + + /* Expect on IuPS: unmodified RAB Assignment Response */ + BSSAP.receive(tr_RANAP_RabAssResp(rab_smdl)); + + f_sleep(2.0); + tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + f_iu2iuh(tx); + + tx := valueof(ts_RANAP_IuReleaseComplete()); + f_iuh2iu(tx); + + f_sleep(2.0); +} + +testcase TC_ps_rab_assignment_without_pfcp() runs on test_CT { + var ConnHdlr vc_conn; + f_init(); + f_start_hnbs(); + f_sleep(1.0); + + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_without_pfcp), t_pars(7, ps_domain := true)); vc_conn.done; } @@ -1354,7 +1416,8 @@ execute(TC_rab_assign_mgcp_to()); execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); - execute(TC_ps_rab_assignment()); + execute(TC_ps_rab_assignment_with_pfcp()); + execute(TC_ps_rab_assignment_without_pfcp()); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Gerrit-Change-Number: 29231 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:39:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think this was intentional, i.e. libsmpp34 as we inherited had shown parallel_make problems. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:37:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022