August 2022 - gerrit-log - lists.osmocom.org

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by fixeria

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: actually build with $PARALLEL_MAKE Parallel build has been fixed [1] and re-enabled [2] back in 2018. Executing $MAKE without $PARALLEL_MAKE builds the project with -j1. Executing $MAKE with $PARALLEL_MAKE after that makes no sense, because everything is already compiled and there is nothing to do. Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/19/29219/2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 939a514..62e6516 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,12 +58,12 @@ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi -$MAKE maintainer-clean +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0848bea..f3331af 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -51,7 +51,7 @@ ./configure --enable-sanitize --enable-werror --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh $MAKE $PARALLEL_MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... contrib/jenkins.sh: also execute maintainer-clean target Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 104ba2a..0848bea 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,6 +53,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY The PRIM_INFO_MODIFY is sent on receipt of the RSL MODE MODIFY message, which may optionally contain new ciphering parameters. Before this patch, osmo-bts-trx would ignore the new parameters and continue using the old ciphering key/algorithm. * Modify l1if_set_ciphering() to allow updating ciphering params. * Call l1if_set_ciphering() when handling PRIM_INFO_MODIFY. This problem was uncovered by BTS_Tests.TC_rsl_modify_encr, which has been failing ever since it was introduced [1]. This patch makes it pass. Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Related: [1] I4cbea499bb6a331d314e6573548a4540945208b5 osmo-ttcn3-hacks.git Related: OS#3750 --- M src/osmo-bts-trx/l1_if.c 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 92180b5..8c364c3 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -326,8 +326,8 @@ /* enable ciphering */ static int l1if_set_ciphering(struct gsm_lchan *lchan, uint8_t chan_nr, int downlink) { - /* ciphering already enabled in both directions */ - if (lchan->ciph_state == LCHAN_CIPH_RXTX_CONF) + /* ignore the request when the channel is not active */ + if (lchan->state != LCHAN_S_ACTIVE) return -EINVAL; if (!downlink) { @@ -463,6 +463,13 @@ lchan->tch.amr_mr.mode[3].mode, amr_get_initial_mode(lchan), 0); + /* update ciphering params */ + l1if_set_ciphering(lchan, chan_nr, 0); + l1if_set_ciphering(lchan, chan_nr, 1); + if (lchan->encr.alg_id) + lchan->ciph_state = LCHAN_CIPH_RXTX_CONF; + else + lchan->ciph_state = LCHAN_CIPH_NONE; break; } /* here, type == PRIM_INFO_DEACTIVATE */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 ) Change subject: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control ...................................................................... BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control Both testcases were introduced in 2021 [1], however they're not executed on Jenkins because they're not present in control section. Fixes: [1] I38e8a1cf15eb41a621b457b39024283a767c94be Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b2d6383..f9361a0 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8726,9 +8726,11 @@ execute( TC_chan_act_a51() ); execute( TC_chan_act_a52() ); execute( TC_chan_act_a53() ); + execute( TC_chan_act_a54() ); execute( TC_encr_cmd_a51() ); execute( TC_encr_cmd_a52() ); execute( TC_encr_cmd_a53() ); + execute( TC_encr_cmd_a54() ); execute( TC_err_rep_wrong_mdisc() ); execute( TC_err_rep_wrong_msg_type() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 Gerrit-Change-Number: 29215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by laforge

Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 15: (2 comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/aebf41e5_35d43381 PS15, Line 600: if ( in whihc situation would we have a zero-length opt_data_cache? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/59cd70d2_3640867b PS15, Line 639: msgb_alloc(SCCP_MAX_DATA, "SCCP optional data cache for CR/CC/RLSD"); If we ever should run into memory leaks, it would be better to use msgb_alloc_c(conn) to attach this msgb to the 'conn'. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 15 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Related: SYS#6093 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7d5492f..f4e24d7 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -291,7 +291,8 @@ talloc_free(message); #if ENABLE_PFCP - } else { + } else if (hnb_gw_is_gtp_mapping_enabled(hnb->gw)) { + /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: fast tracking this regression fix -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022