August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: csn1: add CSN_DESCR_EXTERN for extern declarations

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29181 to look at the new patch set (#2). Change subject: csn1: add CSN_DESCR_EXTERN for extern declarations ...................................................................... csn1: add CSN_DESCR_EXTERN for extern declarations Change-Id: Ieb721c97c8e9acee5057bb04be73f27b2871687b --- M include/osmocom/csn1/csn1.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/81/29181/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ieb721c97c8e9acee5057bb04be73f27b2871687b Gerrit-Change-Number: 29181 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: cosmetic: coding style improvements for #defines

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 ) Change subject: csn1: cosmetic: coding style improvements for #defines ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia00809aa95b91006149d62abbeda9493b5a64728 Gerrit-Change-Number: 29180 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:53:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: cosmetic: coding style improvements for #defines

by fixeria

fixeria has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 ) Change subject: csn1: cosmetic: coding style improvements for #defines ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia00809aa95b91006149d62abbeda9493b5a64728 Gerrit-Change-Number: 29180 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteReviewer

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: cosmetic: coding style improvements for #defines

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 ) Change subject: csn1: cosmetic: coding style improvements for #defines ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Linter does not apply here: include/osmocom/csn1/csn1.h:225: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop include/osmocom/csn1/csn1.h:225: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia00809aa95b91006149d62abbeda9493b5a64728 Gerrit-Change-Number: 29180 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: #include <stddef.h> in csn1.h for offsetof()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29179 ) Change subject: csn1: #include <stddef.h> in csn1.h for offsetof() ...................................................................... csn1: #include <stddef.h> in csn1.h for offsetof() Do not require the API user to include <stddef.h>: note: 'offsetof' is defined in header '<stddef.h>'; did you forget to '#include <stddef.h>'? Change-Id: I2a144c9967b90d78d95db103eebce83822d8c64d --- M include/osmocom/csn1/csn1.h M src/rlcmac/gprs_rlcmac.c 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/csn1/csn1.h b/include/osmocom/csn1/csn1.h index 3b80fad..9b29ba8 100644 --- a/include/osmocom/csn1/csn1.h +++ b/include/osmocom/csn1/csn1.h @@ -23,6 +23,8 @@ #pragma once +#include <stddef.h> + #include <osmocom/core/bitvec.h> #include "wireshark_compat.h" diff --git a/src/rlcmac/gprs_rlcmac.c b/src/rlcmac/gprs_rlcmac.c index cd40387..80b399b 100644 --- a/src/rlcmac/gprs_rlcmac.c +++ b/src/rlcmac/gprs_rlcmac.c @@ -26,7 +26,6 @@ */ #include <assert.h> -#include <stddef.h> #include <arpa/inet.h> #include <osmocom/core/utils.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2a144c9967b90d78d95db103eebce83822d8c64d Gerrit-Change-Number: 29179 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 13: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/75dc6945_f9d89ff6 PS8, Line 603: xua_class_msg_name > Done Nope, this does now solve the problem. In your new patchset 'exp_name' still points to the internal static buffer of xua_class_msg_name() and calling xua_class_msg_name() again may overwrite it. A proper solution would be adding xua_class_msg_name_buf(), which would accept the buffer as an argument. You can find some examples by grepping _buf and _c. As a quick solution, you can simply log hex numbers without using xua_class_msg_name(). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 to look at the new patch set (#5). Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... SIGTRAN: add osmo_sccp_tx_disconn_data() helper SCCP RLSD message might have up to 130 bytes of optional data according to ITU-T Rec Q.713 §4.5 - add helper which allows sending it and use it in example code. Related: OS#5579 Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c 3 files changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/29170/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: Looks like changing default indent value wasn't applied to already opened buffers. Let's see if restarting editor helps. File src/sccp_helpers.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3b93a664_fe26a587 PS4, Line 196: int osmo_sccp_tx_disconn_data(struct osmo_sccp_user *scu, uint32_t conn_id, > Weird misalignment, still. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/5f1dc806_ccf23f85 PS4, Line 230: int osmo_sccp_tx_disconn(struct osmo_sccp_user *scu, uint32_t conn_id, > Weird misalignment, still. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:34:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, fixeria. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 to look at the new patch set (#12). Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD The length limit of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or RLSD message with bigger data - cache it if necessary and send via separate DT1 message after connection becomes active. While at it, clarify the order of comments in the encoding routine to match the spec. Fixes: OS#5579 Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a --- M src/sccp_scoc.c 1 file changed, 131 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/12 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 11: (8 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a3b110f7_3d86edbc PS8, Line 9: Limit length of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or > This reads a bit weird. […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/f0100bc3_6bdeaec6 PS8, Line 50: #include <osmocom/core/msgb.h> > cosmetic: move it below to other imports from 'osmocom/core'. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/ecc3dca8_51692095 PS8, Line 603: xua_class_msg_name > xua_class_msg_name() operates on a static buffer, so calling it more than once in a logging statemen […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/76e546b0_6f13dea0 PS8, Line 613: lim > IIUC, this value is always SCCP_MAX_DATA. […] No, it's not. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/36748543_09562d0c PS8, Line 623: xua_opt_data_cache_check > When I see function names ending with _check, I expect them to do nothing else but check something a […] Renamed and updated docs for clarity. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7c59d29f_d77102b1 PS8, Line 650: static bool xua_opt_data_length_check(struct sccp_connection *conn, const struct osmo_scu_prim *prim, int msg_type) > Again, this naming is really confusing. […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7a9c0031_0ad8e9b7 PS8, Line 659: break > unreachable Yes? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/08795265_cff33e10 PS8, Line 1006: xua_opt_data_clear_cache > IMO, this should be done in conn_destroy(). Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: fix using incomplete type 'struct value_string'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29182 ) Change subject: rlcmac: fix using incomplete type 'struct value_string' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6f261c0e57a8d341f6e613a2845a6f2cb52d3830 Gerrit-Change-Number: 29182 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:27:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: add CSN_DESCR_EXTERN for extern declarations

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29181 ) Change subject: csn1: add CSN_DESCR_EXTERN for extern declarations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ieb721c97c8e9acee5057bb04be73f27b2871687b Gerrit-Change-Number: 29181 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:27:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: cosmetic: coding style improvements for #defines

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 ) Change subject: csn1: cosmetic: coding style improvements for #defines ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia00809aa95b91006149d62abbeda9493b5a64728 Gerrit-Change-Number: 29180 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:27:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-gprs[master]: csn1: #include <stddef.h> in csn1.h for offsetof()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29179 ) Change subject: csn1: #include <stddef.h> in csn1.h for offsetof() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2a144c9967b90d78d95db103eebce83822d8c64d Gerrit-Change-Number: 29179 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-deps.sh: use osmo_git_clone_url

by laforge

Attention is currently required from: osmith, neels, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29191 ) Change subject: scripts/osmo-deps.sh: use osmo_git_clone_url ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa Gerrit-Change-Number: 29191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-upf[master]: packaging: add missing libnftnl, libnftables deps

by laforge

Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29188 ) Change subject: packaging: add missing libnftnl, libnftables deps ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I just did a quick 'git grep libnftnl' to see if we are even including any <libnftnl/*.h> files anywhere in osmo-upf. I cannot find any. So IMHO, the dependency should be dropped from the configure.ac file and not introduced to rpm or dpkg packaging. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I974dd3163e50e6b1a099eac5d5f6a1cac07f44ad Gerrit-Change-Number: 29188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:23:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-upf[master]: packaging: add missing libnftnl, libnftables deps

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29188 ) Change subject: packaging: add missing libnftnl, libnftables deps ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I am wondering why we are depending on libnftnl at all. Are we using it directly from osmo-upf codebase? To me it seesm that all we use is libnftables, and that in turn has an upstream dependency to libnftnl, which again has a dependency to libmnl. But those downstream dependencies should not be of our concern, it is the job of distribution packaging and pkg-config to pull those in. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I974dd3163e50e6b1a099eac5d5f6a1cac07f44ad Gerrit-Change-Number: 29188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... packaging: depend on libosmocore >= 1.7.0 Require the same libosmocore version in configure.ac and rpm spec as already set in debian/control. Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 --- M configure.ac M contrib/libosmo-pfcp.spec.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 6d51465..1b8436e 100644 --- a/configure.ac +++ b/configure.ac @@ -37,7 +37,7 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index e47d52c..d6481c2 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -11,7 +11,7 @@ BuildRequires: libtool >= 2 BuildRequires: lksctp-tools-devel BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.7.0 BuildRequires: pkgconfig(talloc) %description -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: rpm spec: reduce summary line length

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29165 ) Change subject: rpm spec: reduce summary line length ...................................................................... rpm spec: reduce summary line length Fixes the following rpmlint error: [ 17s] libosmo-pfcp.src: E: summary-too-long (Badness: 200) libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation [ 17s] The 'Summary:' must not exceed 79 characters. also, coincidentally it fixes: [ 17s] libosmo-pfcp.src: E: summary-not-capitalized (Badness: 20) libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation [ 17s] Summary doesn't begin with a capital letter. and the non-critical warning: [ 17s] libosmo-pfcp.src: W: name-repeated-in-summary libosmo-pfcp [ 17s] The name of the package is repeated in its summary. Make the summary brief and [ 17s] to the point without including redundant information in it. Related: OS#5653 Change-Id: I293f77849d50e68753b82d7b5476c19217ecc2de --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 286a644..4ef2607 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -1,7 +1,7 @@ Name: libosmo-pfcp Version: @VERSION@ Release: 0 -Summary: libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation +Summary: PFCP protocol encoding, decoding and endpoint implementation License: AGPL-3.0-or-later AND GPL-2.0-or-later Group: Hardware/Mobile URL: https://osmocom.org/projects/libosmo-pfcp -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I293f77849d50e68753b82d7b5476c19217ecc2de Gerrit-Change-Number: 29165 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: rpm spec: use --disable-static

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... rpm spec: use --disable-static Follow what we are doing in other Osmocom rpm packaging by not building and packaging static libraries. Fix for rpmlint errors when building for OpenSUSE: libosmo-gtlv-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-pfcp.a libosmo-gtlv-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-pfcp.a (If we wanted to build with static libraries, we would need to use -ffat-lto-objects to get rid of the second error.) Related: https://github.com/rpm-software-management/rpmlint/issues/458 Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 4ef2607..e47d52c 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -72,6 +72,7 @@ echo "%{version}" >.tarball-version autoreconf -fi %configure \ + --disable-static \ --includedir="%_includedir/%name" make %{?_smp_mflags} @@ -95,7 +96,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/gtlv %{_libdir}/libosmo-gtlv.so -%{_libdir}/libosmo-gtlv.a %{_libdir}/pkgconfig/libosmo-gtlv.pc %files -n libosmo-pfcp0 @@ -106,7 +106,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/pfcp %{_libdir}/libosmo-pfcp.so -%{_libdir}/libosmo-pfcp.a %{_libdir}/pkgconfig/libosmo-pfcp.pc %changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... debian/control: move -dev deps of libosmo-gtlv-dev Only the -dev package of libosmo-gtlv should depend on other -dev packages. Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a --- M debian/control 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/control b/debian/control index c5d9f04..1d4822d 100644 --- a/debian/control +++ b/debian/control @@ -33,8 +33,6 @@ Multi-Arch: same Depends: ${shlibs:Depends}, ${misc:Depends}, - libosmocore-dev (>= 1.7.0), - libtalloc-dev (>= 2.1.0) Pre-Depends: ${misc:Pre-Depends} Description: Generic TLV and TLIV protocol support Decoding, encoding and logging of protocols using a Tag-Length-Value and/or @@ -45,7 +43,9 @@ Multi-Arch: same Section: libdevel Depends: ${misc:Depends}, - libosmo-gtlv0 (= ${binary:Version}) + libosmo-gtlv0 (= ${binary:Version}), + libosmocore-dev (>= 1.7.0), + libtalloc-dev (>= 2.1.0) Description: Development files for libosmo-gtlv libosmo-gtlv implements decoding, encoding and logging of protocols using a Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: Bump version: 0.1.0.32-823b → 0.1.1

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 ) Change subject: Bump version: 0.1.0.32-823b → 0.1.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b Gerrit-Change-Number: 29186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: rpm spec: use --disable-static

by laforge

Attention is currently required from: osmith, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: examples: update vty code

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 ) Change subject: examples: update vty code ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I52d0823b7843aa61594e728a0fac19d884ff78fe Gerrit-Change-Number: 29192 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 22 Aug 2022 12:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by fixeria

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 4: (2 comments) File src/sccp_helpers.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/7bd459e0_73374d29 PS4, Line 196: int osmo_sccp_tx_disconn_data(struct osmo_sccp_user *scu, uint32_t conn_id, Weird misalignment, still. https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/e7f6f5d4_df4ac46f PS4, Line 230: int osmo_sccp_tx_disconn(struct osmo_sccp_user *scu, uint32_t conn_id, Weird misalignment, still. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 to look at the new patch set (#4). Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... SIGTRAN: add osmo_sccp_tx_disconn_data() helper SCCP RLSD message might have up to 130 bytes of optional data according to ITU-T Rec Q.713 §4.5 - add helper which allows sending it and use it in example code. Related: OS#5579 Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c 3 files changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/29170/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 3: (4 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3246d21f_86c3c4d5 PS1, Line 97: > I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […] Done File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/02318179_c4a28f71 PS2, Line 97: [DATA] > You forgot to add documentation an optional parameter: […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/f0e77100_09142d00 PS2, Line 103: argv[1] > Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […] Indeed. Actually, I think it's better to skip the data variable altogether - see next revision. I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant. File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/0b2c5208_cd72b691 PS2, Line 48: > Really weird alignment making it rather harder to read. Tab-size should be 8. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 13: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/20129f38_044df09b PS12, Line 459: osmo_sccp_conn_id_exists > My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of ad […] I don't see any advantage in doing that: even if we expose that function it would still be more convenient to write the wrapper returning bool. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 188s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Requires(pre): /bin/sh systemd [ 188s] Requires(post): /bin/sh systemd [ 188s] Requires(preun): /bin/sh systemd [ 188s] Requires(postun): /bin/sh systemd [ 188s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libasn1c.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-hnbap.so.0()(64bit) libosmo-mgcp-client.so.9()(64bit) libosmo-ranap.so.5()(64bit) libosmo-rua.so.0()(64bit) libosmo-sigtran.so.7()(64bit) libosmocore.so.19()(64bit) libosmoctrl.so.0()(64bit) libosmoctrl.so.0(LIBOSMOCTRL_1.0)(64bit) libosmogsm.so.18()(64bit) libosmogsm.so.18(LIBOSMOGSM_1.0)(64bit) libosmonetif.so.8()(64bit) libosmovty.so.9()(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) [ 188s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 188s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 188s] Provides: debuginfo(build-id) = e41e57058c79b1512cd026207640bee3207f84b5 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debuginfo(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Recommends: osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 189s] error: Installed (but unpackaged) file(s) found: [ 189s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 189s] [ 189s] RPM build errors: [ 189s] Installed (but unpackaged) file(s) found: [ 189s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 189s] ### VM INTERACTION START ### [ 189s] [ 167.311829][ T1] sysrq: Power Off [ 189s] [ 167.327099][ T16] reboot: Power down [ 189s] ### VM INTERACTION END ### [ 189s] [ 189s] obs-arm-2 failed "build osmo-hnbgw.spec" at Mon Aug 22 12:24:16 UTC 2022. [ 189s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 year, 9 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 38s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Requires(pre): /bin/sh systemd [ 38s] Requires(post): /bin/sh systemd [ 38s] Requires(preun): /bin/sh systemd [ 38s] Requires(postun): /bin/sh systemd [ 38s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libasn1c.so.1 libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-hnbap.so.0 libosmo-mgcp-client.so.9 libosmo-ranap.so.5 libosmo-rua.so.0 libosmo-sigtran.so.7 libosmocore.so.19 libosmoctrl.so.0 libosmoctrl.so.0(LIBOSMOCTRL_1.0) libosmogsm.so.18 libosmogsm.so.18(LIBOSMOGSM_1.0) libosmonetif.so.8 libosmovty.so.9 libtalloc.so.2 libtalloc.so.2(TALLOC_2.0.2) [ 38s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208220052-1.1.armv7hl [ 38s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208220052-1.1.armv7hl [ 38s] Provides: debuginfo(build-id) = 1d94497fa2e26986f4911c151f87795480c31177 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debuginfo(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Recommends: osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208220052-1.1.arm [ 38s] error: Installed (but unpackaged) file(s) found: [ 38s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 38s] [ 38s] RPM build errors: [ 38s] Installed (but unpackaged) file(s) found: [ 38s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 38s] ### VM INTERACTION START ### [ 38s] [ 32.825060][ T1] sysrq: Power Off [ 38s] [ 32.844010][ T232] reboot: Power down [ 38s] ### VM INTERACTION END ### [ 38s] [ 38s] obs-arm-10 failed "build osmo-hnbgw.spec" at Mon Aug 22 12:19:24 UTC 2022. [ 38s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: don't advance FSM on failed connection request

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 ) Change subject: SIGTRAN: don't advance FSM on failed connection request ...................................................................... SIGTRAN: don't advance FSM on failed connection request Return proper error code from packet encoding routine and check for it before switching FSM state as it creates confusing mismatch with actual protocol state. Related: OS#5579 Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c --- M src/sccp_scoc.c 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index c209bd7..b85eeb9 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -46,6 +46,7 @@ * * use of multiple Routing Contexts in SUA case */ +#include <errno.h> #include <string.h> #include <osmocom/core/utils.h> @@ -687,7 +688,9 @@ return NULL; } -/* generate xua_msg, encode it and send it to SCRC */ +/* generate xua_msg, encode it and send it to SCRC + * returns 0 on success, negative on error + */ static int xua_gen_encode_and_send(struct sccp_connection *conn, uint32_t event, const struct osmo_scu_prim *prim, int msg_type) { @@ -695,7 +698,7 @@ xua = xua_gen_msg_co(conn, event, prim, msg_type); if (!xua) - return -1; + return -ENOMEM; /* amend this with point code information; Many CO msgs * includes neither called nor calling party address! */ @@ -817,6 +820,7 @@ struct osmo_scu_prim *prim = NULL; struct osmo_scu_connect_param *uconp; struct xua_msg *xua = NULL; + int rc; switch (event) { case SCOC_E_SCU_N_CONN_REQ: @@ -827,10 +831,14 @@ conn->calling_addr = uconp->calling_addr; conn->sccp_class = uconp->sccp_class; /* generate + send CR PDU to SCRC */ - xua_gen_encode_and_send(conn, event, prim, SUA_CO_CORE); - /* start connection timer */ - conn_start_connect_timer(conn); - osmo_fsm_inst_state_chg(fi, S_CONN_PEND_OUT, 0, 0); + rc = xua_gen_encode_and_send(conn, event, prim, SUA_CO_CORE); + if (rc < 0) + LOGPFSML(fi, LOGL_ERROR, "Failed to initiate connection: %s\n", strerror(-rc)); + else { + /* start connection timer */ + conn_start_connect_timer(conn); + osmo_fsm_inst_state_chg(fi, S_CONN_PEND_OUT, 0, 0); + } break; #if 0 case SCOC_E_SCU_N_TYPE1_REQ: 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c Gerrit-Change-Number: 29167 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: rpm spec: add osmo-hnbgw-pfcp.cfg

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 ) Change subject: rpm spec: add osmo-hnbgw-pfcp.cfg ...................................................................... rpm spec: add osmo-hnbgw-pfcp.cfg Fix for: Installed (but unpackaged) file(s) found: /usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg Related: OS#5654 Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 --- M contrib/osmo-hnbgw.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 4bc8807..a4379fa 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -90,6 +90,7 @@ %dir %{_docdir}/%{name}/examples %dir %{_docdir}/%{name}/examples/osmo-hnbgw %{_docdir}/%{name}/examples/osmo-hnbgw/osmo-hnbgw.cfg +%{_docdir}/%{name}/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-hnbgw.cfg %{_unitdir}/%{name}.service -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 Gerrit-Change-Number: 29187 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: rpm spec: add osmo-hnbgw-pfcp.cfg

by fixeria

Attention is currently required from: osmith, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 ) Change subject: rpm spec: add osmo-hnbgw-pfcp.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 Gerrit-Change-Number: 29187 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:13:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-deps.sh: use osmo_git_clone_url

by fixeria

Attention is currently required from: osmith, neels, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29191 ) Change subject: scripts/osmo-deps.sh: use osmo_git_clone_url ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa Gerrit-Change-Number: 29191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: Cosmetic: verify new projects on OBS first

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29190 ) Change subject: obs: Cosmetic: verify new projects on OBS first ...................................................................... obs: Cosmetic: verify new projects on OBS first Related: OS#5654 Change-Id: I4a2ebf65de09e08cf3883ae4de9e7e8c952c2182 --- M scripts/obs/lib/config.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 56f1c61..bb8955d 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -37,6 +37,9 @@ # Osmocom projects: generated source packages will depend on a meta package, # such as osmocom-nightly, osmocom-latest or osmocom-2022q1. This meta package # prevents that packages from different feeds are mixed by accident. +# NOTE: Before adding new projects, make sure the rpm and deb build in OBS! +# Test it in your own namespace (home:youruser), see README for +# instructions and/or ask osmith for help. projects_osmocom = [ "erlang/osmo_dia2gsup", "libasn1c", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a2ebf65de09e08cf3883ae4de9e7e8c952c2182 Gerrit-Change-Number: 29190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: disable osmo-upf

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29189 ) Change subject: obs: disable osmo-upf ...................................................................... obs: disable osmo-upf Deb and rpm packages don't build for osmo-upf so disable it again until it is fixed. Related: OS#5655, OS#5654 Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 --- M scripts/obs/lib/config.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 947b722..56f1c61 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -74,7 +74,6 @@ "osmo-sysmon", "osmo-trx", "osmo-uecups", - "osmo-upf", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 Gerrit-Change-Number: 29189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 13: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/f2c78d41_63a4c598 PS12, Line 459: osmo_sccp_conn_id_exists > I'm sorry but I've completely lost track of your though in here. […] My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of adding this new function. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:09:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-deps.sh: use osmo_git_clone_url

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29191 ) Change subject: scripts/osmo-deps.sh: use osmo_git_clone_url ...................................................................... scripts/osmo-deps.sh: use osmo_git_clone_url Instead of hardcoding https://git.osmocom.org for all clones, use the osmo_git_clone_url function. This clones via https from gerrit where possible, it should fix the many errors we are currently seeing from the master-openbsc job: + osmo-deps.sh libosmo-sccp + project=libosmo-sccp + branch=master + git branch -a + grep -c remotes/origin/master$ + [ x1 != x0 ] + branch=origin/master + test -d libosmo-sccp + git clone https://git.osmocom.org/libosmo-sccp libosmo-sccp Cloning into 'libosmo-sccp'... error: HTTP/2 stream 0 was closed cleanly, but before getting all response header fields, treated as error (curl_result = 92, http_code = 0, sha1 = d23e38020fdbb685570145acd3a35e22a5a91344) error: HTTP/2 stream 0 was closed cleanly, but before getting all response header fields, treated as error (curl_result = 92, http_code = 0, sha1 = 68b450098714e3015a65b6628a7e61ac09dd4d47) error: Unable to find 68b450098714e3015a65b6628a7e61ac09dd4d47 under https://git.osmocom.org/libosmo-sccp Cannot obtain needed tree 68b450098714e3015a65b6628a7e61ac09dd4d47 while processing commit d23e38020fdbb685570145acd3a35e22a5a91344. error: fetch failed. Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/… Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa --- M scripts/osmo-deps.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/29191/1 diff --git a/scripts/osmo-deps.sh b/scripts/osmo-deps.sh index af3d555..59ecce0 100755 --- a/scripts/osmo-deps.sh +++ b/scripts/osmo-deps.sh @@ -1,4 +1,5 @@ #!/bin/sh +. "$(dirname "$0")/common.sh" set -ex project="$1" branch="${2:-master}" @@ -8,9 +9,8 @@ fi -if ! test -d "$project"; -then - git clone "https://git.osmocom.org/$project" "$project" +if ! test -d "$project"; then + git clone "$(osmo_git_clone_url "$project")" "$project" fi cd "$project" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa Gerrit-Change-Number: 29191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

Change in osmo-upf[master]: packaging: add missing libnftnl, libnftables deps

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29188 ) Change subject: packaging: add missing libnftnl, libnftables deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I974dd3163e50e6b1a099eac5d5f6a1cac07f44ad Gerrit-Change-Number: 29188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: disable osmo-upf

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29189 ) Change subject: obs: disable osmo-upf ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 Gerrit-Change-Number: 29189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: Cosmetic: verify new projects on OBS first

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29190 ) Change subject: obs: Cosmetic: verify new projects on OBS first ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a2ebf65de09e08cf3883ae4de9e7e8c952c2182 Gerrit-Change-Number: 29190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: neels, fixeria. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 to look at the new patch set (#13). Change subject: SIGTRAN: add function to check connection existence ...................................................................... SIGTRAN: add function to check connection existence Add convenience helper to check if particular connection ID exists and use it to properly report errors when attempting to send messages over non-existent connections. Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c M src/sccp_scoc.c 4 files changed, 36 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/13 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 12: (2 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/f7271048_33e03579 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > I agree with Neels that doing "int a = ..., rc;" hides definition of rc. […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/d432aad6_5e08f6f2 PS12, Line 459: osmo_sccp_conn_id_exists > So this function basically converts the result of conn_find_by_id() to boolean. […] I'm sorry but I've completely lost track of your though in here. We need boolean value but instead of writing function which gives it we should expose another function which doesn't because new symbol? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:00:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: disable osmo-upf

by fixeria

Attention is currently required from: osmith, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29189 ) Change subject: obs: disable osmo-upf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 Gerrit-Change-Number: 29189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:00:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in osmo-upf[master]: debian: add missing deps

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29142 ) Change subject: debian: add missing deps ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b Gerrit-Change-Number: 29142 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: Bump version: 0.1.0.32-823b → 0.1.1

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 ) Change subject: Bump version: 0.1.0.32-823b → 0.1.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b Gerrit-Change-Number: 29186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 11:58:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 11:58:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 11:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2024

2023

2022

gerrit-log August 2022