Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper
Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 3: (4 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3246d21f_86c3c4d5 PS1, Line 97:
I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […] Done
File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/02318179_c4a28f71 PS2, Line 97: [DATA]
You forgot to add documentation an optional parameter: […] Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/f0e77100_09142d00 PS2, Line 103: argv[1]
Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […] Indeed. Actually, I think it's better to skip the data variable altogether - see next revision.
I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant. File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/0b2c5208_cd72b691 PS2, Line 48:
Really weird alignment making it rather harder to read. Tab-size should be 8. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
msuraev