Attention is currently required from: laforge, fixeria.
4 comments:
File examples/sccp_test_vty.c:
I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […]
Done
File examples/sccp_test_vty.c:
Patch Set #2, Line 97: [DATA]
You forgot to add documentation an optional parameter: […]
Done
Patch Set #2, Line 103: argv[1]
Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […]
Indeed. Actually, I think it's better to skip the data variable altogether - see next revision.
I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant.
File include/osmocom/sigtran/sccp_helpers.h:
Really weird alignment making it rather harder to read. Tab-size should be 8.
Done
To view, visit change 29170. To unsubscribe, or for help writing mail filters, visit settings.