July 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_31_102: Fix EF_EPSLOCI argument ordering

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28711 ) Change subject: ts_31_102: Fix EF_EPSLOCI argument ordering ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9acee757f096fef0d8bacbec3b52f56267cd52f6 Gerrit-Change-Number: 28711 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:03:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in pysim[master]: filesystem: Use Tuple for record length

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28710 ) Change subject: filesystem: Use Tuple for record length ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I470f4e69c83cb2761861b3350bf8d49e31f4d957 Gerrit-Change-Number: 28710 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in pysim[master]: filesystem: Use Tuple for transparent file size

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28709 ) Change subject: filesystem: Use Tuple for transparent file size ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I553616f8c6c4aaa8f635b3d7d94e8e8f49ed5a56 Gerrit-Change-Number: 28709 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:01:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in pysim[master]: introduce fully_qualified_path_str() method

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28684 ) Change subject: introduce fully_qualified_path_str() method ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e9bfb425c3a3fade13ca4ccd2b891a0c21ed56d Gerrit-Change-Number: 28684 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28715 ) Change subject: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() ...................................................................... cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() As the naming suggests, install_lib_element[_ve]() should be used for commands registered by libraries. This API allows to enforce some rules for command attribute letters and should not be used by application specific commands. Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 --- M src/cbc_vty.c 1 file changed, 23 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/15/28715/1 diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 9f2c073..36d646d 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -671,38 +671,38 @@ void cbc_vty_init(void) { - install_lib_element_ve(&show_peers_cmd); - install_lib_element_ve(&show_message_cbs_cmd); - install_lib_element_ve(&show_messages_cbs_cmd); - install_lib_element_ve(&show_messages_etws_cmd); + install_element_ve(&show_peers_cmd); + install_element_ve(&show_message_cbs_cmd); + install_element_ve(&show_messages_cbs_cmd); + install_element_ve(&show_messages_etws_cmd); - install_lib_element(CONFIG_NODE, &cfg_cbc_cmd); + install_element(CONFIG_NODE, &cfg_cbc_cmd); install_node(&cbc_node, config_write_cbc); - install_lib_element(CBC_NODE, &cfg_permit_unknown_peers_cmd); + install_element(CBC_NODE, &cfg_permit_unknown_peers_cmd); - install_lib_element(CBC_NODE, &cfg_cbsp_cmd); + install_element(CBC_NODE, &cfg_cbsp_cmd); install_node(&cbsp_node, NULL); - install_lib_element(CBSP_NODE, &cfg_cbsp_local_ip_cmd); - install_lib_element(CBSP_NODE, &cfg_cbsp_local_port_cmd); + install_element(CBSP_NODE, &cfg_cbsp_local_ip_cmd); + install_element(CBSP_NODE, &cfg_cbsp_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_ecbe_cmd); + install_element(CBC_NODE, &cfg_ecbe_cmd); install_node(&ecbe_node, NULL); - install_lib_element(ECBE_NODE, &cfg_ecbe_local_ip_cmd); - install_lib_element(ECBE_NODE, &cfg_ecbe_local_port_cmd); + install_element(ECBE_NODE, &cfg_ecbe_local_ip_cmd); + install_element(ECBE_NODE, &cfg_ecbe_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_sbcap_cmd); + install_element(CBC_NODE, &cfg_sbcap_cmd); install_node(&sbcap_node, NULL); - install_lib_element(SBcAP_NODE, &cfg_sbcap_local_ip_cmd); - install_lib_element(SBcAP_NODE, &cfg_sbcap_no_local_ip_cmd); - install_lib_element(SBcAP_NODE, &cfg_sbcap_local_port_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_local_ip_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_no_local_ip_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_cbc_peer_cmd); - install_lib_element(CBC_NODE, &cfg_cbc_no_peer_cmd); + install_element(CBC_NODE, &cfg_cbc_peer_cmd); + install_element(CBC_NODE, &cfg_cbc_no_peer_cmd); install_node(&peer_node, NULL); - install_lib_element(PEER_NODE, &cfg_peer_proto_cmd); - install_lib_element(PEER_NODE, &cfg_peer_remote_port_cmd); - install_lib_element(PEER_NODE, &cfg_peer_no_remote_port_cmd); - install_lib_element(PEER_NODE, &cfg_peer_remote_ip_cmd); - install_lib_element(PEER_NODE, &cfg_peer_no_remote_ip_cmd); + install_element(PEER_NODE, &cfg_peer_proto_cmd); + install_element(PEER_NODE, &cfg_peer_remote_port_cmd); + install_element(PEER_NODE, &cfg_peer_no_remote_port_cmd); + install_element(PEER_NODE, &cfg_peer_remote_ip_cmd); + install_element(PEER_NODE, &cfg_peer_no_remote_ip_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 Gerrit-Change-Number: 28715 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc_vty: write peer config nodes at the end

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28713 ) Change subject: cbc_vty: write peer config nodes at the end ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I7623ea5874552e57764327e94a9c3a4de7b71d67 Gerrit-Change-Number: 28713 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:32:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Refactor {cbsp,sbcap}_cbc_accept_cb

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28712 ) Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Patch Set 1: (2 comments) File src/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/2d4b9c36_c630a80a PS1, Line 181: talloc_free(link); Don't we need to do: llist_del(&link->list); osmo_fsm_inst_free(link->fi); before talloc_free()? File src/sbcap_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/c7c5a564_42769c67 PS1, Line 209: talloc_free(link); Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Reorder osmo-cbc.cfg nodes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28714 ) Change subject: ttcn3-cbc: Reorder osmo-cbc.cfg nodes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/28714/comment/8e505ee3_8df… PS1, Line 9: This is the new expected working order. > What do you mean by "the new expected order"? […] Ah, I see the related commit now. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia6f9cb6ac5935b8253521a6bfe11e6905e77523d Gerrit-Change-Number: 28714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Reorder osmo-cbc.cfg nodes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28714 ) Change subject: ttcn3-cbc: Reorder osmo-cbc.cfg nodes ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/28714/comment/19852954_224… PS1, Line 9: This is the new expected working order. What do you mean by "the new expected order"? I guess the order in which recent osmo-cbc generates running-config? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia6f9cb6ac5935b8253521a6bfe11e6905e77523d Gerrit-Change-Number: 28714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 17:21:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Reorder osmo-cbc.cfg nodes

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28714 ) Change subject: ttcn3-cbc: Reorder osmo-cbc.cfg nodes ...................................................................... ttcn3-cbc: Reorder osmo-cbc.cfg nodes This is the new expected working order. Related: osmo-cbc.git I7623ea5874552e57764327e94a9c3a4de7b71d67 Change-Id: Ia6f9cb6ac5935b8253521a6bfe11e6905e77523d --- M ttcn3-cbc-test/osmo-cbc.cfg 1 file changed, 9 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/14/28714/1 diff --git a/ttcn3-cbc-test/osmo-cbc.cfg b/ttcn3-cbc-test/osmo-cbc.cfg index 2c4721b..4332812 100644 --- a/ttcn3-cbc-test/osmo-cbc.cfg +++ b/ttcn3-cbc-test/osmo-cbc.cfg @@ -1,7 +1,4 @@ ! -! OsmoCBC (0.1.0.5-e88e) configuration saved from vty -!! -! log gsmtap 172.18.27.100 logging level set-all debug logging filter all 1 @@ -25,6 +22,15 @@ ! cbc unknown-peers reject + ecbe + local-ip 172.18.27.20 + local-port 12345 + cbsp + local-ip 172.18.27.20 + local-port 48049 + sbcap + local-ip 172.18.27.20 + local-port 29168 peer ttcn3-bsc protocol cbsp remote-port 9999 @@ -33,12 +39,3 @@ protocol sbcap remote-port 9998 remote-ip 172.18.27.100 - cbsp - local-ip 172.18.27.20 - local-port 48049 - sbcap - local-ip 172.18.27.20 - local-port 29168 - ecbe - local-ip 172.18.27.20 - local-port 12345 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia6f9cb6ac5935b8253521a6bfe11e6905e77523d Gerrit-Change-Number: 28714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022