July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Avoid changing peer's protocol once set

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28718 ) Change subject: Avoid changing peer's protocol once set ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @laforge I'm not really happy about the fact that "protocol" needs to be set under the node as a command, there's no good way to prevent it from not being set. It'd be great to have that set at creation time of the peer, so I propse: * adding a new "peer proto NAME" cmd * deprecating "peer NAME" (translate to "peer cbsp NAME" internally, for older release compat). * deprecating VTY cmd "protocol (cbsp|sbcap)" (make it a NO-OP) And of course not merging this commit as it is when applying the above. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I47756dddd8f9b8450ba14c914614fd2391d5486e Gerrit-Change-Number: 28718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Jul 2022 20:01:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Avoid changing peer's protocol once set

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28718 ) Change subject: Avoid changing peer's protocol once set ...................................................................... Avoid changing peer's protocol once set Let's explicitly not support this feature, since it makes code a lot more complex for no good reason. If a peer is created/confgiured with a given protocol, it should be kept forever. If the user wants to change the protocol, she can do so by removign the peer and re-adding it through the VTY. Ideally the protocol would be in the "peer" VTY command, but it's given as a separate command under its now, which makes stuff a bit more difficult to handle in code. Change-Id: I47756dddd8f9b8450ba14c914614fd2391d5486e --- M include/osmocom/cbc/cbc_peer.h M include/osmocom/cbc/debug.h M src/cbc_main.c M src/cbc_peer.c M src/cbc_vty.c M src/cbsp_link.c M src/sbcap_link.c 7 files changed, 47 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/18/28718/1 diff --git a/include/osmocom/cbc/cbc_peer.h b/include/osmocom/cbc/cbc_peer.h index 785ea09..bc1ae6a 100644 --- a/include/osmocom/cbc/cbc_peer.h +++ b/include/osmocom/cbc/cbc_peer.h @@ -14,6 +14,7 @@ *********************************************************************************/ enum cbc_peer_protocol { + CBC_PEER_PROTO_UNSET, CBC_PEER_PROTO_CBSP, CBC_PEER_PROTO_SABP, CBC_PEER_PROTO_SBcAP @@ -38,7 +39,8 @@ extern const struct value_string cbc_peer_proto_name[]; -struct cbc_peer *cbc_peer_create(const char *name, enum cbc_peer_protocol proto); +struct cbc_peer *cbc_peer_create(const char *name); +int cbc_peer_set_proto(struct cbc_peer *peer, enum cbc_peer_protocol proto); void cbc_peer_remove(struct cbc_peer *peer); struct cbc_peer *cbc_peer_by_name(const char *name); diff --git a/include/osmocom/cbc/debug.h b/include/osmocom/cbc/debug.h index 1ec0a8e..025419e 100644 --- a/include/osmocom/cbc/debug.h +++ b/include/osmocom/cbc/debug.h @@ -1,6 +1,7 @@ #pragma once enum { + DMAIN, DCBSP, DSBcAP, DREST, diff --git a/src/cbc_main.c b/src/cbc_main.c index a670722..836982a 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -55,6 +55,13 @@ struct cbc *g_cbc; static const struct log_info_cat log_info_cat[] = { + [DMAIN] = { + .name = "DMAIN", + .description = "Main logging category", + .color = "\033[1;30m", + .enabled = 1, + .loglevel = LOGL_NOTICE, + }, [DCBSP] = { .name = "DCBSP", .description = "Cell Broadcast Service Protocol (CBC-BSC)", diff --git a/src/cbc_peer.c b/src/cbc_peer.c index e8b79f9..d130c52 100644 --- a/src/cbc_peer.c +++ b/src/cbc_peer.c @@ -32,8 +32,10 @@ #include <osmocom/cbc/cbc_peer.h> #include <osmocom/cbc/cbsp_link.h> #include <osmocom/cbc/sbcap_link.h> +#include <osmocom/cbc/debug.h> const struct value_string cbc_peer_proto_name[] = { + { CBC_PEER_PROTO_UNSET, "UNSET" }, { CBC_PEER_PROTO_CBSP, "CBSP" }, { CBC_PEER_PROTO_SABP, "SABP" }, { CBC_PEER_PROTO_SBcAP, "SBc-AP" }, @@ -41,7 +43,7 @@ }; /* create a new cbc_peer */ -struct cbc_peer *cbc_peer_create(const char *name, enum cbc_peer_protocol proto) +struct cbc_peer *cbc_peer_create(const char *name) { struct cbc_peer *peer; if (name && cbc_peer_by_name(name)) @@ -51,13 +53,27 @@ if (!peer) return NULL; - peer->proto = proto; peer->name = talloc_strdup(peer, name); llist_add_tail(&peer->list, &g_cbc->peers); return peer; } +int cbc_peer_set_proto(struct cbc_peer *peer, enum cbc_peer_protocol proto) +{ + OSMO_ASSERT(proto != CBC_PEER_PROTO_UNSET); + if (peer->proto != CBC_PEER_PROTO_UNSET && peer->proto != proto) { + LOGP(DMAIN, LOGL_ERROR, + "Cannot set new protocol %s on peer with already assigned protocol %s. " + "The peer must be re-created.\n", + get_value_string(cbc_peer_proto_name, proto), + get_value_string(cbc_peer_proto_name, peer->proto)); + return -EINVAL; + } + peer->proto = proto; + return 0; +} + /* remove a cbc_peer */ void cbc_peer_remove(struct cbc_peer *peer) { diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 36d646d..aea1ceb 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -38,6 +38,7 @@ #include <osmocom/cbc/sbcap_link.h> static const struct value_string cbc_peer_proto_name_vty[] = { + { CBC_PEER_PROTO_UNSET, "unset" }, { CBC_PEER_PROTO_CBSP, "cbsp" }, { CBC_PEER_PROTO_SABP, "sabp" }, { CBC_PEER_PROTO_SBcAP, "sbcap" }, @@ -52,6 +53,8 @@ unsigned int i; switch (peer->proto) { + case CBC_PEER_PROTO_UNSET: + break; case CBC_PEER_PROTO_CBSP: if (peer->link.cbsp) state = osmo_fsm_inst_state_name(peer->link.cbsp->fi); @@ -528,7 +531,7 @@ peer = cbc_peer_by_name(argv[0]); if (!peer) - peer = cbc_peer_create(argv[0], CBC_PEER_PROTO_CBSP); + peer = cbc_peer_create(argv[0]); if (!peer) return CMD_WARNING; @@ -560,7 +563,16 @@ "Cell Broadcast Service Protocol (GSM)\n") { struct cbc_peer *peer = (struct cbc_peer *) vty->index; - peer->proto = get_string_value(cbc_peer_proto_name_vty, argv[0]); + enum cbc_peer_protocol proto = get_string_value(cbc_peer_proto_name_vty, argv[0]); + int rc = cbc_peer_set_proto(peer, proto); + if (rc < 0) { + vty_out(vty, "%% Cannot set new protocol %s on peer with already assigned protocol %s. " + "The peer must be re-created.%s", + get_value_string(cbc_peer_proto_name, proto), + get_value_string(cbc_peer_proto_name, peer->proto), + VTY_NEWLINE); + return CMD_WARNING; + } return CMD_SUCCESS; } diff --git a/src/cbsp_link.c b/src/cbsp_link.c index cd1c308..9f94a00 100644 --- a/src/cbsp_link.c +++ b/src/cbsp_link.c @@ -167,8 +167,9 @@ } LOGP(DCBSP, LOGL_NOTICE, "Accepting unknown CBSP peer %s:%d\n", remote_ip, remote_port); - peer = cbc_peer_create(NULL, CBC_PEER_PROTO_CBSP); + peer = cbc_peer_create(NULL); OSMO_ASSERT(peer); + OSMO_ASSERT(cbc_peer_set_proto(peer, CBC_PEER_PROTO_CBSP) == 0); peer->unknown_dynamic_peer = true; } if (peer->link.cbsp) { diff --git a/src/sbcap_link.c b/src/sbcap_link.c index 9194509..d6aba7e 100644 --- a/src/sbcap_link.c +++ b/src/sbcap_link.c @@ -195,8 +195,9 @@ } LOGP(DSBcAP, LOGL_NOTICE, "Accepting unknown SBc-AP peer %s:%d\n", remote_ip, remote_port); - peer = cbc_peer_create(NULL, CBC_PEER_PROTO_SBcAP); + peer = cbc_peer_create(NULL); OSMO_ASSERT(peer); + OSMO_ASSERT(cbc_peer_set_proto(peer, CBC_PEER_PROTO_SBcAP) == 0); peer->unknown_dynamic_peer = true; } if (peer->link.sbcap) { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I47756dddd8f9b8450ba14c914614fd2391d5486e Gerrit-Change-Number: 28718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Fix cbc_vty_go_parent() not being called

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28717 ) Change subject: Fix cbc_vty_go_parent() not being called ...................................................................... Fix cbc_vty_go_parent() not being called Change-Id: I946c503f5a40eafbee6e7fa359781548b74e45a6 --- M src/cbc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/17/28717/1 diff --git a/src/cbc_main.c b/src/cbc_main.c index f136ace..a670722 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -116,7 +116,6 @@ .copyright = cbc_copyright, .go_parent_cb = cbc_vty_go_parent, .version = PACKAGE_VERSION, - .go_parent_cb = NULL, .is_config_node = NULL, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I946c503f5a40eafbee6e7fa359781548b74e45a6 Gerrit-Change-Number: 28717 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Make cbsp,sbcap mgr available in data model

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28716 ) Change subject: Make cbsp,sbcap mgr available in data model ...................................................................... Make cbsp,sbcap mgr available in data model Change-Id: I60c3ded80c38bcf50b831c6e9db719a8d2cba5b1 --- M include/osmocom/cbc/cbc_data.h M src/cbc_main.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/16/28716/1 diff --git a/include/osmocom/cbc/cbc_data.h b/include/osmocom/cbc/cbc_data.h index 16861e7..d96e5ca 100644 --- a/include/osmocom/cbc/cbc_data.h +++ b/include/osmocom/cbc/cbc_data.h @@ -42,6 +42,8 @@ /********************************************************************************* * CBC itself *********************************************************************************/ +struct cbc_cbsp_mgr; +struct cbc_sbcap_mgr; struct cbc { struct { @@ -61,6 +63,13 @@ } ecbe; } config; + struct { + struct cbc_cbsp_mgr *mgr; + } cbsp; + struct { + struct cbc_sbcap_mgr *mgr; + } sbcap; + struct llist_head messages; /* cbc_message.list */ struct llist_head expired_messages; /* cbc_message.list */ struct llist_head peers; /* cbc_peer.list */ diff --git a/src/cbc_main.c b/src/cbc_main.c index dcc1725..f136ace 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -277,12 +277,12 @@ exit(1); } - if (cbc_cbsp_mgr_create(tall_cbc_ctx) == NULL) { + if (!(g_cbc->cbsp.mgr = cbc_cbsp_mgr_create(tall_cbc_ctx))) { perror("Error binding CBSP port"); exit(1); } - if (cbc_sbcap_mgr_create(tall_cbc_ctx) == NULL) { + if (!(g_cbc->sbcap.mgr = cbc_sbcap_mgr_create(tall_cbc_ctx))) { perror("Error binding SBc-AP port\n"); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I60c3ded80c38bcf50b831c6e9db719a8d2cba5b1 Gerrit-Change-Number: 28716 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Refactor {cbsp,sbcap}_cbc_accept_cb

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28712 ) Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/509a3bda_89fa9f01 PS1, Line 181: talloc_free(link); > Don't we need to do: […] Done File src/sbcap_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28712/comment/c2134bbe_b6f864ba PS1, Line 209: talloc_free(link); > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:35:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Refactor {cbsp,sbcap}_cbc_accept_cb

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 to look at the new patch set (#3). Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Refactor {cbsp,sbcap}_cbc_accept_cb Delay allocating the structures until really needed. First do checks agains the opened connection, and if an issue is detected simply close the fd. Next, fetch or allocate the related peer. Finally, create the link from the fd. This makes it easier to add early extra checks later when peers will contain info on link_mode (client|server|disabled) later on. Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 --- M include/osmocom/cbc/cbsp_link.h M include/osmocom/cbc/sbcap_link.h M src/cbsp_link.c M src/cbsp_link_fsm.c M src/sbcap_link.c M src/sbcap_link_fsm.c 6 files changed, 139 insertions(+), 80 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/12/28712/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]()

by pespin

Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28715 ) Change subject: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 Gerrit-Change-Number: 28715 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:28:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Refactor {cbsp,sbcap}_cbc_accept_cb

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 to look at the new patch set (#2). Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Refactor {cbsp,sbcap}_cbc_accept_cb Delay allocating the structures until really needed. First do checks agains the opened connection, and if an issue is detected simply close the fd. Next, fetch or allocate the related peer. Finally, create the link from the fd. This makes it easier to add early extra checks later when peers will contain info on link_mode (client|server|disabled) later on. Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 --- M include/osmocom/cbc/cbsp_link.h M include/osmocom/cbc/sbcap_link.h M src/cbsp_link.c M src/cbsp_link_fsm.c M src/sbcap_link.c M src/sbcap_link_fsm.c 6 files changed, 139 insertions(+), 80 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/12/28712/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: add some comments in upf_gtp.c

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28707 ) Change subject: add some comments in upf_gtp.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I58f86cd84207a74e078ae4758bbed76bb1595d95 Gerrit-Change-Number: 28707 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:06:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: constify local var in upf_gtp.c

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28708 ) Change subject: constify local var in upf_gtp.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I08085a6e777175b97b9c32d4c302c9863c6f6f59 Gerrit-Change-Number: 28708 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Jul 2022 18:05:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022