July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: cbc-apitool: Fix port stored in var as a string

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28737 ) Change subject: cbc-apitool: Fix port stored in var as a string ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ief688bb8c2a6cfa410608a6896ce3cb5df4eb48e Gerrit-Change-Number: 28737 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:34:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Split cbsp/sbcap server socket creation from struct allocation

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28736 ) Change subject: Split cbsp/sbcap server socket creation from struct allocation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I14e49d8d2e603925d7f06a7edb710c0eceb02ea3 Gerrit-Change-Number: 28736 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:34:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc-apitool: print usage instead of crashing if no subcmd passed

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28738 ) Change subject: cbc-apitool: print usage instead of crashing if no subcmd passed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ia8d13beeb8da64644d1aaf36deeddda4de889a6c Gerrit-Change-Number: 28738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:33:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Fix encoding of Warning-Type

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28740 ) Change subject: sbcap: Fix encoding of Warning-Type ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9f6a0779c20ba86962aaaebc9b40ad162d2f2f3e Gerrit-Change-Number: 28740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Jul 2022 08:32:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-cbc in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-cbc failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 440s] [494/503] installing glib-networking-2.66.0-2 [ 440s] Processing triggers for libglib2.0-0:armhf (2.66.8-1) ... [ 440s] [495/503] installing libsoup2.4-1-2.72.0-2 [ 440s] [496/503] installing libsoup-gnome2.4-1-2.72.0-2 [ 441s] [497/503] installing librest-0.7-0-0.8.1-1.1 [ 441s] [498/503] installing libgtk-3-0-3.24.24-4+deb11u2 [ 442s] [499/503] installing libgtkspell3-3-0-3.0.10-1 [ 443s] [500/503] installing libgdl-3-5-3.34.0-1 [ 443s] [501/503] installing libgtkmm-3.0-1v5-3.24.2-2 [ 444s] [502/503] installing inkscape-1.0.2-4 [ 457s] [503/503] installing osmo-gsm-manuals-dev-1.3.0.202207220052 [ 457s] configuring all installed packages... [ 457s] Processing triggers for hicolor-icon-theme (0.17-2) ... [ 457s] Processing triggers for dictionaries-common (1.28.4) ... [ 458s] Processing triggers for libc-bin (2.31-13+rpi1+deb11u3) ... [ 458s] Processing triggers for man-db (2.9.4-2) ... [ 458s] Not building database; man-db/auto-update is not 'true'. [ 458s] Processing triggers for tex-common (6.16) ... [ 459s] Running mktexlsr. This may take some time... done. [ 461s] Running updmap-sys. This may take some time... done. [ 461s] Running mktexlsr /var/lib/texmf ... done. [ 462s] Building format(s) --all. Job seems to be stuck here, killed. (after 28800 seconds of inactivity) [29270s] This may take some time... qemu-system-aarch64: terminating on signal 15 from pid 26754 (<unknown process>) [29271s] ### VM INTERACTION END ### [29271s] No buildstatus set, either the base system is broken (kernel/initrd/udev/glibc/bash/perl) [29271s] or the build host has a kernel or hardware problem... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Adapt osmo-cbc 'peer' node to new format

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28733 ) Change subject: ttcn3-cbc: Adapt osmo-cbc 'peer' node to new format ...................................................................... ttcn3-cbc: Adapt osmo-cbc 'peer' node to new format Requires: osmo-cbc.git Change-Id I47756dddd8f9b8450ba14c914614fd2391d5486e Change-Id: I3654acdf4b68886133af7f418726903f3fee57eb --- M ttcn3-cbc-test/osmo-cbc.cfg 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Objections: fixeria: I would prefer this is not merged as is diff --git a/ttcn3-cbc-test/osmo-cbc.cfg b/ttcn3-cbc-test/osmo-cbc.cfg index 4332812..0e131c0 100644 --- a/ttcn3-cbc-test/osmo-cbc.cfg +++ b/ttcn3-cbc-test/osmo-cbc.cfg @@ -31,11 +31,9 @@ sbcap local-ip 172.18.27.20 local-port 29168 - peer ttcn3-bsc - protocol cbsp + peer cbsp ttcn3-bsc remote-port 9999 remote-ip 172.18.27.100 - peer ttcn3-mme - protocol sbcap + peer sbcap ttcn3-mme remote-port 9998 remote-ip 172.18.27.100 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3654acdf4b68886133af7f418726903f3fee57eb Gerrit-Change-Number: 28733 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Adapt osmo-cbc 'peer' node to new format

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28733 ) Change subject: ttcn3-cbc: Adapt osmo-cbc 'peer' node to new format ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging in order to avoid ttcn3-bc-master test case failures. This not really breaking anything, it was already broken, so at least fixes master. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3654acdf4b68886133af7f418726903f3fee57eb Gerrit-Change-Number: 28733 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 17:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Fix encoding of Warning-Type

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28740 ) Change subject: sbcap: Fix encoding of Warning-Type ...................................................................... sbcap: Fix encoding of Warning-Type Change-Id: I9f6a0779c20ba86962aaaebc9b40ad162d2f2f3e --- M src/sbcap_msg.c M tests/sbcap/sbcap_test.c M tests/sbcap/sbcap_test.ok 3 files changed, 8 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/40/28740/1 diff --git a/src/sbcap_msg.c b/src/sbcap_msg.c index d38f861..7dc3410 100644 --- a/src/sbcap_msg.c +++ b/src/sbcap_msg.c @@ -84,7 +84,6 @@ const struct smscb_message *smscb = &cbcmsg->msg; SBcAP_SBC_AP_PDU_t *pdu; SBcAP_Write_Replace_Warning_Request_IEs_t *ie; - uint16_t ie_warning_type; unsigned int i; uint8_t *ptr; #if 0 @@ -150,17 +149,15 @@ if (smscb->is_etws) { /* Warning Type, 3GPP TS 36.413 sec 9.2.1.50: */ - ie_warning_type = smscb->etws.warning_type; - if (smscb->etws.user_alert) - ie_warning_type |= 0x0100; - if (smscb->etws.popup_on_display) - ie_warning_type |= 0x0080; /* static const long asn_VAL_8_SBcAP_id_Warning_Type = 18; */ ie = sbcap_alloc_Write_Replace_Warning_Request_IE(18, SBcAP_Criticality_ignore, SBcAP_Write_Replace_Warning_Request_IEs__value_PR_Warning_Type); - ie->value.choice.Warning_Type.buf = MALLOC(sizeof(ie_warning_type)); - ie->value.choice.Warning_Type.size = sizeof(ie_warning_type); - memcpy(ie->value.choice.Warning_Type.buf, &ie_warning_type, sizeof(ie_warning_type)); + ie->value.choice.Warning_Type.buf = MALLOC(2); + ie->value.choice.Warning_Type.size = 2; + ie->value.choice.Warning_Type.buf[0] = ((smscb->etws.warning_type & 0x7f) << 1); + if (smscb->etws.user_alert) + ie->value.choice.Warning_Type.buf[0] |= 0x01; + ie->value.choice.Warning_Type.buf[1] = (smscb->etws.popup_on_display) ? 0x80 : 0x0; ASN_SEQUENCE_ADD(as_pdu, ie); /* Warning Security Information, 3GPP TS 36.413 sec 9.2.1.51: */ diff --git a/tests/sbcap/sbcap_test.c b/tests/sbcap/sbcap_test.c index 747d0b2..9c8a60f 100644 --- a/tests/sbcap/sbcap_test.c +++ b/tests/sbcap/sbcap_test.c @@ -14,7 +14,7 @@ struct msgb *msg; SBcAP_SBC_AP_PDU_t *pdu; SBcAP_Write_Replace_Warning_Request_IEs_t *ie; - uint16_t ie_warning_type = 0x01; + uint8_t ie_warning_type[2] = {(0x01 << 1) | 0x01, 0x80}; uint8_t ie_dcs = 2; uint8_t ie_warning_sec_info[50] = {0x30, 0x40, 0x12, 0x23, 0x45}; uint8_t ie_warning_msg_content[SBCAP_WARN_MSG_CONTENTS_IE_MAX_LEN] = {0x30, 0x40, 0x12, 0x23, 0x45}; @@ -68,8 +68,6 @@ SBcAP_Write_Replace_Warning_Request_IEs__value_PR_Warning_Type); ie->value.choice.Warning_Type.buf = MALLOC(sizeof(ie_warning_type)); ie->value.choice.Warning_Type.size = sizeof(ie_warning_type); - ie_warning_type |= 0x0100; - ie_warning_type |= 0x0080; memcpy(ie->value.choice.Warning_Type.buf, &ie_warning_type, sizeof(ie_warning_type)); ASN_SEQUENCE_ADD(as_pdu, ie); diff --git a/tests/sbcap/sbcap_test.ok b/tests/sbcap/sbcap_test.ok index b67583a..e679721 100644 --- a/tests/sbcap/sbcap_test.ok +++ b/tests/sbcap/sbcap_test.ok @@ -1,5 +1,5 @@ ==== test_asn1c_enc ==== -Encoded message: 00 00 00 76 00 00 08 00 05 00 02 ab 01 00 0b 00 02 ab cd 00 0a 00 02 00 1e 00 07 00 02 00 59 00 12 40 02 81 01 00 11 40 32 30 40 12 23 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 40 01 02 00 10 40 16 00 13 30 40 12 23 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +Encoded message: 00 00 00 76 00 00 08 00 05 00 02 ab 01 00 0b 00 02 ab cd 00 0a 00 02 00 1e 00 07 00 02 00 59 00 12 40 02 03 80 00 11 40 32 30 40 12 23 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 40 01 02 00 10 40 16 00 13 30 40 12 23 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ==== test_asn1c_dec ==== Decoding message: 20 00 00 14 00 00 03 00 05 00 02 00 2b 00 0b 00 02 41 70 00 01 00 01 00 Decoded message successfully -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9f6a0779c20ba86962aaaebc9b40ad162d2f2f3e Gerrit-Change-Number: 28740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm_23_041.h: Document CBS ETWS Warning Type values

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28739 to look at the new patch set (#3). Change subject: gsm_23_041.h: Document CBS ETWS Warning Type values ...................................................................... gsm_23_041.h: Document CBS ETWS Warning Type values Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 --- M include/osmocom/gsm/protocol/gsm_23_041.h 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/28739/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 Gerrit-Change-Number: 28739 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm_23_041.h: Document CBS ETWS Warning Type values

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28739 to look at the new patch set (#2). Change subject: gsm_23_041.h: Document CBS ETWS Warning Type values ...................................................................... gsm_23_041.h: Document CBS ETWS Warning Type values Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 --- M include/osmocom/gsm/protocol/gsm_23_041.h 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/28739/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5bb9b2c77b8e4a984631d199fc073183691c31 Gerrit-Change-Number: 28739 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022