Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 )
Change subject: Introduce APDU/TPDU trace decoder
......................................................................
Patch Set 5:
(1 comment)
File pySim/apdu/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/28725/comment/3db18ae0_2eabaeb7
PS5, Line 70: cmd
> rsp?
nice catch. Didn't show up as you usually have either str for both cmd/rsp or bytes.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a
Gerrit-Change-Number: 28725
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Jul 2022 10:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, dexter.
Hello Jenkins Builder, fixeria, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/28725
to look at the new patch set (#6).
Change subject: Introduce APDU/TPDU trace decoder
......................................................................
Introduce APDU/TPDU trace decoder
This introduces a new pySim.apdu module hierarchy, which contains
classes that represent TPDU/APDUs as exchanged between
SIM/UICC/USIM/ISIM card and UE.
It contains instruction level decoders for SELECT, READ BINARY and
friends, and then uses the pySim.filesystem.Runtime{Lchan,State} classes
to keep track of the currently selected EF/DF/ADF for each logical
channel, and uses the file-specific decoder classes of pySim to decode
the actual file content that is being read or written.
This provides a much more meaningful decode of protocol traces than
wireshark will ever be able to give us.
Furthermore, there's the new pySim.apdu_source set of classes which
provides "input plugins" for obtaining APDU traces in a variety of
formats. So far, GSMTAP UDP live capture and pyshark based RSPRO
live and pcap file reading are imlpemented.
Change-Id: I862d93163d495a294364168f7818641e47b18c0a
Closes: OS#5126
---
M README.md
M contrib/jenkins.sh
A pySim-trace.py
A pySim/apdu/__init__.py
A pySim/apdu/global_platform.py
A pySim/apdu/ts_102_221.py
A pySim/apdu/ts_31_102.py
A pySim/apdu_source/__init__.py
A pySim/apdu_source/gsmtap.py
A pySim/apdu_source/pyshark_rspro.py
A pySim/gsmtap.py
M pySim/ts_31_102.py
M requirements.txt
M setup.py
A tests/test_apdu.py
15 files changed, 1,855 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/28725/6
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a
Gerrit-Change-Number: 28725
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/28735
to look at the new patch set (#2).
Change subject: sysmocom_sja2: Prevent KeyError/None exception on encode
......................................................................
sysmocom_sja2: Prevent KeyError/None exception on encode
Fix a bug in the pySim.sysmocom_sja2 module, where we defined unnamed
bits in BitStruct without a default value causing exceptions like this:
EXCEPTION of type 'KeyError' occurred with message: 'None'
Change-Id: Ib2da5adda4fae374ab14bb8100f338691aef719a
Closes: OS#5575
---
M pySim/sysmocom_sja2.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/28735/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28735
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib2da5adda4fae374ab14bb8100f338691aef719a
Gerrit-Change-Number: 28735
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28732 )
Change subject: Support CBSP/TCP and SBc-AP/SCTP client mode
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/cbc_vty.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/6171e010_ddb5e89b
PS3, Line 596: DEFUN
I would suggest using DEFUN_ATTR with CMD_ATTR_NODE_EXIT here and in other commands to inform the user that changes are applied on node exit. Can be done later though.
File src/cbsp_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/b8b5049a_26b0faa1
PS3, Line 286: CBC_PEER_LINK_MODE_CLIENT
Just wondering: how is it possible? Getting a client connection in client mode...
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I3ec54b615b41b56f7a9c64298e3fcaac37f4b60e
Gerrit-Change-Number: 28732
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Jul 2022 08:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment