Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 )
Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/host/trxcon/include/osmocom/bb/l1sched/logging.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/d45d2124_83920500
PS4, Line 3: extern int l1sched_log_cat_common;
This probably needs to go into an internal header.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429
Gerrit-Change-Number: 28744
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Jul 2022 17:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28792 )
Change subject: fixup! trxcon: make l1sched logging configurable, use trxcon->fi as prefix
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9efe808a2c96b1e16a76a488dbbb85f2f62f679a
Gerrit-Change-Number: 28792
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: abandon
Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28789
to look at the new patch set (#3).
Change subject: trxcon: make [l1sched_]tchh_block_dl_first_fn() static
......................................................................
trxcon: make [l1sched_]tchh_block_dl_first_fn() static
Change-Id: Ic3b990aaa1a3a3e13a80a63e1933799e58e7158f
---
M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h
M src/host/trxcon/src/sched_lchan_tchh.c
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/28789/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28789
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic3b990aaa1a3a3e13a80a63e1933799e58e7158f
Gerrit-Change-Number: 28789
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28744
to look at the new patch set (#4).
Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix
......................................................................
trxcon: make l1sched logging configurable, use trxcon->fi as prefix
This change adds struct l1sched_cfg, which needs to be passed to
l1sched_alloc(). This structure allows to configure logging
categories for common and data messages, as well as a logging
context. The later is basically a string used as prefix for the
l1sched related logging: let's use name of trxcon->fi for that.
Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429
Related: OS#5599, OS#3761
---
M src/host/trxcon/include/osmocom/bb/l1sched/Makefile.am
M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h
A src/host/trxcon/include/osmocom/bb/l1sched/logging.h
M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
M src/host/trxcon/src/sched_clck.c
M src/host/trxcon/src/sched_lchan_common.c
M src/host/trxcon/src/sched_lchan_pdtch.c
M src/host/trxcon/src/sched_lchan_rach.c
M src/host/trxcon/src/sched_lchan_sch.c
M src/host/trxcon/src/sched_lchan_tchf.c
M src/host/trxcon/src/sched_lchan_tchh.c
M src/host/trxcon/src/sched_lchan_xcch.c
M src/host/trxcon/src/sched_mframe.c
M src/host/trxcon/src/sched_prim.c
M src/host/trxcon/src/sched_trx.c
M src/host/trxcon/src/trxcon.c
16 files changed, 253 insertions(+), 201 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/44/28744/4
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429
Gerrit-Change-Number: 28744
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28756
to look at the new patch set (#7).
Change subject: trxcon: use trxcon->fi as the context in L1CTL logging
......................................................................
trxcon: use trxcon->fi as the context in L1CTL logging
Change-Id: I7b923cb21638e6afc38deb7766955b43e49b60bb
Related: OS#5599
---
M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h
M src/host/trxcon/src/l1ctl.c
M src/host/trxcon/src/l1ctl_server.c
M src/host/trxcon/src/trxcon.c
4 files changed, 123 insertions(+), 87 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/28756/7
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28756
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7b923cb21638e6afc38deb7766955b43e49b60bb
Gerrit-Change-Number: 28756
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria, dexter.
Hello Jenkins Builder, laforge, pespin, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28678
to look at the new patch set (#10).
Change subject: trxcon: support handling of multiple L1CTL client connections
......................................................................
trxcon: support handling of multiple L1CTL client connections
Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae
---
M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h
M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h
M src/host/trxcon/src/l1ctl_server.c
M src/host/trxcon/src/trx_if.c
M src/host/trxcon/src/trxcon.c
5 files changed, 45 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/78/28678/10
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae
Gerrit-Change-Number: 28678
Gerrit-PatchSet: 10
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28790
to look at the new patch set (#3).
Change subject: trxcon: pass lchan to tchh_block_dl_first_fn() for logging
......................................................................
trxcon: pass lchan to tchh_block_dl_first_fn() for logging
Change-Id: I8fafd180e2539be860bf183782817690dcad2d7d
---
M src/host/trxcon/src/sched_lchan_tchh.c
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/90/28790/3
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28790
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8fafd180e2539be860bf183782817690dcad2d7d
Gerrit-Change-Number: 28790
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmocom-bb/+/28793 )
Change subject: trxcon: send pending TRXC messages in trx_if_flush_ctrl()
......................................................................
trxcon: send pending TRXC messages in trx_if_flush_ctrl()
Send all queued TRXC messages immediately without waiting for response.
This way we don't loose anything when an L1CTL connection gets lost.
Change-Id: I16d748b5194d381af0cd5ba9dbd4bfb33fc7d233
---
M src/host/trxcon/src/trx_if.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/28793/2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28793
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I16d748b5194d381af0cd5ba9dbd4bfb33fc7d233
Gerrit-Change-Number: 28793
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset