July 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > so it turns out I was wrong and there is precedent in cisco world of using hex values. I created https://osmocom.org/issues/5631 to follow up on this topic. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Jul 2022 16:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: so it turns out I was wrong and there is precedent in cisco world of using hex values. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 16:20:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges

by laforge

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Removed Code-Review-1 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 11 months

1
0
0 0

Change in osmo-msc[master]: in sdp logging: add payload type number like 'AMR#111'

by dexter

Attention is currently required from: neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28782 ) Change subject: in sdp logging: add payload type number like 'AMR#111' ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Good idea! Maybe it makes sense to print something like "AMR-PT=111" so that one knows that the number indeed refers to the payload type. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icbb4e89ce2947bf787c3ee14e3e115d406e43de2 Gerrit-Change-Number: 28782 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 16:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: add some comments in upf_gtp.c

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28707 ) Change subject: add some comments in upf_gtp.c ...................................................................... add some comments in upf_gtp.c Related: SYS#5599 Change-Id: I58f86cd84207a74e078ae4758bbed76bb1595d95 --- M src/osmo-upf/upf_gtp.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 8eef49f..2c8f89f 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -96,6 +96,8 @@ static int upf_gtp_dev_destruct(struct upf_gtp_dev *dev); +/* Allocate state for one GTP device, add to g_upf->gtp.devs and return the created device. If state for the device of + * that name already exists, do nothing and return NULL. */ static struct upf_gtp_dev *upf_gtp_dev_alloc(const char *name, const char *local_addr) { struct upf_gtp_dev *dev = upf_gtp_dev_find_by_name(name); @@ -260,9 +262,11 @@ return 0; } + /* Already open? */ if (g_upf->gtp.nl && g_upf->gtp.genl_id >= 0) return 0; + /* sanity / paranoia: if re-opening, make sure the previous socket is closed */ if (g_upf->gtp.nl) upf_gtp_genl_close(); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I58f86cd84207a74e078ae4758bbed76bb1595d95 Gerrit-Change-Number: 28707 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: constify local var in upf_gtp.c

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28708 ) Change subject: constify local var in upf_gtp.c ...................................................................... constify local var in upf_gtp.c Related: SYS#5599 Change-Id: I08085a6e777175b97b9c32d4c302c9863c6f6f59 --- M src/osmo-upf/upf_gtp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 2c8f89f..4a430cb 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -160,7 +160,7 @@ int upf_gtp_dev_open(const char *name, bool create_gtp_dev, const char *local_addr, bool listen_for_gtpv0, bool sgsn_mode) { - struct osmo_sockaddr any = { + const struct osmo_sockaddr any = { .u.sin = { .sin_family = AF_INET, .sin_port = 0, 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I08085a6e777175b97b9c32d4c302c9863c6f6f59 Gerrit-Change-Number: 28708 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: implement GTPv1-U ECHO response

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28312 ) Change subject: implement GTPv1-U ECHO response ...................................................................... implement GTPv1-U ECHO response Accept data on the GTPv1-U socket and respond to GTPv1-U ECHO REQUEST messages. We should keep a deterministic recovery counter that increases with every restart. As a quick and dirty way just use the current time at startup for now, until osmo-upf reaches production maturity. Related: OS#5599 Change-Id: I135370a7723e2c667ec681f50c21107cde63ea5b --- M include/osmocom/upf/Makefile.am M include/osmocom/upf/upf.h A include/osmocom/upf/upf_gtpu_echo.h M src/osmo-upf/Makefile.am M src/osmo-upf/upf.c M src/osmo-upf/upf_gtp.c A src/osmo-upf/upf_gtpu_echo.c 7 files changed, 176 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/include/osmocom/upf/Makefile.am b/include/osmocom/upf/Makefile.am index 333132c..127e03e 100644 --- a/include/osmocom/upf/Makefile.am +++ b/include/osmocom/upf/Makefile.am @@ -4,6 +4,7 @@ up_session.h \ upf.h \ upf_gtp.h \ + upf_gtpu_echo.h \ upf_nft.h \ up_gtp_action.h \ $(NULL) diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h index 0380855..1f8355d 100644 --- a/include/osmocom/upf/upf.h +++ b/include/osmocom/upf/upf.h @@ -87,6 +87,8 @@ struct mnl_socket *nl; int32_t genl_id; + + uint8_t recovery_count; } gtp; /* Tunnel forwarding via linux netfilter */ diff --git a/include/osmocom/upf/upf_gtpu_echo.h b/include/osmocom/upf/upf_gtpu_echo.h new file mode 100644 index 0000000..2575424 --- /dev/null +++ b/include/osmocom/upf/upf_gtpu_echo.h @@ -0,0 +1,4 @@ +/* GTP-U ECHO implementation for osmo-upf */ +#pragma once + +int upf_gtpu_echo_setup(struct upf_gtp_dev *dev); diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am index 1265051..1d43ee8 100644 --- a/src/osmo-upf/Makefile.am +++ b/src/osmo-upf/Makefile.am @@ -37,6 +37,7 @@ up_session.c \ upf.c \ upf_gtp.c \ + upf_gtpu_echo.c \ upf_nft.c \ upf_vty.c \ $(NULL) diff --git a/src/osmo-upf/upf.c b/src/osmo-upf/upf.c index 70891ab..db699c7 100644 --- a/src/osmo-upf/upf.c +++ b/src/osmo-upf/upf.c @@ -53,6 +53,10 @@ .nft = { .priority = -300, }, + .gtp = { + /* TODO: recovery count state file; use lower byte of current time, poor person's random. */ + .recovery_count = time(NULL), + }, }; INIT_LLIST_HEAD(&g_upf->gtp.vty_cfg.devs); diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 6a8deac..8eef49f 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -36,6 +36,7 @@ #include <osmocom/upf/upf.h> #include <osmocom/upf/upf_gtp.h> +#include <osmocom/upf/upf_gtpu_echo.h> #define LOG_GTP_TUN(TUN, LEVEL, FMT, ARGS...) \ LOGP(DGTP, LEVEL, "%s: " FMT, upf_gtp_tun_to_str_c(OTC_SELECT, (TUN)), ##ARGS) @@ -228,6 +229,8 @@ return -EIO; } + upf_gtpu_echo_setup(dev); + return 0; } diff --git a/src/osmo-upf/upf_gtpu_echo.c b/src/osmo-upf/upf_gtpu_echo.c new file mode 100644 index 0000000..f6dfe5c --- /dev/null +++ b/src/osmo-upf/upf_gtpu_echo.c @@ -0,0 +1,161 @@ +/* GTP-U ECHO implementation for osmo-upf */ + +#include <stdint.h> +#include <errno.h> + +#include <osmocom/core/endian.h> +#include <osmocom/core/socket.h> +#include <osmocom/core/msgb.h> + +#include <osmocom/upf/upf.h> +#include <osmocom/upf/upf_gtp.h> + +#define GTP1U_PORT 2152 + +enum gtp1u_msgt { + GTP1U_MSGTYPE_ECHO_REQ = 1, + GTP1U_MSGTYPE_ECHO_RSP = 2, +}; + +enum gtp1u_iei { + GTP1U_IEI_RECOVERY = 14, +}; + +/* 3GPP TS 29.281 */ +struct gtp1u_hdr { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t pn:1, /*< N-PDU Number flag */ + s:1, /*< Sequence number flag */ + e:1, /*< Extension header flag */ + spare:1, + pt:1, /*< Protocol Type: GTP=1, GTP'=0 */ + version:3; /*< Version: 1 */ +#elif OSMO_IS_BIG_ENDIAN + uint8_t version:3, pt:1, spare:1, e:1, s:1, pn:1; +#endif + uint8_t msg_type; + uint16_t length; + uint32_t tei; /*< 05 - 08 Tunnel Endpoint ID */ + union { + uint8_t data1[0]; + struct { + uint16_t seq_nr; + uint8_t n_pdu_nr; + uint8_t next_ext_type; + } ext; + }; + uint8_t data2[0]; +} __attribute__((packed)); + +static int tx_echo_resp(struct upf_gtp_dev *dev, const struct osmo_sockaddr *remote, uint16_t seq_nr); + +static int rx_echo_req(struct upf_gtp_dev *dev, const struct osmo_sockaddr *remote, const struct gtp1u_hdr *rx_h) +{ + if (!rx_h->s) { + LOG_GTP_DEV(dev, LOGL_ERROR, "rx GTPv1-U ECHO REQ without sequence nr\n"); + return -1; + } + + return tx_echo_resp(dev, remote, rx_h->ext.seq_nr); +} + +static int tx_echo_resp(struct upf_gtp_dev *dev, const struct osmo_sockaddr *remote, uint16_t seq_nr) +{ + struct msgb *msg; + struct gtp1u_hdr *tx_h; + int rc; + + msg = msgb_alloc_headroom(1024, 128, "GTP-echo-resp"); + tx_h = (void *)msgb_put(msg, sizeof(*tx_h)); + + *tx_h = (struct gtp1u_hdr){ + /* 3GPP TS 29.281 5.1 defines that the ECHO REQ & RESP shall contain a sequence nr */ + .s = 1, + .pt = 1, + .version = 1, + .msg_type = GTP1U_MSGTYPE_ECHO_RSP, + .ext = { + .seq_nr = seq_nr, + }, + }; + + OSMO_ASSERT(msg->tail == tx_h->data2); + + /* ECHO RESPONSE shall contain a recovery counter */ + msgb_put_u8(msg, GTP1U_IEI_RECOVERY); + msgb_put_u8(msg, g_upf->gtp.recovery_count); + + osmo_store16be(msg->tail - tx_h->data1, &tx_h->length); + + rc = sendto(dev->gtpv1.ofd.fd, msgb_data(msg), msgb_length(msg), 0, &remote->u.sa, sizeof(*remote)); + if (rc < 0) { + int err = errno; + LOG_GTP_DEV(dev, LOGL_ERROR, "GTP1-U sendto(len=%d, to=%s): %s\n", msgb_length(msg), + osmo_sockaddr_to_str(remote), strerror(err)); + } + return rc; +} + +int upf_gtpu_echo_read_cb(struct osmo_fd *ofd, unsigned int what) +{ + struct upf_gtp_dev *dev = ofd->data; + + ssize_t sz; + uint8_t buf[4096]; + struct osmo_sockaddr remote; + socklen_t remote_len = sizeof(remote); + const struct gtp1u_hdr *h; + uint16_t h_length; + + if ((sz = recvfrom(dev->gtpv1.ofd.fd, buf, sizeof(buf), 0, &remote.u.sa, &remote_len)) < 0) { + LOG_GTP_DEV(dev, LOGL_ERROR, "recvfrom() failed: %s\n", strerror(errno)); + return -1; + } + if (sz == 0) { + LOG_GTP_DEV(dev, LOGL_ERROR, "recvfrom() yields zero bytes\n"); + return -1; + } + + /* A GTPv1-U header of size 8 is valid, but this code expects to handle only ECHO REQUEST messages. These are + * required to have a sequence number, hence this check here consciously uses the full sizeof(*h) == 12. */ + if (sz < sizeof(*h)) { + LOG_GTP_DEV(dev, LOGL_ERROR, "rx GTP packet smaller than the GTPv1-U header + sequence nr: %zd < %zu\n", + sz, sizeof(*h)); + return -1; + } + + h = (const struct gtp1u_hdr *)buf; + if (h->version != 1) { + LOG_GTP_DEV(dev, LOGL_ERROR, "rx GTP v%u: only GTP version 1 supported\n", h->version); + return -1; + } + + h_length = osmo_load16be(&h->length); + if (offsetof(struct gtp1u_hdr, data1) + h_length > sz) { + LOG_GTP_DEV(dev, LOGL_ERROR, "rx GTP: header + h.length = %zu > received bytes = %zd\n", + offsetof(struct gtp1u_hdr, data1) + h_length, sz); + return -1; + } + + switch (h->msg_type) { + case GTP1U_MSGTYPE_ECHO_REQ: + return rx_echo_req(dev, &remote, h); + default: + LOG_GTP_DEV(dev, LOGL_ERROR, "rx: GTPv1-U message type %u not supported\n", h->msg_type); + return -1; + } + + return 0; +} + +int upf_gtpu_echo_setup(struct upf_gtp_dev *dev) +{ + if (dev->gtpv1.ofd.fd == -1) { + LOGP(DGTP, LOGL_ERROR, "Cannot setup GTP-U ECHO: GTP-v1 socket not initialized\n"); + return -EINVAL; + } + + dev->gtpv1.ofd.cb = upf_gtpu_echo_read_cb; + dev->gtpv1.ofd.data = dev; + return osmo_fd_register(&dev->gtpv1.ofd); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I135370a7723e2c667ec681f50c21107cde63ea5b Gerrit-Change-Number: 28312 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: apply code review: refactor pfcp_endpoint API

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 ) Change subject: apply code review: refactor pfcp_endpoint API ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: i chose 'more_items' because there is no further change required to API users -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e Gerrit-Change-Number: 28754 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 15:31:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: apply code review: refactor pfcp_endpoint API

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 to look at the new patch set (#2). Change subject: apply code review: refactor pfcp_endpoint API ...................................................................... apply code review: refactor pfcp_endpoint API Code review requested that the API should use functions instead of direct access to a struct. I have moved all user provided config to a separate struct osmo_pfcp_endpoint_cfg, to be passed to osmo_pfcp_endpoint_create(). Halfway through those changes, I am not so certain whether that is what reviewers had in mind. It makes sense from the point of view to keep nr of arguments passed to osmo_pfcp_endpoint_create() small, and to allow changing the user provided config without requiring a new osmo_pfcp_endpoint_create2() API function. Though that again has ABI compat problems, and makes no sense from the point of view that all access should be done via API functions. Personally I don't really agree with this change, which is probably the reason why this patch ended up this way. Related: SYS#5599 Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e --- M include/osmocom/pfcp/pfcp_endpoint.h M src/libosmo-pfcp/pfcp_cp_peer.c M src/libosmo-pfcp/pfcp_endpoint.c 3 files changed, 109 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/54/28754/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e Gerrit-Change-Number: 28754 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-msc[master]: sdp_msg: add sdp_audio_codecs_cmp(), add compare flags

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28783 ) Change subject: sdp_msg: add sdp_audio_codecs_cmp(), add compare flags ...................................................................... Patch Set 3: (1 comment) File src/libmsc/sdp_msg.c: https://gerrit.osmocom.org/c/osmo-msc/+/28783/comment/24001f02_7c85afa7 PS1, Line 38: int sdp_audio_codec_cmp(const struct sdp_audio_codec *a, const struct sdp_audio_codec *b, > see the commit log. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I18d33e189674229501afec950aa1c732386455a2 Gerrit-Change-Number: 28783 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 15:24:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022