July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-msc[master]: in sdp logging: add payload type number like 'AMR#111'

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28782 ) Change subject: in sdp logging: add payload type number like 'AMR#111' ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/libmsc/sdp_msg.c: https://gerrit.osmocom.org/c/osmo-msc/+/28782/comment/2d4e2d64_d6aac20b PS3, Line 516: OSMO_STRBUF_PRINTF(sb, "#%d", codec->payload_type); does it makes sense that this is a %d and not a %u? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icbb4e89ce2947bf787c3ee14e3e115d406e43de2 Gerrit-Change-Number: 28782 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:34:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: move fn_counter_advance to struct l1sched_cfg

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28745 ) Change subject: trxcon: move fn_counter_advance to struct l1sched_cfg ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I733761e46ffe03473f03f76f7612a548c9723d99 Gerrit-Change-Number: 28745 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:32:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make l1sched logging configurable, use trxcon->fi as prefix

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 ) Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/23078a92_c0deb6e9 PS3, Line 167: .cfg = *cfg, This is probably wrong now. You are copying a pointer to a string here, which means somehow the caller needs to keep the pointer alive during l1sched_state lifespan... You probably want to talloc_strdup it. File src/host/trxcon/src/trxcon.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/ed583004_1412ffe5 PS3, Line 362: return trxcon; leak of trxon->log_prefix here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429 Gerrit-Change-Number: 28744 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: support handling of multiple L1CTL client connections

by fixeria

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28678 ) Change subject: trxcon: support handling of multiple L1CTL client connections ...................................................................... Patch Set 8: (1 comment) File src/host/trxcon/src/l1ctl_server.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/a3fa529c_28480a90 PS6, Line 163: client->id = server->client_id_seed++; > so this misteriours "seed" is actually "next_client_id". […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae Gerrit-Change-Number: 28678 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use trxcon->fi as the context in L1CTL logging

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28756 ) Change subject: trxcon: use trxcon->fi as the context in L1CTL logging ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > Answered there, add an "id" or "name" field to it if you want to identify it, don't depend on extern […] Done. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b923cb21638e6afc38deb7766955b43e49b60bb Gerrit-Change-Number: 28756 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make l1sched logging configurable, use trxcon->fi as prefix

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 ) Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > I agree with pespin; I don't see a need of having function call-back in this situation. […] Done. File src/host/trxcon/src/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/9c04d147_fbeaa4cd PS2, Line 185: #if 0 > You can simply use DLGLOBAL or alike in that case. […] I simply changed it to accept lchan: https://gerrit.osmocom.org/c/osmocom-bb/+/28790. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429 Gerrit-Change-Number: 28744 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 14:30:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make [l1sched_]tchh_block_dl_first_fn() static

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28789 ) Change subject: trxcon: make [l1sched_]tchh_block_dl_first_fn() static ...................................................................... trxcon: make [l1sched_]tchh_block_dl_first_fn() static Change-Id: Ic3b990aaa1a3a3e13a80a63e1933799e58e7158f --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_lchan_tchh.c 2 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/28789/1 diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index 1719ff8..29b6933 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -469,8 +469,6 @@ size_t l1sched_bad_frame_ind(uint8_t *l2, struct l1sched_lchan_state *lchan); /* Interleaved TCH/H block TDMA frame mapping */ -uint32_t l1sched_tchh_block_dl_first_fn(enum l1sched_lchan_type chan, - uint32_t last_fn, bool facch); bool l1sched_tchh_block_map_fn(enum l1sched_lchan_type chan, uint32_t fn, bool ul, bool facch, bool start); diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index b0bc566..2b4b682 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -149,8 +149,8 @@ * @return either frame number of the first burst, * or fn=last_fn if calculation failed */ -uint32_t l1sched_tchh_block_dl_first_fn(enum l1sched_lchan_type chan, - uint32_t last_fn, bool facch) +static uint32_t tchh_block_dl_first_fn(enum l1sched_lchan_type chan, + uint32_t last_fn, bool facch) { uint8_t fn_mf, fn_diff; int i = 0; @@ -331,7 +331,7 @@ /* Didn't try to decode, fake measurements */ if (n_errors < 0) { lchan->meas_avg = (struct l1sched_meas_set) { - .fn = l1sched_tchh_block_dl_first_fn(lchan->type, fn, false), + .fn = tchh_block_dl_first_fn(lchan->type, fn, false), .toa256 = 0, .rssi = -110, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic3b990aaa1a3a3e13a80a63e1933799e58e7158f Gerrit-Change-Number: 28789 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: pass lchan to tchh_block_dl_first_fn() for logging

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28790 ) Change subject: trxcon: pass lchan to tchh_block_dl_first_fn() for logging ...................................................................... trxcon: pass lchan to tchh_block_dl_first_fn() for logging Change-Id: I8fafd180e2539be860bf183782817690dcad2d7d --- M src/host/trxcon/src/sched_lchan_tchh.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/90/28790/1 diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index 2b4b682..a8c641b 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -149,9 +149,10 @@ * @return either frame number of the first burst, * or fn=last_fn if calculation failed */ -static uint32_t tchh_block_dl_first_fn(enum l1sched_lchan_type chan, +static uint32_t tchh_block_dl_first_fn(const struct l1sched_lchan_state *lchan, uint32_t last_fn, bool facch) { + enum l1sched_lchan_type chan = lchan->type; uint8_t fn_mf, fn_diff; int i = 0; @@ -182,11 +183,9 @@ BLOCK_FIRST_FN(tch_h1_traffic_block_map); } -#if 0 LOGP_LCHAND(lchan, LOGL_ERROR, "Failed to calculate TDMA frame number of the first burst of %s block, " "using the current fn=%u\n", facch ? "FACCH/H" : "TCH/H", last_fn); -#endif /* Couldn't calculate the first fn, return the last */ return last_fn; @@ -331,7 +330,7 @@ /* Didn't try to decode, fake measurements */ if (n_errors < 0) { lchan->meas_avg = (struct l1sched_meas_set) { - .fn = tchh_block_dl_first_fn(lchan->type, fn, false), + .fn = tchh_block_dl_first_fn(lchan, fn, false), .toa256 = 0, .rssi = -110, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8fafd180e2539be860bf183782817690dcad2d7d Gerrit-Change-Number: 28790 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: vty: Print created and expired times for each message

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28785 ) Change subject: vty: Print created and expired times for each message ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9ee49b99546a44be706700c3db94d45210c47e54 Gerrit-Change-Number: 28785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Jul 2022 14:28:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: vty: Fix 'show message' not finding expired messages

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28788 ) Change subject: vty: Fix 'show message' not finding expired messages ...................................................................... vty: Fix 'show message' not finding expired messages Change-Id: I23523876f1df167e8afd730b2164f133c2776085 --- M include/osmocom/cbc/cbc_message.h M src/cbc_vty.c M src/message_handling.c 3 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/88/28788/1 diff --git a/include/osmocom/cbc/cbc_message.h b/include/osmocom/cbc/cbc_message.h index daf992d..9d3b5b8 100644 --- a/include/osmocom/cbc/cbc_message.h +++ b/include/osmocom/cbc/cbc_message.h @@ -102,6 +102,7 @@ int cbc_message_new(const struct cbc_message *cbcmsg, struct rest_it_op *op); void cbc_message_delete(struct cbc_message *cbcmsg, struct rest_it_op *op); struct cbc_message *cbc_message_by_id(uint16_t message_id); +struct cbc_message *cbc_message_expired_by_id(uint16_t message_id); int peer_new_cbc_message(struct cbc_peer *peer, struct cbc_message *cbcmsg); int cbc_message_del_peer(struct cbc_message *cbcmsg, struct cbc_peer *peer); diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 50ec807..99363fb 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -205,8 +205,11 @@ const struct smscb_message *smscb; struct cbc_message_peer *msg_peer; char *timestr; + uint16_t msgid = atoi(argv[0]); - cbc_msg = cbc_message_by_id(atoi(argv[0])); + cbc_msg = cbc_message_by_id(msgid); + if (!cbc_msg) + cbc_msg = cbc_message_expired_by_id(msgid); if (!cbc_msg) { vty_out(vty, "Unknown Messsage ID %s%s", argv[0], VTY_NEWLINE); return CMD_WARNING; diff --git a/src/message_handling.c b/src/message_handling.c index 73898e1..76739c3 100644 --- a/src/message_handling.c +++ b/src/message_handling.c @@ -235,3 +235,13 @@ } return NULL; } + +struct cbc_message *cbc_message_expired_by_id(uint16_t message_id) +{ + struct cbc_message *cbc_msg; + llist_for_each_entry(cbc_msg, &g_cbc->expired_messages, list) { + if (cbc_msg->msg.message_id == message_id) + return cbc_msg; + } + return NULL; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I23523876f1df167e8afd730b2164f133c2776085 Gerrit-Change-Number: 28788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022