Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
to look at the new patch set (#3).
Change subject: cbc: Handle each CBSP and SBc-AP on a separate component
......................................................................
cbc: Handle each CBSP and SBc-AP on a separate component
* Each BSC_ConnectionHandler emulates a BSC and handles one TCP/CBSP
conn.
* Each MME_ConectionHandler emulates an MME and handles one SCTP/SBc-AP
conn.
* ECBE related functionalities are moved to its own file
ECBE_Components.ttcn.
* CBS_Message is moved to its own file since it is used by all modules.
Related: OS#4945
Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
---
A cbc/BSC_ConnectionHandler.ttcn
M cbc/CBC_Tests.ttcn
A cbc/CBS_Message.ttcn
A cbc/ECBE_Components.ttcn
A cbc/MME_ConnectionHandler.ttcn
5 files changed, 608 insertions(+), 325 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/28830/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
Gerrit-Change-Number: 28830
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830 )
Change subject: cbc: Handle each CBSP and SBc-AP on a separate component
......................................................................
Patch Set 2:
(1 comment)
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830/comment/43a4fcb5_b337…
PS2, Line 205: 100
> do we really need to sleep that much?
No idea, I didn't write this. In any case, it's not run in control(), I think it's just for debugging, hecne the big number.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
Gerrit-Change-Number: 28830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28794 )
Change subject: trxcon: trx_if_close(): power the transceiver off if needed
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28794
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9c5178907304b36ec3de0ee31b7f7a9ed2e31c16
Gerrit-Change-Number: 28794
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:26:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28833 )
Change subject: BTS_Tests: tune back to CCCH/BCCH in TC_sacch_chan_act_ho_[a]sync
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65fb243a62fc7670b43f467d6b79268cdfb98f36
Gerrit-Change-Number: 28833
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:08:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28823 )
Change subject: sbcap: Store reported failed TAIs from WriteReplaceResponse in cbc_message_peer
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
> ok, i see now; but with a comment here i wouldn't have had to look
It's not the first time I have to override this so I didn't consider necessary to write about this every time I do it.
File src/smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28823/comment/5357b5cb_bc494f0e
PS3, Line 328: struct cbc_cell_id *cci = NULL; // FIXME: lookup
> explain merging this FIXME?
It's the same as currently done for CBSP. This needs to be improved for both at some point later in time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28823
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I37b08aa374c1097d2871bf69a7bb7893f32bccd3
Gerrit-Change-Number: 28823
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment