Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28823
)
Change subject: sbcap: Store reported failed TAIs from WriteReplaceResponse in
cbc_message_peer
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
ok, i see now; but with a comment here i wouldn't
have had to look
It's not the first time I have to override this so I didn't
consider necessary to write about this every time I do it.
File src/smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28823/comment/5357b5cb_bc494f0e
PS3, Line 328: struct cbc_cell_id *cci = NULL; // FIXME: lookup
explain merging this FIXME?
It's the same as
currently done for CBSP. This needs to be improved for both at some point later in time.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28823
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I37b08aa374c1097d2871bf69a7bb7893f32bccd3
Gerrit-Change-Number: 28823
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment