Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 ) Change subject: sbcap: Log info about messages received and trasmitted ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/1d2905c0_d15986a2 PS2, Line 8:

(same for all patches in this relation chain) I see no need for writing an issue if it's a generic patch simply refactoring/improving some code. It would be more distracting than anything else since there's nothing of interest in the issue regarding this patch.

File src/sbcap/sbcap_common.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/ea30c48b_6bc59b3d PS2, Line 162: static char pdu_name[256] = "<unknown>";

may i suggest the pattern […] I rather have a static buf in the app than using OTC_SELECT. No need to use it more than once per printf, we are not handling several messages in parallel.

https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/5db8feb2_5a3833fc PS2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));

are you sure about: sbcap_procedure_code_str() might return NULL If that ever happened, "(null)" would be printed which is not a big issue.

-- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Fri, 29 Jul 2022 08:03:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment