Attention is currently required from: neels, laforge.

3 comments:

Commit Message:
- Patch Set #2, Line 8:
  (same for all patches in this relation chain)
  I see no need for writing an issue if it's a generic patch simply refactoring/improving some code. It would be more distracting than anything else since there's nothing of interest in the issue regarding this patch.
File src/sbcap/sbcap_common.c:
- Patch Set #2, Line 162: static char pdu_name[256] = "<unknown>";
  may i suggest the pattern […]
  I rather have a static buf in the app than using OTC_SELECT.
  No need to use it more than once per printf, we are not handling several messages in parallel.
- Patch Set #2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));
  are you sure about: sbcap_procedure_code_str() might return NULL
  If that ever happened, "(null)" would be printed which is not a big issue.

To view, visit change 28819. To unsubscribe, or for help writing mail filters, visit settings.