July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: bsc_nat_print_addr: handle NULL

by osmith

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 ) Change subject: bsc_nat_print_addr: handle NULL ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581/comment/f2c8aed8_90ceab19 PS1, Line 101: if (!addr) { > This case doesn't make much sense imho. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I37cfc7ae32d85142d73b523b2f13b94a0bffba7a Gerrit-Change-Number: 28581 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc-nat[master]: bssap_conn: fix missing length check

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 ) Change subject: bssap_conn: fix missing length check ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/c2eb31f1_66f19d12 PS1, Line 48: if (rv < 0 || len > UINT_MAX) { > I don't think len can ever be higher than UINT_MAX. […] oh right. I think I understood now what coverity means, please take another look. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db Gerrit-Change-Number: 28582 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_print_addr: handle NULL

by osmith

Attention is currently required from: osmith, dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 to look at the new patch set (#2). Change subject: bsc_nat_print_addr: handle NULL ...................................................................... bsc_nat_print_addr: handle NULL Fixes: Coverity CID#273006, CID#273005 Fixes: OS#5597 Change-Id: I37cfc7ae32d85142d73b523b2f13b94a0bffba7a --- M src/osmo-bsc-nat/bsc_nat.c M src/osmo-bsc-nat/bsc_nat_fsm.c 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/81/28581/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I37cfc7ae32d85142d73b523b2f13b94a0bffba7a Gerrit-Change-Number: 28581 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-bsc-nat[master]: bssap_conn: fix missing length check

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 to look at the new patch set (#2). Change subject: bssap_conn: fix missing length check ...................................................................... bssap_conn: fix missing length check Fixes: Coverity CID#273004 Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db --- M src/osmo-bsc-nat/bssap_conn.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/82/28582/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db Gerrit-Change-Number: 28582 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: add osmo-opencm3-projects

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28574 ) Change subject: jobs/gerrit-verifications: add osmo-opencm3-projects ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic514e96ff515c5703f39f5a31f419ff344179368 Gerrit-Change-Number: 28574 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: enable osmo-opencm3-projects

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28573 ) Change subject: jobs/master-builds: enable osmo-opencm3-projects ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iefff6e3c3b18f4af99079635a45320faaac54e50 Gerrit-Change-Number: 28573 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: docker-rebuild: add debian-bullseye-jenkins

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28572 ) Change subject: docker-rebuild: add debian-bullseye-jenkins ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I22f95de0bd131f0f0cfd5e2a24e17bed22e5d248 Gerrit-Change-Number: 28572 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:13:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: docker-rebuild: build erlang img on x86_64 only

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28571 ) Change subject: docker-rebuild: build erlang img on x86_64 only ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5636dfc9e06a44b096f9dc55528d677ea2dfc352 Gerrit-Change-Number: 28571 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:12:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: debian-bullseye-jenkins: new container

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28570 ) Change subject: debian-bullseye-jenkins: new container ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I849568826b1993fd9fb652779e631188af4a319e Gerrit-Change-Number: 28570 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 14:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity: don't cd ~/osmo-ci/coverity

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28579 ) Change subject: jobs/coverity: don't cd ~/osmo-ci/coverity ...................................................................... jobs/coverity: don't cd ~/osmo-ci/coverity Run the coverity/jenkins.sh from the osmo-ci.git repository that jenkins checks out at the beginning of the build, instead of using a copy in ~/ that is updated whenever pushing to master. This makes it less confusing, I configured the job to use a WIP branch and didn't realize that it still used the code from master. Change-Id: Ie992d71d2afec6982447b8fe3626c821a9e48d19 --- M coverity/jenkins.sh M jobs/coverity.yml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index b02b82e..64d21de 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -3,8 +3,8 @@ set -e -x -base_dir="$PWD" -src_dir="$base_dir/source-Osmocom" +base_dir="$HOME/osmo-ci/coverity" +src_dir="$PWD/source-Osmocom" cov_dir="$src_dir/cov-int" rm -rf "$src_dir" diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 88b8a49..980c30c 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -13,7 +13,7 @@ node: coverity builders: - shell: | - cd $HOME/osmo-ci/coverity + cd coverity export PATH=$PATH:/opt/coverity/current/bin ./jenkins.sh publishers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie992d71d2afec6982447b8fe3626c821a9e48d19 Gerrit-Change-Number: 28579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022