July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity: don't build tests for all

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28576 ) Change subject: coverity: don't build tests for all ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: finally fixed the coverity job, this one ran from a branch with these patches applied: https://jenkins.osmocom.org/jenkins/job/osmocom-coverity/1666/console -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951 Gerrit-Change-Number: 28576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 13:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity: don't cd ~/osmo-ci/coverity

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28579 ) Change subject: jobs/coverity: don't cd ~/osmo-ci/coverity ...................................................................... jobs/coverity: don't cd ~/osmo-ci/coverity Run the coverity/jenkins.sh from the osmo-ci.git repository that jenkins checks out at the beginning of the build, instead of using a copy in ~/ that is updated whenever pushing to master. This makes it less confusing, I configured the job to use a WIP branch and didn't realize that it still used the code from master. Change-Id: Ie992d71d2afec6982447b8fe3626c821a9e48d19 --- M coverity/jenkins.sh M jobs/coverity.yml 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/79/28579/1 diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index b02b82e..64d21de 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -3,8 +3,8 @@ set -e -x -base_dir="$PWD" -src_dir="$base_dir/source-Osmocom" +base_dir="$HOME/osmo-ci/coverity" +src_dir="$PWD/source-Osmocom" cov_dir="$src_dir/cov-int" rm -rf "$src_dir" diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 88b8a49..980c30c 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -13,7 +13,7 @@ node: coverity builders: - shell: | - cd $HOME/osmo-ci/coverity + cd coverity export PATH=$PATH:/opt/coverity/current/bin ./jenkins.sh publishers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie992d71d2afec6982447b8fe3626c821a9e48d19 Gerrit-Change-Number: 28579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity.yml: add parameter for git branch

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28580 ) Change subject: jobs/coverity.yml: add parameter for git branch ...................................................................... jobs/coverity.yml: add parameter for git branch Allow configuring a different git branch before starting the build. This is especially useful to reproduce a failure that only happens when using coverity tools during a build. Change-Id: I5f7c615ff5af4bf1f34ccef62767b5ca71cd2d8d --- M jobs/coverity.yml 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/28580/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 980c30c..cb39ea6 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -24,13 +24,18 @@ - build-discarder: days-to-keep: 30 num-to-keep: 30 + parameters: + - string: + name: BRANCH + description: osmo-ci.git branch + default: 'origin/master' scm: - git: url: git://git.osmocom.org/osmo-ci git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' branches: - - 'origin/master' + - '$BRANCH' triggers: - timed: "@daily" publishers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f7c615ff5af4bf1f34ccef62767b5ca71cd2d8d Gerrit-Change-Number: 28580 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: Revert "WIP: coverity: Make sure curl is installed, as our coverity u...

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28577 ) Change subject: Revert "WIP: coverity: Make sure curl is installed, as our coverity upload job needs it" ...................................................................... Revert "WIP: coverity: Make sure curl is installed, as our coverity upload job needs it" Revert 3038c19155a7a2fb4b075a84449fc09d06bef59a, which adds a second osmocom-coverity-deps job that apparently was never deployed (or was deployed and then deleted). The mentioned curl dependency shouldn't go here either. Change-Id: I5d4709c0019ef4bae6ccbd11c28eeb23d75692c1 --- M jobs/coverity.yml 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/28577/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 5614fc0..576fa29 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -2,19 +2,9 @@ - project: name: osmocom-coverity jobs: - - osmocom-coverity-deps - osmocom-coverity - job: - name: 'osmocom-coverity-deps' - apt: - name: "{{ item }}" - cache_valid_time: 3600 - update_cache: yes - with_items: - - curl - -- job: name: 'osmocom-coverity' project-type: freestyle defaults: global -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5d4709c0019ef4bae6ccbd11c28eeb23d75692c1 Gerrit-Change-Number: 28577 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity: modernize

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28578 ) Change subject: jobs/coverity: modernize ...................................................................... jobs/coverity: modernize * no need to mention "(jenkins-job-builder)" in the display-name * set mail to jenkins-notifications ML like most other jobs Change-Id: I0284dd7354157e057903f53cde149ce652e76550 --- M jobs/coverity.yml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/78/28578/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 576fa29..88b8a49 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -9,7 +9,7 @@ project-type: freestyle defaults: global description: 'Generated by job-builder' - display-name: 'Coverity-Upload (jenkins-job-builder)' + display-name: 'Coverity-Upload' node: coverity builders: - shell: | @@ -18,7 +18,7 @@ ./jenkins.sh publishers: - email: - recipients: openbsc(a)lists.osmocom.org holger(a)freyther.de + recipients: 'jenkins-notifications(a)lists.osmocom.org' notify-every-unstable-build: true properties: - build-discarder: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0284dd7354157e057903f53cde149ce652e76550 Gerrit-Change-Number: 28578 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: coverity: don't build tests for all

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28576 ) Change subject: coverity: don't build tests for all ...................................................................... coverity: don't build tests for all The coverity jenkins job has been failing since we tried to build tests for all projects (and in an earlier attempt, build and run tests for all projects). Make the coverity job work again by skipping build of tests for asn1c. I looked into it earlier and the cause wasn't obvious to me, and it's currently not worth spending time on. Fix for: libtool: error: cannot find the library '../../skeletons/libasn1cskeletons.la' or unhandled argument '../../skeletons/libasn1cskeletons.la' Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 41 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/28576/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 11b7e5c..01e3d73 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -1,42 +1,46 @@ #!/bin/sh BASEDIR=source-Osmocom +PROJECTS=" + libasn1c + libosmo-abis + libosmocore + libosmo-dsp + libosmo-netif + libosmo-sccp + libsmpp34 + libusrp + osmo-bsc + osmo-msc + osmo-mgw + osmo-ggsn + osmo-gbproxy + osmo-sgsn + osmo-bts + osmo-gmr + osmo-iuh + osmo-pcu + osmo-sysmon + osmo-sip-connector + osmo-trx + osmo-hlr + osmocom-bb + osmo-smlc + osmo-cbc + simtrace2 + osmo-hnodeb + osmo-hnbgw + osmo-bsc-nat +" + +PROJECTS_DONT_BUILD_TEST=" + asn1c +" + [ -d $BASEDIR ] || mkdir -p $BASEDIR cd $BASEDIR -for proj in \ - asn1c \ - libasn1c \ - libosmo-abis \ - libosmocore \ - libosmo-dsp \ - libosmo-netif \ - libosmo-sccp \ - libsmpp34 \ - libusrp \ - osmo-bsc \ - osmo-msc \ - osmo-mgw \ - osmo-ggsn \ - osmo-gbproxy \ - osmo-sgsn \ - osmo-bts \ - osmo-gmr \ - osmo-iuh \ - osmo-pcu \ - osmo-sysmon \ - osmo-sip-connector \ - osmo-trx \ - osmo-hlr \ - osmocom-bb \ - osmo-smlc \ - osmo-cbc \ - simtrace2 \ - osmo-hnodeb \ - osmo-hnbgw \ - osmo-bsc-nat \ - ; do - +for proj in $PROJECTS $PROJECTS_DONT_BUILD_TEST; do if [ -d $proj ]; then if [ -z "$SRC_SKIP_FETCH" ]; then (cd $proj && git fetch && git checkout -f -B master origin/master) @@ -47,9 +51,11 @@ else git clone git://git.osmocom.org/$proj fi +done - # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' - # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. +# We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' +# instead of 'check_PROGRAMS' allows building test binaries during 'make all'. +for proj in $PROJECTS; do files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951 Gerrit-Change-Number: 28576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... octoi_srv_fsm: fix implicit fall-through Found by gcc (Debian 10.2.1-6) 10.2.1 20210110, which fails the build with --enable-werror because of this. Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b --- M src/octoi/octoi_srv_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index 469436e..cda0e52 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -131,6 +131,7 @@ case ACCOUNT_MODE_NONE: LOGPFSML(fi, LOGL_NOTICE, "User account %s has mode 'none', rejecting\n", acc->user_id); + /* fall through */ default: st->rej_str = "Unsupported mode for user"; goto reject; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 13:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28554 ) Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 12:40:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 to look at the new patch set (#7). Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_lchan_common.c M src/host/trxcon/src/sched_lchan_desc.c M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_sch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon.c 18 files changed, 460 insertions(+), 408 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/28554/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022