July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Add unit tests for sbcap

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 to look at the new patch set (#3). Change subject: Add unit tests for sbcap ...................................................................... Add unit tests for sbcap This commit adds some minimum unit tests to validate encoding and decoding of SBc-AP ASN.1 APER format is working properly. Related: OS#4945 Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d --- M configure.ac M tests/Makefile.am A tests/sbcap/Makefile.am A tests/sbcap/sbcap_test.c A tests/sbcap/sbcap_test.ok A tests/testsuite.at 6 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/01/28601/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: Add unit tests for sbcap

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 to look at the new patch set (#2). Change subject: Add unit tests for sbcap ...................................................................... Add unit tests for sbcap This commit adds some minimum unit tests to validate encoding and decoding of SBc-AP ASN.1 APER format is working properly. Related: OS#4945 Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d --- M configure.ac M tests/Makefile.am A tests/sbcap/Makefile.am A tests/sbcap/sbcap_test.c A tests/sbcap/sbcap_test.ok A tests/testsuite.at 6 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/01/28601/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: Add sbcap library

by pespin

pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28600 ) Change subject: Add sbcap library ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: If76f8619a9b2d46af6d94b8ae49348b8514e53aa Gerrit-Change-Number: 28600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: Add sbcap library

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28600 ) Change subject: Add sbcap library ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: If76f8619a9b2d46af6d94b8ae49348b8514e53aa Gerrit-Change-Number: 28600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:41:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in ...osmo_dia2gsup[master]: debian: add packaging

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 ) Change subject: debian: add packaging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ic55bca1260f992d0ed8583e7c7fe948ba0160d4d Gerrit-Change-Number: 28605 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:40:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... Patch Set 1: (1 comment) File lint/checkpatch/checkpatch_osmo.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28606/comment/388fc96a_183667b9 PS1, Line 8: asn|cc > I don't think this is the right approach. We may have hand-written *.asn and *. […] I definetly wouldn't blacklist all .cc by default. I don't care that much for asn files. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... Patch Set 1: (1 comment) File lint/checkpatch/checkpatch_osmo.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28606/comment/73aab762_b81be883 PS1, Line 8: asn|cc I don't think this is the right approach. We may have hand-written *.asn and *.cc files in some projects and they'll be ignored by the linter. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:36:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... lint: ignore *.asn, *.cc Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/06/28606/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index b0c3985..27369e9 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -4,8 +4,8 @@ PROJECT="$(basename "$PROJECT_DIR")" exclude_paths_common() { - # Test output - echo '--exclude \.(ok|err|ctrl|vty)$' + # Test output, generated files + echo '--exclude \.(asn|cc|ok|err|ctrl|vty)$' # Generated from commit log, which may contain spelling errors (OS#5232) echo '--exclude ^debian/changelog$' # Patch files -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in ...osmo_dia2gsup[master]: debian: add packaging

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 ) Change subject: debian: add packaging ...................................................................... debian: add packaging Add initial debian packaging and a systemd service that starts osmo_dia2gsup. Given that rebar3 and the dependencies listed in rebar.lock are not packaged in debian 11, this just downloads the official binary of rebar3 and uses it to download and compile the dependencies during the build. Resulting erlang files are installed to the following path, where they become available in the erlang shell (erl): /lib/erlang/lib/{name_of_component}/ebin/ Related: SYS#6006 Change-Id: Ic55bca1260f992d0ed8583e7c7fe948ba0160d4d --- M .gitignore A contrib/systemd/osmo_dia2gsup.service A debian/changelog A debian/compat A debian/control A debian/download_rebar3.sh A debian/osmo-diameter2gsup.install A debian/rules A debian/source/format 9 files changed, 81 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/05/28605/1 diff --git a/.gitignore b/.gitignore index 587d7e9..4669194 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,11 @@ src/diameter_3gpp* src/diameter_rfc* src/diameter_etsi* + +/rebar3 + +/debian/*.debhelper +/debian/files +/debian/osmo-diameter2gsup.substvars +/debian/osmo-diameter2gsup/ +/debian/debhelper-build-stamp diff --git a/contrib/systemd/osmo_dia2gsup.service b/contrib/systemd/osmo_dia2gsup.service new file mode 100644 index 0000000..3ae9b68 --- /dev/null +++ b/contrib/systemd/osmo_dia2gsup.service @@ -0,0 +1,14 @@ +[Unit] +Description=Osmocom DIAMETER to GSUP translator +After=osmo-hlr.service + +[Service] +Type=simple +Restart=always +Environment="HOME=/var/lib/osmo_dia2gsup" +ExecStartPre=/usr/bin/mkdir -p /var/lib/osmo_dia2gsup +ExecStart=/usr/bin/erl -noshell -sname osmo_dia2gsup -eval "osmo_dia2gsup:start()." +RestartSec=2 + +[Install] +WantedBy=multi-user.target diff --git a/debian/changelog b/debian/changelog new file mode 100644 index 0000000..6e45d35 --- /dev/null +++ b/debian/changelog @@ -0,0 +1,5 @@ +osmo-diameter2gsup (0.1.0) unstable; urgency=medium + + * Initial release. + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 14 Jul 2022 14:51:01 +0200 diff --git a/debian/compat b/debian/compat new file mode 100644 index 0000000..f599e28 --- /dev/null +++ b/debian/compat @@ -0,0 +1 @@ +10 diff --git a/debian/control b/debian/control new file mode 100644 index 0000000..d3ebc4f --- /dev/null +++ b/debian/control @@ -0,0 +1,17 @@ +Source: osmo-diameter2gsup +Maintainer: Osmocom Community <openbsc(a)lists.osmocom.org> +Section: net +Priority: optional +Build-Depends: erlang-nox, + libpcap-dev, + wget, +Standards-Version: 4.5.0 + +Package: osmo-diameter2gsup +Architecture: any +Depends: erlang-nox +Multi-Arch: allowed +Description: Osmocom DIAMETER to GSUP translator + This can be used to translate DIAMETER requests (such as those by an EPC) + to the Osmocom specific GSUP protocol, which means you can use OsmoHLR + as a simplistic HSS. diff --git a/debian/download_rebar3.sh b/debian/download_rebar3.sh new file mode 100755 index 0000000..2b524a5 --- /dev/null +++ b/debian/download_rebar3.sh @@ -0,0 +1,14 @@ +#!/bin/sh -e +# HACK: rebar3 is not packaged for debian 11. Use the official release binary +# for now. + +REBAR3_VERSION=3.19.0 + +if [ -x ./rebar3 ]; then + echo "rebar3 already downloaded" + exit 0 +fi + +set -x +wget "https://github.com/erlang/rebar3/releases/download/$REBAR3_VERSION/rebar3" +chmod +x rebar3 diff --git a/debian/osmo-diameter2gsup.install b/debian/osmo-diameter2gsup.install new file mode 100644 index 0000000..6d442ad --- /dev/null +++ b/debian/osmo-diameter2gsup.install @@ -0,0 +1,2 @@ +/contrib/systemd/osmo_dia2gsup.service /lib/systemd/system/ +/_lib/* /usr/lib/erlang/lib/ diff --git a/debian/rules b/debian/rules new file mode 100755 index 0000000..0e7444c --- /dev/null +++ b/debian/rules @@ -0,0 +1,19 @@ +#!/usr/bin/make -f + +build: + debian/download_rebar3.sh + ./rebar3 compile + ./rebar3 escriptize + ./rebar3 eunit + for i in _build/default/lib/*; do \ + libdir=_lib/"$$(basename "$$i")"; \ + mkdir -pv "$$libdir"; \ + cp -rv "$$i/ebin" "$$libdir"; \ + done + find _lib -name .empty -delete + +clean: + rm -rf _build _lib + +%: + dh $@ diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ic55bca1260f992d0ed8583e7c7fe948ba0160d4d Gerrit-Change-Number: 28605 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Support for SBc-AP protocol as used on the MME-CBC interface

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 ) Change subject: Support for SBc-AP protocol as used on the MME-CBC interface ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Also, where the *.asn files are coming from? Please add a link/reference to the commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2 Gerrit-Change-Number: 28603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 12:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022