Attention is currently required from: pespin.
pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 )
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 )
Change subject: Add unit tests for sbcap
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d
Gerrit-Change-Number: 28601
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
to look at the new patch set (#4).
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Add initial SBc-AP support to osmo-cbc
This patch makes use of the newly introduced sbcap library, and
introduces new code (and extends existing one) to handle all the aspects
of MME peers talking SBc-AP and its underlaying SCTP connection.
This commit doesn't aim to implement all the SBc-AP features, but to
implement a minimal subset of features already available for CBSP in
osmo-cbc, in order to have similar support level for both 2G and 4G
networks.
Related: OS#4945
Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
---
M configure.ac
M debian/control
M doc/examples/osmo-cbc/osmo-cbc.cfg
M include/osmocom/cbc/Makefile.am
M include/osmocom/cbc/cbc_data.h
M include/osmocom/cbc/internal.h
A include/osmocom/cbc/sbcap_msg.h
A include/osmocom/cbc/sbcap_server.h
M src/Makefile.am
M src/cbc_data.c
M src/cbc_main.c
M src/cbc_vty.c
M src/message_handling.c
A src/sbcap_msg.c
A src/sbcap_server.c
A src/sbcap_server_fsm.c
M src/smscb_message_fsm.c
M src/smscb_peer_fsm.c
18 files changed, 1,321 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/02/28602/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28601
to look at the new patch set (#4).
Change subject: Add unit tests for sbcap
......................................................................
Add unit tests for sbcap
This commit adds some minimum unit tests to validate encoding and
decoding of SBc-AP ASN.1 APER format is working properly.
Related: OS#4945
Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d
---
M configure.ac
M tests/Makefile.am
A tests/sbcap/Makefile.am
A tests/sbcap/sbcap_test.c
A tests/sbcap/sbcap_test.ok
A tests/testsuite.at
6 files changed, 346 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/01/28601/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d
Gerrit-Change-Number: 28601
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
to look at the new patch set (#3).
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Add initial SBc-AP support to osmo-cbc
This patch makes use of the newly introduced sbcap library, and
introduces new code (and extends existing one) to handle all the aspects
of MME peers talking SBc-AP and its underlaying SCTP connection.
This commit doesn't aim to implement all the SBc-AP features, but to
implement a minimal subset of features already available for CBSP in
osmo-cbc, in order to have similar support level for both 2G and 4G
networks.
Related: OS#4945
Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
---
M configure.ac
M debian/control
M doc/examples/osmo-cbc/osmo-cbc.cfg
M include/osmocom/cbc/Makefile.am
M include/osmocom/cbc/cbc_data.h
M include/osmocom/cbc/internal.h
A include/osmocom/cbc/sbcap_msg.h
A include/osmocom/cbc/sbcap_server.h
M src/Makefile.am
M src/cbc_data.c
M src/cbc_main.c
M src/cbc_vty.c
M src/message_handling.c
A src/sbcap_msg.c
A src/sbcap_server.c
A src/sbcap_server_fsm.c
M src/smscb_message_fsm.c
M src/smscb_peer_fsm.c
18 files changed, 1,321 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/02/28602/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28602
to look at the new patch set (#2).
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Add initial SBc-AP support to osmo-cbc
This patch makes use of the newly introduced sbcap library, and
introduces new code (and extends existing one) to handle all the aspects
of MME peers talking SBc-AP and its underlaying SCTP connection.
This commit doesn't aim to implement all the SBc-AP features, but to
implement a minimal subset of features already available for CBSP in
osmo-cbc, in order to have similar support level for both 2G and 4G
networks.
Related: OS#4945
Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
---
M configure.ac
M debian/control
M doc/examples/osmo-cbc/osmo-cbc.cfg
M include/osmocom/cbc/Makefile.am
M include/osmocom/cbc/cbc_data.h
M include/osmocom/cbc/internal.h
A include/osmocom/cbc/sbcap_msg.h
A include/osmocom/cbc/sbcap_server.h
M src/Makefile.am
M src/cbc_data.c
M src/cbc_main.c
M src/cbc_vty.c
M src/message_handling.c
A src/sbcap_msg.c
A src/sbcap_server.c
A src/sbcap_server_fsm.c
M src/smscb_message_fsm.c
M src/smscb_peer_fsm.c
18 files changed, 1,320 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/02/28602/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 )
Change subject: Add unit tests for sbcap
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d
Gerrit-Change-Number: 28601
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 )
Change subject: Add unit tests for sbcap
......................................................................
Patch Set 3: Verified+1
(1 comment)
Patchset:
PS3:
I'm not sure I'm able to fix the 2 remaining linter warnings. It's probably due to having to use some tricks due to how asn1c defines those types only inline.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d
Gerrit-Change-Number: 28601
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jul 2022 16:18:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
