Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28611 )
Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604
Gerrit-Change-Number: 28611
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jul 2022 19:53:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28610 )
Change subject: smscb: Tx Failure and Restart Ind using CGI as cellID
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28610
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69
Gerrit-Change-Number: 28610
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jul 2022 19:52:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jul 2022 19:51:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603
to look at the new patch set (#3).
Change subject: Support for SBc-AP protocol as used on the MME-CBC interface
......................................................................
Support for SBc-AP protocol as used on the MME-CBC interface
This requires a recent libfftranscode (>=0.5) with SBC-AP support.
The asn files are obtained from 3GPP TS 29.168.
Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2
Related: OS#4945
---
M cbc/CBC_Tests.ttcn
M cbc/gen_links.sh
M cbc/regen_makefile.sh
A library/sbcap/SBC_AP_Adapter.ttcn
A library/sbcap/SBC_AP_CodecPort.ttcn
A library/sbcap/SBC_AP_CodecPort_CtrlFunct.ttcn
A library/sbcap/SBC_AP_CodecPort_CtrlFunctDef.cc
A library/sbcap/SBC_AP_CommonDataTypes.asn
A library/sbcap/SBC_AP_Constants.asn
A library/sbcap/SBC_AP_Containers.asn
A library/sbcap/SBC_AP_EncDec.cc
A library/sbcap/SBC_AP_IEs.asn
A library/sbcap/SBC_AP_PDU_Contents.asn
A library/sbcap/SBC_AP_PDU_Descriptions.asn
A library/sbcap/SBC_AP_Templates.ttcn
A library/sbcap/SBC_AP_Types.ttcn
A library/sbcap/regen_makefile.sh
17 files changed, 2,228 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/28603/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2
Gerrit-Change-Number: 28603
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28611 )
Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type
......................................................................
smscb: Tx Failure and Restart Ind for each Bcast Msg Type
As described in 3GPP TS 48.049:
7.8.2: "The RESTART message is sent once per broadcast message type as
indicated by the Broadcast Message Type IE."
7.9.2: "The FAILURE message is sent once per broadcast message type as
indicated by the Broadcast Message Type IE."
Related: SYS#5910
Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604
---
M src/osmo-bsc/smscb.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/28611/1
diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c
index 32f8f98..8e1c634 100644
--- a/src/osmo-bsc/smscb.c
+++ b/src/osmo-bsc/smscb.c
@@ -1131,6 +1131,7 @@
bts_cbch_timer_schedule(trx->bts);
/* Start ETWS/PWS Primary Notification, if active */
bts_etws_bootstrap(trx->bts);
+ cbsp_tx_restart_bts(bts->network->cbc, true, bts);
cbsp_tx_restart_bts(bts->network->cbc, false, bts);
}
} else {
@@ -1138,6 +1139,7 @@
/* If timer is ongoing it means CBCH was available */
LOG_BTS(bts, DCBS, LOGL_INFO, "BTS becomes unavailable for CBCH\n");
osmo_timer_del(&bts->cbch_timer);
+ cbsp_tx_failure_bts(bts->network->cbc, true, bts);
cbsp_tx_failure_bts(bts->network->cbc, false, bts);
} /* else: CBCH was already unavailable before */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604
Gerrit-Change-Number: 28611
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange