pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 2:
(1 comment)
File bsc/BSC_Tests_CBSP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609/comment/eccf2cf4_c85a…
PS1, Line 570: [not received_cbs] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx_cbs)) {
> Yeah I thought about the interleave but indeed I didn't know how to handle the "received unexpected […]
merging now in order to avoid ttcn3 test breakage in master.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 16:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 16:17:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: wbokslag.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28591 )
Change subject: ensure zero termination of tun device name
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
The formatting of the file looks wired. The linter also complains. Maybe reformatting the file with lindent in a separate patch before this one is a good idea?
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28591
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I4b783c6b98ddfb30a4ca4532ef8cffa8e5f3a12f
Gerrit-Change-Number: 28591
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Comment-Date: Fri, 15 Jul 2022 15:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: wbokslag.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28597 )
Change subject: moved variable declaration to prevent compiler warnings
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/conv_enc_test.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/28597/comment/28f92a91_40fa5164
PS1, Line 319: int err;
Some compilers might have problems with this, maybe put it at the beginning of the function and use another #if 0
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28597
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: If9a83589b220ae7d937ef75c79de57be11858cd1
Gerrit-Change-Number: 28597
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Comment-Date: Fri, 15 Jul 2022 15:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment