July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: scripts/osmocom-packages-docker: pass OBS_SERVER

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28620 ) Change subject: scripts/osmocom-packages-docker: pass OBS_SERVER ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8e53523b9b1ceafa45fe7b3dca2731d4e1c74959 Gerrit-Change-Number: 28620 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Jul 2022 14:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmocom-packages-docker: pass OBS_SERVER

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28620 ) Change subject: scripts/osmocom-packages-docker: pass OBS_SERVER ...................................................................... scripts/osmocom-packages-docker: pass OBS_SERVER Make the variable available, as it's needed by the scripts that osmocom-packages-docker.sh calls since Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928. Change-Id: I8e53523b9b1ceafa45fe7b3dca2731d4e1c74959 --- M scripts/osmocom-packages-docker.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/20/28620/1 diff --git a/scripts/osmocom-packages-docker.sh b/scripts/osmocom-packages-docker.sh index a541a87..0dda19a 100755 --- a/scripts/osmocom-packages-docker.sh +++ b/scripts/osmocom-packages-docker.sh @@ -27,6 +27,7 @@ docker run \ --rm \ -e "FEED=$FEED" \ + -e "OBS_SERVER=$OBS_SERVER" \ -e "OSMO_OBS_CONFLICT_PKGVER=$OSMO_OBS_CONFLICT_PKGVER" \ -e "PACKAGES=$PACKAGES" \ -e "PROJ=$PROJ" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8e53523b9b1ceafa45fe7b3dca2731d4e1c74959 Gerrit-Change-Number: 28620 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: checkpatch.conf: ignore imported sbcap *.asn files

by pespin

pespin has uploaded a new patch set (#2) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28615 ) Change subject: checkpatch.conf: ignore imported sbcap *.asn files ...................................................................... checkpatch.conf: ignore imported sbcap *.asn files Prepare to import files to library/sbcap, which we don't want to be linted in Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2. Change-Id: I3ab3253753d32a266bdaf32fb247c2c0139d40d3 --- A .checkpatch.conf 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/28615/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ab3253753d32a266bdaf32fb247c2c0139d40d3 Gerrit-Change-Number: 28615 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Support for SBc-AP protocol as used on the MME-CBC interface

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 to look at the new patch set (#5). Change subject: Support for SBc-AP protocol as used on the MME-CBC interface ...................................................................... Support for SBc-AP protocol as used on the MME-CBC interface This requires a recent libfftranscode (>=0.5) with SBC-AP support. The asn files are obtained from 3GPP TS 29.168. Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2 Related: OS#4945 --- M cbc/CBC_Tests.ttcn M cbc/gen_links.sh M cbc/regen_makefile.sh A library/sbcap/SBC_AP_Adapter.ttcn A library/sbcap/SBC_AP_CodecPort.ttcn A library/sbcap/SBC_AP_CodecPort_CtrlFunct.ttcn A library/sbcap/SBC_AP_CodecPort_CtrlFunctDef.cc A library/sbcap/SBC_AP_CommonDataTypes.asn A library/sbcap/SBC_AP_Constants.asn A library/sbcap/SBC_AP_Containers.asn A library/sbcap/SBC_AP_EncDec.cc A library/sbcap/SBC_AP_IEs.asn A library/sbcap/SBC_AP_PDU_Contents.asn A library/sbcap/SBC_AP_PDU_Descriptions.asn A library/sbcap/SBC_AP_Templates.ttcn A library/sbcap/SBC_AP_Types.ttcn A library/sbcap/regen_makefile.sh 17 files changed, 2,227 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/28603/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2 Gerrit-Change-Number: 28603 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind for each Bcast Msg Type

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28619 ) Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type ...................................................................... smscb: Tx Failure and Restart Ind for each Bcast Msg Type As described in 3GPP TS 48.049: 7.8.2: "The RESTART message is sent once per broadcast message type as indicated by the Broadcast Message Type IE." 7.9.2: "The FAILURE message is sent once per broadcast message type as indicated by the Broadcast Message Type IE." Related: SYS#5910 Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604 (cherry picked from commit a7e5f1613aa7478bd51af42a2dea0767e128845d) --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 32f8f98..8e1c634 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -1131,6 +1131,7 @@ bts_cbch_timer_schedule(trx->bts); /* Start ETWS/PWS Primary Notification, if active */ bts_etws_bootstrap(trx->bts); + cbsp_tx_restart_bts(bts->network->cbc, true, bts); cbsp_tx_restart_bts(bts->network->cbc, false, bts); } } else { @@ -1138,6 +1139,7 @@ /* If timer is ongoing it means CBCH was available */ LOG_BTS(bts, DCBS, LOGL_INFO, "BTS becomes unavailable for CBCH\n"); osmo_timer_del(&bts->cbch_timer); + cbsp_tx_failure_bts(bts->network->cbc, true, bts); cbsp_tx_failure_bts(bts->network->cbc, false, bts); } /* else: CBCH was already unavailable before */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604 Gerrit-Change-Number: 28619 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind using CGI as cellID

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28618 ) Change subject: smscb: Tx Failure and Restart Ind using CGI as cellID ...................................................................... smscb: Tx Failure and Restart Ind using CGI as cellID Let's use CGI instead of LAC+CI, which contains only a subset of the information. Furthermore, It was noted that some third party (non-osmocom, non open source) CBCs don't support/like receiving LAC+CI, and expect to receive CGI instead. Related: SYS#5910 Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69 (cherry picked from commit f3a4844f04906b38d521da150ed8aadedf8b917b) --- M src/osmo-bsc/smscb.c 1 file changed, 9 insertions(+), 19 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 0e9049f..32f8f98 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -481,20 +481,15 @@ { struct osmo_cbsp_decoded *cbsp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_RESTART); struct osmo_cbsp_cell_ent cell_ent; + struct osmo_cell_global_id *cgi; if (is_emerg) cbsp->u.restart.bcast_msg_type = 0x01; cbsp->u.restart.recovery_ind = 0x00; /* message data available */ - cbsp->u.restart.cell_list.id_discr = CELL_IDENT_LAC_AND_CI; + cbsp->u.restart.cell_list.id_discr = CELL_IDENT_WHOLE_GLOBAL; - cell_ent = (struct osmo_cbsp_cell_ent){ - .cell_id = { - .lac_and_ci = { - .lac = bts->location_area_code, - .ci = bts->cell_identity, - } - } - }; + cgi = bts_get_cgi(bts); + cell_ent.cell_id.global = *cgi; llist_add(&cell_ent.list, &cbsp->u.restart.cell_list.list); return cbsp_tx_decoded(cbc, cbsp); @@ -505,20 +500,15 @@ { struct osmo_cbsp_decoded *cbsp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_FAILURE); struct osmo_cbsp_fail_ent fail_ent; + struct osmo_cell_global_id *cgi; if (is_emerg) cbsp->u.failure.bcast_msg_type = 0x01; - fail_ent = (struct osmo_cbsp_fail_ent){ - .id_discr = CELL_IDENT_LAC_AND_CI, - .cell_id = { - .lac_and_ci = { - .lac = bts->location_area_code, - .ci = bts->cell_identity, - } - }, - .cause = OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_OPERATIONAL - }; + cgi = bts_get_cgi(bts); + fail_ent.id_discr = CELL_IDENT_WHOLE_GLOBAL; + fail_ent.cell_id.global = *cgi; + fail_ent.cause = OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_OPERATIONAL; llist_add(&fail_ent.list, &cbsp->u.failure.fail_list); return cbsp_tx_decoded(cbc, cbsp); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69 Gerrit-Change-Number: 28618 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind for each Bcast Msg Type

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28619 ) Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604 Gerrit-Change-Number: 28619 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Jul 2022 14:13:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind using CGI as cellID

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28618 ) Change subject: smscb: Tx Failure and Restart Ind using CGI as cellID ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69 Gerrit-Change-Number: 28618 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Jul 2022 14:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind using CGI as cellID

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/28618 ) Change subject: smscb: Tx Failure and Restart Ind using CGI as cellID ...................................................................... smscb: Tx Failure and Restart Ind using CGI as cellID Let's use CGI instead of LAC+CI, which contains only a subset of the information. Furthermore, It was noted that some third party (non-osmocom, non open source) CBCs don't support/like receiving LAC+CI, and expect to receive CGI instead. Related: SYS#5910 Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69 (cherry picked from commit f3a4844f04906b38d521da150ed8aadedf8b917b) --- M src/osmo-bsc/smscb.c 1 file changed, 9 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/28618/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I33a6216f89496484cbb3921609fcd3ab90761c69 Gerrit-Change-Number: 28618 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-bsc[2022q2]: smscb: Tx Failure and Restart Ind for each Bcast Msg Type

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/28619 ) Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type ...................................................................... smscb: Tx Failure and Restart Ind for each Bcast Msg Type As described in 3GPP TS 48.049: 7.8.2: "The RESTART message is sent once per broadcast message type as indicated by the Broadcast Message Type IE." 7.9.2: "The FAILURE message is sent once per broadcast message type as indicated by the Broadcast Message Type IE." Related: SYS#5910 Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604 (cherry picked from commit a7e5f1613aa7478bd51af42a2dea0767e128845d) --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/28619/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q2 Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604 Gerrit-Change-Number: 28619 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022