Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28636 )
Change subject: ts_31_102: Add support for obsolete EF.RPLMNAcT
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File pySim/ts_31_102.py:
https://gerrit.osmocom.org/c/pysim/+/28636/comment/ebd2bb51_31ca6ff6
PS1, Line 751: def _decode_record_hex(self, in_hex):
Something is wrong here, _decode_record_hex() must be a method of class EF_RPLMNAcT I guess, not a scoped function of __init__()? In other words, << in vim.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
Gerrit-Change-Number: 28636
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Jul 2022 20:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28632 )
Change subject: move EF_UServiceTable from ts_31_102 to ts_31_102_telecom
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/28632/comment/e8c5c127_0761b0b6
PS1, Line 10: avoid cyclic imports
Not sure if this is a problem when you import specific API from a module, rather than doing 'import *'...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cd6ab795bfd92f845eb943679a3d6302f1003ce
Gerrit-Change-Number: 28632
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Jul 2022 20:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment