Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28636 )
Change subject: ts_31_102: Add support for obsolete EF.RPLMNAcT
......................................................................
Patch Set 2:
(1 comment)
File pySim/ts_31_102.py:
https://gerrit.osmocom.org/c/pysim/+/28636/comment/a0fea819_21fc76ad
PS1, Line 751: def _decode_record_hex(self, in_hex):
> Something is wrong here, _decode_record_hex() must be a method of class EF_RPLMNAcT I guess, not a s […]
thanks, nice catch. In my use case I'm only seeing a SELECT for that file which fails, so I never get to the point of payload decode...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
Gerrit-Change-Number: 28636
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 07:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, dexter.
Hello Jenkins Builder, fixeria, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/28636
to look at the new patch set (#2).
Change subject: ts_31_102: Add support for obsolete EF.RPLMNAcT
......................................................................
ts_31_102: Add support for obsolete EF.RPLMNAcT
This file existed in earlier specs like Release 3.8.0, but was removed
in later revisions. Still, there are cards around implementing that
older spec, so let's add a decoder.
Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
---
M pySim/ts_31_102.py
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/28636/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
Gerrit-Change-Number: 28636
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28632 )
Change subject: move EF_UServiceTable from ts_31_102 to ts_31_102_telecom
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/28632/comment/442d71ff_d0bc7933
PS1, Line 10: avoid cyclic imports
> Not sure if this is a problem when you import specific API from a module, rather than doing 'import […]
it is. We are and have always been using selective imports between ts_51_011.py and ts_31_102.py, but still it doesn't work if ts_31_102.py imports some classes from ts_51_011 and we now add the inverse to it :(
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cd6ab795bfd92f845eb943679a3d6302f1003ce
Gerrit-Change-Number: 28632
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 07:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment