Attention is currently required from: osmith.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652 )
Change subject: debian: rework packaging
......................................................................
Patch Set 1:
(2 comments)
File debian/osmo-diameter2gsup.install:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/a5ccf9b8_…
PS1, Line 2: /_build/default/bin/osmo-dia2gsup /usr/bin/
> does it still start with the systemd service? I'm not familiar at all with erlang, I though the othe […]
I've missed the update of the service file.
File debian/rules:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/e05033f8_…
PS1, Line 18: _lib
> _lib doesn't get created anymore: […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I40add168875de87ef0cc62deeb5377d2ce080e45
Gerrit-Change-Number: 28652
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 13:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: wbokslag, laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28592 )
Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3
Gerrit-Change-Number: 28592
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 19 Jul 2022 12:30:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 )
Change subject: implement GTP tunnel mapping via netfilter
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Agreeing with pau
you misunderstand.
Of course the VTY tests are not doing anything related to administrative parmissions.
It is osmo-upf preparing the nftables feature *upon startup*.
Whenever osmo-upf starts, it opens the nftables socket and creates an empty table.
So even before the VTY tests begin, the premission error happens.
I've tried to discuss this already in my previous comments,
maybe it was not clear enough.
I wrote before already:
we can skip opening the nftables socket until it is actually needed.
But i would prefer osmo-upf to complain about permission problems directly upon startup.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 12:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment