July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-tetra[master]: added missing switch statements to suppress compiler warnings

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28595 ) Change subject: added missing switch statements to suppress compiler warnings ...................................................................... added missing switch statements to suppress compiler warnings Change-Id: I02f7b1875e5501f6977638130c8c5b8c8634fe4e --- M src/phy/tetra_burst.c M src/tetra_llc.c 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/src/phy/tetra_burst.c b/src/phy/tetra_burst.c index 5bede06..c791ee0 100644 --- a/src/phy/tetra_burst.c +++ b/src/phy/tetra_burst.c @@ -371,5 +371,9 @@ tp_sap_udata_ind(TPSAP_T_BBK, bbk_buf, NDB_BBK_BITS, priv); tp_sap_udata_ind(TPSAP_T_SCH_F, ndbf_buf, 2*NDB_BLK_BITS, priv); break; + case TETRA_TRAIN_NORM_3: + case TETRA_TRAIN_EXT: + /* uplink training sequences, should not be encountered, ignore */ + break; } } diff --git a/src/tetra_llc.c b/src/tetra_llc.c index 893673e..e0d5cab 100644 --- a/src/tetra_llc.c +++ b/src/tetra_llc.c @@ -150,6 +150,12 @@ /* check if the fragment is complete and hand it off*/ tllc_defrag_out(&g_llcs, &lpp); break; + + case TLLC_PDUT_DEC_UNKNOWN: + case TLLC_PDUT_DEC_ALX_ACK: + case TLLC_PDUT_DEC_ALX_RNR: + /* fixme: unhandled types */ + break; } if (lpp.tl_sdu && lpp.ss == 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I02f7b1875e5501f6977638130c8c5b8c8634fe4e Gerrit-Change-Number: 28595 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: Added missing return value

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28594 ) Change subject: Added missing return value ...................................................................... Added missing return value Change-Id: I53d0e75c14933fae30257f8a4cc76df0f3bcd642 --- M src/tetra_llc.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/tetra_llc.c b/src/tetra_llc.c index 42ec288..893673e 100644 --- a/src/tetra_llc.c +++ b/src/tetra_llc.c @@ -105,6 +105,7 @@ llist_del(&dqe->list); talloc_free(msg); talloc_free(dqe); + return 0; } /* Receive TM-SDU (MAC SDU == LLC PDU) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I53d0e75c14933fae30257f8a4cc76df0f3bcd642 Gerrit-Change-Number: 28594 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: added brackets; fprintf was erroneously not guarded by if statement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28593 ) Change subject: added brackets; fprintf was erroneously not guarded by if statement ...................................................................... added brackets; fprintf was erroneously not guarded by if statement Change-Id: I2e8c365ee261bde998a69f0f3531dfe6f3ec49c7 --- M src/tetra_llc.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve diff --git a/src/tetra_llc.c b/src/tetra_llc.c index 045b8df..42ec288 100644 --- a/src/tetra_llc.c +++ b/src/tetra_llc.c @@ -92,9 +92,10 @@ msg->l3h = msg->data; rx_tl_sdu(msg, msgb_l3len(msg)); - if (tun_fd < 0) + if (tun_fd < 0) { tun_fd = tun_alloc("tun0"); fprintf(stderr, "tun_fd=%d\n", tun_fd); + } if (tun_fd >= 0) { uint8_t buf[4096]; int len = osmo_ubit2pbit(buf, msg->l3h+3+4+4+4+4, msgb_l3len(msg)-3-4-4-4-4); -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I2e8c365ee261bde998a69f0f3531dfe6f3ec49c7 Gerrit-Change-Number: 28593 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28592 ) Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c ...................................................................... Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3 --- M src/tetra_llc.c A src/tuntap.h 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified fixeria: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/src/tetra_llc.c b/src/tetra_llc.c index 432f5a7..045b8df 100644 --- a/src/tetra_llc.c +++ b/src/tetra_llc.c @@ -28,6 +28,7 @@ #include <osmocom/core/bits.h> #include "tetra_llc_pdu.h" +#include "tuntap.h" static int tun_fd = -1; diff --git a/src/tuntap.h b/src/tuntap.h new file mode 100644 index 0000000..728002b --- /dev/null +++ b/src/tuntap.h @@ -0,0 +1,6 @@ +#ifndef TUNTAP_H +#define TUNTAP_H + +int tun_alloc(char *dev); + +#endif -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3 Gerrit-Change-Number: 28592 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28592 ) Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3 Gerrit-Change-Number: 28592 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Tue, 19 Jul 2022 13:48:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: ensure zero termination of tun device name

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28591 ) Change subject: ensure zero termination of tun device name ...................................................................... ensure zero termination of tun device name Change-Id: I4b783c6b98ddfb30a4ca4532ef8cffa8e5f3a12f --- M src/tuntap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified dexter: Looks good to me, approved diff --git a/src/tuntap.c b/src/tuntap.c index 8109067..6ae16c7 100644 --- a/src/tuntap.c +++ b/src/tuntap.c @@ -29,7 +29,7 @@ */ ifr.ifr_flags = IFF_TUN|IFF_NO_PI; if( *dev ) - strncpy(ifr.ifr_name, dev, IFNAMSIZ); + snprintf(ifr.ifr_name, IFNAMSIZ, "%s", dev); if( (err = ioctl(fd, TUNSETIFF, (void *) &ifr)) < 0 ){ close(fd); -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4b783c6b98ddfb30a4ca4532ef8cffa8e5f3a12f Gerrit-Change-Number: 28591 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: ensure zero termination of tun device name

by laforge

Attention is currently required from: wbokslag. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28591 ) Change subject: ensure zero termination of tun device name ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4b783c6b98ddfb30a4ca4532ef8cffa8e5f3a12f Gerrit-Change-Number: 28591 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: deleteVote

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28592 ) Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/tuntap.h: https://gerrit.osmocom.org/c/osmo-tetra/+/28592/comment/7a5f8af5_ea1fc532 PS1, Line 1: #ifndef TUNTAP_H > > I think "#pragma once" should be used for all code developed in the last decade, but it's not crit […] ack -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3 Gerrit-Change-Number: 28592 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Tue, 19 Jul 2022 13:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: wbokslag <w.bokslag(a)midnightblue.nl> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-upf[master]: implement GTP tunnel mapping via netfilter

by pespin

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 ) Change subject: implement GTP tunnel mapping via netfilter ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > (marking unresolved) Maybe add a cmdline flag --test-mode or --no-nft ? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650 Gerrit-Change-Number: 28309 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Jul 2022 13:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: fix incorrect timeout values: milliseconds vs microseconds

by neels

Attention is currently required from: fixeria, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28655 ) Change subject: fix incorrect timeout values: milliseconds vs microseconds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I1e0b319033415e42ca7f4da9bae348c5cb1da38c Gerrit-Change-Number: 28655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jul 2022 13:44:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022