July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Split cbc_peer to its own .c and .h files

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28692 ) Change subject: Split cbc_peer to its own .c and .h files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I41c890d81e76ac1a1c89d42af70a1f0631e9724e Gerrit-Change-Number: 28692 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 17:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap_server: Fix double-free of rx msg if conn is destroyed

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28691 ) Change subject: sbcap_server: Fix double-free of rx msg if conn is destroyed ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sbcap_server.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28691/comment/afc6aef4_ea68cb11 PS1, Line 62: msgb_alloc_c I would simply use msgb_alloc() here, which uses dedicated 'msgb' context. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I201f44efa24a514e0087b6dcd01115b9b2b8e9db Gerrit-Change-Number: 28691 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 17:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28699 ) Change subject: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7100f326f45f1f8742363eace0531a4ef3f049c0 Gerrit-Change-Number: 28699 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 20 Jul 2022 17:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap_server: Log all sctp notif

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28690 ) Change subject: sbcap_server: Log all sctp notif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ibe73f1e976f088154c2a20e2c7dd98b39a475c08 Gerrit-Change-Number: 28690 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 17:11:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap_server.c: Remove unneeded goto

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28689 ) Change subject: sbcap_server.c: Remove unneeded goto ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I02cf8e7ec05d5189d9c6dcc9a7b1e4def80220d7 Gerrit-Change-Number: 28689 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 16:51:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28699 ) Change subject: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7100f326f45f1f8742363eace0531a4ef3f049c0 Gerrit-Change-Number: 28699 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 20 Jul 2022 16:50:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28699 ) Change subject: sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES ...................................................................... sim/class_tables: Add GET IDENTITY, SUSPEND UICC, EXCHANGE CAPABILITIES This brings the tables up-to-date with Release 16 of both ETSI 102 221 + 3GPP TS 31.102 specifications. Change-Id: I7100f326f45f1f8742363eace0531a4ef3f049c0 --- M src/sim/class_tables.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/28699/1 diff --git a/src/sim/class_tables.c b/src/sim/class_tables.c index 34f22dd..9c51387 100644 --- a/src/sim/class_tables.c +++ b/src/sim/class_tables.c @@ -113,7 +113,7 @@ [0xD6] = 3, /* UPDATE BINARY */ [0xB2] = 2, /* READ RECORD */ [0xDC] = 3, /* UPDATE RECORD */ - [0xA2] = 4, /* SEEK */ + [0xA2] = 4, /* SEARCH RECORD */ [0x20] = 3, /* VERIFY PIN */ [0x24] = 3, /* CHANGE PIN */ [0x26] = 3, /* DISABLE PIN */ @@ -198,6 +198,7 @@ [0xCB] = 4, /* RETRIEVE DATA */ [0xDB] = 3, /* SET DATA */ [0xAA] = 3, /* TERMINAL CAPABILITY */ + [0x78] = 4, /* GET IDENTITY */ }; /* ETSI TS 102 221, Table 10.5, CLA = 0x80 */ @@ -206,6 +207,8 @@ [0xC2] = 4, /* ENVELOPE */ [0x12] = 2, /* FETCH */ [0x14] = 3, /* TERMINAL RESPONSE */ + [0x76] = 4, /* SUSPEND UICC */ + [0x7A] = 4, /* EXCHANGE CAPABILITIES */ }; /* Card Specification v2.3.1*/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7100f326f45f1f8742363eace0531a4ef3f049c0 Gerrit-Change-Number: 28699 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap_server.h: Remove unused fields

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28698 ) Change subject: sbcap_server.h: Remove unused fields ...................................................................... sbcap_server.h: Remove unused fields Change-Id: I3086a264557b976985d166e56fb7f70ad96b81df --- M include/osmocom/cbc/sbcap_server.h 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/98/28698/1 diff --git a/include/osmocom/cbc/sbcap_server.h b/include/osmocom/cbc/sbcap_server.h index ebc9f2a..a5568ad 100644 --- a/include/osmocom/cbc/sbcap_server.h +++ b/include/osmocom/cbc/sbcap_server.h @@ -34,11 +34,7 @@ struct llist_head list; /* stream server connection for this client */ struct osmo_stream_srv *conn; - /* partially received sbcap message (rx completion pending) */ - struct msgb *rx_msg; - struct osmo_fsm_inst *fi; - struct cbc_peer *peer; }; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3086a264557b976985d166e56fb7f70ad96b81df Gerrit-Change-Number: 28698 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Fix f_sbcap_tx_write_replace_warn_resp()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688 ) Change subject: cbc: Fix f_sbcap_tx_write_replace_warn_resp() ...................................................................... cbc: Fix f_sbcap_tx_write_replace_warn_resp() The line was wrongly removed when pushing a new version of the patch for review submission. Fixes: 7c13cb7e0f3679e58cfba0e666166626b464cfca Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb --- M cbc/CBC_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index b3ef64d..2abd33e 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -315,6 +315,8 @@ runs on test_CT { var template (value) SBC_AP_PDU tx; /* TODO: pass Unknown Tracking Area List as parameter above (omit by default) */ + tx := ts_SBCAP_WRITE_WARNING_RESP(int2bit(msg.msg_id, 16), + int2bit(msg.ser_nr, 16)); f_SBC_AP_send(tx, idx); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb Gerrit-Change-Number: 28688 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Fix f_sbcap_tx_write_replace_warn_resp()

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688 ) Change subject: cbc: Fix f_sbcap_tx_write_replace_warn_resp() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb Gerrit-Change-Number: 28688 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 16:17:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022