pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688 )
Change subject: cbc: Fix f_sbcap_tx_stop_warn_resp()
......................................................................
cbc: Fix f_sbcap_tx_stop_warn_resp()
The line was wrongly removed when pushing a new version of the patch for
review submission.
Fixes: 7c13cb7e0f3679e58cfba0e666166626b464cfca
Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb
---
M cbc/CBC_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/28688/1
diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn
index b3ef64d..2abd33e 100644
--- a/cbc/CBC_Tests.ttcn
+++ b/cbc/CBC_Tests.ttcn
@@ -315,6 +315,8 @@
runs on test_CT {
var template (value) SBC_AP_PDU tx;
/* TODO: pass Unknown Tracking Area List as parameter above (omit by default) */
+ tx := ts_SBCAP_WRITE_WARNING_RESP(int2bit(msg.msg_id, 16),
+ int2bit(msg.ser_nr, 16));
f_SBC_AP_send(tx, idx);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28688
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If99ff5b83e8f0c577e60e0406b001a3753213deb
Gerrit-Change-Number: 28688
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
daniel has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656 )
Change subject: diameter: Change default bind IP to 127.0.0.8
......................................................................
diameter: Change default bind IP to 127.0.0.8
The IP 127.0.0.4 is already used by the open5gs smf. Since the mme by default
tries to connect to the hss at 127.0.0.8 let's change the default here
to something that works ootb.
Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
---
M src/osmo_dia2gsup.erl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
daniel: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl
index be8e87c..a4edd71 100644
--- a/src/osmo_dia2gsup.erl
+++ b/src/osmo_dia2gsup.erl
@@ -69,7 +69,7 @@
% DIAMETER side
SvcName = ?MODULE,
diameter:start_service(SvcName, ?SERVICE(SvcName)),
- Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.4"),
+ Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"),
Port = application:get_env(osmo_dia2gsup, diameter_port, 3868),
Proto = application:get_env(osmo_dia2gsup, diameter_proto, sctp),
listen({address, Proto, element(2,inet:parse_address(Ip)), Port}),
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
Gerrit-Change-Number: 28656
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656 )
Change subject: diameter: Change default bind IP to 127.0.0.8
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
Gerrit-Change-Number: 28656
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:51:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656 )
Change subject: diameter: Change default bind IP to 127.0.0.8
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656/comment/8c029cda_…
PS1, Line 9: used by the smf
> It may not be obvious for some reviewers that you're talking about open5gs.
Thanks, changed
Patchset:
PS2:
Readding +2 from before
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
Gerrit-Change-Number: 28656
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel.
Hello Jenkins Builder, fixeria, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656
to look at the new patch set (#2).
Change subject: diameter: Change default bind IP to 127.0.0.8
......................................................................
diameter: Change default bind IP to 127.0.0.8
The IP 127.0.0.4 is already used by the open5gs smf. Since the mme by default
tries to connect to the hss at 127.0.0.8 let's change the default here
to something that works ootb.
Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
---
M src/osmo_dia2gsup.erl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/56/28656/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28656
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ibe36e86e6473caab753308837b2ced0f1b53e1f2
Gerrit-Change-Number: 28656
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset