May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gsm-manuals[master]: glossary: add CBSP, CBC, CBS

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28098 ) Change subject: glossary: add CBSP, CBC, CBS ...................................................................... glossary: add CBSP, CBC, CBS Change-Id: Iac405366b2191415ebb1e71154fc3bf31ad37a59 --- M common/chapters/glossary.adoc 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/98/28098/1 diff --git a/common/chapters/glossary.adoc b/common/chapters/glossary.adoc index 926ebd3..7c706b9 100644 --- a/common/chapters/glossary.adoc +++ b/common/chapters/glossary.adoc @@ -53,8 +53,14 @@ Base Station Subsystem Gateway Protocol (_3GPP TS 48.018_ <<3gpp-ts-48-018>>) BVCI:: BSSGP Virtual Circuit Identifier +CBC:: + Cell Broadcast Centre; central entity of Cell Broadcast service CBCH:: Cell Broadcast Channel; used to transmit Cell Broadcast SMS (SMS-CB) +CBS:: + Cell Broadcast Service +CBSP:: + Cell Broadcast Service Protocol (_3GPP TS 48.049_ <<3gpp-ts-48-049>>) CC:: Call Control; Part of the GSM Layer 3 Protocol CCCH:: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iac405366b2191415ebb1e71154fc3bf31ad37a59 Gerrit-Change-Number: 28098 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: Add CBSP port number to default list of ports

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 ) Change subject: Add CBSP port number to default list of ports ...................................................................... Add CBSP port number to default list of ports Change-Id: Ifff8eb076bef29a64d9d20237fe5c8ee402788dc --- M common/chapters/port_numbers.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/port_numbers.adoc b/common/chapters/port_numbers.adoc index 477c3b3..5faf3cf 100644 --- a/common/chapters/port_numbers.adoc +++ b/common/chapters/port_numbers.adoc @@ -55,6 +55,7 @@ |UDP|4729|GSMTAP|Almost every osmocom project |TCP|5000|A/IP|osmo-bsc, osmo-bsc_nat |UDP|23000|GPRS-NS over IP default port|osmo-pcu, osmo-sgsn, osmo-gbproxy +|TCP|48049|BSC-CBC (CBSP) default port|osmo-bsc, osmo-cbc |=============== //// ATTENTION: Keep this list in sync with all of: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifff8eb076bef29a64d9d20237fe5c8ee402788dc Gerrit-Change-Number: 28095 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: bibliography: Add reference to TS 48.049 (CBSP)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 ) Change subject: bibliography: Add reference to TS 48.049 (CBSP) ...................................................................... bibliography: Add reference to TS 48.049 (CBSP) Change-Id: Id1504cb8f9331f36b6085d238a43fe041703ab23 --- M common/chapters/bibliography.adoc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/bibliography.adoc b/common/chapters/bibliography.adoc index 06b1fb4..9d635b0 100644 --- a/common/chapters/bibliography.adoc +++ b/common/chapters/bibliography.adoc @@ -141,6 +141,10 @@ (GPRS); Base Station System (BSS) - Serving GPRS Support Node (SGSN); BSS GPRS protocol (BSSGP) https://www.3gpp.org/DynaReport/48018.htm +- [[[3gpp-ts-48-049]]] 3GPP TS 48.049: Digital cellular communications system; + Base Station Controller - Cell Broadcast Centre (BSC-CBC) interface specification; + Cell Broadcast Service Protocol (CBSP) + https://www.3gpp.org/DynaReport/48049.htm - [[[3gpp-ts-48-056]]] 3GPP TS 48.056: Base Station Controller - Base Transceiver Station (BSC - BTS) interface; Layer 2 specification https://www.3gpp.org/DynaReport/48056.htm -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id1504cb8f9331f36b6085d238a43fe041703ab23 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: bibliography: Add reference to TS 48.049 (CBSP)

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 ) Change subject: bibliography: Add reference to TS 48.049 (CBSP) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id1504cb8f9331f36b6085d238a43fe041703ab23 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 13 May 2022 08:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: Add CBSP port number to default list of ports

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 ) Change subject: Add CBSP port number to default list of ports ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifff8eb076bef29a64d9d20237fe5c8ee402788dc Gerrit-Change-Number: 28095 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 13 May 2022 08:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: port_numbers: Add missing records for osmo-upf, pfcp-tool, hnodeb

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28097 ) Change subject: port_numbers: Add missing records for osmo-upf, pfcp-tool, hnodeb ...................................................................... port_numbers: Add missing records for osmo-upf, pfcp-tool, hnodeb Seems like the instructions for adding new port numbers were not followed when those entires were added to https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers Change-Id: Ie077bc375d45202f6004d0a3d45e5fc772d5641d --- M common/chapters/port_numbers.adoc 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/97/28097/1 diff --git a/common/chapters/port_numbers.adoc b/common/chapters/port_numbers.adoc index 5faf3cf..c86551d 100644 --- a/common/chapters/port_numbers.adoc +++ b/common/chapters/port_numbers.adoc @@ -52,6 +52,12 @@ |TCP|4269|telnet (VTY)|osmo-e1d |TCP|4271|telnet (VTY)|osmo-smlc |TCP|4272|Control Interface|osmo-smlc +|TCP|4273|telnet (VTY)|osmo-hnodeb +|TCP|4274|Control Interface|osmo-hnodeb +|TCP|4275|telnet (VTY)|osmo-upf +|TCP|4276|Control Interface|osmo-upf +|TCP|4277|telnet (VTY)|osmo-pfcp-tool +|TCP|4278|Control Interface|osmo-pfcp-tool |UDP|4729|GSMTAP|Almost every osmocom project |TCP|5000|A/IP|osmo-bsc, osmo-bsc_nat |UDP|23000|GPRS-NS over IP default port|osmo-pcu, osmo-sgsn, osmo-gbproxy -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie077bc375d45202f6004d0a3d45e5fc772d5641d Gerrit-Change-Number: 28097 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: Add CBSP port number to default list of ports

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 ) Change subject: Add CBSP port number to default list of ports ...................................................................... Add CBSP port number to default list of ports Change-Id: Ifff8eb076bef29a64d9d20237fe5c8ee402788dc --- M common/chapters/port_numbers.adoc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/95/28095/1 diff --git a/common/chapters/port_numbers.adoc b/common/chapters/port_numbers.adoc index 477c3b3..5faf3cf 100644 --- a/common/chapters/port_numbers.adoc +++ b/common/chapters/port_numbers.adoc @@ -55,6 +55,7 @@ |UDP|4729|GSMTAP|Almost every osmocom project |TCP|5000|A/IP|osmo-bsc, osmo-bsc_nat |UDP|23000|GPRS-NS over IP default port|osmo-pcu, osmo-sgsn, osmo-gbproxy +|TCP|48049|BSC-CBC (CBSP) default port|osmo-bsc, osmo-cbc |=============== //// ATTENTION: Keep this list in sync with all of: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifff8eb076bef29a64d9d20237fe5c8ee402788dc Gerrit-Change-Number: 28095 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: bibliography: Add reference to TS 48.049 (CBSP)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 ) Change subject: bibliography: Add reference to TS 48.049 (CBSP) ...................................................................... bibliography: Add reference to TS 48.049 (CBSP) Change-Id: Id1504cb8f9331f36b6085d238a43fe041703ab23 --- M common/chapters/bibliography.adoc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/96/28096/1 diff --git a/common/chapters/bibliography.adoc b/common/chapters/bibliography.adoc index 06b1fb4..9d635b0 100644 --- a/common/chapters/bibliography.adoc +++ b/common/chapters/bibliography.adoc @@ -141,6 +141,10 @@ (GPRS); Base Station System (BSS) - Serving GPRS Support Node (SGSN); BSS GPRS protocol (BSSGP) https://www.3gpp.org/DynaReport/48018.htm +- [[[3gpp-ts-48-049]]] 3GPP TS 48.049: Digital cellular communications system; + Base Station Controller - Cell Broadcast Centre (BSC-CBC) interface specification; + Cell Broadcast Service Protocol (CBSP) + https://www.3gpp.org/DynaReport/48049.htm - [[[3gpp-ts-48-056]]] 3GPP TS 48.056: Base Station Controller - Base Transceiver Station (BSC - BTS) interface; Layer 2 specification https://www.3gpp.org/DynaReport/48056.htm -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id1504cb8f9331f36b6085d238a43fe041703ab23 Gerrit-Change-Number: 28096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: "Warning Security Information is always present in ETWS

by laforge

Attention is currently required from: fixeria. laforge has removed pespin from this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28094 ) Change subject: smscb: "Warning Security Information is always present in ETWS ...................................................................... Removed reviewer pespin. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1b8e4af37b1f9f9398b81dad29942e82218c70b Gerrit-Change-Number: 28094 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: "Warning Security Information is always present in ETWS

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28094 ) Change subject: smscb: "Warning Security Information is always present in ETWS ...................................................................... smscb: "Warning Security Information is always present in ETWS As per TS 48.049 Table 8.1.3.1.1 the WRITE-REPLACE message always has a Warning Security Information IE if it relates to ETWS. This is also implemented in the libosmocore CBSP parser. As the previous Change Id369bb3676ba279bafc234378fbe21dbc7b0614b has pointed out, the CBSP parser structure doesn't even permit any way of handing a decoded message to us without the warning_sec_info static struct member. So as a result, there's also no need to dynamically allocate bts_etws_state.input.sec_info via talloc. We can have it in-line as a static struct member and reduce code complexity and runtime memory allocations. Change-Id: Ib1b8e4af37b1f9f9398b81dad29942e82218c70b --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/smscb.c 2 files changed, 4 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/28094/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index cb20b9e..6df7c61 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -29,6 +29,7 @@ #include <osmocom/gsm/rxlev_stat.h> #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/gsm/protocol/gsm_12_21.h> +#include <osmocom/gsm/protocol/gsm_03_41.h> #include <osmocom/abis/e1_input.h> #include <osmocom/bsc/meas_rep.h> #include <osmocom/bsc/acc.h> @@ -1098,7 +1099,7 @@ uint16_t msg_id; uint16_t serial_nr; uint16_t warn_type; - uint8_t *sec_info; + uint8_t sec_info[ETWS_SEC_INFO_SIZE]; } input; /* encoded ETWS primary notification */ uint8_t primary[ETWS_PRIM_NOTIF_SIZE]; diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 3a06697..8e2eb0c 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -70,9 +70,7 @@ osmo_store16be(serial_nr, out); etws->msg_id = osmo_htons(msg_id); etws->warning_type = osmo_htons(warn_type); - - if (sec_info) - memcpy(etws->data, sec_info, ETWS_PRIM_NOTIF_SIZE - sizeof(*etws)); + memcpy(etws->data, sec_info, ETWS_PRIM_NOTIF_SIZE - sizeof(*etws)); return ETWS_PRIM_NOTIF_SIZE; } @@ -557,18 +555,11 @@ } } - if (bes->input.sec_info) { - talloc_free(bes->input.sec_info); - bes->input.sec_info = NULL; - } - /* copy over all the data to per-BTS private state */ bes->input.msg_id = wrepl->msg_id; bes->input.serial_nr = wrepl->new_serial_nr; bes->input.warn_type = wrepl->u.emergency.warning_type; - bes->input.sec_info = talloc_named_const(bts, ETWS_SEC_INFO_SIZE, "etws_sec_info"); - if (bes->input.sec_info) - memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); + memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, sizeof(bes->input.sec_info)); /* generate the encoded ETWS PN */ gen_etws_primary_notification(bes->primary, bes->input.serial_nr, bes->input.msg_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1b8e4af37b1f9f9398b81dad29942e82218c70b Gerrit-Change-Number: 28094 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022