May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,b...

by pespin

Attention is currently required from: laforge. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 to look at the new patch set (#6). Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ...................................................................... Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc This allows different parts of the code to hook to some signals which allow start/stopping processes based, for instance, on whether C0 is available or not. This can be later used by paging or CBSP code. Also ACC code can be ported to this new system (acc_ramp_nm_sig_cb()). Same signal can be used for other NM objects, but is left unimplemented until there's use for them. Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 --- M include/osmocom/bsc/nm_common_fsm.h M include/osmocom/bsc/signal.h M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_common_fsm.c M src/osmo-bsc/nm_rcarrier_fsm.c 5 files changed, 73 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/46/28046/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 Gerrit-Change-Number: 28046 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Use ARRAY_SIZE macro

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28104 to look at the new patch set (#2). Change subject: coding: Use ARRAY_SIZE macro ...................................................................... coding: Use ARRAY_SIZE macro Change-Id: I6b7a2a3a7be6a1d92038ff3b249e539fcd0f639e --- M src/coding/gsm0503_coding.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/28104/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6b7a2a3a7be6a1d92038ff3b249e539fcd0f639e Gerrit-Change-Number: 28104 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in docker-playground[master]: osmocom-bb-host-master: modernize

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28101 ) Change subject: osmocom-bb-host-master: modernize ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File osmocom-bb-host-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/28101/comment/dfed1153_919… PS1, Line 9: MAINTAINER Harald Welte <laforge(a)gnumonks.org> > It's deprecated: https://docs.docker. […] Good to know, thanks! grep shows that we still use it quite a lot, so I think we may want to remove it from all Dockerfiles (in a separate change)? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I78e0445a1b82e5cd72ecaa86e8fe25516b19f485 Gerrit-Change-Number: 28101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 12:06:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Use ARRAY_SIZE macro

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28104 ) Change subject: coding: Use ARRAY_SIZE macro ...................................................................... coding: Use ARRAY_SIZE macro Change-Id: I6b7a2a3a7be6a1d92038ff3b249e539fcd0f639e --- M src/coding/gsm0503_coding.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/28104/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 493f957..e2bbb9b 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -547,7 +547,7 @@ return res; coded_len = osmo_conv_encode(code, output, recoded); - OSMO_ASSERT(sizeof(recoded) / sizeof(recoded[0]) >= coded_len); + OSMO_ASSERT(ARRAY_SIZE(recoded)) >= coded_len); /* Count bit errors */ if (n_errors) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6b7a2a3a7be6a1d92038ff3b249e539fcd0f639e Gerrit-Change-Number: 28104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Refactor function to avoid gcc false positive warn

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28102 ) Change subject: coding: Refactor function to avoid gcc false positive warn ...................................................................... Patch Set 1: (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/28102/comment/4022bdec_22461e3f PS1, Line 548: sizeof(recoded) / sizeof(recoded[0]) > Actually it's not related to this patch, can be done in a preceding change. I'll submit an extra patch for that. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9 Gerrit-Change-Number: 28102 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 12:02:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: osmo-arfcn: Fix false positive in gcc 12.1.0

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28103 ) Change subject: osmo-arfcn: Fix false positive in gcc 12.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3eff4ab14a7b2a950386244c9b5f2b9adb32f99 Gerrit-Change-Number: 28103 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 11:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Refactor function to avoid gcc false positive warn

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28102 ) Change subject: coding: Refactor function to avoid gcc false positive warn ...................................................................... Patch Set 1: (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/28102/comment/fe4227fe_8f23c424 PS1, Line 548: sizeof(recoded) / sizeof(recoded[0]) > The linter suggests using ARRAY_SIZE() here. Actually it's not related to this patch, can be done in a preceding change. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9 Gerrit-Change-Number: 28102 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 11:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Refactor function to avoid gcc false positive warn

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28102 ) Change subject: coding: Refactor function to avoid gcc false positive warn ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/28102/comment/d0854885_1e4978f4 PS1, Line 548: sizeof(recoded) / sizeof(recoded[0]) The linter suggests using ARRAY_SIZE() here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9 Gerrit-Change-Number: 28102 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 11:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: osmo-arfcn: Fix false positive in gcc 12.1.0

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28103 ) Change subject: osmo-arfcn: Fix false positive in gcc 12.1.0 ...................................................................... osmo-arfcn: Fix false positive in gcc 12.1.0 The pointer is initialized in all its uses, however newer gcc warns about it: """ inlined from ‘main’ at /libosmocore/utils/osmo-arfcn.c:144:16: /usr/include/bits/stdlib-float.h:27:10: error: ‘param’ may be used uninitialized [-Werror=maybe-uninitialized] """ Change-Id: If3eff4ab14a7b2a950386244c9b5f2b9adb32f99 --- M utils/osmo-arfcn.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/28103/1 diff --git a/utils/osmo-arfcn.c b/utils/osmo-arfcn.c index 9e4534f..3d4fb50 100644 --- a/utils/osmo-arfcn.c +++ b/utils/osmo-arfcn.c @@ -93,7 +93,7 @@ { int arfcn, freq, pcs = 0, uplink = -1; int opt; - char *param; + char *param = NULL; enum program_mode mode = MODE_NONE; while ((opt = getopt(argc, argv, "pa:f:udh")) != -1) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3eff4ab14a7b2a950386244c9b5f2b9adb32f99 Gerrit-Change-Number: 28103 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: Refactor function to avoid gcc false positive warn

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28102 ) Change subject: coding: Refactor function to avoid gcc false positive warn ...................................................................... coding: Refactor function to avoid gcc false positive warn """ /libosmocore/src/coding/gsm0503_coding.c: In function 'osmo_conv_decode_ber_punctured': /libosmocore/src/coding/gsm0503_coding.c:563:31: error: 'coded_len' may be used uninitialized [-Werror=maybe-uninitialized] 563 | *n_bits_total = coded_len; | ~~~~~~~~~~~~~~^~~~~~~~~~~ /libosmocore/src/coding/gsm0503_coding.c:541:21: note: 'coded_len' was declared here 541 | int res, i, coded_len; | ^~~~~~~~~ """ This error is really a false positive. However, it is true that the code used to be a bit more complex than required, since the 2 later conditions could be inside the first one. Let's simply do early termination to simplify the function, and get rid of the gcc warning. Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9 --- M src/coding/gsm0503_coding.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/28102/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 835a18e..493f957 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -543,10 +543,11 @@ res = osmo_conv_decode(code, input, output); - if (n_bits_total || n_errors) { - coded_len = osmo_conv_encode(code, output, recoded); - OSMO_ASSERT(sizeof(recoded) / sizeof(recoded[0]) >= coded_len); - } + if (!n_bits_total && !n_errors) + return res; + + coded_len = osmo_conv_encode(code, output, recoded); + OSMO_ASSERT(sizeof(recoded) / sizeof(recoded[0]) >= coded_len); /* Count bit errors */ if (n_errors) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I31ebf0c4be61daf6395d9a9fac05c7fdceb8bcb9 Gerrit-Change-Number: 28102 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022