Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28099 )
Change subject: Add new Manuall "OsmoBSC CBSP Protocol Specification"
......................................................................
Patch Set 1:
(2 comments)
File doc/manuals/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/3443be7b_adde3ac2
PS1, Line 22: #
> What does '#' mean here?
it means the remainder is commented out as we have no msc nor dot files for this manual yet.
File doc/manuals/cbsp/messages.adoc:
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/20a69b0a_545167e0
PS1, Line 15: | TS 48.049 § | This document § | Message | <-/-> | Received/Sent by OsmoBSC
> Apparently it's indicating direction '<-' or '->'. […]
using the exact same format as osmobts-abis where we document differences from RSL/OML. As usual, I like consistency :P
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28099
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2e18e167281fac3abaf380089ff883738ebaa0a0
Gerrit-Change-Number: 28099
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 16:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28106 )
Change subject: */Dockerfile: drop MAINTAINER line
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28106
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If1ef3032af2075d792c526ae744ec4c0c091da3a
Gerrit-Change-Number: 28106
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 16:23:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28101 )
Change subject: osmocom-bb-host-master: modernize
......................................................................
osmocom-bb-host-master: modernize
Do not set up the Osmocom repository inside osmocom-bb-host-master, it
is done in debian-bullseye-build. Without this patch, we actually
installed the debian 9 version of libosmocore-dev in the debian 11
container.
This is part 1/2 of fixing TTCN3-centos-bts-test, which has been failing
since OSMOCOM_REPO_MIRROR was changed in osmo-ci.git. Part 2 is in
osmo-ci I8201f34a0f9747eea78c358a626cc3981d7407c4.
Change-Id: I78e0445a1b82e5cd72ecaa86e8fe25516b19f485
---
M osmocom-bb-host-master/Dockerfile
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile
index 3f9c108..21c7f31 100644
--- a/osmocom-bb-host-master/Dockerfile
+++ b/osmocom-bb-host-master/Dockerfile
@@ -1,24 +1,10 @@
ARG USER
ARG DISTRO
-ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org"
FROM $USER/$DISTRO-build
# Arguments used after FROM must be specified again
ARG DISTRO
-ARG OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org"
-
-MAINTAINER Harald Welte <laforge(a)gnumonks.org>
-
ARG OSMO_BB_BRANCH="master"
-ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/nightly/Debian_9.0/"
-
-COPY .common/Release.key /tmp/Release.key
-
-RUN apt-key add /tmp/Release.key && \
- rm /tmp/Release.key && \
- echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
-
-ADD $OSMOCOM_REPO/Release /tmp/Release
RUN apt-get update && \
apt-get install -y --no-install-recommends \
libosmocore-dev && \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I78e0445a1b82e5cd72ecaa86e8fe25516b19f485
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28101 )
Change subject: osmocom-bb-host-master: modernize
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
1+1=2
File osmocom-bb-host-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/28101/comment/ea6635ca_411…
PS1, Line 9: MAINTAINER Harald Welte <laforge(a)gnumonks.org>
> Good to know, thanks! grep shows that we still use it quite a lot, so I think we may want to remove […]
=> https://gerrit.osmocom.org/c/docker-playground/+/28106
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I78e0445a1b82e5cd72ecaa86e8fe25516b19f485
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 16:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105 )
Change subject: ggsn: Append IMEISV IE to CreatePdpCtxReq
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/6627655d_53ba…
PS1, Line 338: return int2oct(f_rnd_int(18446744073709551616), 8);
> There is a more elegant way to do this (see Osmocom_Types.f_rnd_imsi()): […]
Done
File library/GTP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/f7724c9a_3379…
PS1, Line 129:
> Usually no tab here, so function body is visually separated from its declaration.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00975328e94afd116e59c88fd96c5b0154810a1e
Gerrit-Change-Number: 28105
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 15:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105 )
Change subject: ggsn: Append IMEISV IE to CreatePdpCtxReq
......................................................................
Patch Set 1:
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/8d174739_b965…
PS1, Line 338: return int2oct(f_rnd_int(18446744073709551616), 8);
There is a more elegant way to do this (see Osmocom_Types.f_rnd_imsi()):
return hex2oct(f_rnd_hexstring(16, 10));
File library/GTP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/0a914183_227b…
PS1, Line 129:
Usually no tab here, so function body is visually separated from its declaration.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00975328e94afd116e59c88fd96c5b0154810a1e
Gerrit-Change-Number: 28105
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 15:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment