April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: CBSP: tr_CBSP_REPLACE_CBS_COMPL: num_compl_list is optional

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27966 ) Change subject: CBSP: tr_CBSP_REPLACE_CBS_COMPL: num_compl_list is optional ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/CBSP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27966/comment/ac950147_9031… PS1, Line 415: //ies[lengthof(ies)] := tr_CbspNumComplList ifpresent; what is this "ifpresent" keyword supposed to be doing? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b24ac7e5857bdd50a821399b3c383cea9d408ad Gerrit-Change-Number: 27966 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 17:05:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req_no_paging_load_ind

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 ) Change subject: bsc: Introduce test TC_paging_500req_no_paging_load_ind ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This one is still not passing because the estimated pace at which we need to send (around 8 req/s) is too slow, so the calculated T3113 seems to be expiring around request num 200 a bit before it is scheduled towards the BTS. So it seems something of the two below is still wrong: * T3113 calculation provides a value too low based on BSC queue load * transmit pace etimation (8 req/s) is way to low for a BTS with no CCCH paging Load. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I787cba895f1cb6c5bfef95259bcf69b4291a9237 Gerrit-Change-Number: 27970 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 27 Apr 2022 17:01:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: cbsp: Reject CBSP WRITE for emergency if emergency already active

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27963 ) Change subject: cbsp: Reject CBSP WRITE for emergency if emergency already active ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I376c9e796f3a2d26b22d0451f15ef1debbd7f656 Gerrit-Change-Number: 27963 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:54:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: cbsp: Implement KILL for Emergency Broadcast

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27962 ) Change subject: cbsp: Implement KILL for Emergency Broadcast ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie91939b93de6847eeb5d00c97a137c43721c2711 Gerrit-Change-Number: 27962 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: Always start ETWS timer even in cells without ETWS support

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27961 ) Change subject: smscb: Always start ETWS timer even in cells without ETWS support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I448be9fd75b87c1f7333a5bfa4f6ba238569fdc3 Gerrit-Change-Number: 27961 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: Store ETWS input state from CBSP

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27960 ) Change subject: smscb: Store ETWS input state from CBSP ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/3eda2319_7ff901ba PS1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n", voa? https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/eb67536b_e778cb14 PS1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); did you check previously you are not going to read out of buffer in wrepl here? by checking msg len or whatever. https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/205b1bea_5f1939ce PS1, Line 705: osmo_timer_del(&bts->etws.timer); not related to this patch, but you could delete this timer before setting it up in line 542, not sure if that's a good idea. I'd move the osmo_timer_setup to be called once during bts object creation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide74638880d7e3c6a7c774bf6320d3dce4b11c74 Gerrit-Change-Number: 27960 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:49:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: Don't include extraneous IEs in CBSP KILL COMPLETE / FAILURE

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27959 ) Change subject: smscb: Don't include extraneous IEs in CBSP KILL COMPLETE / FAILURE ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27959/comment/4cf5727b_7a4c4e45 PS1, Line 10: mesages: messages -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9a43d386da01f085663d231a555b8b5acc99faca Gerrit-Change-Number: 27959 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req_no_paging_load_ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 ) Change subject: bsc: Introduce test TC_paging_500req_no_paging_load_ind ...................................................................... bsc: Introduce test TC_paging_500req_no_paging_load_ind Change-Id: I787cba895f1cb6c5bfef95259bcf69b4291a9237 --- M bsc/BSC_Tests.ttcn 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/27970/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 64334de..29cb893 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3583,7 +3583,7 @@ } /* Verify BSC can schedule 500 paging requests under one minute if BTS buffer is good enough */ -testcase TC_paging_500req() runs on test_CT { +function f_TC_paging_500req(boolean send_pag_load_ind) runs on test_CT { var ASP_RSL_Unitdata rx_rsl_ud; const integer num_subscribers := 500; var hexstring imsis[num_subscribers]; @@ -3602,8 +3602,10 @@ /* Clear the queue, it might still contain stuff like BCCH FILLING */ IPA_RSL[0].clear; - /* Tell there's plenty of space at the BTS (UINT16_MAX): */ - f_ipa_tx(0, ts_RSL_PAGING_LOAD_IND(65535)); + if (send_pag_load_ind) { + /* Tell there's plenty of space at the BTS (UINT16_MAX): */ + f_ipa_tx(0, ts_RSL_PAGING_LOAD_IND(65535)); + } for (i := 0; i < num_subscribers; i := i + 1) { BSSAP.send(ts_BSSAP_UNITDATA_req(g_bssap[0].sccp_addr_peer, g_bssap[0].sccp_addr_own, @@ -3635,8 +3637,10 @@ } [] IPA_RSL[0].receive { repeat; } [] T_load_ind.timeout { - log("Tx CCH Load Ind, received paging requests so far: ", rx_paging_num); - f_ipa_tx(0, ts_RSL_PAGING_LOAD_IND(40)); + log("[CCH Load Ind timer] received paging requests so far: ", rx_paging_num); + if (send_pag_load_ind) { + f_ipa_tx(0, ts_RSL_PAGING_LOAD_IND(40)); + } T_load_ind.start; repeat; } @@ -3648,6 +3652,15 @@ f_shutdown_helper(); } +/* Verify BSC can schedule 500 paging requests under one minute if BTS buffer is good enough */ +testcase TC_paging_500req() runs on test_CT { + f_TC_paging_500req(true); +} +/* Same as TC_paging_500req, but without sending CCCH Load Indication, which + * means BTS is always under CCH Load Threshold, aka capable of sending tons of requests */ +testcase TC_paging_500req_no_paging_load_ind() runs on test_CT { + f_TC_paging_500req(false); +} /* Test RSL link drop causes counter increment */ testcase TC_rsl_drop_counter() runs on test_CT { @@ -11535,6 +11548,7 @@ execute( TC_paging_counter() ); execute( TC_paging_resp_unsol() ); execute( TC_paging_500req() ); + execute( TC_paging_500req_no_paging_load_ind() ); execute( TC_rsl_drop_counter() ); execute( TC_rsl_unknown_unit_id() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I787cba895f1cb6c5bfef95259bcf69b4291a9237 Gerrit-Change-Number: 27970 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: f_TC_paging_500req: Improve logging and checks

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27958 to look at the new patch set (#2). Change subject: bsc: f_TC_paging_500req: Improve logging and checks ...................................................................... bsc: f_TC_paging_500req: Improve logging and checks Change-Id: I08f93ad3170c218bf5e1847613f36e7690dc0908 --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/27958/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08f93ad3170c218bf5e1847613f36e7690dc0908 Gerrit-Change-Number: 27958 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix TC_cbsp_write_then_kill expectations

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27967 ) Change subject: bsc: Fix TC_cbsp_write_then_kill expectations ...................................................................... bsc: Fix TC_cbsp_write_then_kill expectations A more clear reading of TS 48.049 is that the KILL COMPLETE should *only* contain a Cell List IE if it relates to an Emergency message; only the Number of Broadcasts Completed IE indicates successful cells. osmo-bsc fixes this in I9a43d386da01f085663d231a555b8b5acc99faca Change-Id: Ia50e50f9812d9934d35d32b25e1079240df04a82 Related: SYS#5906 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/27967/1 diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index b291546..5f470ab 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -800,8 +800,8 @@ /* expect to receive it once on the BTS */ var template (present) RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no); IPA_RSL[0].receive(tr_ASP_RSL_UD(tr)); - /* kill it, expecting non-empty completion list */ - f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=?, compl_list:=?, fail_list:=omit); + /* kill it, expecting non-empty completion list; success must be empty in case of CBS! */ + f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=omit, compl_list:=?, fail_list:=omit); } /* Write a message, then reset all messages */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia50e50f9812d9934d35d32b25e1079240df04a82 Gerrit-Change-Number: 27967 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022