April 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: coding: simplify detect_ahs_id_marker()

by pespin

Attention is currently required from: Hoernchen, laforge, tnt, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 ) Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called. Not sure if this is really worth it, specially since this may be called lots of times. I'd like others to comment on this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 14:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by pespin

Attention is currently required from: osmith, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 4: (8 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/b76cff2b_0f44ed7c PS4, Line 9: * Drop hardcoded features for osmo-bts and nanobts Be careful here, nanobts may support some features it doesn't report, since there may be feature enums which we added ourselves? So it's possibel that for nanobts we may need some? Or we can simply check bts_is_nanobts() or alike? File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c891f570_fae480ca PS4, Line 302: /* BTS reports features on start up. When false, BTS model features get "on start up" -> "during OML bring up". https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/55713f26_8387244c PS4, Line 303: * copied to BTS features. */ "features during object initialization". Actually, for the case of nanobts we may use both things: set up some during _init(), and some during OML bring up. https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/e8a424e5_b6c5044a PS4, Line 347: bool features_set; I'd rather call it "features_present" or "feature_available" or "features_known", features_set may drive to cofusion, like it's a set of features. File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/10ce9564_82187e7c PS4, Line 507: if (bts->features_set) { Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above. https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6bcb5925_94fb34b8 PS4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data)); You still may want to copy them in case of nanobts. File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c02d8b63_8871d2be PS4, Line 498: bts_model_nanobts.features_get_reported = true; I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here. File src/osmo-bsc/bts_osmobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/f743f1f0_2e05ece1 PS4, Line 204: model_osmobts.features_get_reported = true; same, can be set in bts_model_nanobts directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 14:08:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:57:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: bts_trx_vty: adjust TSC warning message

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27953 ) Change subject: bts_trx_vty: adjust TSC warning message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I041150c9ce27caca6029ed54444562bb6cdcc57a Gerrit-Change-Number: 27953 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: bts_model_*_start: move set_feature calls to _init

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27952 ) Change subject: bts_model_*_start: move set_feature calls to _init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I43389ae48d5e0f01381602751f6bad902011b158 Gerrit-Change-Number: 27952 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by fixeria

Attention is currently required from: osmith, neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 4: (4 comments) File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/9b614c3c_433c3e8e PS4, Line 343: struct bitvec *ft const https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/c3a72264_5b484990 PS4, Line 355: if (!osmo_bts_has_feature(ft, BTS_FEAT_VAMOS)) { Not sure this check makes sense here. I would expect that all lchans to have 'vamos.enabled == false' at start up. Neels can definitely say more here. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/408917e9_1d766d4c PS4, Line 319: struct gsm_bts *bts const https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/1ebe2d03_0afb89a9 PS4, Line 342: struct gsm_bts *bts const -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: abis_nm_ipaccess_rsl_connect: initialize ia

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27951 ) Change subject: abis_nm_ipaccess_rsl_connect: initialize ia ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27951/comment/611a32e8_4c8c73de PS1, Line 3050: /* if ip == 0, we use the default IP */ what is the "default IP" here? It make make sense to fill ia with it in order to have meaningul logging. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc Gerrit-Change-Number: 27951 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: simplify detect_ahs_id_marker()

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27939 to look at the new patch set (#4). Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... coding: simplify detect_ahs_id_marker() This function is used to detect SID_{UPDATE,FIRST} frames by their identification marker, which is basically a fixed 9-bit sequence repeated 24 times, minus 4 tailing bits (212 bits total). Current code employs three for-loops in order to match the marker, but the same can be efficiently achieved with just one for-loop. Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 5 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/27939/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by fixeria

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27938 to look at the new patch set (#3). Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... coding: fix comments for detect_afs_sid_{first,update,onset} Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/27938/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/fd89c2ae_a6b7faa5 PS2, Line 347: * connected yet (thus not sent the feature vector), so we cannot know for > agreed. Patch updated. Now in vty commands the checks against bts features are skipped if the bts didn't report its features yet, and once the bts reports its features the relevant config options get validated again. If features are missing for the given config, the connection to the BTS gets dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Apr 2022 13:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022