February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 ) Change subject: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg ...................................................................... bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg Report: in inter-BSC incoming handover, when the MSC omits the Chosen Encryption Algorithm IE in the Handover Request message, then osmo-bsc starts an unencrypted lchan even if A5/0 is not permitted. This test verifies that the Encryption Information is present in the Channel Activation when the Chosen Enc Alg is omitted. Related: SYS#5839 Change-Id: Ia94cc29bf66339ed782cb5101f3640f69cf73131 --- M bsc/BSC_Tests.ttcn 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 69e187c..44916c4 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6131,6 +6131,22 @@ f_tc_ho_into_this_bsc_a5(f_encr_params('10'O)); } +/* Report: in inter-BSC incoming handover, when the MSC omits the Chosen Encryption Algorithm IE in the Handover Request + * message, then osmo-bsc starts an unencrypted lchan even if A5/0 is not permitted. + * + * This test verifies that the Encryption Information is present in the Channel Activation when the Chosen Enc Alg is + * omitted. + * + * Related: SYS#5839 + */ +testcase TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg() runs on test_CT { + f_tc_ho_into_this_bsc_a5(f_encr_params(alg_permitted := '0a'O, alg_expect := '08'O, alg_chosen := omit)); +} + +testcase TC_ho_into_this_bsc_a5_1_3() runs on test_CT { + f_tc_ho_into_this_bsc_a5(f_encr_params(alg_permitted := '0a'O, alg_expect := '08'O)); +} + testcase TC_ho_into_this_bsc_tla_v6() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); pars.host_aoip_tla := "::6"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94cc29bf66339ed782cb5101f3640f69cf73131 Gerrit-Change-Number: 27233 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... bsc: improve encryption testing config TestHdlrEncrParams Clean up: absorb pars.encr_exp_enc_alg into TestHdlrEncrParams as pars.encr.alg_expect. Remove the automagic encr alg choice from test procedures, instead put all magic in the pars.encr configuration setup; like this all encr alg values remain fixed through the tests, less confusing. Add separate alg_chosen for BSSMAP: So far, we have only one algorithm field for both the mask of permitted algorithms in the Encryption Information IS and the Chosen Encryption Algorithm IE. However, in the Chosen Enc Alg there must be only one bit set. Thus we cannot easily run a test where more than one alg is permitted and where the BSSMAP Chosen Enc Alg IE is involved. We've recently come to realize that the Chosen Encryption Algorithm IE may also be omitted from BSSMAP messages, in which case osmo-bsc should still work. To be able to test BSSMAP messages with omitted Chosen Encryption Algorithm, allow to set alg_chosen == omit. Keep t_EncrParams() in a way that all current tests (that set only one bit in alg_permitted) still run the same as they always did. Add t_EncrParams2() for a proper template. Add a convenience function to configure encryption testing. Related: SYS#5839 Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 93 insertions(+), 39 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index dadd5bf..69e187c 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1673,10 +1673,12 @@ var template BSSMAP_IE_KC128 kc128 := omit; if (ispresent(enc)) { var TestHdlrEncrParams v_enc := valueof(enc); - encryptionInformation := valueof(ts_BSSMAP_IE_EncrInfo(v_enc.enc_key, v_enc.enc_alg)); - chosenEncryptionAlgorithm := valueof( - ts_BSSMAP_IE_ChosenEncryptionAlgorithm(int2oct(enum2int( - f_cipher_mode_bssmap_to_rsl(v_enc.enc_alg)), 1))); + encryptionInformation := valueof(ts_BSSMAP_IE_EncrInfo(v_enc.enc_key, v_enc.enc_alg_permitted)); + if (ispresent(v_enc.enc_alg_chosen)) { + chosenEncryptionAlgorithm := valueof( + ts_BSSMAP_IE_ChosenEncryptionAlgorithm(int2oct(enum2int( + f_cipher_mode_bssmap_to_rsl(v_enc.enc_alg_chosen)), 1))); + } if (ispresent(v_enc.enc_kc128)) { kc128 := ts_BSSMAP_IE_Kc128(v_enc.enc_kc128); } @@ -3781,8 +3783,7 @@ var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); - pars.encr := valueof(t_EncrParams('05'O, f_rnd_octstring(8))); /* A5/0 and A5/2 (0x01|0x04)*/ - pars.encr_exp_enc_alg := '04'O; /* A5/2 */ + pars.encr := f_encr_params('05'O, '04'O); /* A5/0 and A5/2 (0x01|0x04)*/ f_init(1, true); f_vty_encryption_a5("0 1 2 3"); @@ -3797,8 +3798,7 @@ var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); - pars.encr := valueof(t_EncrParams('06'O, f_rnd_octstring(8))); /* A5/1 and A5/2 (0x02|0x04)*/ - pars.encr_exp_enc_alg := '02'O; /* A5/1 */ + pars.encr := f_encr_params('06'O, '02'O); /* A5/1 and A5/2 (0x02|0x04)*/ f_init(1, true); f_vty_encryption_a5("1 2"); @@ -6108,27 +6108,27 @@ f_shutdown_helper(); } -function f_tc_ho_into_this_bsc_a5(OCT1 encr_alg) runs on test_CT { +function f_tc_ho_into_this_bsc_a5(TestHdlrEncrParams encr) runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); - pars.encr := valueof(t_EncrParams(encr_alg, f_rnd_octstring(8), f_rnd_octstring(16))); + pars.encr := encr; f_tc_ho_into_this_bsc_main(pars); f_shutdown_helper(); } testcase TC_ho_into_this_bsc_a5_0() runs on test_CT { - f_tc_ho_into_this_bsc_a5('01'O); + f_tc_ho_into_this_bsc_a5(f_encr_params('01'O)); } testcase TC_ho_into_this_bsc_a5_1() runs on test_CT { - f_tc_ho_into_this_bsc_a5('02'O); + f_tc_ho_into_this_bsc_a5(f_encr_params('02'O)); } testcase TC_ho_into_this_bsc_a5_3() runs on test_CT { - f_tc_ho_into_this_bsc_a5('08'O); + f_tc_ho_into_this_bsc_a5(f_encr_params('08'O)); } testcase TC_ho_into_this_bsc_a5_4() runs on test_CT { - f_tc_ho_into_this_bsc_a5('10'O); + f_tc_ho_into_this_bsc_a5(f_encr_params('10'O)); } testcase TC_ho_into_this_bsc_tla_v6() runs on test_CT { diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 109194b..c2b49c8 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -550,17 +550,85 @@ } type record TestHdlrEncrParams { - OCT1 enc_alg, + /* A mask of multiple encryption algorithms, for Encryption Information IE. */ + OCT1 enc_alg_permitted, + /* Expect this encryption algorithm in Channel Activation from the BSC. + * To expect no encryption, set to '01'O == A5/0. */ + OCT1 enc_alg_expect, + /* In BSSMAP, the Chosen Encryption Algorithm IE that the test sends to the BSC. + * When set to omit, the MSC will not send a Chosen Encryption Algorithm IE. */ + OCT1 enc_alg_chosen optional, octetstring enc_key, octetstring enc_kc128 optional }; -template (value) TestHdlrEncrParams t_EncrParams(OCT1 alg, octetstring key, template (omit) octetstring kc128 := omit) := { - enc_alg := alg, +template (value) TestHdlrEncrParams t_EncrParams(OCT1 alg_permitted, + octetstring key, template (omit) octetstring kc128 := omit) := { + enc_alg_permitted := alg_permitted, + enc_alg_expect := alg_permitted, /* <- for compat with tests before enc_alg_expect was added */ + enc_alg_chosen := alg_permitted, /* <- for compat with tests before enc_alg_chosen was added */ enc_key := key, enc_kc128 := kc128 } +template (value) TestHdlrEncrParams t_EncrParams2(OCT1 alg_permitted, + OCT1 alg_expect, + template(omit) OCT1 alg_chosen, + octetstring key, + template (omit) octetstring kc128 := omit) := { + enc_alg_permitted := alg_permitted, + enc_alg_expect := alg_expect, + enc_alg_chosen := alg_chosen, + enc_key := key, + enc_kc128 := kc128 +} + +/* Convenience for common t_EncrParams2 usage. + * + * To test a scenario where only A5/3 is permitted: + * f_encr_params('08'O); + * To test a scenario where A5/3 is chosen from A5/0,A5/1,A5/3 (1 | 2 | 8 = 11 = 0xb): + * f_encr_params('0b'O, '08'O); + * To test the same, but the Chosen Encryption Algorithm IE should reflect A5/1: + * f_encr_params('0b'O, '08'O, '02'O); + * To test the same, but the MSC sends no Chosen Encryption Algorithm IE: + * f_encr_params('0b'O, '08'O, omit); + * + * Set alg_chosen and alg_expect magically when == '00'O: + * - enc_alg_expect is set to alg_chosen if present, else to alg_permitted. + * - enc_alg_chosen is set to alg_permitted. + * When only alg_permitted is given, alg_permitted must reflect only one algorithm, or f_cipher_mode_bssmap_to_rsl() + * will fail. + * When alg_chosen is passed as omit, the messages from the MSC will not contain a Chosen Encryption Algorithm IE. + */ +function f_encr_params(OCT1 alg_permitted, OCT1 alg_expect := '00'O, template (omit) OCT1 alg_chosen := '00'O, + boolean kc128 := false) + return TestHdlrEncrParams +{ + if (not istemplatekind(alg_chosen, "omit")) { + if (valueof(alg_chosen) == '00'O) { + if (alg_expect != '00'O) { + alg_chosen := alg_expect; + } else { + /* In this case, alg_permitted should have only one permitted algo */ + alg_chosen := alg_permitted; + } + } + if (alg_expect == '00'O) { + alg_expect := valueof(alg_chosen); + } + } + if (alg_expect == '00'O) { + /* In this case, alg_permitted should have only one permitted algo */ + alg_expect := valueof(alg_permitted); + } + var template octetstring kc := omit; + if (kc128) { + kc := f_rnd_octstring(16); + } + return valueof(t_EncrParams2(alg_permitted, alg_expect, alg_chosen, f_rnd_octstring(8), kc)); +} + type record TestHdlrParamsLcls { GlobalCallReferenceValue gcr optional, /* LCLS Configuration */ @@ -588,7 +656,6 @@ RSL_IE_Body expect_mr_conf_ie optional, /* typically present for AMR codecs */ bitstring expect_mr_s0_s7 optional, /* typically present for AMR codecs */ TestHdlrEncrParams encr optional, - OCT1 encr_exp_enc_alg optional, /* if set, expect a different enc_alg than encr.enc_alg */ TestHdlrParamsLcls lcls, SCCP_PAR_Address sccp_addr_msc optional, SCCP_PAR_Address sccp_addr_bsc optional, @@ -618,7 +685,6 @@ expect_mr_conf_ie := omit, expect_mr_s0_s7 := omit, encr := omit, - encr_exp_enc_alg := omit, lcls := { gcr := omit, cfg := omit, @@ -740,24 +806,12 @@ else if (alg_bssmap == '80'O) { return RSL_ALG_ID_A5_7; } else { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm: " & + oct2str(alg_bssmap)); return RSL_ALG_ID_A5_0; } } -function f_cipher_mode_bssmap_to_rsl_exp_enc_alg() runs on MSC_ConnHdlr return RSL_AlgId -{ - var OCT1 enc_alg; - - if (ispresent(g_pars.encr_exp_enc_alg)) { - enc_alg := g_pars.encr_exp_enc_alg; - } else { - enc_alg := g_pars.encr.enc_alg; - } - - return f_cipher_mode_bssmap_to_rsl(enc_alg); -} - function f_verify_encr_info(RSL_Message rsl) runs on MSC_ConnHdlr { var RSL_IE_Body encr_info; var RSL_AlgId alg_rsl; @@ -776,7 +830,7 @@ /* RSL uses a different representation of the encryption algorithm, * so we need to convert first */ - alg_rsl := f_cipher_mode_bssmap_to_rsl_exp_enc_alg(); + alg_rsl := f_cipher_mode_bssmap_to_rsl(g_pars.encr.enc_alg_expect); if (alg_rsl == RSL_ALG_ID_A5_4 and ispresent(g_pars.encr.enc_kc128)) { expect_kc := g_pars.encr.enc_kc128; @@ -820,9 +874,9 @@ var RSL_Message rsl; if (isvalue(enc.enc_kc128)) { - BSSAP.send(ts_BSSMAP_CipherModeCmdKc128(enc.enc_alg, enc.enc_key, valueof(enc.enc_kc128))); + BSSAP.send(ts_BSSMAP_CipherModeCmdKc128(enc.enc_alg_permitted, enc.enc_key, valueof(enc.enc_kc128))); } else { - BSSAP.send(ts_BSSMAP_CipherModeCmd(enc.enc_alg, enc.enc_key)); + BSSAP.send(ts_BSSMAP_CipherModeCmd(enc.enc_alg_permitted, enc.enc_key)); } alt { @@ -843,7 +897,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Cipher Mode Complete"); } else { setverdict(pass); - var RSL_AlgId alg_rsl := f_cipher_mode_bssmap_to_rsl_exp_enc_alg(); + var RSL_AlgId alg_rsl := f_cipher_mode_bssmap_to_rsl(g_pars.encr.enc_alg_expect); if (oct2int(bssap.pdu.bssmap.cipherModeComplete.chosenEncryptionAlgorithm.algorithmIdentifier) != enum2int(alg_rsl)) { setverdict(fail, "Unexpected Encryption Algorithm ID in BSSMAP Cipher Mode Complete"); } @@ -941,11 +995,11 @@ var RSL_IE_Body ms_power_param; var RSL_IE_Body ms_power; - if (ispresent(g_pars.encr) and g_pars.encr.enc_alg != '01'O) { + if (ispresent(g_pars.encr) and g_pars.encr.enc_alg_permitted != '01'O) { if (not f_rsl_find_ie(chan_act, RSL_IE_ENCR_INFO, encr_info)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Missing Encryption IE in CHAN ACT"); } else { - var RSL_AlgId alg := f_cipher_mode_bssmap_to_rsl_exp_enc_alg(); + var RSL_AlgId alg := f_cipher_mode_bssmap_to_rsl(g_pars.encr.enc_alg_expect); var octetstring expect_key; if (alg == RSL_ALG_ID_A5_4) { expect_key := g_pars.encr.enc_kc128; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 ) Change subject: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94cc29bf66339ed782cb5101f3640f69cf73131 Gerrit-Change-Number: 27233 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 16:06:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 16:06:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > A bit hard to follow due to many changes in a single patch. Not going to block you though. thought of separating it but it seemed simple enough, sorry, next time -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 16:06:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Makefile: Include hnbgw in SUBDIRS

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27240 ) Change subject: Makefile: Include hnbgw in SUBDIRS ...................................................................... Makefile: Include hnbgw in SUBDIRS Change-Id: I04616434cf8b5e67b67803040c3a03e4a0e3d182 --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/27240/1 diff --git a/Makefile b/Makefile index 91c826c..1d5e670 100644 --- a/Makefile +++ b/Makefile @@ -24,6 +24,7 @@ gbproxy \ ggsn_tests \ hlr \ + hnbgw \ hnodeb \ mgw \ mme \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04616434cf8b5e67b67803040c3a03e4a0e3d182 Gerrit-Change-Number: 27240 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_srvcc_eutran_to_geran_src_sai

by osmith

Attention is currently required from: neels, pespin, fixeria, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27225 ) Change subject: bsc: Introduce test TC_srvcc_eutran_to_geran_src_sai ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I186b9b9436bf82bcd54ca348df1e5e4b6424ca6e Gerrit-Change-Number: 27225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 14:18:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement/generate TLV and IE value coding

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27222 ) Change subject: libosmo-pfcp: implement/generate TLV and IE value coding ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Have a look at https://github.com/sysmocom/open5gs/blob/pespin/gtp1/lib/core/ogs-tlv-msg.h and .c it may give you ideas on how to define messages too. File src/libosmo-pfcp/gen__pfcp_ies_auto.c: https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/fb498e4a_c54511d7 PS1, Line 42: .dec_enc = "32be", we should have enums for this imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7 Gerrit-Change-Number: 27222 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:34:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27221 ) Change subject: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It would be interesting to know how did you generate all this. By Hand? ope5ngs uses python scripts to parse types, messages, etc. from spec files. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I568b821e89007ed52eeefcdbcb6edd8052a8b5be Gerrit-Change-Number: 27221 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-tlv: add auto dec/enc to/from structs

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27218 ) Change subject: libosmo-tlv: add auto dec/enc to/from structs ...................................................................... Patch Set 1: (2 comments) File include/osmocom/tlv/tlv_dec_enc.h: https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/e240fd96_68a88369 PS1, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0, This is not really clear. What's the difference between ORDERED_SAME and ORDERED? https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/421a08a9_42697e5d PS1, Line 135: * In this example, the nested IEs decode/encode to different goo sub structs depending on the tag value. goo? the table game? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022