February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: libosmo-tlv: add versatile TLV de- and encoder

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-tlv: add versatile TLV de- and encoder ...................................................................... Patch Set 1: (4 comments) File include/osmocom/tlv/tlv.h: https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/d52ae8f0_aa2de0ac PS1, Line 102: unsigned int tag; Isn't this duplicated in load_tl callback? File src/libosmo-tlv/tlv.c: https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/c5393a85_847a0f4b PS1, Line 256: static int t16l16v_load_tl(unsigned int *tag, size_t *len, const uint8_t **val, See my comment below for store_tl, it also applies here. https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/ce0d5b13_c0dcb6bf PS1, Line 266: static int t16l16v_store_tl(uint8_t *dst_data, size_t dst_data_avail, unsigned int tag, size_t len, From my experience after looking at open5gs TLV parser, these callbacks can avoided. As you can see, t16l16v_store_tl and t8l8v_store_tl are basically doing the same steps, but with different parameters. So you can avoid users needs to implement functions or this code calling functions pointers by simply storing some parameters in osmo_tlv_cfg: uint8_t tag_byte_len; uint8_t length_byte_len; You could also add tag_max_val = UINT16_MAX to the struct, and so on. Then this store_tl function can use all that anb become a static generic function. https://gerrit.osmocom.org/c/osmo-upf/+/27217/comment/a0a4f786_bd224b55 PS1, Line 275: osmo_store16be(tag, dst_data); You may want to also support setting instance in the API, to avoid API breakage in the future when we want to use it in more places. See open5gs lib/core/*tlv*.{c,h} for different types of TLVs. https://github.com/sysmocom/open5gs/blob/pespin/gtp1/lib/core/ogs-tlv.h#L32 The presence of Instance byte can also be then configured in tlv_config->instance_byte_len. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:06:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 ) Change subject: bsc: add TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94cc29bf66339ed782cb5101f3640f69cf73131 Gerrit-Change-Number: 27233 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: improve encryption testing config TestHdlrEncrParams

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 ) Change subject: bsc: improve encryption testing config TestHdlrEncrParams ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6590ecf4a146dbed494d9d72f5a79441877e9010 Gerrit-Change-Number: 27234 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:29:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File tests/ranap_rab_ass/ranap_rab_ass_test.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199/comment/6da2503f_7a26ba25 PS3, Line 305: ranap_rab_ass_req_ies_check_release(&message.msg.raB_AssignmentRequestIEs, 23); Same as previous patch. Add a test with a different ID not found. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 ) Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File tests/ranap_rab_ass/ranap_rab_ass_test.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139/comment/9c71d3a1_4c3204c0 PS2, Line 285: rab_failed_at_hnb = Maybe add another case where you pass another ID to test the "not found" path. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:22:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24)

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 ) Change subject: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) ...................................................................... upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/rebar.config b/rebar.config index 86444dd..0803ccd 100644 --- a/rebar.config +++ b/rebar.config @@ -2,7 +2,7 @@ {deps, [ {setup, "2.0.2"}, - {lager, "3.6.8"}, + {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "laforge/wip"}}}, {osmo_gsup, {git, "git://git.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: switch back to use the master branch of osmo_ss7

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 ) Change subject: switch back to use the master branch of osmo_ss7 ...................................................................... switch back to use the master branch of osmo_ss7 Add the missing ipa_ccm_options record to use the new api Change-Id: I89ff055ed84e394d0f25bc6389d1f4d757f7b92b --- M rebar.config M src/gsup_client.erl 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/rebar.config b/rebar.config index 0803ccd..66db6b5 100644 --- a/rebar.config +++ b/rebar.config @@ -3,7 +3,7 @@ {deps, [ {setup, "2.0.2"}, {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, - {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "laforge/wip"}}}, + {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "master"}}}, {osmo_gsup, {git, "git://git.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 361864f..6a583e0 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -36,6 +36,7 @@ -behaviour(gen_server). -include_lib("osmo_gsup/include/gsup_protocol.hrl"). +-include_lib("osmo_ss7/include/ipa.hrl"). -define(IPAC_PROTO_EXT_GSUP, {osmo, 5}). @@ -65,8 +66,19 @@ % register the GSUP codec with the IPA core; ignore result as we mgiht be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), + CcmOptions = #ipa_ccm_options{ + serial_number="HSS-00-00-00-00-00-00", + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name="HSS-00-00-00-00-00-00" + }, case ipa_proto:connect(Address, Port, Options) of {ok, {Socket, IpaPid}} -> + ipa_proto:set_ccm_options(Socket, CcmOptions), lager:info("connected!~n", []), true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I89ff055ed84e394d0f25bc6389d1f4d757f7b92b Gerrit-Change-Number: 26698 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: switch back to use the master branch of osmo_ss7

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 ) Change subject: switch back to use the master branch of osmo_ss7 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I89ff055ed84e394d0f25bc6389d1f4d757f7b92b Gerrit-Change-Number: 26698 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:18:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24)

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 ) Change subject: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) Patchset: PS2: The 2 patches (this one and next one) are needed to have jenkins pass. Manually adding +1 verified myself. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 17 Feb 2022 12:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24)

by pespin

Attention is currently required from: laforge, pespin. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 ) Change subject: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022