December 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: osmo-stat-dummy: add rate counters and statsd tester

by fixeria

Attention is currently required from: laforge, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30301 ) Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... Patch Set 19: (1 comment) Patchset: PS17: > I've added README to clarify. […] Having config examples in random, non standard locations is not definitely not a good idea, IMO. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 04 Dec 2022 13:10:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo-stat-dummy: add rate counters and statsd tester

by msuraev

Attention is currently required from: laforge, fixeria, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30301 ) Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... Patch Set 19: (1 comment) Patchset: PS17: > The osmo-stat-dummy.cfg should most likely go to 'doc/examples/'. […] I've added README to clarify. Regarding doc/examples/ it only make sense only if we install osmo-stat-dummy which I'm not convinced is worth doing. Let's see what others think. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 04 Dec 2022 12:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by msuraev

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30302 to look at the new patch set (#9). Change subject: rate_ctr: convert to timerfd ...................................................................... rate_ctr: convert to timerfd Use timerfd to schedule 1-second periodic timer once instead rescheduling every second in timer callback. Related: OS#5671 Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 --- M src/rate_ctr.c 1 file changed, 46 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/30302/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo-stat-dummy: add rate counters and statsd tester

by msuraev

Attention is currently required from: laforge, pespin, msuraev. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30301 to look at the new patch set (#19). Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... osmo-stat-dummy: add rate counters and statsd tester It's handy for testing rate counters as well as statsd metrics. Related: OS#5671 Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 --- M .gitignore M utils/Makefile.am A utils/README A utils/osmo-stat-dummy.c A utils/osmo-stat-dummy.cfg A utils/osmo-stat-dummy.html 6 files changed, 452 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/30301/19 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by msuraev

Attention is currently required from: laforge, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... Patch Set 7: (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/dc20c609_9c1b8a7e PS7, Line 365: } w > won't this have an overflow issue? what if tmier_ticks + expire count wraps the 64bit value and ends […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 04 Dec 2022 12:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by msuraev

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30302 to look at the new patch set (#8). Change subject: rate_ctr: convert to timerfd ...................................................................... rate_ctr: convert to timerfd Use timerfd to schedule 1-second periodic timer once instead rescheduling every second in timer callback. Related: OS#5671 Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 --- M src/rate_ctr.c 1 file changed, 48 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/30302/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: telnet_init_dynif: don't allow negative port

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30443 ) Change subject: telnet_init_dynif: don't allow negative port ...................................................................... telnet_init_dynif: don't allow negative port Binding to a negative port should not be allowed. Using signed value for unsigned parameter is a mistake to begin with. Change-Id: I24f957641f2d8e230ccceb331a719496df0fdb1f --- M src/vty/telnet_interface.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index 1758860..3fcae6e 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -80,6 +80,9 @@ { int rc; + if (port < 0) + return -EINVAL; + tall_telnet_ctx = talloc_named_const(tall_ctx, 1, "telnet_connection"); 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I24f957641f2d8e230ccceb331a719496df0fdb1f Gerrit-Change-Number: 30443 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: telnet_init_dynif: propagate error

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30442 ) Change subject: telnet_init_dynif: propagate error ...................................................................... telnet_init_dynif: propagate error Return actual error from osmo_sock_init_ofd() to the caller. Change-Id: Ib09f4315b3868ec031ecbced8a63069e7c2de7da --- M src/vty/telnet_interface.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index 132cd2e..1758860 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -94,7 +94,7 @@ if (rc < 0) { LOGP(DLGLOBAL, LOGL_ERROR, "Cannot bind telnet at %s %d\n", ip, port); - return -1; + return rc; } LOGP(DLGLOBAL, LOGL_NOTICE, "Available via telnet %s %d\n", ip, port); 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib09f4315b3868ec031ecbced8a63069e7c2de7da Gerrit-Change-Number: 30442 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: telnet_init_dynif: don't allow negative port

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30443 ) Change subject: telnet_init_dynif: don't allow negative port ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I24f957641f2d8e230ccceb331a719496df0fdb1f Gerrit-Change-Number: 30443 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 04 Dec 2022 10:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: telnet_init_dynif: propagate error

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30442 ) Change subject: telnet_init_dynif: propagate error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib09f4315b3868ec031ecbced8a63069e7c2de7da Gerrit-Change-Number: 30442 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 04 Dec 2022 10:05:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022