December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: up_gtp_action_to_str_buf(): always print PDR IDs

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30457 ) Change subject: up_gtp_action_to_str_buf(): always print PDR IDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I16dae4d693850435e98e8ba18ea4ab339ee28e23 Gerrit-Change-Number: 30457 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:44:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: VTY: show gtp: still list tunmap if no tunend device is open

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30456 ) Change subject: VTY: show gtp: still list tunmap if no tunend device is open ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9a43a240f2ca55cf2ca237a83aa13e68a625d6ea Gerrit-Change-Number: 30456 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: Send raw data with mISDN as it arrives from application

by laforge

Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30450 ) Change subject: Send raw data with mISDN as it arrives from application ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Are you sure this won't break any existing applications? So far we did not push this responsibility into applications. An application can just enqueue data into the write queue, and it's the responsibility of e1_input to sned it with the speed that the driver/hardware/network supports. For DAHDI and osmo-e1d, we have file descriptors (device node, unix domain socket) which simply block once the transmit buffer is full and the line is not consuming data at the rate that is arriving from the application. So the flow/rate is controlled by the file descriptor becoming write-able. And exactly this is where mISDN differs, and libosmo-abis/e1_input needs to ensure the same semantics towards the application. marking as -1 until we are absolutely certain -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib311331fbbeff3661f6745e3474918987a8aa460 Gerrit-Change-Number: 30450 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:43:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: Initialize devinfo at misdn.c

by laforge

Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30449 ) Change subject: Initialize devinfo at misdn.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3a60eee96366561acac9ccfc92eb0d6ca828b7b9 Gerrit-Change-Number: 30449 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:39:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: Remove mISDN header from received channel data

by laforge

Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30448 ) Change subject: Remove mISDN header from received channel data ...................................................................... Patch Set 1: (2 comments) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/6e546296_f4885856 PS1, Line 376: ms you can do msg->l2h = msgb_pull(msg, MISDN_HEADER_LEN). Or you could even keep "msg->l2h = msg->data + MISDN_HEADER_LEN;" and then call msgb_pull_to_l2(msg). I think the last options is most clear, but it's not critical. https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/cc9a8c7a_2475f6c6 PS1, Line 459: msgb_pull(msg, MISDN_HEADER_LEN); same here -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I37f12baa1013cd1cfc6f6531b132669071eec926 Gerrit-Change-Number: 30448 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: Add missing functions to send HDLC/RAW data

by laforge

Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30447 ) Change subject: Add missing functions to send HDLC/RAW data ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iebcb99f491b945d364b1044a59638524637dd8b2 Gerrit-Change-Number: 30447 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: Fix support for HDLC/RAW type channels at mISDN.c

by laforge

Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30446 ) Change subject: Fix support for HDLC/RAW type channels at mISDN.c ...................................................................... Patch Set 1: (2 comments) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/f62af4b8_cfd759b2 PS1, Line 502: LOGL_DEBUG Not critical, but given this is quite unexpected, I would guess this migth be worth a higher level than debug? notice? https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/1dd3d75a_06b1f828 PS1, Line 690: /* TS 16 is the D-channel, so we use D-channel proto */ : bfd->fd = socket(PF_ISDN, SOCK_DGRAM, : (ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC); the problem here is that it makes assumptions. For [public] ISDN it is defined trhat signaling is (only) on TS16. But that's not always the caase - nor is TS16 always the only channel used for signaling. Futhermore, who says that all libosmo-abis users will always want to run in NT mode? Also: I'm wondering why we didn't need this so far? Even for actual Abis, we have simply used E1INP_TS_TYPE_SIGN with ISDN_P_B_HDLC (as seen below) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie9a2a3f6ae1ad7da1711b6ff2f0aeda39839a427 Gerrit-Change-Number: 30446 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: improve error log for unknown netinst

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/30462 ) Change subject: improve error log for unknown netinst ...................................................................... improve error log for unknown netinst When a Network Instance name is not known, hint in the error log that an entry needs to be added to the 'netinst' section of the cfg. Related: SYS#6192 Change-Id: Ifdc0e7ec0d7b62b0127a5daa76cf48a932fcaf72 --- M src/osmo-upf/up_session.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/62/30462/1 diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index e17b319..90bb49a 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -156,8 +156,10 @@ } else { netinst = netinst_find(&g_upf->netinst, netinst_name); if (!netinst) { - LOGPFSML(session->fi, LOGL_ERROR, "Network Instance from PFCP request not found: %s\n", - osmo_quote_str_c(OTC_SELECT, netinst_name, -1)); + LOGPFSML(session->fi, LOGL_ERROR, "Network Instance from PFCP request not found: %s" + " -- ensure there is a 'netinst' / 'add %s <ip-addr>' entry in your config\n", + osmo_quote_str_c(OTC_SELECT, netinst_name, -1), + osmo_escape_str_c(OTC_SELECT, netinst_name, -1)); return OSMO_PFCP_CAUSE_RULE_CREATION_MOD_FAILURE; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifdc0e7ec0d7b62b0127a5daa76cf48a932fcaf72 Gerrit-Change-Number: 30462 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: log: add missing sep in far_to_str

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/30463 ) Change subject: log: add missing sep in far_to_str ...................................................................... log: add missing sep in far_to_str Change-Id: I1789cdb65b1e355d28cb6d22c8a18e011c202383 --- M src/osmo-upf/up_session.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/63/30463/1 diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 90bb49a..38be5ff 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -305,6 +305,7 @@ if (f->forw_params_present) { OSMO_STRBUF_PRINTF(sb, " dst:%s", osmo_pfcp_dest_iface_str(f->forw_params.destination_iface)); if (f->forw_params.outer_header_creation_present) { + OSMO_STRBUF_PRINTF(sb, ","); OSMO_STRBUF_APPEND(sb, osmo_pfcp_ie_outer_header_creation_to_str_buf, &f->forw_params.outer_header_creation); } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I1789cdb65b1e355d28cb6d22c8a18e011c202383 Gerrit-Change-Number: 30463 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: fix PFCP Session Mod: Update FAR

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/30464 ) Change subject: fix PFCP Session Mod: Update FAR ...................................................................... fix PFCP Session Mod: Update FAR Fix parsing of the Update FAR information so that a Session Modification Request properly causes a GTP action to become active: Add missing forw_params_present = true, and copy the information from the incoming message instead of the current state. Related: SYS#6192 Change-Id: I2a2c015d5615bb461b4d7b476a7c9830dc8e130f --- M src/osmo-upf/up_session.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/64/30464/1 diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 38be5ff..915dd75 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -257,22 +257,23 @@ if (upd->upd_forw_params_present) { const struct osmo_pfcp_ie_upd_forw_params *u = &upd->upd_forw_params; struct osmo_pfcp_ie_forw_params *p = &far->desc.forw_params; + far->desc.forw_params_present = true; if (u->destination_iface_present) p->destination_iface = u->destination_iface; if (u->network_inst_present) { - p->network_inst = p->network_inst; + p->network_inst = u->network_inst; p->network_inst_present = true; } if (u->outer_header_creation_present) { - p->outer_header_creation = p->outer_header_creation; + p->outer_header_creation = u->outer_header_creation; p->outer_header_creation_present = true; } if (u->linked_te_id_present) { - p->linked_te_id = p->linked_te_id; + p->linked_te_id = u->linked_te_id; p->linked_te_id_present = true; } if (u->destination_iface_type_present) { - p->destination_iface_type = p->destination_iface_type; + p->destination_iface_type = u->destination_iface_type; p->destination_iface_type_present = true; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2a2c015d5615bb461b4d7b476a7c9830dc8e130f Gerrit-Change-Number: 30464 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022