This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/vlr has been updated discards d403c05fc11ecbb4ca6ebc6bb28506ada4dbe135 (commit) discards f96af61242c353acd2ed6cb2d8048edc42d95c57 (commit) discards 95e4770a889de5e7cd42b8c02d36d9e9700e7931 (commit) discards dcf09c998709e78af7f026896417a020bfdaa1eb (commit) discards 8ea55754fc3715094ced1e544f22cc249b1bdf11 (commit) discards 4985fdee1432739692db8c5482a92336bf497235 (commit) discards f681dddd2342945d8fa2a0e2a37df11490e6e95a (commit) discards bbb3f7f5e1ee3e3d47b2eb2027f1e5eee01ea584 (commit) discards f2908c89915d000c6a59252e86d1c594cb032f2a (commit) discards f462943d19200049d695cd66000b545231dd7389 (commit) discards 0e3bdfc006aef75f43eba4b02a06c10c97921077 (commit) discards d65a5e1eb57602f65891fd5aef31d439f0550418 (commit) discards 5517e924e73853fa401cbb192d243958571e68dc (commit) discards 7497b84b170653ecf33223b62eac4d8ab1367977 (commit) discards b23ebdaefdcaf527159f0a17da6a81a7cdfc9555 (commit) discards 67da528272ad392749e2d1025896756a3def881d (commit) discards ecc3316a116642f1994387528bd969c42faa2838 (commit) discards 85525d77029db61179326b13f44fa702443587aa (commit) discards f6b1a63c99757e53fcab892c7e30cc162f4a5cdd (commit) discards 109b8de508e53fe255fcb2b47d2851fe2743481d (commit) discards 11dc20d51c6f9ceeb69b544cd0bec526204e9a35 (commit) discards b349136cf46203c5e15de31260b10ed51c468511 (commit) discards cee5a4c8808c4038e1f3719d35bf0dbb8e5cd61a (commit) discards 9c1fa8fa0c71d20d7504f62562814f969b818072 (commit) discards e2d82d51465d96ba8bc365623be2ce410ebcf90d (commit) discards 9e4df0857773366ecbe3dbde86145fe0b1c6b9f8 (commit) discards 23e2a688a3a371913a6c6c979c636a474e26ba8d (commit) discards 0d78f2509853af77d11e05fbe3dec7e7fd62c73d (commit) discards 80708411bd963e11aea48225a3c6f26262ca498c (commit) discards 96a75a8e97c19ee57972f0d1dbbe8a916ba8c797 (commit) discards bb130905d17e377bf8ac902c4ca82adac1a73ad5 (commit) discards 7462197fac2ff454d7ffd13dccfe3c69a5b90582 (commit) discards 0825a2c4f371feccae8912fae4fae3ff5122e195 (commit) discards 9422a1607d938130a3d12e473fd005414f7f5b40 (commit) discards 7f9baf9531789ed9e6cf5f319df206dcf6114d71 (commit) discards f3a7388d5c5102be2fefba617b6ffba239a819d0 (commit) discards d6796d00e9fc4a2c3ca554d3e1e961db820fa12a (commit) discards 958221d1949a737d6723caf57d5b6cbde748282c (commit) discards 19fe12f74bb7aeec3e39473ef052a5b1186f4905 (commit) discards e416071fd192ac7039f979021c60d1c62e398bcc (commit) discards 62a0bef9197be16b9801cd6d7e1e16d550d7eb54 (commit) discards e4bf1fb1fd70b35aa6f8b23b49b26ff23d803f92 (commit) discards cb154483ee0c9825bc09b0fbb4d62de2ecc50b1b (commit) discards fa14e9b0e68c88ed03d11eeffeca7c7823bed706 (commit) discards 7897f7d98ff789151f0c2ba96d80fe115b976d19 (commit) discards b63770f9e875993937794c9ba541ea1e49060db3 (commit) discards 79b287a61e23a95a86759c635270c5622aab9a30 (commit) discards 49422db7b3cc8ccaf9eb8331e7e5f92350c60f37 (commit) discards 97fab6d4b4e22cf2ebcb6018923f62993239d4e9 (commit) discards 1b8fb2550e193f2e76ca95a3c284cf482db8fb42 (commit) discards 7de782afef9c021b2bb9e12f9f69ff3c3515dc1c (commit) discards 4593ab666a2298b44f1ab0283a698ca10d4fb0e9 (commit) discards fe3a060923b1d8e7c3689ce71bb00162a0956c6a (commit) discards 12760b429cbb2d3b101121e60e1a739c808bc0cf (commit) discards ecbc60ac87fc83bd1b45c5fb1a3df92b54be99bb (commit) discards 89b2b273f4d1eee452402fe8729b632ade2c81f6 (commit) discards 1215298e8769ced017a3de0dd4f9889ecd9d60fc (commit) discards 9260e296e090ce4ec49365a70fbbf48971e3fb1c (commit) discards 68a0908eccdd2683297e4f3123139d32144ae000 (commit) discards a4abda06e67b1f80f6d44abf18cc9173dcd68767 (commit) discards b62833b3f2180a6067e723f65ad37b3f59d3835e (commit) discards 79528939ca6b6938c75c698e4f3a8a5323e49d6b (commit) discards a063b9086163c178a9da0fd16273b2dac6413049 (commit) discards b70d8fce0ffb09ab27104832900981f46bc8a764 (commit) discards 14586e2a55be96725256f97689a553772918e351 (commit) discards 6fc3068a076462ad221172ac4e7134a73f3a1305 (commit) discards a23b4ff0fa06ee690ec8c410f64b324d2abb1e0c (commit) discards 0f8cd0a9552b4907ccac8aa84acc63e1c0ea9850 (commit) discards d81cb11d5b0de57c31db664fb39ab124c4fb9277 (commit) discards 966c7e59965eff0cda5c17e123cedeb85248161f (commit) discards 6d10eee83476ed03a01d25632e6aadf7c2ae75b6 (commit) discards 27190f409697d45c4653071029041a3f1c748771 (commit) discards f16e556c515353db8547fd71ca3a3ae17b535a59 (commit) discards 0fec61b52f0d1e621c4e4a8abb163389c6d34473 (commit) discards 21c5c324dd3842d940eb8a90a7f408c71a4948a3 (commit) discards f51bd0e74d7abc7d5854cfa6a012ddc0250b4c64 (commit) discards 6b3386f0328e4d7c227f224e4befa728fe526960 (commit) discards f98206e3c5e848e1a8f3b8845e05af2fb087c6fa (commit) discards 40ade554981831a3b75eec6afe1d23a63ad626a0 (commit) discards 98cf3be76acf827c5105a9bade405c7f5b570965 (commit) discards 5e3b8de0f2135261c8d4e7dfcb1d910644f8e86c (commit) discards f4a71a4612020e0139bfbf96b3636942d4783210 (commit) discards 109799291e668d243a9157189e6721b11355347a (commit) discards 6ee640b663fc61814cdb550d755b6ef266d79be3 (commit) discards a328488fa86137dcfa618121ff7e5be3eaf33bd0 (commit) discards 54db8c2ec711dfec19a6e2741c502b1c23308fb6 (commit) discards fce6291229fe78f5ecaa4f36ceb5afb86fd13943 (commit) discards 20a16983126cc3f291ac3637bf8f7b94ce812c2e (commit) discards 253bdec4bcbeb43e46dd6b0cd421da4aacf954df (commit) discards 09170e762e8e6f88ede2ee504095004ec4aa2cbb (commit) discards 955c8c91c59849cd600f232612c92a9bb56ed38c (commit) discards 33fea034352ee549f9eeb3dac4df6bc8bd9fe955 (commit) discards c21672756999d5bd408fdd6dd6ce124adb7d14d7 (commit) discards 73c31f8d8b00fbcb719d1b1174904a3ef5829d22 (commit) discards 8b70e85b54025533ddb3a7695217badfe7857c32 (commit) discards 0d06bcc77502f8df260afaac43ad203670caaf6c (commit) discards a152feb9f412416a5a1eb78aa8276fd43e73fa64 (commit) discards 889f04a8e5881c791faf1e6625cfd829757f8ace (commit) discards 3d42dfeef60320a42562222afd50881bde3fbad5 (commit) discards 88271079b059c69684f5eb8bd9f526e16bcea229 (commit) discards 665a0c0fb841eeec7ca1642dae3c9bd075e2c154 (commit) discards df060a728d14943f6ed8a9483ab0a8b6a0a2ab65 (commit) discards 87db85c005acd27e54d96756de1f8a9661aa4984 (commit) discards d29a03354ea6055b05118a6b41bfd97ebeda074c (commit) via 2bbaa172197eca1962ef90b9637637d3d34e9193 (commit) via e0992f6096c9a9b11fe8449e74edd446bcf9f99a (commit) via 03b24052a55dbfbc42f7de7c484e21871aff8493 (commit) via 3651526c4594c9f02078cc382c7946f9080f6f73 (commit) via 6a55939550890f9078ed9b6fd3681fd866d35846 (commit) via 738ab2123523f5634ac5db735916baa202d410f0 (commit) via 42a9a0ef9bfe01e757e27b1696c064ca0081cf95 (commit) via f197c1baa384bdde99cc00db21211033f8d52e32 (commit) via c7d82f0fc753d0b4a994ce57c9242f142b618753 (commit) via d6a72d6a343b680683536fea63fea15a7bb2bc23 (commit) via a3ba2bba6c08e0b82330953c9cbdccdd03c0cb0e (commit) via 785ec06c4dceb026a5a1162d787bb21e0bd9f93c (commit) via 80243f7ad0e5dedaa4d1a1e0e0f574d89d68003e (commit) via a4b48fcf5d10d38e00647e92c3884e6259872b22 (commit) via 440337fb6d07520b61c76d13775008d9458e7112 (commit) via 55e25dfd700931977cc3143ec67b46086f00eab7 (commit) via 1dcc6b4c3bc6b57e5cf8b581887fdf46d948c136 (commit) via e7631dffd5e274de510e9bf372a24852a593a54b (commit) via a0d16128e450f024460bb1b87dce443163eb877d (commit) via 2a29de205898feab0df3b1e0fcd3e60c409f160b (commit) via f66c423d3e6598a9b56c5bcdf91894e8ae329c18 (commit) via 417d7700a12c6a2ac6349231849f2e157a83f9da (commit) via 68b788b55b11458d2dc6614dbd3d5adc221c372c (commit) via 54bb6695331c9d3efac0f40b10b6167dc7f3ac30 (commit) via c3c8638ed23e6efd6823871c502881beae4c52e4 (commit) via 947a6e1fc1f776c6aa1fb13e6d3987285401e9a5 (commit) via 86d7e9ccb0d79e56ca0f8f0c239715a577169633 (commit) via af229e8c6ce8929837d833aa8c77da780f30dea9 (commit) via 2245d52d3bdee96ca75f50b8683081866316352e (commit) via 5c3be0798659aad0315ff2de104e1d176e2cd97f (commit) via f2903369766966b1aae1d994d5fa61f0b0921ed3 (commit) via 87868b5dc8c2e349e7d166ec20d4931879d0114f (commit) via 19de589b83ee8a97764d3055ae24781b749e902a (commit) via 8d6e095e2fe18548afbb0b3775126aa84df9dffd (commit) via 77968e14d89f54a52b227f253f8177876ead1e53 (commit) via c47fd8f02daf959520dfd198fe44d53b836b0ff8 (commit) via 999bef07e4e24be7d330b19c41da00865e7c5107 (commit) via 07aba9d956c93d53154c34bbe1e909e77f0bd8c5 (commit) via 58ee92573c7ec524df749528be097f0bba0d5235 (commit) via efc0b391e210a8cb84aa1016b7e835198ac8dcde (commit) via 969a57630a07f7a034566deb647430de271a025d (commit) via 820b0ff10b6e343c6d96eef1631273362b9b3935 (commit) via e2c26981156a6fa4d5f4603159e2deded3a4dfc2 (commit) via ea8189aba65ea14a4595a9267ce92a618619e2ee (commit) via ba4a2695981b641f15b072297fe3a6e2f3bd633a (commit) via 24e50e459760d8f80f66a3facd6755295024ddbe (commit) via 0f0600f3171d1d8035f9701d204f8f949d8f5548 (commit) via f3fcaa8c74b293b1a22a6973857901a76c7c4a41 (commit) via 5e4277f6c162d5bb3d74d4e62aeabb17f0e5a090 (commit) via eb6cf011563e63fe338be8c3e0b365d5823fdae6 (commit) via b4f24f4dabb80ddb218f466a39fca65e1b27dfa8 (commit) via 5dfbd39ee0b9a1bfff9d21c25d479df353418588 (commit) via 689beec4ad698d28eb2fd0016a6f427ecb59a9d6 (commit) via e3877baee19e9b962c89d13746d0185f10d8459b (commit) via 5ea49699a04296e23338a8818c2ec9f08bcdf785 (commit) via 9fc011ae032ce2f47c132f0bc8418bad451dc7c7 (commit) via 8eed17d32b7978864198e47f171eb14c2a979266 (commit) via e2be8c4cfe99d88cb25b797c51145b117676c778 (commit) via 332f135a2340d3fe3b8544742242b2c4d66a8dd8 (commit) via f83381cca8a103a06b88289f5a216d37de428b00 (commit) via b8ee32e67217590bbaf367865e474f50443254e6 (commit) via c260241d94c8811c8f2c76477318bf24921e4679 (commit) via 57e63c34f2b65f3ae7f8c56839134dec6ad626f2 (commit) via b2e2381ad0dbf02a6c0847146fe1c485608c42f9 (commit) via 99cdc15b7ceb4636ea0d95ee0d13a9450298bf34 (commit) via 3f20f9b41f37c77f43ef340ac60aef3e49248452 (commit) via d2ec0e5ce5c67b301c3cef900b6504b6e03ca89e (commit) via 3a66b0224bd6f79b0a967b4c4cdd8d82dac2d4f1 (commit) via 201535ee84f85140496b282a3bb664c0a78072e5 (commit) via 21ae0bdf28eea6dc1c2e244354df7271dec9ae79 (commit) via 6c2986155820aa626bd5623df810b1eb8b63e33b (commit) via e6c01591e2c46f63f2b64914ec6d87a6663f4c08 (commit) via fb66b4f35f924d95b8bdb2ede24407c35b560c3b (commit) via a3634430f5ba2daad746c95f88ea40d0d8a78def (commit) via d8316d3064984a90211f41f29f465860da3f0059 (commit) via 796ee8bce82eae3b820b45000c7a69356e293942 (commit) via 63eb0d8cf88cec284da03d93135817eb541790ef (commit) via 2a2e28e53583c8ab419ce84422a1fc8a148c008b (commit) via dcba86f193df7d2821da04732da321a20536f9a6 (commit) via 0a26187cdb56f1e964fe9983e1219a0e710a280e (commit) via 051eef49bf1e8fb2231dfe6982abaf07fdf2788d (commit) via 61be33b2b22fd9c46a30c2f0f322da8808244a4a (commit) via 7b4c1eab5b91e94a3257236e2503869a763a2131 (commit) via 7e968f635566f92df87afe05d54d6603f8535001 (commit) via daa5f99cd73642655613cb916813fbd96db8ceb7 (commit) via 9f6e15ff34b404bae05d38f65487012efdcf10b2 (commit) via a91c1c9c2e9c15513102efae678066847fe8e528 (commit) via 82a3d104062e7e4cf3b8cb63e0577e19d29e75d2 (commit) via bf5f8eb659c2ddf52cf847f059f7e3ea49af1b59 (commit) via db5c863ca2e1ac5deedf13b4ae60b5a714046013 (commit) via 861020dff94bc08e787287bc7f3368e2705978f2 (commit) via 8064a878d4fdf396f5854248c79bcb6792bbb55e (commit) via 6e1652710920a6f8b26cacec7550c6874e8bb73e (commit) via 727a8fe112d0caee9dbbf38049eeb91a2d348783 (commit) via 6d866fc51ac1940987e4be86d5eb387c478e1633 (commit) via 48f0c79be1640fbcc9f7b45ccc93364ec18797d1 (commit) via bf643179bf9ac25ed6ae5173a79a82a117dae5fd (commit) via 3309ad3d0d1b25c5328ed3063b5be3f99bd9da20 (commit) via 8014bfb472989811dc9c000e0cd603a00166b130 (commit) via 8c2206bb9e9590b8311e64d93755aedcf31408fc (commit) via c62fca961f30ee11d691f67fb25e17bb2a231000 (commit) via 66e2ec9e777e5e3a98f9501e65401a441b38428b (commit) via b450f02310cdd29a916d4c3300167aa36b11f691 (commit) via fe346153dfe808a535e4d4ab6080beec5245f03e (commit) via 45cfeaa28c404e784724254f1859e8bdd09d609f (commit) via 40843036f3cea49b02b63827699fd944f2d91d46 (commit) via 4a5b676fb7be3cb27ab6d8b2450249766ddd8ff1 (commit) via 0f2ff80ecd222f60cce2fa5f513cd652e1dce256 (commit) via 69491224a794cf0931f6d35c03bc0f7e4a8d3cf1 (commit) via b25aa166486adf45f3e15553184f76a5c3546517 (commit) via 15e5b937986cc8967d4d9a933dcf05522711eb0b (commit) via 6778f35b5d54cf1afa3785cf50a89ae55f5e8708 (commit) via 35ea4433f0146e567d075f6cd4a348f3a1b27b04 (commit) via 815b347efe2b16813a8458e57e8d43f1d334e9f1 (commit) via b889e8b36300cad44b641cbd55ecaa556847652c (commit) via b0f7c79d2e5e5169eb71a07474421d25b1cefe29 (commit) via 52f57c50aca26c3110c34ae1c4e9f9ce308a8f3b (commit) via c7bffcf15cd318fcf405937a8c9c01a0b7d54dbe (commit) via 80abe522e2ddc979d994530f21b103808fc465d7 (commit) via 532480a705726452ace30b1a914640d984dd0418 (commit) via db142dc59dc8d79d8ee608c9165bc865d240b97d (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (d403c05fc11ecbb4ca6ebc6bb28506ada4dbe135) \ N -- N -- N (2bbaa172197eca1962ef90b9637637d3d34e9193) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=2bbaa172197eca1962ef90b9637637d3… commit 2bbaa172197eca1962ef90b9637637d3d34e9193 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 25 03:00:10 2016 +0100 subscr_conn_test Change-Id: Iba897235173c782ecb88d6d0049b62a2bd7ba5f8 http://cgit.osmocom.org/openbsc/commit/?id=e0992f6096c9a9b11fe8449e74edd446… commit e0992f6096c9a9b11fe8449e74edd446bcf9f99a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 25 02:59:31 2016 +0100 vlr: add vlr_sub_free Change-Id: I3be55b10d28276f4024d58eee9560fd82f2a9feb http://cgit.osmocom.org/openbsc/commit/?id=03b24052a55dbfbc42f7de7c484e2187… commit 03b24052a55dbfbc42f7de7c484e21871aff8493 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 23:55:35 2016 +0100 drop unused _gsm48_rx_mm_serv_req_sec_cb Change-Id: I4feb799002d0c05c7253b559c355d8469cd8b1eb http://cgit.osmocom.org/openbsc/commit/?id=3651526c4594c9f02078cc382c7946f9… commit 3651526c4594c9f02078cc382c7946f9080f6f73 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 25 04:55:28 2016 +0100 ciph Change-Id: Id253026531aef6e905c24b3e09618bebebd8af7c http://cgit.osmocom.org/openbsc/commit/?id=6a55939550890f9078ed9b6fd3681fd8… commit 6a55939550890f9078ed9b6fd3681fd866d35846 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 23:53:36 2016 +0100 add enum vlr_ciph Change-Id: Ie73ceae3d2f2977af12bf282faa39c397c96d555 http://cgit.osmocom.org/openbsc/commit/?id=738ab2123523f5634ac5db735916baa2… commit 738ab2123523f5634ac5db735916baa202d410f0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 23:35:01 2016 +0100 subscr_conn_test Change-Id: Ib8607db4b8e91a38bd8163445260971132669383 http://cgit.osmocom.org/openbsc/commit/?id=42a9a0ef9bfe01e757e27b1696c064ca… commit 42a9a0ef9bfe01e757e27b1696c064ca0081cf95 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 23:54:22 2016 +0100 vlr_loc_update fu: arg names Change-Id: If6c3ce41fb965fb76cd8fd809a353063ed2c701f http://cgit.osmocom.org/openbsc/commit/?id=f197c1baa384bdde99cc00db21211033… commit f197c1baa384bdde99cc00db21211033f8d52e32 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 25 05:03:05 2016 +0100 vlr cosmetic Change-Id: Ied4508e6817c11e1ad8551b7937aa6959134220b http://cgit.osmocom.org/openbsc/commit/?id=c7d82f0fc753d0b4a994ce57c9242f14… commit c7d82f0fc753d0b4a994ce57c9242f142b618753 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 23:34:55 2016 +0100 vlr_access_req_fsm: tweak state names with OSMO_STRINGIFY Change-Id: Ifdfe9b771e746fbd01b064eeb5b44a2e47db92fe http://cgit.osmocom.org/openbsc/commit/?id=d6a72d6a343b680683536fea63fea15a… commit d6a72d6a343b680683536fea63fea15a7bb2bc23 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 18:37:28 2016 +0100 subscr_conn_test Change-Id: If19abbe962c1cc75eac68453c1abb8c0f1f20c86 http://cgit.osmocom.org/openbsc/commit/?id=a3ba2bba6c08e0b82330953c9cbdccdd… commit a3ba2bba6c08e0b82330953c9cbdccdd03c0cb0e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 00:46:48 2016 +0100 subscr_conn_test Change-Id: I554cf64b634171662743e5dd39406c0f20d55481 http://cgit.osmocom.org/openbsc/commit/?id=785ec06c4dceb026a5a1162d787bb21e… commit 785ec06c4dceb026a5a1162d787bb21e0bd9f93c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 00:46:24 2016 +0100 vlr auth_fsm_states names tweak with OSMO_STRINGIFY Change-Id: I94f3b6f092fb3378f14a1d3c1b1bddbc5b1f06d3 http://cgit.osmocom.org/openbsc/commit/?id=80243f7ad0e5dedaa4d1a1e0e0f574d8… commit 80243f7ad0e5dedaa4d1a1e0e0f574d89d68003e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 00:45:56 2016 +0100 vlr_auth_fsm: fix: don't skip auth vector when checking availability factor out _vlr_sub_next_auth_tuple() to find an available tuple and only increase the use count in vlr_sub_get_auth_tuple(). Also provide vlr_sub_has_auth_tuple() to allow checking availability without use inc. Otherwise, during a CM Service request, the use count would increase without using the auth tuple. Change-Id: I8314fd5026adbe5ca15d3518300531473234c9b6 http://cgit.osmocom.org/openbsc/commit/?id=a4b48fcf5d10d38e00647e92c3884e62… commit a4b48fcf5d10d38e00647e92c3884e6259872b22 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 24 00:42:27 2016 +0100 tweak fsm_auth_event_names with OSMO_VALUE_STRING Change-Id: Ie72c2e008848f10f33005e0a75591e7bb8598e0d http://cgit.osmocom.org/openbsc/commit/?id=440337fb6d07520b61c76d13775008d9… commit 440337fb6d07520b61c76d13775008d9458e7112 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 22:04:03 2016 +0100 subscr_conn_test Change-Id: Iedfd7fbd0be6fa464aafa78304d36e4314b4cd1c http://cgit.osmocom.org/openbsc/commit/?id=55e25dfd700931977cc3143ec67b4608… commit 55e25dfd700931977cc3143ec67b46086f00eab7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 22:31:53 2016 +0100 vlr_auth_fsm.c: dont log the entire auth tuple Change-Id: Ieb8b2b6cca7a49cd3dcab3286462ef46c6ddba37 http://cgit.osmocom.org/openbsc/commit/?id=1dcc6b4c3bc6b57e5cf8b581887fdf46… commit 1dcc6b4c3bc6b57e5cf8b581887fdf46d948c136 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 22:03:26 2016 +0100 vlr: log: check_auth_resp: fix output of expected sres Change-Id: I596730551fd25b3cbc4ec2b71830019950845583 http://cgit.osmocom.org/openbsc/commit/?id=e7631dffd5e274de510e9bf372a24852… commit e7631dffd5e274de510e9bf372a24852a593a54b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 22:01:23 2016 +0100 tweak msg_is_initially_permitted Change-Id: I89268ad21f289f9c24421eb354fa19a26446267d http://cgit.osmocom.org/openbsc/commit/?id=a0d16128e450f024460bb1b87dce4431… commit a0d16128e450f024460bb1b87dce443163eb877d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 16:49:37 2016 +0100 subscr_conn_test Change-Id: If3285465b8deef3dd64ebbe1282d1c5d8bdc5134 http://cgit.osmocom.org/openbsc/commit/?id=2a29de205898feab0df3b1e0fcd3e60c… commit 2a29de205898feab0df3b1e0fcd3e60c409f160b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 02:53:18 2016 +0100 vlr_lu_fsm and vlr_lu_compl_fsm: enable result dispatch Distinguish success and failure; separate into alloc and start. Change-Id: I35f8183702e0b2f045dee96d706740c705477e9f http://cgit.osmocom.org/openbsc/commit/?id=f66c423d3e6598a9b56c5bcdf91894e8… commit f66c423d3e6598a9b56c5bcdf91894e8ae329c18 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 02:52:20 2016 +0100 proc_arq_fsm rename _signal_result to _dispatch_result Change-Id: I01df3d8b061789b541baf7f2028094f42df722f5 http://cgit.osmocom.org/openbsc/commit/?id=417d7700a12c6a2ac6349231849f2e15… commit 417d7700a12c6a2ac6349231849f2e157a83f9da Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 02:51:09 2016 +0100 debug log: remove pointer from log for deterministic test output Change-Id: I4607f5ba8872b1093d234a82027371fdd8fa5ac3 http://cgit.osmocom.org/openbsc/commit/?id=68b788b55b11458d2dc6614dbd3d5adc… commit 68b788b55b11458d2dc6614dbd3d5adc221c372c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 02:50:46 2016 +0100 do not ref count on subscr conn Change-Id: I103a1a6ea18a913295fc7b84f99d44b6b9a6325e http://cgit.osmocom.org/openbsc/commit/?id=54bb6695331c9d3efac0f40b10b6167d… commit 54bb6695331c9d3efac0f40b10b6167dc7f3ac30 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 05:24:06 2016 +0100 subscr_conn_test Change-Id: I96bd018407ae55ef88d9fcecf12c395998a37946 http://cgit.osmocom.org/openbsc/commit/?id=c3c8638ed23e6efd6823871c502881be… commit c3c8638ed23e6efd6823871c502881beae4c52e4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 04:49:04 2016 +0100 adjust msc_subscr_cleanup Change-Id: I840f808541d4ac3cdfd8e3cb3abf34b172c40e6d http://cgit.osmocom.org/openbsc/commit/?id=947a6e1fc1f776c6aa1fb13e6d398728… commit 947a6e1fc1f776c6aa1fb13e6d3987285401e9a5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 01:45:22 2016 +0100 log: gsm_04_08.c: change some logs from DEBUGPC to complete lines Change-Id: Ic255523c29bcd44f9487f22e204b9e0995d6b3ed http://cgit.osmocom.org/openbsc/commit/?id=86d7e9ccb0d79e56ca0f8f0c239715a5… commit 86d7e9ccb0d79e56ca0f8f0c239715a577169633 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 00:58:00 2016 +0100 subscr_con_put: disable implicit destruction on zero ref count Change-Id: I5a0307eef75b45f86a6bcc1eb4723489ef0d4c62 http://cgit.osmocom.org/openbsc/commit/?id=af229e8c6ce8929837d833aa8c77da78… commit af229e8c6ce8929837d833aa8c77da780f30dea9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 00:57:34 2016 +0100 osmo_signal_dispatch of S_SUBSC_IDENTITY before vlr starts Change-Id: I661e13ef689693d932c7cbe93f24831d07a23f5c http://cgit.osmocom.org/openbsc/commit/?id=2245d52d3bdee96ca75f50b868308186… commit 2245d52d3bdee96ca75f50b8683081866316352e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 00:56:47 2016 +0100 vlr proc arq fsm: refactor success/failure events Change-Id: I095f3ef101419f8d485c01c977644dd6ba6a748a http://cgit.osmocom.org/openbsc/commit/?id=5c3be0798659aad0315ff2de104e1d17… commit 5c3be0798659aad0315ff2de104e1d176e2cd97f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 23:37:44 2016 +0100 vlr ops Change-Id: I2f5b67ce26d818de7da48701bd38faab558a34e7 http://cgit.osmocom.org/openbsc/commit/?id=f2903369766966b1aae1d994d5fa61f0… commit f2903369766966b1aae1d994d5fa61f0b0921ed3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 23:37:34 2016 +0100 refactor conn_fsm events Change-Id: I358b92a9a028cf13c4477ccc3c695d48ed2af34f http://cgit.osmocom.org/openbsc/commit/?id=87868b5dc8c2e349e7d166ec20d49318… commit 87868b5dc8c2e349e7d166ec20d4931879d0114f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 23:15:51 2016 +0100 rename master_fsm to conn_fsm Change-Id: Idbd44dd6b10d68291e745a48b04466f720f9360a http://cgit.osmocom.org/openbsc/commit/?id=19de589b83ee8a97764d3055ae24781b… commit 19de589b83ee8a97764d3055ae24781b749e902a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 05:23:55 2016 +0100 wip Change-Id: I5c418c3ac0bc036deed27f5fa67e095d6a3e12cf http://cgit.osmocom.org/openbsc/commit/?id=8d6e095e2fe18548afbb0b3775126aa8… commit 8d6e095e2fe18548afbb0b3775126aa84df9dffd Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 05:23:11 2016 +0100 log: subscr and subscr_conn ref counts: log callers of get/put Change-Id: Iaec6385aad233be74f31924c0def3251e6caacfe http://cgit.osmocom.org/openbsc/commit/?id=77968e14d89f54a52b227f253f817787… commit 77968e14d89f54a52b227f253f8177876ead1e53 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 02:06:03 2016 +0100 subscr_conn_test Change-Id: I9f40a0036a10d146adb61e52d7b24a57d26ec2b0 http://cgit.osmocom.org/openbsc/commit/?id=c47fd8f02daf959520dfd198fe44d53b… commit c47fd8f02daf959520dfd198fe44d53b836b0ff8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 04:14:31 2016 +0100 log tweaks for conn use count / free in osmo_msc.c Change-Id: I25d0cccc8fe5b5ebba20dc8ee00faac7547dbe11 http://cgit.osmocom.org/openbsc/commit/?id=999bef07e4e24be7d330b19c41da0086… commit 999bef07e4e24be7d330b19c41da00865e7c5107 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 01:56:43 2016 +0100 subscr_conn Change-Id: I5f2873be1289522b88f316eef81cc713fb6e2f4f http://cgit.osmocom.org/openbsc/commit/?id=07aba9d956c93d53154c34bbe1e909e7… commit 07aba9d956c93d53154c34bbe1e909e77f0bd8c5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 03:35:46 2016 +0100 vlr: add VLR_PR_ARQ_T_INVALID Change-Id: I3464b9a11d7574884e32b43334afd8632dd3be46 http://cgit.osmocom.org/openbsc/commit/?id=58ee92573c7ec524df749528be097f0b… commit 58ee92573c7ec524df749528be097f0bba0d5235 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 01:58:33 2016 +0100 add check: msg_is_initially_permitted Change-Id: Ia03377b184fa1e8c7187e015fd3266f9a5552d81 http://cgit.osmocom.org/openbsc/commit/?id=efc0b391e210a8cb84aa1016b7e83519… commit efc0b391e210a8cb84aa1016b7e835198ac8dcde Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 01:57:23 2016 +0100 vlr_loc_update with success and fail term events Change-Id: I05cc0b71fe320d5b83fac09d04c8bfb19a1ed9da http://cgit.osmocom.org/openbsc/commit/?id=969a57630a07f7a034566deb647430de… commit 969a57630a07f7a034566deb647430de271a025d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 02:01:08 2016 +0100 fix vlr_access_req_fsm: set success_parent_term Change-Id: I6a7a57464685506950a41ea5c6f818169fc22cb9 http://cgit.osmocom.org/openbsc/commit/?id=820b0ff10b6e343c6d96eef163127336… commit 820b0ff10b6e343c6d96eef1631273362b9b3935 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 01:56:11 2016 +0100 rename to SUBSCR_CONN_ Change-Id: I1a03e17ef89f66d6975ac3a63eb88247ee83f93c http://cgit.osmocom.org/openbsc/commit/?id=e2c26981156a6fa4d5f4603159e2dede… commit e2c26981156a6fa4d5f4603159e2deded3a4dfc2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 17:21:37 2016 +0100 vlr: fix: dispatch subscr conn close event only when there is a master_fsm Change-Id: I66c688b0c2443540bb3ceee30d580653090658bf http://cgit.osmocom.org/openbsc/commit/?id=ea8189aba65ea14a4595a9267ce92a61… commit ea8189aba65ea14a4595a9267ce92a618619e2ee Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 01:52:45 2016 +0100 typo in comment Change-Id: I41da41494ab6d4b058f74d9ad231eec9889d48ab http://cgit.osmocom.org/openbsc/commit/?id=ba4a2695981b641f15b072297fe3a6e2… commit ba4a2695981b641f15b072297fe3a6e2f3bd633a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 01:52:37 2016 +0100 fix SUBSCR_CONN_S_ACCEPTED Change-Id: I40b70a8bf9d84964f6cf8cc3117bcf7ad2766e32 http://cgit.osmocom.org/openbsc/commit/?id=24e50e459760d8f80f66a3facd675529… commit 24e50e459760d8f80f66a3facd6755295024ddbe Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 01:52:13 2016 +0100 subscr_conn_fsm_event_names tweaks Change-Id: Ia7a4d8be4b35b2609e9b436e5cae64d93aa4a9e0 http://cgit.osmocom.org/openbsc/commit/?id=0f0600f3171d1d8035f9701d204f8f94… commit 0f0600f3171d1d8035f9701d204f8f949d8f5548 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 01:51:56 2016 +0100 logging tweaks Change-Id: Ic5d749fb427c7fed8470014c8cb88dbcfd1d4b3c http://cgit.osmocom.org/openbsc/commit/?id=f3fcaa8c74b293b1a22a6973857901a7… commit f3fcaa8c74b293b1a22a6973857901a76c7c4a41 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 21 02:04:45 2016 +0100 move some subscriber connection related things to subscr_conn.c Change-Id: I24f4c4676c2b67b1cc3632e021af5146eeff0ce3 http://cgit.osmocom.org/openbsc/commit/?id=5e4277f6c162d5bb3d74d4e62aeabb17… commit 5e4277f6c162d5bb3d74d4e62aeabb17f0e5a090 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 20 01:22:02 2016 +0100 vlr: cm serv req WIP Change-Id: I155d819f81e3e8dde221f3bf0c58fff43f9268c8 http://cgit.osmocom.org/openbsc/commit/?id=eb6cf011563e63fe338be8c3e0b365d5… commit eb6cf011563e63fe338be8c3e0b365d5823fdae6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 20 01:21:28 2016 +0100 vlr: log invocation of internal _proc_arq_vlr_* functions Change-Id: I711f88b56fff4b3900c1813fb2626d76062aa715 http://cgit.osmocom.org/openbsc/commit/?id=b4f24f4dabb80ddb218f466a39fca65e… commit b4f24f4dabb80ddb218f466a39fca65e1b27dfa8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 20 01:19:28 2016 +0100 vlr: tweak proc_arq_vlr_event_names Change-Id: I5d7eed109bcfcd1e3b0f22c01470b592e7a4c5f2 http://cgit.osmocom.org/openbsc/commit/?id=5dfbd39ee0b9a1bfff9d21c25d479df3… commit 5dfbd39ee0b9a1bfff9d21c25d479df353418588 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 20 01:18:57 2016 +0100 vlr: fix: no longer trigger old code to send CM Service Accept Change-Id: I80c7c978ab40dcd886899887d906b1d338c63418 http://cgit.osmocom.org/openbsc/commit/?id=689beec4ad698d28eb2fd0016a6f427e… commit 689beec4ad698d28eb2fd0016a6f427ecb59a9d6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 20 01:17:29 2016 +0100 vlr: add value strings for enum vlr_proc_arq_result Change-Id: I6ae82c34cf577e0113154474268c083535db9c85 http://cgit.osmocom.org/openbsc/commit/?id=e3877baee19e9b962c89d13746d0185f… commit e3877baee19e9b962c89d13746d0185f10d8459b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 04:07:29 2016 +0100 vlr: debug log: log received GSUP MSISDN Change-Id: I80c00862be880b58ada39d1585c7cbdbe96228ee http://cgit.osmocom.org/openbsc/commit/?id=5ea49699a04296e23338a8818c2ec9f0… commit 5ea49699a04296e23338a8818c2ec9f08bcdf785 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 03:51:11 2016 +0100 vlr: fix: decode GSUP MSISDN from BCD without leading '0' When using gsm48_mi_to_string() to decode the MSISDN, odd-length numbers are preceded by a leading zero, which may break things. Instead, use gsm48_decode_bcd_number() to do the job properly. E.g. when the hlr.db contains '12345', it gets encoded as bcd hex L=03 V=2143f5 in GSUP, which apparently gets right-justified to "012345" in gsm48_mi_to_string(). gsm48_decode_bcd_number()'s result is just "12345". However, to benefit from the available length (gsup_msg->msisdn_enc_len), provide a function decode_bcd_number_safe(), which adds input length checks to gsm48_decode_bcd_number() by means of an additional argument. Todo: maybe add such a length check to libosmocore, deprecating the original gsm48_decode_bcd_number(); add unit tests for the length checks and BCD decoding. Change-Id: Ia3428792562c3f7f4ba339d000536373e0513f8e http://cgit.osmocom.org/openbsc/commit/?id=9fc011ae032ce2f47c132f0bc8418bad… commit 9fc011ae032ce2f47c132f0bc8418bad451dc7c7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 02:46:41 2016 +0100 tmp log: ussd Change-Id: I5cc462111054207d8022ea801e9ef3a77d11d780 http://cgit.osmocom.org/openbsc/commit/?id=8eed17d32b7978864198e47f171eb14c… commit 8eed17d32b7978864198e47f171eb14c2a979266 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 04:10:19 2016 +0100 vlr: ussd: use vlr_subscriber's msisdn Change-Id: I1b4b0aa1ccb5417294148ca54572319d042aa8a7 http://cgit.osmocom.org/openbsc/commit/?id=e2be8c4cfe99d88cb25b797c51145b11… commit e2be8c4cfe99d88cb25b797c51145b117676c778 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 01:33:47 2016 +0100 vsub Change-Id: I2432fd147a2ae23341b58a6e744e397450057538 http://cgit.osmocom.org/openbsc/commit/?id=332f135a2340d3fe3b8544742242b2c4… commit 332f135a2340d3fe3b8544742242b2c4d66a8dd8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 00:00:12 2016 +0100 temp: osmo-nitb: log fsm addresses Change-Id: I242b6dc3793487a02f3f2d7d75d3416175ee7626 http://cgit.osmocom.org/openbsc/commit/?id=f83381cca8a103a06b88289f5a216d37… commit f83381cca8a103a06b88289f5a216d37de428b00 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 01:35:27 2016 +0100 vlr: lu_fsm: explicitly log the "_node*" functions Change-Id: Ib371280aef82fed6b8c270a05dc2a98d782c7027 http://cgit.osmocom.org/openbsc/commit/?id=b8ee32e67217590bbaf367865e474f50… commit b8ee32e67217590bbaf367865e474f50443254e6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 01:34:56 2016 +0100 cosmetic: fsm, state and event names by OSMO_STRINGIFY When reading logs and looking for bugs, it can be quite cumbersome to have to follow the given name strings back to a name used in the C code. Rather make the names identical to the C code enum values and struct names. Depends-on: libosmocore I857af45ae602bb9a647ba26cf8b0d1b23403b54c Change-Id: Ie9a8f8e94a009eef2bb4a6a6f5572e4013e5b085 http://cgit.osmocom.org/openbsc/commit/?id=c260241d94c8811c8f2c76477318bf24… commit c260241d94c8811c8f2c76477318bf24921e4679 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 19 01:31:36 2016 +0100 fix: msc-specific subscr conn de/alloc msc_subscr_con_free() is dead code -- this is the result of the ongoing mscsplit (OS#1594); it is used on the iu branch, but osmo-nitb on the master branch still uses only bsc_subscr_con_free(). To make sure that the lu_fsm is cleaned up when a subscr conn is discarded, add some cleanup code: to keep it on the proper side, put this in libmsc/osmo_msc.c and add another callback to struct bsc_api: conn_cleanup(). The osmo-bsc standalone implementations keep it NULL (not called when NULL), the msc_bsc_api() sets it to msc_subscr_con_cleanup(), which does the lu_fsm cleanup. Call this from bsc_subscr_con_free(). Move along all other msc_subscr_con_*() to osmo_msc.c instead of gsm_04_08.c, to counteract the tendency of gsm_04_08.c to become a kitchen sink for everything. Factor out msc_subscr_cleanup() for no good reason, really. All this to make sure that in the new VLR: 1) when a subscr conn is freed, the FSM instances are properly terminated instead of being freed quietly along with the conn's talloc context; 2) that an orphaned LU attempt doesn't leave an invalid lu_fsm pointer in the vlr_subscriber. Change-Id: I597a650ed19a6e9335890bbba7c8353a3e1ba7bf http://cgit.osmocom.org/openbsc/commit/?id=57e63c34f2b65f3ae7f8c56839134dec… commit 57e63c34f2b65f3ae7f8c56839134dec6ad626f2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:54:36 2016 +0100 cosmetic: mark fixme Change-Id: I099362da02d81ac273d57fa36f641ecd3dbd9bfc http://cgit.osmocom.org/openbsc/commit/?id=b2e2381ad0dbf02a6c0847146fe1c485… commit b2e2381ad0dbf02a6c0847146fe1c485608c42f9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 23 22:01:36 2016 +0100 ws Change-Id: Ib031b1ac8992bfc9195fcb855be4d72e9ae654ae http://cgit.osmocom.org/openbsc/commit/?id=99cdc15b7ceb4636ea0d95ee0d13a945… commit 99cdc15b7ceb4636ea0d95ee0d13a9450298bf34 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:52:38 2016 +0100 cosmetic ws Change-Id: I716d6f33aa7e8f2fbaf4bf247f97da57e77c7d61 http://cgit.osmocom.org/openbsc/commit/?id=3f20f9b41f37c77f43ef340ac60aef3e… commit 3f20f9b41f37c77f43ef340ac60aef3e49248452 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:56:43 2016 +0100 cosmetic: extraneous 'break;' Change-Id: I73515e3cf4ccd3312d1ce8270cd5ab3ff96feaca http://cgit.osmocom.org/openbsc/commit/?id=d2ec0e5ce5c67b301c3cef900b6504b6… commit d2ec0e5ce5c67b301c3cef900b6504b6e03ca89e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:54:23 2016 +0100 lu fsm: absorb state change to DONE into lu_fsm_term() Change-Id: I0d21783678d96e56904e3b62af4a14c2a8c3b854 http://cgit.osmocom.org/openbsc/commit/?id=3a66b0224bd6f79b0a967b4c4cdd8d82… commit 3a66b0224bd6f79b0a967b4c4cdd8d82dac2d4f1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:55:44 2016 +0100 vlr: lu fsm: deal with failure during internal subscriber assoc Change-Id: Id64705fbf106d3ba5b9c9ab465776f088edc6cdb http://cgit.osmocom.org/openbsc/commit/?id=201535ee84f85140496b282a3bb664c0… commit 201535ee84f85140496b282a3bb664c0a78072e5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:53:26 2016 +0100 lu fsm invocation: abort if internal subscriber assoc has failed Change-Id: I8f6fe8d1d911059e7bfcff88a46abb4f83c34fc4 http://cgit.osmocom.org/openbsc/commit/?id=21ae0bdf28eea6dc1c2e244354df7271… commit 21ae0bdf28eea6dc1c2e244354df7271dec9ae79 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:52:24 2016 +0100 vlr_proc_acc_req authentication option Change-Id: Ie66580d3f73c1faebe90c36f99070ed201a48878 http://cgit.osmocom.org/openbsc/commit/?id=6c2986155820aa626bd5623df810b1eb… commit 6c2986155820aa626bd5623df810b1eb8b63e33b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:52:05 2016 +0100 vlr_loc_upd authentication option Change-Id: Ibf105e4ba91e94c1362b1ab1409ec05f976e69ea http://cgit.osmocom.org/openbsc/commit/?id=e6c01591e2c46f63f2b64914ec6d87a6… commit e6c01591e2c46f63f2b64914ec6d87a6663f4c08 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Dec 18 23:51:01 2016 +0100 vty: add net / 'authentication (optional|required)' Change-Id: I82e13a81f5d1d4d078907319d72385d505243be1 http://cgit.osmocom.org/openbsc/commit/?id=fb66b4f35f924d95b8bdb2ede24407c3… commit fb66b4f35f924d95b8bdb2ede24407c35b560c3b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 16:14:50 2016 +0100 log: vlr: log all auth tuple details Change-Id: I5c73e7edda35e908b07411114226711105262173 http://cgit.osmocom.org/openbsc/commit/?id=a3634430f5ba2daad746c95f88ea40d0… commit a3634430f5ba2daad746c95f88ea40d0d8a78def Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 16:14:06 2016 +0100 typo in comment Change-Id: Iefc7a9b547dac18af9bb6aacd707e7465107250f http://cgit.osmocom.org/openbsc/commit/?id=d8316d3064984a90211f41f29f465860… commit d8316d3064984a90211f41f29f465860da3f0059 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 16:13:33 2016 +0100 vlr: assert that we don't replace an existing conn->master_fsm Change-Id: Iaccd07e5b8c299232d05bbffa45f854d0b974300 http://cgit.osmocom.org/openbsc/commit/?id=796ee8bce82eae3b820b45000c7a6935… commit 796ee8bce82eae3b820b45000c7a69356e293942 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 16:15:11 2016 +0100 vlr: authenticate: fix erratic assertion res is never NULL, since it is an array member. Furthermore, res is not related to this part of auth, so don't assert res_len. Change-Id: I0f5c9584bc5398523c4748e2fc469da104bbe628 http://cgit.osmocom.org/openbsc/commit/?id=63eb0d8cf88cec284da03d93135817eb… commit 63eb0d8cf88cec284da03d93135817eb541790ef Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 16:13:03 2016 +0100 vlr: create conn->master_fsm also for CM Service Req Change-Id: I2c4f5b47abd7e28cb2000adcedaa5bcc53c381d5 http://cgit.osmocom.org/openbsc/commit/?id=2a2e28e53583c8ab419ce84422a1fc8a… commit 2a2e28e53583c8ab419ce84422a1fc8a148c008b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:31:39 2016 +0100 add value strings for enum vlr_auth_fsm_result Change-Id: I85cbadd546eae032542b942718b6997c4ab5cadf http://cgit.osmocom.org/openbsc/commit/?id=dcba86f193df7d2821da04732da321a2… commit dcba86f193df7d2821da04732da321a20536f9a6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:35:20 2016 +0100 fix: vlr_lu_fsm: set vsub->lu_fsm to NULL upon cleanup Otherwise an invalid pointer to a previous, deallocated lu_fsm would stick around and prevent future Location Updating attempts. Change-Id: I81cc50b77fa26863c6bf4a29b09c35fa98921f08 http://cgit.osmocom.org/openbsc/commit/?id=0a26187cdb56f1e964fe9983e1219a0e… commit 0a26187cdb56f1e964fe9983e1219a0e710a280e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:33:29 2016 +0100 cosmetic: drop obvious comment Change-Id: Id3362ec013c1929659c1167de566de944ba2803e http://cgit.osmocom.org/openbsc/commit/?id=051eef49bf1e8fb2231dfe6982abaf07… commit 051eef49bf1e8fb2231dfe6982abaf07fdf2788d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:33:09 2016 +0100 fix: missing return after auth_fsm_term() in auth_fsm_wait_ai() Missing return statement would cause FSM to be terminated twice, resulting in segfault. Change-Id: Iba9f208c598ccc4623a20188496b2753cdfa5b22 http://cgit.osmocom.org/openbsc/commit/?id=61be33b2b22fd9c46a30c2f0f322da88… commit 61be33b2b22fd9c46a30c2f0f322da8808244a4a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:32:08 2016 +0100 vlr_auth_fsm: log term result Change-Id: I34b769e75d8aea6e5a96e6d4c4e691fa37208dc0 http://cgit.osmocom.org/openbsc/commit/?id=7b4c1eab5b91e94a3257236e2503869a… commit 7b4c1eab5b91e94a3257236e2503869a763a2131 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 16 14:30:49 2016 +0100 cosmetic: don't log fsm instance addresses Change-Id: I8ffbeecdddbef4db4e23722c8300bced7d06caec http://cgit.osmocom.org/openbsc/commit/?id=7e968f635566f92df87afe05d54d6603… commit 7e968f635566f92df87afe05d54d6603f8535001 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 13 01:09:04 2016 +0100 implement msc_create_conn_fsm Change-Id: Id541b5977ad4a7824b26fee35467ecbfa56c89f3 http://cgit.osmocom.org/openbsc/commit/?id=daa5f99cd73642655613cb916813fbd9… commit daa5f99cd73642655613cb916813fbd96db8ceb7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 13 01:10:49 2016 +0100 lu_fsm bootstrap Change-Id: I14f27a2f657567f424a4dc2ec13b6a01e2aa6676 http://cgit.osmocom.org/openbsc/commit/?id=9f6e15ff34b404bae05d38f65487012e… commit 9f6e15ff34b404bae05d38f65487012efdcf10b2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 13 01:09:39 2016 +0100 fix implit function: declare msc_release_connection Change-Id: I34a673616238e6bda677e470c83ab57fd521a217 http://cgit.osmocom.org/openbsc/commit/?id=a91c1c9c2e9c15513102efae67806684… commit a91c1c9c2e9c15513102efae678066847fe8e528 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 23:03:09 2016 +0100 gsup client: tweak logging levels around connecting Change-Id: Iee77ba45c24d6b8308e344dc1d1531e9d1b45921 http://cgit.osmocom.org/openbsc/commit/?id=82a3d104062e7e4cf3b8cb63e0577e19… commit 82a3d104062e7e4cf3b8cb63e0577e19d29e75d2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Dec 10 15:38:27 2016 +0100 nitb: vlr init Change-Id: If741ace01d939fb8b7db7496ce623d20e15cf2d7 http://cgit.osmocom.org/openbsc/commit/?id=bf5f8eb659c2ddf52cf847f059f7e3ea… commit bf5f8eb659c2ddf52cf847f059f7e3ea49af1b59 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 9 01:30:58 2016 +0100 vlr gsup client fu Change-Id: If8c119c47892763370b63ed487a5fbe7eb4f2d55 http://cgit.osmocom.org/openbsc/commit/?id=db5c863ca2e1ac5deedf13b4ae60b5a7… commit db5c863ca2e1ac5deedf13b4ae60b5a714046013 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Dec 9 01:31:14 2016 +0100 cosmetic subscr count log Related: OS#1592 Change-Id: I28fbbf136b26e69f7c7da1927c2a19f658bea8c9 http://cgit.osmocom.org/openbsc/commit/?id=861020dff94bc08e787287bc7f3368e2… commit 861020dff94bc08e787287bc7f3368e2705978f2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 14:59:48 2016 +0100 gsm_04_08 rx: check subscriber presence Related: OS#1592 Change-Id: Ic073b44ed564b9c3b51f1f8bcd134b31dbeb8a21 http://cgit.osmocom.org/openbsc/commit/?id=8064a878d4fdf396f5854248c79bcb67… commit 8064a878d4fdf396f5854248c79bcb6792bbb55e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Dec 13 01:40:40 2016 +0100 vlr_fu Change-Id: Ia3f39ab5760b9ce1889e77b24b3a578099d3cdbc http://cgit.osmocom.org/openbsc/commit/?id=6e1652710920a6f8b26cacec7550c687… commit 6e1652710920a6f8b26cacec7550c6874e8bb73e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 02:01:27 2016 +0100 fix build: osmo-nitb: include libvlr from proper dir Related: OS#1592 Change-Id: Ifebfb3cf3dfec76aca803e1ccf0da182fb8a1b39 http://cgit.osmocom.org/openbsc/commit/?id=727a8fe112d0caee9dbbf38049eeb91a… commit 727a8fe112d0caee9dbbf38049eeb91a2d348783 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 14:57:02 2016 +0100 move vlr_sub_name to libcommon, to allow logging vsub name without libvlr Related: OS#1592 Change-Id: I8a0e7cbfd5338035499825ef2755efc8c77762ca http://cgit.osmocom.org/openbsc/commit/?id=6d866fc51ac1940987e4be86d5eb387c… commit 6d866fc51ac1940987e4be86d5eb387c478e1633 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 01:28:35 2016 +0100 comment fix in vlr_subscriber Related: OS#1592 Change-Id: I53f9830b609a861c5baa693d10d3765dd769dbb3 http://cgit.osmocom.org/openbsc/commit/?id=48f0c79be1640fbcc9f7b45ccc93364e… commit 48f0c79be1640fbcc9f7b45ccc93364ec18797d1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 01:28:09 2016 +0100 vlr: temporary comments in gsm_subscriber Related: OS#1592 Change-Id: I3ef5f6230198584888cdf8e7749b41c59421f07f http://cgit.osmocom.org/openbsc/commit/?id=bf643179bf9ac25ed6ae5173a79a82a1… commit bf643179bf9ac25ed6ae5173a79a82a117dae5fd Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 8 01:01:06 2016 +0100 vlr: add vlr_subscriber to gsm_subscriber and comment subscr_name: redirect to vlr_subscriber Related: OS#1592 Change-Id: Ibff06dd2926e329d196ada5a0916c8cca02b7d69 http://cgit.osmocom.org/openbsc/commit/?id=3309ad3d0d1b25c5328ed3063b5be3f9… commit 3309ad3d0d1b25c5328ed3063b5be3f99bd9da20 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:49:18 2016 +0100 vlr: fix LAI composition: use proper network and bts pointers Related: OS#1592 Change-Id: I8ebfcedaf044261c0600b87533b60104a62b992d http://cgit.osmocom.org/openbsc/commit/?id=8014bfb472989811dc9c000e0cd603a0… commit 8014bfb472989811dc9c000e0cd603a00166b130 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 02:44:50 2016 +0100 FIXME disable subscr_update() Related: OS#1592 Change-Id: If94ed34238b221a4ff625697f42d90e4a05974ff http://cgit.osmocom.org/openbsc/commit/?id=8c2206bb9e9590b8311e64d93755aedc… commit 8c2206bb9e9590b8311e64d93755aedcf31408fc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:47:39 2016 +0100 FIXME disable classmark2 Related: OS#1592 Change-Id: I5a2231e3a680b429bc8c8195d85fa013b86cda1c http://cgit.osmocom.org/openbsc/commit/?id=c62fca961f30ee11d691f67fb25e17bb… commit c62fca961f30ee11d691f67fb25e17bb2a231000 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 15:58:25 2016 +0100 vlr_sub_name(): be robust against NULL pointer Related: OS#1592 Change-Id: I41ab19839dad00dfe46c0b5f501ca7ebc9d3b40e http://cgit.osmocom.org/openbsc/commit/?id=66e2ec9e777e5e3a98f9501e65401a44… commit 66e2ec9e777e5e3a98f9501e65401a441b38428b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:31:05 2016 +0100 gsm48_rx_rr_app_info: don't store app info at all, comment Related: OS#1592 Change-Id: Iaeeb18a0b812ac6fbfcb57abffb62d789c7ba0de http://cgit.osmocom.org/openbsc/commit/?id=b450f02310cdd29a916d4c3300167aa3… commit b450f02310cdd29a916d4c3300167aa36b11f691 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:29:42 2016 +0100 fixes for tmsi reall compl path vlr_sub_rx_tmsi_reall_compl(): have a return value; publish in vlr.h. gsm48_rx_mm_tmsi_reall_compl(): fix everything. Related: OS#1592 Change-Id: Ieeccca85e7177e21af43db4de705ec13d7bc8c40 http://cgit.osmocom.org/openbsc/commit/?id=fe346153dfe808a535e4d4ab6080beec… commit fe346153dfe808a535e4d4ab6080beec5245f03e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 02:46:13 2016 +0100 gsm_04_08.c: add missing vlr .subscr_assoc() Related: OS#1592 Change-Id: I89757df03c4bf9ff9272f848f6724b635af1eeb0 http://cgit.osmocom.org/openbsc/commit/?id=45cfeaa28c404e784724254f1859e8bd… commit 45cfeaa28c404e784724254f1859e8bdd09d609f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 02:43:09 2016 +0100 fix const compiler warning in print_meas_rep() Related: OS#1592 Change-Id: Icd89a1e0c99f455317387ee55f2d90a0e3c61c7a http://cgit.osmocom.org/openbsc/commit/?id=40843036f3cea49b02b63827699fd944… commit 40843036f3cea49b02b63827699fd944f2d91d46 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:45:16 2016 +0100 vlr_lu_fsm: missing: WAIT_SUB_PRES out_state_mask += WAIT_IMEI_TMSI Related: OS#1592 Change-Id: I050cfaf2d23c71a2bb7d969f43bb5b493d3639c5 http://cgit.osmocom.org/openbsc/commit/?id=4a5b676fb7be3cb27ab6d8b245024976… commit 4a5b676fb7be3cb27ab6d8b2450249766ddd8ff1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:44:04 2016 +0100 libmsc: store classmark1 in gsm_subscriber_connection Related: OS#1592 Change-Id: I03d194595da684e165715faf5f602adef8587144 http://cgit.osmocom.org/openbsc/commit/?id=0f2ff80ecd222f60cce2fa5f513cd652… commit 0f2ff80ecd222f60cce2fa5f513cd652e1dce256 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Nov 17 05:06:59 2016 +0100 cosmetic: in comments, drop some unbalanced braces Simplistic C file harvesters will break at a single opening brace even if it is in a comment. This is of course aimed at the fsm-to-dot.py script recently added in libosmocore/contrib. Related: OS#1592 Change-Id: Ie47bc869fbd3f2dab7141a3d61a9d772b5a9b7a9 http://cgit.osmocom.org/openbsc/commit/?id=69491224a794cf0931f6d35c03bc0f7e… commit 69491224a794cf0931f6d35c03bc0f7e4a8d3cf1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:28:33 2016 +0100 fix various missing vars and unused vars Related: OS#1592 Change-Id: I16cf82fe3b27a4cdd69df1cf34e60918b453d07b http://cgit.osmocom.org/openbsc/commit/?id=b25aa166486adf45f3e15553184f76a5… commit b25aa166486adf45f3e15553184f76a5c3546517 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:46:12 2016 +0100 comments: various tweaks and fixes Mention 3GPP TS 23.008, whitespace, typos Related: OS#1592 Change-Id: I8b996e8900e4846ff3d95189215ad3b5e97d1d2b http://cgit.osmocom.org/openbsc/commit/?id=15e5b937986cc8967d4d9a933dcf0552… commit 15e5b937986cc8967d4d9a933dcf05522711eb0b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Dec 7 14:53:37 2016 +0100 fix vlr_loc_update: don't return vlr_subscriber, return fsm inst Related: OS#1592 Change-Id: I943aea5575bf57e3bb148ade616a66191cee6752 http://cgit.osmocom.org/openbsc/commit/?id=6778f35b5d54cf1afa3785cf50a89ae5… commit 6778f35b5d54cf1afa3785cf50a89ae55f5e8708 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Nov 14 14:48:00 2016 +0100 WIP: more incomplete libvlr integration work Related: OS#1592 Change-Id: I77fb3a540c900be6440d0aec12161711b65b8aa6 http://cgit.osmocom.org/openbsc/commit/?id=35ea4433f0146e567d075f6cd4a348f3… commit 35ea4433f0146e567d075f6cd4a348f3a1b27b04 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Jun 17 00:06:42 2016 +0200 WIP: Introduce libvlr Related: OS#1592 Change-Id: I3f75de5f0cc2ff77f276fd39832dd3621309c4b9 http://cgit.osmocom.org/openbsc/commit/?id=815b347efe2b16813a8458e57e8d43f1… commit 815b347efe2b16813a8458e57e8d43f1d334e9f1 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri May 6 23:28:11 2016 +0200 VTY: Print 3G auth tuples, not just 2G auth tuples Change-Id: I277e4347ee1486a39e6dc4e2363a593f328f9e3b Related: OS#1592 http://cgit.osmocom.org/openbsc/commit/?id=b889e8b36300cad44b641cbd55ecaa55… commit b889e8b36300cad44b641cbd55ecaa556847652c Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri May 6 13:49:49 2016 +0200 WIP: Handle Authentication Failure from MS Change-Id: I71f51eff089cf05f32a6ef408c4606880fc2e4a5 Related: OS#1592 http://cgit.osmocom.org/openbsc/commit/?id=b0f7c79d2e5e5169eb71a07474421d25… commit b0f7c79d2e5e5169eb71a07474421d25b1cefe29 Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu May 5 22:52:41 2016 +0200 SGSN: Integrate basic support for UMTS AKA We already had almost all the parts in place before: * GSUP with capability to send us auth_vectors that contain either triplets or quintuples * mm_context that holds such auth_vectors All that we need to add in this patch is the capability to send the AUTN parameter in the GMM AUTH REQ and parse the extended RES in the GMM AUTH RESP. TODO: Implement SQN re-synchronoization mechanism (Auth Fail: Sync Err) Change-Id: Ie6a0cefba5e4e7f02cc2eaf6ec006ac07d5c1816 Related: OS#1592 http://cgit.osmocom.org/openbsc/commit/?id=52f57c50aca26c3110c34ae1c4e9f9ce… commit 52f57c50aca26c3110c34ae1c4e9f9ce308a8f3b Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 19 18:06:02 2016 +0200 Introduce subscriber_connection ref-counting This introduces a reference count for gsm_subscriber_connection. Every user of the connection needs to hold a reference until done. Once the reference count dorps to zero, the connection is cleared towards the BSC (which subsequently will clear any logical channels associated with it). Related: OS#1592 Change-Id: I8c05e6c81f246ff8b5bf91312f80410b1a85f15e http://cgit.osmocom.org/openbsc/commit/?id=c7bffcf15cd318fcf405937a8c9c01a0… commit c7bffcf15cd318fcf405937a8c9c01a0b7d54dbe Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Dec 22 01:58:03 2016 +0100 gsm0408_rcv_cc: guard against NULL subscriber Check conn->subscr against NULL. gsm0408_rcv_cc() dereferences many conn members without checking presence: the bts and lchan members may be expected to be NULL in the ongoing MSC split and 3G developments. But the conn->subscr is initially NULL, so an MS sending a CC message before something like a LU or CM Service Request will result in a segfault. Prevent that. Note: the upcoming VLR will be more restrictive on what messages are processed, this is a "backport" to the situation on current master. Change-Id: If067db7cc0dd3210d9eb1da15be6b637795a3ecf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sndcp_xid.h | 14 ++- openbsc/include/openbsc/vlr.h | 26 +++- openbsc/src/gprs/gprs_llc.c | 14 +-- openbsc/src/gprs/gprs_sndcp.c | 25 ++-- openbsc/src/gprs/gprs_sndcp_xid.c | 54 ++++++--- openbsc/src/libmsc/gsm_04_08.c | 55 +-------- openbsc/src/libmsc/smpp_openbsc.c | 4 +- openbsc/src/libvlr/vlr.c | 50 ++++++++ openbsc/src/libvlr/vlr_access_req_fsm.c | 81 ++++++------- openbsc/src/libvlr/vlr_auth_fsm.c | 74 ++++++------ openbsc/src/libvlr/vlr_lu_fsm.c | 21 +++- openbsc/tests/sndcp_xid/sndcp_xid_test.c | 10 +- openbsc/tests/subscr_conn/subscr_conn_test.c | 87 +++++++++++++- openbsc/tests/subscr_conn/subscr_conn_test.err | 157 +++++++++++++------------ openbsc/tests/vlr/vlr_test.c | 1 + 15 files changed, 404 insertions(+), 269 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)