This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT".

The branch, sysmocom/revert_WAIT_ASSIGN has been updated discards 2d0da6371dba88860d843998faabd98518d50179 (commit) via 303be72c9fe3266214e3bf70852270ad45d3eb95 (commit) via 7c7a86c080edd9c92778c941bbe484f59a81f93c (commit) via a35c911a91ea7b6d8b017fd103c0d86f79bb271e (commit) via 3c2eaebd214fd39ebaf0bf86d2120bd226c62309 (commit)

This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this:

* -- * -- B -- O -- O -- O (2d0da6371dba88860d843998faabd98518d50179) \ N -- N -- N (303be72c9fe3266214e3bf70852270ad45d3eb95)

When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B.

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=303be72c9fe3266214e3bf70852270ad...

commit 303be72c9fe3266214e3bf70852270ad45d3eb95 Author: Neels Hofmeyr neels@hofmeyr.de Date: Wed Jun 8 15:27:40 2016 +0200

Revert "tbf: Add state WAIT_ASSIGN"

This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0.

Conflicts: tests/tbf/TbfTest.err

The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002 with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e).

The error observed is the following log output (was viewing both osmo-bts-sysmo and osmo-pcu logs interleaved):

<0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169 timeout during transsmission <0002> tbf.cpp:893 - Assignment was on CCCH <0002> tbf.cpp:899 - No uplink data received yet <0007> l1sap.c:904 RACH for packet access <0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653 [repeat]

When removing this single commit from current osmo-pcu master, GPRS service works well on SysmoBTS, with current osmo-bts master.

The TbfTest.err expected output needed adjustment after the revert.

Disclaimer: I am not aware of adverse effects this commit may have. I have no idea what the WAIT_ASSIGN state is used for -- further review is required.

Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd

-----------------------------------------------------------------------

Summary of changes: src/rlc.cpp | 2 +- tests/tbf/TbfTest.cpp | 60 +++++++++++++++++++++++++++++++++++++++++++++++ tests/tbf/TbfTest.err | 49 ++++++++++++++++++++++++++++++++++++++ tests/tbf/TbfTest.ok | 2 ++ tests/types/TypesTest.cpp | 17 ++++++++++++++ 5 files changed, 129 insertions(+), 1 deletion(-)

hooks/post-receive