wireshark.git branch pespin/osmux-stats created. 0987ace7f58717e0da75b25adffa902b87fc10f5
11 May
2017
11 May
'17
6:11 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "wireshark with Osmocom specific dissectors".
The branch, pespin/osmux-stats has been created
at 0987ace7f58717e0da75b25adffa902b87fc10f5 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/wireshark/commit/?id=0987ace7f58717e0da75b25adffa90…
commit 0987ace7f58717e0da75b25adffa902b87fc10f5
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Wed May 10 20:24:56 2017 +0200
gsm_osmux: Add support to follow Osmux streams and show its statistics
http://cgit.osmocom.org/wireshark/commit/?id=5c9660df9684dc762d5dd4f8d1b835…
commit 5c9660df9684dc762d5dd4f8d1b8350882288487
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Tue May 9 17:50:48 2017 +0200
gsm_osmux: Support multiple OSmux frames per packet
Also split and show all AMR payloads
http://cgit.osmocom.org/wireshark/commit/?id=22f6e11f617b4036a5a5ed955f1c7a…
commit 22f6e11f617b4036a5a5ed955f1c7a7c63865db8
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Tue May 9 14:19:10 2017 +0200
gsm_osmux: Add RTP Marker field
GSM Osmux recently got support to bring RTP Marker (M) bit. It should be
mostly backwards compatible as the first bit was reserved and not used
before for the FieldType.
Support was added in libosmo-netif commit e98afe5808176efb60298a2f764e8e11efaf580b
This bit is documented in the protocol documentation recently available:
http://ftp.osmocom.org/docs/latest/osmux-reference.pdf
http://cgit.osmocom.org/wireshark/commit/?id=103190de10caf79b18e38e0ed22d2d…
commit 103190de10caf79b18e38e0ed22d2dd2daf69121
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Tue May 9 14:04:18 2017 +0200
gsm_osmux: Fix showing up in GUI
Without this change I cannot see the GUI showing up in wireshark-gtk
http://cgit.osmocom.org/wireshark/commit/?id=fb44c8ced518aa72ce35d6402ceef7…
commit fb44c8ced518aa72ce35d6402ceef70da117f343
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue May 9 10:46:57 2017 +0200
[GSM RLCMAC] Add comments.
Change-Id: I2d98d8f318fdbe160974a69f50c456683669e57e
Reviewed-on: https://code.wireshark.org/review/21562
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fa5f913256bc16d21f9b9727fdf2ce…
commit fa5f913256bc16d21f9b9727fdf2cec454059c8d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon May 8 20:32:56 2017 -0400
Bring DOCSIS Mac Management "dissectors" into modernity.
1. Use proto_tree_add_item_ret_uint to remove separate "gets"
2. Remove if (tree)s that prevented expert_info
3. Apply consistent whitespace
4. Apply consistent TLV behavior, making T and L always filterable
5. Remove T name (of TLV) from field name itself (where applicable)
6. Use BASE_UNIT_STRING and BASE_NO_DISPLAY_VALUE
Tested with capture generated from https://github.com/AdrianSimionov/docsis-generator
Change-Id: I9987397ccb3248b2a26d850af468740f94b28a63
Reviewed-on: https://code.wireshark.org/review/21561
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=954548fdb951cbffbfa3c7cadb2c20…
commit 954548fdb951cbffbfa3c7cadb2c202919c0204c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 12:21:49 2017 +0200
qsig: fix conflicting entry in its value_string
Field 'Error' (qsig.error) has a conflicting entry in its value_string: 43 is
at indices 12 (proceduralError) and 42 (notActivated))
Change-Id: I17fcebc677495033dedad57dd0c3d87631152290
Reviewed-on: https://code.wireshark.org/review/21456
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c88e60f9fb2269d8204e4a8e79d872…
commit c88e60f9fb2269d8204e4a8e79d8723561fb38ca
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 17:21:02 2017 +0200
ceph: fix conflicting entry in its value_string
Field 'Type' (ceph.type) has a conflicting entry in its value_string: 64 is at
indices 39 (C_CEPH_MSG_PRIO_LOW) and 40 (C_MSG_MON_SCRUB))
Change-Id: I69e6bd56d928c20b6262999e057c92f0d325e96d
Reviewed-on: https://code.wireshark.org/review/21509
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=07fc801684ebff7aff02505cdb2c12…
commit 07fc801684ebff7aff02505cdb2c120caea846e0
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon May 8 17:21:58 2017 +0200
[GSM RLCMAC] Update : PACKET RESOURCE REQUEST to Release 14.0.0
Change-Id: I41e6ebf862f0bd9523778053d40f18ae7385a5bd
Reviewed-on: https://code.wireshark.org/review/21560
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ab504191fccdb7db1d9559ac0592f2…
commit ab504191fccdb7db1d9559ac0592f22872586133
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun May 7 21:50:00 2017 +0200
Qt: try harder to find a working monospace font
QFont::toString returned the default font (which might be unavailable),
leading to use of non-monospace fonts in the bytes view. Detect the
effective font instead and apply it to avoid this issue.
Add additional logic to invoke font detection when the configured font
is bad (for example, because of the bug or because a font has been
removed in meantime).
Bug: 13638
Change-Id: I8a625cf365c90119caebe8c4deada0df7426e53a
Reviewed-on: https://code.wireshark.org/review/21551
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
Petri-Dish: Jörg Mayer <jmayer(a)loplof.de>
Tested-by: Jörg Mayer <jmayer(a)loplof.de>
Reviewed-by: Ahmad Fatoum <ahmad(a)a3f.at>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ee37135c67c7dfc3339dec7d13e665…
commit ee37135c67c7dfc3339dec7d13e665da56867b7c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun May 7 19:39:19 2017 -0700
Note that the HT MCS index macros can't return all possible MCS values.
I don't know whether this is a bug in the software or a lack of support
in the hardware.
This at least notes the issue in CID 1405905.
Change-Id: I481454bc38842a0f877cb8b52b73e1156fd362b5
Reviewed-on: https://code.wireshark.org/review/21558
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=548e9762fb6e1c49a651b02b5e8c80…
commit 548e9762fb6e1c49a651b02b5e8c806dfdf74fa8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun May 7 14:18:46 2017 -0700
Fix handling of 20 MHz VHT with MCS = 9.
That's valid only for 3 or 6 spatial streams; return 0 as the bitrate
for all other values. Also, handle the 6 spatial streams case.
Give the conversion tables explicit sizes, to make it clear what
subscripts are valid.
Return 0 for an MCS > 9, for consistency with the other error return,
and to mark it as clearly wrong.
Fixes CID 1405908.
Change-Id: Icbf655c63c0e88fd6cec7c66bae85fd887a3bd9c
Reviewed-on: https://code.wireshark.org/review/21557
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f4585f957db82e77975f3436c6ff20…
commit f4585f957db82e77975f3436c6ff20724a45fe1b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun May 7 14:13:48 2017 -0700
Regenerate header.
Change-Id: Ie77c182b0ee61f84f505b0f40a171d5afef59811
Reviewed-on: https://code.wireshark.org/review/21556
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2229665d4871ad52faaf363f5a4604…
commit 2229665d4871ad52faaf363f5a4604893771dfa4
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun May 7 22:59:08 2017 +0200
gif: fix the version detection
tvb_strneql() returns 0 if the two strings are equal.
Thanks to Ahmad Fatoum for reporting this bug.
Change-Id: Id6cde56623e18fe0a28f37b108dc1848cc58e1c3
Reviewed-on: https://code.wireshark.org/review/21554
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=163d66099d7ef338c475f63e56b242…
commit 163d66099d7ef338c475f63e56b242957c9103c7
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Thu May 4 18:09:42 2017 +0300
UMTS Iub: Refactored U-RNTI resolving logic for dedicated channels
Instead of mapping Scrambling codes to U-RNTIs, now mapping CRNC communication context
IDs to U-RNTIs.
Change-Id: Id81b7764d2941b742f21094dac391f8658061a80
Reviewed-on: https://code.wireshark.org/review/21495
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0419add8a1c94c2db976e2ce4ff0cd…
commit 0419add8a1c94c2db976e2ce4ff0cdabbd85f5e7
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun May 7 22:20:10 2017 +0200
ixveriwave: Fix maybe-uninitialized warning
Fix maybe-uninitialized warning:
packet-ixveriwave.c:2508:16: error: 'rate_mcs_index' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
if (rate_mcs_index < 4)
Change-Id: I878f8d68104cf4f01990eebea85cfbb2a170a5bd
Reviewed-on: https://code.wireshark.org/review/21553
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=6a040b525cc3fa94b27945f62856de…
commit 6a040b525cc3fa94b27945f62856de70ed234b87
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat May 6 19:37:07 2017 +0200
gif: start cleaning up the dissection code
Remove the global if(tree). We should not throw exceptions under if
(tree). Buf we may get exceptions while parsing the gif file.
Process the version string once as we go through the file. (Ok, we
already had to look at it to figure out that we have a gif file.)
Use tvb_reported_length_remaining() in the main loop.
Change-Id: Ie00594eebffc715676ffd5df8cbf7d43034aa68d
Reviewed-on: https://code.wireshark.org/review/21545
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=c1b7aa4d95cc4d22521294dcdc7636…
commit c1b7aa4d95cc4d22521294dcdc7636d0fc37c126
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun May 7 12:51:37 2017 -0700
Clean up various things.
Sort the hf_ definitions, and the entries for them, as much as possible
by the order in which they're put into the protocol tree.
Indicate which if statement branches are for pre-OCTO hardware and which
are for OCTO hardware.
Pre-HT PHYs don't have an MCS index; the "MCS index" is, rather, an
index into a table of bit rates, so call it a "rate index".
Fill in some more 802.11 radio pseudoheader fields.
Use proto_item_append_text to indicate the direction in the entry for
the L1 information.
Don't show irrelevant fields, such as the preamble length for HT and
VHT.
Change-Id: Ibd2baff09fd4ec6e4a84dc0ae2e4615631a2d15e
Reviewed-on: https://code.wireshark.org/review/21550
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d0e317d69e07412a330d1d67038ac4…
commit d0e317d69e07412a330d1d67038ac4194caf55eb
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat May 6 19:34:24 2017 +0200
gif: refactor the detection of a gif file
Generally, we should not throw an exception before we know that this is
our file/packet. Use tvb_strneql() to get the version string. This
function does not throw an exception if there are fewer bytes left than
we requested.
(I know that we check for reported len < 20. However, for captured
length > 6 and reported length < 20, the current code does not work.)
Change-Id: I5214c5c9dc9da616a94ae96269ec1c9e6f412e8e
Reviewed-on: https://code.wireshark.org/review/21544
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=8657646e0b2ee68de0defa1f9d9fd7…
commit 8657646e0b2ee68de0defa1f9d9fd7ed23ba126f
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun May 7 13:53:22 2017 +0200
gif: remove pointless coments, unused debug macro
Change-Id: Id4ac23a7e5164e40ddc0ee22ddb62f7121b74ad9
Reviewed-on: https://code.wireshark.org/review/21543
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=47b1a98f09b81ad8d090a01d73eda1…
commit 47b1a98f09b81ad8d090a01d73eda1ebc7b1abc6
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat May 6 20:25:50 2017 +0200
gif: (trivial) fix a typo
The trailer byte is 0x3b, not 0xb3.
Change-Id: I9b2d21f369957fc0c4eb5ff376c4aa7fbdc28c9e
Reviewed-on: https://code.wireshark.org/review/21542
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=2aa3adf55900bb290f7a28d4121fbb…
commit 2aa3adf55900bb290f7a28d4121fbb63d74508e4
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun May 7 08:18:57 2017 -0700
[Automatic update for 2017-05-07]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: Iae34b6ae74e4b6f891756732107aa1fdfa9ffa51
Reviewed-on: https://code.wireshark.org/review/21541
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=6a0b5b33af1dc9ab1523483d2396ba…
commit 6a0b5b33af1dc9ab1523483d2396bafdde79cd5f
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun May 7 16:16:16 2017 +0100
Fix kafka build error by casting
Change-Id: I34a5f60c49d09a8cec4a2c9ab49ea48ef67527cd
Reviewed-on: https://code.wireshark.org/review/21540
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d89b83a9e4f9a974a05943bca44473…
commit d89b83a9e4f9a974a05943bca4447371003bd725
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat May 6 12:35:13 2017 +0100
Kafka: show decompressed messages more clearly
Change-Id: I8edf251d9ab26f93bf54d8032706ac7b9e4f6dd1
Reviewed-on: https://code.wireshark.org/review/21538
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Petri-Dish: Evan Huus <eapache(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e925a9e7dac35dda404247e78fa5a…
commit 6e925a9e7dac35dda404247e78fa5a7934d7820e
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat May 6 17:57:01 2017 +0200
netgear: tree is used, remove the _U_
Change-Id: I17d058cf7949e7513241dec0248896bd9883dd11
Reviewed-on: https://code.wireshark.org/review/21539
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=753d6f66679430a61af87e7f77d149…
commit 753d6f66679430a61af87e7f77d14950bb2f726e
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat May 6 11:35:23 2017 +0200
can: remove duplicated can_identifier struct.
Change-Id: Ib6f0bcd1bec9a1fc5cbcd797a1f418270ae74a0e
Reviewed-on: https://code.wireshark.org/review/21537
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6364e44fb0de823a6c55225bf52f5d…
commit 6364e44fb0de823a6c55225bf52f5daf54f70097
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Thu May 4 23:50:31 2017 +0200
ua3g: updated GET_PARAM_RESPONSE message decoding (freeseating and ethernet config)
Change-Id: Ie67c2e61c031de5b48310d1fc8940808481b725b
Reviewed-on: https://code.wireshark.org/review/21504
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b3103837a84f82a8b4aa202ac805e8…
commit b3103837a84f82a8b4aa202ac805e8b9c2dba57d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:44:17 2017 +0200
ixveriwave: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ia4ff13fb9ab57ad6749ffdcb4a2b2243c98747b6
Reviewed-on: https://code.wireshark.org/review/21515
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f175c223618fd223a5377272be22fe…
commit f175c223618fd223a5377272be22fe84f44cb4fb
Author: Robert Jonbgloed <robertj(a)voxlucida.com.au>
Date: Thu May 4 16:29:48 2017 +0100
Fixed the column info when displaying VP8 sub protocol to RTP.
The RTP header information was no longer displayed, and this is very useful
information. It certainly looked like the VP8 information was supposed to
be extra to the existing info (the dash in the text), and should have been
tacked on the end.
Change-Id: I1cbefac109a7de7fbc78ac2c274071e20261dd4f
Reviewed-on: https://code.wireshark.org/review/21496
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1247aaef83428c8e995eea6687379d…
commit 1247aaef83428c8e995eea6687379d02cd54929f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 19:33:01 2017 -0700
Set some variables in the "RF only" code path.
That should remove the need to initialize them, make it clearer what
values are being used in the "RF only" case, and catch any cases where
they don't get set in the "not just RF" case in the future.
Change-Id: I10c3ecef608ed2f481111fb7bc32bb8494b68d27
Reviewed-on: https://code.wireshark.org/review/21536
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=247484816619b176ba3d20e7546e37…
commit 247484816619b176ba3d20e7546e37a448eb1961
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri May 5 16:49:36 2017 -0400
packet-pcep.c: Fix infinite loop
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1363
Bug: 13687
Change-Id: I11d9736db945857fdcf2c23826a3acf5f6fd08a7
Reviewed-on: https://code.wireshark.org/review/21528
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e2bd5314d005d7e94ed0b9e243ba26…
commit e2bd5314d005d7e94ed0b9e243ba26c4c67b0183
Author: Andrew Feren <acferen(a)yahoo.com>
Date: Fri May 5 11:33:31 2017 -0400
Add decodes for Gigamon IPFIX information elements
-- Elements to be decoded described in IE-doctor format (RFC 7013 section 10)
httprequrl(26866/1)<string>
httprspstatus(26866/2)<unsigned16>{identifier}
sslcertificateissuercommonname(26866/101)<string>
sslcertificatesubjectcommonname(26866/102)<string>
sslcertificateissuer(26866/103)<string>
sslcertificatesubject(26866/104)<string>
sslcertificatevalidnotbefore(26866/105)<string>
sslcertificatevalidnotafter(26866/106)<string>
sslcetificateserialnumber(26866/107)<octetArray>
sslcertificatesignaturealgorithm(26866/108)<octetArray>
sslcertificatesubjectpubalgorithm(26866/109)<octetArray>
sslcertificatesubjectpubkeysize(26866/110)<unsigned16>
sslcertificatesubjectaltname(26866/111)<string>
sslservernameindication(26866/112)<string>
sslserverversion(26866/113)<unsigned16>
sslservercipher(26866/114)<unsigned16>
sslservercompressionmethod(26866/115)<unsigned8>
sslserversessionid(26866/116)<octetArray>
dnsidentifier(26866/201)<unsigned16>{identifier}
dnsopcode(26866/202)<unsigned8>{identifier}
dnsresponsecode(26866/203)<unsigned8>{identifier}
dnsqueryname(26866/204)<string>
dnsresponsename(26866/205)<string>
dnsresponsettl(26866/206)<unsigned32>
dnsresponseipv4address(26866/207)<ipv4Address>
dnsresponseipv6address(26866/208)<ipv6Address>
dnsbits(26866/209)<string>
dnsqdcount(26866/210)<unsigned16>
dnsancount(26866/211)<unsigned16>
dnsnscount(26866/212)<unsigned16>
dnsarcount(26866/213)<unsigned16>
dnsquerytype(26866/214)<unsigned16>
dnsqueryclass(26866/215)<unsigned16>
dnsresponsetype(26866/216)<unsigned16>
dnsresponseclass(26866/217)<unsigned16>
dnsresponserdlength(26866/218)<unsigned16>
dnsresponserdata(26866/219)<string>
dnsauthorityname(26866/220)<string>
dnsauthoritytype(26866/221)<unsigned16>
dnsauthorityclass(26866/222)<unsigned16>
dnsauthorityttl(26866/223)<unsigned32>
dnsauthorityrdlength(26866/224)<unsigned16>
dnsauthorityrdata(26866/225)<string>
dnsadditionalname(26866/226)<string>
dnsadditionaltype(26866/227)<unsigned16>
dnsadditionalclass(26866/228)<unsigned16>
dnsadditionalttl(26866/229)<unsigned32>
dnsadditionalrdlength(26866/230)<unsigned16>
dnsadditionalrdata(26866/231)<string>
Bug: 13688
Change-Id: I4a2472d9bb86d195851edd3a1f5e688ba31dde89
Reviewed-on: https://code.wireshark.org/review/21519
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d815913b387e7c97b22c19cb3422a0…
commit d815913b387e7c97b22c19cb3422a0a78a480842
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 19:25:26 2017 -0700
Comments to indicate which bits of the header we're looking at.
Change-Id: I7b1c924af9d23894ff79767bbb1290b60d36e298
Reviewed-on: https://code.wireshark.org/review/21533
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=538abdfbc2225e8c39de99811fb9cb…
commit 538abdfbc2225e8c39de99811fb9cbef53b0911b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri May 5 17:23:59 2017 -0400
packet-dcm.c: Fix infinite loop
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1329
Bug: 13685
Change-Id: Ic70cf8185beeb4cfa9417c287cf963e1c56bf86c
Reviewed-on: https://code.wireshark.org/review/21529
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0e53c857e5ecc0032941b2e8a04898…
commit 0e53c857e5ecc0032941b2e8a048989099fb0043
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri May 5 16:37:35 2017 -0400
packet-ipv6.c: dissect_routing6_rpl must have IPv6 addresses.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1303
Bug: 13675
Change-Id: Icadf8a57a25bbf9abaa9685f9e9c7a803204b7e5
Reviewed-on: https://code.wireshark.org/review/21527
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d67b334e7d1ab7bf06500daed22e9…
commit 5d67b334e7d1ab7bf06500daed22e92ac52b379f
Author: Charlie Lenahan <clenahan(a)sonicbison.com>
Date: Fri May 5 16:56:41 2017 -0400
Add Netgear Ensemble protocol
Bug: 13689
Change-Id: I9573d0106a1639cfc2d416a4146f558047cfd67e
Reviewed-on: https://code.wireshark.org/review/21524
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dddde02e251213002f2dedeaea85a1…
commit dddde02e251213002f2dedeaea85a1a97044a1a3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri May 5 16:22:01 2017 -0400
packet-mle.c: Fix infinite loop
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1359
Bug: 13686
Change-Id: Ibc08b6e79200264d821e755ef1e4b5da74b8cf97
Reviewed-on: https://code.wireshark.org/review/21526
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=82c667b1a6a701b1b4cd369c825f44…
commit 82c667b1a6a701b1b4cd369c825f44a1433c7a23
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 27 20:25:26 2017 -0400
vwr.c: Initialize some local variables
Prevents some compiler warnings
Change-Id: I9d62d0f3e6b7794c5ed43f37d52f86d81344a33c
Reviewed-on: https://code.wireshark.org/review/21531
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3ef57b9ea2da5c122c66a62649d2b7…
commit 3ef57b9ea2da5c122c66a62649d2b76b0592002c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 15:12:36 2017 -0700
Small cleanups.
Add some parentheses to make an expression clearer to people who haven't
memorized the table of C operator precedences.
Don't fiddle the nss variable in place; explicitly combine it with the
IS_TX value when we put it in the header, to make it clearer what's in
that header byte.
Change-Id: I870b892fb9dab2bc210956f923e0183f4e147989
Reviewed-on: https://code.wireshark.org/review/21530
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0d368850aebe054b66959975df4ddb…
commit 0d368850aebe054b66959975df4ddbbad58a37a9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 17:48:40 2017 +0200
tnef: fix conflicting entry in its value_string
Field 'Type' (tnef.property.tag.type) has a conflicting entry in its
value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING))
Change-Id: I306ba69b954f22781bbafe4400993d73c9be5811
Reviewed-on: https://code.wireshark.org/review/21511
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5956556aceb1f59387a081a6e8898a…
commit 5956556aceb1f59387a081a6e8898a7e40730936
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 17:24:41 2017 +0200
mapi: fix conflicting entry in its value_string
Field 'Value' (mapi.SPropValue.value) has a conflicting entry in its
value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING))
Field 'Value' (nspi.SPropValue.value) has a conflicting entry in its
value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING))
Change-Id: Icc1060804ced2887a34ffe81cf473fbe8154ce18
Reviewed-on: https://code.wireshark.org/review/21510
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c1880e3095acd7541076bb89bfae5d…
commit c1880e3095acd7541076bb89bfae5d5bd348a3d2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:20:41 2017 +0200
dcerpc pn io (profinet) fix conflicting entry in its value_string
Field 'Index' (pn_io.index) has a conflicting entry in its value_string: 45057
is at indices 82 (Sync-Log / RTA SyncID 1 (GSY)) and 114 (reserved for profiles))
Change-Id: Ic3e6f6db0631a9337861cd697b4d7bf17fba0c36
Reviewed-on: https://code.wireshark.org/review/21513
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=905e0c08ee49aa6cf1d605c28bcbb9…
commit 905e0c08ee49aa6cf1d605c28bcbb9f0a9945064
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:50:48 2017 +0200
lempar: set ParseInit/ParseFinalize static
grammar.c:471:6: warning: no previous prototype for ‘DfilterInit’
[-Wmissing-prototypes]
grammar.c:646:6: warning: no previous prototype for ‘DfilterFinalize’
[-Wmissing-prototypes]
dtd_grammar.c:502:6: warning: no previous prototype for ‘DtdParseInit’
[-Wmissing-prototypes]
dtd_grammar.c:637:6: warning: no previous prototype for ‘DtdParseFinalize’
[-Wmissing-prototypes]
Change-Id: I9c43fb4d5ad50992e8e55163333793b20319aa74
Reviewed-on: https://code.wireshark.org/review/21516
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6d7759081639c4389975d91f5e2c2…
commit c6d7759081639c4389975d91f5e2c20399c460b6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 14:13:30 2017 -0700
Assume the Series II does the same with NSS for VHT that the Series III does.
The packet-ixveriwave.c dissector appears to do so.
Change-Id: Ie02c4611ef18e83abcd3b625bbc40014080ffca1
Reviewed-on: https://code.wireshark.org/review/21525
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a1478413bec9aa86630b388fbc2a23…
commit a1478413bec9aa86630b388fbc2a239773a5cb36
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 13:06:16 2017 -0700
NSS != (MCS / 8) + 1 for MCS >= 32.
Do the MCS -> NSS mapping for HT by a table lookup.
For VHT with Series II, do it the old way for now, under the assumption
that the MCS index and NSS are bit fields, but note that the MCS index
and NSS bit fields would overlap.
Change-Id: Ibc89590faf15900171b2a1b4ac1e50793ed70c32
Reviewed-on: https://code.wireshark.org/review/21523
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1a5c6da9fe25e768a45587d8ffb00f…
commit 1a5c6da9fe25e768a45587d8ffb00f38dd1a82e4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 11:40:22 2017 -0700
Series I only handles pre-HT, so rename and remove variables.
Change-Id: Id9f086983544647267854446932a3ffe2ec2cc55
Reviewed-on: https://code.wireshark.org/review/21522
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8493630f0cc67d640cb3ffbbe1e7a8…
commit 8493630f0cc67d640cb3ffbbe1e7a80840570c1f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri May 5 11:31:58 2017 -0700
Have separate routines for calculating pre-HT/HT/VHT data rates.
That maeks the code a little clearer.
It also makes it clearer that the "MCS index" is, for pre-HT, a rate
index, so rename some variables and macros.
Change-Id: I64b7bca073df0f837e5d968682345187000207fc
Reviewed-on: https://code.wireshark.org/review/21521
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7a9c026e0573c9303db080a546e6b7…
commit 7a9c026e0573c9303db080a546e6b745a8cf9797
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:52:08 2017 +0200
gsm_sms: fix no previous prototype for ‘proto_reg_handoff_gsm_sms’
[-Wmissing-prototypes]
Change-Id: If580b059d6aae1d69ac32578674491205a7ae21d
Reviewed-on: https://code.wireshark.org/review/21517
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=daf3ae77afb890228220727be85cc9…
commit daf3ae77afb890228220727be85cc9e89f53f601
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:12:15 2017 +0200
pn dcp (profinet): fix conflicting entry in its value_string
Field 'BlockQualifier: ResettoFactory' (pn_dcp.block_qualifier_reset) has a
conflicting entry in its value_string: 9 is at indices 7 (Resets all stored data) and 12
(Reserved))
Change-Id: I9d43fc44899d47eaafb50a76511dda69560a75da
Reviewed-on: https://code.wireshark.org/review/21512
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=959a0ed22ccab1167314d4e3b38bbb…
commit 959a0ed22ccab1167314d4e3b38bbb8f8eef2296
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed May 3 18:53:42 2017 +0200
netlink (nl80211) fix no previous prototype for
‘proto_register_netlink_nl80211/handoff_netlink_nl80211’ [-Wmissing-prototypes]
Change-Id: Ife84b7865f7646b3ae8ad0dd3bbf10a679868fce
Reviewed-on: https://code.wireshark.org/review/21518
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=58a00264543c127abbe1395c01de29…
commit 58a00264543c127abbe1395c01de29b04e0a4edc
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri May 5 15:40:02 2017 +0200
extcap: Update example help text
Change-Id: I1240af78664d6066650be67b95f0423a5353c711
Reviewed-on: https://code.wireshark.org/review/21508
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e3d284f6a89b2a04f378d0125cf7a7…
commit e3d284f6a89b2a04f378d0125cf7a75ec35b76de
Author: Dr. Lars Voelker <lars.voelker(a)bmw.de>
Date: Sun Apr 30 23:31:26 2017 -0400
Adding support for the NM protocol.
UDP-NM is an automotive communication protocol as standardized by
AUTOSAR and is specified in AUTOSAR_SWS_UDPNetworkManagement.pdf,
which can be accessed on:
autosar.org -> Classic Platform -> Software Arch -> Comm Stack.
It can run over UDP or CAN, which is why "UDP" is not in any user
exposed strings.
Change-Id: I68adfd941c193588a6c8ef0fe1cb7271f921623e
Reviewed-on: https://code.wireshark.org/review/21437
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4302a0ad650627b4c0e6f48a90ed64…
commit 4302a0ad650627b4c0e6f48a90ed642939b14841
Author: Adrian Simionov <daniel.simionov(a)gmail.com>
Date: Sun Apr 30 22:10:12 2017 +1000
[docsis->dccrsp] Resolve confirmation code
Change-Id: I1f863eea427529537df004e9782311d5c69ed4bd
Reviewed-on: https://code.wireshark.org/review/21505
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ae8b18d6183538a4ffd5d18588be1b…
commit ae8b18d6183538a4ffd5d18588be1b5e1a058206
Author: Rado Radoulov <rad0x6f(a)gmail.com>
Date: Thu Apr 27 13:06:24 2017 -0400
New Lua function TreeItem:referenced(ProtoField | Dissector).
This function returns TRUE/FALSE depending whether the specified ProtoField/Dissector
needs to be dissected. By using this function in conjunction with the
TreeItem.visible
attribute, Lua dissectors can be significantly sped up by making less C interop calls
which are relatively slow in terms of dissection especially when using sub-protocols
where the dissection of an entire protocol can be skipped.
Added tests for TreeItem:referenced to protofield.lua
Change-Id: I44feacb91a2a5b0e3c28c0ccd8d6b04cccd67261
Reviewed-on: https://code.wireshark.org/review/21387
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=ce8863c6efcee54655b7856002430b…
commit ce8863c6efcee54655b7856002430bd1716a7776
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu May 4 20:03:35 2017 +0200
nsh: fix stack overflow due to missing length checks
After v2.3.0rc0-3167-ge6f944d632, the NSH dissector could call itself
recursively and since the minimum header length was not validated, it
could result in a stack overflow due to infinite recursion.
Add checks based on the text from
https://tools.ietf.org/html/draft-ietf-sfc-nsh-12#section-3.2
This patch also fixes a regression since v2.3.0rc0-3171-g2273cf0e7b
where the wrong tvb was passed to subdissectors. Tested with the two
captures from bug 11490.
Bug: 13612
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1156
Change-Id: I8cacfa267557e8373ff8134f4b020d927e37842f
Reviewed-on: https://code.wireshark.org/review/21499
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a9be0881285c948b5bcf8dd3f11c03…
commit a9be0881285c948b5bcf8dd3f11c0369f2735b98
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu May 4 18:18:20 2017 -0700
Fix previous change.
Change-Id: I6093d9f5d498c003d14e4f3cec4220eb191d550e
Reviewed-on: https://code.wireshark.org/review/21506
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dd884611ac69f1c671bf11a8c57267…
commit dd884611ac69f1c671bf11a8c57267dd629fd803
Author: Hessam Jalali <hessam.jalali(a)gmail.com>
Date: Mon Apr 24 17:31:00 2017 +0430
Auto reset epan session
Automatically resets intarnal epan session after reaching to
specified number of packets, for example
-M 1000
will reset the session every 1000 packets.
this is more like a proposal since the usage is very specific
it is useful for 24/7 live capture with dissection and sending
data directly to another application.
example:
tshark -Y "gtp" -M 100000 -T fields -e gtp.message -e gtp.teid
Change-Id: I8ee8b0380017c684120a93cb3fb43f41615a9c04
Reviewed-on: https://code.wireshark.org/review/21312
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Petri-Dish: Evan Huus <eapache(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8e52cfb891aa5de7b20f5dbd847160…
commit 8e52cfb891aa5de7b20f5dbd8471609e6c6ca40d
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Thu May 4 14:21:27 2017 +0200
Qt: Inhibit Disable Protocol when applicable
The packet details context menu allows you, through the Protocol
Preferences sub menu to manipulate (disable) the protocol dissection
through the Disable <protocol>... option. This opens up the appropriate
dialog and select the applicable protocol.
This fails for protocols which have their can_toggle flag reset (e.g.
the frame protocol). The dialog opens, but the protocol can't be found,
hence the top item is selected.
Instead disable the menu option for protocols which can't have their
enabled state toggled.
Change-Id: Ifa83f656a8ab747f379d3ca0114520e5efed4b67
Reviewed-on: https://code.wireshark.org/review/21494
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8bed61f9fcc83e98b22d4c4b4408c7…
commit 8bed61f9fcc83e98b22d4c4b4408c7b6b276e78c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu May 4 14:02:08 2017 -0700
Use proto_tree_add_item_ret_uint() for the RFID.
Do some whitespace cleanup while we're at it.
Change-Id: I1c55ce916b6d8344736f5732130613f63cf4d60f
Reviewed-on: https://code.wireshark.org/review/21502
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=508bec78a39f0c7a2a54986b7616e4…
commit 508bec78a39f0c7a2a54986b7616e4f615d6f170
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu May 4 18:45:55 2017 +0200
bootp: fix potential buffer overflow (read)
The Vendor class Identifier is a string (used with strncmp). Be sure to
obtain a null-terminated string.
Bug: 13628
Change-Id: Ic6457da171fbfa1bd18366d965d22e942fb080d6
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1183
Bug: 13609
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1153
Reviewed-on: https://code.wireshark.org/review/21498
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2f35a811a33e21b06adf917051aa9a…
commit 2f35a811a33e21b06adf917051aa9a7a66c95544
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu May 4 17:57:23 2017 +0200
dfilter: fix memleak when using value_string values
When using a filter such as "ncp.alloc_reply_lvl2 == FALSE", a memory
leak would occur as follows:
1. dfilter_fvalue_from_unparsed is called and
2. ends up calling _uint64_from_unparsed
3. which fails with error message "\"FALSE\" is not a valid
number.".
4. Next, mk_fvalue_from_val_string is called which maps "FALSE" to 0
5. and the filter is successfully compiled.
6. dfwork_free deliberately does not free the error message (since
there should be none at this point) and we have a memleak (from 3).
Fix this memleak by clearing the error message when a successful
value_string mapping is found.
Change-Id: I78d59a4336342b09dc5448ea994b2e1d199d7f3f
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1302
Reviewed-on: https://code.wireshark.org/review/21497
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=98d87038a7db23c61acb24b4311e82…
commit 98d87038a7db23c61acb24b4311e826d3c63ba8f
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Thu May 4 00:22:28 2017 +0200
ua3g: added SET_SIP_PARAMETERS and FREESEATING messages decoding
Change-Id: I6e00edfa09dea6f9f8c24b72769257ce428bfc61
Reviewed-on: https://code.wireshark.org/review/21481
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cd7980206347563f93b134dec16161…
commit cd7980206347563f93b134dec16161ba519ad538
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu May 4 00:20:37 2017 -0700
Another comment explaining why a packet size check isn't necessary.
Change-Id: Id7494823f9af69c6185b41983ca78ead2dae24dd
Reviewed-on: https://code.wireshark.org/review/21492
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4ca15be3eb1f3675d7f683e0b9b433…
commit 4ca15be3eb1f3675d7f683e0b9b433999835dccc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu May 4 00:12:07 2017 -0700
Do packet length checks iff they're necessary.
They're not necessary for most hardware; remove the unnecessary checks,
and add comments indicating why they're not necessary (or fix the
"maximum value of actual_octets is" part of the comment).
They *are* necessary for Series III hardware; put in the check.
Change-Id: Idd64a74099d5cf7398a2ddb850442e53c9206724
Reviewed-on: https://code.wireshark.org/review/21491
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dead1b3817d3992cbce0d5c3c7b392…
commit dead1b3817d3992cbce0d5c3c7b3928f44e7e207
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 21:51:12 2017 -0700
Add a comment.
Change-Id: Ia60a0cdac3d70862aa5941487af142bd26ab2b80
Reviewed-on: https://code.wireshark.org/review/21489
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8638eb91c78cd773b59636bc40642a…
commit 8638eb91c78cd773b59636bc40642a0ae0e55409
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Wed May 3 22:56:55 2017 +0100
Add g_get_monotonic_time() to glib-compat and use
Change-Id: If41dab19692516270e8b4bcf1a8a954bb8dc3ccc
Reviewed-on: https://code.wireshark.org/review/21480
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d5c98c4a6ee08faa8a747d631ab12…
commit 0d5c98c4a6ee08faa8a747d631ab12db5e714e6e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 20:28:29 2017 -0700
Clean up whitespace and a #define.
Add some additional blank lines, remove some extra, blank lines, fix
indentation.
Make vVW510024_E_IS_VLAN 32-bits, to match the other flags.
Change-Id: Id1cd63ff2b75764907a44e9f8525b1537666fde1
Reviewed-on: https://code.wireshark.org/review/21488
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0d69b9aef11872f689e7ebd8c242fb…
commit 0d69b9aef11872f689e7ebd8c242fbf146589d9d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 19:55:39 2017 -0700
Update comments.
There's only a 17-byte PLCP header with the Series III hardware.
Change-Id: Ice8dfbbc5daa0578ee4eb6588fc8a8b597806d0d
Reviewed-on: https://code.wireshark.org/review/21487
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7703d45803c487062209f70ae19f28…
commit 7703d45803c487062209f70ae19f28e1d4327310
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 19:50:11 2017 -0700
Use a #define for the PLCP type.
That makes it clearer that the Series I hardware doesn't do HT or VHT.
Change-Id: Ibeccfcba997555bef06098828f01951dc32a6d2c
Reviewed-on: https://code.wireshark.org/review/21486
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=04e5d8d715890601b66ea69898e0e6…
commit 04e5d8d715890601b66ea69898e0e60cc928d3aa
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 19:12:03 2017 -0700
Remove an unnecessary comment, fix another comment.
Change-Id: Id20517c99663c624b6bfd58d7475284db450e003
Reviewed-on: https://code.wireshark.org/review/21485
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1ac685f7719fe996702fd65bb0fa1d…
commit 1ac685f7719fe996702fd65bb0fa1d72b292b831
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 18:53:00 2017 -0700
Remove trailing white space.
Change-Id: I8cdbde058c7ebb9aaaac4739e9a5c206e0d2c919
Reviewed-on: https://code.wireshark.org/review/21484
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7c6bdc3ac90f8b526050d7b4327109…
commit 7c6bdc3ac90f8b526050d7b4327109b8442bb61d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 18:45:11 2017 -0700
More description of stats headers.
Change-Id: I21ee8b39b96dd58ea1dfeb502e8734b33aa298c1
Reviewed-on: https://code.wireshark.org/review/21483
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6b7d99022b1007d8762e4c46bd5a74…
commit 6b7d99022b1007d8762e4c46bd5a746674349cca
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 18:32:31 2017 -0700
Fix some comments, shuffle some code, change a constant in an assignment.
Fix "VHTPPDU" to be "VHT PPDU".
Move the code that processes the RSSI values before the code that
processes the next two bytes of the header, so it's done in order; that
makes it a bit easier to see the layout of that header (although 2 bytes
of it are processed below).
Fix the comment describing what the first 16 bytes of the record data
after the stats are. Don't use vVW510021_W_STATS_HEADER_LEN - that's
for the Series II hardware.
Fix some indentation.
Change-Id: If47c4a44fd5e72971a28daf6af88d5e19c53abbe
Reviewed-on: https://code.wireshark.org/review/21482
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=81292f3ac786578f0cadee55f16f6d…
commit 81292f3ac786578f0cadee55f16f6dfb8315b705
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 14:23:54 2017 -0700
Put back the null terminator in the list of handles.
The code to scan the list has always required a null terminator, but
change 96f517647a8f8b22c66eacf6e3d8bea9d8b8c68f got rid of the null
terminator.
Change-Id: I13c1553114e08e8617adaf8874ffb5e7c7c4b2d3
Reviewed-on: https://code.wireshark.org/review/21477
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e0ab0b72aebf50f65da6bac2841bbb…
commit e0ab0b72aebf50f65da6bac2841bbbae529d8728
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Wed May 3 17:44:33 2017 +0100
Extcap: use glib-compat for g_list_free_full()
Change-Id: I13e6a465b0e169f2f4ce134df3c873c416737b33
Reviewed-on: https://code.wireshark.org/review/21476
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dbae27f7b2ee3d2960cd5cc8b36c33…
commit dbae27f7b2ee3d2960cd5cc8b36c333560fd7664
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed May 3 09:38:29 2017 -0400
[DOCSIS] Use expert info instead of THROWing bounds errors for bad lengths
Also adjust whitespace for a few places where if (tree) would mess up
expert_info use.
Change-Id: I79b8f7105515fb9ce220a46f3e875be466ee1044
Reviewed-on: https://code.wireshark.org/review/21474
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8f6b8e29f9d7a77bf0306315901c36…
commit 8f6b8e29f9d7a77bf0306315901c3677aa6ec410
Author: Michael Tuexen <tuexen(a)wireshark.org>
Date: Wed May 3 10:47:54 2017 +0200
Add support for TCP over UDP.
Add support to configure a port number for encapsulating TCP
packets in UDP.
Change-Id: I9aea1eda4537b05e76e76ed0417acb34705bad9e
Reviewed-on: https://code.wireshark.org/review/21473
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Tüxen <tuexen(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=e9d3cb9a4f0cfd049c553027cbe7a3…
commit e9d3cb9a4f0cfd049c553027cbe7a38da22cff7c
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Tue May 2 22:57:56 2017 +0200
ua3g: updated SET_PARAM_REQ message decoding
Change-Id: Ic20286111b39539b5c423cc2442be0533d0b631e
Reviewed-on: https://code.wireshark.org/review/21468
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=91a21b3eda3757da1d82db80025edb…
commit 91a21b3eda3757da1d82db80025edb18b579e104
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Apr 5 13:29:25 2017 +0200
[mbtcp] Separate conversation and per-packet data, build ppd on first
pass.
Change-Id: I741824b239476a3eafa481344a3f699f986a03c8
Reviewed-on: https://code.wireshark.org/review/20927
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0807e50f69c9e7cc7504b8e0da7dd2…
commit 0807e50f69c9e7cc7504b8e0da7dd26b0c16708c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue May 2 18:19:46 2017 +0200
TLS13: update HKDF-Expand-Label for draft -20
This is needed for decryption to work in draft -20. Since lots of
implementations are still at draft -18, maintain decryption support for
older draft versions. Tested with tls13.pcapng (attachment 15156).
Change-Id: Ieb7d85136221573007b529b40e4eadc60eac174f
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/21467
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=80176e0223b6c73a24f91b504b3382…
commit 80176e0223b6c73a24f91b504b33820ad29c9065
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue May 2 17:54:49 2017 +0200
TLS13: update Certificate dissection for draft -20
RawPublicKey (RFC 7250) has been incorporated in the Certificate
message, update the definition and restructure the code accordingly.
No functional change for X.509 certs, but RPK types will now be
correctly handled for TLS 1.3 (including the context and extensions).
Ran the test suite and tested for regressions using
rpk-certficate-message.pcapng from bug 11480.
Change-Id: If551a30344851313430201cb6d6198b2091efc2d
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/21466
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=62adcd6d17f8f2e620045011a816db…
commit 62adcd6d17f8f2e620045011a816dbbbbb288e85
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Wed May 3 00:19:03 2017 +0200
USB: prevent array bounds overflow from invalid Darwin transfer type
During 'Darwin' transfer type conversion the network data is taken
as-is, without checking validity. This results in indexing errors.
Add validation before using as array index.
Bug: 13676
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1307
Change-Id: I24ca49bb21ba36a8d6a3c078ac2c05ded7b8d382
Reviewed-on: https://code.wireshark.org/review/21470
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=37d0e1b0b7fdfa26efaf5811cb5612…
commit 37d0e1b0b7fdfa26efaf5811cb56129e9f72f26e
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Tue May 2 23:36:05 2017 +0200
ua3g: updated START_RECORD_RTP message decoding
Change-Id: I98d2aa5098d3019f829e75e46a0842a9d87786aa
Reviewed-on: https://code.wireshark.org/review/21469
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13b65875d640fc860c4b0eaa12b88a…
commit 13b65875d640fc860c4b0eaa12b88a2f60c936c4
Author: Binh Trinh <beango(a)gmail.com>
Date: Sun Apr 30 23:17:14 2017 -0400
pdcp-lte: add preference to ignore Set Security Algorithm
Useful when captures are already deciphered
Change-Id: Ie0f57efa6dccd21d7bd0f25851cbdc8887d7fbbf
Reviewed-on: https://code.wireshark.org/review/21443
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c6b56bb9c0263d400501671a7f7a69…
commit c6b56bb9c0263d400501671a7f7a69b8b38db16f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed May 3 00:23:33 2017 -0700
Fix handling of Header IEs.
Add the tree for the type/length/element ID for *all* IEs, whether we
know the IE type or not.
The total length of the IE is 2 + the value of the length field; always
advance by that much. This prevents infinite loops.
Fix the name of a field.
Bug: 13678
Change-Id: Iadc537653999a4a796c6689b180cf1b75e175035
Reviewed-on: https://code.wireshark.org/review/21472
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dbd5902e76c94e53ba19cba830186d…
commit dbd5902e76c94e53ba19cba830186d4337f9cb69
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue May 2 19:52:05 2017 -0700
Add terminating NULL to lists for proto_tree_add_bitmask().
Those lists require null terminators; fix the script to add them, and
re-run the script (with the current tip of the master branch for
xcbproto and mesa).
Change-Id: I76c156521e79753f5c19cae16e9caa031abd2496
Reviewed-on: https://code.wireshark.org/review/21471
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4a41c2412b1a96bae0843f815d766f…
commit 4a41c2412b1a96bae0843f815d766f12cb8387bb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 12:56:52 2017 +0200
scsi: fix conflicting entry in its value_string
Field 'SPC-2 Opcode' (scsi.spc.opcode) has a conflicting entry in its
value_string: 132 is at indices 26 (Receive Copy) and 27 (Receive Copy Results))
Change-Id: I5916bab1bb493226003e86b5a6b693fd4a727499
Reviewed-on: https://code.wireshark.org/review/21458
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=427c800a9fb41d0c6147b5eac7b82c…
commit 427c800a9fb41d0c6147b5eac7b82c0e62d4c58f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 14:58:26 2017 +0200
lemon: fix no previous prototype for ‘memory_error’ [-Wmissing-prototypes]
Change-Id: I5830581c843af41f48bc9645c2be7cf35fa00391
Reviewed-on: https://code.wireshark.org/review/21463
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67cfac7ef94d05f5f18fae27cec085…
commit 67cfac7ef94d05f5f18fae27cec0853a21b46495
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 14:55:24 2017 +0200
extcap (parser): fix no previous prototype for ‘extcap_free_toolbar_value/control’
Change-Id: I9ebf5a48534915e5f316358af3637c4fce69593c
Reviewed-on: https://code.wireshark.org/review/21462
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=61436c0308b9a1e700355de47f8f27…
commit 61436c0308b9a1e700355de47f8f27ea9d2a6d39
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 15:45:01 2017 +0200
TLS (1.3): Add new extension 'post_handshake_auth' add on draft 20
The "extension_data" field is zero length.
Ping-Bug: 12779
Change-Id: I7a512d7940f55a5edf2c4f71bf1684c3d4e4733a
Reviewed-on: https://code.wireshark.org/review/21465
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=7826ae4ac4dd11789c2e4bb2d40031…
commit 7826ae4ac4dd11789c2e4bb2d4003185141ced6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 15:35:12 2017 +0200
TLS: Add support of TLS 1.3 (draft 20)
Ping-Bug: 12779
Change-Id: I6c54f7c4d793a99e448cbfe6b2971cae418f2d39
Reviewed-on: https://code.wireshark.org/review/21464
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=fc931b8d912ce1be08129b578eba8c…
commit fc931b8d912ce1be08129b578eba8c26da12813c
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Wed Apr 26 21:46:14 2017 +0100
Snort: Ask for needed fields.
Doesn't seem to make a difference at the moment, but ask
for it regardless.
Change-Id: I94ff4f1321b2b2f2cde23f3281a6b79fd7048009
Reviewed-on: https://code.wireshark.org/review/21436
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66d6ff9f98edea9efe848f35fc3a0e…
commit 66d6ff9f98edea9efe848f35fc3a0e853c5b86c6
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Tue May 2 10:37:22 2017 +0200
ua3g: updated RESET message decoding (appl_mode, sip_name and reset_mac parameters)
Change-Id: I4604b4de036f5e2d43a6e4f52e64576d63f2c8ed
Reviewed-on: https://code.wireshark.org/review/21449
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=03362436ecb22d03a850877704a806…
commit 03362436ecb22d03a850877704a806a4ec19057b
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Tue May 2 10:49:12 2017 +0200
ua3g: updated REDIRECT message decoding (redundant maincpu parameter)
Change-Id: I4c703d380010ed784946a0093307423c227d37eb
Reviewed-on: https://code.wireshark.org/review/21450
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a81ddf2d4c090077df554d819e83a6…
commit a81ddf2d4c090077df554d819e83a6f46ca81e44
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 09:09:32 2017 +0200
nmas (ncp): fix conflicting entry in its value_string
Field 'Return Code' (nmas.return_code) has a conflicting entry in its
value_string: 4294965609 is at indices 56 ((-1687) EVALUATION VERSION WARNING) and 58
((-1689) THREAD CREATE))
Field 'Return Code' (nmas.return_code) has a conflicting entry in its
value_string: 4294965610 is at indices 55 ((-1686) DLL FAILED LOADING) and 59 ((-1690)
SECURE CHANNEL REQUIRED))
Field 'Return Code' (nmas.return_code) has a conflicting entry in its
value_string: 4294965611 is at indices 54 ((-1685) UNICODE FAILED INIT) and 60 ((-1691) NO
DEFAULT USER SEQUENCE))
Field 'Return Code' (nmas.return_code) has a conflicting entry in its
value_string: 4294965612 is at indices 53 ((-1684) CODEPAGE FAILED INIT) and 61 ((-1692)
NO TREENAME))
Field 'Return Code' (nmas.return_code) has a conflicting entry in its
value_string: 4294965613 is at indices 52 ((-1683) DOUBLEBYTE FAILED INIT) and 62 ((-1693)
MECHANISM NOT FOUND))
Field 'Payload Error' (nmas.encrypt_error) has a conflicting entry in its
value_string: 4294965609 is at indices 56 ((-1687) EVALUATION VERSION WARNING) and 58
((-1689) THREAD CREATE))
Field 'Payload Error' (nmas.encrypt_error) has a conflicting entry in its
value_string: 4294965610 is at indices 55 ((-1686) DLL FAILED LOADING) and 59 ((-1690)
SECURE CHANNEL REQUIRED))
Field 'Payload Error' (nmas.encrypt_error) has a conflicting entry in its
value_string: 4294965611 is at indices 54 ((-1685) UNICODE FAILED INIT) and 60 ((-1691) NO
DEFAULT USER SEQUENCE))
Field 'Payload Error' (nmas.encrypt_error) has a conflicting entry in its
value_string: 4294965612 is at indices 53 ((-1684) CODEPAGE FAILED INIT) and 61 ((-1692)
NO TREENAME))
Field 'Payload Error' (nmas.encrypt_error) has a conflicting entry in its
value_string: 4294965613 is at indices 52 ((-1683) DOUBLEBYTE FAILED INIT) and 62 ((-1693)
MECHANISM NOT FOUND))
Change-Id: I2bdaa16b04c9d34cfbc5e83ca2b612326216224a
Reviewed-on: https://code.wireshark.org/review/21451
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=527c31fdc986bff555cd6b8ecacc58…
commit 527c31fdc986bff555cd6b8ecacc586265bb1469
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue May 2 14:36:00 2017 +0200
Qt: Fix build without extcap
Change-Id: Ibfcdb719408c0172ae78bf3b2761ff551ff6313c
Reviewed-on: https://code.wireshark.org/review/21461
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=798773b9922a1427cd0f465295e088…
commit 798773b9922a1427cd0f465295e08837f1c58cb8
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 10:52:57 2017 +0200
mq: fix conflicting entry in its value_string
Field 'Selector........' (mq.inq.sel) has a conflicting entry in its
value_string: 2002 is at indices 221 (MQCA_BASE_Q_NAME) and 222 (MQCA_BASE_OBJECT_NAME))
Change-Id: Ie81b58bf9c32ea38ff5d0808accdd8e9dac3b81a
Reviewed-on: https://code.wireshark.org/review/21453
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9fc3b47b5c3a584ad50de8a054d8c2…
commit 9fc3b47b5c3a584ad50de8a054d8c2212429e09b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 12:17:53 2017 +0200
pn532 (rfid): fix conflicting entry in its value_string
Field 'SAM Mode' (pn532.sam.mode) has a conflicting entry in its value_string:
3 is at indices 2 (Wired Card Mode) and 3 (Dual Card Mode))
Change-Id: I5ee07aff43e2f5ba7a2757057a0da80e2f747541
Reviewed-on: https://code.wireshark.org/review/21455
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=886c571b473b8be51c0c476c517caa…
commit 886c571b473b8be51c0c476c517caa655b6f44ef
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 09:12:26 2017 +0200
nettl: fix conflicting entry in its value_string
Field 'Trace Kind' (nettl.kind) has a conflicting entry in its value_string:
536870912 is at indices 2 (Incoming PDU - PDUIN) and 3 (PDUIN))
Field 'Trace Kind' (nettl.kind) has a conflicting entry in its value_string:
268435456 is at indices 4 (Outgoing PDU - PDUOUT) and 5 (PDUOUT))
Change-Id: I14d47225a4ae83b6667313e5c0ca13e4d4d64831
Reviewed-on: https://code.wireshark.org/review/21452
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b64889d62e9b4a5494c38b7e585c6e…
commit b64889d62e9b4a5494c38b7e585c6eedae1a466c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 12:16:16 2017 +0200
kerberos: fix conflicting entry in its value_string
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its
value_string: 1 is at indices 1 (kRB5-PADATA-TGS-REQ) and 2 (kRB5-PADATA-AP-REQ))
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its
value_string: 15 is at indices 15 (kRB5-PADATA-PK-AS-REP-19) and 16
(kRB5-PADATA-PK-AS-REQ-WIN))
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its
value_string: 20 is at indices 21 (kRB5-PADATA-USE-SPECIFIED-KVNO) and 22
(kRB5-PADATA-SVR-REFERRAL-INFO))
Change-Id: I504291b8eb181c9e40d54421f583755cfc4f17db
Reviewed-on: https://code.wireshark.org/review/21454
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=093f13065247c9337a7a3319dfe3ca…
commit 093f13065247c9337a7a3319dfe3ca56e7d01eff
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue May 2 12:24:56 2017 +0200
qllc: fix conflicting entry in its value_string
Field 'Error' (qsig.error) has a conflicting entry in its value_string: 43 is
at indices 12 (proceduralError) and 42 (notActivated))
Change-Id: Ic1468f32922644933a79db504a4ecfb6e2289bd2
Reviewed-on: https://code.wireshark.org/review/21457
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=741d4f5898082f29c6732f16dd5713…
commit 741d4f5898082f29c6732f16dd57139021545c15
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Apr 28 21:26:53 2017 +0200
Qt: Interface Toolbar improvements
- Select one of the capturing interfaces when start capture
- Only send user changed control values when start capture
- Don't show hidden interfaces
- Allow a toolbar with no interfaces
- Renamed button role "reset" to "restore"
- Improved control number validation
- Updated documentation
Change-Id: Icc8d04043c95c1f3ef8d7cdc3b251be4471cba0a
Reviewed-on: https://code.wireshark.org/review/21445
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=afb4de370a4c54e08e9367b55ae142…
commit afb4de370a4c54e08e9367b55ae142414efc6e8f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Apr 29 10:30:23 2017 -0400
packet-bzr.c: Prevent infinite loop
Bug: 13599
Change-Id: If85588099d7c6635865614f8778a903a5e971789
Reviewed-on: https://code.wireshark.org/review/21410
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6907601211d579dce185494d21f08b…
commit 6907601211d579dce185494d21f08b97ef4867fe
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon May 1 20:27:01 2017 -0700
Improve the handling of the PLCP header.
Dissect the PLCP headers in a bit more detail, and use bit fields. Use
common code.
Change-Id: I8711cba71894bebf94f17fdba98b28cc7a620f81
Reviewed-on: https://code.wireshark.org/review/21448
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c9f3adda808ec805931494def179db…
commit c9f3adda808ec805931494def179db4c2b7f85fb
Author: Adrian Simionov <daniel.simionov(a)gmail.com>
Date: Sun Apr 30 20:36:14 2017 +1000
[docsis->dccrsp] Update TLV numbers and names to MULPIv3.1-I10
Change-Id: I72bec5bcbe7e2139ae36bf704e7ebda9207331fd
Reviewed-on: https://code.wireshark.org/review/21424
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2e2ba64b7214fd449131368f3973cb…
commit 2e2ba64b7214fd449131368f3973cbe26f382e2e
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon May 1 18:35:04 2017 +0200
file: (trivial) initialize "passed" when it's declared
Change-Id: I2ace2a6847ca01435651a48934acf9c1c6d2f23d
Reviewed-on: https://code.wireshark.org/review/21444
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=cd12580de127fb5647c7bc11562968…
commit cd12580de127fb5647c7bc115629682527395e8a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 19:55:06 2017 -0700
For S3, yes, the PLCP type can be vVW510021_W_PLCP_LEGACY.
(The dissector checks for it.)
Change-Id: Ic1456b263f3cbda2a630259a2b71b1f1015b5e3e
Reviewed-on: https://code.wireshark.org/review/21442
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=477c4edd346f98b1215787404bc7f6…
commit 477c4edd346f98b1215787404bc7f605389839db
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 19:53:51 2017 -0700
Fill in more fields of the 802.11 radio metadata structure.
Also, use #defines for the PLCP type, and add some comments about the
PLCP format, and fill in the "short GI" flag from the PLCP header.
Change-Id: Ia3c44cc12feb87c181783e9dc37fe0877d1e2a81
Reviewed-on: https://code.wireshark.org/review/21441
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=88147079fc5bfe88e6a3efdbd2e1de…
commit 88147079fc5bfe88e6a3efdbd2e1de8e11e1a463
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 17:28:38 2017 -0700
Replace some proto_tree_add_uint() calls with proto_tree_add_item().
If we're fetching a value only to use it in proto_tree_add_uint(), we
might as well just use proto_tree_add_item().
Change-Id: I504c54f972b2844f57f25c9ffc89c142c8dc495f
Reviewed-on: https://code.wireshark.org/review/21440
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=20d6b67bff2eee410cb6237b572421…
commit 20d6b67bff2eee410cb6237b572421467e7a54ba
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 17:10:02 2017 -0700
Make the record-length checks take the RF information into account.
Include the RF information length if there's RF information.
While we're at it:
Rename the variable holding the offset of the stats information from "j"
to "stats_offset", to make it clearer what it is.
Clean up whitespace.
Get rid of comments that no longer apply.
Improve the comment explaining the MPDU_OFF value for Series III.
Change-Id: I49e2926a80aa8bb11f87d97fdc628bcc9f1220e0
Reviewed-on: https://code.wireshark.org/review/21439
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=30d674b241095a83a4e9d572d6dbe5…
commit 30d674b241095a83a4e9d572d6dbe550aec01af3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 12:44:55 2017 -0700
Do all the command-type analysis of decode_msg() in the switch statement.
Add #defines for the remaining command types, based on some other
Get rid of the HEADER_IS_xxx #defines; they're the same for all
hardware, and the switch statement doesn't distinguish between different
hardware.
Set *IS_TX in the switch statement cases. While we're at it, set v_size
and *v_type in the default case; add a VT_UNKNOWN value for that case.
Change-Id: Ib17d1e435c99fcb746144b4735c160a5f22b7544
Reviewed-on: https://code.wireshark.org/review/21438
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9606d671f6c19482a19c11daebd2fa…
commit 9606d671f6c19482a19c11daebd2fafc31c94a57
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 11:08:20 2017 -0700
Use some #defines.
Change-Id: I9cafd3b745eb0fec39c0a9b5f529249584107971
Reviewed-on: https://code.wireshark.org/review/21435
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2700055d3cc6f6ddc7c8c0be4adb29…
commit 2700055d3cc6f6ddc7c8c0be4adb29f064f2f959
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 10:43:52 2017 -0700
Fix a comment to reflect reality.
There aren't any "4 Management bytes for OCTO version FPGA" in that
header.
Change-Id: I57f673dad5bc10b888fae22c2fb1a45af57ff493
Reviewed-on: https://code.wireshark.org/review/21434
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=df77121071c75668de96f9049a367d…
commit df77121071c75668de96f9049a367d8f070cbf0b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 10:13:50 2017 -0700
Remove now-unused variables and code and unnecesary headers.
We're not doing any CRC stuff here - that's the job of the 802.11
dissector, which does it Just Fine - so remove what remains of the stuff
for it.
Change-Id: If6a0113dec7773b3b4daa7fa014f02c6a97eca0d
Reviewed-on: https://code.wireshark.org/review/21433
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f9997eebd92443313f0b029579ba6d…
commit f9997eebd92443313f0b029579ba6d4ffdce7e70
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 30 14:53:01 2017 +0200
GSM SMS: use TCAP OTID as last resort for reassembly when GSM MAP does not give info
Bug: 13592
Change-Id: Ie13e7466da906e72418c6f9d5ea6f816ff14e129
Reviewed-on: https://code.wireshark.org/review/21425
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e2ce1d3e0ca5c6c685a267b2ea741…
commit 0e2ce1d3e0ca5c6c685a267b2ea741789d4f5f7b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 09:55:22 2017 -0700
Pass inforation from dissect_ixveriwave() to wlantap_dissect().
Always set log_mode - if the command type is 3, set log_mode to 0, as
it's not supplied by the libwiretap code.
Pass log_mode and is_octo from dissect_ixveriwave() to
wlantap_dissect(). Test is_octo in wlantap_dissect(), just as we do in
dissect_ixveriwave().
Change-Id: I536ca59f01e644d55e541df6d2e119db590ae48a
Reviewed-on: https://code.wireshark.org/review/21432
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=63e64e3bdbd91e190b7e091eccf6c5…
commit 63e64e3bdbd91e190b7e091eccf6c5edc5c231f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 30 09:31:14 2017 -0700
Remove a now-unused table.
Change-Id: Ibb04201bd2acd5fa6cbcd7837504b10d1d5174c4
Reviewed-on: https://code.wireshark.org/review/21430
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5de615c0a79527c71628d2216e7ac9…
commit 5de615c0a79527c71628d2216e7ac9a14f5b45c2
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Apr 30 08:16:34 2017 -0700
[Automatic update for 2017-04-30]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I491517d8801f9b5d3d3084102ed35b418460e4b6
Reviewed-on: https://code.wireshark.org/review/21427
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=638fb0a1507c7138e56b43e134e6fb…
commit 638fb0a1507c7138e56b43e134e6fb3d29a97646
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 30 09:30:09 2017 -0400
packet-ixveriwave.c: Initialize mgmt_byte
Suppress Ubuntu warning
Change-Id: Ia95e19d59b768b6842ca58051ffbd97dce84174c
Reviewed-on: https://code.wireshark.org/review/21426
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Uli Heilmeier <openid(a)heilmeier.eu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bb83fe45519eb280e6545ad69868e4…
commit bb83fe45519eb280e6545ad69868e4e7f5fbef93
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Wed Jan 6 17:23:00 2016 -0800
packet-ieee80211-radio.c: Minor refactor and whitespace cleanup
Change-Id: Idad8f7eeed968eeed9f553fef98d58453f328afb
Reviewed-on: https://code.wireshark.org/review/21421
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7f2c6e13001bed11ae113b0aca47e5…
commit 7f2c6e13001bed11ae113b0aca47e562735d6e26
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 20:51:38 2017 -0700
Some cleanup.
Whitespace, remove now-irrelevant comments, add more comments, expand
some comments, make an if chain more straightforward.
Change-Id: I9772022247e2f0fdbfc676db9f0031bad7f8884d
Reviewed-on: https://code.wireshark.org/review/21423
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9d49ab79a47438ed6125394371f29e…
commit 9d49ab79a47438ed6125394371f29e167dcb005f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 20:35:23 2017 -0700
Boolean bitfields don't need a mask, just a bit.
You don't have to and the bitfield container with a mask and compare it
against the bit, you can just test the bit, which is a pretty standard C
idiom.
Change-Id: I87b3d84f802114199fb93357358412c623199ca2
Reviewed-on: https://code.wireshark.org/review/21422
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=db2746a5f05f3e451e2f4244ddfb15…
commit db2746a5f05f3e451e2f4244ddfb159174b153e5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 20:13:03 2017 -0700
Get rid of some unused cruft, and rename an hf_ variable.
Change-Id: Ib74efc765d354b32b40ff298125d4e08f0eb3c2e
Reviewed-on: https://code.wireshark.org/review/21420
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d2b772e33eade2afbff65e7674c120…
commit d2b772e33eade2afbff65e7674c120dba04ac5c6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 19:56:04 2017 -0700
The encryption type field is part of a 16-bit bitfield.
Set its type accordingly.
Change-Id: I3f80828d9e248235db6f4b30f02ada6b6786d25a
Reviewed-on: https://code.wireshark.org/review/21419
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=287739baa26d3985ac69725c181df0…
commit 287739baa26d3985ac69725c181df00615367a50
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 19:51:43 2017 -0700
There's no "FCS is present" flag passed up from libwiretap.
For Ethernet, the FCS is absent; for 802.11, the Series I and II
hardware doesn't provide an FCS, but the Series III hardware appears to.
Get rid of the flag bit, and a bunch of other dead code (probably
inherited by copy-and-paste).
Change-Id: I44301c8211c25a5665eb528ac657925931d3f0b4
Reviewed-on: https://code.wireshark.org/review/21418
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5c1cf9d46ad80f1ce5367724fa28bb…
commit 5c1cf9d46ad80f1ce5367724fa28bb55a44dee39
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 19:42:18 2017 -0700
Series III packets appear to have an FCS at the end.
Change-Id: I9c4ba78cba4cb32a1473c6b8573880f2b56f1fde
Reviewed-on: https://code.wireshark.org/review/21417
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bc7452d1d91a6e3f1544037f60c351…
commit bc7452d1d91a6e3f1544037f60c3511c42e7e03a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 18:41:12 2017 -0700
Get rid of unused flag bits and #defines.
The "sent/received during CFP", "sent/received with fragmentation"
and
"frame has padding between 802.11 header and payload" flag bits are
never set by wiretap/vwr.c, so don't test them. They're copied over
from radiotap, but this is *not* radiotap.
Also, get rid of a bunch of unused #defines, and one instance of a
duplicate #define. Again, they're copied over from radiotap, but this
is *not* radiotap.
Change-Id: I1d62e6400fb21c40512005d88cbc06d8576e8183
Reviewed-on: https://code.wireshark.org/review/21416
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=113676bd952cde1d2be8817856bae2…
commit 113676bd952cde1d2be8817856bae2cd1f4777c5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 18:07:46 2017 -0700
Get rid of duplicate #defines, and shuffle some comments and #defines.
This makes stuff a bit clearer.
Also, add some comments, remove some redundant comments, fix some
comments, and use some #defines instead of hardcoded constants and
expressions.
And get rid of an unnecessary setting of *err to WTAP_ERR_SHORT_READ -
either it's a short read, in which case it was already set to
WTAP_ERR_SHORT_READ, or it's *not* a short read, in which case *err was
set to the appropriate error code, and we should leave it alone.
Change-Id: I657f505915854ac4a6b85e87b4021961b1a1c507
Reviewed-on: https://code.wireshark.org/review/21415
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a48997a1748c6106b6fcfc01440b28…
commit a48997a1748c6106b6fcfc01440b28643f77011d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 17:37:48 2017 -0700
Remove Series III code from vwr_read_s2_W_rec().
It's only called if vwr->FPGA_VERSION is S2_W_FPGA, so any code that's
run only if it's *not* S2_W_FPGA is dead code. Remove it, for clarity.
While we're at it, add some new comments, fix some comments, and get rid
of an unused argument to vwr_read_s2_W_rec().
Change-Id: I3e4bd5d7a79f36d8354a0bbf875ee87eeaf60d43
Reviewed-on: https://code.wireshark.org/review/21414
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c0a1ce2821009ae1e37c77ad233893…
commit c0a1ce2821009ae1e37c77ad23389347b96a5100
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 17:24:45 2017 -0700
Fix broken test for new Series III metadata header.
Add some comments while we're at it.
Change-Id: I87f97ab640d9a02c01923867d3d3b91e755d0e40
Reviewed-on: https://code.wireshark.org/review/21413
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7bd8ec1b243e8861a76d51648fb1c9…
commit 7bd8ec1b243e8861a76d51648fb1c9f187ba8930
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 10:03:35 2017 -0700
Fields added with proto_tree_add_bitfield() must have an integral type.
Change-Id: I314e192d1d2b6dbe1e098438ba4f407c9b5b6b14
Reviewed-on: https://code.wireshark.org/review/21411
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b8d473a7bc299272d93f69666c956b…
commit b8d473a7bc299272d93f69666c956baa8dd206b5
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Apr 29 14:24:59 2017 +0200
iso14443: dissect the type B bit rate info
Change-Id: I71b4d3c8f22c32f1aaf89f147bc6a20ce54aec4d
Reviewed-on: https://code.wireshark.org/review/21409
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=acdc0a0230f7d58e357c2c561de322…
commit acdc0a0230f7d58e357c2c561de322d964424290
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Apr 29 13:47:42 2017 +0200
extcap_free_interface_info: data param is used
The data parameter is used, remove the _U_ qualifier.
Change-Id: I3a3935bae958103da1a7a1abe0636e4781424aa7
Reviewed-on: https://code.wireshark.org/review/21408
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=2a3f1a4f6724c061f47a0266e157e6…
commit 2a3f1a4f6724c061f47a0266e157e6d84aa65c7d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 04:28:53 2017 -0700
Eliminate some double-frees.
The cfile_ error-reporting routines free err_info; the caller doesn't
have to and, in fact, mustn't do so themselves.
While we're at it, make sure wtap_seek_read() always zeroes out *err and
nulls out *err_info, so the latter either points to a freshly-allocated
string or is null.
Change-Id: Idfe05a3ba2fbf2647ba14e483187617ee53e3c69
Reviewed-on: https://code.wireshark.org/review/21407
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e3f49280deb11a7055083634fbbc4d…
commit e3f49280deb11a7055083634fbbc4d8416fce024
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 29 03:31:58 2017 -0700
Fix some field type errors.
Don't add FT_BOOLEAN and FT_NONE fields with proto_tree_add_uint().
Change-Id: I3c89aa161775fc639e6a7306282b55649a3c473a
Reviewed-on: https://code.wireshark.org/review/21406
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=cc9b38a734ac64603e78fe2dc00ad5…
commit cc9b38a734ac64603e78fe2dc00ad5bdc214e3ff
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 25 23:26:59 2017 -0400
Improve ixveriwave dissector
Bug: 13652
Bug: 12535
Change-Id: Ie4c140acbe983a585776bc1430cf407cdcd6e07a
Reviewed-on: https://code.wireshark.org/review/21356
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=fb1a6320ec67fc30414948b8e7e8c6…
commit fb1a6320ec67fc30414948b8e7e8c63c37a15983
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Apr 28 18:39:07 2017 +0200
GSM MAP: use TCAP OTID to retrieve SM-RP-OA and SM-RP-DA fields when required
Bug: 13592
Change-Id: Ib8a0ff6d897699c44e5c4b8834123169066cf904
Reviewed-on: https://code.wireshark.org/review/21397
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5bda98586b4f81c14a5f3b8feacd10…
commit 5bda98586b4f81c14a5f3b8feacd10392dc0d078
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 28 20:00:14 2017 -0700
Don't add /usr/X11/lib/pkgconfig if we're not using GTK+.
Qt for macOS doesn't use X11, so you don't need X11.
Change-Id: Ibc09a2d802f21b5be38baf735d2f6d582d6bf41f
Reviewed-on: https://code.wireshark.org/review/21401
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=57b17187d5eda5dd481d1bf5c5e026…
commit 57b17187d5eda5dd481d1bf5c5e026866fc38e91
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 28 19:55:44 2017 -0700
Get rid of a message that should no longer apply.
The version of pkg-config downloaded and built by macosx-setup.sh
defaults to looking in, among other places, /usr/local/lib/pkgconfig, so
you don't need to add that to PKG_CONFIG_PATH on macOS; Wireshark for
macOS no longer uses X11, so you don't need to add
/usr/X11/lib/pkgconfig to PKG_CONFIG_PATH on macOS.
Change-Id: I84fd6848b72010aafd7859c4e9c0a4362113c890
Reviewed-on: https://code.wireshark.org/review/21398
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b3a339b86f813fb9268039c643e11e…
commit b3a339b86f813fb9268039c643e11e6d92273ee7
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Thu Apr 27 17:23:03 2017 +0200
openSAFETY: Set filter list for nodes
To enhance the possibility for dissections, add a list
of nodes, you explicitly want to see and print an info
text in the node list for all nodes filtered
Change-Id: I08e8a7ddcfd7b78fee24431ffdae75124a8ecddd
Reviewed-on: https://code.wireshark.org/review/21383
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c9588ddc33b40c28787ab5aaad885…
commit 1c9588ddc33b40c28787ab5aaad885d76dbe37e7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Apr 28 08:00:18 2017 +0200
dis: fix conflicting entry in its value_string
Field 'Country' (dis.country) has a conflicting entry in its value_string: 107
is at indices 106 (Cote D'Ivoire (aka Ivory Coast)) and 107 (Ivory Coast (aka Cote
D'Ivoire)))
Field 'Country' (dis.aggregate.country) has a conflicting entry in its
value_string: 107 is at indices 106 (Cote D'Ivoire (aka Ivory Coast)) and 107 (Ivory
Coast (aka Cote D'Ivoire)))
Change-Id: Iabc2fafae5d756ff0cdfb4d16a8751b573378f06
Reviewed-on: https://code.wireshark.org/review/21396
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6a6f64d53ff320a61ac24a18d04073…
commit 6a6f64d53ff320a61ac24a18d040738ce71a2f7e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Apr 28 07:59:41 2017 +0200
cipmotion: fix conflicting entry in its value_string
Field 'Service Code' (cipm.svc.code) has a conflicting entry in its
value_string: 83 is at indices 30 (Run Hookup Test) and 31 (Get Hookup Test Data))
Change-Id: I3d650b0a6aeacb8e992126a7008e0b256cf1fe94
Reviewed-on: https://code.wireshark.org/review/21395
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=122c4dd04fa762092dc5c19a522c92…
commit 122c4dd04fa762092dc5c19a522c9297ea108f04
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Apr 27 17:34:46 2017 +0200
cmake: make docbook build optional if AsciiDoc is missing
This prevents ASCIIDOC2xxx from being invoked (which would define
useless targets and error out during the build since a2x is missing).
Now Wireshark.sln builds successfully without Cygwin.
Change-Id: I37684ce4a2ef22bdc74b388ced44271e14a1d337
Reviewed-on: https://code.wireshark.org/review/21384
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=976d8abce4194f591e18ea3da9f567…
commit 976d8abce4194f591e18ea3da9f5673659557b9d
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Thu Apr 27 20:24:51 2017 +0100
Snort: get rid of dependency on struct timeval
Change-Id: Iad529ddf85b315452adc26a2d1b4c609ac2aaa00
Reviewed-on: https://code.wireshark.org/review/21389
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=aeccfa3e651df3a4ee89ce334fad80…
commit aeccfa3e651df3a4ee89ce334fad80fda092c6f4
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 26 20:28:35 2017 +0200
GSM SMS: Use SIP To / From tapped addresses for reassembly
Ping-Bug: 13592
Change-Id: Ie07033972943ef38ca88bc0e82463ebccd281ce2
Reviewed-on: https://code.wireshark.org/review/21354
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ffddacf79ed36e70aa683126267531…
commit ffddacf79ed36e70aa6831262675317d0586b361
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Thu Apr 27 15:18:35 2017 +0200
uaudp: fixed decoding of CONNECT message
Change-Id: I69e0d9abc8e2fccf2837bf7dee52480063f11193
Reviewed-on: https://code.wireshark.org/review/21366
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=015d9194e1471455371ce7a8a59112…
commit 015d9194e1471455371ce7a8a591125a7c492619
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 27 18:23:48 2017 -0700
Add proto_tree_add_item_ret_boolean().
It does what it says on the label. You get back TRUE or FALSE in a
gboolean.
While we're at it, remove a copied-and-pasted comment that doesn't
apply, and update another comment.
Change-Id: I117391d2ffe44124a614a7f64dad1b389c1ebc6a
Reviewed-on: https://code.wireshark.org/review/21394
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b9d3db608de194d6f0e8bfeb1f1cbe…
commit b9d3db608de194d6f0e8bfeb1f1cbe9c5d8c858b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 15:17:46 2017 +0200
ipdc: fix conflicting entry in its value_string (and convert to value_string_ext)
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 255 is at indices 3 (SS -> GW: MRJ: Message reject.) and 32 (GW -> SS:
MRJ: Message reject.))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 17 is at indices 17 (SS -> GW: RCR: Release channel request) and 45 (GW
-> SS: RCR: Release channel request))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 18 is at indices 18 (SS -> GW: ACR: Release channel complete) and 46 (GW
-> SS: ACR: Release channel complete))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 125 is at indices 23 (SS -> GW: RTE: Request Test Echo) and 52 (GW ->
SS: RTE: Request Test Echo))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 126 is at indices 24 (SS -> GW: ARTE: Response to Request Test Echo) and
53 (GW -> SS: ARTE: Response to Request Test Echo))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 121 is at indices 25 (SS -> GW: NATV: Native Mode Q.931 Signaling
Transport) and 54 (GW -> SS: NATV: Native Mode Q.931 Signaling Transport))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 122 is at indices 26 (SS -> GW: TUNL: Tunneled Transport of signaling
protocol data units) and 55 (GW -> SS: TUNL: Tunneled Transport of signaling protocol
data units))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its
value_string: 122 is at indices 26 (SS -> GW: TUNL: Tunneled Transport of signaling
protocol data units) and 55 (GW -> SS: TUNL: Tunneled Transport of signaling protocol
data units))
Change-Id: I2d679f01ff9ddb6618ebd7212d1d7789045b434c
Reviewed-on: https://code.wireshark.org/review/21378
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=755bc5c506716b2e336a47edc81898…
commit 755bc5c506716b2e336a47edc818980cedd2cffc
Author: Radhashyam Behera <radhashyambehera(a)gmail.com>
Date: Wed Apr 19 16:22:52 2017 -0400
IEEE80211: Support of PHI, PSI Angle Decode in VHT Compressed Beamforming Report
Bug: 13341
Change-Id: Ide9c9a08b73e97ddb716fd307800f58efb9bcb0e
Reviewed-on: https://code.wireshark.org/review/19739
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2a906b9c9f0a499a4da8ad2256c5d6…
commit 2a906b9c9f0a499a4da8ad2256c5d63f1c81656e
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Wed Apr 26 22:51:30 2017 +0200
ua3g: update decoding of START_RTP message (new compressors and new parameter)
Change-Id: Ic5bd9afc2af14a64d074d598f1e185252308008b
Reviewed-on: https://code.wireshark.org/review/21357
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3f7f131ef372ec3a22f6363ab89dcd…
commit 3f7f131ef372ec3a22f6363ab89dcdc0fba2b377
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 27 09:28:25 2017 -0400
packet-rgmp.c: Ensure pinfo->dst is a valid IPv4 address
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1243
Bug: 13646
Change-Id: I2174e79dd2a9679f099c87c55c33984aca891d22
Reviewed-on: https://code.wireshark.org/review/21368
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=92e61ed35b6d93094658140c187390…
commit 92e61ed35b6d93094658140c18739032a05e5b5d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 26 20:12:21 2017 +0200
cmake: cleanup package variable
Do not print a message for a variable if the package does not provide it
(e.g. "Git includes: ").
Change-Id: Ife5e58055c4eb24218b543f52fb7d7882dc1e04e
Reviewed-on: https://code.wireshark.org/review/21359
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f045d177f407b5a91d499c59350e16…
commit f045d177f407b5a91d499c59350e168fb30c3505
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 26 20:03:05 2017 +0200
CMake: prevent confusing "Git NOT FOUND" in CMake 3.1.3
Change-Id: Ia7c03220f49ff862bf05a34727bf5c99297deeab
Reviewed-on: https://code.wireshark.org/review/21358
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f7fdc06fa0b59b9860cb9b29477826…
commit f7fdc06fa0b59b9860cb9b294778262cb6a205e3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 17:15:56 2017 +0200
lcsap fix conflicting entry in its value_string
Field 'Positioning Method' (lcsap.pos_method) has a conflicting entry in its
value_string: 15 is at indices 15 (Reserved for other location technologies) and 31
(Reserved for network specific positioning methods))
Change-Id: If0db3d7466924da82e1307717b79dd3e4c2bdf6e
Reviewed-on: https://code.wireshark.org/review/21382
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3e038cba156329feebbe6732340c2b…
commit 3e038cba156329feebbe6732340c2b1cea0b487a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 09:59:06 2017 +0200
DSR: fix conflicting entry in its value_string
Field 'Type' (dsr.option.err.type) has a conflicting entry in its
value_string: 129 is at indices 3 (Unknown flow) and 4 (Default flow unknown))
Change-Id: I06e31b9dd5f4887d2590a8dc0efa6d6706a5aff7
Reviewed-on: https://code.wireshark.org/review/21377
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bba1e3828895b41bdd77659e99c131…
commit bba1e3828895b41bdd77659e99c13141c51d56a6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 15:23:25 2017 +0200
t35: fix conflicting entry in its value_string
Field 'H.225 Manufacturer' (h225.Manufacturer) has a conflicting entry in its
value_string: 67108994 is at indices 3 (Siemens AG) and 13 (SITK Institut fuer
Telekommunikation GmbH & Co KG))
Field 'H.245 Manufacturer' (h245.Manufacturer) has a conflicting entry in its
value_string: 67108994 is at indices 3 (Siemens AG) and 13 (SITK Institut fuer
Telekommunikation GmbH & Co KG))
Change-Id: I6b08ffce5e8335be0f31dda0a9530afef2950f09
Reviewed-on: https://code.wireshark.org/review/21379
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ca8a340eba3b2de534094a210f3538…
commit ca8a340eba3b2de534094a210f35384bca68467f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 16:14:48 2017 +0200
ieee802.11: fix conflicting entry in its value_string
WARNING **: Field 'Rx STBC' (wlan.vht.capabilities.rxstbc) has a conflicting
entry in its value_string: 2 is at indices 2 (1 to 2 Spatial Stream Supported) and 5
(160MHz and 80+80 Supported))
Change-Id: I7b94a88d8b12b3c0e485d0cade0e9918668a7342
Reviewed-on: https://code.wireshark.org/review/21380
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6431695049116176361ce4691dfd3…
commit f6431695049116176361ce4691dfd3c77ab19858
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 27 09:15:01 2017 -0400
[OpenSafety] Bugfix invalid length calculation.
Length calculation leads to -1, which will result in a large malloc
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1212
Bug: 13649
Change-Id: Iccb78b8c8ec9ca8e8f97bc12d0d8f41526d1f791
Reviewed-on: https://code.wireshark.org/review/21367
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a1152a2a1f486e07e861afcc56ab0f…
commit a1152a2a1f486e07e861afcc56ab0f16bb9c7a83
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 27 09:50:34 2017 -0400
packet-sigcomp.c: Prevent large shift
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1232
Bug: 13641
Change-Id: I6e53d07dd03a5b637ca27884fad32ba5f7a85d0e
Reviewed-on: https://code.wireshark.org/review/21369
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=92903583f8373af782efe7ae64352e…
commit 92903583f8373af782efe7ae64352ec1e426e35a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 27 09:58:14 2017 -0400
packet-netsync.c: Prevent large shift
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1221
Bug: 13639
Change-Id: I0b67a270460473917f2481f79f404e4599727508
Reviewed-on: https://code.wireshark.org/review/21370
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b23536ff18a6c4a9eeb12b4a135916…
commit b23536ff18a6c4a9eeb12b4a135916de6d455b9f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Apr 27 14:58:58 2017 +0200
[Diameter] Update experimental result codes according to 3GPP TS 29.230
V14.4.0 (2017-03).
Change-Id: Ia9624ca6668dea8f673a70eb87482cd05238e920
Reviewed-on: https://code.wireshark.org/review/21365
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8d72865eb9dba3acb27d1f115d3816…
commit 8d72865eb9dba3acb27d1f115d3816971e8c2bf4
Author: Pavel Strnad <pavel_strnad(a)hotmail.com>
Date: Thu Apr 27 13:40:26 2017 +0200
S1AP: fix dissection of MS Classmark 2 and MS Classmark 3 IEs
Bug: 13666
Change-Id: If65ba54db3541575fb71d1cd88a2fd3c47ef95c3
Reviewed-on: https://code.wireshark.org/review/21364
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=64712974ed86b4b4a413bf4006fb4c…
commit 64712974ed86b4b4a413bf4006fb4cfe4447127c
Author: Adrian Simionov <daniel.simionov(a)gmail.com>
Date: Thu Apr 27 20:49:29 2017 +1000
[docsis->Annex C] Fix TLV 45 decoding
Change-Id: I23830283c1a3323cfb3b72da1e329c72817119ab
Reviewed-on: https://code.wireshark.org/review/21362
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=265ed3e1ac8ab3fe889b53b1bf989b…
commit 265ed3e1ac8ab3fe889b53b1bf989b4b382243c1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Apr 27 13:03:42 2017 +0200
[Diameter] Add a table for subdissectiong AVPs for VENDOR_VERIZON
Change-Id: I37397e590f294d209b89fe868b365cafb5343464
Reviewed-on: https://code.wireshark.org/review/21363
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9f8c2296d04a8cc189bbc5369772d0…
commit 9f8c2296d04a8cc189bbc5369772d0f4a66e458d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 26 18:58:43 2017 -0700
Add/expand comments, add/shuffle #defines.
Attempt to make the various metadata headers, and the code that
constructs them, a bit clearer.
(Also, it's VeriWave; be consistent.)
Change-Id: I0bb7d70f547d492c4947ceb313888991f2d374f2
Reviewed-on: https://code.wireshark.org/review/21360
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=54d92cd43658fb2c5e528ac629f743…
commit 54d92cd43658fb2c5e528ac629f743228ba21642
Author: Rémy Léone <remy.leone(a)gmail.com>
Date: Tue Apr 11 10:37:13 2017 +0200
Refactor header ie dissection
- Change title of IE subtree
- extract dissect_802154_enhanced_beacon_filter
- Adding reference to the IEEE 802.15.4 standard
- fix Typo
- Explicit case of header termination
Change-Id: Ia18d8d0345e2bac5ef16057e7c3cf08e4341060a
Reviewed-on: https://code.wireshark.org/review/21187
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2c921eb83c2e4a959080461777fab3…
commit 2c921eb83c2e4a959080461777fab3397c5abac0
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 25 23:29:58 2017 -0400
Add proto_tree_add_item_ret_uint64
Just like proto_tree_add_item_ret_uint, but with 64-bit support
Change-Id: Ie0cbfda9e63bf21e85df2d674e391a6c0abe92f7
Reviewed-on: https://code.wireshark.org/review/21355
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=24c93965593b535b135e1befff5cd0…
commit 24c93965593b535b135e1befff5cd0c32be6f28d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Apr 26 16:49:31 2017 +0200
m2ua: Export the m2ua dissector for lua scripts or similar
Make Dissector.get("m2ua"):call() work from within lua. So far
only m3ua, m2pa were exported to other dissectors.
Change-Id: I3350c3f4b2614fa07254306464c5fdffbadd4f3b
Reviewed-on: https://code.wireshark.org/review/21351
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=50a1f903987ef3f577a2e744c225d8…
commit 50a1f903987ef3f577a2e744c225d88a556dd526
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 26 15:44:29 2017 +0200
FindPOD.cmake: look for pod2html.bat
Strawberryperl 5.24.1.1 installs "pod2man", "pod2man.bat" and
"pod2html.bat", but not "pod2html" so find_program cannot locate
it.
Change-Id: Id52ee7e77bbbfc8c2fcc6ab66c498d4818f54bf8
Reviewed-on: https://code.wireshark.org/review/21350
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=35f620c533d688413e4b807fd001bd…
commit 35f620c533d688413e4b807fd001bdc914cf7784
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Apr 24 18:14:29 2017 +0200
cmake: make Cygwin optional
Cygwin is not needed if the documentation is not built (i.e. asciidoc,
docbook, xsltproc are not needed). Via Chocolatey the following packages
can be installed: git, winflexbison, strawberryperl.
Change-Id: Ib13d144321cf6d2ed5c3346a2ae271de983deada
Reviewed-on: https://code.wireshark.org/review/21316
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=46b105d51334efe1af4fbe6f6c0207…
commit 46b105d51334efe1af4fbe6f6c02073980120721
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Apr 24 19:17:25 2017 +0200
Remove runlex.sh script, just run lex directly
This removes the need for sh (and Cygwin) on Windows to build Wireshark.
runlex.sh (added in commits 5be4499a and 517d6d57) was added because
older flex had quirks with its options (and the --header(-file) option
was not available). The minimum required flex version for reentrant
scanners (2.5.6) does not have these issues though, so remove the step.
Change-Id: I73c82bb329e2130481efca94809dc60b86dcbafe
Reviewed-on: https://code.wireshark.org/review/21315
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=a8d97771610ec5f0e81f434f21002c…
commit a8d97771610ec5f0e81f434f21002c31e83aeb5b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Apr 24 17:48:16 2017 +0200
cmake: remove dependency on sed
runlex.sh does not need sed anymore since v2.3.0rc0-2386-g64f83641ad.
Since building docs already depends on Perl, let's use Perl instead.
Change-Id: Id7e923e47001cfd32c8cef89960377026464f2ee
Reviewed-on: https://code.wireshark.org/review/21314
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=821a3466c68ed509d8f71e34a62a22…
commit 821a3466c68ed509d8f71e34a62a2227823b1e55
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Apr 25 22:01:21 2017 +0200
ISUP: restore number indicators2 display like what was done in master-1.12
proto_tree_add_bitmask_list() should avoided as there is an interpreted field.
Bug: 13588
Change-Id: Iec6bf9bb4002123b6913fbee6287472aaf9bc00b
Reviewed-on: https://code.wireshark.org/review/21340
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b9adb80cae7d49351a84fabbcbdf5a…
commit b9adb80cae7d49351a84fabbcbdf5a54ec173a98
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Tue Apr 25 17:31:39 2017 +0200
ua3g: fixed "GET_PARAM_RESPONSE" message decoding (firmware version) and
display
Change-Id: Ifb834d4895fda129878657468d21e3afc65cc5d3
Reviewed-on: https://code.wireshark.org/review/21339
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b8614451a22570bec8d6a02c2e4bbb…
commit b8614451a22570bec8d6a02c2e4bbbe3989a6338
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Tue Apr 25 23:35:27 2017 +0200
ua3g: minor change in "UNSOLICITED" message decoding
Display "Not Applicable" instead of "Unknown" when the
"Additional VTA Type" is not set (0),
which is the case with 2G and 3G terminals.
Change-Id: I178248e1de18176710fe978ebf90e99486e0ec7e
Reviewed-on: https://code.wireshark.org/review/21346
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8012dcc712e4dbbedb360a8e9ae1cc…
commit 8012dcc712e4dbbedb360a8e9ae1ccd844e1d24e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Apr 26 08:28:48 2017 +0200
Qt: Remove semicolon behind Q_UNUSED macro
Change-Id: Ief5f7bca5d110df8958307b58fc11bf740787dfd
Reviewed-on: https://code.wireshark.org/review/21349
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=81bad32f2ce6cfe05863b89a81752d…
commit 81bad32f2ce6cfe05863b89a81752d449bd2d635
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Apr 26 08:27:10 2017 +0200
Qt: Remove semicolon behind Q_UNUSED macro, part 2
Change-Id: Id27a93c9a76b554bb2e98199d08d3d9604550889
Reviewed-on: https://code.wireshark.org/review/21348
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=30d98d1ea9cdec7cfa04f960337e9c…
commit 30d98d1ea9cdec7cfa04f960337e9c0dbaf4c574
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 25 22:51:53 2017 +0200
Qt: Remove semicolon behind Q_UNUSED macro
Change-Id: I75ff975216da23447b94bc513671ac269c52b7dc
Reviewed-on: https://code.wireshark.org/review/21342
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=3b5cfa9a771b0a523855b72fe47e7b…
commit 3b5cfa9a771b0a523855b72fe47e7bdf116550ca
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 25 22:48:23 2017 +0200
Qt: Don't use _U_ for unused parameters in C++
Change-Id: If7acab5f438bb20b053fdcfef86b2f06765b5321
Reviewed-on: https://code.wireshark.org/review/21341
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f493bad8a23591a999c16539e35415…
commit f493bad8a23591a999c16539e35415382591f0c3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 25 21:47:29 2017 -0700
Fix no-extcap build.
Change-Id: I9f01264bf5f0c28a4d871f6d983e9efed1c23259
Reviewed-on: https://code.wireshark.org/review/21347
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0557fe144624769797d82b98cc3965…
commit 0557fe144624769797d82b98cc3965b8f83fc724
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Apr 25 22:43:32 2017 +0200
Qt: fix compilation without pcap.
Change-Id: Ia0fe79157f21fd0b1c0e5195c902ae07c55ca253
Reviewed-on: https://code.wireshark.org/review/21343
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5b1a802c3ee3cffb2b0754e6ed17c2…
commit 5b1a802c3ee3cffb2b0754e6ed17c2a470278335
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Apr 20 15:20:33 2017 +0200
tools: improve debian-setup.
Change-Id: If547e0e1c821d3696eba0f303e8ab0769b1fabb4
Reviewed-on: https://code.wireshark.org/review/21245
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=451731f0c6d3991008df9f173782fc…
commit 451731f0c6d3991008df9f173782fc26f28629ba
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Apr 24 23:20:39 2017 +0200
cmake: fix build without libxml2
When LibXml2 is not found, the LIBXML2_LIBRARIES is set to
"LIBXML2_LIBRARIES-NOTFOUND" rather than an empty string (as other
FindXxx modules do). This results in an error because the variable is
used in target_link_libraries (via epan_LIBS).
As workaround, explicitly clear the variable to ignore the cache entry.
Change-Id: I9e164f9c175b23559ac6bc37f9aca5f41df79d1f
Reviewed-on: https://code.wireshark.org/review/21321
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bfd1461ec81311f31e9fc0f3f298ae…
commit bfd1461ec81311f31e9fc0f3f298ae779911c7f4
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 25 12:13:01 2017 +0200
ieee80211: fix stack-use-after-return
Bug: 13662
Change-Id: I26c53ecc78005b26908d74877814be22924848bc
Fixes: v1.11.3-rc1-2029-g4b8b83407a ("Support for IEEE 802.11ad")
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1268
Reviewed-on: https://code.wireshark.org/review/21333
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=907d05da84f97b893887416d453a54…
commit 907d05da84f97b893887416d453a540a793c9ec5
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 25 11:36:18 2017 +0200
print: Avoid shadowing a global variable
Change-Id: I9c04bc1d6fc5511d404987dd94eee342e0d75442
Reviewed-on: https://code.wireshark.org/review/21332
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=0d3da40fcd4ccd4618e7ae06b9ba1e…
commit 0d3da40fcd4ccd4618e7ae06b9ba1e8eefbc88e6
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Tue Apr 25 13:49:43 2017 +0300
UMTS FP: Cosmetic fixes
Some fixes to comments and spaces
Change-Id: I0b1abf9619f2aab2b30120f4086d99332171b69d
Reviewed-on: https://code.wireshark.org/review/21334
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cd58e676bd7b8866cbc4c2b88af9af…
commit cd58e676bd7b8866cbc4c2b88af9af357d7d9fa3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 25 10:10:38 2017 +0200
etypes: Add ETHERTYPE_REALTEK
The definition was found in RTL8324 / RTL8326 datasheet.
Change-Id: Idaec6bb13ee1e321d6fe24c2a567bd9cd2a9d27d
Reviewed-on: https://code.wireshark.org/review/21331
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f9f2b84e658b8ce64553f9b9df3a37…
commit f9f2b84e658b8ce64553f9b9df3a37acaa2ec916
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 25 08:18:05 2017 +0200
Qt: Make text in SimpleDialog selectable by mouse
This makes it easier to copy error messages.
Change-Id: I39284d9b2d716336c6fc4b211e5346abcebf0aee
Reviewed-on: https://code.wireshark.org/review/21326
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=4ac4ab31a32fd58e7180ba086baaab…
commit 4ac4ab31a32fd58e7180ba086baaabc48bd5f4a9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 25 00:45:09 2017 -0700
Don't crash if we have no BOOTP option preferences.
wmem_list_foreach() crashes if handed a null pointer, and saved_uat_opts
will be null if there are no BOOTP option preferences. Don't do the
"free saved UAT options" stuff if there aren't any saved UAT options.
Bug: 13655
Change-Id: I88e64c6ebec88fc04a5adc0a85d378bbba49b383
Reviewed-on: https://code.wireshark.org/review/21329
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=77751c94f17e2c110ae9e88b1780e2…
commit 77751c94f17e2c110ae9e88b1780e279d610b96b
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Apr 15 23:30:30 2017 +0200
Qt: Add interface toolbar support
An extcap utility can provide configuration for controls to use in a
GUI interface toolbar. This controls are bidirectional and can be
used to control the extcap utility while capturing.
This is useful in scenarios where configuration can be done based on
findings in the capture process, setting temporary values or give other
inputs without restarting current capture.
Todo:
- Add support for Windows
Change-Id: Ie15fa67f92eb27d8b73df6bb36f66b9a7d81932d
Reviewed-on: https://code.wireshark.org/review/19982
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=cd55bd29258b8e0ffae9ea9471059b…
commit cd55bd29258b8e0ffae9ea9471059b457ebb59ae
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Sun Apr 23 22:02:09 2017 +0300
UMTS FP: Improved MAC multiplexing detection
Previous detection was based on DCH ID 31 or 24 and specific TB Size.
New method checks if the 'Transport Format' looks like the commonly used
format for DCCH over DCH or DCH ID 24 and specific TB size (To not break that special case
which I'm not familiar with personally)
Change-Id: I59fe7772ec05f7cc15351ef78276085e25570461
Reviewed-on: https://code.wireshark.org/review/21304
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d3b2e44e91c3239ee7ddf9da4fd18e…
commit d3b2e44e91c3239ee7ddf9da4fd18e155cac62fe
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Sun Apr 23 23:59:41 2017 +0200
ua3g: fixed/updated "unsolicited" and "version information"
messages
Change-Id: If006c36a21556a8fb690401677e9ca62a594d82b
Reviewed-on: https://code.wireshark.org/review/21307
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dcaad43e1f65e8b99cbfed8b1b410e…
commit dcaad43e1f65e8b99cbfed8b1b410e01eb1cad80
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 24 22:52:52 2017 +0200
GSM SMS: add more lower layer info for reassembly and switch preference to on by
default
Change-Id: I3faf15c326d14e246975094ad31431eba2404d8c
Ping-Bug: 13592
Reviewed-on: https://code.wireshark.org/review/21320
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cb089dd2ff20cd7cc165de303de075…
commit cb089dd2ff20cd7cc165de303de075bcb6be3afc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 24 21:16:37 2017 +0200
GSM SMS: fix display of reassembled 8 bits SMS
Change-Id: I0052fb1f311f18180fbc7c6b8bd2fbf23215ad67
Reviewed-on: https://code.wireshark.org/review/21319
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13fbdfc1ba9e38a45336f2d06e3508…
commit 13fbdfc1ba9e38a45336f2d06e35083ba7da3d16
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Apr 24 22:20:44 2017 +0200
fuzzshark: try to fix oss-build, remove oss-fuzzshark.c in old location.
Step #3: /src/wireshark/tools/oss-fuzzshark.c:190:2: warning: implicit declaration of
function 'wtap_init' is invalid in C99 [-Wimplicit-function-declaration]
(https://oss-fuzz-build-logs.storage.googleapis.com/log-472514ce-1a41-4f14-8…)
Change-Id: I47715bdf55c20124a80da51d3c8812db1d8d94cf
Reviewed-on: https://code.wireshark.org/review/21317
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=6cbea5c01c636b1e4b2737e325adde…
commit 6cbea5c01c636b1e4b2737e325addeb5ca32a11c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Apr 22 00:09:35 2017 -0400
Convert BOOTP options into a dissector table.
This allows for much easier addition or overriding of options and use of Decode As.
This includes adding heuristic dissector tables for vendor specific options.
Change-Id: If52c00bbc23d89386ba3e777600f665609856de0
Reviewed-on: https://code.wireshark.org/review/21297
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4b2ee367434572f288f1272cc4c172…
commit 4b2ee367434572f288f1272cc4c1722a0c484798
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 23 23:17:15 2017 +0200
GSM SMS: optionally use GSM-MAP info to perform reassembly (off by default)
Change-Id: I62c7a04e62167bd2d68d861f1d8d854f3159b159
Ping-Bug: 13592
Reviewed-on: https://code.wireshark.org/review/21306
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9785aed5b6fe3b2e67b20d8b044fda…
commit 9785aed5b6fe3b2e67b20d8b044fda6c4626e908
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Apr 23 20:28:05 2017 +0200
oss-fuzzshark: Copy to separate directory, add build script.
(oss-fuzz part https://github.com/google/oss-fuzz/pull/544)
Change-Id: I54cf7a7b1aaa49582b5fff8bd034187aa6a9bdec
Reviewed-on: https://code.wireshark.org/review/21302
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=20d1db6439431d5be4e8f21d05d26b…
commit 20d1db6439431d5be4e8f21d05d26b206bb588c3
Author: Adrian Simionov <daniel.simionov(a)gmail.com>
Date: Mon Apr 24 23:13:13 2017 +1000
[docsis->bpkm-attr] Updated Attribute 16 Error Codes
Change-Id: If9156b4a73e7db006daf4ab4e278379f0e39905f
Reviewed-on: https://code.wireshark.org/review/21313
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4dde22c416176d99f2db32f0b5dac5…
commit 4dde22c416176d99f2db32f0b5dac568a522df9d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Apr 24 14:37:47 2017 +0200
[MIP6] Fix length calculation, APN name and PCO.
Change-Id: I2a26ef0bbde07071f72c19d9465adf02cb177816
Reviewed-on: https://code.wireshark.org/review/21311
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9ccba0e605fc1529a710b269425d19…
commit 9ccba0e605fc1529a710b269425d1916413b4972
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 18 08:10:53 2017 +0000
Revert "Make the set of static routines match that in the current tip
SQLite."
This reverts commit 96c72df2dfe9c84bc2716352ebe1876ddd8ceaf4.
Generated a lot of warning (-Wmissing-prototypes)
and i try to kept a sync branch on https://github.com/alagoutte/sqlite/tree/wireshark
Change-Id: I42252a6e736f96783a9fa9805b84e525fe11726e
Reviewed-on: https://code.wireshark.org/review/21182
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=860abb09e7e6ec5aec6a438d5e1d76…
commit 860abb09e7e6ec5aec6a438d5e1d7657cacc66cd
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Mon Apr 24 07:57:32 2017 +0200
TFSHARK: Fix clobbing warning for variable success
Without setting the success variable as volatile my build fails
with warning "error: variable success might be clobbered by 'longjmp' or
'vfork'"
Change-Id: Ic7d4a9b8be4bf9211127dcf5a6bb4bef8bbcd7a9
Reviewed-on: https://code.wireshark.org/review/21310
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e52c95c6c8cdac34eccdba9b49d68a…
commit e52c95c6c8cdac34eccdba9b49d68a6982685f1a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 23 16:48:17 2017 -0700
Move UI-only stuff out of libwireshark.
Packet ranges are used only in the UI; move the packet range stuff into
libui.
Don't pass a print_args_t structure to libwireshark packet-printing
routines, just pass the few parameters they need. Move the declaration
of print_args_t into file.h.
Change-Id: Icff5991eea7d7d56f33b4716105895263d275bcf
Reviewed-on: https://code.wireshark.org/review/21308
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=751e078d2bc6adf1179de164291eb7…
commit 751e078d2bc6adf1179de164291eb743abd8732b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 23 13:18:02 2017 -0700
Print first-pass read errors at the end.
That way, they don't, for example, get lost as a result of being
scrolled off the screen by output from the second pass.
Also, do the post-processing of output regardless of whether we got read
errors or not, and fix a code error hidden by a call to tshark_debug().
Change-Id: I389c7c794f4dd5fda6e4c50ce480802c92701866
Reviewed-on: https://code.wireshark.org/review/21305
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e2f76f991c7c266a4f5d83d3fee584…
commit e2f76f991c7c266a4f5d83d3fee5841dcf5808da
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Apr 23 21:00:31 2017 +0200
tshark: make success volatile.
/home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/tshark.c:
In function ‘main’:
/home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/tshark.c:653:12:
error: variable ‘success’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
Change-Id: I793962c71b0ebfafc7c09b1d865cfa774456bb3a
Reviewed-on: https://code.wireshark.org/review/21303
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5ac71132e24beff2ff2ca1be8420f1…
commit 5ac71132e24beff2ff2ca1be8420f1d04fa61c48
Author: sswsdev <sswsdev(a)gmail.com>
Date: Sun Apr 23 19:20:26 2017 +0300
UMTS FP: Fix bug in heuristic dissectors
The code was not allowing UDP port types, should ONLY allowed UDP ports.
Change-Id: Ida5467313cbc24fcbac7cd432fb4a018cc00bdef
Reviewed-on: https://code.wireshark.org/review/21301
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=69762f5d1c8f420e7819a9564b8bb1…
commit 69762f5d1c8f420e7819a9564b8bb1d0b490b6d3
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Apr 23 08:17:34 2017 -0700
[Automatic update for 2017-04-23]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: If8e6efa61c4c2808c51c585b0c61fd76a321c3fd
Reviewed-on: https://code.wireshark.org/review/21298
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=dc9127ddff6081ab3a7e7480621405…
commit dc9127ddff6081ab3a7e7480621405119ad38d95
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 23 01:29:23 2017 -0700
Rename read{_cap}_file() to process{_cap+_file().
They might read the file once or twice, but the key is that they (and
what they call) are doing the work of processing the file's contents.
Change-Id: I2df6257c55ff5ace944f1a1db5e2aec456ed2038
Reviewed-on: https://code.wireshark.org/review/21293
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e9f5e045f743fd3220f1c8d9ba6821…
commit e9f5e045f743fd3220f1c8d9ba68214f1feb7359
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 23 01:18:02 2017 -0700
Just have read_cap_file()/read_file() return a success/failure indication.
No need to report the precise error code - it's already reported the
error.
Change-Id: Ib52daf094253deac2a10d16793ebf0f42581afd6
Reviewed-on: https://code.wireshark.org/review/21292
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=045d1dc9f1379693d11de7bdc14cf5…
commit 045d1dc9f1379693d11de7bdc14cf54f31477ce7
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun Apr 16 21:38:01 2017 +0200
HTTP: Add status code description
This commit adds the IANA status code description to the tree.
Furthermore it updates the registered status codes
s. https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
Change-Id: I6ec57569b784a137b57532a092c8781dec545039
Reviewed-on: https://code.wireshark.org/review/21162
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7eab596c0824e6fa20aad6932bcd2f…
commit 7eab596c0824e6fa20aad6932bcd2fdb94b86edf
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Apr 22 18:46:23 2017 +0200
slsk: fix infinite loop
If check_slsk_format reports that the buffer does not contain the
expected data, do not try to find more items (break out of the loop).
In one case, an infinite loop would occur because the index variable was
not incremented when the check fails. In all other cases, it would
perform up to 2^32 calls to check_slsk_format per loop (with the same
offset parameter, so no exception is triggered).
Change-Id: I4b7fa10a36fee2551fa46831bcecd6bcd9f342d1
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1200
Bug: 13631
Reviewed-on: https://code.wireshark.org/review/21284
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a4eb68be97346edaaeca22381cfe37…
commit a4eb68be97346edaaeca22381cfe3787ed9b78b8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 22 22:22:00 2017 -0700
Rename some routines to better reflect what they do.
In TShark, rename load_cap_file() to read_cap_file(); this is TShark,
not Wireshark, so you're not "loading" a file to be manipulated through
the GUI.
In TFShark, rename it to "read_file()"; not only are we not loading it,
it's not even necessarily a capture file.
Change-Id: I122b46ecd8cb7de9c1e1c249ba6c08fdeb93f7e2
Reviewed-on: https://code.wireshark.org/review/21291
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5e74b318fd9bfe14ca1bb2269a72dd…
commit 5e74b318fd9bfe14ca1bb2269a72dd29c5e28de9
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Apr 23 00:15:12 2017 +0100
Snort: restore timestamp before showing alert
Change-Id: I4772c9c46b7a79a7139229bcb43ee6c84109a26b
Reviewed-on: https://code.wireshark.org/review/21289
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6fdf8eb5a92d51617203be1a712c15…
commit 6fdf8eb5a92d51617203be1a712c15585b156497
Author: Björn Ruytenberg <bjorn(a)bjornweb.nl>
Date: Sat Apr 22 23:33:57 2017 +0200
DOF: Fix buffer overflow (read)
Perform sanity check on buffer length parsed from data. Check buffer
size before reading value.
Change-Id: I8beaf8860b39426d79867b0dd2221e57e32da8e0
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1151
Bug: 13608
Reviewed-on: https://code.wireshark.org/review/21287
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f42b2a531e0c9cafe7d694cb1109dd…
commit f42b2a531e0c9cafe7d694cb1109dd53c33fdd40
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 18 14:47:43 2017 +0000
aruba (PAPI): fix conflicting entry in its value_string
Field 'Destination Port' (papi.hdr.dest.port) has a conflicting entry in its
value_string: 8999 is at indices 143 (LAST_SERVICE) and 144 (MESSAGE_HANDLER))
Field 'Source Port' (papi.hdr.src.port) has a conflicting entry in its
value_string: 8999 is at indices 143 (LAST_SERVICE) and 144 (MESSAGE_HANDLER))
Check from Services.pm and same value for both...
Change-Id: I8ff56bfbee525e894235a9aea62e0f1d2a9b0ebc
Reviewed-on: https://code.wireshark.org/review/21191
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=003598eb80455ed5000512afcf79c7…
commit 003598eb80455ed5000512afcf79c70aa83a32c8
Author: sswsdev <sswsdev(a)gmail.com>
Date: Sat Apr 22 15:36:10 2017 +0300
UMTS Iub: Fixed some comments and replaced tabs with spaces
Changes done to the FP, MAC and RLC dissectors
Change-Id: I7ccf229a7a1d9a8c04d8ac04e74f03253eb3bff0
Reviewed-on: https://code.wireshark.org/review/21281
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e763fca0160d8a97311a421823ea65…
commit e763fca0160d8a97311a421823ea656f46f0af3c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 22 15:39:24 2017 -0700
Update a comment.
Change-Id: Ice2727d691719a10c7163b9496107ec95fbd2e3b
Reviewed-on: https://code.wireshark.org/review/21288
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=22f05d620f428c0769227f0173876c…
commit 22f05d620f428c0769227f0173876c95fb9aead4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 19 21:43:49 2017 -0400
packet-quakeworld.c: Fix potential out of bounds error.
Overflow can occur while writing to a buffer.
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1179
Bug: 13624
Change-Id: I7511c43ed67f81d246e3eb66e092353e2ab4924c
Reviewed-on: https://code.wireshark.org/review/21235
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=26d5b3dab9ee0dc3610d56148b52f3…
commit 26d5b3dab9ee0dc3610d56148b52f35f5cc1c496
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Sat Apr 22 15:08:10 2017 +0200
ua3g: fixed/updated init message (vta type values)
Change-Id: I8c500d6e049e9243c2c4b283731674bf3fc0a521
Reviewed-on: https://code.wireshark.org/review/21282
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c70d2ec8069b113aa575817535b19b…
commit c70d2ec8069b113aa575817535b19be52e6e635b
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sat Apr 22 13:17:37 2017 +0200
ROS: Harden ROS dissection
Make sure that on a OID search an actual OID is available to search for.
Bug: 13637
Change-Id: I36f84cce5506f003d2a30a17f8671d5e22070612
Reviewed-on: https://code.wireshark.org/review/21280
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=951ac6c230c0397767ac4bfc1b5aa6…
commit 951ac6c230c0397767ac4bfc1b5aa668330dd68d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 21 12:25:57 2017 -0700
Put all the capture dissector structures into epan/capture_dissectors.h.
Don't scatter them amongst various other headers.
Change-Id: I243954222cd4ad3e6bbe8b4d1dd25ee4952f87d6
Reviewed-on: https://code.wireshark.org/review/21277
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4bf38d7c21c5091cf803f79873a41e…
commit 4bf38d7c21c5091cf803f79873a41e20facb4e22
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Apr 21 13:58:53 2017 +0200
capwap: fix conflicting entry in its value_string
Field 'Cisco Element ID' (capwap.control.cisco.element_id) has a conflicting
entry in its value_string: 125 is at indices 31 (SPAM AP Led State) and 34 (AP Led State
Config))
Rename also some variable name...
Change-Id: I4e3c1fa925492a570dad47a3d274d1f3e950c483
Reviewed-on: https://code.wireshark.org/review/21271
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5d1a2a57a0833030507ec9741137fc…
commit 5d1a2a57a0833030507ec9741137fcc05a8ce1a6
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Fri Apr 21 13:56:49 2017 +0200
UCP: Update Xser types
Updated Xser types according to
http://documents.swisscom.com/product/1000174-Internet/Documents/Landingpag…
Bug: 13636
Change-Id: I4591c37534da0ccf1ee4352eaff00156eefff519
Reviewed-on: https://code.wireshark.org/review/21270
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=103c8b728a3c722be82786a69646a3…
commit 103c8b728a3c722be82786a69646a36dc2c5e223
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Apr 21 15:46:15 2017 +0200
LTE RRC: insert an optional separator before adding message name to info column
Bug: 13634
Change-Id: I9585d915b9bc9c895eabeed3d3d5453e94c31789
Reviewed-on: https://code.wireshark.org/review/21274
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0f41da9da36218b390f890ab9aaf54…
commit 0f41da9da36218b390f890ab9aaf5459325f19c3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Apr 21 14:05:01 2017 +0200
cast: fix conflicting entry in its value_string
Field 'AudioCodec' (cast.audio) has a conflicting entry in its value_string:
1 is at indices 0 (G711) and 1 (G729))
Change-Id: I094a85a84ca1e79d4cf817bd5222e902a34f3741
Reviewed-on: https://code.wireshark.org/review/21272
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2c52d954d5713be1b809c3b668b035…
commit 2c52d954d5713be1b809c3b668b0353d2b355c16
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 21 03:10:21 2017 -0700
Code in epan/dissectors may require GeoIP.h, so include LIBGEOIP_FLAGS.
Change-Id: I31bd53c49906db24b64fa3f1e3078b0658db3158
Reviewed-on: https://code.wireshark.org/review/21269
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67a5d9bebebe1bbe668d8da11601c1…
commit 67a5d9bebebe1bbe668d8da11601c1833bc7bf4d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 19:08:00 2017 -0700
Use the cfile_ failure_message routines in androiddump.
Change-Id: Ic310eaafac054db7736c503252062c3dd3e00a99
Reviewed-on: https://code.wireshark.org/review/21265
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9e4c018e08d5a657f85f0cde0607db…
commit 9e4c018e08d5a657f85f0cde0607db0a6d25ddf4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 21:25:46 2017 -0700
Code in epan/crypt may require gcrypt, so include LIBGCRYPT_FLAGS.
Change-Id: I7f6745eb39bae6ae37a63178bcd60c75fd9e9de2
Reviewed-on: https://code.wireshark.org/review/21268
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=41a917f43330ee9ad868237d7e80fc…
commit 41a917f43330ee9ad868237d7e80fc823790140a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 20:29:16 2017 -0700
Update URL.
Change-Id: Ice4235b6b2cda947ee5059380ad5a49556bb3e6a
Reviewed-on: https://code.wireshark.org/review/21267
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5c5a17b1f40f72cfae0acbdf2ecf7d…
commit 5c5a17b1f40f72cfae0acbdf2ecf7d271645a6df
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 18 15:09:32 2017 +0000
nstrace (mep/rpc): fix conflicting entry in its value_string
Field 'Status Code' (nstrace.mep.errcode) has a conflicting entry in its
value_string: 341 is at indices 7 (LARGE DATA) and 8 (SMALL DATA))
Field 'Status Code' (nstrace.rpc.errcode) has a conflicting entry in its
value_string: 341 is at indices 7 (LARGE DATA) and 8 (SMALL DATA))
Change-Id: I75aba4140cbbcd412087e951bd35543f14ec1281
Reviewed-on: https://code.wireshark.org/review/21193
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=21178a092f83d37cc97e0f419e37e7…
commit 21178a092f83d37cc97e0f419e37e7260b803a6e
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Wed Apr 19 08:57:33 2017 +0200
EAPOL-MKA: Add parameter set info to info column
Show which parameter sets are present in the info column, and some more
relevant info. Prepare all parameter set handler function interfaces to
be able to add relevant info.
Change-Id: Idd206eebc4d7196511e118fbf9e30919fb38328e
Reviewed-on: https://code.wireshark.org/review/21218
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a967ca50746fff4035f166585a9172…
commit a967ca50746fff4035f166585a9172b082431ec5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 20 23:15:38 2017 +0200
Fixes for sfloat_ieee_11073_val_to_repr() function
- when having a special value, leave function once buffer is written
- give the right buffer length to g_snprintf() function
Bug: 13590
Change-Id: Iecf1456686b6e92a7cfcf8ed6d8619541ad50ace
Reviewed-on: https://code.wireshark.org/review/21260
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=70b6e406e783eab172b4b9e90e9e7e…
commit 70b6e406e783eab172b4b9e90e9e7e624d7facb8
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 20 08:44:52 2017 -0400
dwarf.c: Fix potential too large shift
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1167
Bug: 13616
Change-Id: I43ab629ad8368bf672d1c079219d6b055c431e86
Reviewed-on: https://code.wireshark.org/review/21249
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=648b6eb936eb8a1e129aae3b5d2b95…
commit 648b6eb936eb8a1e129aae3b5d2b956d766008c4
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 20 23:45:19 2017 +0200
mergecap: remove a now useless variable
Change-Id: I9acbbc03cbc2719abbe5b3ade62fc1c4e92cb8ff
Reviewed-on: https://code.wireshark.org/review/21262
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3dd274cddcc585b5c5494647769895…
commit 3dd274cddcc585b5c549464776989548f6d14883
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 14:25:59 2017 -0700
Use more of the cfile_ failure message routines.
Change-Id: Iceb15f15622d391da0332e6ed55aac0e74abd0e2
Reviewed-on: https://code.wireshark.org/review/21261
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=804d3f62454895c1560a690728b859…
commit 804d3f62454895c1560a690728b859f68ee35bf6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 14:07:06 2017 -0700
Use cfile_write_failure_message() in the randpkt code.
Change-Id: I32ef7ff85f854782e5dd02c3e7f12436a120bc13
Reviewed-on: https://code.wireshark.org/review/21259
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=64ec2b2e5ed590a6f1a3d22c8b24a6…
commit 64ec2b2e5ed590a6f1a3d22c8b24a6e70420d1f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 13:25:21 2017 -0700
Take the error message generation out of the merge_files routines.
Have them just return the information needed for the caller to produce
an error message, and have the callers use the new cfile_ routines for
reporting errors.
This requires that the "write failure alert box" routine take the
*input* file name as an argument, so that, on a merge, if the problem is
that a record from a given input file can't be written out to the type
of output file we're generating, the input file name can be given, along
with the record number in that file.
Change-Id: If5a5e00539e7e652008a523dec92c0b359a48e71
Reviewed-on: https://code.wireshark.org/review/21257
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2e6cb9dbab154531b306e472642ff6…
commit 2e6cb9dbab154531b306e472642ff6033f0e341c
Author: sswsdev <sswsdev(a)gmail.com>
Date: Fri Apr 14 13:41:37 2017 +0300
UMTS Iub: Added U-RNTI resolving logic for UEs on DCH
The goal is to figure out the U-RNTI for UEs in DCH to
preserve a single continous RLC session when the UE moves to FACH
(Since the UE ID in FACH is derived from the identity found in the
MAC layer, which is sometimes the U-RNTI)
UMTS RRC dissector now defines a single 'umts rrc private data'
structure as the way to access the actx->private_data field
Change-Id: Id0ffcbcdf0a8babe533915855909e250852e46cf
Reviewed-on: https://code.wireshark.org/review/21087
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=09e787a8fb4a1a04366e57c059c499…
commit 09e787a8fb4a1a04366e57c059c4997abcd9183e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Apr 20 13:05:52 2017 -0400
sigcomp: Shift operand should be limited to 16 bits
Change-Id: I5a6fbcacf874962c361e68fef7402dc775aca658
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1154
Bug: 13610
Reviewed-on: https://code.wireshark.org/review/21250
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d97ce76161f573beb88fff7eefe4e0…
commit d97ce76161f573beb88fff7eefe4e0f686a4f3a9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 11:46:45 2017 -0700
cf_open() pops up a dialog box on errors; its callers shouldn't do so.
Change-Id: I1c65854b5bde1c64d70cb17a13080829f0faa27b
Reviewed-on: https://code.wireshark.org/review/21253
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9e9d284d9157a8b79964015be868f4…
commit 9e9d284d9157a8b79964015be868f4e8c43274c3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 11:23:51 2017 -0700
Have separate routines for open-for-reading and open-for-writing errors.
Expand comments while we're at it.
Change-Id: I6dcc791eab1c9e323a9572f3d54720d223bdd64b
Reviewed-on: https://code.wireshark.org/review/21252
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d09ef614598cf6b714059f39191f09…
commit d09ef614598cf6b714059f39191f09af5701bc93
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 10:14:50 2017 -0700
Make the command-line and alert-box failure messages more similar.
Change-Id: I94af221a0ce8b6b3ff8e0e1b94d5379351ac0962
Reviewed-on: https://code.wireshark.org/review/21251
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=46f0c351a902284923a0d16bc394ce…
commit 46f0c351a902284923a0d16bc394ceb91ebc8453
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Wed Apr 19 22:37:04 2017 +0200
noe: reworked EVT_BT_KEY_... message handling
Change-Id: I36763e4f1b6bad6c7fd62100164a61a239653646
Reviewed-on: https://code.wireshark.org/review/21226
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7312019eac8d4c5546af1108f52155…
commit 7312019eac8d4c5546af1108f52155aa6efac0d4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 09:55:35 2017 -0700
Fix a compiler warning.
(Clang FTW! Is this not an issue on x86-64 macOS, so that it doesn't
warn about it, or does it, unlike GCC, require a particular -W flag to
warn about non-volatile variables being stomped by setjmp/longjmp?)
Change-Id: I253c1ea324feac1372aa4077aaba03c787a47d9f
Reviewed-on: https://code.wireshark.org/review/21248
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9b0b2c3d59a698ac80c2d9911575d9…
commit 9b0b2c3d59a698ac80c2d9911575d96c7803a08d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 12 22:04:38 2017 +0200
Qt: show relative time for the IO Graph in an appropriate unit
The GTK+ UI performs automatic formatting of the units (us, ms, s) based
on the magnitude of the value (for MIN/MAX/SUM calculations). Internally
the numbers are stored as integers (microseconds).
The Qt UI did not have this formatting feature yet and would therefore
display the values as-is (in microseconds). This patch rescales the Y
value and appends an appropriate label (s, ms or us).
With multiple graphs, rescaling is disabled completely for simplicity
(GTK+ would still try to find an appropriate unit prefix if there are
multiple time graphs).
Bug: 12828
Change-Id: I26ed68fc3497e06ac283a618fee8b673b1b0cf71
Reviewed-on: https://code.wireshark.org/review/21062
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=691d803037f777ff1bed025a48a48a…
commit 691d803037f777ff1bed025a48a48aa92956967f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 12 00:55:06 2017 +0200
Qt: Prevent moving other columns on drag and drop
This workaround prevents moving around other columns during drag and
drop and also transfers the sorting order to the new position.
Bug: 13183
Ping-Bug: 13540
Change-Id: I4609c63557bf3abf06ba417ac1b40cac22a82abc
Reviewed-on: https://code.wireshark.org/review/21022
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=2ab4f63dea65de2e00fa488a35a86c…
commit 2ab4f63dea65de2e00fa488a35a86cfd494d5fca
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 19 22:38:09 2017 -0400
packet-sigcomp.c: Fix potential negative shift
Bug: 13619
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1172
Change-Id: Ifa5ed88031425701f9cb14c80eb61311e0bba4aa
Reviewed-on: https://code.wireshark.org/review/21236
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ba3fbc5adb1b96aea598bc625b0388…
commit ba3fbc5adb1b96aea598bc625b038855f17db316
Author: Max Dmitrichenko <dmitrmax(a)gmail.com>
Date: Wed Apr 19 17:11:43 2017 -0400
memory leak: Qt code doesn't pass 'parent' argument to some Qt class
constructors
found with valgrind
Change-Id: I2d73bd50a6f0e13b1817c8a518189c0e56558f72
Reviewed-on: https://code.wireshark.org/review/21227
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=3e755bb0c1b8ad9e466db1d02d7699…
commit 3e755bb0c1b8ad9e466db1d02d76995ce1d39763
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 19 22:51:45 2017 -0400
packet-xot.c: Handle potentially large representation of packet sizes
Value on wire is 2^x, so represent the field that way.
Bug: 13618
Change-Id: Ida4a85e1f52b29b8b89fa835f78ef3fff2bde5c9
Reviewed-on: https://code.wireshark.org/review/21237
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=6d99d7ff50d84b826686c8aedde557…
commit 6d99d7ff50d84b826686c8aedde55757daf93dd3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 00:22:16 2017 -0700
Fix a comment.
Change-Id: Ic99602ec405533dcf436463ee26bf312f9dd78f1
Reviewed-on: https://code.wireshark.org/review/21240
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bce5ec919e2fd197e0042dfabf5186…
commit bce5ec919e2fd197e0042dfabf5186d0d6f6eb47
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 20 00:19:01 2017 -0700
Use the new cfile_XXX_failure_message() routines more broadly.
Change-Id: I7814b3fd0353f4836ae61cbdbd4e13f659cbcb59
Reviewed-on: https://code.wireshark.org/review/21239
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b0c48f3b4fd4a1e8e7552265c1b539…
commit b0c48f3b4fd4a1e8e7552265c1b5393ca991a40f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 19 20:25:59 2017 -0700
editcap now uses stuff from libui.
Change-Id: Ifa5cda67305682909559963ea5ce90cecc0c8e6e
Reviewed-on: https://code.wireshark.org/review/21238
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=347a19ae9629ad06ab597a176672c9…
commit 347a19ae9629ad06ab597a176672c9098c9af64a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 19 19:21:11 2017 -0700
Add common routines for command-line libwiretap error reporting.
These are similar to the routines added to ui/alert_box.c for dialog-box
libwiretap error reporting.
This centralizes the knowledge about what to say for various libwiretap
errors, removing some duplicate code, and giving more details in some
programs.
Change-Id: I737405c4edaa0e6c27840f78a8c587a8b3ee120b
Reviewed-on: https://code.wireshark.org/review/21234
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9e8bc9fee87c99944bfe52e27498d7…
commit 9e8bc9fee87c99944bfe52e27498d759e7235701
Author: Max Dmitrichenko <dmitrmax(a)gmail.com>
Date: Wed Apr 19 17:36:48 2017 -0400
extcap: fix memory leak
found by valgrind
Change-Id: I8c5226a08be797ce72ec937138a6681d946fb13c
Reviewed-on: https://code.wireshark.org/review/20720
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a426cf7631664ee56c753f39039a29…
commit a426cf7631664ee56c753f39039a296eb0c32efb
Author: Max Dmitrichenko <dmitrmax(a)gmail.com>
Date: Wed Apr 19 17:29:44 2017 -0400
packet-xml.c: Fix memory leaks in XML DTD processing (mostly g_* to wmem_*
transition)
Change-Id: I6766e0ef3d33895ba04bca1347eabdfa854b78b1
Reviewed-on: https://code.wireshark.org/review/21229
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=860bfd8ba4b5db965bd9e07f0cc061…
commit 860bfd8ba4b5db965bd9e07f0cc0612c7462c342
Author: Max Dmitrichenko <dmitrmax(a)gmail.com>
Date: Wed Apr 19 17:32:14 2017 -0400
decode as: Fix small memory leak
Change-Id: I3b924ff3e81a5b4ca17fcb9a087b7d7520225f34
Reviewed-on: https://code.wireshark.org/review/21231
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d1c0f2b95ad7b5e03305996017635e…
commit d1c0f2b95ad7b5e03305996017635e1cb181c723
Author: Max Dmitrichenko <dmitrmax(a)gmail.com>
Date: Wed Apr 19 17:16:28 2017 -0400
Fix memory leak in create_persconffile_profile
found by valgrind
Change-Id: I15aef9d78dffac44e36849349dc57b4b36f23de1
Reviewed-on: https://code.wireshark.org/review/21228
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9e36106bafc4919a46ea7ae27c43d9…
commit 9e36106bafc4919a46ea7ae27c43d98815dfe9c9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 19 15:06:20 2017 -0700
Have a common "capture file write failure alert box" routine.
Take the code from save_record() to pop up an alert box and put it into
libui, with the name cfile_write_failure_alert_box().
While we're at it, clean up some variable names and comments.
Change-Id: If56e649e5afe50e7a20b39720ec96e8fe2983b24
Reviewed-on: https://code.wireshark.org/review/21233
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4362e63dd54d8d35603d81fd2468cf…
commit 4362e63dd54d8d35603d81fd2468cfe710b88f3e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 19 14:43:11 2017 -0700
Have a common "capture file close alert box" routine.
Take the code from cf_read() to pop up an alert box and put it into
libui, with the name cfile_read_failure_alert_box(). Use it in a couple
of places where we pop up such an error dialog.
While we're at it, get rid of the "err" argument to rescan_file();
nobody uses what it returns.
Change-Id: Iba7099b95de24309359d94eb96f606020e2ff2c3
Reviewed-on: https://code.wireshark.org/review/21232
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=26cc3f06a7541578ed216ab37e8c07…
commit 26cc3f06a7541578ed216ab37e8c07683f2e9b3a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Apr 19 21:05:22 2017 +0200
pqsql: add salt for GSSAPI
Change-Id: Iaab55d4c727b151687b242ad02d938164521e87c
Reviewed-on: https://code.wireshark.org/review/21225
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=27da6380de478ed32a778d7f606186…
commit 27da6380de478ed32a778d7f60618680046da8c7
Author: Christian Ullrich <chris(a)chrullrich.net>
Date: Wed Apr 19 16:20:55 2017 +0200
pgsql: Add missing authentication types
Bug: 13622
Change-Id: I0813ebb5f506d1e702f84399416994daeb527be2
Signed-off-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/21222
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cb018b4cc662c0b65087e3aa5bb3db…
commit cb018b4cc662c0b65087e3aa5bb3db7635c7c5b3
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Wed Apr 19 17:40:02 2017 +0200
macosx-setup.sh: Allow downloading packages without installation
For offline installation, or for checking if all links are working
Change-Id: I0447d99b2accf6757b944a02a682b3ee7ed63846
Reviewed-on: https://code.wireshark.org/review/21223
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4c13bde1e0faa8cf3f3cb4fc83eaa9…
commit 4c13bde1e0faa8cf3f3cb4fc83eaa94b6b7e730b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 18 23:02:38 2017 -0400
P_Mul: Convert GHashtable -> wmem_map to fix memleaks
Change-Id: I7bdd0a483d9744780c18b45ab9fad3de3ed238de
Ping-Bug: 13120
Reviewed-on: https://code.wireshark.org/review/21215
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d4519ff28daa4708efb265933fe43d…
commit d4519ff28daa4708efb265933fe43de371332504
Author: Guy Davies <aguydavies(a)gmail.com>
Date: Tue Apr 18 16:39:46 2017 +0200
[Diameter] Add Juniper SCG AVPs
Change-Id: I832a82b4edbfce26e3edceb0f6baed3b7a1c8b62
Reviewed-on: https://code.wireshark.org/review/21190
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=89e0bdf36dcb33e079f6bffb14b16e…
commit 89e0bdf36dcb33e079f6bffb14b16e90c20f13e3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 18 19:20:48 2017 -0400
X11: Replace VALUEXX macros and handle endianness "natively."
Change-Id: I45d4557377a445c981e6b7cfc1dbe57f586252e5
Reviewed-on: https://code.wireshark.org/review/21210
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=39167ab2c99dd42497ec6f0ea7449e…
commit 39167ab2c99dd42497ec6f0ea7449ef635a31433
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Apr 19 12:43:31 2017 +0200
cmake: FixLibXML2 include
Add default setting for the libraries entry, to satisfy windows builds,
if no libxml2 has been found
Change-Id: I3db026b6b8446eb42c7f30ee63c00a07600948fa
Reviewed-on: https://code.wireshark.org/review/21221
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=84e7855f271d7f912499ef27142cd7…
commit 84e7855f271d7f912499ef27142cd7b4ffecf830
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 19 01:40:25 2017 +0200
smb-pipe: fix memory leaks from descriptors
The values from the requests are used in a later response, so use the
packet capture file scope instead.
Bug: 13615
Change-Id: I480d9dbdc20c64eabea092065245d8687b7fc39f
Reviewed-on: https://code.wireshark.org/review/21211
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cfab5ef035db7be8502623af203ab3…
commit cfab5ef035db7be8502623af203ab3494a9200e3
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Tue Apr 4 23:23:59 2017 +0200
Add libxml2 as optional dependency
This can be used by dissectors that need to parse out-of-band
configuration.
Change-Id: I13c0a2f408fb5c21bad7ab3d7971e0fa8ed7d783
Reviewed-on: https://code.wireshark.org/review/20912
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d13c6d9628e3964697559e3509d9c1…
commit d13c6d9628e3964697559e3509d9c1f8ec30ed9e
Author: Xiaochuan Sun <linuxvxworks(a)gmail.com>
Date: Mon Apr 17 19:39:15 2017 +0800
remove unnecessary guint64 cast in IO graph
Change-Id: I35d666a5a9fb5813706c312334f1552703c9475c
Reviewed-on: https://code.wireshark.org/review/21214
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=05140af874e9bd86160659dbc85413…
commit 05140af874e9bd86160659dbc8541373d662e290
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Apr 18 23:24:23 2017 +0200
RTCP: Handle large TMMBR value presentation
TMMBR can be _very_ large (131072*2^63, larger than 64 bit entities can
hold). Therefore don't try to calculate and present the bitrate as an
integer value, but as an expression.
Bug: 13611
Change-Id: Ieb8caae5d72d06f82c134eda63f99575218584c2
Reviewed-on: https://code.wireshark.org/review/21207
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fe003f1321ba1aec5a66859ca60352…
commit fe003f1321ba1aec5a66859ca60352f33019ca50
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Apr 18 23:42:33 2017 +0200
EAPOL-MKA: differentiate between actor and peers
Actor member identifier and message numbers are something else than peer
member identifiers and message numbers. Give them their own header
field.
Change-Id: I9ee0073447f861084e81ab2e23cf587005184686
Reviewed-on: https://code.wireshark.org/review/21208
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=111973c294a575ca201f955c5775dd…
commit 111973c294a575ca201f955c5775dd0be1023467
Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Date: Sun Mar 26 11:56:36 2017 +0200
ZigBee: Use value_string_ext and VALUE_STRING macros
Change-Id: I04d8e1f89e0d6cf34f94ba1b6e0249297834c078
Reviewed-on: https://code.wireshark.org/review/21141
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=243da1fb3c856e4d3973ecec200a85…
commit 243da1fb3c856e4d3973ecec200a85b9e502ea1c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 18 15:55:26 2017 -0400
X11: Replace UNUSED macro
Change-Id: Ieed2c672fd2acb76dba0ef1c3182eb9f00a04253
Reviewed-on: https://code.wireshark.org/review/21205
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=913f9fb35335acd30aa231b00b23fd…
commit 913f9fb35335acd30aa231b00b23fd8f0dc379fb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 18 15:27:28 2017 -0700
Rename BASE_VALS_NO_UNKNOWN to BASE_SPECIAL_VALS.
It makes it a bit clearer what its purpose is - to allow a value_string
to be used for numeric rather than enumerated fields, giving certain
values of the field a special meaning.
Change the explanation in the documentation to match as well.
Change-Id: Id07b22eee996b79ea5f3473928d29adcabe09bf3
Reviewed-on: https://code.wireshark.org/review/21209
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c9088466253f53bb29602810b7f4ad…
commit c9088466253f53bb29602810b7f4ad5fca627f92
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 18 10:42:35 2017 -0400
X11: Sort mesa_enum to allow for value_string_ext
Adjust the dissector generator to put mesa_enum values in
numerical order. Remove comments about where the specific
values came from as sorting them means the comments aren't
always going to be in the right place.
Change-Id: I3c6b8252017c8a3ec379be49b3df069ec488cd1c
Reviewed-on: https://code.wireshark.org/review/21198
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=73e2354e4c4dfcffe413562e0f9f01…
commit 73e2354e4c4dfcffe413562e0f9f0169c8f6b50e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Apr 18 21:55:30 2017 +0200
mate: avoid redefining NDEBUG
When building RelWithDebInfo target with MSVC, NDEBUG is automatically defined.
Avoid redefining the macro by checking if it already exists.
Change-Id: I1720f47cce0df210c2b2dff3b20c218dc2ae7b02
Reviewed-on: https://code.wireshark.org/review/21200
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=cf40e733e968c4ecb05b88bfb6b074…
commit cf40e733e968c4ecb05b88bfb6b07442279a2d59
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 18 14:20:25 2017 -0700
Fix a comment.
Change-Id: I3a18e3fab9fa785e828df843b1b4b899beba1f19
Reviewed-on: https://code.wireshark.org/review/21206
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e6b9c7706f2421008b44b1df1eb7a5…
commit e6b9c7706f2421008b44b1df1eb7a55263bdf04f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 18 14:07:42 2017 -0700
Fix a comment.
Change-Id: I2ed361efdaa6dcf632f054634dc473d518df4cc8
Reviewed-on: https://code.wireshark.org/review/21204
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1015fa04313893ba81bca678534fad…
commit 1015fa04313893ba81bca678534fad7a4630d6c8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 18 14:02:18 2017 -0700
Have a common "capture file close alert box" routine.
Take cf_close_failure_alert_box() and put it into libui, with the name
cfile_close_failure_alert_box(). Use it not only in file.c but also
in ui/export_pdu_ui_utils.c, ui/gtk/file_import_dlg.c, and
ui/qt/import_text_dialog.cpp where the error we get back isn't
necessarily an errno.
Have ui/gtk/file_import_dlg.c and ui/qt/import_text_dialog.cpp also use
cfile_open_failure_alert_box() on open errors.
Change-Id: I987f339a23ea58609390306a319923e7f92d5c07
Reviewed-on: https://code.wireshark.org/review/21203
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=870b3d2c0f46addafb6a7dab4278de…
commit 870b3d2c0f46addafb6a7dab4278de48edc33535
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 18 16:28:52 2017 +0200
netflow: fix undefined shift
Treat any prefix length larger than 32 as 32 (effectively not masking
anything) and treat a zero-length prefix as the empty mask (matching
anything).
Change-Id: If96b03c2f76ff7624d50fefdf0b025ab373c07dc
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1152
Bug: 13607
Reviewed-on: https://code.wireshark.org/review/21189
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=31b7e165c8d31fc3f0740172614102…
commit 31b7e165c8d31fc3f074017261410255f9a1b225
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 18 14:33:59 2017 -0400
X11: Fix missing brackets caught by GCC
packet-x11.c: In function ‘dissect_x11_request’:
packet-x11.c:3753:13: error: this ‘if’ clause does not guard...
[-Werror=misleading-indentation]
if (next_offset - *offsetp > 0)
^~
packet-x11.c:3755:17: note: ...this statement, but the latter is misleadingly
indented as if it is guarded by the ‘if’
*offsetp = next_offset;
^
cc1: all warnings being treated as errors
Makefile:4388: recipe for target 'packet-x11.lo' failed
make[6]: *** [packet-x11.lo] Error 1
Change-Id: I3605c316e7b84f7cec21ce54431f6816fccca100
Reviewed-on: https://code.wireshark.org/review/21199
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5df6cc4b3da71f3d9564eab1ed25f4…
commit 5df6cc4b3da71f3d9564eab1ed25f4d3ad21a3ff
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 18 16:01:10 2017 +0200
ositp: fix undefined behavior from large shift
Display "2^105" instead of the expanded value.
Change-Id: I455625ab66cd86587ca35d09e1eba98ae1d87a94
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1149
Bug: 13606
Reviewed-on: https://code.wireshark.org/review/21188
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67d7a942376be1e4a86b4c50e94cd7…
commit 67d7a942376be1e4a86b4c50e94cd7f74b969777
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 18 14:57:15 2017 +0200
MPLS: Add Support for identifying Entropy Label (RFC6790)
Bug: 13605
Change-Id: I414cad63df92b17f34676364fb38815dba9020e2
Reviewed-on: https://code.wireshark.org/review/21186
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ea9d9dcb26dbd949350cd3f3b399c2…
commit ea9d9dcb26dbd949350cd3f3b399c22582b4b5fb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 18 15:02:30 2017 +0000
RMP: fix conflicting entry in its value_string
Field 'Returncode' (rmp.retcode) has a conflicting entry in its value_string:
19 is at indices 8 (Default File Open Failed) and 10 (Bad Packet Detected))
Change-Id: I77bd9b91f0c32f484ffd2406a493426f0ad3fbf8
Reviewed-on: https://code.wireshark.org/review/21192
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0012214facc35f92536354d77dfde7…
commit 0012214facc35f92536354d77dfde74f1347cdf9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Apr 17 21:52:51 2017 -0400
X11: General cleanup
1. Replace bitmask macros with proto_tree_add_bitmask + bitmask field handling
2. Replace REQUEST_LENGTH macro with actual function.
Change-Id: Ibb3b2bc8c9d0556092af0e3dc384a4aad6c07ac2
Reviewed-on: https://code.wireshark.org/review/21185
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d46adfe75377323508dbf9443f35ba…
commit d46adfe75377323508dbf9443f35baa81e4a2471
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Apr 17 23:02:57 2017 -0400
X11: GHashTable -> wmem_map
A few other cleanups related to switching to wmem_alloc()ed memory
Change-Id: I86229affaa6b89dc86ab1589471734bba9efe50d
Reviewed-on: https://code.wireshark.org/review/21184
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6c33af3d16c84066ef2cd33b649a9e…
commit 6c33af3d16c84066ef2cd33b649a9e9232784c56
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Apr 18 09:00:01 2017 +0200
NETLINK: Show raw attribute data
Once the netlink dissector does an attribute dissector callback it knows
whether or not the callback function could handle the data. If not then
simply add the raw data to be inspected by a human.
Change-Id: Ibeb7a54f72f0f856008a50f5340e4ba142e00115
Reviewed-on: https://code.wireshark.org/review/21180
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1b7677e32f75c8e12698a9de505f3f…
commit 1b7677e32f75c8e12698a9de505f3f9fb9df9569
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 18 10:11:06 2017 +0200
CMake: Sort entries
Put additional_toolbar in sorted position.
Change-Id: I483bca72265a5932f54ccf882c6659e94be5d95b
Reviewed-on: https://code.wireshark.org/review/21183
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=951cf710e8c8f85fb248887d9545c9…
commit 951cf710e8c8f85fb248887d9545c939cc03d7a8
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Apr 18 10:03:00 2017 +0200
Qt: AdditionalToolbars is a menu
Rename actionViewAdditionalToolbars to menuAdditionalToolbars
because this is a menu, not an action.
Change-Id: I85e45c065f415ffa008792f04127d81283e54b7e
Reviewed-on: https://code.wireshark.org/review/21181
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=3c5183326bbca86273d62fb7ac12a9…
commit 3c5183326bbca86273d62fb7ac12a9513df7f14a
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Apr 17 19:50:36 2017 +0200
raknet: don't THROW() an exception from a dissector
Show an expert info and return from raknet_dissect_system_address().
Change-Id: Icedab5f1956d4b4c60318a1dd4f65bc7078d4e20
Reviewed-on: https://code.wireshark.org/review/21168
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=c54afb89a2163cb816169b50e66068…
commit c54afb89a2163cb816169b50e660684a508914a9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 22:58:28 2017 -0700
No need to close a descriptor that didn't get duped-to in the first place.
Addresses CID 1398217.
Change-Id: I387c4a9f1df739724b80ccaad173de2d9095b101
Reviewed-on: https://code.wireshark.org/review/21179
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6a049dd755a5c2c4c20669c8b4c989…
commit 6a049dd755a5c2c4c20669c8b4c9895d63ea2c15
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 22:54:04 2017 -0700
Check the result of localtime().
Unlikely to fail, but it squelches CID 1398219.
Change-Id: Ibdabd2d71bdc2c09549f27f1ffe528005383ee3e
Reviewed-on: https://code.wireshark.org/review/21178
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=720705091c0d3414ea9d291cf419e8…
commit 720705091c0d3414ea9d291cf419e865b193672d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 22:43:22 2017 -0700
Check the result of localtime().
Unlikely to fail, but it squelches CID 1398220.
Change-Id: I0e40146f0a32c1082e84052c6b3e382fe6a15ae7
Reviewed-on: https://code.wireshark.org/review/21177
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=613476fbaf26bdcc427e661b4144f2…
commit 613476fbaf26bdcc427e661b4144f226b3319abd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 22:31:53 2017 -0700
More checks for localtime() failing.
Addresses CIDs 1398222 and 1398221.
Fix the previous fix while we're at it.
Change-Id: I6fe54e6ad115ac05154291b76de316426db72139
Reviewed-on: https://code.wireshark.org/review/21176
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=85d08e58cc9be2127dfa022cf3fab3…
commit 85d08e58cc9be2127dfa022cf3fab32e402f04f4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 07:52:38 2016 -0500
X11: Use proto_tree_add_bitmask for generated bitmasks
Change-Id: Idc95500b74452911117be8903fe0bde0c8a6fefa
Reviewed-on: https://code.wireshark.org/review/21173
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8fb828ff0cdb2bd734e8a9e8197a7a…
commit 8fb828ff0cdb2bd734e8a9e8197a7a378cfaaae7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 19:14:06 2017 -0700
Have a common "print a capture file open error message" routine.
Use that for both "open for input" and "open for output" errors.
Change-Id: Id17b732a2ca91bd080957b9fa010f781a1c65471
Reviewed-on: https://code.wireshark.org/review/21175
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e34d76942c15f9d9e83d078aca950a…
commit e34d76942c15f9d9e83d078aca950a29452d0b60
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 18:58:55 2017 -0700
Have a commont "capture file open alert box" routine.
Take cf_open_failure_alert_box() and put it into libui, with the name
cfile_open_failure_alert_box(). Use it not only in file.c but also in
ui/export_pdu_ui_utils.c, where the error we get back isn't necessarily
an errno.
Change-Id: Ia053f3e403ba464d446bd9530778d5ed302796d2
Reviewed-on: https://code.wireshark.org/review/21174
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4ce54674b3c8d3782a744718646ddd…
commit 4ce54674b3c8d3782a744718646ddd0104b45e68
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 17:37:21 2017 -0700
Just say "pcap" in the short names of all pcap variants.
That's more consistent.
Handle the "libpcap" names for backwards compatibility.
Change-Id: I819404d69bddd733b7ee38e23d3ddc71110c0faf
Reviewed-on: https://code.wireshark.org/review/21172
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ce6430e35e137b981cb18e286e546e…
commit ce6430e35e137b981cb18e286e546eae3c1f6b3c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 17:17:01 2017 -0700
Eliminate an unneded member of a wtap_dumper.
The only place the time stamp precision is used is in the libpcap code,
where it determines whether to write out microsecond-precision or
nanosecond-precision time stamps; we can determine that by looking at
the type/subtype field, which is also part of that structure, so do
that.
We weren't setting it consistently - we were only setting it in libpcap
and a few other capture file writers, and not in other capture file
writers - and none of the writers other than libpcap used it.
Change-Id: If53779cf4823ca936b8bf3e8a7dbcfea5850e652
Reviewed-on: https://code.wireshark.org/review/21171
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c9bb6b8282eb5c829bc4cb07f4bc2e…
commit c9bb6b8282eb5c829bc4cb07f4bc2e53f409c0c5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 17:09:26 2017 -0700
Don't close a wtap that you don't have open in the first place.
Change-Id: I4d9d539957d06cb3568df287eb36ecc34677373f
Reviewed-on: https://code.wireshark.org/review/21170
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3fac48da689998ca0942ec2bdcb0da…
commit 3fac48da689998ca0942ec2bdcb0dabd77e04a36
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Apr 6 21:50:53 2017 +0200
raknet: re-structure raknet_dissect_system_address()
Create the subtree first. Increment *offset as we process the fields.
Change-Id: I03b6ba9a20541593b90ac7932aab5ac88538f640
Reviewed-on: https://code.wireshark.org/review/21167
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e1e31ed1c9e2ecf379a988020c25c3…
commit e1e31ed1c9e2ecf379a988020c25c3059232a1d5
Author: Binh Trinh <beango(a)gmail.com>
Date: Sun Apr 16 14:10:02 2017 -0400
[GTPv2]: Add preference to Decode the SRVCC Transparent Containers
This is to re-enable SRVCC Transparent Containers by letting the user make the
assumption of the target technology
Change-Id: I54812716a011c6a68f48bd0c8c7d18c06c0431fd
Reviewed-on: https://code.wireshark.org/review/21147
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=55f98f6affdcbc60f22c0e88499dba…
commit 55f98f6affdcbc60f22c0e88499dba90088b7b74
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Apr 17 18:00:27 2017 +0200
Simplify dissector_try_uint_new().
Exit straight away if there's no entry for our value in the dissector
table.
Change-Id: I2637b4f03cb852dca0a6993b9f63fdc15e8edc58
Reviewed-on: https://code.wireshark.org/review/21165
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2273cf0e7b2dedc20430594a4ee840…
commit 2273cf0e7b2dedc20430594a4ee840d640203ab3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Apr 17 08:52:57 2017 -0400
packet-nsh.c: Create dissector table for next protocol
Change-Id: Id8be2a37f99f4ac9d531a694273c7d5d3f843cc1
Reviewed-on: https://code.wireshark.org/review/21163
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=25382fd638a7152d0262b994b1b1b3…
commit 25382fd638a7152d0262b994b1b1b38e9e1ae283
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 11:02:49 2017 -0700
Don't assume gmtime() or localtime() succeed.
The chances that they won't, in this case, are slim to none, as the time
is after the Epoch, but this squelches CID 1398223.
We'll change the master branch to require an err_info string for
WTAP_ERR_INTERNAL and to display it in a future commit.
Change-Id: Ifb51076b25117efc53ba3ad8b434e36c71f7600f
Reviewed-on: https://code.wireshark.org/review/21169
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=07e2f65b9627f9b37648f4a9dd310d…
commit 07e2f65b9627f9b37648f4a9dd310d9e18bac223
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Apr 17 17:55:09 2017 +0200
Fix the description of dissector_try_uint_new().
We return the number of bytes consumed by the dissector.
Change-Id: Icc22c9e033dfb11f230fb59cfb79932bc8c80548
Reviewed-on: https://code.wireshark.org/review/21164
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=6d67dff65698439c110689efb4514b…
commit 6d67dff65698439c110689efb4514b39292a9b1a
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Apr 17 18:08:27 2017 +0200
oss-fuzzshark: disable setresgid(), it fails with -EINVAL
Change-Id: I28abb1d0beb89ce45e20414298b2046f5149a25b
Reviewed-on: https://code.wireshark.org/review/21166
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=e6f944d6326b0522d971522decb207…
commit e6f944d6326b0522d971522decb2079e43ba6906
Author: Gabriel Ganne <gabriel.ganne(a)enea.com>
Date: Wed Apr 12 13:53:19 2017 +0200
nsh: add support for nsh/nsh, and nsh/mpls
Change-Id: If7c8d703c3a019af75ef24d3813bfe64a9db2471
Signed-off-by: Gabriel Ganne <gabriel.ganne(a)enea.com>
Reviewed-on: https://code.wireshark.org/review/21161
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b478df61f54f08e0279d83e2cc1131…
commit b478df61f54f08e0279d83e2cc11313fbdf28758
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Fri Apr 14 11:33:57 2017 +0200
Qt: Provide both file save and open preferences
This is a breaking change.
prefs_register_filename_preference hasn't been differentiating
between files to be saved and ones to be opened.
On GTK, a neutral dialog is used, so no problems there.
On Qt, a save dialog has been always used, even in dissectors that
were reading configuration files without modification.
prefs_register_filename_preference now takes an argument to indicate
whether UI could be a save dialog with a warning on overwriting
a file, or whether it's a general purpose open file dialog.
Qt now does this. Previously no warning was shown on overwriting a file,
so it may be used for opening files too without irritating the user.
This has been changed, as non-destructive reads should now use
the open dialog.
Dissectors were changed accordingly.
Change-Id: I9087fefa5ee7ca58de0775d4fe2c0fdcfa3a3018
Reviewed-on: https://code.wireshark.org/review/21086
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f63ad23ef9036a60e78e5efd45936a…
commit f63ad23ef9036a60e78e5efd45936aae1705d5ac
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Apr 17 00:48:20 2017 -0700
Check for localtime() failing.
It "shouldn't happen", but at least this squelches a Coverity
complaint,
CID 1398224.
Change-Id: I9555f71a50574e9386a3c96d52143d838f7f121f
Reviewed-on: https://code.wireshark.org/review/21160
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ca29ec9e77ce0422562727187e3d29…
commit ca29ec9e77ce0422562727187e3d2946f6ec2d6c
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Apr 8 10:15:11 2017 +0200
sharkd: support for "downloading" decoded RTP stream in wave-like format.
Change-Id: Ic6b241f9b7ed302e7b11644e63230474d5933a85
Reviewed-on: https://code.wireshark.org/review/20963
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=067ef3e08a4728d37c64a50da81087…
commit 067ef3e08a4728d37c64a50da81087cc7b3ad2e0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 20:47:34 2017 -0700
Clean up documentation and help messages for protocol enabling/disabling.
List all of --enable-protocol, --disable-protocol, --enable-heuristic,
and --disable-heuristic in the SYNOPSIS section of the man pages.
Undent after the list of taps for the -z option, so the following
options are at the same indentation as other options.
List --enable-protocol in the DESCRIPTION, above --disable-protocol.
Include --enable-protocol in the help message.
Change-Id: I680a54430789f3543b2d539fbded22b0b57f7f76
Reviewed-on: https://code.wireshark.org/review/21159
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ea1f62a8e8f9624de9447e8cd71f4d…
commit ea1f62a8e8f9624de9447e8cd71f4d95b292cc0b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 20:02:00 2017 -0700
Get rid of unnecesary #includes.
Change-Id: I379a2a1007be1b844873d9c5e8ea53bd689f0f4d
Reviewed-on: https://code.wireshark.org/review/21158
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4db20ec4a4b39f24df3ab691fc14fe…
commit 4db20ec4a4b39f24df3ab691fc14fed25d9c19dc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 19:57:51 2017 -0700
Remove unnecessary tap.
The tap was just a trick to get fields and protocols registered as being
of interest. Now that we have mechanisms by which postdissectors can
explicitly register fields and protocols as being of interest, and are
using that, the trick is no longer needed.
Change-Id: I0bccc88a1e4ee4c9fc84b90d968820375594c5c1
Reviewed-on: https://code.wireshark.org/review/21157
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b9c6e2d3915bc41b04420fb1fa99b1…
commit b9c6e2d3915bc41b04420fb1fa99b1b7d12b0a21
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 19:37:00 2017 -0700
Remove unnecessary tap.
The tap was just a trick to get fields and protocols registered as being
of interest. Now that we have mechanisms by which postdissectors can
explicitly register fields and protocols as being of interest, and are
using that, the trick is no longer needed.
Change-Id: Ib2620ff32c41ffa050203c1d4481c63535fb3f4b
Reviewed-on: https://code.wireshark.org/review/21156
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=acf349ea486799be4c28bc98fb674c…
commit acf349ea486799be4c28bc98fb674c145fbb66c6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 19:32:33 2017 -0700
Fix backwards test.
If fdata->flags.visited *isn't* set, this is the first pass over the
packets since opening a file or starting a redissection.
Change-Id: Ib72d122c9291ce5ac9c3a3df1b6dfb4db163698e
Reviewed-on: https://code.wireshark.org/review/21155
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=190350d73236c5f2ab2885f63b61a4…
commit 190350d73236c5f2ab2885f63b61a43e8890f02c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Apr 5 01:51:19 2017 +0200
Initial support for Linux 802.11 Netlink (nl80211) dissection
Only commands and top-level attributes are recognized, no specialization
is done (yet?) since it is a large protocol.
Fields are extracted from Linux v4.10-rc4-749-g8585989d146c using the
"tools/generate-nl80211-fields.py --update" command.
Depends on the Generic Netlink (genl) dissector.
Change-Id: I7f81b91e3beacca8ebcb853137212406004f65e8
Ping-Bug: 13561
Reviewed-on: https://code.wireshark.org/review/20914
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=61c5e8e76d215cd0f1ea2139ecafba…
commit 61c5e8e76d215cd0f1ea2139ecafbada1f933973
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Apr 17 00:54:32 2017 +0200
genl: make subdissectors responsible for header
Allow subdissectors to specify the command field for the Generic Netlink
message header, similar to how Netlink subdissectors handle the Netlink
message header (for its type field).
Pass the root tree instead of the genl tree to subdissectors (so
subdissectors can add their own layer).
Change-Id: I3e56f538661b7e8a51d2411da14d181ead820c4b
Reviewed-on: https://code.wireshark.org/review/21150
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=407a2b07e55a262905881c7d1e225d…
commit 407a2b07e55a262905881c7d1e225d618e9824fb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 18:48:30 2017 -0700
Rename some routines and structure members.
They deal with sets of hfids, which can belong to protocols as well as
fields (I guess you could argue that a protocol is a field, but...).
Change-Id: Ibd103cfa26427ead4ef54be89f1251908004cfae
Reviewed-on: https://code.wireshark.org/review/21154
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1bfc8580e322450f8afaaf797e2364…
commit 1bfc8580e322450f8afaaf797e236469b948c984
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 18:29:26 2017 -0700
Include protocols in the list of wanted hfids.
That's currently required to get the fields we want.
Bug: 12161
Change-Id: Ic1066334358c58fa915ef886b2658902393172c7
Reviewed-on: https://code.wireshark.org/review/21153
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0cc454359cadcb0ff2f11e53c39f50…
commit 0cc454359cadcb0ff2f11e53c39f50367254412e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 18:22:48 2017 -0700
Consistently call mate_config pointers "mc".
Some routines had "matecfg", some had "mc"; be a bit more
consistent.
Change-Id: I3406488315483fb281ebc3fb8a23e9e1b2104a14
Reviewed-on: https://code.wireshark.org/review/21152
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dae108837fc1d9c48eefbcc7feeff6…
commit dae108837fc1d9c48eefbcc7feeff607c26e0a4e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 18:18:11 2017 -0700
Make the current MATE config pointer static only to packet-mate.c.
Pass it as an argument to everything else, so only packet-mate.c has the
notion of there being *a* configuration, and everything else takes the
configuration as an argument.
Change-Id: Ia92c1539586d3e71580fd822cf07bd3d79a6f093
Reviewed-on: https://code.wireshark.org/review/21151
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3f912df8754972a6db06eda36564a3…
commit 3f912df8754972a6db06eda36564a300d5a5e350
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Wed Apr 12 13:02:45 2017 +0200
noe: improved EVT_LOCAL_APPLICATION message decoding (and updated code to match
previous reviews)
Change-Id: I3cf3687303cc582261aa62feef6bd81576965dfd
Reviewed-on: https://code.wireshark.org/review/21038
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d28d537391cab21362a471c514b361…
commit d28d537391cab21362a471c514b36158d87ea62a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 14:50:30 2017 -0700
No need for this to be a global variable.
Make it local to mate_tree(), and pass it to mate_pdu_tree().
Change-Id: I489683614b4d65aec3ddd94ce2c9077180e769ca
Reviewed-on: https://code.wireshark.org/review/21149
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5d7bd7ca2615bd9c86acf43affdd83…
commit 5d7bd7ca2615bd9c86acf43affdd83fbcfabaa78
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 14:36:57 2017 -0700
Work around a Lemon bug.
There's a Lemon bug where this grammar produces a parser that fails
assertions; to work around it, we disable assert() failures.
(A bug report has been sent to sqlite-users about this.)
Change-Id: I6812b20fafe318425b37755a15009b0baf2d68a2
Reviewed-on: https://code.wireshark.org/review/21148
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b1a41acb52a2db6f4661d741badc44…
commit b1a41acb52a2db6f4661d741badc44709d3078ec
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 05:56:42 2016 -0500
X11: Resolve filter differences between a "list" and its "item".
The "list" is of type FT_NONE and the "item" is not. That can
cause type conflicts.
Change-Id: If62f7113bc120e392588724a0dd65b7ab32ccde7
Reviewed-on: https://code.wireshark.org/review/21146
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4fa9c5f1f34885181339c7e2fa6f97…
commit 4fa9c5f1f34885181339c7e2fa6f97a57569b413
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Apr 16 17:48:49 2017 +0200
oss-fuzzshark: search for dissector in given table.
Change-Id: Ia02b0e6a92213599307e5b382e9fd7ba6c9833a3
Reviewed-on: https://code.wireshark.org/review/21145
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=6e708bdab91e53d6caeb51ed5c124d…
commit 6e708bdab91e53d6caeb51ed5c124d05a2f1954a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 10:24:56 2017 -0400
MQ: Remove duplicate values from mq_PrmId_xvals.
Appears to be duplicates between "regular" and "64-bit" versions
of values.
Change-Id: Ib615c0d85c29e11daf5d4379c18563c58ad152f9
Reviewed-on: https://code.wireshark.org/review/21138
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f5f5e8c6a7d50f25b3c7fcc6cc0698…
commit f5f5e8c6a7d50f25b3c7fcc6cc06986107d3d2e1
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 10:22:33 2017 -0400
packet-hislip.c: Remove duplicate entries from vendorID.
This does occasionally happen to enumerated vendor ID values for protocols
(company/product line buyouts/acquisitions, etc).
Use "first value" as the vendor ID of choice.
Change-Id: I9a277bf07276809e0684bd3a9f121d4a656d87f6
Reviewed-on: https://code.wireshark.org/review/21137
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1ebdf3d7f010d55dcf8f55c59bbef2…
commit 1ebdf3d7f010d55dcf8f55c59bbef247fc1a6bb9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 10:19:43 2017 -0400
Netlink: Remove duplicate from nfq_ctinfo_vals
Problem seems to stem from handling of enum (and that first value has to be 0)
Change-Id: I4c5d749cc53c73988c54f2aa08e60b7f55779348
Reviewed-on: https://code.wireshark.org/review/21136
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=965723a6cd158a397baabd2f2951d3…
commit 965723a6cd158a397baabd2f2951d36a046a4e7c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 10:18:28 2017 -0400
packet-qnet6.c: Remove duplicates from qnet6_kif_msg_devctl_cmd_class_vals.
Maybe the value_string needs to be broken up into the different pieces.
Change-Id: I1c69ca486eea6d8d8d1ea33d5d0d9eb2e2832ee6
Reviewed-on: https://code.wireshark.org/review/21135
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fe4598626a189fcc443433dc5e98bf…
commit fe4598626a189fcc443433dc5e98bf95615d110e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 10:15:27 2017 -0400
[TACACS] Fix typo with TAC_PLUS_AUTHEN_METH_KRB5
Causes duplication in value_string
Change-Id: Ifdafab2f32f69115dcbb0d1e65604a60a603563c
Reviewed-on: https://code.wireshark.org/review/21134
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9d9bb8ef98801d8be7c4b40db4fe88…
commit 9d9bb8ef98801d8be7c4b40db4fe88d40aa36afb
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 09:13:16 2017 -0400
[DOCSIS] Fix typo in docsis_conf_code.
Flagged during value_string duplication check
Change-Id: Ia6b657b6e0d8e60cf69ea0e40199b78e96837ecc
Reviewed-on: https://code.wireshark.org/review/21133
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7b68ddacefb27fd586599e22dcb046…
commit 7b68ddacefb27fd586599e22dcb046d99ad68ba9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 09:12:11 2017 -0400
packet-vsip.c: Remove duplicate value in EVsipConfigItem_vals
Looks like it's just a typo.
Change-Id: Ic1fe505a311b423c24f24f2060b8a84c4f577ad3
Reviewed-on: https://code.wireshark.org/review/21132
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=42277559cf5685d6174eb3a2e76c2e…
commit 42277559cf5685d6174eb3a2e76c2e2bed062c17
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 09:11:03 2017 -0400
packet-v52.c: Remove duplicates from info_element_values.
ETSI EN 300 347-1 V2.2.2 does have the duplicated values
documented. Maybe the value_string needs to be broken up
into the different pieces (PSTN, Control, etc).
Change-Id: I92477d9532d334945cb9e55e75534520d51dd1d1
Reviewed-on: https://code.wireshark.org/review/21131
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=099556c81ca5759ca914c02da329a5…
commit 099556c81ca5759ca914c02da329a506ecea5b19
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 16 09:07:43 2017 -0400
packet-starteam.c: Remove duplicate entries from starteam_opcode_vals.
Comments around the duplicates suggest author was unsure of their
values to begin with.
Change-Id: Idc55e2b6e721e1061d8707ede4faad39901d3085
Reviewed-on: https://code.wireshark.org/review/21130
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f9b8e64e15226c1cf27cc1edc91c05…
commit f9b8e64e15226c1cf27cc1edc91c057c76e38090
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 04:40:55 2016 -0500
X11: Revert mesa_enum_ext back to mesa_enum
Values aren't numerically sorted in the XML, so they aren't put
in the value_string in numerical order. That's a problem for
value_string_ext.
Change-Id: Ie40c5ab1083cc7be140d11dc131e3588759819b7
Reviewed-on: https://code.wireshark.org/review/21128
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ef9150acee2131ee31e851ff7fff42…
commit ef9150acee2131ee31e851ff7fff42c369a16893
Author: Binh Trinh <beango(a)gmail.com>
Date: Sun Apr 16 10:14:50 2017 -0400
[GTPv2]: Add Request/Response Lookups for SRVCC PS-to-CS Messages
Change-Id: I12fcb180fd361f1df4e6d0f78f8f34f01284d7a4
Reviewed-on: https://code.wireshark.org/review/21129
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b2219bbccb9dbde0959d2e46bc8568…
commit b2219bbccb9dbde0959d2e46bc8568dafeff2d0b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Apr 16 08:16:47 2017 -0700
[Automatic update for 2017-04-16]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I8165b1b2db0f81049a88dd17163a4367f04f83cc
Reviewed-on: https://code.wireshark.org/review/21142
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f4f252d4c4b1d498c81d22686b160c…
commit f4f252d4c4b1d498c81d22686b160c7feccdc68d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Apr 12 14:15:00 2017 +0200
btatt: failed assertion 'hf->bitmask != 0'
(btatt.glucose_measurement.type_and_sample_location.type)
Fixes: v1.99.9rc0-246-ga50a49e527 ("Bluetooth: ATT: Add some remaining
attributes")
Bug: 13590
Change-Id: I8e92ec80ee9e93a3e507f86c8354f1909070b0b9
Reviewed-on: https://code.wireshark.org/review/21041
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=287a9cf8f3abd5dd002830650807d6…
commit 287a9cf8f3abd5dd002830650807d6937cee8a0e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 11:33:35 2017 +0000
Revert "Temporary hack to debug the MATE grammar."
This reverts commit c63c5c8c4262c8f58b12f56bf659383a1b0aa47a.
This is probably easier than just abandoning it and trying to remove it from my
repository.
https://xkcd.com/1597/
Change-Id: Ibba2107cfa9c60c86862b16a4cac31689670e137
Reviewed-on: https://code.wireshark.org/review/21127
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c63c5c8c4262c8f58b12f56bf65938…
commit c63c5c8c4262c8f58b12f56bf659383a1b0aa47a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 01:51:23 2017 -0700
Temporary hack to debug the MATE grammar.
Builds on my machines, physical and virtual, crash with an assertion
failure in the MATE Lemon grammar when parsing the MATE configuration
file in bug 12161 - on Mac OS X Lion with llvm-gcc, Ubuntu 15.10 with
GCC, and on macOS Sierra with clang.
Builds on the macOS buildbot do *not* fail.
So put the result of Lemon in the MATE plugin into the release tarball,
so I can compare it with what Lemon generates on my machine.
Change-Id: I2d5ecee68535a8b4803de0bd7f02d448ab629083
Reviewed-on: https://code.wireshark.org/review/21126
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=55220d3f8dcf6b1dc14b8b21c8d8d4…
commit 55220d3f8dcf6b1dc14b8b21c8d8d4641f4733be
Author: Dhiru Kholia <dhiru.kholia(a)gmail.com>
Date: Fri Apr 14 13:24:00 2017 +0530
VRRP: Improve dissection of VRRP packets using MD5 authentication
VRRP v2 in Cisco routers can use "Keyed MD5" for IP authentication, and
such packets are now dissected slightly better.
The offset of the MD5 digest value pointed out by this patch can be
validated against Cisco's IOU software by using the IOU's "debug vrrp
auth" feature.
Sample VRRP (version 2) .pcap files can be found at,
https://github.com/kholia/my-pcaps
Change-Id: Ib421428bea9c2a074aec4594b26c76bc271fada8
Reviewed-on: https://code.wireshark.org/review/21084
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=cb1967a98209abf2c37c6e4504c6d2…
commit cb1967a98209abf2c37c6e4504c6d27e65614de0
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Fri Apr 14 22:37:10 2017 +0100
Snort: map more pcre modifiers to GRegexCompileFlags
Change-Id: I5df8cb794b7b76b708448ae4b74b7481bdd8faff
Reviewed-on: https://code.wireshark.org/review/21097
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=581db4c2b82601a93023fb3ce214b4…
commit 581db4c2b82601a93023fb3ce214b4171d7e14d9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 16 01:23:16 2017 -0700
Get rid of some generated files with "make distclean".
register.c, and the plugin.c for various plugins, are generated by tools
that must be available to do a build, and aren't distributed as part of
the source tarball. That means "make distclean" should remove them. Do
so.
Change-Id: I9e37abdafb50234cf1ebb5fb828446e45e605d78
Reviewed-on: https://code.wireshark.org/review/21125
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b88cb666040672f7ae2e5efc385722…
commit b88cb666040672f7ae2e5efc385722a28a4c1e1f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 03:17:29 2016 -0500
X11: Ensure mesa_enum value_string has unique values
Also convert usage to a value_string_ext
Change-Id: Ie515591355879f8eb65faf50e7c04b30cff13519
Reviewed-on: https://code.wireshark.org/review/21124
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c7e32fb09ca7d25ee86aeb3f627a4e…
commit c7e32fb09ca7d25ee86aeb3f627a4e5db450922b
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Mar 26 17:06:04 2017 +0200
sharkd: support for limits in sending information about rows (columns).
Suboptimal, but still much better than sending columns
for whole capture file. webshark by defaults requests for 120 rows.
Change-Id: I96188e0d2bc4539a57e5061c7784f8c44f318393
Reviewed-on: https://code.wireshark.org/review/20715
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b9edacecaf90f9151972e1f4cb1003…
commit b9edacecaf90f9151972e1f4cb1003c12032b799
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Apr 15 23:29:32 2017 +0200
Fix memleak of g_pservices_path.
Change-Id: Iaee6f3773bc3b4164935092f2c9c9c888171a5b7
Reviewed-on: https://code.wireshark.org/review/21117
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=ce50000f14da32dd2ae50f5b5efa12…
commit ce50000f14da32dd2ae50f5b5efa12333e29dfcc
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Fri Apr 14 14:46:11 2017 +0200
DICOM: Revert 3752a643ac5c85622822c88c69d83ce23828acb8
Revert commit 3752a643ac5c85622822c88c69d83ce23828acb8
to fix bug 13164 and bug 13570 introduced with this commit.
This reopens bug 13110.
Bug: 13164
Bug: 13570
Change-Id: Id237f08258ca100f675614a9cb36a32340944b3e
Reviewed-on: https://code.wireshark.org/review/21089
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cbc2c84a27f3158784238cbc4b2076…
commit cbc2c84a27f3158784238cbc4b2076618b7dc6e4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 15 14:45:12 2017 -0700
Catch attempts to pass unregistered protocols to prefs routines.
That way, you don't end up with "(none)" being used as the filter name
and getting confusing error messages.
Change-Id: Ifc77d4434d82dabebe74118742938cfa5234791d
Reviewed-on: https://code.wireshark.org/review/21118
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=237d23dc7355f066d772ba6ad184d5…
commit 237d23dc7355f066d772ba6ad184d5f99c25fa5a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 15 12:37:34 2017 -0700
Squelch some compiler warnings.
Cast an ssize_t value to unsigned int before subtracting it from an
unsigned int. The value is already known to be >= 0 and <= the value
from which we're subtracting it, and that latter value is an unsigned
int, so it's guaranteed to fit into an unsigned int. (ssize_t can be
bigger than unsigned int.)
Change-Id: I5c4d3c7fa4bf241c9ea72661beca89bc30495a3b
Reviewed-on: https://code.wireshark.org/review/21114
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3743186bcf5cd37b56f40069341565…
commit 3743186bcf5cd37b56f40069341565b4e6ad196c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Apr 15 13:13:24 2017 -0400
packet-slsk.c: Fix potential uninitialized variable.
Change-Id: Ic1ae372bb50192d4503b1d5ba02684f44a51f968
Reviewed-on: https://code.wireshark.org/review/21113
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=731d6e504dbf509b605d98fd35f483…
commit 731d6e504dbf509b605d98fd35f4837a36ed695e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Apr 14 19:58:13 2017 -0400
x11: proto_tree_add_uint_format -> proto_tree_add_uint_format_value
Change-Id: Ib8b80b2c4a79941cf56d8add783c88d1078f079a
Reviewed-on: https://code.wireshark.org/review/21104
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7e002ed84f844661159e3584b8ce37…
commit 7e002ed84f844661159e3584b8ce376e8fd792dc
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 12 07:21:12 2017 -0400
packet-slsk.c: General cleanup
1. Use FT_UINT_STRING as appropriate
2. Replace many proto_tree_add_xxx_format with proto_tree_add_item[_xxx]
Change-Id: Id9853c54074c2c033b3494b2d687df8e9fd33881
Reviewed-on: https://code.wireshark.org/review/21098
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=22ccd2ae9782cdf60ca88556eefc72…
commit 22ccd2ae9782cdf60ca88556eefc72bfbbe31e91
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Apr 15 17:34:59 2017 +0200
Add oss-fuzzshark.c tool, for integration with oss-fuzz.
Change-Id: I8a6b620c8ef1454e57db1d9a6341263ffc9fca3b
Reviewed-on: https://code.wireshark.org/review/21110
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=e66f9c7b6d597c63fb3960ce61110a…
commit e66f9c7b6d597c63fb3960ce61110a25becf8a90
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sat Apr 15 13:21:48 2017 +0200
CMake: include PKG_INCLUDE_DIR if PKG_INCLUDE_DIRS is undefined
FindLibXml2.cmake populates LIBXML2_INCLUDE_DIR and leaves
LIBXML2_INCLUDE_DIRS undefined.
Libxml2 inclusion as optional dependency is suggested in Change-Id
I13c0a2f408fb5c21bad7ab3d7971e0fa8ed7d783.
Change-Id: If49c778230e99af4b2ebb97dcb2f8acb4b55aa88
Reviewed-on: https://code.wireshark.org/review/21109
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=c2386c5b0114e1fc882ed5396d6569…
commit c2386c5b0114e1fc882ed5396d65697c491b43ed
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 22:41:33 2017 -0700
Update to the current lempar.c in the SQLite repository.
Change-Id: I86ca187a7c698541d70bab558c4073fdff28dea3
Reviewed-on: https://code.wireshark.org/review/21108
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=96c72df2dfe9c84bc2716352ebe187…
commit 96c72df2dfe9c84bc2716352ebe1876ddd8ceaf4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 22:04:49 2017 -0700
Make the set of static routines match that in the current tip SQLite.
This reduces the differences between our lemon.c and SQLite's.
Change-Id: Ie672fa564a43ffe2fae271968accfed2a864bb63
Reviewed-on: https://code.wireshark.org/review/21107
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c64ab9d355a5e9308a268ca2bc2021…
commit c64ab9d355a5e9308a268ca2bc20218fb8fe23ab
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 19:36:36 2017 -0700
Update symbols.
Change-Id: I41a075758103f0c37d30b3e764eef5f87e87234f
Reviewed-on: https://code.wireshark.org/review/21106
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d523f615beab84b9ce6224c42d8555…
commit d523f615beab84b9ce6224c42d8555c619825e31
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 19:24:05 2017 -0700
Make memory_error() a routine.
That makes the code more like Lemon as distributed.
Note that Lemon, as distributed, at least claims to have a bunch of
stuff "From the file "XXX.{c,h}", which might be the result of lemon.c
being an "amalgamation":
https://www.sqlite.org/amalgamation.html
although, unlike SQLite, the individual bits of the amalgamation don't
appear to be present in the SQLite Fossil repository, so maybe they've
been permanently glued together.
Change-Id: I361d0d16be0744b127110d7d237fdd84e30b6432
Reviewed-on: https://code.wireshark.org/review/21105
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3bd767108391e6d3498241b20e86ca…
commit 3bd767108391e6d3498241b20e86ca176dffc185
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 18:28:25 2017 -0700
Make whitespace match what's checked into the SQLite repository.
They accepted some of our changes, but with no space between "struct
XXX" and "*. Whatever.
Change-Id: I6b29462dc8b04ebf0822f8512d82f5f8df575447
Reviewed-on: https://code.wireshark.org/review/21101
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0f3e20051c5be2d8164365763e6398…
commit 0f3e20051c5be2d8164365763e63988a30aa24f4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 17:44:04 2017 -0700
Fix parsing of packet ranges.
Replace the dash in a range with a '\0', so that the first value in the
range is properly terminated.
Change-Id: Ib2807c2534c1e99e643848ca0fc32f4b78025ce3
Reviewed-on: https://code.wireshark.org/review/21099
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ccef2d8860f55d56f7662cc218defe…
commit ccef2d8860f55d56f7662cc218defe5447e226e4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 13:44:08 2017 -0700
Make prefs_register_subtree() static too.
It's not used outside epan/prefs.c, and it probably shouldn't be.
Change-Id: I8a10961a33b93db1de982eec264c134f9f3bc66c
Reviewed-on: https://code.wireshark.org/review/21096
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6dd6fc9eff40e86aba1fb3aefa119b…
commit 6dd6fc9eff40e86aba1fb3aefa119b212ddd5504
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 13:05:16 2017 -0700
Make prefs_register_module() static.
It's not used outside epan/prefs.c, and it *shouldn't* be used outside
epan/prefs.c - there are other APIs that call it, and handle the details
of picking the right name, title, description, etc..
Change-Id: Ib95b4811d50c2bf1c480f115ee998274252243c9
Reviewed-on: https://code.wireshark.org/review/21095
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dcd3d7b2a5a592a058752187760e85…
commit dcd3d7b2a5a592a058752187760e856a72b6fa6c
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Apr 14 20:04:54 2017 +0200
pcep: add registration of missing ett fields
Add registration of ett fields:
- ett_pcep_obj_unreach_destination,
- ett_pcep_obj_branch_node_capability,
Which were used since 7bca5e168817f6f665e9aaec70ca37722c7afbea.
Reorder, ett_ registration to match declaration order.
Change-Id: Ie88cf518a77e134257570a054f6173ee49f27776
Reviewed-on: https://code.wireshark.org/review/21091
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c398858205724434bfcbec0ffed1f4…
commit c398858205724434bfcbec0ffed1f4223c2c85d1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Apr 14 12:34:18 2017 -0700
Give a better error message for invalid characters in preference module names.
And make the message for an invalid character in a preference name more
like it, by putting the offending name in quotes.
Change-Id: I40db8b87eae5e46a1d49213a9a45861b6b3565af
Reviewed-on: https://code.wireshark.org/review/21092
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=74784bdb3ef60d02f6041f6ec6c3b5…
commit 74784bdb3ef60d02f6041f6ec6c3b56e3841a2db
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Apr 14 16:52:10 2017 +0200
Update Windows binaries to GeoIP 1.6.10 with a local GeoIP_free function
This solves a crash occurring when trying to free memory allocated by
GeoIP (cross-compiled with mingw(32|64)) with MSVC function
Bug: 13598
Change-Id: I757cff13660bd485d7ea91d10660e9bf86404728
Reviewed-on: https://code.wireshark.org/review/21090
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=90afc2582b4cd5a8ae75dcb9f6e193…
commit 90afc2582b4cd5a8ae75dcb9f6e19330a28aa5f9
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Fri Apr 14 10:14:09 2017 +0200
Units: add millibel unit string
Add millibel unit string, for wireless and optical power useage.
Change-Id: I7fe98fbeea7431fb74db57d2253ea78813379629
Reviewed-on: https://code.wireshark.org/review/21083
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1928592b91d2b4b32b8e48fc2762fc…
commit 1928592b91d2b4b32b8e48fc2762fc92b582265e
Author: Patryk Nowak <patryk.nowak(a)tieto.com>
Date: Fri Apr 14 12:33:12 2017 +0200
Bluetooth: HCI: fix dissection of command Enhanced Setup Synchronous Connection
Change-Id: I6f66b583f50da841eb67eb1995b637db327be6a9
Reviewed-on: https://code.wireshark.org/review/21088
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bf5fd112bcfdafa9050c1fcd88aaa2…
commit bf5fd112bcfdafa9050c1fcd88aaa29cff0f34d4
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Thu Apr 13 16:34:49 2017 +0200
Functions that put large amounts of static data onto the stack may be
worth looking at every now and then.
The value of 16384 is the same as the default in VS.
Change-Id: I68fd51e373437088f59c1e197d1a889f856caded
Reviewed-on: https://code.wireshark.org/review/21030
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=77e67a3e8a2e7bb8ac481f5e013009…
commit 77e67a3e8a2e7bb8ac481f5e01300915de3cde95
Author: sswsdev <sswsdev(a)gmail.com>
Date: Thu Apr 13 20:42:46 2017 +0300
UMTS RLC: Fixing incorrect direction
Using 'link_dir' instead of 'p2p_dir'
Change-Id: I98c0b98396a6fe3b6d4c5243e1abb33edff43229
Reviewed-on: https://code.wireshark.org/review/21080
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=166c9cfe3240b4185532f28c5175d3…
commit 166c9cfe3240b4185532f28c5175d32fadb3ebf3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Apr 14 11:09:01 2017 +0200
Diameter: update Reservation-Priority AVP values
Change-Id: I5609385ee0a13fe5262a35ac65e206f0bc492a61
Reviewed-on: https://code.wireshark.org/review/21085
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c8dd3a1141ede3b238597b3026d2fa…
commit c8dd3a1141ede3b238597b3026d2fa09d8b7c321
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 13 18:24:46 2017 +0200
mate: move 3 big structures from stack to heap
Change-Id: I03bdb1f17c8c8b79cc78e37b14ac4e959f1ed089
Reviewed-on: https://code.wireshark.org/review/21078
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3a8db34f01c0b5553e1d5643951608…
commit 3a8db34f01c0b5553e1d5643951608f81ad48597
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 13 18:25:48 2017 -0700
Remove some unused code.
It's copied-and-pasted from {somethingelse}shark.c, such as tshark.c;
it's not needed here.
Fixes CID 1405103.
Clean up indentation while we're at it.
Change-Id: Ia3ab41f64f055fcebeac6e49ebf5f5581125b960
Reviewed-on: https://code.wireshark.org/review/21082
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=32c9c08471495616d5a8da8f1c16ba…
commit 32c9c08471495616d5a8da8f1c16ba486a578b99
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 13 17:31:58 2017 +0200
LBMC: move lbmc_extopt_reassembled_data_t structure from stack to heap
This structure contains an array of 65536 bytes.
Change-Id: Ied2c584100cb613dc195fbc5de7ae9a5ec5b770b
Reviewed-on: https://code.wireshark.org/review/21077
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eff51c6076ad6ffb72aedcac8dc0d3…
commit eff51c6076ad6ffb72aedcac8dc0d3b3723fd556
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 13 20:02:48 2017 +0200
sharkd: reduce buffer put on stack from 16K to 2K
Change-Id: Ie86f68ed48b881f4803377a3e1ad94fcfe1947e3
Reviewed-on: https://code.wireshark.org/review/21079
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=3fefb191680e55294bc4d1f45f541b…
commit 3fefb191680e55294bc4d1f45f541b15c8df2ae0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Apr 13 14:46:08 2017 -0700
Update to GeoIP 1.6.10.
That's the most recent version of the GeoIP legacy API.
GeoIP 1.6.1, and later, are available from GitHub, but not from
MaxMind's Web site.
Change-Id: I67b1b5b47761beac2fc303e18e39d9accac86e3b
Reviewed-on: https://code.wireshark.org/review/21081
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3f71262bb1e7dd0b0fe062b6ec20f2…
commit 3f71262bb1e7dd0b0fe062b6ec20f2cb2291255a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Apr 12 21:07:20 2017 +0200
netlink (sock_diag): Fix Dead Store (Dead assignement/Dead increment) Warning found by
Clang
The payload dissection should start after the header, so do not reset offset.
Fixes: v2.3.0rc0-3039-g92ebd63892 ("netlink: let subdissectors handle the netlink
header")
Change-Id: I6bdfdd967bc56cb99c07f4f151ef96592e18a508
Reviewed-on: https://code.wireshark.org/review/21057
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0c597f111ffaacd12c1f1e46c0bfdd…
commit 0c597f111ffaacd12c1f1e46c0bfddcdfdec5b02
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Apr 13 16:59:22 2017 +0200
[GSM MAP] Update to 3GPP TS 29.002 V14.3.0 (2017-03).
Change-Id: I97a4ee7cdcb8644a4f2e3f108842d4c28d788c54
Reviewed-on: https://code.wireshark.org/review/21076
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4e56c063b462837202d6c37adbdc4c…
commit 4e56c063b462837202d6c37adbdc4c0726a25024
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Apr 13 13:17:41 2017 +0200
LTE RRC: do not display twice RRCConnectionReestablishmentReject in info column
Bug: 13595
Change-Id: I5d1537afea7f5a2dddd5e11a06c451ec00913d12
Reviewed-on: https://code.wireshark.org/review/21073
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8bbdece59b2d7c0b81869a4b0fd99…
commit f8bbdece59b2d7c0b81869a4b0fd991e74e162ab
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 12 22:40:32 2017 -0400
Bugfix bad checksum of ICMP extension header.
Use offset in tvb, not 0 for computation.
Also add check for checksum = 0, which means checksum isn't present.
Bug: 13586
Change-Id: I18812894104c35e50ecb99aa8eca6b030c78c486
Reviewed-on: https://code.wireshark.org/review/21070
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a96dc7bdd580fdbe4934b5de483742…
commit a96dc7bdd580fdbe4934b5de483742689b553a0a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 12 11:15:08 2017 -0400
Require MLE to have IEEE802.15.4 as an underlying layer.
MLE runs over UDP, but presumes IEEE802.15.4 is also an underlying layer.
Enforce it by ensuring IEEE802.15.4 protocol data is present.
Bug: 13589
Change-Id: I5fd54244499980637c121f5f8d1fb2d152d31c73
Reviewed-on: https://code.wireshark.org/review/21053
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6c096f31ac6bbe2f0b7e0fd43dddb5…
commit 6c096f31ac6bbe2f0b7e0fd43dddb5419a8b2a3d
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Wed Apr 12 19:36:27 2017 +0200
packet-epl.c: Fix bigger-than-actual offset being reported
dissect_epl_asnd_nmtdna returns the offset + 27,
adding that to the original offset isn't correct,
unless the offset was 0 to begin with, which isn't the case.
Change-Id: Id0d5043b23a83aef8d07a6f6ee3b70486d913e9f
Reviewed-on: https://code.wireshark.org/review/21056
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d7320989a03e3ac5a21bc04a1d471b…
commit d7320989a03e3ac5a21bc04a1d471be8584413d0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Apr 12 21:16:27 2017 +0200
zbee zcl: fix conflicting entry in its value_string
Field 'Command' (zbee_zcl_general.applctrl.execcmd.id) has a conflicting entry
in its value_string: 4 is at indices 4 (Start Superfreezing) and 5 (Stop Superfreezing))
Field 'Meter Type ID' (zbee_zcl_ha.metidt.attr.meter_type.id) has a
conflicting entry in its value_string: 0 is at indices 0 (Utility Primary Meter) and 2
(Data Quality ID))
Change-Id: I9e92a5c58aea0d6ef00e8d5f61fdfb073b41ee80
Reviewed-on: https://code.wireshark.org/review/21058
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e5a120a570ae4abbfde6f60bdb719b…
commit e5a120a570ae4abbfde6f60bdb719b91625ac5ed
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Apr 12 21:19:24 2017 +0200
unistim: fix conflicting entry in its value_string
Field 'Stream Based Volume ID' (unistim.stream.volume.id) has a conflicting
entry in its value_string: 111 is at indices 0 (C1=0xFF00 C2=0x00 C3=0x00 c4=0x00 Steady
on. -13 dBmO per frequency.) and 1 (C1=0x0505 C2=0x0505 C3=0x0505 c4=0xFF00 3 burst(0.1
sec on,0.1 sec off),Then steady on.-13 dBmO per frequency.))
Change-Id: I49f50688b9e68d597190d891b114eea1ff3e4858
Reviewed-on: https://code.wireshark.org/review/21059
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9769e8af992ef1585492884c794cc9…
commit 9769e8af992ef1585492884c794cc95ff9c38cca
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 12 17:09:39 2017 -0700
Use proto_get_finfo_ptr_array() rather than proto_find_finfo().
As the comments say, proto_find_finfo() is slower than
proto_get_finfo_ptr_array(), as it has to scan the entire tree, and,
given that we're priming the tree with the fields we need (which we
*have* to do to *guarantee* that we'll get the fields we want;
requesting that a protocol tree be constructed isn't sufficient, and
asking for a "visible" protocol tree is overkill),
proto_get_finfo_ptr_array() will work.
Change-Id: Ic1e21105a0a89003a3cdd3d7a2e55ac287ddad5e
Reviewed-on: https://code.wireshark.org/review/21068
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=37e45ccba85656a2d33a8c5e1e7d8c…
commit 37e45ccba85656a2d33a8c5e1e7d8cdde815badb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 12 16:44:51 2017 -0700
Fix indentation.
Change-Id: Idc3d9c40a5f8ecd0f192c289538c3303ba2b7ffe
Reviewed-on: https://code.wireshark.org/review/21067
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=847c25c5a7e7c5653870c4bd60625d…
commit 847c25c5a7e7c5653870c4bd60625da1c64c86f1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 12 13:52:07 2017 -0700
Prime the epan_dissect_t with postdissector wanted fields if necessary.
This makes sure that postdissectors that indicate that they need certain
fields in the first pass will get them.
While we're at it:
Fix the field-fetching code in TRANSUM not to assume it got any
instances of the field being fetched.
Rename process_packet_first_pass() in sharkd to process_packet(), as
it's the only routine in sharkd that processes packets.
Rename process_packet() in tshark and tfshark to
process_packet_single_pass(), as it's what's used if we're only doing
one-pass analysis.
Clean up comments and whitespace.
Change-Id: I3769af952c66f5ca4b68002ad6213858ab9cab9b
Reviewed-on: https://code.wireshark.org/review/21063
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=74f9b279e9888b0449b569a1c47435…
commit 74f9b279e9888b0449b569a1c474351ccc991d5e
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Wed Apr 12 13:17:31 2017 +0100
Changes to Connectivity TLV for Thread v1.1 plus a couple of minor
bugfixes.
Change-Id: I7c42ddabea263bb15178a71014b6e25eb690cc4c
Reviewed-on: https://code.wireshark.org/review/21042
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c587edb41b189350802731a55df9fa…
commit c587edb41b189350802731a55df9faafb7c63d24
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Apr 12 07:34:31 2017 -0400
packet-thread.c: rename remainder -> remaining
Pacify macOS buildbot
Change-Id: I60bdb0ca7b9a1456d6fe12879dec61c5dff19e53
Reviewed-on: https://code.wireshark.org/review/21039
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ccdb9073cdf1eee198e383ac202cb3…
commit ccdb9073cdf1eee198e383ac202cb370bb0af6ce
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 11 16:21:55 2017 +0200
ieee80211: fix "INVALID" label in Endpoints dialog
Problem: the "Apply as filter" option in the Endpoints dialog creates
the "INVALID==11:22:33:44:55:66" filter for IEEE 802.11 packets.
Since dissect_ieee80211_common initialises the address "whdr->src" and
"whdr->dst" fields using the "wlan_address_type" type, we have
to do the
same in "wlan_host_get_filter_type". While at it, remove the check for
AT_ETHER since these will never match.
Change-Id: I43f9298adfa406ea37a383187137e3e0c1f8733d
Reviewed-on: https://code.wireshark.org/review/21015
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=75d40599b04d69a0857418ac7b7ada…
commit 75d40599b04d69a0857418ac7b7adac1266420dc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 12 01:56:21 2017 -0700
No need to include <epan/packet.h> in <epan/ftypes/ftypes-int.h>.
It's sufficient to include <epan/proto.h>...
...as long as <epan/proto.h> includes <epan/tfs.h>, just as it includes
<epan/value_string.h>.
And, since it's already including <epan/value_string.h>, it doesn't
need
to have a definition of struct _value_string as an incomplete type,
given that <epan/value_string.h> gives a definition of it as a complete
type.
Change-Id: Ic296bc0b0d68277ba7e0569412b780fd847ecca2
Reviewed-on: https://code.wireshark.org/review/21033
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6fb9ee21495a06ece8681e81872dd…
commit c6fb9ee21495a06ece8681e81872dd23d0d4be85
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 6 21:22:39 2017 +0100
Add -Wduplicated-branches to extra warnings
Change-Id: I11d60b4405f4fde039affcdeebb13a3ceb2aded6
Reviewed-on: https://code.wireshark.org/review/20428
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5be11a5984c32e592e773c30493428…
commit 5be11a5984c32e592e773c3049342861d4f30db1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 12 10:24:12 2017 +0200
GSM SMS: also consider source and destination address for reassembly
Change-Id: I68ca00c970828311392565882bd7e4803df9818a
Reviewed-on: https://code.wireshark.org/review/21032
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4d2d42310610e736f23466472ca5dd…
commit 4d2d42310610e736f23466472ca5dd70b7655c7f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 11 21:56:14 2017 -0700
Rename routines to clarify what they do.
XXX_prime_with_YYY makes it a bit clearer than does XXX_prime_YYY that
we're not priming YYY, we're priming XXX *using* YYY.
Change-Id: I1686b8b5469bc0f0bd6db8551fb6301776a1b133
Reviewed-on: https://code.wireshark.org/review/21031
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c0792555392f234ab96917e784d365…
commit c0792555392f234ab96917e784d365b5de053836
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 11 19:53:48 2017 -0700
Add an API to let a postdissector specify fields whose values it needs.
Currently, this is only used to determine whether a protocol tree needs
to be built on the first pass or not - if there are postdissectors that
need fields, it does - but eventually we should be able to use it to
prime the dissection to deliver those fields in cases where we don't
need the *entire* protocol tree (rather than using a hack such as
cooking up a fake tap with a fake filter to do that).
Update MATE and TRANSUM to use it.
Clean up code to check whether we need a protocol tree, and add comments
before that code indicating, in each case, what the criteria are.
The array of postdissectors includes a length, so we don't need to
separately keep track of the number of postdissectors.
Clean up indentation while we're at it.
Change-Id: I71d4025848206d144bc54cc82941089a50e80ab7
Reviewed-on: https://code.wireshark.org/review/21029
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=aa9a0b3bf831395dc1cfbaea7f467f…
commit aa9a0b3bf831395dc1cfbaea7f467faed952dbf9
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 31 18:14:38 2017 +0200
cmake: fix sporadic WSDG build failure on Windows
The Windows builds (using msbuild) fail sporadically when building
documentation (target developer_guides). The problem is that the targets
"developer_guide_pdf_a4" and "developer_guide_html" both depend
on
developer-guide.xml and msbuild does not notice that the file has
already been generated by the generate_developer-guide.xml target.
For a discussion of the problem, see
https://gitlab.kitware.com/cmake/cmake/issues/16767
To fix this, remove the "developer-guide.xml" dependency from
"developer_guide_xyz" (to prevent these targets from triggering building
"developer-guide.xml"). Instead, depend on a generated
"developer-guide.xml-stamp" file which is created by the
"generate_developer-guide.xml" target (but do *not* add it as output of
this target, otherwise we will have the original problem again).
This workaround is restricted to the MSVC generators because otherwise
it would trigger a CMP0058 policy warning when used with Ninja.
Change-Id: Idb3975cde35be2601b038a500d4886bbd3a684d7
Reviewed-on: https://code.wireshark.org/review/20812
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a71811af0de3ca9e7b5569f6e0f43d…
commit a71811af0de3ca9e7b5569f6e0f43dc7d4052d02
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 11 15:31:15 2017 -0400
packet-wsp.c: Fix WSP dissector loop (add_capabilities)
Bug: 13581
Change-Id: I8b9f2df47fabb25d8851debc616fee1091d49f31
Reviewed-on: https://code.wireshark.org/review/21018
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a445efdd03afd90ec0e849be4f7e46…
commit a445efdd03afd90ec0e849be4f7e46f28d2dedb7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 11 16:14:20 2017 -0400
packet-sigcomp.c: Fix sigcomp dissector loop
Bug: 13578
Change-Id: I92892a74adea49b71670b4dca57dd52e13537bd5
Reviewed-on: https://code.wireshark.org/review/21019
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9830eadad0d850aa3318120120f5ef…
commit 9830eadad0d850aa3318120120f5ef5b2d66337b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 11 16:38:35 2017 -0400
packet-slsk.c: Fix (many potential) SLSK long dissector loops
Bug: 13576
Change-Id: I9a0f6c6b682877ed7b5ce4b6b249d4aa4034096a
Reviewed-on: https://code.wireshark.org/review/21020
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0d040f699cb62e621709ede912ae0b…
commit 0d040f699cb62e621709ede912ae0bf939e2daaf
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 11 16:57:30 2017 -0400
packet-asterix.c: Make hf_021_230_RA FT_DOUBLE type
Bug: 13580
Change-Id: I4861c9b69bafe72ecb44e57c9be393506fb9715b
Reviewed-on: https://code.wireshark.org/review/21021
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=73e24b31de073dfbc7a3e89a811e99…
commit 73e24b31de073dfbc7a3e89a811e99b104f1b5df
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 11 18:13:48 2017 +0200
Qt: mark bool and enum prefs as changed when modified via the menu
When preferences are modified, these must be marked to ensure that the
"prefs_changed" callback for Lua dissectors is invoked.
Bug: 13536
Change-Id: Ib93b2920ebefbc1532d3c6cd097f802a45ec6f35
Reviewed-on: https://code.wireshark.org/review/21016
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=692461033b9d17b299d4d2fc8bdf3f…
commit 692461033b9d17b299d4d2fc8bdf3fb364ab7b47
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Mon Apr 10 12:06:52 2017 +0200
NOE: fix "EVT_DEVICE_PRESENCE" message decoding
Change-Id: Ib4c7cee28586a9506b94f4cd28ed6417809f76ce
Reviewed-on: https://code.wireshark.org/review/20952
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=14a1e1c9b4d8a213920dd38ff65841…
commit 14a1e1c9b4d8a213920dd38ff65841280763a83b
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Apr 10 10:13:36 2017 +0200
Fix is_broadcast_bssid() for GCC.
This seems to be working for clang, but with gcc bssid_broadcast.data
don't have FFs, and is_broadcast_bssid() fails.
Change-Id: I69bdd91fe1838ab1f2a22a082a460c6cb3e34616
Reviewed-on: https://code.wireshark.org/review/20989
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=90c2e34cbd988179187422b48f8d9f…
commit 90c2e34cbd988179187422b48f8d9f28e4f0e9ed
Author: Mathias Kurth <mathias.kurth(a)commsolid.com>
Date: Mon Apr 10 10:45:08 2017 +0200
NB-IoT SRB1bis implementation
Change-Id: If0c9dd3f3ca2321aaf9176330299a32f611d34ce
Reviewed-on: https://code.wireshark.org/review/20990
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87fc4cc5d7d7838d9fb708ca0c0016…
commit 87fc4cc5d7d7838d9fb708ca0c00166014d4ace8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Apr 11 11:23:03 2017 +0200
GSM SMS: take into consideration TP-OA/TP-DA fields and direction for reassembly
Bug: 13572
Change-Id: Ieb1b972f95bc5c445597dd9aa2a0d8e7e9985238
Reviewed-on: https://code.wireshark.org/review/21013
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5bcd2f681e1507d7a9ddcfc89b5303…
commit 5bcd2f681e1507d7a9ddcfc89b5303178f9b7e75
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Apr 3 02:32:03 2017 +0200
Initial support for Generic Netlink (genl) dissection
For consistency with other netlink dissectors, the file is named
"netlink-generic", but the short protocol name is "genl" for
brevity.
Ping-Bug: 13561
Change-Id: I6f94454f8366467fd833c3e57364c515aee9e86f
Reviewed-on: https://code.wireshark.org/review/20875
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4eed07af89716db99203d4afd9a3c2…
commit 4eed07af89716db99203d4afd9a3c20232a990af
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 16:03:43 2017 +0100
sctp: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: Ia2cca91f03f312b0163848917f04bb5e17baf876
Reviewed-on: https://code.wireshark.org/review/20692
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a265283f12c2354ff9b84f877142b1…
commit a265283f12c2354ff9b84f877142b176212856a2
Author: Rémy Léone <remy.leone(a)gmail.com>
Date: Mon Mar 20 15:39:31 2017 +0100
Simplify filter and 6Top commands
- Change internal variables to have shorter and explicit name
- Add extra item to perform filtering
Change-Id: I84a55540d552ffba6c935eb0bc2d24b7859be1b6
Reviewed-on: https://code.wireshark.org/review/20928
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6b30fe1ce5014ec332cf8c2f483f9f…
commit 6b30fe1ce5014ec332cf8c2f483f9f1c519e0167
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Apr 10 23:26:07 2017 -0400
packet-icmp.c: Remove tree check that prevents expert info
proto_tree_add_checksum uses expert info and shouldn't be
"NULL tree protected"
Change-Id: If8a367c2be69252e9c6613329b7f78ad7e1e34eb
Ping-Bug: 13586
Reviewed-on: https://code.wireshark.org/review/21012
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=069c15ccb94e2d2657f21a90017157…
commit 069c15ccb94e2d2657f21a9001715732fdfd927c
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Mon Apr 10 20:18:27 2017 +0200
LDP: Add Entropy Label Capability TLV
s. https://tools.ietf.org/html/rfc6790#section-5.1
Bug: 13584
Change-Id: I1271b154960d7c46f9d0776a431beab3290c2871
Reviewed-on: https://code.wireshark.org/review/21007
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=14ba81598da88390d26d3082da7357…
commit 14ba81598da88390d26d3082da735743d6d41074
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Fri Mar 17 16:59:23 2017 +0000
MLE and Thread: Additional dissectors
Additional dissectors for Mesh Link Establishment (MLE) and Thread CoAP
TMF messages. MLE is also used in ZigBee IP.
Change-Id: I5b9c224d7df48855b79ccac67dca7661a51d0a9b
Bug: 13495
Reviewed-on: https://code.wireshark.org/review/20594
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=043df01c5645378bd61318c20cfdbf…
commit 043df01c5645378bd61318c20cfdbf86c8f73288
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 06:42:03 2017 -0400
Add support for BASE_VALS_NO_UNKNOWN
BASE_VALS_NO_UNKNOWN is a special value_string value for only a single
(maybe 2) numerical value(s). If a field has the numerical value
that doesn't match anything in the value_string, just the number
is supplied for the field (no "Unknown")
Dissectors that had this use case have been converted in the patch.
Change-Id: Ie63a36cceec2fe4436938ec7e3d7f9e690d2b8d9
Reviewed-on: https://code.wireshark.org/review/20736
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ded9ad7017a9b04a9f63c9ea91961d…
commit ded9ad7017a9b04a9f63c9ea91961d19ff6b395e
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Fri Mar 17 11:52:27 2017 +0000
IEEE 802.15.4: Add support for Thread, MLE and ZigBee IP
Enhancements to security processing add support for Thread, MLE and ZigBee
IP. Thread and ZigBee IP use a hash for key derivation for MAC and MLE
security processing. Thread additionally uses a sequence counter.
Ping-Bug: 13495
Change-Id: Ib8351b21e5615cd44880f5126f59fd0dc0a11742
Reviewed-on: https://code.wireshark.org/review/20585
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2321a92ccc339cd2103f75f190df04…
commit 2321a92ccc339cd2103f75f190df045d7c631051
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 10 11:44:17 2017 +0200
PacketBB: do not add more bytes to the protocol tree than the real addr array length
Bug: 13559
Change-Id: I612a7e2c104603a0aa14a0775bf9b8d247069398
Reviewed-on: https://code.wireshark.org/review/20992
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fa97a31dd4754724a53658cd26adee…
commit fa97a31dd4754724a53658cd26adeefb29c2b246
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 10 14:26:00 2017 +0200
RTPproxy: use tvb_format_text() to add text to info column
Otherwise you can have put multiple lines in the info column when a
packet is wrongly identified as RTPproxy (TCP connection using the
default RTPproxy port for example)
Bug: 13582
Change-Id: I817f67d5fc8c0d5f9d252f0f949af715bfc0ef56
Reviewed-on: https://code.wireshark.org/review/21000
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Lemenkov <lemenkov(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=82442d788facb7592ad9dec581d895…
commit 82442d788facb7592ad9dec581d895adec52bfc3
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Apr 10 13:12:14 2017 +0200
[SGSAP] Add a cause value.
Change-Id: I62c04933fa0f80c2e4af8a885554328cc9fc50a7
Reviewed-on: https://code.wireshark.org/review/20995
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2861b38153b9d78f6129081bc7dd50…
commit 2861b38153b9d78f6129081bc7dd50e853ca1a0e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 10 10:13:33 2017 +0200
NBAP: fix malformed packet error when having a single byte BindingID
The tvb length must be checked before trying to read 2 bytes
Bug: 13577
Change-Id: I8ba8320b3a0a96239e52a36bc09bb6b41e65a657
Reviewed-on: https://code.wireshark.org/review/20991
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d10421a39a1a3a7c05ac4814ca08a7…
commit d10421a39a1a3a7c05ac4814ca08a70830e18f11
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 10 09:41:08 2017 +0200
WSP: fix addition of x-up-proxy-tod in tree
Regression introduced in gcf7979c
Bug: 13579
Change-Id: Ia2c0d95eec45937ffcdbee52022466a30ebab1f8
Reviewed-on: https://code.wireshark.org/review/20988
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=77c580d30d785d94a489a54fdc587e…
commit 77c580d30d785d94a489a54fdc587e1ea2d77709
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Apr 10 08:14:10 2017 +0200
dpnet: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I874ce616ef2b3d7eac0d7b034c83c0b7ac8ac731
Reviewed-on: https://code.wireshark.org/review/20987
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=69ccb66581c21a3bac2bd7838cf494…
commit 69ccb66581c21a3bac2bd7838cf494332df7b5a3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Apr 10 08:11:38 2017 +0200
noe: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I7a20dd07b378dbd27122b3a92b1bfa9bdb5b5d4d
Reviewed-on: https://code.wireshark.org/review/20986
Reviewed-by: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b8acaac91b7f82274113ad53b810d8…
commit b8acaac91b7f82274113ad53b810d8935696aa3e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Apr 10 11:45:03 2017 +0200
bthci_cmd: fix this statement may fall through [-Werror=implicit-fallthrough] found by
gcc7
Change-Id: Id18a0879114f11acb1db8dea8d94a1fb845b5e58
Reviewed-on: https://code.wireshark.org/review/20993
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8344f5a6919d04376fe06db8db36fe…
commit 8344f5a6919d04376fe06db8db36fe430e327371
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Apr 10 11:47:39 2017 +0200
dns: fix this statement may fall through [-Werror=implicit-fallthrough] found by gcc7
and add also a missing (optional) break after default
Change-Id: I03d594db4702ccb4ebab3fca6b071d323e7f8d39
Reviewed-on: https://code.wireshark.org/review/20994
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6b802f3c26818d91071ee242667ef5…
commit 6b802f3c26818d91071ee242667ef5bee696adba
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Date: Fri Apr 7 14:52:19 2017 +1000
dpnet: Use a bitfield for the Enum Reponse description flags
Change-Id: I296c032a48c103e32fe886a317fddf7a52bff6c9
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Reviewed-on: https://code.wireshark.org/review/20959
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=58406cf936b8c0dc7d6e4c908440fe…
commit 58406cf936b8c0dc7d6e4c908440fedbac259e90
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun Apr 9 19:47:22 2017 +0200
SSH: display protocol without carriage return / newline
Add protocol to tree without carriage return / newline bytes
Bug: 13574
Change-Id: I757a0a3b034943da7f42557a96cdb10a45627dc7
Reviewed-on: https://code.wireshark.org/review/20981
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6b3714254d41f4e18ecc1df017804c…
commit 6b3714254d41f4e18ecc1df017804c9d94d21d9b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 9 12:27:57 2017 -0700
Pull all the "load settings" calls into a epan_load_settings() routine.
That way, nothing using libwireshark needs to know what settings need to
be loaded, they just call epan_load_settings().
Change-Id: I9390e259e286fc4f5acaeaac2767e4c3c4b656af
Reviewed-on: https://code.wireshark.org/review/20983
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7d5ce06cbe35f3f818695c87e5b0f4…
commit 7d5ce06cbe35f3f818695c87e5b0f42172ee3784
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 9 02:01:05 2017 -0700
Pull the error reporting into {read,save}_filter_list.
Change-Id: I4d9582661f2f1728d400eeb2a1b1dea98f32ce7f
Reviewed-on: https://code.wireshark.org/review/20982
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1abbb503e4242f56921b7ee950f185…
commit 1abbb503e4242f56921b7ee950f185711e9f85c0
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 31 18:13:01 2017 +0200
cmake: fail if ENABLE_CHM_GUIDES but HTMLHelp is unavailable
While "cmake -DENABLE_CHM_GUIDES=ON" succeeds on Linux, the actual build
fails. Since the default for ENABLE_CHM_GUIDES is OFF, let's fail early
when ENABLE_CHM_GUIDES is requested.
When hcc.exe is found, do report the package as available.
Change-Id: If6fc3eb18f1150c251e2886f1f16277669f8ec25
Reviewed-on: https://code.wireshark.org/review/20811
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=05c501373d01ae087d697940d1818c…
commit 05c501373d01ae087d697940d1818cdf7acd7839
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Apr 9 10:00:45 2017 -0700
[Automatic update for 2017-04-09]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I147cbfa4c9cca70ad581d2e3c149473afd243086
Reviewed-on: https://code.wireshark.org/review/20978
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1fd23e21a5fa3b91a45c85e980ef00…
commit 1fd23e21a5fa3b91a45c85e980ef006bf8cfe0f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 21:50:48 2017 -0700
We use libui with dumpcap, which is built PIE, so libui should be, too.
Change-Id: Ic469517dc414e1eb62b27b6d2b0b0a7837790bf9
Reviewed-on: https://code.wireshark.org/review/20975
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=77cad8561cec1699d7a4317e34c559…
commit 77cad8561cec1699d7a4317e34c5590d566c9eb8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 21:24:45 2017 -0700
Move the filter file reading code to libui.
It doesn't belong in libwireshark, as it doesn't affect dissection, but
it *does* belong in libui, as it's helper code for the UIs.
Change-Id: I8a5e0640a299a08e9ec1917dd253197438ebfdbc
Reviewed-on: https://code.wireshark.org/review/20974
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=62b342443ddf2e5089c9cbaf137dc6…
commit 62b342443ddf2e5089c9cbaf137dc6a81b0b4678
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 20:02:53 2017 -0700
Pull the error-reporting code for preference files into read_prefs().
No need to duplicate it in N different programs.
Update comments while we're at it.
Change-Id: I3096cbe5448a19363eff6303bdd54e522dae9336
Reviewed-on: https://code.wireshark.org/review/20973
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f0a24bee898d71c7c005d68b97d47b…
commit f0a24bee898d71c7c005d68b97d47b16f7778f1c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 19:54:08 2017 -0700
Have vwarning_alert_box() pop up a warning, not an error.
Change-Id: I993133931af222c94f4a8814583fef97e49542ca
Reviewed-on: https://code.wireshark.org/review/20972
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ed6f23406b3c3a971908b458772561…
commit ed6f23406b3c3a971908b45877256170cd047af4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 19:42:57 2017 -0700
Fix routine name.
Change-Id: I3c1e4080c28d0d14eaf7ecfb5540c53f8736703c
Reviewed-on: https://code.wireshark.org/review/20971
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=23a7890b6a2133a559fc691c865e61…
commit 23a7890b6a2133a559fc691c865e617c19b26a7a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 18:59:17 2017 -0700
Pull the code to save enabled/disabled lists into libwireshark.
It's identical in the GTK+ and Qt UIs, and it should just be done in
libwireshark.
Rename some routines to just speak of enabled_and_disabled_lists, so we
don't have to say enabled_and_disabled_protos_and_heuristic_dissectors
or something such as that.
Clean up indentation.
Change-Id: Ief2e612d9e1b60d8d0123b6bd3409dce5faf6495
Reviewed-on: https://code.wireshark.org/review/20970
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=92ebd6389203448168a2769fa473bb…
commit 92ebd6389203448168a2769fa473bbbad95ec159
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 4 21:30:45 2017 +0200
netlink: let subdissectors handle the netlink header
Let subdissectors handle parsing and addition of the Netlink header
instead of doing this before calling subdissectors. After this patch:
- Protocol filters like "netlink-netfilter" can be used to match
packets (previously only a text item was added to the tree).
- Subdissectors have more freedom in modifying the type field, so now
it shows the correct type directly rather than "Message type:
Protocol-specific".
- netfilter: the type fields are now actually linked to a tvb,
previously it was linked to a NULL tvb.
- netfilter: fix unintended rejection of packets (the length should
have been added to the offset, otherwise it would fallback to the
data dissector).
- Now subdissectors will not be called for control messages (so the
netlink-conntrack.pcap sample now shows "Netlink" instead of
"Netlink
route" for the "End of dump" control message).
Change-Id: I2ab1bef91fb0080664195b281a6a45c9702914e5
Reviewed-on: https://code.wireshark.org/review/20910
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0add542dbfc6d0467d14ebb2abbde0…
commit 0add542dbfc6d0467d14ebb2abbde0ebd1427ce1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Apr 4 13:13:59 2017 +0200
netlink: add helper for dissecting an array of attributes
From https://wiki.linuxfoundation.org/networking/generic_netlink_howto
"Arrays can be represented by using a single nested attribute as a
container with several of the same attribute type inside each
representing a spot in the array."
This patch adds a helper function to dissect such a type (it will be
used by Generic Netlink for CTRL_ATTR_OPS and CTRL_ATTR_MCAST_GROUPS).
Change-Id: I60537712f7fb0f9d4fb8850c6c8eef590635f49f
Reviewed-on: https://code.wireshark.org/review/20903
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=802479d23798c6d180fad50e95555b…
commit 802479d23798c6d180fad50e95555b49b3d337cb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 15:26:32 2017 -0700
Update symbol lists.
Change-Id: I5bd2aaaa28923a6fb5f0954e306cf0fc0c6dca5a
Reviewed-on: https://code.wireshark.org/review/20969
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a5fadc99ff9f40163747891566be7f…
commit a5fadc99ff9f40163747891566be7f1ddff73907
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 14:59:31 2017 -0700
Link dftest with libui.
No need to select one source file from libui and build it independently;
just go ahead and link.
Change-Id: I7ae5d8f9b83832518a4fb3430cb348e8c4d6b7ab
Reviewed-on: https://code.wireshark.org/review/20968
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8f2b1bf9cabf9064b34374186481d0…
commit 8f2b1bf9cabf9064b34374186481d0572e85cd28
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 14:44:00 2017 -0700
Link rawshark with libui.
No need to select one source file from libui and build it independently;
just go ahead and link.
Change-Id: Ie451b736411bcdac52ccde56f329c933a0065ead
Reviewed-on: https://code.wireshark.org/review/20967
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2c44a7f930967335b442e899c17e1e…
commit 2c44a7f930967335b442e899c17e1eb46831e3c1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 8 12:45:19 2017 -0700
Clean up handling of enabled/disabled protocols/heuristic dissectors.
Add a "report a warning message" routine to the "report_err" code
in
libwsutil, and rename files and routines appropriately, as they don't
only handle errors any more.
Have a routine read_enabled_and_disabled_protos() that reads all the
files that enable or disable protocols or heuristic dissectors, enables
and disables them based on the contents of those files, and reports
errors itself (as warnings) using the new "report a warning message"
routine. Fix that error reporting to report separately on the disabled
protocols, enabled protocols, and heuristic dissectors files.
Have a routine to set up the enabled and disabled protocols and
heuristic dissectors from the command-line arguments, so it's done the
same way in all programs.
If we try to enable or disable an unknown heuristic dissector via a
command-line argument, report an error.
Update a bunch of comments.
Update the name of disabled_protos_cleanup(), as it cleans up
information for disabled *and* enabled protocols and for heuristic
dissectors.
Support the command-line flags to enable and disable protocols and
heuristic dissectors in tfshark.
Change-Id: I9b8bd29947cccdf6dc34a0540b5509ef941391df
Reviewed-on: https://code.wireshark.org/review/20966
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f1751ef22fc9877e59fad3b1c60826…
commit f1751ef22fc9877e59fad3b1c60826bff8569d94
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Apr 8 19:34:24 2017 +0200
checkhf: handle C++-style comments
"tools/checkhf.pl epan/dissectors/packet-umts_fp.c" gave this error:
Complex regular subexpression recursion limit (32766) exceeded at tools/checkhf.pl
line 273.
This is caused by the comment "// ... Indicator's ..." which failed to
match the single-quoted string and caused "catastrophic backtracking".
Solution to fix this case is to disallow unescaped newlines (add "\n" to
the negated character class). Additionally, add logic to remove
C++-style comments for completeness.
Tested against all epan/dissectors/packet-*.c files, the only difference
in output is this umts_fp case, the running time has not regressed.
Change-Id: I7b43e01e1580acf831c0485513135b613bb02e8b
Reported-by: Joerg Mayer
Reviewed-on: https://code.wireshark.org/review/20965
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6d204e51520d3b5013e5acf319eb01…
commit 6d204e51520d3b5013e5acf319eb01cef6fab0a3
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Apr 1 22:48:33 2017 +0200
ANCP: Update to RFC6320
Updates ANCP dissector to final RFC6320.
Additional updates types and codes to current IANA registry values:
https://www.iana.org/assignments/ancp/ancp.xhtml
Bug: 13532
Change-Id: I15d3e66e049d425350a528d04d4a5ff24d9b26bd
Reviewed-on: https://code.wireshark.org/review/20964
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=029c38d3fc3cdeb907c11db69992a8…
commit 029c38d3fc3cdeb907c11db69992a820e6624e13
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Apr 8 09:50:29 2017 +0100
Cope with spaces among options better, plus trivial cleanups
Change-Id: I3a00cf5dbcc0ee83a31f95ac74759cbc0aaa0e89
Reviewed-on: https://code.wireshark.org/review/20962
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8cfa57cdb53ea7928a6514985f788a…
commit 8cfa57cdb53ea7928a6514985f788aa6d6545763
Author: Marcelo Ricardo Leitner <marcelo.leitner(a)gmail.com>
Date: Fri Apr 7 10:17:35 2017 -0300
Fix NR-SACK DuplicateTSN field
It was commented out because the loop reading it was filling using the
wrong header field, probably just due to a copy&paste issue.
Also, fix its width, which is actually 4-bytes long. The loop reading it
is reading it correctly already.
Change-Id: Ie1a3cb901ec578e51395ba110ea1792476919d75
Reviewed-on: https://code.wireshark.org/review/20961
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dc81822154a24c6eed5095d73319cb…
commit dc81822154a24c6eed5095d73319cbee18241a94
Author: Marcelo Ricardo Leitner <marcelo.leitner(a)gmail.com>
Date: Wed Apr 5 22:36:13 2017 -0300
Fix size information for sctp.sack_duplicate_tsn
It was listed as UINT16 while it's actually UINT32.
The loop that actually parses the duplicate_tsn's in dissect_sack_chunk
is already parsing it using 4-bytes, as per SACK_CHUNK_DUP_TSN_LENGTH
definition.
Change-Id: I90fa115844a397f143d39770da9f5bc3c5c891b5
Reviewed-on: https://code.wireshark.org/review/20960
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=99e0b39ba811796b48333540cf6f7e…
commit 99e0b39ba811796b48333540cf6f7edaa737c803
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Mar 31 20:35:51 2017 +0200
sharkd: add tap for RTP stream analysis.
Change-Id: Idf88a891b69e4d89b2d0c62d505059ab073e266e
Reviewed-on: https://code.wireshark.org/review/20816
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=b9b5703a41a52d9494c0179e42bbf5…
commit b9b5703a41a52d9494c0179e42bbf5c62c7dcb05
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 31 01:06:07 2017 +0200
Qt: Remember exact position of selected item in tree
When switching between packets, the first field at a level would be
selected. This is annoying if you have similarly structured trees (like
TLVs or text labels).
Combined with something like bug 13533, this causes erratic jumping. Fix
this by incorporating the level position in the path.
Change-Id: I998853ce899fffc69dd4932902508141325c35a4
Ping-Bug: 13533
Reviewed-on: https://code.wireshark.org/review/20799
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=438459183bebf650ba05bf1c3b4aa6…
commit 438459183bebf650ba05bf1c3b4aa69ba0b011e6
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Apr 6 20:41:03 2017 +0200
kpasswd: remove unused entry hf_kpasswd_newpassword
Change-Id: I46a295ee55f97c9b384aca07f6de50bc85bd5151
Reviewed-on: https://code.wireshark.org/review/20954
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2780ad60786ba7ddd1c054e17edd3e…
commit 2780ad60786ba7ddd1c054e17edd3e3b76eb2160
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Apr 6 20:43:26 2017 +0200
kpasswd: remove unnecessary if(tree) check
Change-Id: I6f50198f9bd646bb01365feef929213f4fa274a9
Reviewed-on: https://code.wireshark.org/review/20955
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9d5f172875a9a0db5b5088a6a86496…
commit 9d5f172875a9a0db5b5088a6a86496ec40dba45d
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Apr 6 20:53:42 2017 +0200
simplify the description of tvb_memeql()
Make the description simpler than the code (hopefully).
Change-Id: Iaede1a6eb18e25e379b719f9b66ecbef0c00ea63
Reviewed-on: https://code.wireshark.org/review/20956
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ae9efa2bff12b88601ab50d9325582…
commit ae9efa2bff12b88601ab50d93255821cc47fc8c3
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Apr 6 21:10:00 2017 +0200
adwin: remove an unnecessary if(tree) check
Change-Id: If55f3e30192d5af6700d5193880bc932623d254f
Reviewed-on: https://code.wireshark.org/review/20957
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4baa0c222272a0dc5e5383952d842d…
commit 4baa0c222272a0dc5e5383952d842d3c31af77c9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 20:45:56 2017 +0100
adb: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: Iaa441f2f1c6147effe47d735d296f3c496518796
Reviewed-on: https://code.wireshark.org/review/20424
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a771a12a2d13277b02346cd66df273…
commit a771a12a2d13277b02346cd66df2738db2470d8a
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Wed Apr 5 23:31:13 2017 -0400
PCEP: Decode "SR-RRO subobjects" as defined in
draft-ietf-pce-segment-routing-08.
Change-Id: I93cc00da055364b2a6d647966fcd299c1f4e206e
Reviewed-on: https://code.wireshark.org/review/20943
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cc30b7b0b5dcb79e4daaa096c2aabf…
commit cc30b7b0b5dcb79e4daaa096c2aabfca9ee23bc9
Author: Nicolas BERTIN <nicolas.bertin(a)al-enterprise.com>
Date: Wed Apr 5 23:55:27 2017 +0200
NOE: fix "EVT_LOCAL_APPLICATION" message decoding
Change-Id: Ic27d05afa3a785152c7a6e114d8cf1f13cb65859
Reviewed-on: https://code.wireshark.org/review/20942
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2bd5adcf71792fc2a9431ad98aa803…
commit 2bd5adcf71792fc2a9431ad98aa803b2c03a93dc
Author: Rémy Léone <remy.leone(a)gmail.com>
Date: Mon Apr 3 11:01:36 2017 +0200
randpkt: Add support to generate IEEE802.15.4 packets
Change-Id: I17a93c18d204cb7ab70a5c6898f866b32f745a4b
Reviewed-on: https://code.wireshark.org/review/20878
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=280f2feeaf95fcf50f028162b49be1…
commit 280f2feeaf95fcf50f028162b49be1bf6866c918
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 22:58:18 2017 +0200
RPC-over-RDMA: protect against a variable overflow
Bug: 13558
Change-Id: I0cb379df1a6c40a3c4a84f18c631d9239550c3ab
Reviewed-on: https://code.wireshark.org/review/20941
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0bd11903938e7fbcc876888178ed9c…
commit 0bd11903938e7fbcc876888178ed9c1f085fdffc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 22:29:01 2017 +0200
BGP: fix a variable underflow
Bug: 13557
Change-Id: I882c8a7161ff233e289a413579ed51c3b8f43c36
Reviewed-on: https://code.wireshark.org/review/20940
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=899f98911365c22434c61df91fd0a6…
commit 899f98911365c22434c61df91fd0a6df576be276
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 22:01:35 2017 +0200
WASSP: replace a DISSECTOR_ASSERT() by an expert info
Bug: 13555
Change-Id: I052600eee1e0bf0f036e419bc9df7ff228941883
Reviewed-on: https://code.wireshark.org/review/20937
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=462fba965a2ba5e15add24ef02bc4b…
commit 462fba965a2ba5e15add24ef02bc4b9b95567ba5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 21:33:15 2017 +0200
LAPSat: remove a useless assert
If the length is bigger than the captured length, an excpetion will be thrown anyway
Bug: 13554
Change-Id: Icf0f2b049847ec945efdf42815b49c4e6040e19d
Reviewed-on: https://code.wireshark.org/review/20936
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f53333f43398bd09321b372c1f4608…
commit f53333f43398bd09321b372c1f46085381ea4ab8
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Wed Apr 5 13:35:46 2017 -0400
BGP: Update BGP Path Attributes with latest IANA assignment.
Change-Id: I6f66a5d51677db6cfea279c322ef9f976452de90
Reviewed-on: https://code.wireshark.org/review/20930
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a00b971b0712cb8a68d2d0cf3f2b9a…
commit a00b971b0712cb8a68d2d0cf3f2b9a4edafe62c0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 20:53:34 2017 +0200
TAPA: replace DISSECTOR_ASSERT() calls by expert info
Bug: 13553
Change-Id: I01d35c7e68bfee6d30da63cb804dd9913bb5a7a2
Reviewed-on: https://code.wireshark.org/review/20932
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=97377547a7cdd7fd51e252729ad916…
commit 97377547a7cdd7fd51e252729ad916bee5f47967
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 5 12:26:26 2017 -0700
More OS name cleanups.
Use macOS when not referring to a particular release; use the
appropriate name when referring to a particular release.
Change-Id: I9293d4db7c91d7c859d7c067c0f0b3c9c482fcc5
Reviewed-on: https://code.wireshark.org/review/20935
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3dd45f53d68b13db080e18c88f6855…
commit 3dd45f53d68b13db080e18c88f6855031db7d5fb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 5 12:19:28 2017 -0700
Remove trailing whitespace.
Change-Id: If044e0df526cfba0061ab3e5beec5a56dfe1e870
Reviewed-on: https://code.wireshark.org/review/20934
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=357cfd3b035d1ba6438e82cc1cbec1…
commit 357cfd3b035d1ba6438e82cc1cbec105874206b6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 5 12:15:27 2017 -0700
A bunch of "{Mac} OS X" -> "macOS" changes.
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X
10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was
sometimes called "OS X" and sometimes called "Mac OS X"), and it
was "OS
X" from 10.8 to 10.11.
Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3
Reviewed-on: https://code.wireshark.org/review/20933
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1f94d34f43055ea47fc9426e1720bd…
commit 1f94d34f43055ea47fc9426e1720bdb4b7397dd9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Apr 5 10:50:53 2017 -0700
Update comments.
The OS is now called macOS.
In newer versions of macOS, tar can uncompress xz'ed tarballs, but older
versions don't support that.
Change-Id: Ife8ac7fc7da69586ad6b718def4a52588740686b
Reviewed-on: https://code.wireshark.org/review/20931
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=71905a34b70857a8398840dc01b9df…
commit 71905a34b70857a8398840dc01b9df5ae59a652c
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Wed Apr 5 11:31:48 2017 +0200
Follow HTTP redirects when fetching tarballs in macosx-setup.sh
xz now hosts older releases on SourceForge and does a 302 redirect
to SourceForge, which cURL without -L won't follow.
The default value of 50 redirects before giving up is left unchanged.
Change-Id: I2d73301f025737ad84438d01a445fe6f257ba9d5
Reviewed-on: https://code.wireshark.org/review/20926
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2eca457d52eba25a70d82b796d147a…
commit 2eca457d52eba25a70d82b796d147a764367f679
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 4 22:05:10 2017 -0400
Display numeric fields in their base display type for columns.
Don't force display of BASE_DEC
Change-Id: Id6f115c074f0d4b1bd277dcbf6c523ffaa295edb
Reviewed-on: https://code.wireshark.org/review/20918
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c0184059d1fd48cfe2fd80302d1928…
commit c0184059d1fd48cfe2fd80302d1928088f7e0524
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Dec 1 12:00:07 2016 +0100
Bluetooth: HCI_CMD: Implement all remaining commands
Commands:
Set Connectionless Slave Broadcast Data
Read Synchronization Train Parameters
Write Synchronization Train Parameters
Read Secure Connections Host Support
Write Secure Connections Host Support
Read Authenticated Payload Timeout
Write Authenticated Payload Timeout
Read Local OOB Extended Data
Read Extended Page Timeout
Write Extended Page Timeout
Read Extended Inquiry Length
Write Extended Inquiry Length
Change-Id: If6d7a7b5405c9b9bd708553d56c6bd372b0b293b
Reviewed-on: https://code.wireshark.org/review/20891
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=023cf320ebc2ce467aec07136c74a3…
commit 023cf320ebc2ce467aec07136c74a32254cf733c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Mar 28 18:27:28 2017 +0200
Qt: support selecting the min/max packet from IO Graph
GTK+ supports selecting the first packet (via the "left mouse button")
and the last packet (via the "right mouse button") in an interval, and
Qt supports selecting the last packet of an interval. This patch enables
picking the packet matching the extreme value in Qt.
Bug: 12401
Change-Id: If0b7f2f1bf8c384ea0d68b5f5fae2d1e8b4b0ac2
Reviewed-on: https://code.wireshark.org/review/20769
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=a5f9b4e06dffa34e795f3abb1e44d4…
commit a5f9b4e06dffa34e795f3abb1e44d4e7ec7cdfa9
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Mar 28 18:19:23 2017 +0200
Qt: fix tracer and selection of packet in IO Graph
Do not assume first graph in the list, pick the first visible graph.
This (1) fixes the tracer which would otherwise show a marker at an
non-obvious position that is not located on the graph and (2) fixes the
GoToPacket action when clicking on the graph.
Bug: 13537
Change-Id: I49d750102ad25c8539aa2e44fe1583cd535dd471
Reviewed-on: https://code.wireshark.org/review/20768
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=48a614da2eae8b1f54cdfa9c7d0d2c…
commit 48a614da2eae8b1f54cdfa9c7d0d2c22275a9e07
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 10:59:51 2017 +0200
LTE RRC: add description of FGI 42 bit
Change-Id: Ie72e82c26eddef9ca99b7da801cc85e54ba5158e
Reviewed-on: https://code.wireshark.org/review/20924
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3053d7c0c14515fa8ab46a5b01e456…
commit 3053d7c0c14515fa8ab46a5b01e45678bd19f314
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Apr 5 09:13:38 2017 +0200
Qt: Remove unused argument in Size string
Change-Id: I4c09092aba986c4fe224a46cac23d70bc5915aa6
Reviewed-on: https://code.wireshark.org/review/20923
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=9f71c86880cb5c3eab65c82e6fb3d3…
commit 9f71c86880cb5c3eab65c82e6fb3d32e603f3709
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 4 10:43:51 2017 -0400
A few more BASE_UNIT_STRING cases.
Change-Id: Ic443f773d19e63aad59292bfb540f58bda565241
Reviewed-on: https://code.wireshark.org/review/20917
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=70eeeff25ce9aab6f4725d325e13aa…
commit 70eeeff25ce9aab6f4725d325e13aac690f48f00
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 4 10:41:55 2017 -0400
packet-etch.c: Optimize proto_item_append_text use
Change-Id: I0272b7160fa2207fd4bba40d9d4b59ab920c6298
Reviewed-on: https://code.wireshark.org/review/20916
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=76edea174f808785cca55033cb3c2e…
commit 76edea174f808785cca55033cb3c2ebfbf149e6a
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Mar 16 19:14:47 2017 +0100
Bluetooth: HCI_CMD: Fix master-slave role
Initiator is always master. Only Role switch event may change it.
Improve "Accept Connection Request" to avoid users confusion
by using new specification description:
0x00 Become the Master for this connection. The LM will perform the role switch.
0x01 Remain the Slave for this connection. The LM will NOT perform the role switch.
Field "Role" is now splitted from: "bthci_cmd.role"
and it name is "bthci_cmd.acr.role".
Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd
Reviewed-on: https://code.wireshark.org/review/20894
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=cf54564508f1a4e3ce6af8bab17fb8…
commit cf54564508f1a4e3ce6af8bab17fb884c5e9b9b9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Apr 2 18:44:15 2017 -0400
packet-geneve.c: Convert print_flags to proto_tree_add_bitmask
Change-Id: Ibf3ed8885737dcec2f59ba640ff202097195322d
Reviewed-on: https://code.wireshark.org/review/20915
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=697ea9affaab0dbd8fe98767247492…
commit 697ea9affaab0dbd8fe9876724749207be75adfa
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Date: Sun Apr 2 12:20:03 2017 +1000
dpnet: Dissect command frame packets
Change-Id: I00305d1a2d6f3d0f260f5ca6352e7f40ea3e878b
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Reviewed-on: https://code.wireshark.org/review/20876
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f9c800adfe882e569ca215518c6841…
commit f9c800adfe882e569ca215518c6841150eb63954
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Sun Apr 2 14:41:41 2017 -0400
ISIS: Adjust header field names to align with ISO 10589:2002.
Change-Id: Id495f1ca5a7ea2081b6ed35690ad94978c17ec6f
Reviewed-on: https://code.wireshark.org/review/20808
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=919b26323b9d47cb6379c3f9a5ca62…
commit 919b26323b9d47cb6379c3f9a5ca62fa948a83cd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 4 14:07:07 2017 +0200
dpnet: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ic3831f8d4e174a56c3b3f6ca2428496e9b307d05
Reviewed-on: https://code.wireshark.org/review/20901
Reviewed-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e46a8fc9cc09e12f36a6a0ee22fc72…
commit e46a8fc9cc09e12f36a6a0ee22fc72d41d583675
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Apr 5 00:05:17 2017 +0200
E.212: fix a typo
Thanks Gerald
Change-Id: I9e076e2b83e0868620cb943cd29e93f0495bc913
Reviewed-on: https://code.wireshark.org/review/20913
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0852b7b57c80059b05f8f2de0ee53b…
commit 0852b7b57c80059b05f8f2de0ee53b563adca534
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Apr 4 11:59:42 2017 +0200
EAPOL-MKA: Implement updates from IEEE standards
Alignment with IEEE 802.1X-2010
- Addition of Announcement
Alignment with IEEE 802.1X-2010 EAPOL-MKA
- Interpretation of algorithm agility value
- Interpretation of confidentiality offset values
- Interpretation of (wrong) cipher suite ID
- Padding handling for more parameter sets
- Improved robustness malformed frames
- Flexible SAK size handling
- Addition of Announcement parameter set
- Split ICV from ICV indicator
- Handle unknown parameter set
Additions for IEEE 802.1Xbx-2014
- Allow version 2 handling
- Addition of XPN parameter set
Change-Id: If7a36de6bb3b5148bfd1bd890e4490c045fba40d
Reviewed-on: https://code.wireshark.org/review/20899
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2a8bcfe86c3a24eab33e8270cade80…
commit 2a8bcfe86c3a24eab33e8270cade8021ed7d31f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Apr 4 11:05:24 2017 -0700
White space and style cleanups.
Get rid of extra blank lines.
Clean up indentation.
Use the same style for switch statements inside cases for the main
switch statement in dissect_dns_answer() that's used for the main switch
statement.
Change-Id: I77da88a9ffcbf176d27e16222e75c778202c651b
Reviewed-on: https://code.wireshark.org/review/20907
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=20edef4915962eb63180d51b73b25f…
commit 20edef4915962eb63180d51b73b25feb7d78e94c
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Tue Apr 4 14:34:15 2017 +0200
NOE: fix "Context" field decoding of EVT_CONTEXT_SWITCH message (was
"Unknown" instead of "Call Server" or "Presentation
Server")
Change-Id: I85e2980d5cb4adb4f5806dbc215df016c094c75e
Reviewed-on: https://code.wireshark.org/review/20904
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4c555c6b57e68a64f0efcc642edf05…
commit 4c555c6b57e68a64f0efcc642edf051ea767b9ac
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 4 14:07:37 2017 +0200
osi-utils: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I48121b5e73501a39ff5fb7986ab58242ee32af53
Reviewed-on: https://code.wireshark.org/review/20902
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2fb1cef0cf95021290a6718cf902ff…
commit 2fb1cef0cf95021290a6718cf902ff2a29ad806d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Apr 4 10:55:36 2017 -0400
debian-nightly-package.sh: Add Wireshark license
Change-Id: Idff9c807cbc3714acafd98bea5b15b06bf23f0a9
Reviewed-on: https://code.wireshark.org/review/20906
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7f3234981540afa94462cdb349752c…
commit 7f3234981540afa94462cdb349752ce3db7acbee
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Nov 24 10:50:46 2016 +0100
Bluetooth: HCI_CMD: Implement a lot of remaining commands
Commands:
Enhanced Setup Synchronous Connection
Enhanced Accept Synchronous Connection Request
Truncated Page
Truncated Page Cancel
Set Connectionless Slave Broadcast
Set Connectionless Slave Broadcast Receive
Start Synchronization Train
Receive Synchronization Train
Remote OOB Extended Data Request Reply
Set MWS Channel Parameters
Set External Frame Configuration
Set MWS Signaling
Set MWS Transport Layer
Set MWS Scan Frequency Table
Set MWS Pattern Configuration
Set Reserved LT_ADDR
Delete Reserved LT_ADDR
Set Triggered Clock Capture
AMP Test
Write Secure Connections Test Mode
Fix copy-paste issue:
Implementation for "Get MWS Transport Layer Configuration"
was in: "Set Triggered Clock Capture"
Change-Id: I4a2119278b1f3a7e1a3ec87f499d9aa43e8b8a96
Reviewed-on: https://code.wireshark.org/review/20890
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=386dd82bff113e1ad3a91cef120d96…
commit 386dd82bff113e1ad3a91cef120d967b498e37f0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 22:09:56 2017 +0200
ICMPv6: use a single field for RPL Secure Algorithm
Bug: 13551
Change-Id: If652f2c7c351cca271e9b08708db7c0b47b82932
Reviewed-on: https://code.wireshark.org/review/20872
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e5f39dfec688af47d17e0bf7a0dc0…
commit 1e5f39dfec688af47d17e0bf7a0dc0de01078fe6
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Apr 3 22:22:14 2017 +0200
cmake: add feature info for yapp
Explain what it is and where to get it from.
Change-Id: I0a02f1c3c25b76772dddda95d8e6c410b595c036
Reviewed-on: https://code.wireshark.org/review/20886
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=077f99f8def3580bc56124dc9adbb4…
commit 077f99f8def3580bc56124dc9adbb4192c390fe7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Apr 4 06:48:17 2017 +0000
RTPS: fix no previous prototype for function 'rtps_util_add_timestamp'
[-Wmissing-prototypes]
Change-Id: I2757f6442b9f3d37897225a90dd6d848e4a9c373
Reviewed-on: https://code.wireshark.org/review/20889
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=174dc4b363aa0b2d550e9353ec16ca…
commit 174dc4b363aa0b2d550e9353ec16ca6199d05777
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sat Mar 4 19:03:15 2017 +0100
Bluetooth: HFP: Fix "Parameters" field highlight
It seems that "Parameters" highlight only one byte instead of all
parameters. Fix that before someone requests to fix that.
Change-Id: If056f16ffbfc234e5d6443fb43b34bc107df964f
Reviewed-on: https://code.wireshark.org/review/20898
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=34fa55cbb2adfe93e65a2db7752e42…
commit 34fa55cbb2adfe93e65a2db7752e425d30b1d070
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Mar 23 12:55:37 2017 +0100
Bluetooth: HCI: Fix tracking for "Read Clock Offset"
Fix missing information about command-event(response) tracking.
Change-Id: I060ae71f8efb774d4d04693e58f750dec442c046
Reviewed-on: https://code.wireshark.org/review/20896
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=889752a294291d2168989ec5ff1efc…
commit 889752a294291d2168989ec5ff1efcda0c967bcf
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Tue Mar 7 19:15:57 2017 +0100
Bluetooth: PBAP: Fix two Application Parameters fields
Application Parameters:
vCard Selector
Data Filter
Both are splitted to two 4-bytes subfield, so there is a need to
move offset for second field.
Change-Id: I66c106f5455bff8789f25c683301276b1e484e65
Reviewed-on: https://code.wireshark.org/review/20892
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2db162d326e90a44665f15b1b062ba…
commit 2db162d326e90a44665f15b1b062baf6852777c9
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Mar 20 16:03:31 2017 +0100
Qt: Fix Conversation dialog's refreshing table
Fix wrong slot statement ("name").
Change-Id: I6911d6f7cb6d01ea14d5172c334c54f74ae6e546
Reviewed-on: https://code.wireshark.org/review/20897
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ae7ac4441e2a46b2d34e00e94fcc72…
commit ae7ac4441e2a46b2d34e00e94fcc72e25152644c
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Mar 20 16:00:51 2017 +0100
Bluetooth: HFP: Fix expert info for reserved field in +BRSFs
It seems to be issue introduced while implementing
features from new specification - add new bits in bitmask field
without correcting expert info condition.
Change-Id: I5a4fb4147971f565cfb5dd1abf4e5616ce9da4c5
Reviewed-on: https://code.wireshark.org/review/20895
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4543d339e35173523e5d3a7b21248a…
commit 4543d339e35173523e5d3a7b21248a0c335d7348
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Mar 16 16:13:41 2017 +0100
Bluetooth: HCI_CMD: Fix wrong field name
Interval -> Window
Change-Id: Ic40811a87fd301a07e2a9af60b152feeab395ead
Reviewed-on: https://code.wireshark.org/review/20893
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c449ca037f84f8e57160540e65adb3…
commit c449ca037f84f8e57160540e65adb33df449baa0
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Mon Apr 3 15:33:57 2017 +0200
NOE: update protocol definitions
Change-Id: I3cf8b006d792b8c866297aa6c06d9d7b005307fe
Reviewed-on: https://code.wireshark.org/review/20881
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bc40ae80759e57d2178b8fde6d25ce…
commit bc40ae80759e57d2178b8fde6d25ced5fa5bbf50
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 21:34:51 2017 +0200
WLCCP: ensure that offset is always incremented in dissect_wlccp_tlvs()
Bug: 13549
Change-Id: I4613d1e2708a65b6e9968a5a920bd1b15366ffe0
Reviewed-on: https://code.wireshark.org/review/20871
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=03f372fd8b1512df3d499e1c5d292f…
commit 03f372fd8b1512df3d499e1c5d292f9aaf5c8fa4
Author: Patryk Nowak <patryk.nowak(a)tieto.com>
Date: Mon Apr 3 13:07:04 2017 +0200
Qt/Bluetooth: add results filter in HCI Summary window
Add ability to display only these HCI commands whose names match specified
filter. Currently only simple filtering is implemented (substring search,
no regex-matching).
Change-Id: I418d3d2d3e7a3b196d5ba05496d31c508e842dec
Reviewed-on: https://code.wireshark.org/review/20880
Reviewed-by: Michal Labedzki <michal.labedzki(a)wireshark.org>
Petri-Dish: Michal Labedzki <michal.labedzki(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bf524d95f3c4a642a00d3e322d771d…
commit bf524d95f3c4a642a00d3e322d771d33c592fa8c
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Mar 30 19:00:34 2017 +0200
wbxml: don't THROW() an exception from a dissector
If the offset is out of bounds, we can simply continue and
proto_tree_add_...() will throw an exception for us.
While at it, wrap some long lines and remove obsolete coments about
g_malloc()ed memory (the dissector has been converted to wmem).
Change-Id: Icd36418f07c0cf33c5fe906a8a2d3160789ee1f2
Reviewed-on: https://code.wireshark.org/review/20856
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=965cd913bf41aef8099f446012ba30…
commit 965cd913bf41aef8099f446012ba3092cfa767b7
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 3 15:32:56 2017 +0200
E.212: update list to Operational Bulletin No. 1121 (1.IV.2017)
Change-Id: Ic04f30108deb004281569eb225e42a9515430db0
Reviewed-on: https://code.wireshark.org/review/20882
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9d7ce7aa8fea5242606e78ea25fb60…
commit 9d7ce7aa8fea5242606e78ea25fb604362a1243e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Apr 3 21:38:45 2017 +0200
ieee802154: Add missing parenthesis in incorrect FCS
Change-Id: Iea1855c00dbceac340bc0f65f23fdb1cb74250ec
Reviewed-on: https://code.wireshark.org/review/20883
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b215b92b6957474a4c07c1518fe722…
commit b215b92b6957474a4c07c1518fe7222f3f1e22c7
Author: Balint Reczey <balint(a)balintreczey.hu>
Date: Fri Mar 17 15:13:33 2017 +0100
Add script for generating nightly .debs with git revision
Change-Id: I5478feabd6966fa9ed46258da4815bb8ac882ec9
Reviewed-on: https://code.wireshark.org/review/20601
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=877b9a0d52c9b28c0169565add6f8b…
commit 877b9a0d52c9b28c0169565add6f8bf6a6f3915c
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Apr 1 12:00:47 2017 +0200
tcp: (trivial) remove some unnecessary if (tree) checks
Doing the checks ourselves doesn't save a lot of time.
Change-Id: Icd96d6487ba88bc8a0f9d475e8f569803b40cf1a
Reviewed-on: https://code.wireshark.org/review/20859
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7b0e5f87ce63f325b286ed9e9142fb…
commit 7b0e5f87ce63f325b286ed9e9142fbb78c1d7f3b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Apr 3 12:01:30 2017 +0200
MAC-LTE: enhance a bit dissection of Bandwidth Reduced related packets
Change-Id: I12fac09c982b78b16df1ca93cbae8850a4e214ed
Reviewed-on: https://code.wireshark.org/review/20879
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d99112d39310c38798aae92a6db811…
commit d99112d39310c38798aae92a6db811d363ffc385
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Apr 2 20:08:15 2017 +0200
Use col_append_str() for fixed strings
Change from col_append_fstr() to col_append_str() when
appending strings without formatting.
Change-Id: I8975704c246f2b9a1301ed5f96273aa9d61c6f44
Reviewed-on: https://code.wireshark.org/review/20857
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a3444529e5c1d4a3439e33cb449c70…
commit a3444529e5c1d4a3439e33cb449c70b399bf9205
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 22:25:36 2017 +0200
GTPv2: fix dissection of TWAN PLMN-ID
Bug: 13552
Change-Id: I8c854eb30fd025a286f3823526c7f26acc8a758c
Reviewed-on: https://code.wireshark.org/review/20873
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ae3797ec11b043ef18b1fbbf3c3540…
commit ae3797ec11b043ef18b1fbbf3c3540f18adea768
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Apr 1 21:07:37 2017 +0200
Don't compile plugins when configured --without-plugins.
--without-plugins didn't affect plugins_dir=, fix it.
Change-Id: I375aa15e38993008eaea9e311eed5cb1c3731e49
Reviewed-on: https://code.wireshark.org/review/20839
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=12434e967808011b4bdffe727c0260…
commit 12434e967808011b4bdffe727c0260ad783d68e6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Apr 2 15:32:39 2017 -0700
Fix dissection of Get Info requests.
If the length of the input buffer is zero, it means there *is* no input
buffer; don't use the offset of that buffer plus the length as the
offset past the end of the end of the packet, as both will probably be
zero. Also, for a request to get quota info, report a warning if
there's no input buffer, as MS-SMB2 seems to say there must be one.
If the length of the input buffer is *not* zero, ignore the iput buffer
for requests other than requests to get quota info or full extended
attribute info, as MS-SMB2 says a server should do that. Otherwise,
make sure the offset of the input buffer is past the end of the
fixed-length part of the request and the offset+length doesn't overflow
or go past the end of the message.
While we're at it, for some routines that return a "next offset", use
that return value rather than wiring in the length in the caller.
Bug: 12954
Change-Id: If3d8846f5e03d0d7cdfe10ddfacb347bd0915a5a
Reviewed-on: https://code.wireshark.org/review/20874
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bc48169614d33ccaf056ace1ea1cd2…
commit bc48169614d33ccaf056ace1ea1cd2c7bfceaea5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 18:42:05 2017 +0200
DNS: add an expert info if buffer is too short to compute a key id
Bug: 13548
Change-Id: I4c018ae7a46ebb3e667004293b3f6e180f9d693f
Reviewed-on: https://code.wireshark.org/review/20855
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cf7979c657e728f01b26b635939013…
commit cf7979c657e728f01b26b635939013ed290e74ba
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 17:12:43 2017 +0200
WSP: fix addition of X-Wap-Tod header in tree
Bug: 13546
Change-Id: Ie1e78cc7ada338b17a21a32714fed4816724a4f8
Reviewed-on: https://code.wireshark.org/review/20850
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a68cb9e90f23d88c6c200d6a9f45f6…
commit a68cb9e90f23d88c6c200d6a9f45f66429fe1a5b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 17:31:47 2017 +0200
PacketBB: fix hf_packetbb_addr_value[3] field type
Bug: 13545
Change-Id: Ic2dff0eeb2d312f573696cba9376cc004be17af9
Reviewed-on: https://code.wireshark.org/review/20852
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b0b39a737a8295ec68860651f193f8…
commit b0b39a737a8295ec68860651f193f8547d6e8ae1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 17:50:15 2017 +0200
PEEKREMOTE: treat header size as a signed integer
Bug: 13544
Change-Id: If04ad8e71f06c289673492db3ed916e85cfc55e5
Reviewed-on: https://code.wireshark.org/review/20853
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f564e2d7357979ccf3140251e9e0d0…
commit f564e2d7357979ccf3140251e9e0d0067dfcfb8f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 18:08:32 2017 +0200
MIH: fix subtree addition in dissect_dev_states()
Bug: 13547
Change-Id: Ib3eed331178284758953db5300ce6ea651d7dddd
Reviewed-on: https://code.wireshark.org/review/20854
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9d1f2efa51b529b7bbf453919bf6b3…
commit 9d1f2efa51b529b7bbf453919bf6b35546545637
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Apr 2 12:34:44 2017 +0200
Use col_append_sep_str() for fixed strings
Change from col_append_sep_fstr() to col_append_sep_str() when
appending strings without formatting.
Change-Id: I315aca9b815c204a5bc78f7326402c40d1325f0e
Reviewed-on: https://code.wireshark.org/review/20846
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=522532643f18e879da8706a2a0327d…
commit 522532643f18e879da8706a2a0327d2feae84d2f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Apr 2 08:13:02 2017 -0700
[Automatic update for 2017-04-02]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I9e722e963dcf7437feb98a3176e6c507d86a9485
Reviewed-on: https://code.wireshark.org/review/20848
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8350873a461b009a37e1872ca5cda8…
commit 8350873a461b009a37e1872ca5cda82ff2efc32a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Apr 2 16:52:20 2017 +0200
BGP: remove some true_false_string values obsoletes after gf998923
Change-Id: I10753353d0593b736630118ccf0a797d48e087b8
Reviewed-on: https://code.wireshark.org/review/20847
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe2857d8e53a405ee4b9dcb3791729…
commit fe2857d8e53a405ee4b9dcb37917298a90d1330f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Apr 2 08:07:17 2017 +0200
tcp: Add separator to Info column when segmented
Prefix the Info column entry "[TCP segment of a reassembled PDU]"
with a space if the column is not empty.
Change-Id: If4fc46b2d8a2d261044767c534da34e2d27435f8
Reviewed-on: https://code.wireshark.org/review/20845
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f998923bae797556106e36826dbb90…
commit f998923bae797556106e36826dbb900c71276c1a
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Sun Mar 26 21:37:15 2017 -0400
BGP: Remove redundant text in Path Attributes.
Also added display of lower-order four bits of the Attribute Flags
("unused").
Current implementation of displaying path attribute flags shows flag description
twice if the flag was set.
For example, with Optional and Length set, the attribute flags were displayed as
follows:
Flags: 0x90, Optional, Length: Optional, Non-transitive, Complete,
Extended Length
1... .... = Optional: Optional
.0.. .... = Transitive: Non-transitive
..0. .... = Partial: Complete
...1 .... = Length: Extended length
Now they are displayed as follows:
Flags: 0x90, Optional, Extended-Length, Non-transitive, Complete
1... .... = Optional: Set
.0.. .... = Transitive: Not set
..0. .... = Partial: Not set
...1 .... = Extended-Length: Set
.... 0000 = Unused: 0x0
Change-Id: Iec3c92ac2383dd3f736598b089a74f0f3c165bae
Reviewed-on: https://code.wireshark.org/review/20732
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7a1679b4fe20ef80184e45977570b2…
commit 7a1679b4fe20ef80184e45977570b202bb9b1300
Author: Nick <jimschaettle(a)gmail.com>
Date: Wed Mar 22 09:23:00 2017 -0500
ACN with blobs and magic bullet
Bug: 13315
Change-Id: I2322e5f08fefbe6979cf4bed46596ac6636cccf9
Reviewed-on: https://code.wireshark.org/review/19542
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=235ee14d2890454f0dd5eda78096fe…
commit 235ee14d2890454f0dd5eda78096fefe1731c0b4
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Apr 1 23:02:00 2017 +0200
ssl: Fix Info column separator
Always prefix Info column entries with comma if the column is
not empty.
Bug: 13539
Change-Id: I47b43841b092671fe5a74c99ec8aaa15f144bced
Reviewed-on: https://code.wireshark.org/review/20844
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=de032c63e067197cbd9155082d12ff…
commit de032c63e067197cbd9155082d12ffea5aed4c76
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Apr 1 12:28:05 2017 -0700
Check before setting the length of a protocol item.
Don't assume that 8 + {32-bit unsigned integer} won't overflow. Use
tvb_ensure_bytes_exist() to ensure that the data in question is present;
it also checks for overflows.
Also, set the length after we've succeeded in dissecting the item - if
we throw an exception, it's because we don't have all the data, so the
tvb_ensure_bytes_exist() would have failed, but this way we at least get
to dissect what data we *do* have.
Change-Id: If27a2e3ed7978c2051ccb2ddba0d498255d0e350
Reviewed-on: https://code.wireshark.org/review/20840
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=38bc42b00b21866d8c2161830876fc…
commit 38bc42b00b21866d8c2161830876fce0aab426ee
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Mar 31 19:35:04 2017 +0200
Fix IPv6/IPX statistics generation
g70381f7 switched from a sorted GSList to a wmem_tree.
But the strings "ipx" or "ipv6" must be tested before
"ip" to select the
right tap so the sorting does matter.
Use a wmem_list and parse it by reverse order like what was done with
the GSList to ensure proper selection of the tap.
Change-Id: Ic8d291c265e9c83c960d9a2f6713c25e3aa0e60d
Reviewed-on: https://code.wireshark.org/review/20813
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=420da27a13ae87bf3bdd61a83b8bc8…
commit 420da27a13ae87bf3bdd61a83b8bc8607ce6e7f2
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Date: Wed Mar 15 15:25:42 2017 +1100
Add DirectPlay 8 Enumation Query/Response packets
Bug: 13541
Change-Id: Ie8133be9ef7b3943d8cf66c5c4fe024250912253
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
Reviewed-on: https://code.wireshark.org/review/20820
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ebcfc1ba8e85bd37b03f8ae5fd2f48…
commit ebcfc1ba8e85bd37b03f8ae5fd2f48ce07239bca
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 23:32:50 2017 -0700
Improve the display of metrics.
Give the value and the "supported" bit names that reflect what they are.
Show both the "supported" bit and the value as bitfields, because
that's
what they are.
Show the "supported" bit before the value.
Show the metric value as decimal; there's nothing particularly
hexadecimal about it.
The "supported" bit is 1 if it's *not* supported and 0 if it *is*
supported.
Fetch the byte for the metric within dissect_metric(), rather than in
the call to dissect_metric().
Change-Id: Ief3bb74b273df06e07066ccdede38a2eeedc6db2
Reviewed-on: https://code.wireshark.org/review/20836
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=aa82f522c28134463b223bc1eaa5d1…
commit aa82f522c28134463b223bc1eaa5d1fd6cd9d9cd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 20:39:20 2017 -0700
You can't get a string value from an FT_NONE string.
Make it an FT_STRING.
Change-Id: I2a44c4542c79daa486382bd5b28f6c37c9c46111
Reviewed-on: https://code.wireshark.org/review/20827
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=19bb1b128b0e8fdbff0959a00ea062…
commit 19bb1b128b0e8fdbff0959a00ea062a34fbadfb4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 19:41:47 2017 -0700
Provide better error messages for field type mismatches.
Don't just report an assertion failure with a line in proto.c; give the
name of the field with the wrong type, and a list of the types that are
valid for the routine in question.
Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
Reviewed-on: https://code.wireshark.org/review/20824
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d967d71d98f20dbd107594e7605b13…
commit d967d71d98f20dbd107594e7605b13ea28cfe982
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 19:22:54 2017 -0700
FT_CHAR is an integral type, so list it in the diagnostic message.
Change-Id: I8d095a2424033bee5b3569c906327ac15de33890
Reviewed-on: https://code.wireshark.org/review/20823
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6a67209bff51c6e75e959bee27b29c…
commit 6a67209bff51c6e75e959bee27b29c0ebdd7882b
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Wed Mar 29 13:23:45 2017 +0200
ieee80211: Fix parsing of supported operating classes IE
Fix parsing of Supported Operating Classes information element
- Fix min tag length check message (min length is 2 not 3)
- Fix max tag length check (no max defined)
- Fix malformed packet exception on frames with min tag length
- Handle OneHundredAndThirty and Zero field delimiters
- Use same base (dec) for both current and alternate op classes
Bug: 13534
Change-Id: I05b2238eb07f65fde0a33479e9459d2a99911a50
Reviewed-on: https://code.wireshark.org/review/20784
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d57f03ce0f747f251dd34f2bbe70e4…
commit d57f03ce0f747f251dd34f2bbe70e45667aa8a09
Author: Priyanka Mondal <priyanka02010(a)gmail.com>
Date: Fri Mar 24 15:29:29 2017 -0400
Add citrix mep dissectors
Change-Id: Id574fc20e17333646d615cab415b2d40b4487375
Reviewed-on: https://code.wireshark.org/review/20333
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7aed334856820b1a1676b81313076e…
commit 7aed334856820b1a1676b81313076e086a893587
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 18:52:31 2017 -0700
Don't add an FT_UINT32 with proto_tree_add_none_format().
Make it an FT_NONE.
Change-Id: I83339d84b88c7decffa6e6a48d12acc4b063a4ad
Reviewed-on: https://code.wireshark.org/review/20822
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=01ec22994affe82633bb673da6f78d…
commit 01ec22994affe82633bb673da6f78d87986411cd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 18:41:16 2017 -0700
Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.
We don't allow that. Use proto_tree_add_boolean() instead.
Change-Id: I59ed0f0dc731b1ce4b5d921cd4e85b1c101cb2a8
Reviewed-on: https://code.wireshark.org/review/20821
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=62d78199eee5d239b826442c6edd95…
commit 62d78199eee5d239b826442c6edd95aeeef1540b
Author: Scott Deandrea <sdeandrea(a)apple.com>
Date: Wed Mar 29 17:20:06 2017 -0700
Add packet capture support for Darwin USB
Change-Id: Iec9e4ac2362cf8e88a3cf6ae3483cefe938967e5
Reviewed-on: https://code.wireshark.org/review/20814
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=02f74e47ed3e542f4aff9fc6a7a9c4…
commit 02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 14:47:49 2017 -0700
Fix some dissection errors.
"XXX supported" for a metric type is a Boolean, not an int; add it as
such.
Add the value of the item without the extra bits.
The length of an address prefix is in semi-octets (nibbles/hex digits),
not in octets.
Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda
Reviewed-on: https://code.wireshark.org/review/20819
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7dc065397a5a18715dd1cf70dc4cfb…
commit 7dc065397a5a18715dd1cf70dc4cfbccb550fa90
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Mar 31 12:52:58 2017 +0200
Optimize frame_data layout.
Move tsprec to remove padding. It saves 8 bytes on amd64,
shrink size of frame_data structure from 96 to 88 bytes.
Change-Id: Ib69687b2e5b7d65b5c15eda7d5834100a02c059e
Reviewed-on: https://code.wireshark.org/review/20807
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a8ce98fc255482938b70142707e8fd…
commit a8ce98fc255482938b70142707e8fd40b134595e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Mar 31 18:31:14 2017 +0200
Fix endpoints statistics optional filter parsing
Bug: 13538
Change-Id: I4cd66d2dffc976610d41126c50b5722bc06a72f8
Reviewed-on: https://code.wireshark.org/review/20810
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Christopher Maynard <Christopher.Maynard(a)gtech.com>
http://cgit.osmocom.org/wireshark/commit/?id=c5d7183a32d138004517ab3699caa3…
commit c5d7183a32d138004517ab3699caa3239623f1b5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 10:58:25 2017 -0700
Fix comments.
Change-Id: Iac768dd2f06ce081a7b82c58c225f2674f3f1174
Reviewed-on: https://code.wireshark.org/review/20815
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e767f42a242fa640feaee7df70c668…
commit e767f42a242fa640feaee7df70c668ee16114f2d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Feb 28 09:54:56 2017 +0100
AMQP: fix field amqp.value is not of type FT_NONE
Bug: 13435
Change-Id: Ib61404fc3a8c461593d2a8a60224463ef2b9c4b6
Reviewed-on: https://code.wireshark.org/review/20309
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fff930d3939c21a1ed988ef9014c32…
commit fff930d3939c21a1ed988ef9014c32f75739ea7c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 31 02:08:30 2017 +0200
Qt: do not expand collapsed trees when switching packets
Scenario: user selects a field, collapsed tha parent tree and selects
the next packet. Before this patch, the tree would be expanded again,
selecting the child. After this patch, the tree will not be expanded,
instead selecting the tree node that got collapsed.
Change-Id: I7968fca1056a937cf3b399afb6f3089c2d199067
Reviewed-on: https://code.wireshark.org/review/20801
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=641a48ec68778a5eaed82e436c0964…
commit 641a48ec68778a5eaed82e436c09642e9ef1f911
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Mar 30 13:26:56 2017 +0200
checkAPIs: improve trailing item suggestion for XXX_string
Tighten the check (do not just check for "0,NULL}};" but also
"{0,NULL}};" in case someone decides to use "{0x10,NULL}};" as
trailing
item. Improve the suggestion, "{NULL,NULL}" is better for string_string
than "{0,NULL}".
For now treat 0 the same as NULL since files like packet-fix.h would
need editing otherwise. Accept octal notation for value_string since
packet-nfs.c uses this in nfs2_mode_names.
Change-Id: Ic507dbd8b07f3ae062b3f0310aa3398115d54273
Reviewed-on: https://code.wireshark.org/review/20796
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=08963526bc618cb827f7e1eddb547c…
commit 08963526bc618cb827f7e1eddb547c3bea0d2017
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 01:09:38 2017 -0700
Fix typo.
Change-Id: I55137590280024dd383c0d005a2d9d79f9b7d38a
Reviewed-on: https://code.wireshark.org/review/20804
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9a3f177c22cc9f02511913be51927a…
commit 9a3f177c22cc9f02511913be51927aab5309ab11
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 31 00:27:48 2017 -0700
Fix incorrect NSAP AFI values.
Change-Id: I302041f5a08973229317455d8df8690256557e76
Reviewed-on: https://code.wireshark.org/review/20803
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=93cf5909ec0aabb84b96c518ad61e0…
commit 93cf5909ec0aabb84b96c518ad61e082d52600b6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 31 01:12:06 2017 +0200
dns: prevent repeatedly overwriting resolved entries
When a packet contains multiple conflicting names for the same address,
it would result in modification of the resolved name every time this DNS
packet is selected. In Qt, this causes a periodic (one second)
redissection of the current (DNS!) packet which interferes with user
interaction. To avoid this, only add the address on the first visit.
Bug: 13533
Change-Id: Ic71515131da4d666bfd589df9ff90a866a30778c
Reviewed-on: https://code.wireshark.org/review/20800
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fb97e82cbe1f177034e8129c9bb48f…
commit fb97e82cbe1f177034e8129c9bb48f5b30270003
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 30 17:48:58 2017 -0700
Distinguish between the two flavors of ITU-T AFIs.
As ISO 8348/X.213 Annex A says:
A.5.2.1.2 Format and allocation of the IDI
A specific combination of IDI format and DSP abstract syntax is
associated with each allocated AFI value, as summarized for use in
individual addresses in Table A.4 (the corresponding AFI values for use
in group addresses is found via Table A.2). Two AFI values are
associated with each combination that involves a variable-length IDI
format. In each case, both of the AFI values identify the same
combination of IDI format and DSP abstract syntax. The numerically
lower AFI value is used when the first significant digit in the IDI is
non-zero. The numerically greater AFI value is used when the first
significant digit in the IDI is zero.
and A.5.3 talks further about this.
Change-Id: I3fdad04064451b3c891731dc8f107bc57586eb84
Reviewed-on: https://code.wireshark.org/review/20802
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0ea51ad82256f833a0d93efb16aa4e…
commit 0ea51ad82256f833a0d93efb16aa4e749c80eb5b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Mar 28 18:14:35 2017 +0200
Qt: Fix uninitialized memory access in val_units_
Fixes the following UBSAN errors:
ui/qt/io_graph_dialog.cpp:1720:75: runtime error: load of value 3200171710, which
is not a valid value for type 'io_graph_item_unit_t'
#0 0x5611f0b0cd1d in IOGraph::setFilter(QString const&)
ui/qt/io_graph_dialog.cpp:1720:75
#1 0x5611f0b737a1 in IOGraph::IOGraph(QCustomPlot*)
ui/qt/io_graph_dialog.cpp:1682:5
#2 0x5611f0afb3f3 in IOGraphDialog::addGraph(bool, QString, QString, int,
IOGraph::PlotStyles, io_graph_item_unit_t, QString, int) ui/qt/io_graph_dialog.cpp:340:24
#3 0x5611f0af7c19 in IOGraphDialog::IOGraphDialog(QWidget&,
CaptureFile&) ui/qt/io_graph_dialog.cpp:289:13
ui/qt/io_graph_dialog.cpp:1818:19: runtime error: load of value 3200171710, which
is not a valid value for type 'io_graph_item_unit_t'
#0 0x5611f0b1167e in IOGraph::setPlotStyle(int)
ui/qt/io_graph_dialog.cpp:1818:19
#1 0x5611f0b062ee in IOGraphDialog::syncGraphSettings(QTreeWidgetItem*)
ui/qt/io_graph_dialog.cpp:420:10
ui/qt/io_graph_dialog.cpp:1872:29: runtime error: load of value 3200171710, which
is not a valid value for type 'io_graph_item_unit_t'
#0 0x5611f0b13e6a in IOGraph::setValueUnits(int)
ui/qt/io_graph_dialog.cpp:1872:29
#1 0x5611f0b06640 in IOGraphDialog::syncGraphSettings(QTreeWidgetItem*)
ui/qt/io_graph_dialog.cpp:422:10
Note that calling setFilter with an empty string is pretty useless,
especially since the filter is initialized later, so remove it.
The choice for IOG_ITEM_UNIT_FIRST is quite arbitrary and needed because
setValueUnits reads the "old" (uninitialized) value.
Change-Id: I32c65a30593cb718b838c0f324e0d1b0eaab90e5
Reviewed-on: https://code.wireshark.org/review/20767
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=aa6dcf9cd317d223f6d3f1e12917b8…
commit aa6dcf9cd317d223f6d3f1e12917b807d2abb5d7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 30 15:00:06 2017 -0700
Add a bunch of #defines for OSI NSAP AFI values, and use them.
Have the ISUP value_string for those AFI values show "decimal" and
"binary" indicators.
Update some references.
Change-Id: I07797455f5ffa5fa9cd4e0702a6f5db831054937
Reviewed-on: https://code.wireshark.org/review/20798
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8bf0a57ce1fddb3ca3172814d86c17…
commit 8bf0a57ce1fddb3ca3172814d86c17bf2c07951d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 30 12:39:29 2017 -0700
Make some routines static.
Change-Id: I04860f058345cb633ab379c83dcfc24b6cf1a846
Reviewed-on: https://code.wireshark.org/review/20797
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1c3d85d577d3820486df2c9ebee687…
commit 1c3d85d577d3820486df2c9ebee687301f5c812b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:14:43 2017 +0000
.mailmap: Update (of February and March)
Change-Id: Ib728c6ebf0a029e7241a042a0ca80c602df8e89e
Reviewed-on: https://code.wireshark.org/review/20202
Reviewed-by: Mark Phillips <mark.phil(a)samsung.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=038679c6531b763a8c11e157f962d4…
commit 038679c6531b763a8c11e157f962d44f61f08b21
Author: Chema Gonzalez <chemag(a)gmail.com>
Date: Wed Mar 29 15:35:23 2017 -0700
ssl-utils: fix a couple of uninitialized variables
Fixed these (false-positive) warnings:
epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_frag' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_fraglen' may be
used uninitialized in this function [-Werror=maybe-uninitialized]
else if(tls_check_mac(decoder,ct,TLSV1_VERSION,mac_frag,mac_fraglen,mac)>=
0) {
Change-Id: I282d5d60d96953858844deeaaf2069ffed3fabca
Reviewed-on: https://code.wireshark.org/review/20793
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=732d54e6e7282cea1875079d425a18…
commit 732d54e6e7282cea1875079d425a18429224944a
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 30 11:09:25 2017 +0200
pcapng: Align code name and hf name.
Use common name for "Number of Received Packets".
Change-Id: Ib57b142e8fc5c85a03c5622c264ce1d7e113f795
Reviewed-on: https://code.wireshark.org/review/20795
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=77e308f82dfa85216c158d9aec7ace…
commit 77e308f82dfa85216c158d9aec7acef9f5d56505
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Wed Mar 29 20:08:37 2017 +0300
[UMTS FP] Fixed some comments
And also removed an unused length check in the DCCH over DCH heuristic dissection
method
Change-Id: I534200acb66e11a0c49d15e478e1f1d902e0ba05
Reviewed-on: https://code.wireshark.org/review/20788
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5cd534145522c602e2e28abe5a9b2d…
commit 5cd534145522c602e2e28abe5a9b2d58015bc9b4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 29 17:27:40 2017 -0700
Terminate string_strings with { NULL, NULL }.
checkAPIs.pl looks for { 0, NULL }, so use that.
Change-Id: Ia8ec0bddcb346649ac760df8b42a8589d6b67983
Reviewed-on: https://code.wireshark.org/review/20794
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=57d15713db46be0a48a29b4201aea9…
commit 57d15713db46be0a48a29b4201aea976c20fb3e9
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 26 19:11:02 2017 +0200
Prevent crash/assert on access to "uninitialized" device.if_info.name.
While this is one possible way to fix it, it probably is not the "right"
way to do it. I just don't know which one would be right. I regard
several options to be cleaner:
- Remove if_info from interface_t altogether and add the required fields
to interface_t directly.
- Never use device.if_info.name but always use device.name (same with
friendly_name)
- Initialize both fields the same (same with friendly_name)
- Also not nice: device is optically a struct, not a pointer. So into the
function, when we create a new struct (that's where the error "is
made"),
the same name continues to be used.
Not improving my confidence into my solution:
- I haven't bee able to figure out why the automated Windows builds don't
crash/assert.
Last but not least: The two qt/gtk functions should probably have their common
core extracted into a common function.
Change-Id: I1b36d1765d1a1ec975927cb5785a1540ba4952f5
Ping-Bug: 13448
Reviewed-on: https://code.wireshark.org/review/20721
Petri-Dish: Jörg Mayer <jmayer(a)loplof.de>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=a2cf38305e6ead954cb91d4cfdb196…
commit a2cf38305e6ead954cb91d4cfdb1968281bd7bbe
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Mar 29 19:22:21 2017 +0200
c15ch: fix value_string termination
Change-Id: I305ec694e2eea75dd1826d3ae82b39d2716ef7c1
Reviewed-on: https://code.wireshark.org/review/20789
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c9817936fbf96d6a5a6fdb4f390815…
commit c9817936fbf96d6a5a6fdb4f3908150cb386ff01
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Mar 29 19:22:39 2017 +0200
sysex: fix value_string termination
Change-Id: I7063db4b748a96ad3fb190f575d04ca4a411a404
Reviewed-on: https://code.wireshark.org/review/20790
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=483daa4d276968e152ac991323c927…
commit 483daa4d276968e152ac991323c9274c4cbf40ac
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Mar 29 19:24:37 2017 +0200
checkAPIs.pl: check value_string termination
Check for the expected "{0, NULL}" termination, disallowing things like
"{9, NULL}". Also add val64_string and bytes_string while at it. Remove
a stale comment since we allow some c99 syntax now.
Change-Id: I1685255bbb11d84eba46b7cd00934d2f74187e03
Reviewed-on: https://code.wireshark.org/review/20792
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4d1060eca52e3ec39ca6da7e729b6b…
commit 4d1060eca52e3ec39ca6da7e729b6bd63d71a063
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Mar 29 19:24:43 2017 +0200
mrcpv2: fix value_string termination
Not actually used in a header field, but in str_to_str. Caught by an
updated checkAPIs.pl script.
Change-Id: I8b7173716034b71b556c3d95fa0541ca9117e1f1
Reviewed-on: https://code.wireshark.org/review/20791
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f8c870eee23915aee30bfabe20e2f1…
commit f8c870eee23915aee30bfabe20e2f14a95cad560
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 29 09:45:29 2017 -0700
Throw in a cast to squelch a compiler warning.
MSVC warns that comparing a gboolean (which is a typedef for int) to a
bool is unsafe; convert the gboolean to a bool (the post-C++11 draft C++
standard I have says that the conversion from integral to bool does
pretty much what you'd expect - zero goes to false, non-zero goes to
true - and is exactly what we want).
Change-Id: Ia7d7b62baf87ca3a29da5140f68c2c5b38b2d6de
Reviewed-on: https://code.wireshark.org/review/20787
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=25dc3ee9fde080d2098fe0fc7b2077…
commit 25dc3ee9fde080d2098fe0fc7b207757b8b7c6e0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 29 09:38:54 2017 -0700
Squelch 64-to-32-bit narrowing warnings.
Change-Id: Ifc6938ab8deb62fc8b53c9d68504210b6fcc58f7
Reviewed-on: https://code.wireshark.org/review/20786
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0369b504d3bc3ef791e8429e121817…
commit 0369b504d3bc3ef791e8429e1218177c2d2fc97d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 29 09:27:31 2017 -0700
Fix processing of AMQP 0-10 arrays, maps, and conneciton locales.
You can't call proto_tree_add_XXX routines on a proto_item * that hasn't
been given a subtree with proto_item_add_subtree(). Fix that.
The packet offset for a FT_UINT_STRING is a pointer to the first byte of
the *length*, not to the first byte *after* the length.
Properly pluralize "entry".
Change-Id: I7f2a55eaad850e3e52e62eb061e0444d176c593a
Reviewed-on: https://code.wireshark.org/review/20785
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=601fe5e3516b67e709628f9c4a4fa2…
commit 601fe5e3516b67e709628f9c4a4fa2c2f8918041
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 10 14:37:18 2017 +0100
Qt: propagate selection from main screen to dialog
Ensure that the selection in main screen is updated on refreshing
interfaces (InterfaceFrame::interfaceListChanged). Add additional
patches to ensure that selection changes from the main screen propagate
to the dialog and be careful to avoid infinite recursions.
Life of a signal for InterfaceFrame:
ui->interfaceTree->selectionModel emits selectionChanged
-> slot InterfaceFrame::interfaceTreeSelectionChanged
-> emits InterfaceFrame::itemSelectionChanged
-> slot MainWelcome::interfaceSelected
-> emits MainWelcome::interfacesChanged
-> slot CaptureInterfacesDialog::interfaceSelected
(updats dialog selection)
Life of a signal for CaptureInterfacesDialog:
ui->interfaceTree emits itemSelectionChanged
-> slot CaptureInterfacesDialog::interfaceSelected
(emission of next signal because sender is ui->interfaceTree)
-> emits CaptureInterfacesDialog::interfacesChanged
-> slot InterfaceFrame::updateSelectedInterfaces
(updates main screen selection)
This should probably be updated to model/view with shared selection
model in the future.
Change-Id: Ibb32c201a92bd2f1310523b3e6e63b03209c9ce4
Reviewed-on: https://code.wireshark.org/review/20487
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=5eaa9e770533345dfc6664a5d53c69…
commit 5eaa9e770533345dfc6664a5d53c6931b00fdc75
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Mar 29 07:37:38 2017 -0400
packet-icmpv6.c: Fix some value_strings
Change-Id: Ieae37af709b670792cca3937674ba0cc1026d45f
Reviewed-on: https://code.wireshark.org/review/20783
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=08e4d57ec452a1b809297af71f6bfb…
commit 08e4d57ec452a1b809297af71f6bfb60bf503fb7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Mar 28 21:53:04 2017 -0400
Bluetooth: fix conflicting entries in its value_string.
Change-Id: Ie0f9bc800b5d86effa18a8ae333bbf8da18d0c3b
Reviewed-on: https://code.wireshark.org/review/20775
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f7060112b7e83edd844c90a397e603…
commit f7060112b7e83edd844c90a397e60301ee5f1c29
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Mar 28 22:28:13 2017 +0200
TLS: fix decryption with Encrypt-then-MAC (RFC 7366)
Bug: 13522
Change-Id: I0dfe30e086c3ef1a4f96f22e2db46e4d4cc7dffa
Reviewed-on: https://code.wireshark.org/review/20771
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2de68eb47ff076c3a7e17e278098a5…
commit 2de68eb47ff076c3a7e17e278098a584f367f391
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Mar 25 13:05:50 2017 +0100
sharkd: support exporting ssl secrets
Change-Id: Ie7db733d8aa7189b1ade6ef85d911653ed8c490f
Reviewed-on: https://code.wireshark.org/review/20703
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=572b80d2835f9296e87c0d099f133d…
commit 572b80d2835f9296e87c0d099f133d55149c44f1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 28 17:07:33 2017 +0200
Add ENC_TIME_MSEC_NTP and use it in packet-gtpv2.c
While at it fix expert info a typo and an calculation.
Change-Id: I071a36edb7eed5f58708b98aebcb24bc6c34f2a8
Reviewed-on: https://code.wireshark.org/review/20766
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=79ba8c397653d99b4c52a5bbfa2f4d…
commit 79ba8c397653d99b4c52a5bbfa2f4d554067c6a4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 21:16:19 2017 -0700
Print signed values with %d, not %u.
Change-Id: I1ad46df006976c052ff42baf6415e18b488b215f
Reviewed-on: https://code.wireshark.org/review/20780
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b56bbb493afe6717d2e26c6e795205…
commit b56bbb493afe6717d2e26c6e795205d7ae10254a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Mar 28 19:36:50 2017 -0400
Fix "warning C6246: Local declaration hides declaration of the same name in outer
scope" warnings
Change-Id: I98edc076fdab40ef1fd05313168011f58e13a4d6
Reviewed-on: https://code.wireshark.org/review/20773
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6b0f846ac35a9775090f85a02f5806…
commit 6b0f846ac35a9775090f85a02f58064b4b0117e6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 19:29:44 2017 -0700
Fix problem found by Coverity.
The loop was using bytes_read, but wasn't setting it. Go back to
something similar to the previous loop condition, but don't lose the
error tests.
Fixes Coverity CID 1403388.
Change-Id: I557cbfa6e9ad81491af4fc90e85ce87c71fec8aa
Reviewed-on: https://code.wireshark.org/review/20776
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=630b5a8165aab25d99989916f36412…
commit 630b5a8165aab25d99989916f36412a0414068be
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 18:41:43 2017 -0700
Check for localtime() failing.
It "shouldn't happen", but at least this squelches a Coverity
complaint,
CID 1394503.
Change-Id: I40af10d47c1d1b026f6b40ef68b139e6bf246109
Reviewed-on: https://code.wireshark.org/review/20774
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1bea950b7a7934fe7bed7719a0ed99…
commit 1bea950b7a7934fe7bed7719a0ed99321785f7d6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 11:56:53 2017 -0700
Add bounds checks for references to outhdr_values.
Don't run past the end of the outhdr_values array.
While we're at it, don't make it a global array - it doesn't need to be
global, as its values don't persist from invocation to invocation, and
this would allow use of this routine in multiple threads in parallel.
(Yes, we have other global variables that don't maintain state, but we
should get rid of that, too.)
Change-Id: I7ceed3c9ba6356eddb7d52472e9d53dd08f90029
Reviewed-on: https://code.wireshark.org/review/20770
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=616bbce78e0bc7986d51f4297f04f3…
commit 616bbce78e0bc7986d51f4297f04f31b9ed75616
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Mar 28 16:53:19 2017 -0400
packet-nstrace.c: Ensure value_strings end with {0, NULL}
Change-Id: I548c51dd7333b0dc26a84f77b1e848530b79dde3
Reviewed-on: https://code.wireshark.org/review/20772
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8efd42c4aa708e53bcb383e79c5351…
commit 8efd42c4aa708e53bcb383e79c535137d6d0cade
Author: Martin Sehnoutka <msehnout(a)redhat.com>
Date: Mon Mar 27 14:55:05 2017 +0200
Reflect new default value of snaplen in man pages.
Default value for snaplen is defined in wiretap/wtap.h:
#define WTAP_MAX_PACKET_SIZE 262144
and used in capture_opts.c:
capture_opts->default_options.snaplen =
WTAP_MAX_PACKET_SIZE;
but help and man pages don't reflect this change.
Change-Id: I35ddf1e8b7ffd657f4e01b3fe6b4c44c9acece2b
Reviewed-on: https://code.wireshark.org/review/20738
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=172107521b8be56911ce467b837ba0…
commit 172107521b8be56911ce467b837ba047db40d0bb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Mar 28 08:08:57 2017 +0200
voip_calls_infO_model(.h): fix extra ‘;’ [-Wpedantic]
Change-Id: I2f131999cd0337d0d65d52f303c8ab9ca6bda39a
Reviewed-on: https://code.wireshark.org/review/20757
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=aa998d75732759abf8a5727c297789…
commit aa998d75732759abf8a5727c2977897c7425afe6
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Mar 28 13:42:54 2017 +0200
Qt: update endpoint statistics column labels to match GTK ones
Bug: 13526
Change-Id: I40485c6f9b54ff0bf07f955c1dde8cd5ac05ef9b
Reviewed-on: https://code.wireshark.org/review/20762
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2f324e770f0fd58065b9e80d878fd3…
commit 2f324e770f0fd58065b9e80d878fd3536897ea81
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Mar 28 08:21:55 2017 -0400
randpkt_core: Fix a handful of warnings
1. randpkt_core.c(559): warning C6262: Function uses '65596' bytes of stack:
exceeds /analyze:stacksize '16384'. Consider moving some data to heap.
2. randpkt_core.c(615): warning C6386: Buffer overrun while writing to
'buffer': the writable size is '65536' bytes, but '-1' bytes
might be written.
Change-Id: I0f3bcd19b49d6c8cde0d2ad9f745b14f5462a708
Reviewed-on: https://code.wireshark.org/review/20763
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6b929abe6957f4c2cb27760daa1a24…
commit 6b929abe6957f4c2cb27760daa1a248ac73c1b88
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 03:33:45 2017 -0700
Don't wire in 262144, use WTAP_MAX_PACKET_SIZE.
That way, if we ever increase WTAP_MAX_PACKET_SIZE, this code won't need
to be changed.
Change-Id: I68d21e10810b7b8a4732d9ecf7e145668b0fe1cb
Reviewed-on: https://code.wireshark.org/review/20761
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bd486eb9b16640af51fb58995ff59c…
commit bd486eb9b16640af51fb58995ff59c1434737dc2
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Mar 28 11:15:13 2017 +0200
text2pcap: define max packet size to WTAP_MAX_PACKET_SIZE
Change-Id: I73ab87032e4a0c0259227622412be36aaf66a9d6
Reviewed-on: https://code.wireshark.org/review/20758
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ed3b5e5764ce368edc6ca10b81411a…
commit ed3b5e5764ce368edc6ca10b81411a7b01b29444
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 03:21:18 2017 -0700
Get rid of blanks at the ends of lines.
Change-Id: I10a756a4a42d4f27f59e12c11f12d71947191c92
Reviewed-on: https://code.wireshark.org/review/20760
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8f515b1a99d0043966a8d287cee38f…
commit 8f515b1a99d0043966a8d287cee38fe67e06d189
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 28 03:17:48 2017 -0700
Fix up time encodings.
Add some new encodings for absolute time stamps, and use them as
appropriate; this fixes some cases where the time stamps in question
were being dissected incorrectly.
For the encodings with seconds and 1/2^32s of a second, don't
arbitrarily give only microsecond resolution; 2^32 is greater than 1
million, and, in fact, at least some NTP RFCs explicitly talk about time
resolution greater than 1 microsecond.
Update references in the RELOAD dissector to reflect the documents in
question having been updated and published as RFCs.
Change-Id: Icbe0b696d65eb622978eb71e99ddf699b84e4fca
Reviewed-on: https://code.wireshark.org/review/20759
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=721182b09ba7212e6c4c2c182d67fb…
commit 721182b09ba7212e6c4c2c182d67fb8762a5919d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Mar 13 13:47:34 2017 +0100
Qt: fix closing editor in capture interfaces dialog
Whenever (every second) the points list is updated, a dataChanged signal
is emitted and Qt decides to close all editors. Workaround this issue by
disabling the dataChanged signal. (Alternatively, we could change the
list into a pointer-to-list again.)
Change-Id: Ie06d118d011a72f5be5608c2324ca2715a3f97c7
Fixes: v2.3.0rc0-2014-gf8dc2346df ("Qt: fix memleak of PointList in interface
statistics")
Reviewed-on: https://code.wireshark.org/review/20530
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1b14fbcfe9252922b73f5c3087a9a…
commit e1b14fbcfe9252922b73f5c3087a9ae7a61e6ad3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 16:15:41 2017 +0200
text_import: the maximum frame length should be WTAP_MAX_PACKET_SIZE
Change-Id: I41989e8b5fd273c518f786ca74683b9284d9403e
Reviewed-on: https://code.wireshark.org/review/20747
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cabd7d82935561dde001ba7132ae14…
commit cabd7d82935561dde001ba7132ae145ea2c6dbeb
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 21:19:28 2017 +0200
wsutil: fix a NULL pointer dereference when there is a single plugin registered
Rework loop to avoid dereferencing a NULL pointer. Bug introduced in g6d79055
Change-Id: I88a9f2d045b633cc2365ff6ce939f3315e7d42cc
Reviewed-on: https://code.wireshark.org/review/20751
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2141eafa64fd080b1aeb0aa2259c57…
commit 2141eafa64fd080b1aeb0aa2259c57de076c8836
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 16:16:48 2017 +0200
GTK: the maximum packet size is WTAP_MAX_PACKET_SIZE, not 65535
Change-Id: I4b78a3bff7ed158eef2008e52ec8abc9f7a8d1d3
Reviewed-on: https://code.wireshark.org/review/20748
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3a3d6edb042b71cce70898cd2ad0ce…
commit 3a3d6edb042b71cce70898cd2ad0ce787267dcf3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 16:12:10 2017 +0200
artnet : fix conflicting entry in its value_string
Field 'ESTA Code' (artnet.poll_reply.esta_man) has a conflicting entry in its
value_string: 19546 is at indices 386 (LightMinded Industries, Inc.) and 387 (Sumolight
GmbH))
Matches http://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php
Change-Id: I61044a3b9d7f7e3255fb9da1eceef79afa084003
Reviewed-on: https://code.wireshark.org/review/20742
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4cc0d1e72881f2ce3e975e5e6d0ae7…
commit 4cc0d1e72881f2ce3e975e5e6d0ae735b20791ad
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 16:17:51 2017 +0200
Qt: the maximum packet size is WTAP_MAX_PACKET_SIZE, not 65535
Also ensure that the update of sparkline does not lose focus of the
spinbox currently edited.
Change-Id: Icf7dd180fe3cb1d8bfab9017f923bf38e6210554
Reviewed-on: https://code.wireshark.org/review/20749
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0c0f6a650e854672a915ba0c318ba6…
commit 0c0f6a650e854672a915ba0c318ba6bb5f16a552
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 16:11:41 2017 +0200
reordercap: use the snaplen from the source file
Change-Id: I61871fa10142e2e2fab5e0e579df7530b9e52eef
Reviewed-on: https://code.wireshark.org/review/20746
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4038b2db268ab967f4e7da483aef55…
commit 4038b2db268ab967f4e7da483aef5573f5f31155
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 27 18:54:49 2017 -0400
rawshark: Move large data (WTAP_MAX_PACKET_SIZE) to the heap.
Change-Id: Ib525d35b6a0fa58602d30fda701b0cce5f05b322
Reviewed-on: https://code.wireshark.org/review/20756
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=915d3409944caef5f452a6c59d4abe…
commit 915d3409944caef5f452a6c59d4abe89c06ea898
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 27 18:49:59 2017 -0400
dumpcap: Move large data (WTAP_MAX_PACKET_SIZE) to the heap.
Change-Id: Id365b533812bd972a5e7732ad43b6b6e3221029b
Reviewed-on: https://code.wireshark.org/review/20755
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=60d2fda9c9660a41c10b1e18b87d68…
commit 60d2fda9c9660a41c10b1e18b87d68652516a870
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 27 17:14:59 2017 -0400
k12text.l: Move large data (WTAP_MAX_PACKET_SIZE) to the heap.
Change-Id: Ic291dbd5930978bbd0adc8b58d09b423de83b65b
Reviewed-on: https://code.wireshark.org/review/20754
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=26abd2a0226bdec47f6269421ac478…
commit 26abd2a0226bdec47f6269421ac478208d5e260b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 27 17:02:05 2017 -0400
logcat_text.c: Move large data (WTAP_MAX_PACKET_SIZE) to the heap.
Change-Id: I3a391079a28aae7e41d926268f9f60152871bfa5
Reviewed-on: https://code.wireshark.org/review/20753
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bd3196b094ae46fa4396edbb406d68…
commit bd3196b094ae46fa4396edbb406d68056cba6974
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Mar 27 12:50:26 2017 -0700
Don't waste time trying to run non-plain file and non-executable files.
Directories, and non-executable files, aren't going to be extcap
executables.
This may not make much of a difference for an installed version of
Wireshark, but it makes a difference if you're running from the build
directory.
Change-Id: Ib9953fa04392dc7a8420ddf28bab9726e6050c12
Reviewed-on: https://code.wireshark.org/review/20752
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=cea97f225aa86fdc01bc47cdc09502…
commit cea97f225aa86fdc01bc47cdc095021c0ed31a1b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 20:36:23 2017 +0200
Qt: fix capture statistics display in status bar
Broken in g414c132
Bug: 13524
Change-Id: I4d579170f925749aa9e7a6015ff17dee08d6e445
Reviewed-on: https://code.wireshark.org/review/20750
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=db9db90d54d18ca283966cc6495abc…
commit db9db90d54d18ca283966cc6495abc7eb6b41e6d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 15:24:32 2017 +0200
btatt: fix conflicting entry in its value_string
Field 'Response Value' (btatt.user_control_point.response_value) has a
conflicting entry in its value_string: 4 is at indices 3 (Operation Failed) and 4 (User
not Authorized))
Change-Id: Idb1f023c3dde00f7dcfc8b16e91d0a15a24072dd
Reviewed-on: https://code.wireshark.org/review/20740
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67f8b957d34b4675a37ebce36ad42f…
commit 67f8b957d34b4675a37ebce36ad42f764fc422e0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 15:27:25 2017 +0200
BGP: fix conflicting entry in its value_string
Field 'Type Code' (bgp.update.path_attribute.type_code) has a conflicting
entry in its value_string: 29 is at indices 19 (LINK_STATE) and 20 (Deprecated))
Change-Id: Ifd0c7a2a095d2b216115b94ca0b71e0dca2213ee
Reviewed-on: https://code.wireshark.org/review/20741
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=45e0707472afa319de2f23fbe00815…
commit 45e0707472afa319de2f23fbe0081503b1001d29
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 16:13:01 2017 +0200
bctp: fix conflicting entry in its value_string
Field 'BVEI' (bctp.bvei) has a conflicting entry in its value_string: 0 is at
indices 0 (No indication) and 1 (Version Error Indication, BCTP version not supported))
Change-Id: I9071d3ab7aff6b2c3767f0a5596dad23f1ee4b42
Reviewed-on: https://code.wireshark.org/review/20743
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f5ed8a4306fabff20518cc5b176e57…
commit f5ed8a4306fabff20518cc5b176e57c8e9d334de
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 27 09:40:56 2017 -0400
Fix "warning C6246: Local declaration hides declaration of the same name in outer
scope" warnings
Change-Id: I0dbf8d0236b163da568a173ccedc3072bd039caa
Reviewed-on: https://code.wireshark.org/review/20739
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9e9917bdbefe47482c08ea32360c03…
commit 9e9917bdbefe47482c08ea32360c0311f536cdc6
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Mar 27 16:09:06 2017 +0200
wslua: update a comment
Change-Id: I8ccb3f00ab3ed2eea770acb7541b64ec07749d6b
Reviewed-on: https://code.wireshark.org/review/20745
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=96447e4496a5484c9f079209d5b3e2…
commit 96447e4496a5484c9f079209d5b3e2a6f89245d5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 29 09:24:19 2016 +0200
ISUP: use proto_append_item_text
Change-Id: Ie17717cbc7d175c3515a155517225a9babb9b5bd
Reviewed-on: https://code.wireshark.org/review/17515
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3a21f679ad68290081e1df79d07146…
commit 3a21f679ad68290081e1df79d07146b45f18a6a5
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Sat Mar 25 01:18:02 2017 +0300
Added Heuristic dissectors for the following UMTS FP channels:
HS-DSCH Type 1, HS-DSCH Type 2
Change-Id: Id4177d6ce6978b405aa213122f4629467cb249d8
Reviewed-on: https://code.wireshark.org/review/20701
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2a8126c3ad6109e5c40d803298bb73…
commit 2a8126c3ad6109e5c40d803298bb73fbfd68dd15
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 19:25:49 2017 -0400
sharkd_session.c: warning C6031: Return value ignored: 'sscanf'
Change-Id: I32f56b7b351d7096b4e97f7c61db1af8d0b3b6f0
Reviewed-on: https://code.wireshark.org/review/20729
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4764087ef3880043a82ee6be6002ed…
commit 4764087ef3880043a82ee6be6002ed9cb041ae07
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 11:12:23 2017 +0200
netflow: Add Classification Engines types
Change-Id: I880044c0a91e471c8eb6f98c9ee9aede6877bed2
Ping-Bug: 13497
Reviewed-on: https://code.wireshark.org/review/20734
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c5dd3a1fdf5469fa1dfb35cfcc948b…
commit c5dd3a1fdf5469fa1dfb35cfcc948b3e2a858e7f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 11:13:47 2017 +0200
netflow fix conflict for hf field
'cflow.transport_rtt' exists multiple times with NOT compatible types:
FT_RELATIVE_TIME and FT_UINT32
'cflow.transport_jitter_mean' exists multiple times with NOT compatible types:
FT_UINT32 and FT_RELATIVE_TIME
'cflow.transport_jitter_min' exists multiple times with NOT compatible types:
FT_UINT32 and FT_RELATIVE_TIME
'cflow.transport_jitter_max' exists multiple times with NOT compatible types:
FT_UINT32 and FT_RELATIVE_TIME
Change-Id: I3ee220646412235eb3bce58ce3a7bc0547a5a90d
Reviewed-on: https://code.wireshark.org/review/20735
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Uli Heilmeier <openid(a)heilmeier.eu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ff6058039a4e4e1b2d4277e88ff92e…
commit ff6058039a4e4e1b2d4277e88ff92ebcc70edfcc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 27 09:20:16 2017 +0200
udpdump: fix indent (use tab)
Change-Id: Ibfe9ad19d12a84794f5e84ebaf3b9de5d4e419e8
Reviewed-on: https://code.wireshark.org/review/20733
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea0f0939bb7c4a0b12864f36a6525f…
commit ea0f0939bb7c4a0b12864f36a6525fa930cc11b8
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Sun Mar 26 00:37:41 2017 +0300
[UMTS RRC] Added dissection of "Cell Identity"
According to TS 25.401 / 6.1.5 Cell Identifier
Change-Id: I74996e76328f536dec0d34aa8229a1074ed47187
Reviewed-on: https://code.wireshark.org/review/20709
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc482dd71508ea69f58fa5c0d4ac9b…
commit dc482dd71508ea69f58fa5c0d4ac9bd6d55de7bc
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Sun Mar 26 21:01:13 2017 -0400
packet-nvme: Corrected typo in keep alive string.
This patch fixes typo in keep alive admin queue command string from
"kepp" to "keep".
Change-Id: If4b01d9d78628978b8db2c39d203cf1e153bfdf2
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/20731
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=45df494f538d6bf716078748a382c5…
commit 45df494f538d6bf716078748a382c5b8e2b85470
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 13:22:02 2017 -0400
netscreen.c: Suppress compiler warnings on Windows
Change-Id: I6920b7ab5862db46c56a85198f97dced842f14d5
Reviewed-on: https://code.wireshark.org/review/20723
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=687f7f9773068e2fdb4b0c5cb49e07…
commit 687f7f9773068e2fdb4b0c5cb49e07c11668b684
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 13:50:23 2017 -0400
netscaler.c: use dynamic memory for temporary buffer in nstrace_read_v30.
Makes Windows vscodeanalysis a little happier.
Change-Id: Ie744e91ab3f2a9744ae21c932ab6ea25467ad2fa
Reviewed-on: https://code.wireshark.org/review/20724
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3b588dffcf4737f07ccf49baf6bc44…
commit 3b588dffcf4737f07ccf49baf6bc44a4108647c3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 18:46:13 2017 -0400
Check for return value of WSAStartup on all executables.
Windows vscodeanalysis complains even though the event is probably
very unlikely.
Change-Id: Iafe158eea5586908209d6bfe1e45540117558673
Reviewed-on: https://code.wireshark.org/review/20727
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=520cfcf53b1c3e56ff524c89cf18fb…
commit 520cfcf53b1c3e56ff524c89cf18fbf999a28f0c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 14:18:03 2017 -0400
bluetooth_device_dialog.cpp: warning C6246: Local declaration of 'item' hides
declaration of the same name in outer scope
Change-Id: If6d2cf5d193b45d972534a3064fea7d290eac7f4
Reviewed-on: https://code.wireshark.org/review/20726
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=505c0f375dda19e3a9eaa4f24f7424…
commit 505c0f375dda19e3a9eaa4f24f74247d6149a979
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 14:07:12 2017 -0400
packet-ieee80211.c: Use dynamic memory for AIRPDCAP_KEYS_COLLECTION
Makes Windows vscodeanalysis a little happier.
Change-Id: I4e49615bc8b1623f826e0f2b9319d71016454310
Reviewed-on: https://code.wireshark.org/review/20725
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ebc6dfa6ded7944cdea5f6ec05e2d7…
commit ebc6dfa6ded7944cdea5f6ec05e2d73018e37203
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 19:23:08 2017 -0400
sharkd_session.c: Match printf argument with datatype
Address complaints from vscodeanalysis.
Change-Id: I0943a635eb0904a5ee392f772aa21cc3b56bc3de
Reviewed-on: https://code.wireshark.org/review/20728
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=677e103d1076760139b7b53527cac5…
commit 677e103d1076760139b7b53527cac55f3ace55b3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 26 19:31:03 2017 -0400
udpdump.c: warning C6262: Function uses '65608' bytes of stack: exceeds
/analyze:stacksize '16384'
Change-Id: I1d82c62dd30497db6a88ba3d3c973799ba7631ab
Reviewed-on: https://code.wireshark.org/review/20730
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6184560d71bc78444128abee5168bf…
commit 6184560d71bc78444128abee5168bfa8f7ac89ea
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Mar 17 13:51:01 2017 +0100
LLRP: Remove PARAM_TREE_ADD* macros
and make checkhf happy (no need to rewrite some wireshark function...)
Change-Id: I0214e809229ac14d5ecf136f61db232c5dd50cdb
Reviewed-on: https://code.wireshark.org/review/20704
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=244b30179cce1b795d4498db49950d…
commit 244b30179cce1b795d4498db49950d391e7fd43e
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 26 18:36:44 2017 +0200
Move #if 0 up to include the now unused struct definition
Change-Id: I5500a091608af61d7f8091ba133db558c148a853
Reviewed-on: https://code.wireshark.org/review/20719
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=be6584640ec12e1873e64e4632f7a0…
commit be6584640ec12e1873e64e4632f7a0523848c9a6
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sun Mar 26 10:02:59 2017 -0500
User Guide: Fix two trivial typos
Change-Id: I25bab6eb1072bec102e00a76027c7742a0ea883b
Reviewed-on: https://code.wireshark.org/review/20714
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2d31c2a93d6e3e825dfa65b1952e76…
commit 2d31c2a93d6e3e825dfa65b1952e76e88fd2467d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Mar 26 08:12:24 2017 -0700
[Automatic update for 2017-03-26]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I284e7960d0ad30e715a9afc42e4248f2a19f8fa7
Reviewed-on: https://code.wireshark.org/review/20716
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=2affc00cf1f6f18a4a1b1dfa8ef442…
commit 2affc00cf1f6f18a4a1b1dfa8ef442f26ac30a56
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Mar 19 11:33:47 2017 +0100
sharkd: support for SRT and RTD taps.
Change-Id: I60b9ece77f4795cd5208e53ccd18ab010646050f
Reviewed-on: https://code.wireshark.org/review/20614
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=457f4fbab0b6f66ed50bdfd663eb9f…
commit 457f4fbab0b6f66ed50bdfd663eb9f5e228c77dd
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Mar 25 16:48:48 2017 +0100
diameter: Improvement of AVP 8
Will now show country and operator
Same as Ic16623c226228ab0c3e31d33cda81953c80551d6
Change-Id: Iecae92d531b9d37254573894f0e7e7f2e2a970aa
Reviewed-on: https://code.wireshark.org/review/20708
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a5b61039424788dfb7c0e9fc1b8b89…
commit a5b61039424788dfb7c0e9fc1b8b89bf5863a2d0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 25 15:36:41 2017 +0100
BGP: Fix dissection of BGP ADD-PATH capability
not limited to len = 4 (can be a multiple of 4)
Bug: 13521
Change-Id: I668dbff6d8a7b0a4260da31393bb70d2c5431455
Reviewed-on: https://code.wireshark.org/review/20705
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bb2ab6ac9664869eaadec1d472acb4…
commit bb2ab6ac9664869eaadec1d472acb478be285168
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Mar 25 21:58:47 2017 -0700
Don't speak of RTPS time_t as an "NTP" time.
It's some weird hybrid of UN*X time and NTP time stamps, using UN*X's
epoch and NTP's seconds/fractions split. I'm sure they had their
reasons for not using something like struct timespec or regular NTP
time, and instead inventing something that's halfway in between them.
Change-Id: I1f39ec1368af52b82adfa2a22677dfa6e9341309
Reviewed-on: https://code.wireshark.org/review/20711
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a6730565f8569b0b8dafc8aebad120…
commit a6730565f8569b0b8dafc8aebad120c5b66cf3cb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Mar 25 21:37:29 2017 -0700
Add ENC_TIME_TIMEVAL and use it for gsmtap.
From a look at the libosmocom code, time stamps in
GSMTAP_TYPE_OSMOCORE_LOG messages appear to be UN*X struct timevals with
a 4-byte tv_sec, not anything NTP-like with the fraction-of-a-second
part in units of 1/2^32s of a second.
Add ENC_TIME_TIMEVAL to handle time stamps like that, and use it rather
than ENC_TIME_NTP_BASE_ZERO.
Change-Id: Ia1511527ee292fb7725b2a64c0af16d23ff10a6d
Reviewed-on: https://code.wireshark.org/review/20710
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6c374a2a5c6c5125ab3ebacb922ca3…
commit 6c374a2a5c6c5125ab3ebacb922ca3978d9c0a9d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 25 16:12:43 2017 +0100
profinet (pn-rt): fix 'pn_rt.ds_redundancy' exists multiple times with NOT
compatible types: FT_BOOLEAN and FT_UINT8
Change-Id: I5c74a34619ea66c3ac2a77d10b31a3f1256c6595
Reviewed-on: https://code.wireshark.org/review/20707
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8a5bce55df05b3d246004c978a5889…
commit 8a5bce55df05b3d246004c978a5889adab231ba3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 25 16:12:13 2017 +0100
dvb (s2): fix 'dvb-s2_bb.reserved' exists multiple times with NOT compatible
types: FT_NONE and FT_BYTES
Change-Id: If8fee9f8c27d32acecec975c7107b6e8203480ed
Reviewed-on: https://code.wireshark.org/review/20706
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=be528f3256d13465d36ac0d4391fcf…
commit be528f3256d13465d36ac0d4391fcf4f83fe6e30
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Sat Mar 25 01:59:24 2017 +0300
Fixing TVB creation for PDUs in HS-DSCH Type 2 FP packets
Bug: 13520
Change-Id: I3e95a33fa053637a3af0e74f6b010ba1eacdfde8
Reviewed-on: https://code.wireshark.org/review/20702
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=370f3b358cd9ee7dcd2b7274f7ee6c…
commit 370f3b358cd9ee7dcd2b7274f7ee6c90d5906c7a
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 00:51:08 2017 +0100
Qt: add cache proxy model for Voip Calls dialog
When a capture file is reloaded, the information stored in
VoipCallsInfoModel is invalidated. Add another cache layer to fix this:
VoipCallsInfoModel wraps around raw data (invalid on close)
CacheProxyModel NEW: use prev. data or cache on close
VoipCallsInfoSortedModel provided sorting, etc.
VoipCallsDialog actual user of model (callTreeView)
This also fixes a UAF after a file was closed, and when a call is
selected (that got worse with the last model/view patch and is "fixed"
in this patch with the caching layer. Note that the Flow sequence and
Play Streams dialog are not that useful when the file is closed).
Change-Id: Ib4daff9dc01a54863fe1d943bdbdb876418924ee
Reviewed-on: https://code.wireshark.org/review/20574
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=b4bc6c72c79fa121753cf94ae179ea…
commit b4bc6c72c79fa121753cf94ae179ea73f1e911dd
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Feb 13 01:36:58 2017 +0100
Qt: refactor Voip Calls Dialog into Model/View
Functional improvements:
- "Time of day" option is now propagated to the CSV/YAML export.
- The sorting order is preserved in the CSV/YAML export.
Other changes:
- Convert column name identifiers to enum.
- CSV output will now always be quoted (previously numbers like packet
count were not quoted, but since CSV has no numeric type it should
be OK to add quotes). Side-effect of model design decision.
- Instead of clearing the widgets and re-adding all calls, now it will
add new calls to the model. Not tested with a live capture, if the
column data can change, maybe a dataChanged signal is needed.
Due to this patch, it should be easier to add a filter for finding calls
easier (e.g. by From, IP, etc.).
Note: extra QList is used in the model to ensure a O(1) lookup of calls
(rather than O(n) for GQueue).
Change-Id: Ie08462aae038d9c3daf1cc7a152b948724689017
Reviewed-on: https://code.wireshark.org/review/20084
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bff74696df796fca83df72fc7cec7c…
commit bff74696df796fca83df72fc7cec7cb917ebb205
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Mar 24 19:48:15 2017 +0100
MAC LTE: upgrade dissector to v13.5.0
Change-Id: Iffba7cc03f1326dfa9725ac6ed677173b932684a
Reviewed-on: https://code.wireshark.org/review/20700
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e8c7d530670bc4c814bce9a2ab52ad…
commit e8c7d530670bc4c814bce9a2ab52adfe71d55820
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Fri Mar 24 11:24:43 2017 -0400
packet-nvme-rdma: Corrected NVMe Fabrics port number
This patch fixes typo in the NVMe fabrics port number from 4220 to 4420.
Ping-Bug: 13201
Change-Id: Ib0378b894c014ab91065f61c512c4d83fe7fcdb8
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/20699
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c78c8dc8423d5603a699b7e730482d…
commit c78c8dc8423d5603a699b7e730482d07a0fd0736
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 24 14:42:51 2017 +0100
Rename a few variables to look more similar to the qt implementation
Reset auth_str for each round of the loop.
Change-Id: Ib5be6a3d172c28d7b1634fdba3e72c83622405dd
Reviewed-on: https://code.wireshark.org/review/20698
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=cf97b57ede106f1bca733f9aa48d0e…
commit cf97b57ede106f1bca733f9aa48d0ea29b25bf4d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Mar 24 12:52:18 2017 +0100
[RTP Analysis] Remove check for duplicated MAC (duplicated packet
detection)
Bug: 11478
Change-Id: Ieff015e5bf55facc732beae6a40b76d2050a4aac
Reviewed-on: https://code.wireshark.org/review/20696
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ceeb757cd3c869a9da3e37b62442b6…
commit ceeb757cd3c869a9da3e37b62442b63c94fd4e4f
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 24 14:09:06 2017 +0100
Remove the last HAVE_PCAP_REMOTE inside HAVE_PCAP_REMOTE for this file.
Change-Id: I8710c235ae5377c2064097b1d7163c4cb3544fd8
Reviewed-on: https://code.wireshark.org/review/20697
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=5e2f72a75941c7d52359d6b66b5fed…
commit 5e2f72a75941c7d52359d6b66b5fedc30cceb3d1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 16 19:20:03 2017 +0100
ros (asn1): fix this condition has identical branches [-Werror=duplicated-branches]
found by gcc7
Change-Id: I2c7553bdf664ffaa53ba48195b9b7d234d53e839
Reviewed-on: https://code.wireshark.org/review/20581
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f9fe43d282c7c3fc035f9bbcbb9ab9…
commit f9fe43d282c7c3fc035f9bbcbb9ab9846fd5fc54
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 16:24:01 2017 +0100
proto: fix this condition has identical branches [-Werror=duplicated-branches] found
by gcc7
Change-Id: Ie8590d6c94b19697cff33874c5bc0b76024d337f
Reviewed-on: https://code.wireshark.org/review/20693
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e61189d838cfe7bda65aff2a5e7e2a…
commit e61189d838cfe7bda65aff2a5e7e2a43aef24827
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Mar 24 09:33:47 2017 +0100
coap: Add filterable payload length
Also fix payload desc abbrev.
Change-Id: I355658d7722383e5d1ef84efddf43e545bfda269
Reviewed-on: https://code.wireshark.org/review/20695
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=0b2eb9d242d9ea1b7aa69dee4a13ac…
commit 0b2eb9d242d9ea1b7aa69dee4a13ac8474fb8b60
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Mar 24 08:33:06 2017 +0100
coap: Put payload protocol in parent tree
Change-Id: I15cc9df174a42d284c55306cd43f9a86eebd93a2
Reviewed-on: https://code.wireshark.org/review/20694
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=2ff5931287799b88e93b6918b73b1a…
commit 2ff5931287799b88e93b6918b73b1ab245356145
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 24 01:39:37 2017 +0100
Clean up gtk/capture_dlg.c insert_new_rows a bit.
Hopefully no semantic changes.
Change-Id: I1e43a971851ad944aa1e18c42131b6e180017656
Reviewed-on: https://code.wireshark.org/review/20689
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2dbde83ee56dd2879cb7076ec46f5b…
commit 2dbde83ee56dd2879cb7076ec46f5b432c8f3d69
Author: D. Ulis <daulis0(a)gmail.com>
Date: Wed Mar 22 14:57:02 2017 -0400
CIP Motion: Minor updates
1. Change protocol name from "Motion" to "CIP Motion". This now
matches "CIP Safety" I/O.
2. Print out unparsed data as bytes.
3. Remove if(tree) check
4. Clean up the parsing to be a little more consistent, and in packet byte order.
Change-Id: I5c28522da7991852b708d825a349badc036b4b8d
Reviewed-on: https://code.wireshark.org/review/20673
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3ddaa5ebc93ed6022dbb552448a550…
commit 3ddaa5ebc93ed6022dbb552448a5508a907f51dc
Author: IWASE Yusuke <iwase.yusuke0(a)gmail.com>
Date: Tue Mar 21 13:09:21 2017 +0900
BGP: Decode Route Distinguisher in VPN Flow Specification
RFC5575 says Route Distinguisher is inserted between "length" and
"NLRI
value" fields when the BGP NLRI type is VPNv4 Flow Spec (AFI=1,
SAFI=134) and this is the same for VPNv6 and L2VPN.
This patch fixes the BGP dissector to decode the missing Route
Distinguisher field in Flow Spec NLRI decoder.
Change-Id: Ib45d96bb399b80be69ca70ea552d2c07b07a9782
Signed-off-by: IWASE Yusuke <iwase.yusuke0(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/20653
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=383ba15d02452ba2fefd9c6f2d43d7…
commit 383ba15d02452ba2fefd9c6f2d43d727dba071b4
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 24 00:26:53 2017 +0100
Clean up updateRemoteInterfaceList a bit more.
Add an #if-0'ed add_interface_to_remote_list because it is present in its
gtk pendant insert_new_rows in capture_dlg.c
Change-Id: I90e8f9eaafd3d3ca31140ec8bcd6a2eeb7c849ca
Reviewed-on: https://code.wireshark.org/review/20688
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=cbea4c02c4b154e5995ce9c9ae6978…
commit cbea4c02c4b154e5995ce9c9ae6978d9dd2ecad2
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Thu Mar 23 19:46:49 2017 +0100
Split interface update code into its own routine
Change-Id: I568a0785978227924cc6c3b7e9f86f39fa777411
Reviewed-on: https://code.wireshark.org/review/20687
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=ff89c111233269f40beeee3005bde5…
commit ff89c111233269f40beeee3005bde56289f7511d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 23 14:58:11 2017 +0100
[GTPv2] Add dissection of Millisecond Time Stamp.
Change-Id: Ic1f536c3fa786e118f1f20b983137ae5a91de271
Reviewed-on: https://code.wireshark.org/review/20686
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8db347bf61ceb665c53378bc70b619…
commit 8db347bf61ceb665c53378bc70b6193d978844b7
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 23 14:53:16 2017 +0100
[Diameter] Fix typos
Change-Id: I535605f29ce052c7d86e1646797456d2c02a8643
Reviewed-on: https://code.wireshark.org/review/20685
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da53525e3f8e7c51a1fb83879515d8…
commit da53525e3f8e7c51a1fb83879515d828660d9c53
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Thu Mar 23 08:37:25 2017 +0100
MACsec: Align dissector more with IEEE 802.1AE
- Use more standard Wireshark APIs
- Align naming more with IEEE standard
Change-Id: Id76e9693c5f59dbbd7864da8072e993ba60f71b9
Reviewed-on: https://code.wireshark.org/review/20677
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8826910ba42e99eca7dd52b54cb066…
commit 8826910ba42e99eca7dd52b54cb0664d692c26b5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 20 19:08:02 2017 +0100
netflow: fix dissection of Application ID
Bug: 13497
Change-Id: Ifa1679c95893268a70f201626d4c534d9bb54bcd
Reviewed-on: https://code.wireshark.org/review/20648
Reviewed-by: Nick Brown <nickbroon(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=81ad4cd3bdc1b729de2b43ccf9d543…
commit 81ad4cd3bdc1b729de2b43ccf9d5435bac17f3d5
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sun Mar 19 21:07:53 2017 -0500
capinfos: Add -K option and report capture comments last
This patch adds a capinfos -K option to suppess printing of capture
comments. This patch also changes when capture comments are printed
relative to the other enabled infos. Because capture comments are
freeform we will now defer their printing until all but the interface
detail infos are printed.
Change-Id: Ibb3df040c09e4c67d714c561869c00e08b83d6ed
Reviewed-on: https://code.wireshark.org/review/20643
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9e35c0bc8b667b79d36c1ce9d16da3…
commit 9e35c0bc8b667b79d36c1ce9d16da3228cf5f3c8
Author: Erik de Jong <erikdejong(a)gmail.com>
Date: Mon Mar 20 19:11:46 2017 +0100
Fix QT UI bugs in RTP dialogs
- RTP analysis and player dialogs are modal whereas they were not modal in GTK
UI
Only fixed calling up the RTP analysis window being modal when called from the
RTP streams dialog as it is modeless when called from the menu in the main
window with a stream packet selected.
- Action 'Next problem packet' triggers an infinite loop when there are no
'problem packets' and first packet is selected when calling the action.
- Crosshairs not implemented in RTP player/crosshairs context menu item not
working.
Context menu item commented out.
bug: 13500
Change-Id: I0ba954f895b85605462c316e4426280ec4d437b2
Reviewed-on: https://code.wireshark.org/review/20660
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=50a30c194f89d246ae916f3cca6bc2…
commit 50a30c194f89d246ae916f3cca6bc216d8aab9a6
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 23 12:45:49 2017 +0100
[Diameter] Update with AVPs from TS 29.273 V14.2.2
Change-Id: I4095beebfd8f9bd0f5a74b338eff91722843ad8d
Reviewed-on: https://code.wireshark.org/review/20684
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d49e7d98ecaec690a933def015df85…
commit d49e7d98ecaec690a933def015df8502f87fe322
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 23 08:48:39 2017 +0100
icmp: Fix name for addr_entry_size
Use "Address entry size" as name for icmp.addr_entry_size
Change-Id: Ibf118ef4e05e9bda4d90a4576dd844204c3ca5ed
Ping-Bug: 13515
Reviewed-on: https://code.wireshark.org/review/20678
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=12241beea2ffa2fda901c17d9f114e…
commit 12241beea2ffa2fda901c17d9f114e3ed3b3f9c3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 22 10:52:16 2017 +0100
Qt: Register Qt dialog UAT files during startup
All files which belongs in a configuration profile are registered
during startup because they affect copy existing profiles and
reset the default profile.
UAT files used in Qt dialogs are not loaded during startup because
they only get loaded when the dialog is shown. This files must be
manually registered.
Change-Id: Ib43f5c46b0dbde6994d90512708488cc2bd92f04
Reviewed-on: https://code.wireshark.org/review/20665
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=bb017f3eb30804645a84ccc4cd071f…
commit bb017f3eb30804645a84ccc4cd071fac44d0a326
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Wed Mar 22 11:43:43 2017 +0100
androiddump: Fix tcpdump op prec bug with used_buffer_length calc
androiddump reads data from tcpdump in chunks that not necessarily
match packet sizes. Whenever a partly read packet is found in buffers
more data is read and the number of used bytes in buffer is updated.
The calculation of used_buffer_length is wrong though leading to most
packets are read and thrown away.
Problem fixed by correcting an operator precedence mistake where
used_buffer_length would only be increaded with 0 or 1 insted of
actual number of read bytes.
Change-Id: Ib5c4e1d96e7ba499f26796ffa5d7ce6a116b9a6e
Reviewed-on: https://code.wireshark.org/review/20666
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c9bf21cbcaf5f79360015c4edcb65f…
commit c9bf21cbcaf5f79360015c4edcb65f23300a39d7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 15:08:23 2017 +0100
umts_fp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I4dd45ebfb4e9a2c6d2537f9a3fa842bfc4414a08
Reviewed-on: https://code.wireshark.org/review/20604
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=559836a74c8ceebc4a9e291188a8b3…
commit 559836a74c8ceebc4a9e291188a8b331a52a7051
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Mar 22 18:35:28 2017 +0100
LTE RRC: upgrade dissector to v13.5.0
Change-Id: Ic1c1b2cbf2a9213dbb6d6eadb41c15fcddb0d64a
Reviewed-on: https://code.wireshark.org/review/20672
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4f1df36cc3e11fa804a7b1001f76a8…
commit 4f1df36cc3e11fa804a7b1001f76a84456402711
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 22 21:12:37 2017 -0700
Update some Cisco URLs.
Some pages moved, some pages went away and are archived on the Wayback
Machine, some pages went away and *weren't* archived on the Wayback
Machine but are stored on another site out there.
Change-Id: I2f8d8b9ce569804b0e8424523d31168b47162506
Reviewed-on: https://code.wireshark.org/review/20676
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5f49829cc63ada00619b38e84ae868…
commit 5f49829cc63ada00619b38e84ae868f75283f1ff
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 22 22:10:43 2017 +0100
ieee802154: Don't set COL_PACKET_LENGTH
It's not needed for a dissector to set COL_PACKET_LENGTH.
Change-Id: I536145d1ed3b98cbdc922d03a2dd2e26a8f99744
Reviewed-on: https://code.wireshark.org/review/20675
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fa25f19ae433d6ee34e15c123ffffb…
commit fa25f19ae433d6ee34e15c123ffffbc908d3bbe2
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Wed Mar 22 20:05:51 2017 +0100
Thrift: Register for media-type application/x-thrift
Thrift streams can be transported over http (or https).
application/x-thrift is not official assigned but still in use
(s. https://issues.apache.org/jira/browse/THRIFT-3250).
Change-Id: I42e34b55da023b09bfef4658c89b1941ef4e574b
Reviewed-on: https://code.wireshark.org/review/20674
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a83496452a8511c2a6c93328fa12cb…
commit a83496452a8511c2a6c93328fa12cbaabf6bddf9
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Mar 22 14:55:53 2017 +0100
NBIFOM: fix a typo in a filter name
Change-Id: I3e8880300e14630151c91cd4d0cf7311a3497fb1
Reviewed-on: https://code.wireshark.org/review/20669
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=74ac452895c8a19e204eca4a32fb29…
commit 74ac452895c8a19e204eca4a32fb2984967fecbd
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Mar 22 14:50:24 2017 +0100
[BSSAP] Update comments from V 14.2.0
Change-Id: I943550891ae25bedea969db57fe20167137e1feb
Reviewed-on: https://code.wireshark.org/review/20668
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e5c9440d4f13294671267ee0f97693…
commit e5c9440d4f13294671267ee0f97693c449469cf0
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Mar 22 10:48:17 2017 +0100
[BSSGP] Dissect UTRA SI Container.
Change-Id: I043061784cc3863cf6d67c42042a74dd80e9741a
Reviewed-on: https://code.wireshark.org/review/20664
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b2ee6469910f2fb01da6b14378231d…
commit b2ee6469910f2fb01da6b14378231d645a72f8ca
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 22 08:51:46 2017 +0100
pcapng: Fix reading OPT_IDB_FCSLEN block
Changed to use correct option_id when reading IDB.
Change-Id: Id3a3b3cd95f9d7bcf51de001cfe246beb98590ad
Reviewed-on: https://code.wireshark.org/review/20663
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9477e47f794e5ce70db9c66ddc0c85…
commit 9477e47f794e5ce70db9c66ddc0c85b2a145e61a
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Wed Mar 22 00:32:14 2017 +0100
Netlink: update some values used in netlink
Change-Id: Id12caf9d40b0f53880ea4cc9200c340086e0b39b
Reviewed-on: https://code.wireshark.org/review/20661
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=af79cf1700fc4acc8933a409d8a5cc…
commit af79cf1700fc4acc8933a409d8a5cc56327d448c
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Sun Mar 12 10:19:08 2017 -0400
BGP: Fix incorrect desegment_len value.
Change-Id: I9a8f0b6877ce15f1e4672dd9dc884571de6f7f7e
Reviewed-on: https://code.wireshark.org/review/20510
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=40a5fb567a9bd1bb02d38ca33efe64…
commit 40a5fb567a9bd1bb02d38ca33efe64392230d27d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 10 03:46:53 2017 +0100
Restore interface selection after interface refresh
Remember which interfaces were selected for the next capture and restore
the selection (note that only active capture devices are stored in
"ifaces", so simply querying that list does not work).
The original change tried to fix duplicate devices (which were added
from "ifaces" to "all_ifaces") by clearing "ifaces",
this patch tries to
fix that by ignoring all non-PIPE devices while preserving "ifaces".
Now after refreshing the interfaces list in Qt, the selection in the
Manage Interfaces dialog is preserved. Removal of the bluetooth0
interface+refresh does hide the interface. Read+refresh does add the
interface (and preserve the selected state).
Change-Id: I26a78982f0327c835dc96da9c813e38f31d6cd3d
Fixes: v1.99.0-rc1-879-g55733ea170 ("fix scan_local_interfaces()")
Reviewed-on: https://code.wireshark.org/review/20477
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1f5c3044f920ef4cf9c345f81bd8a1…
commit 1f5c3044f920ef4cf9c345f81bd8a14bd7b4ffc9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 19 10:35:04 2017 -0400
Localize decimal point on time formatted columns.
Have the decimal point for sub-second values be locale specific.
Change-Id: I670471e8e5db6291e364d124eb48ddbaa6d8ff26
Ping-Bug: 12500
Reviewed-on: https://code.wireshark.org/review/20621
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d972ffc25d66a5ffd0e4464b9a4822…
commit d972ffc25d66a5ffd0e4464b9a48222136d0b842
Author: Rémy Léone <remy.leone(a)gmail.com>
Date: Tue Mar 7 14:32:22 2017 +0100
ieee802154: Time correction IE: Fix and add micro-second value
Change-Id: I52a22e7cfd8c0d5c054435678c891a3e1d0505b2
Reviewed-on: https://code.wireshark.org/review/20547
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=015217ac62698a539631323aa5551f…
commit 015217ac62698a539631323aa5551fd4b4ef9673
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Mar 21 12:08:21 2017 -0400
packet-ieee802154.c: Bugfix handling Auxilary Security Header for v2003
Bug: 4912
Change-Id: Ifc4922fecb1320d7992f8250a0fb2fa18723a514
Reviewed-on: https://code.wireshark.org/review/20659
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cfab7d55fd888d07a08a1d1b9fc7e4…
commit cfab7d55fd888d07a08a1d1b9fc7e4446956edf2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 21 19:10:40 2017 -0700
Handle LINKTYPE_SDLC.
Change-Id: I16a67f2d459cd6ebdbc7bdefd481fd95607af22a
Reviewed-on: https://code.wireshark.org/review/20662
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=eda05b5cd29291ee498abd5307a977…
commit eda05b5cd29291ee498abd5307a9775eaaf3d8ef
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 21 16:24:51 2017 +0100
[RANAP] Update to 3GPP TS 25.413 V13.2.0 (2016-06)
Change-Id: I1f6cc99761e13cd09811a4cebca145c47d5b4eca
Reviewed-on: https://code.wireshark.org/review/20657
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d9a71c496e15ce269a86c7e2749dbf…
commit d9a71c496e15ce269a86c7e2749dbf74672e918f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 21 14:36:38 2017 +0100
[RANAP] Dissect RIMInformation.
Change-Id: I39281c36e55b09427b3022362964c934be433ef1
Reviewed-on: https://code.wireshark.org/review/20655
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=041cc881a970512f8c63fe9a5a4689…
commit 041cc881a970512f8c63fe9a5a46897abd5da4a2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 21 14:16:53 2017 +0100
[BSSGP] Set cur_offset after expert info,UTRA SI Container - not
dissected yet to continur dissection.
Change-Id: Ibe3235b4238969e49915a6b9ecdd475f5a3cc620
Reviewed-on: https://code.wireshark.org/review/20654
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ca1f1141bee226281c5409d82ad98a…
commit ca1f1141bee226281c5409d82ad98af6b80ded2c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Mar 20 19:32:00 2017 -0700
More URL updates and additions.
Change-Id: Id7fbfc3bd0bf94163228ad4e6de87b70e886edb6
Reviewed-on: https://code.wireshark.org/review/20652
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7c2e0a239adcf0432cdff7478b7e91…
commit 7c2e0a239adcf0432cdff7478b7e91df49f93af9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Mar 20 19:27:06 2017 -0700
Update some URLs.
Go to the Wayback Machine for now; give URLs for the specific documents
in that directory on the IBM FTP site, and indicate what documents they
are.
Change-Id: Ica0378e8e8a29b9367a6ebd3ecb41a06d2e93a15
Reviewed-on: https://code.wireshark.org/review/20651
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f6e04681fcae10c01ceaba79be7364…
commit f6e04681fcae10c01ceaba79be73642bc44faec1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 16:56:38 2017 +0100
TLS13: add oid_filters(48) extension for draft -19
Change-Id: I80b05bc81e77a70f2e0c8e1fe706ce5bd0a33981
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20593
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f033925557c6d91d00273de4d0e3dd…
commit f033925557c6d91d00273de4d0e3ddad5ab21d87
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 19:11:45 2017 +0100
TLS13: fix key expansion for AES256
"key_len" refers to the key length of an algorithm, not the block size.
For AES128 both are the same, but for AES256 it is different.
Change-Id: Ic657265d90323eb224b133b23232cb809264ab64
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20598
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c0d6b0ec313432af1f377f696f3774…
commit c0d6b0ec313432af1f377f696f37746ad7a84cef
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 20 21:28:44 2017 +0100
LLRP: Fix LLRP Custom Parameter Decoding
param_end is the offset+len... and also vendor unknown is not limited to uint32
Bug: 13473
Change-Id: I68cf435f52f28a4a399812f715b38edeecd1e78c
Reviewed-on: https://code.wireshark.org/review/20650
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2d0ae39bd6708f00d2b6fb357c1146…
commit 2d0ae39bd6708f00d2b6fb357c1146dcf4d3dbb8
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 21:16:03 2017 +0100
ftypes: move get_value_ptr into the union
Delete get_value_ptr from struct _ftype_t, make it
part of the get_value union.
Change-Id: I947331069662a7043bd838e622d286629cc7be9a
Reviewed-on: https://code.wireshark.org/review/20647
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=45b8a1e7ea18d62f78aa6f7812d91a…
commit 45b8a1e7ea18d62f78aa6f7812d91a576811ae72
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 20 10:24:37 2017 -0400
MIPv6: Bugfix proto_tree_add_item_ret_uint usage.
hf_mip6_ipv4ha_ha field is an FT_IPv4 type, so proto_tree_add_item_ret_uint can't
be used.
Also correct option tree display noticed while debugging above issue.
Bug: 13499
Change-Id: I6da281567f47d08864575e41fa2a29347d55613a
Reviewed-on: https://code.wireshark.org/review/20646
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e6525ab178265eba9a937675df03a4…
commit e6525ab178265eba9a937675df03a4643b8a5a9b
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Mon Mar 20 00:40:59 2017 -0400
packet-nvme-rdma: Add support to dissect send with invalidate
This patch adds support to dissect nvme fabric cqe which is sent using
rdma send_with_invalidate opcodes.
Change-Id: I90d271526f04da047295f496e77b04f606a29ad4
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/20645
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2fd8c1778afff80794742c636b1094…
commit 2fd8c1778afff80794742c636b1094eae34d671e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 19:31:02 2017 +0100
Replace PARAM_TREE_ADD_SPEC_STAY macro by proto_tree_add...
(Make checkhf more happy)
Change-Id: I27ff7d9ba1351bdc7dc1b801950ffdfaf3266629
Reviewed-on: https://code.wireshark.org/review/20634
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66dc0aecab655d64a02d34209b7301…
commit 66dc0aecab655d64a02d34209b73016988b6faa5
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sun Mar 19 22:17:30 2017 -0400
capinfos: Remove obsolete message from print_usage() report.
Commit 6b84ddee83e70aff944da084129624226b7a32fa made libcrypt a
mandatory dependency. Remove overlooked help message claiming
that hashing support is not present.
Change-Id: I908dbbf4d37253fe01513988a42f074322344c0f
Reviewed-on: https://code.wireshark.org/review/20644
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c258b6b0564f3ef211615f8f19d906…
commit c258b6b0564f3ef211615f8f19d9067a9364bfe6
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 20:57:43 2017 +0100
ftypes: move get_value_uinteger into the union
Delete get_value_uinteger from struct _ftype_t, make it
part of the get_value union.
Change-Id: I4a6c8341676c442e2bf8ae3b8f771b72161d133c
Reviewed-on: https://code.wireshark.org/review/20640
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=01b460fb77ebf8ea697c4a08c9f106…
commit 01b460fb77ebf8ea697c4a08c9f106ad59df6b0e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 16:26:05 2017 +0100
proto(.c): remove unused check and fix indent..
Change-Id: I30b44cb0145f76c3929cac92337756a4164df1d2
Reviewed-on: https://code.wireshark.org/review/20609
Reviewed-by: Juan Jose Martin Carrascosa <juanjo(a)rti.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e94bd9b4eeeb882c83b0c1624e9f63…
commit e94bd9b4eeeb882c83b0c1624e9f63b77e9c3d5d
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 20:32:20 2017 +0100
ftypes: move get_value_sinteger into the union
Delete get_value_sinteger from struct _ftype_t, make it
part of the get_value union.
Change-Id: I3127252cafc62389ce426639992f1d59f7ac9731
Reviewed-on: https://code.wireshark.org/review/20637
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2a3473820da5834b7d3732a3c6e314…
commit 2a3473820da5834b7d3732a3c6e314245839a673
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 20:45:20 2017 +0100
eth: remove unnecessary NULL checks
We may safely call proto_item_add_subtree() when the item is NULL.
Make sure that expert info are not filtered out by a NULL check.
Change-Id: I4516cd750c9b0b568c8de9adaad757d0ea769ad6
Reviewed-on: https://code.wireshark.org/review/20639
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=401f9018738243b2568b13662e0655…
commit 401f9018738243b2568b13662e0655dc3403917b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 15:51:17 2017 +0100
TLS13: update pre_shared_key lengths for draft -19
Change-Id: Idb9741fba0a2dfcad503e7bd033311bffd54a022
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20592
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=18c4d1bb1f89dc9a75fbd3cb85a602…
commit 18c4d1bb1f89dc9a75fbd3cb85a6024ceb2b3775
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 13:53:40 2017 +0100
TLS13: update HRR for draft -19
Change-Id: I4b229350fbc6740b307e52086cc0529a888c8eb4
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20587
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2d6e634f34559b9dea7affa51f9309…
commit 2d6e634f34559b9dea7affa51f93090333df8e5c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 20:42:07 2017 +0100
dissectors (and tools): fix typo dependant -> dependent
found by lintian
Change-Id: I50907b9721f3941c291cf322916f553ab3b4b168
Reviewed-on: https://code.wireshark.org/review/20638
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=784169bcb779e7c3c5092fd70435c1…
commit 784169bcb779e7c3c5092fd70435c1192eb8f18c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 19:33:21 2017 +0100
h245 (asn1): fix typo identifer -> identifier
found by lintian
Change-Id: I15f734e1d2218756867cefbd311b620c8a84e9ac
Reviewed-on: https://code.wireshark.org/review/20635
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ca13359f845b105a30408782234041…
commit ca13359f845b105a304087822340413b2fc01900
Author: Apeksha Singhal <apeksha.singhal(a)gmail.com>
Date: Wed Mar 8 22:15:22 2017 +0530
nstrace: Updating Additional TCP debugrec labels according to tracedebug option
Change-Id: I4fc9efba068078f9ae6be4d74fb6fbcb9a6545c3
Reviewed-on: https://code.wireshark.org/review/20450
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9a81d2ec3764f33a2525c66d784e24…
commit 9a81d2ec3764f33a2525c66d784e24f00a852916
Author: erikdejong <erikdejong(a)gmail.com>
Date: Sun Mar 19 19:19:11 2017 +0100
Fix: UA3G read past end of tvb + NOE key descriptions
packet-ua3g.c:
Start tone device routing packet causes exception because it adds a subtree with
length 6 where it should be 3. Changed 6 to 3.
packet-noe.c:
Key description is incomplete because buffer reserved is only 10 bytes long and
key descriptions are up to 23 bytes long. Changed buffer length to 24.
Bug: 13502
Change-Id: I8212d23c650efd341e87f766a80a887ef82f4b0b
Reviewed-on: https://code.wireshark.org/review/20633
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0fdbaa4f1855594e7a48bc3b1ff9e3…
commit 0fdbaa4f1855594e7a48bc3b1ff9e31e835cb860
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Mar 19 11:01:04 2017 -0700
Make GTK compile with HAVE_PCAP_REMOTE on macOS with clang-800.0.42.1.
Change-Id: I36bf1e39541fc55bc315f12f56dfd7ed7e0cc207
Reviewed-on: https://code.wireshark.org/review/20632
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c87cf1a81a280cc285a4a63bd989f0…
commit c87cf1a81a280cc285a4a63bd989f04a6c7adb54
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 19 18:44:38 2017 +0100
Remove a reference to deleted doc/README.epan_child
Change-Id: I521674267873fe32c3ff5b53c9fb6a9e971d8772
Reviewed-on: https://code.wireshark.org/review/20631
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=ea5b19a723816dd9840f1861b5f6fd…
commit ea5b19a723816dd9840f1861b5f6fdc3dc188111
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 19 11:27:03 2017 -0400
SMB2: Remove useless blurbs
Spacing differences or just providing name of dissector + field name is
not a useful use of the blurb field.
Change-Id: Ie30e53733977715cdcb0030c064afe897e6766eb
Reviewed-on: https://code.wireshark.org/review/20624
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b6e37131f82fb76532ce304cf96aa0…
commit b6e37131f82fb76532ce304cf96aa0e50a8799d0
Author: Jeremy Hitt <jeremy.hitt(a)isilon.com>
Date: Sat Mar 18 23:40:18 2017 -0400
Enhance SMB2 dissector to include negotiate contexts in negotiate requests and
responses
Add session setup flag for encryption
Change-Id: Iff85751ae635d92cf752426f4ceb7398b99b4799
Reviewed-on: https://code.wireshark.org/review/20612
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=78634bbe5281d10dc9083958c80018…
commit 78634bbe5281d10dc9083958c80018787f040960
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 16:59:58 2017 +0100
ciscodump (man): fix typo dependant -> dependent
found by lintian
Change-Id: I5ce951fca2213d3d18807cde061dea201a36999f
Reviewed-on: https://code.wireshark.org/review/20628
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4db2d40ea9368166140767b1c29609…
commit 4db2d40ea9368166140767b1c29609c26611b5de
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 16:55:49 2017 +0100
response_time_delay_dialog (Qt): fix typo reponse -> response
Change-Id: Ib29cca71a4ffe4e44f341d9de5e3da603c7b3f15
Reviewed-on: https://code.wireshark.org/review/20627
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9a8d90698b936be3ef941a37c0c053…
commit 9a8d90698b936be3ef941a37c0c053b67b086a7d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 16:54:49 2017 +0100
dissector: fix typo reponse -> response
Change-Id: I5d12b7038c0ed602cd5b3b416c35893986018f85
Reviewed-on: https://code.wireshark.org/review/20626
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b157a5d80c683da26e242eab398109…
commit b157a5d80c683da26e242eab398109b9b4ef785b
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sun Mar 19 00:37:30 2017 -0500
capinfos: Ensure empty columns are written in -T reports.
When using capinfo's -T report insure that proper placeholders are written
to the records if any of the optional pcapng SHB block values are missing
so as to maintain column alignment with the header record.
Augment the comments about the potential silliness regarding the dumping
of pcapng comments in capinfos -T reports.
Change-Id: I43df4aeed2235f7ed9c67519c249361ab00680f1
Reviewed-on: https://code.wireshark.org/review/20613
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dfed842147e93fd95b5d10a578522e…
commit dfed842147e93fd95b5d10a578522ec1eaddca35
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 19 17:07:55 2017 +0100
dissector: fix typo identifer -> identifier
Change-Id: Id23d219f06c2c504b9e4c845a1bf9d4c2531bc93
Reviewed-on: https://code.wireshark.org/review/20629
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ed234da840da24625e63e2146f81a9…
commit ed234da840da24625e63e2146f81a993f7f39b74
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 19 15:33:28 2017 +0100
Make GTK compile with HAVE_PCAP_REMOTE on Linux with gcc6
Change-Id: I87cbe47d34b768cb50be6580f85e8175103686c0
Reviewed-on: https://code.wireshark.org/review/20620
Petri-Dish: Jörg Mayer <jmayer(a)loplof.de>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=1dde98826551e1c71c6cd880ef0e9e…
commit 1dde98826551e1c71c6cd880ef0e9e2e1361ccab
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 16 20:45:34 2017 +0100
Lua: Add some ProtoField tests
Add tests for abbrev and name validation.
Add tests for signed integer base values.
Change-Id: I0bd65c6633b44ae998880f528c22afc22c87529d
Reviewed-on: https://code.wireshark.org/review/20568
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0b6b152694762bd5783569acbae48e…
commit 0b6b152694762bd5783569acbae48e9397d2b85f
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 19 13:47:11 2017 +0100
Remove echld/.
It has been unsupported for some years and when talking about removing it
in the past I received some positive and no negative feedback.
There is one instance of echld left:
capchild/capture_sync.c: * echld might have already reaped the child.
Can that case be removed or should be comment be updated to something more
accurate? (left for a separate patch)
Change-Id: Idac397158dd86fd0728eb95379449ee4a463fc28
Reviewed-on: https://code.wireshark.org/review/20619
Petri-Dish: Jörg Mayer <jmayer(a)loplof.de>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a65c0c457668d7524dffefb17cc4e6…
commit a65c0c457668d7524dffefb17cc4e69a77a29f3c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Mar 17 14:37:25 2017 -0400
MySQL: Bugfix state handling
A "conversation" is created for MySQL to store "conversation data"
including
current state. The problem is that it's updated every time a packet is dissected
so depending on how packets are viewed, dissection may change.
Fix that by only allowing conversation state to be set on first pass and have
the state cached with each individual pdu, keyed by tvb_raw_offset() (the key
when you have multiple pdus in a TCP packet).
Change-Id: I2c7e38be63501360d709210a509aa0dfa482bfd4
Reviewed-on: https://code.wireshark.org/review/20600
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0bcd255a5bcbcdcf223fa7d9eee291…
commit 0bcd255a5bcbcdcf223fa7d9eee2918b8c43e979
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Mar 19 08:09:10 2017 -0700
[Automatic update for 2017-03-19]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I5d2807ce653df495722663def31164e2342b0d89
Reviewed-on: https://code.wireshark.org/review/20622
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=5d9cfea5d9b21b6f3ab285938507d6…
commit 5d9cfea5d9b21b6f3ab285938507d6cad8843c63
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 13:31:53 2017 +0100
ftypes: move get_value_uinteger64 into the union
Delete get_value_uinteger64 from struct _ftype_t, make it
part of the get_value union.
Change-Id: I2b06efb7691c1bd4089994849373ab8b5ff0bcc7
Reviewed-on: https://code.wireshark.org/review/20618
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5bb8f1a2418863debe2b935c38a769…
commit 5bb8f1a2418863debe2b935c38a769c8e5adbf53
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 19 13:08:06 2017 +0100
ftypes: move get_value_sinteger64 into the union
Delete get_value_sinteger64 from struct _ftype_t, make it
part of the get_value union.
Change-Id: I0113f70ab0aadd1aa655466e896e3acce6c8faeb
Reviewed-on: https://code.wireshark.org/review/20617
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e66b05fa9da469bc2d6e7127977bf9…
commit e66b05fa9da469bc2d6e7127977bf93d2b477a0a
Author: Jim Young <jyoung(a)gsu.edu>
Date: Mon Mar 13 21:04:24 2017 -0500
tshark: Optionally delimit packet summary columns with tabs
This patch augments tshark's -T report with a "tabs" option.
When the -T tabs option is enabled an ASCII horizontal tab character
is inserted between each column of the human-readable one-line
packet summary record.
Change-Id: Id10a6e21e231eb2e52b6342ed05399db1a5fcfdf
Reviewed-on: https://code.wireshark.org/review/20537
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2890e415bbec3ddad7c0485067dd09…
commit 2890e415bbec3ddad7c0485067dd09f1e503c84f
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 19 12:26:28 2017 +0100
Fix various compile warnings turning error on Linux with gcc6 when
compiling with HAVE_PCAP_REMOTE (and ENABLE_ECHLD)
Change-Id: If5524f2d3dcacca9c82a46167480c8436dd8b1b2
Reviewed-on: https://code.wireshark.org/review/20615
Petri-Dish: Jörg Mayer <jmayer(a)loplof.de>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=74e793e8bac3013f0474fdf398608b…
commit 74e793e8bac3013f0474fdf398608ba24506307c
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Mar 16 22:34:49 2017 +0100
ftypes: create a get_value union, move get_value_floating into the union
Change-Id: I6bbaf6a7c8a3124e5eab7a7b97c6be082fe8beff
Reviewed-on: https://code.wireshark.org/review/20611
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fd9a595aedf4aa15cb5460766175a1…
commit fd9a595aedf4aa15cb5460766175a19cd2e75047
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 16 19:28:50 2017 +0100
ICMP: display C-Type when unknown object in extension
Change-Id: I465341919675783999f4b131a7485ef2f6b8059f
Reviewed-on: https://code.wireshark.org/review/20583
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8271aa85edeaa73e2cb2cd54a32a26…
commit 8271aa85edeaa73e2cb2cd54a32a26d6bfb7bf1f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 16 20:31:24 2017 +0100
LLRP: Display unknown data when vendor is unknown...
Bug:13473
Change-Id: Ia8ba177489be72c76b8b1168098de329ffcb8356
Reviewed-on: https://code.wireshark.org/review/20580
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2e76b588407107c7d530cfb74a684b…
commit 2e76b588407107c7d530cfb74a684bca38281885
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 19 12:40:04 2017 +0100
Fix warning turning error:
/home/jmayer/work/wireshark/git/ui/qt/manage_interfaces_dialog.cpp:273:33: error:
variable ‘link_type_name’ set but not used [-Werror=unused-but-set-variable]
By commenting out all lines using this variable for now.
Change-Id: I8f074b24f86ee2063fc545cabd99d446b31a06ec
Reviewed-on: https://code.wireshark.org/review/20616
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=0297e374b88891626fe2583f12aac2…
commit 0297e374b88891626fe2583f12aac29b695a5336
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Mar 17 07:59:05 2017 +0100
sharkd: support for expert tap.
Change-Id: I7e5b27b5c25c01f015dd8b33c541cbda2c426726
Reviewed-on: https://code.wireshark.org/review/20578
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=0e244e01fe608dccf8429fb59d65dc…
commit 0e244e01fe608dccf8429fb59d65dc9006f6b9a3
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 14:44:18 2017 +0100
TLS13: update CertificateRequest dissection for draft -19
Removed supported_signature_algorithms and certificate_authorities
dissection for TLS 1.3. In preparation for certificate_authorities,
extract the certificate_authorities dissection.
Change-Id: I58884b02744ac53f226d3a3e6c491219f58facc0
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20588
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a5bb470a553cbd4dc90a874760ec17…
commit a5bb470a553cbd4dc90a874760ec17e4bd914f7d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 13:39:13 2017 +0100
TLS13: update end_of_early_data to draft -19
It changed from an alert to a handshake message.
Change-Id: Ic24776e612a291153290543ba1ec8680d9d74264
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20586
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a16771f34b60cc9862fae885d681d2…
commit a16771f34b60cc9862fae885d681d2eeb4530d4d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 15:10:33 2017 +0100
umts_fp: Fix Dereference of null pointer found by Clang analyzer
Access to field 'paging_indications' results in a dereference of a null
pointer (loaded from variable 'umts_fp_conversation_info')
Change-Id: Iacddb9b2e9b49f50178e82f48273757885331c2f
Reviewed-on: https://code.wireshark.org/review/20605
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8e7e3cc816b1cbec29f29113eb469…
commit a8e7e3cc816b1cbec29f29113eb469ab9a8aa19d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 14:48:15 2017 +0100
TLS13: add certificate_authorities (47) dissection for draft -19
Ping-Bug: 12779
Change-Id: Ic21869f73ffa1ac29b6a50102030eca85f533d37
Reviewed-on: https://code.wireshark.org/review/20589
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=870a8c49ecf3142170f071ece576b4…
commit 870a8c49ecf3142170f071ece576b4f9f66eeaf2
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 14:55:32 2017 +0100
TLS13: update pre_shared_key references to draft -19
Also rename the fields for consistency.
Change-Id: I49f4c9b1d308264e7849df92e1b1ac4a93a94766
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20590
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2337b7bd20e6db80797384a03a83a4…
commit 2337b7bd20e6db80797384a03a83a45c4b58a580
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 15:46:14 2017 +0100
TLS13: update early_data for draft -19
Added new max_early_data_size for NewSessionTicket.
Change-Id: I6886415d03ffdce983b49649ad52ff0f897f2f77
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20591
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a126c8093dbacb60e525dc9b306a27…
commit a126c8093dbacb60e525dc9b306a2726f9ceb97a
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Mar 16 22:09:44 2017 +0100
ftypes: rename get_value to get_value_ptr
This is in preparation for introducing a get_value union, similar to
set_value.
Change-Id: Id0cf913a616e0314638f1531836c3136ed02631d
Reviewed-on: https://code.wireshark.org/review/20610
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=33cbeb68cb33414502e6610a684588…
commit 33cbeb68cb33414502e6610a6845880efd109bc6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 15:15:29 2017 +0100
CIP: Fix Assigned value is garbage or undefined found by Clang Analyzer
Change-Id: Ie3d97ef22c6c8f69855f747f78b86d94f1091fa9
Reviewed-on: https://code.wireshark.org/review/20606
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2868b4a09a8d730e07a7da1bcd7b89…
commit 2868b4a09a8d730e07a7da1bcd7b8923a5311611
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 15:19:40 2017 +0100
cipsafety: Fix Dereference of null pointer found by Clang Analyzer
Change-Id: Id5d9972f527e94164b61bf420ddf9c444d90235b
Reviewed-on: https://code.wireshark.org/review/20607
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a20fd0a8e1a500ddd7bc376c85372d…
commit a20fd0a8e1a500ddd7bc376c85372d03ff938b88
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 18 14:52:15 2017 +0100
Makefile.am (dissectors): fix indent (use tabs)
Change-Id: I2706f9d26731006216f111b65b718061503bd75e
Reviewed-on: https://code.wireshark.org/review/20603
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=88c0f52f3423468e501655d2aa6a1e…
commit 88c0f52f3423468e501655d2aa6a1eaccc0575e2
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Mar 18 09:25:43 2017 -0400
MySQL: Make value_string_ext variables static
Change-Id: I83322dc432e2f8acbaccdfca600ec891106ae815
Reviewed-on: https://code.wireshark.org/review/20602
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=68136e70bc3e1b1443d1c494e53cc1…
commit 68136e70bc3e1b1443d1c494e53cc1d6e68d512c
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Fri Mar 17 19:44:30 2017 +0200
FP/MAC: Cosmetic fixes
Changing 2 things shown in the dissection tree:
1. For FP's E-DCH CRC: separating the bit string into nibbles.
2. For MAC: Adding a missing ')' in one of the strings
Change-Id: Id13fa3676cc77c890cba4191c77fdbb5f9cb1c5e
Reviewed-on: https://code.wireshark.org/review/20597
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cea41157fde841ca8771ef1f9919ec…
commit cea41157fde841ca8771ef1f9919ecba09de4faa
Author: Birol Capa <birol.capa(a)siemens.com>
Date: Thu Mar 16 13:55:17 2017 +0300
PROFINET: Support the new BlockVersion 1.1 of the record PDPortStatistic.
PDPortStatistic with BlockVersionLow = 1 has 2 bytes CounterStatus while
PDPortStatistic with BlockVersionLow = 0 has 2 bytes Padding.
Change-Id: I39783ad29993501249bfa7875760b505ded6a8e9
Reviewed-on: https://code.wireshark.org/review/20563
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c9efc5d0ab19044554ca3cb3829c66…
commit c9efc5d0ab19044554ca3cb3829c668a2555a525
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Mar 16 22:34:49 2017 -0400
packet-mysql.c: Some minor improvements
1. Created a few value_string_ext.
2. Removed tree check for an expert info.
Change-Id: Iadf55ecad1b1ddf249bfccff0d232883313fab83
Reviewed-on: https://code.wireshark.org/review/20599
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=693a61e2d5d137680cc00940fb3e96…
commit 693a61e2d5d137680cc00940fb3e96bf9f73bdfb
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Mar 17 18:10:59 2017 +0100
S1AP: fix dissection of Reroute NAS Request message
The S1 Message information element contains a full S1AP PDU, not
only the Initial UE Message payload
Change-Id: Ibf416ea45efbd65b341ba3ce1cc5b02b0747f46b
Reviewed-on: https://code.wireshark.org/review/20595
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e40b65d5b01f9d5fb05636f14f3d3…
commit 1e40b65d5b01f9d5fb05636f14f3d3769e541a56
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 17 18:02:15 2017 +0100
TLS13: add new supported_versions value for draft -19
Change-Id: I2e5fd001bb8d4312c6267f530b66d6687865112e
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20596
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c8112886a7020b14e97ab4c8ccbfe3…
commit c8112886a7020b14e97ab4c8ccbfe3a36db29930
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Wed Mar 15 21:09:16 2017 +0200
RNSAP: Call right RRC dissectors for payload.
According to TS 25.423 both 'Uplink Signaling Transfer' and 'Downlink
Signalling Transfer' carry CCCH messages.
Hence the RRC-UL-CCCH and RRC-DL-CCCH dissectors should be called for the 'L3
Information' fields in these messages (respectively)
Change-Id: Ief2aab77d2851746e6374729eaf8a0a5b115d7d7
Reviewed-on: https://code.wireshark.org/review/20560
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d5d85924c7a721da82f2684e684bc…
commit 0d5d85924c7a721da82f2684e684bceda9d69826
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Mar 17 09:45:10 2017 +0100
[proto.h] Make proto_tree_add_split_bits_item_ret_val() usable from
plugins.
Change-Id: Ibcfdb9a3a33b0f12bf1f4752654bde279776768a
Reviewed-on: https://code.wireshark.org/review/20579
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=795b4594434d2e11cea0370d97232d…
commit 795b4594434d2e11cea0370d97232df8379d9899
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 16 19:46:28 2017 +0100
Qt: Pluralize packet count in Size string
Change-Id: Ifb23f4d558aa30df4ec436e42a4e23b23c2af110
Reviewed-on: https://code.wireshark.org/review/20566
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=144a4acb29660b51b01ae3f99bb7d2…
commit 144a4acb29660b51b01ae3f99bb7d2499a395a56
Author: Éric Piel <piel(a)delmic.com>
Date: Thu Mar 16 21:00:40 2017 -0400
Bugfix GIOP LocateRequest v1.0
Bug: 13488
Change-Id: If4717dee805fdb3e910e2ea8ef16352294b305c6
Reviewed-on: https://code.wireshark.org/review/20575
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=77ee625fcd87b97e9c1ecc042e0217…
commit 77ee625fcd87b97e9c1ecc042e02176d8dea91fd
Author: Philipp Hancke <fippo(a)andyet.net>
Date: Thu Mar 16 22:25:50 2017 +0100
packet-rtcp: enable REMB support
enables support for the REMB dissector. This looks for the
magic string REMB (0x52454d42) before falling back to the current
behaviour.
This is consistent with the guidance in
https://tools.ietf.org/html/draft-alvestrand-rmcat-remb-03#section-2.2
Kudos to whoever wrote this, it just works.
Change-Id: I8b7420d8cfdb1cfe1bed8c23d5103a2f5bac1937
Reviewed-on: https://code.wireshark.org/review/20573
Reviewed-by: Nils Ohlmeier <github(a)ohlmeier.org>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=663a3606c5a8a87dc2fe2afdbab0b8…
commit 663a3606c5a8a87dc2fe2afdbab0b8906cf34893
Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Date: Mon Feb 27 20:42:06 2017 +0100
ZigBee: Add attribute and command names from Prepayment used with GBCS
The Great Britain Companion Specification specifies how energy meters
will communicate in the UK. This patch adds names for attributes and
commands from the Smart Energy Prepayment cluster that are used within
that specification.
Bug: 13360
Change-Id: Iaf93dd5ef6769abba72c67d498c244ba0e15d1d6
Reviewed-on: https://code.wireshark.org/review/20552
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3eb71158e6e37d1835fc578fb8cf4c…
commit 3eb71158e6e37d1835fc578fb8cf4cf35ea62463
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Mar 16 21:24:27 2017 +0100
ZigBee ZCL IAS: fix dissection of ZoneStatus bitmask
Bug: 13493
Change-Id: Ide076bce8032767477df804a97981009a0f64828
Reviewed-on: https://code.wireshark.org/review/20569
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c6166754140907f02b5a9457f74df2…
commit c6166754140907f02b5a9457f74df28e1ed7d2bc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Mar 16 21:25:33 2017 +0100
ZigBee ZCL General: fix a typo
ZigBee is a little endian protocol. Let's not use ENC_BIG_ENDIAN (even if for a 1
byte field it is harmless)
Change-Id: I83f9d0e6c22af83ca0417afeb0244113b009abfe
Reviewed-on: https://code.wireshark.org/review/20570
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea63360f4f73300f13ef247a33fb05…
commit ea63360f4f73300f13ef247a33fb0531baa76a2a
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 16 15:09:20 2017 +0100
[H248 3GPP] Add dissection of IP transport package.
Change-Id: If0b7d4a46dd251816d9a093c394743838112824d
Reviewed-on: https://code.wireshark.org/review/20565
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a8478844f35c05f7a2d0f13bce0215…
commit a8478844f35c05f7a2d0f13bce02153f575b5add
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 16 14:36:19 2017 +0100
Lua: Run protofield test with tree
Only perform the protofield with a tree.
Change-Id: I93caeb505d1138a57c846ea6c295e5a44d72023c
Reviewed-on: https://code.wireshark.org/review/20564
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f7b784c968327b9204f50b0540968d…
commit f7b784c968327b9204f50b0540968dfd286ac8f0
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Wed Mar 15 08:28:15 2017 +0000
CoAP: Enhancements to improve conversation recording.
Conversation recording now uses a hash map instead of a tree. URI
reconstruction for responses has also been added to assist Thread CoAP
decoding.
Change-Id: I83dc0dc48534d5182cf37ba50dad67e1b095188a
Reviewed-on: https://code.wireshark.org/review/20553
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5e934d583fcbda9bd4d96b32902dcc…
commit 5e934d583fcbda9bd4d96b32902dccd8fc749186
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Feb 9 14:58:25 2017 -0500
proto_dlg.c: Convert GSList into wmem_tree
Change-Id: Ice643361e91bded91547428d7fbb7cdff969664f
Reviewed-on: https://code.wireshark.org/review/20383
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c7f554c5132397f4237b1141d64bfc…
commit c7f554c5132397f4237b1141d64bfc76cbaaad6c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Mar 16 09:02:27 2017 +0100
TGPP.xml: add a new enum value for Specific-Action AVP
Change-Id: If45c6b196fc55ff7452f83e022b585cb9a816d53
Reviewed-on: https://code.wireshark.org/review/20562
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c10788cbd58a3708c3f6a3819f4674…
commit c10788cbd58a3708c3f6a3819f46743f5d2850a4
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Thu Mar 16 07:34:28 2017 +0100
g_assert on device.if_info.name to prevent undefined behaviour.
Change-Id: Id730eb0e846e557c2f5a47139b480362a0b2a777
Reviewed-on: https://code.wireshark.org/review/20561
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=618ca466aae3637d641a6e3101b62f…
commit 618ca466aae3637d641a6e3101b62f1e552a7ee1
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Mar 13 15:20:49 2017 -0400
Add support for verifying CIP Safety CRC values.
Change-Id: I44f7ff6980f27b1a0d4199a91f9b217aec7e4652
Reviewed-on: https://code.wireshark.org/review/20557
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=05b61a21a209f43de2926b808ed3bc…
commit 05b61a21a209f43de2926b808ed3bc151aa1991e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Mar 15 10:30:41 2017 +0100
QUIC: Add TBKP (Token Binding Key Params) tag
Change-Id: Ie7be38fc605d4c93f4e5488c9472909f6644e8c5
Reviewed-on: https://code.wireshark.org/review/20559
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=72e7482f76443c173562afa9694be3…
commit 72e7482f76443c173562afa9694be32d4c021b39
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Mar 15 09:27:55 2017 +0100
dhcpv6: Add Captive Portal option (103)
Change-Id: Ib56a1e9d1353d3245715bb0b5ba20672548bb9c1
Ping-Bug: 13483
Reviewed-on: https://code.wireshark.org/review/20555
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2210ef1c76b3b4d9cd0b8c8692f36e…
commit 2210ef1c76b3b4d9cd0b8c8692f36ebd7c333c1c
Author: Birol Capa <birol.capa(a)siemens.com>
Date: Tue Mar 14 17:42:15 2017 +0300
PROFINET: Remove AMFilterData Block
Since AMFilterData block is removed from PROFINET specification,
related parts are removed from dissector.
Change-Id: I0f9f346fd409fc0cb78f4d7a8ca5869229d68bed
Reviewed-on: https://code.wireshark.org/review/20546
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4f8a0f2dd7a8ef88282adbeecf1eb3…
commit 4f8a0f2dd7a8ef88282adbeecf1eb3485045d73c
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Mar 15 18:11:51 2017 +0100
[GTPv2] Don't try to dissect Target to Source Transparent Container it's
not so easy to determine it's content.
Change-Id: I58d5caeb5b7264afa1ed28e84c0207610d5c13d2
Reviewed-on: https://code.wireshark.org/review/20558
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0837dd23ec0df1446c2912f378eb9f…
commit 0837dd23ec0df1446c2912f378eb9fefe3fe362d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 15 09:21:18 2017 +0100
Lua: Add absolute time base values
Add ABSOLUTE_TIME_* defines to the base table in init.lua for use
in ProtoField.absolute_time.
Change-Id: I5c99eafdac97655d71fd4f3374294cd587afaf0a
Reviewed-on: https://code.wireshark.org/review/20543
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=0156f22c62c1d955724ae44ca607c9…
commit 0156f22c62c1d955724ae44ca607c95e2944aa26
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 15 09:30:37 2017 +0100
Lua: Merge sep and str tables into base
Also add documentation strings to the base values.
Change-Id: I00ac8f154fdd0382106ed27d740e16956520be97
Reviewed-on: https://code.wireshark.org/review/20554
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b8ede14d44b4fb165787a000bc3f69…
commit b8ede14d44b4fb165787a000bc3f6962f285d23b
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Mar 15 09:37:03 2017 +0100
ftypes: move set_value_floating into the union
Delete set_value_floating from struct _ftype_t, make it
part of the set_value union.
Change-Id: Ic00e1c70488ddc4422c34657c62af7dc07db02d9
Reviewed-on: https://code.wireshark.org/review/20556
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f190a92bc257f383d7821094aa594d…
commit f190a92bc257f383d7821094aa594d95eaedac0e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Mar 13 11:10:08 2017 +0100
Qt: Disable "Show hidden interfaces"
Disable the "Show hidden interface" option until bug 13354 is fixed
because it's not possible to capture from hidden interfaces yet.
Ping-Bug: 13354
Change-Id: I428c2698485f0c7c2d9a8ab8408d7129af5fecf1
Reviewed-on: https://code.wireshark.org/review/20528
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=a75a21fb31207ec724554363e2251b…
commit a75a21fb31207ec724554363e2251b935380cd17
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Tue Mar 7 23:23:52 2017 +0200
Added Heuristic dissectors for the following UMTS FP channels:
DCH (Downlink and Uplink), FACH, RACH and PCH
Note that the existing heuristic dissection function does not correctly dissect any of
the above and, frankly, I'm not sure which cases it covers.
Change-Id: I832bfdccc9ae760a42a4c6537052ee2fee9262b4
Reviewed-on: https://code.wireshark.org/review/20439
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d448d77ac7a369e085eef6713282a4…
commit d448d77ac7a369e085eef6713282a4df376b4646
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Tue Mar 14 16:56:47 2017 +0000
ZigBee NWK: Add zero length beacon checks to avoid assert.
Add a zero length check on beacon to avoid assert when beacon payload is
non existent.
Change-Id: I016a97bda1590b8edc68db4f47e5c814e4eb8e0a
Reviewed-on: https://code.wireshark.org/review/20550
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5f4f62bde027b131dcfe1b3914e4bf…
commit 5f4f62bde027b131dcfe1b3914e4bf9d4a3f6987
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Mar 14 23:00:36 2017 +0100
ftypes: move set_value_sinteger64 into the union
Delete set_value_sinteger64 from struct _ftype_t, make it
part of the set_value union.
Change-Id: I76668f0a6455c5d75c703cd4f440757601246bdb
Reviewed-on: https://code.wireshark.org/review/20551
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=42d410b8e37a5be47979758ae69dc3…
commit 42d410b8e37a5be47979758ae69dc33327e6369c
Author: D. Ulis <daulis0(a)gmail.com>
Date: Tue Mar 14 12:57:12 2017 -0400
CIP: Log more errors when expected data is missing
1. CIP: Instead of exiting early in dissect_cip_generic_service_req/rsp when there is
no data, keep processing so that a malformed packet warning will be displayed when there
should be data.
2. CIP Safety: Remove copy-paste. Use load_cip_request_data
3. CIP Safety: Use more constants.
Change-Id: Ic364201f1e587b43cf2bda407fb77b50032974ae
Reviewed-on: https://code.wireshark.org/review/20549
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=17953ceea338598a7217edfab72f22…
commit 17953ceea338598a7217edfab72f22a623d62f9f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Mar 14 10:30:20 2017 +0100
Lua: Check for no table in ProtoField unit string
When using base.UNIT_STRING in a ProtoField the table must be given.
Change-Id: Ie4beb93b5597a97a99939ef2c60a1ee7ece328f2
Reviewed-on: https://code.wireshark.org/review/20542
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b72d86602cae511f7b53ae24654b41…
commit b72d86602cae511f7b53ae24654b41e1b56e58dc
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 14 17:43:20 2017 +0100
[GSM-A-BSSMAP] Update MSG content according to 3GPP TS 48.008 V13.3.0
(2016-09)
All IEs are not dissected.
Change-Id: If215b85ba1f786d9b4cb518c7525aec58d000f8e
Reviewed-on: https://code.wireshark.org/review/20548
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da786c28e7a2ac641b1e3343ad45e6…
commit da786c28e7a2ac641b1e3343ad45e66d5d4547fe
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 19:10:39 2017 +0100
ieee80211-radio: fix this condition has identical branches
[-Werror=duplicated-branches] found by gcc7
Change-Id: I7f5f25b0afd30612d9e20e52585c7cad70bc1f59
Reviewed-on: https://code.wireshark.org/review/20468
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=43a08c90a5de1a87634665957f22ad…
commit 43a08c90a5de1a87634665957f22ad1ecf5c9be7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 19:24:09 2017 +0100
v150fw: fix this condition has identical branches [-Werror=duplicated-branches] found
by gcc7
Change-Id: I04e781b12a2b89999bf628ceaa66b8527dd591aa
Reviewed-on: https://code.wireshark.org/review/20471
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=096dd7946589d155b30148da2faad3…
commit 096dd7946589d155b30148da2faad34d5698416c
Author: Robert Cragie <Robert.Cragie(a)arm.com>
Date: Tue Mar 14 11:27:04 2017 +0000
DTLS: Cookie formatting fix for HVR
Cookie format for HelloVerifyRequest inconsistent with that in
ClientHello. Changed to be consistent.
Change-Id: I79809ebc4bd4a1c5b43b44a21f58ad5b5d5a1bcf
Reviewed-on: https://code.wireshark.org/review/20544
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=c899dd57ffb81075e6f20f4af83daf…
commit c899dd57ffb81075e6f20f4af83daf99ef4e8b0c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Mar 14 10:33:29 2017 +0100
Lua: Improve base checking for signed integer
Check base value for signed integer before unsigned to avoid a case
where the valid bases for a unsigned integer is presented in a error
message when a signed type is used.
Change-Id: Idfb87597779652e32adceacad220d748afda5e85
Reviewed-on: https://code.wireshark.org/review/20541
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d89bb12d1feb41fb7b2cb6ed932660…
commit d89bb12d1feb41fb7b2cb6ed93266054f9ee4377
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Mar 14 10:17:09 2017 +0100
Lua: Layout cleanup in init.lua
Remove double start-of-comments and some leading spaces.
Change-Id: I1c5ba49990076cc2d32da2d0a3bb0f54ec31e823
Reviewed-on: https://code.wireshark.org/review/20540
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=472e5199ac7e6899ba12cd490f651f…
commit 472e5199ac7e6899ba12cd490f651f10d9118fef
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 14 13:57:46 2017 +0100
[GSM-A-BSSMAP] Correct and enhance dissection of HANDOVER COMPLETE
Change-Id: Ie65fc6c9f0cd2291d7e1421fbbedff097c7e09df
Reviewed-on: https://code.wireshark.org/review/20545
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ba49a8526c2caf68b95511aa2f5235…
commit ba49a8526c2caf68b95511aa2f5235276796cf5d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 20 09:44:16 2016 +0100
Lua: Add some ProtoField tests.
Test usage of base.UNIT_STRING.
Change-Id: I9c97b58b3cc6db65713e83609900880e157237f2
Reviewed-on: https://code.wireshark.org/review/19357
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=20d7669bbe9ca84597a371dd605385…
commit 20d7669bbe9ca84597a371dd605385f5b9c88154
Author: Birol Capa <birol.capa(a)siemens.com>
Date: Mon Mar 13 13:53:30 2017 +0300
PROFINET: Fix the Asset Management Record Dissection
Dissecting AMR doesn't work properly when AM_Location.Structure don't equal to
2.
Bug: 13480
Change-Id: Ie116e10f6e88e240b2f1ae4e1eab27b24350e55a
Reviewed-on: https://code.wireshark.org/review/20529
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Birol Capa <birol.capa(a)siemens.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b11d4e7ed00cf6bc877cb9a407dc0e…
commit b11d4e7ed00cf6bc877cb9a407dc0eadb10866c1
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Mar 13 18:46:48 2017 +0100
ftypes: move set_value_uinteger64 into the union
Delete set_value_uinteger64 from struct _ftype_t, make it
part of the set_value union.
Change-Id: I12407b7336282daa60fe6e0e742d65e205dc84fd
Reviewed-on: https://code.wireshark.org/review/20539
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f94509c140b8cd72d041f3925be9c8…
commit f94509c140b8cd72d041f3925be9c8af3b38ffb7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 13 15:12:50 2017 +0100
bootp: Add Captive-Portal option (160)
Thanks to David Bird for pcap
Bug: 13483
Change-Id: Id53eadd5faa7599c3864840aa80a8770099baac3
Reviewed-on: https://code.wireshark.org/review/20531
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a6f7e16859b35d1d0b680eb04caabc…
commit a6f7e16859b35d1d0b680eb04caabc82f7cc70e7
Author: Jakub Pawlowski <jpawlowski(a)google.com>
Date: Mon Mar 13 13:20:23 2017 -0700
Bluetooth: "dublicates" -> "duplicates"
Change-Id: Ie52c6ef60c911d1e119c5b69de6f64a88b3433f3
Reviewed-on: https://code.wireshark.org/review/20534
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=98558fd81cad9d578ea5085fe84653…
commit 98558fd81cad9d578ea5085fe8465334e4b266fd
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Mar 13 17:02:23 2017 +0100
Fix buffer overrun in try_bytesprefix_to_str
bytes_string list contains a list of prefixes to match, not the other
way round (matching prefixes in the list).
Bug: 13479
Change-Id: Ie625dc5db30bd55158d688a0101f35d0bf6906af
Fixes: v2.3.0rc0-2644-g540b555729 ("Introduce "bytes_string" type,
similar to "value_string"")
Reviewed-on: https://code.wireshark.org/review/20532
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f1d0533ee1f051aabbc1ba8e3e6a9b…
commit f1d0533ee1f051aabbc1ba8e3e6a9b51dbb2c228
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Mar 13 19:10:51 2017 +0100
Lua: Base must be base.DEC or base.UNIT_STRING for signed integer
Reject ProtoField signed integer types with base other than base.DEC
and base.UNIT_STRING. Update documentation for this.
Bug: 13484
Change-Id: I55a636c89704e96a598f1f185faabd8ad13d96f1
Reviewed-on: https://code.wireshark.org/review/20533
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=39fd595b34773355c00f9996006457…
commit 39fd595b34773355c00f9996006457b294b58601
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 16:33:58 2017 +0100
tap-iostat (cli): fix this statement may fall through [-Werror=implicit-fallthrough]
found by gcc7
Change-Id: Idd8f4e2175d6575beecaccf2ee018457a25fd225
Reviewed-on: https://code.wireshark.org/review/20493
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a6d69084dc18da09d7020b9bfda74c…
commit a6d69084dc18da09d7020b9bfda74cdfea963cad
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 12 19:49:42 2017 +0100
ftypes: move set_value_sinteger into the union
Delete set_value_sinteger from struct _ftype_t, make it part of the
set_value union.
Change-Id: I084c4c9beba9978b538d359ebaac21391ebd7f82
Reviewed-on: https://code.wireshark.org/review/20523
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d217530a171a666ba5530675785e9…
commit 5d217530a171a666ba5530675785e9463f2e20f6
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Mar 13 08:24:35 2017 +0100
Qt: Use em dash when hide the "Show" checkbox
Match the style used in "Capture Interfaces" table when elements
are N/A by using the em dash. This item should also be disabled
using QPalette::Disabled to get a even better match.
Change-Id: I127ce309318df2c36515996df8584d1e4ce690c0
Reviewed-on: https://code.wireshark.org/review/20527
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=9e82cffeea10fce62cdfc49cec3b9e…
commit 9e82cffeea10fce62cdfc49cec3b9e3794ac04bf
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 12 19:15:19 2017 +0100
ftypes: move set_value_uinteger into the union
Delete set_value_uinteger from struct _ftype_t, make it part of the
set_value union.
Change-Id: I26de15be8ea0ede76236a8f8a4958bfd97ad9d52
Reviewed-on: https://code.wireshark.org/review/20521
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c70927c0e11a251aec14bc3bb391cd…
commit c70927c0e11a251aec14bc3bb391cd18cacba6db
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 15:19:16 2017 +0100
erf: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: I1634b0a7b0fa35ea59ef2fc7fbe0b81f77aad978
Reviewed-on: https://code.wireshark.org/review/20508
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=eab8050fdd8ea43d75a6fd3d862116…
commit eab8050fdd8ea43d75a6fd3d86211628b6e1d1aa
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 18:53:27 2017 +0100
dis: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: I8d28637d5262fd0e06d80607adb6f88b3d909a9e
Reviewed-on: https://code.wireshark.org/review/20465
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=75cbd387dbe92be1d5bfafd69d4971…
commit 75cbd387dbe92be1d5bfafd69d49716e97a9c3bf
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 20:54:18 2017 +0100
cigi: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: I1f755c876150f204cce95932698c3f4e96fd465d
Reviewed-on: https://code.wireshark.org/review/20426
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=7197e9c6711f3869890c3406dcb5eb…
commit 7197e9c6711f3869890c3406dcb5eb49ef786ac7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 19:06:27 2017 +0100
ieee80211-prism: fix this condition has identical branches
[-Werror=duplicated-branches] found by gcc7
Change-Id: Ic3c4a4347ab501c1ee22a25dd3dd41609d28418f
Reviewed-on: https://code.wireshark.org/review/20467
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7f2a39f9ba7541c6a2ec609f096b09…
commit 7f2a39f9ba7541c6a2ec609f096b09ee135e0673
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 12 23:10:41 2017 +0100
rpcap URLs *require* the :<port> argument for remote capture - update manpage.
Change-Id: Iabae39347bc0058d106a9b00d81629899bc93249
Reviewed-on: https://code.wireshark.org/review/20526
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=16c8bff15ad20e1a4c11e116ff29f3…
commit 16c8bff15ad20e1a4c11e116ff29f36f527ffded
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Mar 12 11:47:44 2017 -0700
Catch read errors and zero-length records, as opposed to short reads/EOF.
Also, if we return WTAP_OPEN_ERROR from an open routine after we've set
our close routine, that routine is called, which frees up our private
data structures; don't free them ourselves before returning
WTAP_OPEN_ERROR.
Change-Id: I03eebe1a1677e2161fdacec8de14668093cf03a3
Reviewed-on: https://code.wireshark.org/review/20522
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=10798ef0c5c0d395d0614bb4ca7b84…
commit 10798ef0c5c0d395d0614bb4ca7b847b94588920
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Mar 12 19:21:24 2017 +0100
ftypes (trivial): fix two comments
The comments give the name of the struct _ftype_t component that is
initialized. They are wrong in two places. This confuses my script that
deletes the initializers for the components which were moved into the
union.
Change-Id: I876fb29305a94b241df07c97064f31378752b559
Reviewed-on: https://code.wireshark.org/review/20520
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=41b4f0b6eaddbf923cd85b0cb0b8b2…
commit 41b4f0b6eaddbf923cd85b0cb0b8b29f7dbe1283
Author: Birol Capa <birol.capa(a)siemens.com>
Date: Mon Mar 6 14:39:53 2017 +0300
PROFINET: Extend System Redundancy Support
A special ARType for System redundancy IOCARSR (0x0020) used to indicate
SR during the IODConnectReq for Advanced Startup ARs (StartupMode:=1).
With this change, the ARUUID is subdivided into several parts.
APDUStatus dissection is affected by Primary/Backup switchover.
Bug: 13456
Change-Id: I0504ad2f4d15c491b0142c6d24bb8b849a929ba2
Reviewed-on: https://code.wireshark.org/review/20422
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1d51475b59279e917a96724c7a71e…
commit e1d51475b59279e917a96724c7a71e2192c44e84
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 10 04:25:43 2017 +0100
Qt: hide the "Show" checkbox for default devices
When marking a previously hidden device as default (e.g. via wireshark
-ocapture.device:eth0), an unchecked checkbox is visible. This is just
confusing, just hide the checkbox completely.
Change-Id: I3f85cfcb659c351c72237dced52f0684733188c4
Reviewed-on: https://code.wireshark.org/review/20478
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=845f82e5cdadc76f39ecd350793cd1…
commit 845f82e5cdadc76f39ecd350793cd1d09184b183
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 12 11:58:54 2017 -0400
netscaler: Sanity check record size
Bug: 13478
Change-Id: I6be2972979ff7cabf27e70d236c581d539d6ddac
Reviewed-on: https://code.wireshark.org/review/20515
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8e1befc4777431851f7026b059ecf6…
commit 8e1befc4777431851f7026b059ecf6ce9a518781
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 12 11:26:54 2017 -0400
packet-wbxml.c: Fix potential infinite loops
Bug: 13477
Change-Id: Ib6c440bbcbb5011e8f23fb87418acd87bb38c272
Reviewed-on: https://code.wireshark.org/review/20513
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5f789e3fe365fc1f71308f794a5bc7…
commit 5f789e3fe365fc1f71308f794a5bc7b5af72c670
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Mar 12 08:11:50 2017 -0700
[Automatic update for 2017-03-12]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I5718e7c7df8061f81eb01973f504ebbb0cfe1e44
Reviewed-on: https://code.wireshark.org/review/20511
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=033232868e5ad383b6e69985929ac3…
commit 033232868e5ad383b6e69985929ac34c58902e81
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 19:14:39 2017 +0100
llrp: fix this condition has identical branches [-Werror=duplicated-branches] found by
gcc7
Change-Id: I2bc9b5b50b8698c27f2a56b869de318fa98bf7b1
Reviewed-on: https://code.wireshark.org/review/20469
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=39f6687a912dff78bda23c57e729f1…
commit 39f6687a912dff78bda23c57e729f1e99f93bd2b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 12 10:58:08 2017 +0100
ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I53bca9bc50d18a88cc6c5c5a7ae93bdd1b772903
Reviewed-on: https://code.wireshark.org/review/20504
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8b6284ed146fd73688867d413d24a…
commit a8b6284ed146fd73688867d413d24a31b714bf6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 16:44:20 2017 +0100
tfshark: fix this ‘if’ clause does not guard... [-Wmisleading-indentation]
Change-Id: If66223021d074e6cb3c7bde2af7cca9c72acb8c6
Reviewed-on: https://code.wireshark.org/review/20507
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0501699a4e338948e6dec369152744…
commit 0501699a4e338948e6dec36915274402a9553808
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Mar 12 09:23:17 2017 +0100
sharkd: fix tap memleaks & support for links to frame, url & cleanup
Change-Id: I08af04c7882802035344d0051055be05967fb089
Reviewed-on: https://code.wireshark.org/review/20502
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c80bfec083aee9cd14345f821a6a17…
commit c80bfec083aee9cd14345f821a6a17cf2e0f3797
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 12 10:54:57 2017 +0100
ieee80211: fix declaration of 'ieee80211_tag_...' shadows a global
declaration
Make OSX buildbot happy
Change-Id: I1a376fba3d7f4b24741839697ed0f6c55c9ac77d
Reviewed-on: https://code.wireshark.org/review/20503
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e4b90a9451e0b13f842ce6c673c453…
commit e4b90a9451e0b13f842ce6c673c453dd944d9c84
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 19:20:37 2017 +0100
radius: fix this condition has identical branches [-Werror=duplicated-branches] found
by gcc7
Change-Id: I654ead4d834af90e14568a54c7a914a3774c05bc
Reviewed-on: https://code.wireshark.org/review/20470
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=6d584aad721515da570185e7f8e9e5…
commit 6d584aad721515da570185e7f8e9e5a21540b0d3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 18:55:59 2017 +0100
gmr_rach: fix this condition has identical branches [-Werror=duplicated-branches]
found by gcc7
Change-Id: I3313ea62fd86b0a7a3ae6dfbc40bd6e0841316a2
Reviewed-on: https://code.wireshark.org/review/20466
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=3baae12c4f83451d291176df4c6d9d…
commit 3baae12c4f83451d291176df4c6d9d5499fcbcdc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 9 18:49:25 2017 +0100
dcerpc (netlogon): fix this condition has identical branches
[-Werror=duplicated-branches] found by gcc7
Change-Id: I96b8a8c5157dc89785421282f2c509c100fb0504
Reviewed-on: https://code.wireshark.org/review/20464
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=135557f39be3c07371a45798ffd9f1…
commit 135557f39be3c07371a45798ffd9f1e4fa07c520
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 20:52:16 2017 +0100
catapult-dct2000: fix this condition has identical branches
[-Werror=duplicated-branches] found by gcc7
Change-Id: If3afda940b40500e067467b341f192bbaef173bc
Reviewed-on: https://code.wireshark.org/review/20425
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=c8020c7f6253ae606736326b41e572…
commit c8020c7f6253ae606736326b41e572630c73ee59
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Mar 6 21:05:06 2017 +0100
ansi_a: fix this condition has identical branches [-Werror=duplicated-branches] found
by gcc7
All users of the ELEM_OPT_TLV and ELEM_MAND_TV macros pass an empty string
("")
for the elem_name_addition parameter, so it can never be NULL. The Coverity
warning was about a superfluous check (elem_name_addition[0]=='\0'). All of
these checks are superfluous anyway since both branches yield an empty string.
Change-Id: I28c994fd5e10c04f99c8d77e9aee18afd4a26412
Reviewed-on: https://code.wireshark.org/review/20427
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=ae39d9ad13434865ecdac5e2749d2e…
commit ae39d9ad13434865ecdac5e2749d2e48cd842b97
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Mar 12 12:20:23 2017 +0100
tshark and tfshark require -2 when using -R. Document this.
Change-Id: I3ef802ed1163512e20da10eaa8da3239107b6fae
Reviewed-on: https://code.wireshark.org/review/20509
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=3d4822d158285bcd0c8afbc0567025…
commit 3d4822d158285bcd0c8afbc0567025724d14866c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 12 11:04:49 2017 +0100
afn(.h) fix indent
use 4 spaces like afn.c
Change-Id: Iadc6d6e3b2919c7014eccc2890966eadd7d7bee7
Reviewed-on: https://code.wireshark.org/review/20506
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d918f241a7b996e881aa9ad7cdc99…
commit 0d918f241a7b996e881aa9ad7cdc997b0aa145e9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 12 11:01:27 2017 +0100
afn(.c): fix indent (align field)
Change-Id: Ie2cc66b8ba26278490134974662acd554b8931f9
Reviewed-on: https://code.wireshark.org/review/20505
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9ea5b08da68235973768eb55e34f90…
commit 9ea5b08da68235973768eb55e34f908308cc1c4b
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Sat Mar 11 22:16:53 2017 -0500
BGP: Update Transitive Four-Octet AS-Specific Extended Community Sub-Types and remove
duplicate marcos.
Change-Id: I87454ea95bc64a39e4e60ba374e9cafb574e744c
Reviewed-on: https://code.wireshark.org/review/20501
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c427376579a426cdb8ef3212f7ddf…
commit 3c427376579a426cdb8ef3212f7ddfd7ab5a80b3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jan 6 08:16:24 2017 +0100
802.11: Use proto_tree_add_bitmask
Change-Id: If46ccea1c58448d2dacad07fb3171e423babe59f
Reviewed-on: https://code.wireshark.org/review/19562
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b0335359e59048a95346c7d3581180…
commit b0335359e59048a95346c7d3581180b79eefd2e2
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Mar 10 13:03:02 2017 +0100
Qt: Give discard button focus (but not as default)
Set focus to the discard button in the "Unsaved packet" and
"Unsaved comments" dialogs to enable spacebar for discard and
enter for save.
Bug: 13363
Change-Id: I576b02c4e3f0964aef56a0f1c06ed57c6ba683bf
Reviewed-on: https://code.wireshark.org/review/20485
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f8abec1f37595aa42ea23ace5e98a6…
commit f8abec1f37595aa42ea23ace5e98a66a1f129b12
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Mar 11 23:16:11 2017 +0100
bgp: Avoid divide by zero
Bug: 13476
Change-Id: I399df46c9d5f6d0d464ecc9cf8d44eddf709f7dc
Reviewed-on: https://code.wireshark.org/review/20499
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c62497066e0e6078b5d5d1ee8e6883…
commit c62497066e0e6078b5d5d1ee8e6883f5f78afe26
Author: Michal Kubecek <mkubecek(a)suse.cz>
Date: Fri Mar 10 08:59:02 2017 +0100
netlink: support legacy dump request messages
Some legacy tools, including iproute2 < 3.9, issue shorter RTM_GETLINK
and RTM_GETADDR dump queries which only contain struct rtgenmsg rather
than struct ifinfomsg. As noted in kernel comment in rtnl_dump_ifinfo(),
these legacy requests will be (even with attributes) always shorter than
struct ifinfomsg so that they are easy to detect.
Similar problem can be observed with tools using nl_rtgen_request()
function from libnl3; this also affects other RTM_GET* types.
If such legacy message is detected by length shorter than expected data
structure, parse it as this legacy version with (1-byte) struct
rtgenmsg so that it's shown as intended rather than as malformed.
Change-Id: I53b6bff9e44cd2359d7cd313b6f0724f63f0e74d
Reviewed-on: https://code.wireshark.org/review/20461
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michal Kubeček <mkubecek(a)suse.cz>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bccc2004dfbd179ee05fa2e4d6d336…
commit bccc2004dfbd179ee05fa2e4d6d336a23df7b150
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Mar 11 12:27:14 2017 +0100
sharkd: support for export objects, following stream.
Change-Id: I364cb200e537ae07cbe831d8be1f217c5a15ee09
Reviewed-on: https://code.wireshark.org/review/20492
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7d28e99a7c73b9a51be3d2b96dd5f7…
commit 7d28e99a7c73b9a51be3d2b96dd5f7f2bfb253f3
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Fri Mar 10 14:11:23 2017 -0500
Updated Address Family Numbers with latest (Last Updated 2016-08-26) IANA table.
Change-Id: I4286a249ca9603732f06e2715c1804a201c105e9
Reviewed-on: https://code.wireshark.org/review/20489
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ef05fa513448c82dcdf2b95fdf7534…
commit ef05fa513448c82dcdf2b95fdf7534966c925b4d
Author: Martin Vit <martin(a)voipmonitor.org>
Date: Mon Mar 6 17:14:18 2017 +0100
T30: fix parsing broken since ge063924
Bug: 1918
Change-Id: I276e5ad74caaf509d220f97e111d2aedc7caef17
Reviewed-on: https://code.wireshark.org/review/20423
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ecd598ae69147b613a3ad8bcd3bb76…
commit ecd598ae69147b613a3ad8bcd3bb764d88b0e03d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 16:38:46 2017 +0100
unistim (plugin): fix this statement may fall through [-Werror=implicit-fallthrough]
found by gcc7
Change-Id: Id928c9f4506b3f88016d77e3e79a4ecf78d52e93
Reviewed-on: https://code.wireshark.org/review/20494
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=77aa6744ca2babddd21df74887d5ba…
commit 77aa6744ca2babddd21df74887d5bac1b6b87680
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 16:40:33 2017 +0100
oids: fix this statement may fall through [-Werror=implicit-fallthrough] found by
gcc7
Change-Id: I8f84414be693ea8ebcfef003480e9ee05de94ea0
Reviewed-on: https://code.wireshark.org/review/20495
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=02ea90f3ccf2a349c2569308f2c98e…
commit 02ea90f3ccf2a349c2569308f2c98ef159c0b466
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 11 16:41:00 2017 +0100
stats_tree: fix this statement may fall through [-Werror=implicit-fallthrough] found
by gcc7
Change-Id: Idd5ab938b95d515cdf8b2a8568456f44b3dd85ac
Reviewed-on: https://code.wireshark.org/review/20496
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5b9879806d293938820e657354e5e6…
commit 5b9879806d293938820e657354e5e631437ce1bf
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Fri Mar 10 13:49:29 2017 -0500
BGP: Fix the issue that SAFI 72 (BGP-LS-VPN) was not decoded.
Change-Id: I2aef41458c89975dddea4d8bb6355bb7aabd1cad
Reviewed-on: https://code.wireshark.org/review/20488
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7119b6691f318efa90bfe42a98d1b8…
commit 7119b6691f318efa90bfe42a98d1b812dac183b5
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Mar 10 12:49:54 2017 +0100
[LDAP] Add a couple of OID translations.
Change-Id: I3d3435a9ac5d2a177b0ced6085eabe4feb67ba7b
Reviewed-on: https://code.wireshark.org/review/20484
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eb19d3517d3a974a76f80f7651e8b8…
commit eb19d3517d3a974a76f80f7651e8b883e227eb76
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 10 14:54:21 2017 +0100
Add decoding of EDCA IE
Bug: 13472
Change-Id: Iff8b3e532680ada668581263476b6557518acc50
Reviewed-on: https://code.wireshark.org/review/20486
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=d91cd6865a286e024cfe1c254b88fc…
commit d91cd6865a286e024cfe1c254b88fcb8ddc69b1b
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Thu Mar 9 22:52:48 2017 +0200
SMB3 SVHDX_OPEN_DEVICE_CONTEXT_V2 implementation
1. Extended SMB3 dissector of OPEN_DEVICE_CONTEXT to hanlde V2 structure
See https://msdn.microsoft.com/en-us/library/mt240852.aspx
2. Rejected restriction for request-only processing
(now this context MUST be handled in response packets too, both V1 and v2).
See https://msdn.microsoft.com/en-us/library/dn366831.aspx
and https://msdn.microsoft.com/en-us/library/dn409028.aspx#Appendix_A_10
Change-Id: I7f200932d07eb61c6465d5792a550332ac769be5
Reviewed-on: https://code.wireshark.org/review/20473
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c2e74c5fc2cf9c0f6d85c2e6ce5bcb…
commit c2e74c5fc2cf9c0f6d85c2e6ce5bcb0cfb777b26
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 9 20:20:20 2017 -0800
Don't cast to a too-large size.
The maximum record length is 255*128 + 127 = 32767; that fits in a
guint32, which is large enough to support the biggest packet we'd ever
support without stretching several size values to 64 bits.
It's not a size of an object in memory, so it doesn't have to be a
size_t, and a size_t could be too large to fit in the record sizes we're
using.
Just cast to guint32.
Change-Id: Ie664fda3ce9945893fd992bbb9a81a5d632a3fcb
Reviewed-on: https://code.wireshark.org/review/20479
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=fe285c640b6279fdb9920bb79b0494…
commit fe285c640b6279fdb9920bb79b0494ac87cb0e32
Author: erikdejong <erikdejong(a)gmail.com>
Date: Mon Mar 6 22:01:39 2017 +0100
Replace aes.c and des.c by Libgcrypt
Follow-up of https://code.wireshark.org/review/20095
Rewritten functions:
- crypt_des_ecb
crypt_des_ecb verified against previous crypt_des_ecb implementation with
4294967295 random keys and input buffers from /dev/random as I cannot find a
suitable pcap which uses DES
Change-Id: I21ec2572451e0ded4299ffadd8dd687817bc6318
Reviewed-on: https://code.wireshark.org/review/20429
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=9e0251f2187388ce03b4afde91df25…
commit 9e0251f2187388ce03b4afde91df2528e313afd8
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Mar 8 23:05:14 2017 +0100
io_graph_item: fix false positive array subscript is above array bounds
[-Werror=array-bounds]
Change-Id: I14fc19f131782a9c85104ca2189b9452079d0013
Reviewed-on: https://code.wireshark.org/review/20454
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3a63f8dc61b103c4716e49a914868a…
commit 3a63f8dc61b103c4716e49a914868a2ca327f4de
Author: Anil Kumar <anilkumar911(a)gmail.com>
Date: Wed Mar 8 12:15:22 2017 +0530
nstrace: fix size of vmnames
When vmnames are included in the header of a netscaler packet trace,
number of bytes equal to the size of vmnames is omitted from the packet,
by the dissector.
Bug: 13459
Change-Id: I0f907e9c2e08c1cbebd47f7e50d8284a6aaade59
Reviewed-on: https://code.wireshark.org/review/20446
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ee7296db93ee4f35896b33b8802820…
commit ee7296db93ee4f35896b33b880282085102366ee
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Mar 5 01:56:17 2017 +0100
TLS: append Log name for CT Log IDs
Show something like "Signed Certificate Timestamp (Google 'Pilot'
Log)"
if the Log ID is recognized, or "... (Unknown Log)" otherwise.
Bug: 13372
Change-Id: I1cd373f110d5beb63ee89fb85831ab72cafe03d0
Reviewed-on: https://code.wireshark.org/review/20387
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=8b11bc7b040862cfa5afd06541fb26…
commit 8b11bc7b040862cfa5afd06541fb26829392a43c
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Mar 9 23:05:18 2017 +0100
ftypes: move set_value_protocol into the union
Delete set_value_protocol from struct _ftype_t, make it part of the
set_value union.
Change-Id: Iae55388b8a2c965944028499619282c3232c31f3
Reviewed-on: https://code.wireshark.org/review/20475
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3bcda66971e7eff1bca5155207cb03…
commit 3bcda66971e7eff1bca5155207cb035e185dc6d0
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Mar 9 22:56:07 2017 +0100
ftypes: move set_value_string into the union
Delete set_value_string from struct _ftype_t, make it part of the
set_value union.
Change-Id: Ia3a57245330ed0d158c8c3e4552ec5d80752fe0f
Reviewed-on: https://code.wireshark.org/review/20474
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e00390842333e6548f365b266dd66b…
commit e00390842333e6548f365b266dd66bc8710e33a9
Author: Erik de Jong <erikdejong(a)gmail.com>
Date: Thu Mar 9 14:33:29 2017 +0100
RTP streams dialog: Fix find reverse button
Fix find reverse button
Bug: 13462
Change-Id: I6e19fa38cd333285c9ca3cf01e4c06ff8de56b2a
Reviewed-on: https://code.wireshark.org/review/20462
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=abcaf3e37036766d16815cae8ae8b1…
commit abcaf3e37036766d16815cae8ae8b1c997e308b8
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Mar 7 22:43:04 2017 +0100
ftypes: move set_value_time into the union
Delete set_value_time from struct _ftype_t, make it part of the
set_value union.
Change-Id: Ieee3b083d52afdd608e31e8ca75b50016fec8a69
Reviewed-on: https://code.wireshark.org/review/20442
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=ae9ccbeb72b014ae72c588e2c6f65f…
commit ae9ccbeb72b014ae72c588e2c6f65f08bc375bde
Author: Radhashyam Behera <radhashyambehera(a)gmail.com>
Date: Tue Feb 21 19:06:48 2017 +0530
IEEE80211: Support of MU Exclusive Beamforming Report decoding under VHT Compressed
Beamforming.
Bug: 13343
Change-Id: Ia69b2c074adb1c269c93db40ad5004a261560c88
Reviewed-on: https://code.wireshark.org/review/20224
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6c00eba20e5dfceb8a516e3fa5342a…
commit 6c00eba20e5dfceb8a516e3fa5342a6148c30288
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Thu Mar 9 19:48:48 2017 +0100
Add another instance of capture_opts_log when more information is known.
Make a url in a comment more readable.
Change-Id: I9a34e442434cc50c6d631622d680c12049c7dbf8
Reviewed-on: https://code.wireshark.org/review/20472
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=0ac07be8081f4ae8d1a40c7ca94a70…
commit 0ac07be8081f4ae8d1a40c7ca94a70dd92bd7164
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Mar 8 06:00:51 2017 +0100
snort-config: fix comparison between pointer and zero character constant
[-Werror=pointer-compare]
Change-Id: I6afeac8606fda59c833933628f53d2eb73e2909c
Reviewed-on: https://code.wireshark.org/review/20445
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e781fdd18010c6c70d08b1bd89cd34…
commit e781fdd18010c6c70d08b1bd89cd3449d4a5b14d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 9 09:46:08 2017 +0100
Qt: Fix heap-use-after-free when deleting IO graph
Deleting a IO graph item while editing a field will use the IOGraph
object so ensure we delete in correct order to avoid heap-use-after-free.
Bug: 13234
Change-Id: I6d0de21684f842fbd67c9b38fc6b75b81aec5518
Reviewed-on: https://code.wireshark.org/review/20456
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=eb046064ff0f064896ad60508876b8…
commit eb046064ff0f064896ad60508876b8a764fbbca9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 8 21:01:12 2017 +0100
imap: Give correct lineend to get_token_len()
The return value from get_token_len() is the token length, but the
returned next_token can have a offset more than token length because
it also skip trailing blanks. Ensure we always give correct lineend.
Bug: 13466
Change-Id: I88a11b9bce02999fcf87c0d7542e56fa90aae5a0
Reviewed-on: https://code.wireshark.org/review/20451
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=528a3d31ff1861d5445ee649752876…
commit 528a3d31ff1861d5445ee649752876e8bed82270
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Mar 9 08:34:54 2017 +0100
proto: Check for empty protocol->fields
In proto_get_first_protocol_field() we must check for an empty
protocol->fields because Lua scripts may have protocols without
fields and g_ptr_array_index() does not perform bounds checking
on the given index.
Bug: 13223
Change-Id: Ib2f6286d0799541243450348dcf345a965b2825c
Reviewed-on: https://code.wireshark.org/review/20455
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=540b5557291ad0960ce566adc3f241…
commit 540b5557291ad0960ce566adc3f24100aac946de
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Mar 4 01:40:51 2017 +0100
Introduce "bytes_string" type, similar to "value_string"
In order to map arbitrary byte buffers to strings, introduce a new
"bytes_string" type. Since "bytes_to_str" is already used for
other
purposes, name the generic function "bytesval_to_str" instead similar to
the name( "val_to_str").
Accept "size_t" as length parameter since this is what is returned by
the "sizeof" operator. Do not add a "try_bytesval_to_str_idx"
variant
since this pattern is not needed for now. Add a variant to match the
prefix since this is currently expected by the ISAKMP dissector.
Change-Id: I6d790325e85d9fb1384330f28a8c36e2057fdf30
Reviewed-on: https://code.wireshark.org/review/20386
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=2b06c17592e792224779355c2e47d7…
commit 2b06c17592e792224779355c2e47d776ba2f9af6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:54:22 2017 +0100
ubertooth: fix this statement may fall through [-Werror=implicit-fallthrough=] found
by gcc7
Change-Id: Iec4253ad488f51169ce4cc295b5f084ba4aa4122
Reviewed-on: https://code.wireshark.org/review/20412
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d7fc8abc944134f23645c5f9a3f318…
commit d7fc8abc944134f23645c5f9a3f318a9a65345fe
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Mar 7 22:35:45 2017 +0100
ftypes: move set_value_guid into the union
Delete set_value_guid from struct _ftype_t, make it part of the
set_value union.
Change-Id: I3a04ff6b1ab179063ef77a3c475809df0bde5c68
Reviewed-on: https://code.wireshark.org/review/20441
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=da78a59744619b2b4e082eb6aa42a1…
commit da78a59744619b2b4e082eb6aa42a1e5b22628ce
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Mar 7 22:16:02 2017 +0100
ftypes: move set_value_bytes into the union
Delete set_value_bytes from struct _ftype_t, make it part of the
set_value union.
Change-Id: I3ee6a9f68b269ee083794947816e13ea6c1b9d29
Reviewed-on: https://code.wireshark.org/review/20440
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=af8361a90e514b2773202bc602fb22…
commit af8361a90e514b2773202bc602fb223c8426ca70
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Mar 7 22:06:13 2017 +0100
http: Check for valid tcpinfo pointer
In dissect_http_tcp() the data pointer may be NULL so ensure
we check for this before dereferencing it.
Bug: 13457
Change-Id: I84f4a0e3b416a2829998f20fe59da8770a34e564
Reviewed-on: https://code.wireshark.org/review/20438
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=c2938420691b5163f8abfde15c6a93…
commit c2938420691b5163f8abfde15c6a9307a1929b86
Author: Gabriel Ganne <gabriel.ganne(a)enea.com>
Date: Wed Mar 8 08:40:30 2017 +0100
nsh: remove duplicate ethertype entry
Change-Id: I3b177eb86a4058a437f9fb0617b5ae5b3a513af2
Signed-off-by: Gabriel Ganne <gabriel.ganne(a)enea.com>
Reviewed-on: https://code.wireshark.org/review/20447
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f4c71c32e28b19b11f627ad00c31d1…
commit f4c71c32e28b19b11f627ad00c31d1c707148c36
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Mar 8 09:16:16 2017 +0100
[SIP] Start dissecting generic parameters.
Change-Id: I545f8646e6e4cba74c48b58e0fb6ea6ea5338625
Reviewed-on: https://code.wireshark.org/review/20448
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ca4f37d17c125f567ce4ecfdacb7e3…
commit ca4f37d17c125f567ce4ecfdacb7e31584521706
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 7 16:57:12 2017 +0100
[SIP] Start dissecting generic parameters.
Change-Id: I5d5c2f8cfc78c4557a9fcd61a47b39e7c8b50cad
Reviewed-on: https://code.wireshark.org/review/20437
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1ac358c99ddcddc29d4e7c9fee1591…
commit 1ac358c99ddcddc29d4e7c9fee1591e71f4a6a6e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Mar 7 14:08:53 2017 -0800
Don't close the pcap_t in get_data_link_types().
1) Its caller closes it, and closing a closed pcap_t can cause Bad
Things to happen.
2) We're trying to get an error string from it after we're closing it,
which won't work well, either.
While we're at it, don't use pcap_statustostr() if we don't have it (we
have it iff we have pcap_create()).
Change-Id: Ieded1e3ae78aea4e0970cf582e780c2846fe9dd5
Reviewed-on: https://code.wireshark.org/review/20443
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=25015a00a3d1f877f053940b59d5b9…
commit 25015a00a3d1f877f053940b59d5b96c1b80c744
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Mar 4 16:15:54 2017 +0100
ftypes: create a set_value union
struct _ftype_t contains a number of pointers to set_value_...()
functions. For each pre-defined ftype_t, only one of these pointers
is != NULL.
As the comment already says, we should move these functions into a
union. ftenum_t ftype will be used for selecting the correct function
pointer from the union.
Create a set_value union and move the FvalueSetByteArrayFunc pointer
into the union. Update fvalue_set_byte_array() accordingly. Check
that the fvalue_t parameter is of the correct type.
Change-Id: I6568d8f47108311289c0cd425f28ea8b38046141
Reviewed-on: https://code.wireshark.org/review/20433
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=4caa64fc18dfbde99b6f8b0f5d2aa2…
commit 4caa64fc18dfbde99b6f8b0f5d2aa211292d9ffe
Author: Gabriel Ganne <gabriel.ganne(a)qosmos.com>
Date: Fri Jul 8 14:11:21 2016 +0200
nsh: add protocol dissection over ethernet
Change-Id: I4cbfb5d4371fa4401f591d5e52a603ae1256c23c
Signed-off-by: Gabriel Ganne <gabriel.ganne(a)enea.com>
Reviewed-on: https://code.wireshark.org/review/20435
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8a33207dc3f04655409c199d121e6d…
commit 8a33207dc3f04655409c199d121e6dcb52c1c3ef
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Mar 7 14:30:06 2017 +0100
[SIP] Handle P-Access-Network-Info Headers parameter without '='.
Change-Id: I6cb5bc6c3cd612b4770d578edaf1c9a877659d8e
Reviewed-on: https://code.wireshark.org/review/20436
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5dcd11261290d2e4592038c085a04b…
commit 5dcd11261290d2e4592038c085a04bcd3d6d70ed
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:31:59 2017 +0100
rtpproxy: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: Ide19cb51d5ce0a9d0a0634ad492c9e81cbc2c810
Reviewed-on: https://code.wireshark.org/review/20411
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Lemenkov <lemenkov(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b56afb1211be9ce610078c22ad91f0…
commit b56afb1211be9ce610078c22ad91f0d3e5ea6d12
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Mar 7 07:35:33 2017 +0100
androiddump: Fix a type
Change-Id: I839e7e7300af9b90e91548fa29157143ae00adee
Reviewed-on: https://code.wireshark.org/review/20434
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=44e270cbd6c6eeea7d86e65970e983…
commit 44e270cbd6c6eeea7d86e65970e9837925581ca6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Dec 21 02:31:35 2016 +0100
lua: improve FileHandler:[seek_]read behavior and documentation
WSLUA documents FileHandler:read as returning a boolean or integer.
Ignore strings, do not treat strings as number even if it is possible.
Remove undocumented feature of FileHandler:seek_read that used returned
strings as the frame data. Use FrameInfo:read_data instead. This avoids
interpreting numbers as data which caused surprising behavior when
combining with FileHandler:read.
Documentation has been improved to document the return value, this is
consistent with the documentation in the WSLUA tests.
Change-Id: I31f74ec33ff0e43c90d83c1904af43801886cfa1
Reviewed-on: https://code.wireshark.org/review/19366
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cec782cb292eb18821801d092fc826…
commit cec782cb292eb18821801d092fc8267140b80432
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sat Jan 28 19:16:15 2017 +0100
androiddump: Add ignore log-buffer and custom-options for logcat-text
Logcat Text interfaces have now two new options:
1. Ignore log-buffer - this means you start capturing immediately
and there will no logs from buffer
2. Custom-options - pass command line parameters to logcat, like tags
For example:
adb logcat -v threadtime -b main #now custom parameters starts# -T 20 -s Ads
Wireshark
Please note that some custom options are banned to avoid unexpected
behaviour (like "not working")
Change-Id: I015d1aeae35cfed712de59138288d82d3a491c38
Reviewed-on: https://code.wireshark.org/review/20358
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=77d5a4269682032d19bc5997be93b2…
commit 77d5a4269682032d19bc5997be93b21f6c8d9ffb
Author: Boazi <ronen.boazi(a)intel.com>
Date: Thu Feb 23 18:52:52 2017 +0200
RadioTap TimeStamp field added.
Timestamp was added according to radiotap spec.
Original changes provided by Johannes Berg from Intel
Change-Id: I72cb315626787d85b2bfb676c8ea7c73130f5a69
Reviewed-on: https://code.wireshark.org/review/20282
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d87a54c5a33290404183b129255508…
commit d87a54c5a33290404183b12925550868b0063d1e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:22:37 2017 +0100
opa: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I1edb5a3f7c9ac94c2a922058ca54d4b3e9218b0e
Reviewed-on: https://code.wireshark.org/review/20408
Reviewed-by: Adam Goldman <adam.goldman(a)intel.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=56aaa5b705fc87830a0f74f0ad3499…
commit 56aaa5b705fc87830a0f74f0ad34997ed76f7c92
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 17:05:17 2017 -0500
Switch conversations to use wmem_tree_t instead of (sorted) GSList.
Change-Id: Ifaf25ca5a7974f1d398ceebbb4c6733d4d3e001a
Reviewed-on: https://code.wireshark.org/review/20006
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cfa50019b6366404f54da57700e508…
commit cfa50019b6366404f54da57700e50862aa87ebb0
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Mar 5 13:10:16 2017 -0500
gsm_rr_csn_flag -> proto_tree_add_bits_item when not using return value
(CID-281350).
When flags aren't used in flow control decisions, the function is
effectively proto_tree_add_bits_item, so make it so.
Change-Id: Ic82e734ddd24d41fe7c36e435cc941ed872c3b03
Reviewed-on: https://code.wireshark.org/review/14773
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=daefa86695ecb6f859615ccd1bee62…
commit daefa86695ecb6f859615ccd1bee6269e2c568a5
Author: Rustam Safargalin <rustam.safargalin(a)sifox.ru>
Date: Wed Nov 2 11:36:09 2016 +0300
Fix issue with dissecting multiple DT1 packets in the frame
When parameter 'Reassemble SCCP messages' enabled in case there
are more than one complete DT1 in the frame they had not been
dissected.
Bug: 11130
Bug: 3360
Change-Id: Iba9093105fcd95dc398607c950129ed1db866c85
Reviewed-on: https://code.wireshark.org/review/18615
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=576043944b54df469d00e929e48256…
commit 576043944b54df469d00e929e48256697075d9b1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:20:15 2017 +0100
bluetooth: fix this statement may fall through [-Werror=implicit-fallthrough=] found
by gcc7
Change-Id: I4d8e6f32b08991f49ee22b320f02c1f65e22b6a0
Reviewed-on: https://code.wireshark.org/review/20400
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e9f6174c26b861f16c99d7e9d8d913…
commit e9f6174c26b861f16c99d7e9d8d913e5572fed1e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Mar 5 18:30:43 2017 -0800
Clean up indentation.
Consistently use 4-space indentation.
Change-Id: I8418241924a5b77a9e223869ff707335b8a52b75
Reviewed-on: https://code.wireshark.org/review/20419
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=27db39e79a171d7d68442583e9066c…
commit 27db39e79a171d7d68442583e9066cc3d677aee3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Mar 5 18:11:22 2017 -0800
Rename a data structure to reflect what it represents.
The structure called a pcap_options structure doesn't (only) hold
options for a packet capture; it holds all information about a
particular device, pipe, or socket from which we're capturing. Rename
it capture_src - and rename all the pointer variables that point to
something of that type to pcap_src from pcap_opts.
Change-Id: I8476146f174c82f331227528381defcc2828d822
Reviewed-on: https://code.wireshark.org/review/20416
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=579a86f5589e8c577d62052cc05ca9…
commit 579a86f5589e8c577d62052cc05ca91e4242dde0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:56:35 2017 +0100
vrrp: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I45748459e4024d918ef9b146e8a62f54e2d91b65
Reviewed-on: https://code.wireshark.org/review/20413
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bd9b2b7eac963ca6320b82b26b223e…
commit bd9b2b7eac963ca6320b82b26b223ebf8b9d450b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:35:02 2017 +0100
ieee80211: fix this statement may fall through [-Werror=implicit-fallthrough=] found
by gcc7
Change-Id: I294e0f426d760d0ccb59ebd8ea509245af1293a5
Reviewed-on: https://code.wireshark.org/review/20405
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=43f2177d7c4b50a5bbc66b41f8ae62…
commit 43f2177d7c4b50a5bbc66b41f8ae620f94dfb6de
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:13:45 2017 +0100
BGP: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I7cb6f73efb1e37eba977dc6912041d5969989696
Reviewed-on: https://code.wireshark.org/review/20399
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a9c2a9782340fafb3fdc8f4c0f056d…
commit a9c2a9782340fafb3fdc8f4c0f056d797f7f191f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:32:19 2017 +0100
enip: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I134262482c259a9f30bfeec7bf28441d0d37d499
Reviewed-on: https://code.wireshark.org/review/20404
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c1e6724cf6938de24ddfbcb0227aad…
commit c1e6724cf6938de24ddfbcb0227aad5822a80c2d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 19:38:59 2017 +0100
dissectors: fix this statement may fall through [-Werror=implicit-fallthrough=] found
by gcc7
Change-Id: Iba6238988ded675cba328ab512232d1919d93b4a
Reviewed-on: https://code.wireshark.org/review/20415
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=70e04f3f4c1a290ce8834bb7f9773d…
commit 70e04f3f4c1a290ce8834bb7f9773d4f644db5e8
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 19:38:07 2017 +0100
dumpcap: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I46bf9ae4150d9bd7efe5387919091ac49143232d
Reviewed-on: https://code.wireshark.org/review/20414
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8b017dc919ae9c2dfcb095cdae4c31…
commit 8b017dc919ae9c2dfcb095cdae4c31513a522e5a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:28:37 2017 +0100
rsvp: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I6e9d15ef9306433b982d6aff670c38ca8a0b4e85
Reviewed-on: https://code.wireshark.org/review/20410
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7491498d12203e477e22aa1a1979e8…
commit 7491498d12203e477e22aa1a1979e86d0785ed08
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:23:33 2017 +0100
packetbb: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: Id1fb00f95608e7ad09f9eb48f1d98f5849ae575b
Reviewed-on: https://code.wireshark.org/review/20409
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5e507ca47b8628b35fc4462f793e62…
commit 5e507ca47b8628b35fc4462f793e620868b30a45
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:15:51 2017 +0100
nstrace: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I1943798d8dc7449e962856fef6286b9d74be0d34
Reviewed-on: https://code.wireshark.org/review/20407
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=53cc59270888f16f264f16bfc93f0b…
commit 53cc59270888f16f264f16bfc93f0be44eb0d12d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 17:13:33 2017 +0100
nasdap-itch: fix this statement may fall through [-Werror=implicit-fallthrough=] found
by gcc7
Change-Id: I1a0038219271c9346c0c66738b75ab087b78be82
Reviewed-on: https://code.wireshark.org/review/20406
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=89ea1ade0315dad5291f9fb5f54d26…
commit 89ea1ade0315dad5291f9fb5f54d267bcdbe8c4e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:31:22 2017 +0100
erf: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I377a62a2702b89242a0abfb51f5617f265f698f3
Reviewed-on: https://code.wireshark.org/review/20403
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=232dbe6c4242ce37849d1781d3d28e…
commit 232dbe6c4242ce37849d1781d3d28eccbc73e914
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:27:13 2017 +0100
gsm_a_bssmap: fix this statement may fall through [-Werror=implicit-fallthrough=]
found by gcc7
Change-Id: Ic45f7e7bbeb73e0a222d4837694bb781157ae042
Reviewed-on: https://code.wireshark.org/review/20402
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fd68c7dfc7d06ce7babe914f2575d9…
commit fd68c7dfc7d06ce7babe914f2575d9e4f35988ad
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:21:44 2017 +0100
csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I11b943736a4f0835e8432db95b7d471244b08a16
Reviewed-on: https://code.wireshark.org/review/20401
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c4245d835c40b0330c26a6a04c87dd…
commit c4245d835c40b0330c26a6a04c87ddef37ebe7f5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 16:08:21 2017 +0100
bacapp: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: I35174c0a94f4fc36435541b136f4f899e24e6867
Reviewed-on: https://code.wireshark.org/review/20398
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d557643193ccb240c2936fa77626d8…
commit d557643193ccb240c2936fa77626d8bb27148f82
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 15:46:07 2017 +0000
ieee802154: add modelines info
Change-Id: Ieaa9b9db97cd1753e3c395f19ae005c4df1bee3a
Reviewed-on: https://code.wireshark.org/review/20394
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bda3704b5881d802073b5c2c7980c4…
commit bda3704b5881d802073b5c2c7980c4cbebed9239
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 15:42:48 2017 +0000
ieee80211: fix indent (missing spaces)
Change-Id: Ic10c9aff5058f75d31029f5d4ac7b0ce38dcc8c7
Reviewed-on: https://code.wireshark.org/review/20393
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=509488b3bdf0453a5cf631848ab6f6…
commit 509488b3bdf0453a5cf631848ab6f6066b003aef
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Mar 5 09:02:43 2017 -0800
[Automatic update for 2017-03-05]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I074b964d75082adc6ab216514c36abf3d54c6a0a
Reviewed-on: https://code.wireshark.org/review/20395
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=867d5cd6b10f2dbf1e845e8f32a457…
commit 867d5cd6b10f2dbf1e845e8f32a4579065893151
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Mar 5 15:34:39 2017 +0100
lemon: fix this statement may fall through [-Werror=implicit-fallthrough=] found by
gcc7
Change-Id: If52bc0092f1baa833e35a9f4c107faf72c3b64d1
Reviewed-on: https://code.wireshark.org/review/20392
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e3253915743da14ae3e60b8dabc662…
commit e3253915743da14ae3e60b8dabc66283a969dcdc
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 22 10:41:38 2017 +0100
tools: add more entries to valgrind suppression file (libc).
Remove leak from dl_init.
Change-Id: Iaefc20bd0c71157d604f8f0b2538dc2481fc56db
Reviewed-on: https://code.wireshark.org/review/20248
Reviewed-by: Evan Huus <eapache(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a819806e1fa09580fe0ec3ecd1beea…
commit a819806e1fa09580fe0ec3ecd1beead2c25d2c10
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 22 10:40:29 2017 +0100
tools: add more entries to valgrind suppression file (glib).
Remove leaks coming from glib.
Change-Id: I05fc6b1143e2d20c953a2c602989cec0cc786f27
Reviewed-on: https://code.wireshark.org/review/20247
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=78d168fcbb0480109ba637590912f2…
commit 78d168fcbb0480109ba637590912f220197737cc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Mar 5 12:11:37 2017 +0100
DOF: ensure to return a value different from 0 when asking for more data
Bug: 13453
Change-Id: I331fb5f662f152c9c16b0d8ccbe228cded8ca85d
Reviewed-on: https://code.wireshark.org/review/20389
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c3dde590d8226bdb19149013acf9d4…
commit c3dde590d8226bdb19149013acf9d45781adbd16
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Mar 5 11:29:04 2017 +0100
DOF: fix an infinite loop in sid_buffer_hash_fn()
The sid buffer can contain up to 255 bytes of data, so the loop counter must
be a guint16 at least.
Bug: 13453
Change-Id: I997ce1a737532d94796586d7e109d89b2dc1911b
Reviewed-on: https://code.wireshark.org/review/20388
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e23676c999d9926f984c4076c18a10…
commit e23676c999d9926f984c4076c18a1060acb59ff4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Mar 4 18:33:33 2017 -0500
wmem: Ensure callbacks are initialized and not accidentally unregistered
Start the "callback register ID" at 1, so that zeroed out callback IDs
are not found during unregister.
Change-Id: I1d7d70f53d89c40e07d1637e1e195dd027855ed3
Reviewed-on: https://code.wireshark.org/review/20385
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b7d6cca4aeffcf8df55d6fa2e4417b…
commit b7d6cca4aeffcf8df55d6fa2e4417b731923ac8c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Mar 4 08:26:22 2017 -0500
Add wmem_tree_destroy
Allows the cleanup of NULL scoped wmem trees
Change-Id: I7c49a224ca7e2f7ddfe0e38d3ea0e79aa2cb057c
Reviewed-on: https://code.wireshark.org/review/20382
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Evan Huus <eapache(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9b4f325132091c053131b352df914f…
commit 9b4f325132091c053131b352df914f378286809a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 16:52:42 2017 -0500
Add wmem_tree_count.
There are cases where wmem_tree needs to know its number of nodes.
Change-Id: I6411cf4275fd4d85a1d76382e1922d236be3b176
Reviewed-on: https://code.wireshark.org/review/20005
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3cc1d1cf5aa6a5c05aa5d03b5e4c9f…
commit 3cc1d1cf5aa6a5c05aa5d03b5e4c9fd844ced5a2
Author: Gene Cumm <gene.cumm(a)gmail.com>
Date: Sun Feb 26 13:06:39 2017 -0500
packet-hp-erm.c: Add is_tagged flag
Remove the high bit from hp_erm.unknown3 for hp_erm.is_tagged flag.
This value was found by observation.
Also realign the static value declarations and some other cleanup
Change-Id: I8ca701cad0456c1af561fe4238e4686dc9c83c40
Signed-off-by: Gene Cumm <gene.cumm(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/20288
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d452a0cdba9ebb5a2f674d62fcbaa1…
commit d452a0cdba9ebb5a2f674d62fcbaa1f318454e15
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sun Jan 29 19:03:51 2017 +0100
Logcat-text: use GRegex optimizations
"G_REGEX_OPTIMIZE - Optimize the regular expression. If the pattern
will be used many times, then it may be worth the effort to optimize
it to improve the speed of matches." - Glib documentation.
It is possible to capture a lot of Logcat logs or these log may
flooding us. Optimizations are welcome.
Change-Id: If753e795efe30b014a5fad11c8ebbcd4da3824a6
Reviewed-on: https://code.wireshark.org/review/20357
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3f238389eb984068f7c3500d6366f5…
commit 3f238389eb984068f7c3500d6366f548469a13bd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Mar 4 15:29:39 2017 +0100
RPKI-RTR: Add new error code
From RFC-ietf-sidr-rpki-rtr-rfc6810-bis-09
Change-Id: Ice24416515448c633eb436f5f08320561c2a6a6a
Reviewed-on: https://code.wireshark.org/review/20384
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ee9b998d64c50727920be3c03a77f0…
commit ee9b998d64c50727920be3c03a77f02c61563cb7
Author: Roland Knall <rknall(a)gmail.com>
Date: Fri Mar 3 22:04:18 2017 +0100
extcap: Minor improvements
Add method for searching for tools by ifname and minor improvements
in the interface callback to save time and space
Change-Id: I0073c96fbee846cc5ff6304823fa14564ff36c22
Reviewed-on: https://code.wireshark.org/review/20376
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b7e9582fd72d85373d5223394d55f4…
commit b7e9582fd72d85373d5223394d55f405edd0eca8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Mar 3 20:34:59 2017 -0800
Fix the calculation of the number of levels in the radix tree.
The algorithm being used calculated the number of levels in a
1024-leaf-node tree as being 2, but it's 1 - 0 elements means 0 levels,
1 through 1024 elements means 1 level, 1025 through 1024^2 elements
means 2 levels, etc.. With a count of 1024, the loop would bump the
level count from 0 to 1, and divide the element count by 1024, yielding
1, so the loop would not terminate, and the level count would them go
from 1 to 2 and the element count would go to 0.
This could cause problems if exactly 1024 packets were seen.
Just use an if chain, similar to the one used when adding elements to
the tree.
Bug: 13433
Change-Id: I3eaeaf374bb65b37b38a59e95f77cac6690614ed
Reviewed-on: https://code.wireshark.org/review/20379
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=59bbe6b0cd4f33341c5c0a517474de…
commit 59bbe6b0cd4f33341c5c0a517474debf579b6804
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Wed Nov 23 13:26:17 2016 +0100
Bluetooth: HCI: A few minor improvements
1. According to ESR05 there is no event called "Bluetooth Logo Testing".
2. According to ESR09 error code 0x23 is also "LL Procedure Collision"
3. Add some HCI status for event for HCI Summary
bthci_evt is now up-to-date with Bluetooth Core 4 + CSA4 + CSS6 and ERS09
- nothing to implementing...
Change-Id: Ief9e2de61be91942ab2211de6bc44a8f15d12426
Reviewed-on: https://code.wireshark.org/review/20355
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cf1d07c8e371c48e73a27941e0e645…
commit cf1d07c8e371c48e73a27941e0e645230a0944d1
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Mar 1 10:11:27 2017 +0100
Qt: Apply selected bookmark display filter
When selecting a display filter from the bookmark list this filter
should be applied, because that's the most common action for a user.
Holding down the the Alt key will only prepare the filter.
Change-Id: I567ee8a2a70a3de07fea33fa5763d9efba591de3
Reviewed-on: https://code.wireshark.org/review/20317
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=807fe8ed99b09c33c02c7574a830ce…
commit 807fe8ed99b09c33c02c7574a830ce0b344d6e91
Author: Roland Knall <rknall(a)gmail.com>
Date: Fri Mar 3 20:55:13 2017 +0100
pluginIF: Allow en-/disable of elements
Allow the enable/disable of an element
Change-Id: I9652e8d74b261ba259cebfba53e7bc7ef560d347
Reviewed-on: https://code.wireshark.org/review/20370
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4a703e01f47d1127756dab5f43b53c…
commit 4a703e01f47d1127756dab5f43b53cc49179cf9f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 22 22:51:54 2017 -0500
Check profile directory before personal directory for services and subnets file
Bug: 11228
Change-Id: Id8bcc51ff694ef9f2019bc7509e440021d049d22
Reviewed-on: https://code.wireshark.org/review/19735
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=fdfa24dab602cb3e0ac4a5c6cc3aa5…
commit fdfa24dab602cb3e0ac4a5c6cc3aa58755f6f707
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Mar 3 21:58:48 2017 +0100
Fix compile error about missing intializer.
Change-Id: I5ff757c199df5cf78d9c625bf2f69e9c62dc3f61
Reviewed-on: https://code.wireshark.org/review/20375
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=f5ed7a5cb8b1508afd4c992762da65…
commit f5ed7a5cb8b1508afd4c992762da6514e2c1016f
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Tue Nov 22 13:35:21 2016 +0100
Bluetooth: HCI_EVT: Implement all remaining events/commands
Event:
Authenticated Payload Timeout Expired
Commands:
Set Connectionless Slave Broadcast
Set Connectionless Slave Broadcast Receive
Set MWS Signaling
Read Synchronization Train Parameters
Write Synchronization Train Parameters
Read Secure Connections Host Support
Read Authenticated Payload Timeout
Read Local OOB Extended Data
Read Extended Page Timeout
Read Extended Inquiry Length
LE Read Suggested Default Data Length
LE Write Suggested Default Data Length
LE Read Resolving List Size
LE Read Peer Resolvable Address
LE Read Local Resolvable Address
LE Read Maximum Data Length
Change-Id: Id57693b284151b054b7e06237744629a6af98057
Reviewed-on: https://code.wireshark.org/review/20354
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f22964da50418c6f3d7d9fef1c130d…
commit f22964da50418c6f3d7d9fef1c130d4887173351
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Mar 3 08:52:29 2017 +0100
Qt: Fix goto next/prev packet toolbar buttons
Use bitwise AND to check if a modifier bit is set.
Also changed from MetaModifier to AltModifier to match the comment
and the modifier key used in "Next/Previous Packet in History".
Change-Id: I89072a1dfdd14a2beb7344a672cbc18a3ace8924
Reviewed-on: https://code.wireshark.org/review/20359
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=c79b5e0eb74a5ef5e91697618a87b4…
commit c79b5e0eb74a5ef5e91697618a87b4c591ccf3cc
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 3 12:31:14 2017 +0100
Update documentation with reference to $XDG_CONFIG_HOME
Since v2.1.0rc0-184-gb0b53fa593, $XDG_CONFIG_HOME/wireshark (instead of
$HOME/.wireshark) is used, clarify this in the WSUG and manuals.
Change-Id: I74a6f9b86bd8d54ee326ca83d7536e091d6da08a
Reviewed-on: https://code.wireshark.org/review/20364
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bc94ffcb0c754591e3dbac368f90e7…
commit bc94ffcb0c754591e3dbac368f90e7f91d4a64bb
Author: erikdejong <erikdejong(a)gmail.com>
Date: Tue Feb 28 20:24:41 2017 +0100
SIP: Add digest verification functionality
Added functionality to verify SIP authorization lines. With this functionality
it's possible to find faulty passwords that were added to configuration by
automatic processes (eg having unescaped '&' characters in XML config
files) resulting in authorization failures that cannot be diagnosed
otherwise.
Other uses include bug hunting in SIP stacks.
Bug: 13444
Change-Id: I5abecd048480c8f5130a5112c531587c5993f12f
Reviewed-on: https://code.wireshark.org/review/20314
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ca68749606bb78a333a0961dbf9fa7…
commit ca68749606bb78a333a0961dbf9fa74c65fa72aa
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Mar 3 10:04:58 2017 -0800
IAX2: Add a timestamp check.
Don't try to process timestamps that are more than 60 seconds apart.
Avoids the infinite loop in bug 13432.
Bug: 13432
Change-Id: I05aea4c733c94cbfe832f03ba826c74a41e6bb2f
Reviewed-on: https://code.wireshark.org/review/20366
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=a539036339c3bbe51b5c59ed23906d…
commit a539036339c3bbe51b5c59ed23906d977878597c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Mar 2 22:19:19 2017 +0100
Qt: reduce minimum window size requirement
Strip some padding from the main welcome screen and lower the minimum
width to allow the window to be shrinked. Even when a capture file was
open, the minimum dimensions from the main welcome screen would apply.
The minimum dimensions on Arch Linux with Qt 5.8.0-5 and Plasma 5.9.2
(with the default Breeze theme) for a window have changes as follows:
- main screen/pcap loaded: 746x626 -> 702x590
- with search bar opened: 826x658 -> 826x622
(These numbers exclude 35x10 window decoration.)
Change-Id: Iccc43ee55803abb8105c0d9664368aab09e8cfcf
Reviewed-on: https://code.wireshark.org/review/20343
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=85aa48cef2d6334a05963bf36711d4…
commit 85aa48cef2d6334a05963bf36711d47eceb3d209
Author: Roland Knall <rknall(a)gmail.com>
Date: Fri Mar 3 11:53:39 2017 +0100
pluginIf: Add/Remove single entries from selector
Allow to add and remove single items from a selector list and also
fixing the selection of items in a selector list
Change-Id: I0c69ea97db6ca1a6932939f0df9049c6fb720f77
Reviewed-on: https://code.wireshark.org/review/20363
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9eca0390e70bf72573189c6f4d20d3…
commit 9eca0390e70bf72573189c6f4d20d352ace8b814
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Mar 3 12:39:14 2017 +0100
WSDG: update for $XDG_CONFIG_HOME
Since v2.1.0rc0-184-gb0b53fa593, the config directory has changed.
Change-Id: Idbeb62f2393d1a4ec192da2d85e6bfb76782aeb8
Reviewed-on: https://code.wireshark.org/review/20365
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cde54839af9158368368e60212833c…
commit cde54839af9158368368e60212833cda7365bf92
Author: Marcin Rokicki <marcin.rokicki(a)gmail.com>
Date: Fri Mar 3 11:08:08 2017 +0100
ieee80211: fix minimum TCLAS length
TCLAS IE contains a set of parameters to identify incoming
frames with a TS.
During verification with various types of classifier types
Wireshark prints Error/Malformed message for type 2 (IEEE802.1Q)
IEEE802.11e defines that for classifier type 2 frame length is
5 not 6.
Change-Id: Icf61f7fb65e5b119aedbb664b4adaee1f1e9fde8
Signed-off-by: Marcin Rokicki <marcin.rokicki(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/20361
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=aa02f5737c277bd600295a6845031a…
commit aa02f5737c277bd600295a6845031a5b8625081a
Author: Martin Peylo <wireshark(a)izac.de>
Date: Thu Mar 2 18:07:40 2017 +0200
Having business-as-usually unused words for specific "users" in TIPC not
shown
as needlessly highlighted expert info but as normal text in the protocol tree.
Change-Id: I41028b00c6c5cdb85e399c959df721d768f674e1
Reviewed-on: https://code.wireshark.org/review/20360
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4796f79f2f2c553b8a919694a2fff5…
commit 4796f79f2f2c553b8a919694a2fff59ea2b1fc06
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Mar 3 11:13:44 2017 +0100
Diameter 3GPP: update Rx Feature-List AVP
Change-Id: Ia4fa3687173f8642f80e650df3e713a26e9a17b5
Reviewed-on: https://code.wireshark.org/review/20362
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=88fbd72f21a045cd601d0170ae63a5…
commit 88fbd72f21a045cd601d0170ae63a5b992de48b7
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Tue Nov 22 13:30:18 2016 +0100
Bluetooth: HCI_EVT: Implement "Read Local Supported Codecs"
Implement event reponse for command "Read Local Supported Codecs".
Change-Id: I38946f4744b2d2d586384125700e937db698038c
Reviewed-on: https://code.wireshark.org/review/20353
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=35592f94ecd60dfd95ed207d8cce0c…
commit 35592f94ecd60dfd95ed207d8cce0c63f70e001f
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Mar 2 16:04:48 2017 +0100
Bluetooth: HCI_EVT: Add missing unit for generated field
Add missing unit [ms] for "Command-Response Delta"
Change-Id: I7ba31fc6bf3baae161608432ea5fcd1015414604
Reviewed-on: https://code.wireshark.org/review/20356
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8e76cfbf54c209336d3aaf7e613e30…
commit 8e76cfbf54c209336d3aaf7e613e309675eebf38
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Mar 1 10:03:17 2017 -0600
Qt: Add selection history navigation.
Add the ability to move back and forth in the packet selection history
similar to GTK+. Update the documentation accordingly.
Change-Id: If1fdc1e59b240c0588c292dc0f7f0a5f083c30e1
Reviewed-on: https://code.wireshark.org/review/20320
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bc56801319ba30b6d83f336ec1d793…
commit bc56801319ba30b6d83f336ec1d793b3a0ab016a
Author: Florian Adamsky <fa-git(a)haktar.org>
Date: Tue Feb 28 21:19:48 2017 +0100
BT-DHT: add IPv6 support for find_node responses
Change-Id: I4ce38892b6c287c2dc51f438a12a5be5920197b6
Reviewed-on: https://code.wireshark.org/review/20323
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8f35d6ff900120afe53ffaa9284ed8…
commit 8f35d6ff900120afe53ffaa9284ed86b5db9614a
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Mar 2 22:10:36 2017 +0100
Qt: allow Packet Bytes view to be shrinked
Even if a packet has only one or two lines for the byte view, Qt
autoresizing insists to require a minimum of 5.5 lines (or 7.5 lines for
packets without multiple data sources). Remove this artificial
requirement and allow the packet bytes view to be resized to show
nothing (except for possible data sources tabs).
This makes it easier to fit more packets and details for screenshots.
Change-Id: I3ea997b9effa8292b396dc2ceb2ab1c35cead410
Reviewed-on: https://code.wireshark.org/review/20342
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a9ec1e41b19abd9da62f15ffbd94db…
commit a9ec1e41b19abd9da62f15ffbd94db3dbc4a3d9f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 18:54:26 2017 -0800
Squelch a warning from VS Code Analysis.
It warns that a 32-bit value is being shifted left and then converted to
a 64-bit type; presumably it means "this might overflow and not give you
the result you expect". That's unlikely to be the case here, as few
UN*X file systems have a recommended I/O block size > 2^30, but we might
as well throw in a cast so the convert-to-a-64-bit-type is done first.
Change-Id: Id6ab11d750d5cf4cc03d060d63edc01b66cd179d
Reviewed-on: https://code.wireshark.org/review/20352
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=300f474737108e3cd9340d2d1eb1cd…
commit 300f474737108e3cd9340d2d1eb1cdc7b9f21fa4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 18:04:41 2017 -0800
Fix compilation with old libcrypt versions.
Change-Id: If9c0631435e5380d3f158ebe6578adaf65a429bb
Reviewed-on: https://code.wireshark.org/review/20351
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ead24d24dc994bc93fd89368855f69…
commit ead24d24dc994bc93fd89368855f690a8717ea6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Mar 2 22:37:48 2017 +0100
erf: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I7214adc58362902790c006e1e22f77104be5df2e
Reviewed-on: https://code.wireshark.org/review/20341
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f1c75cf6ef7e9f9de1ec7fd798df94…
commit f1c75cf6ef7e9f9de1ec7fd798df941b972ec71c
Author: Erik de Jong <erikdejong(a)gmail.com>
Date: Mon Feb 13 19:31:26 2017 +0100
Rewrite dissectors to use Libgcrypt functions.
As discussed on the mailinglist, rewriting dissectors to use Libgcrypt
functions as Libgcrypt will be mandatory after change 20030.
Removal of following functions:
- crypt_md4
- crypt_rc4*
- aes_cmac_encrypt_*
- md5_*
- sha1_*
- sha256_*
Further candidates:
- aes_*
- rijndael_*
- ...
Added functions:
- ws_hmac_buffer
Added const macros:
- HASH_MD5_LENGTH
- HASH_SHA1_LENGTH
Changes on epan/crypt/* verified with captures from
https://wiki.wireshark.org/HowToDecrypt802.11
Changes on packet-snmp.c and packet-radius.c verified with captures from
https://wiki.wireshark.org/SampleCapture
Changes on packet-tacacs.c verified with capture from
http://ccie-in-3-months.blogspot.nl/2009/04/decoding-login-credentials-rega…
Change-Id: Iea6ba2bf207cf0f1bf2117068fb1abcfeaafaa46
Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html
Reviewed-on: https://code.wireshark.org/review/20095
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=4bd3c4d44ddcdf8e98fdf08a425e3a…
commit 4bd3c4d44ddcdf8e98fdf08a425e3a68e9b18395
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 15:02:14 2017 -0800
Remove a cast that now causes rather than squelching warnings.
We're now comparing an unsigned with an expression made mostly of
unsigned, so there's no need to cast the expression to long to squelch
signed vs. unsigned warnings.
Change-Id: I3b8c6f6faf26a9c252eb55d9e69fb298a3ad4c3b
Reviewed-on: https://code.wireshark.org/review/20347
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b98bb5188c9082a06a370483c9474a…
commit b98bb5188c9082a06a370483c9474a929e957659
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 14:51:43 2017 -0800
Make sure nspr_getv20recordsize() returns an unsigned value.
The record size fields are guint8, but NSPR_V20RECORDSIZE_2BYTES was
0x80, which has type int, promoting the result to int. Make it 0x80U,
which means everything is unsigned.
This squelches a compiler warning.
Change-Id: I1c63e485352a90c7f675ab0dacaaeba794235b35
Reviewed-on: https://code.wireshark.org/review/20344
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b019c5931c945c20b9bc3f0c1f904d…
commit b019c5931c945c20b9bc3f0c1f904dd3bd590873
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 13:03:09 2017 -0800
Add more sanity checks.
Bug: 13431
Change-Id: I330cb087c6e89277120057019cb5155f005ed269
Reviewed-on: https://code.wireshark.org/review/20337
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2f6ba7534721d643fca84bfce80712…
commit 2f6ba7534721d643fca84bfce80712daa4fffa3d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 2 16:17:56 2017 +0100
Use glib-compat
Change-Id: I510af18d433c4db360243dda72260e59eb84355f
Reviewed-on: https://code.wireshark.org/review/20336
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bf28bd4da3c163234dbdccf4926018…
commit bf28bd4da3c163234dbdccf492601853b697073d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 2 14:01:21 2017 +0100
[packet snort] Fix build on SuSE 11.4
packet-snort.c: In function snort_dissector:
packet-snort.c:882: error: converted_content_length may be used
uninitialized in this function
packet-snort.c:882: note: converted_content_length was declared here
packet-snort.c:880: error: content_offset may be used uninitialized in
this function
packet-snort.c:880: note: content_offset was declared here
Change-Id: I8fb990492f31fc4ce942244005f547f3b3c9bba3
Reviewed-on: https://code.wireshark.org/review/20335
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4fdc16d8e4e2bf527fe75d6143d09e…
commit 4fdc16d8e4e2bf527fe75d6143d09e3238553170
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Mar 1 15:58:16 2017 -0600
Docbook: Replace "OS X" with "macOS".
Change-Id: Ic2ab4f9050c9c76349d8d872b8fc2bf9feb7827d
Reviewed-on: https://code.wireshark.org/review/20325
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2d0e4c37304031ac51d56d62deb672…
commit 2d0e4c37304031ac51d56d62deb672df5a4e5c3a
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Mar 2 12:34:35 2017 +0100
include <wsutil/glib-compat.h> to allow use of g_list_free_full() with
older glibs.
Change-Id: I3eb7e178dcb844ddbac47f53f221a98e2d32f413
Reviewed-on: https://code.wireshark.org/review/20334
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e4dfeed2ca2491fa944dc9cd5180ec…
commit e4dfeed2ca2491fa944dc9cd5180ec202313b5b6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Mar 2 01:00:25 2017 -0800
Do more record length checks.
Do the check early in the process of processing the record, and do it
for all record types.
Bug: 13429
Change-Id: Id7f4d12415c6740241850d8f873cff52909e7110
Reviewed-on: https://code.wireshark.org/review/20330
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=19c51d27b9cabf7b811d6c60e42a59…
commit 19c51d27b9cabf7b811d6c60e42a59330235c2de
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Mar 1 19:53:29 2017 -0800
Don't go past the end of a page in a NetScaler file.
Records in a properly formatted NetScaler file shouldn't go past the end
of a page, but nothing guarantees that a NetScaler file will be properly
formatted.
NetScaler 3.x files allow record bodies to go past the end of a page,
but 1.x and 2.x files don't, so treat record headers that go past the
end of a page, and record bodies in 1.x and 2.x files that go past the
end of a page, as errors.
Clean up some stuff while we're at it.
Bug: 13430
Change-Id: I3b1d56086e3bb14b246406f306e3d730df337561
Reviewed-on: https://code.wireshark.org/review/20326
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=929e0e897cc857dc11cffc612c4eb8…
commit 929e0e897cc857dc11cffc612c4eb8030cbb0e2d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Mar 1 11:32:24 2017 +0100
udpdump: fix recvfrom error on windows.
Change-Id: Ia88d00593163b1c1e9a0e120aeff5e36f0135474
Reviewed-on: https://code.wireshark.org/review/20319
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9157e4035d962fc87ad4fbf8f8299c…
commit 9157e4035d962fc87ad4fbf8f8299c1e1c0677bd
Author: Rémy Léone <remy.leone(a)gmail.com>
Date: Wed Mar 1 17:04:14 2017 +0100
Fix spelling mistake
Change-Id: I21ef4e5b19299f843a6f2a644bfa7068abd90fc4
Reviewed-on: https://code.wireshark.org/review/20321
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1d31986e8d26f5c05b8b3125fb2ba0…
commit 1d31986e8d26f5c05b8b3125fb2ba0ec356139c1
Author: Roland Knall <rknall(a)gmail.com>
Date: Wed Mar 1 10:04:59 2017 +0100
extcap: Create callback structure
To ease development of callbacks and new parameters,
move all parameters for the callback methods to a
struct
Change-Id: I160277acf4d0473897172124f7c7aa744718da9c
Reviewed-on: https://code.wireshark.org/review/20316
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=17dd9d0544b5d28eb28f5010918b52…
commit 17dd9d0544b5d28eb28f5010918b52b96bce6da4
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 28 17:19:55 2017 +0100
radius: remove unused rule, add clarifying comment
Since commit fdb5257f7cc8e19e6f8bcd35edee225cf44438a2 the ATTR_W_VENDOR
symbol was never matched, so remove it.
Change-Id: I5a56f48ce1995c23f9eca518308d3543a15ad049
Reviewed-on: https://code.wireshark.org/review/20313
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=82b2d8b4e53878f03e469869abd6cf…
commit 82b2d8b4e53878f03e469869abd6cfa82b6f7bf8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Feb 28 11:34:50 2017 -0800
Expand a comment.
Change-Id: I4b040665582ec1fd3f97b915b3819ff2d8850a6f
Reviewed-on: https://code.wireshark.org/review/20315
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3c6900f31fcfed080d165b581ccef8…
commit 3c6900f31fcfed080d165b581ccef8f022109491
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Feb 27 23:47:11 2017 +0100
radius: fix use-after-free after recent memleak fixes
The same data is referenced by the ID-to-name and name-to-ID mapping, so
be make sure that the ID mapping is responsible (as the name mapping is
just used for duplicate detection and while parsing dictionary files).
Still to be done is fixing duplicate attribute numbers (by adding
support for OIDs and changing TLV attribute type IDs to OIDs) and fixing
duplicate attribute names (by prefixing the Vendor Names to them).
Also not handled is fixing Value memleaks.
Reproducers of the crash under ASAN:
tshark -G fields >/dev/null
tshark -r radius-ms-mppe-etrl-bug.cap (from bug 796)
Change-Id: Ifa4055901072bc830e19fe06937af67ce524a3be
Fixes: v2.3.0rc0-2536-gd4cf57100c ("Free radius dissector memory on
shutdown")
Reviewed-on: https://code.wireshark.org/review/20307
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=87b7242e69845db13daf5701019035…
commit 87b7242e69845db13daf570101903521e17cfd50
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 28 17:05:10 2017 +0100
radius: fix memleaks of value_string
The value_string was taken from the GArray and added to
radius_attr_info_t, but these were not properly freed.
Change-Id: I8de2b84760887c41229a57881ff46cedcef1d22f
Reviewed-on: https://code.wireshark.org/review/20311
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=77d309c92fdd3e7826c12301d3d4ab…
commit 77d309c92fdd3e7826c12301d3d4ab3a56251b1b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 28 17:16:54 2017 +0100
radius: fix final memleak due to malformed dictionary
The VENDOR line did not have a proper ID, so scanning the full line
failed and the "yyextra->vendor_name" was not freed. Import the current
version from FreeRadius to fix this problem.
(Since the attributes are now grouped by the vendor, the conflict
comment no longer applies.)
Change-Id: Id6020c0a5f34c624aedbb0acebe70dc643402e41
Reviewed-on: https://code.wireshark.org/review/20312
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=146b6b824da171f457198797def508…
commit 146b6b824da171f457198797def5083d2fa90a0c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Feb 21 14:28:57 2017 +0100
text2pcap: free memory on exit.
Make also text2pcap_lex_destroy() public to be called from main.
Change-Id: I360c3dd3991d027afe6e4542ea5f9680e92f92cf
Reviewed-on: https://code.wireshark.org/review/20226
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=26e62dfad07a02efc03e4c08c3c6b0…
commit 26e62dfad07a02efc03e4c08c3c6b08e5c5d2076
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 28 10:19:28 2017 +0100
Qt: Fix -Wshorten-64-to-32 warnings
Fix some warnings when building with -Wshorten-64-to-32 flag for
C++ code.
Fixes for warnings from QList, QTimer and QVector has been pushed
upstream, so some time we may be able to enable this flag for C++.
Change-Id: Iae7457f9afc469c63f3edbe23dbf272b5c6c9e5e
Reviewed-on: https://code.wireshark.org/review/20310
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=311b1ee70072531352262f3a47181e…
commit 311b1ee70072531352262f3a47181e89472e3109
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Wed Feb 15 22:25:58 2017 +0100
IEEE 802.11: Handle Atheros padding
For some unknown reason between 802.11 protocol fields end and LLC
protocol field start two octets of padding may appear. These octets
(value 0x00) were observed on the OLPC laptop, heuristically detected
and marked as OLPC mysterious stuff.
It seems that Atheros chipset drivers also show this behaviour,
although the padding is not 0x0000, but seem to be a duplicate of the
sequence control field. This is now also heuristically detected and
marked more generically as payload padding.
Bug: 13411
Change-Id: I1e817e07dc19be8b3917ff302ede3328ca6a4938
Reviewed-on: https://code.wireshark.org/review/20284
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=2534ec45c108c00a9e8c5fa09b85f1…
commit 2534ec45c108c00a9e8c5fa09b85f1c70f4ae35e
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Feb 25 12:45:33 2017 +0100
sharkd: support for rtp tap.
Change-Id: I84b542f8ace1e53f41be0b73a24aeb720c3c904a
Reviewed-on: https://code.wireshark.org/review/20271
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=5c6f6333768e16fc682b732db56175…
commit 5c6f6333768e16fc682b732db561754434f41272
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Feb 27 07:44:39 2017 +0100
androiddump: Use only non-blocking connect() instead of the socket
Architecture of androiddump based on "blocking" sockets,
however for start-up it is better to use non-bloking connect()
to avoid long waiting time then fail.
Change-Id: I2bb8ea51e24db4dd1f5a6b97e1d2bc0156342d97
Reviewed-on: https://code.wireshark.org/review/20293
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=606f941e7f9f67f7851c6eb285ca30…
commit 606f941e7f9f67f7851c6eb285ca30175aad0344
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Mon Feb 27 15:06:23 2017 +0200
RSVDv2 support - 2nd stage
Improved META_OPERATION_START (CreateSnapshot, ApplySnapshot)
Added VHDSET_QUERY_INFORMATION (SnapshotEntry)
Added DELETE_SNAPSHOT
Minor fixes:
RSVD Status field of RSVD header shown as NT_STATUS
Using more structural names for RSVDv2 hf_
Change-Id: I0199527a2de819796c7b34b663df73547f32d2fd
Ping-Bug: 11232
Reviewed-on: https://code.wireshark.org/review/20300
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4ef0fa2f15b0d389e05ff94024f194…
commit 4ef0fa2f15b0d389e05ff94024f194702ddf42f9
Author: sfd <stephen.donnelly(a)endace.com>
Date: Tue Feb 28 10:13:42 2017 +1300
Some ERF pseudo-headers have color instead of lctr value
Don't report expert-info warnings for lctr when it is actually color.
Change-Id: I689ec84dd8f1cafa1ec7e8740f9bc4091339929a
Reviewed-on: https://code.wireshark.org/review/20306
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=841531bc85629023c9f3fb73d8af60…
commit 841531bc85629023c9f3fb73d8af609e3cd32109
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 27 21:10:33 2017 +0100
wiretap (nettl/pppdump): fix this statement may fall through
[-Werror=implicit-fallthrough=] found by gcc7
Change-Id: I8c339e7484d410460d499dd2923641630b482ebe
Reviewed-on: https://code.wireshark.org/review/20303
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=59b672e5907d272ea5bd5ef571b03e…
commit 59b672e5907d272ea5bd5ef571b03e004d07705a
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Feb 26 11:49:32 2017 +0100
Return correct filter for get_hostlist_filter()
It was returning (ip.src == ... && <protocol>.port == ...).
Now, I think correctly returns (ip.addr == ... && <protocol>.port ==
...)
Change-Id: I242e13c0c79c2222e2b27fc2f9ee348b89d21ec1
Reviewed-on: https://code.wireshark.org/review/20281
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8b8a3b8d1a28c8406d41f3836dbc73…
commit 8b8a3b8d1a28c8406d41f3836dbc73fdddb568fc
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Feb 27 19:25:20 2017 +0100
Qt: Avoid null pointer dereference (CID 1401573)
Change-Id: I638174a05c6275baf54e000d941f47f8ba572169
Reviewed-on: https://code.wireshark.org/review/20302
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8851c1c56eb40432b6acd407e92da9…
commit 8851c1c56eb40432b6acd407e92da927ed909207
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 27 12:32:16 2017 +0100
extcap: remove leak in interface lists.
Change-Id: Ib57292afc88cd32736b78a901385cfdde84c46c9
Reviewed-on: https://code.wireshark.org/review/20297
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a29fe9d76afe04ae80caebfb4239d3…
commit a29fe9d76afe04ae80caebfb4239d3b5a8318183
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Feb 9 18:06:45 2017 +0100
print_stream: free memory on exit.
Change-Id: I6c4acaa9026cfdf1d4230c28c30bccfb6c025cef
Reviewed-on: https://code.wireshark.org/review/19920
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d4cf57100ce10930551b1985eac77e…
commit d4cf57100ce10930551b1985eac77e78bae6361d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Feb 26 22:18:11 2017 -0500
Free radius dissector memory on shutdown
Change-Id: I19eef65e8144d7cb6d5c9eea454581a532420c75
Reviewed-on: https://code.wireshark.org/review/20292
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=220772dc19ef8b9c20a919375b4739…
commit 220772dc19ef8b9c20a919375b47390a794c4e42
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Feb 27 10:52:08 2017 +0100
text2pcap: fix -Wmacro-redefined warning
With flex 2.6.3, this warning is observed (which causes a build failure
when -Werror is not disabled:
text2pcap-scanner.c:398:9: warning: 'yywrap' macro redefined
[-Wmacro-redefined]
#define yywrap() (/*CONSTCOND*/1)
^
text2pcap-scanner.c:76:13: note: previous definition is here
#define yywrap yywrap
Issue is specific to flex 2.6.3 and resolved upstream at
https://github.com/westes/flex/issues/162
Change-Id: I861565f5080f87a9457427e7a63b5d9256c49e85
Reviewed-on: https://code.wireshark.org/review/20294
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4b2a2eb0a4c393dcf29e505ed8f135…
commit 4b2a2eb0a4c393dcf29e505ed8f135e9b85fb60e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Feb 27 11:30:07 2017 +0100
wslua: fix documentation of Struct.fromhex
The default separator is really an empty string, not a single space.
This has been wrongly documented since the beginning.
Change-Id: I5598daec1486ce17cfeeaf5697f9759172db9cf5
Fixes: v1.11.3-rc1-1760-g860747e1e7 ("Adds some Lua helper functions: some
commonly used functions, and to help troubleshooting Lua scripts")
Reviewed-on: https://code.wireshark.org/review/20296
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e8ff9f5b488383fba593143fdd8173…
commit e8ff9f5b488383fba593143fdd81731c7c0c97d0
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Feb 27 10:53:25 2017 +0100
pluginifdemo: Adjust title texts
Small improvement in the title texts.
Change-Id: Ia413577386dab11f78fd141d6333944beefb5b33
Reviewed-on: https://code.wireshark.org/review/20295
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=513eed6871198d025a45ad70aaa507…
commit 513eed6871198d025a45ad70aaa50721857c2095
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Feb 21 14:08:27 2017 +0100
text2pcap: check return values of functions and use a single exit point.
This is going to check every function for success and following patches
will free allocated memory in clean_exit.
Change-Id: I7ba7a53eae8a37a4c25e56369af20e575c3489fb
Reviewed-on: https://code.wireshark.org/review/20225
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a08177b00bd07e77baa9db97bd731c…
commit a08177b00bd07e77baa9db97bd731cb1df9173a8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Feb 26 20:30:54 2017 +0100
HTTP: do not call g_path_get_basename with a NULL pointer
If the HTTP request was not found / captured, the request_uri pointer in
conversation data is set to NULL. Do not call g_path_get_basename in that case.
Bug: 13441
Change-Id: I86eef2072ad4932e8e415580e3144d1d95796c4f
Reviewed-on: https://code.wireshark.org/review/20289
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fd4d009e2edac2e6ad7f703265ac17…
commit fd4d009e2edac2e6ad7f703265ac17f25afcf981
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 26 21:09:41 2017 +0100
ppp: fix conflict for hf field
ccp.opt.oui' exists multiple times with NOT compatible types: FT_BYTES and
FT_UINT24
Change-Id: If6a3bbaf0012ab41722648a950f7b7007cf9a3b3
Reviewed-on: https://code.wireshark.org/review/20291
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=257359854a5f7b26a1fcff2b2a485c…
commit 257359854a5f7b26a1fcff2b2a485c05a8a49470
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Feb 26 20:35:36 2017 +0100
Fix error: extra ';' after member function definition [-Werror,-Wextra-semi]
Change-Id: I53aee8f259c3e855bf71160bbfd1d79254a5cdf4
Reviewed-on: https://code.wireshark.org/review/20290
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=53fb7e41b122f10320c80cdd9591d9…
commit 53fb7e41b122f10320c80cdd9591d97b093214bb
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 14:06:16 2017 +0100
capinfos: use single exit point.
Change-Id: Ib1b556c07ec3e1f788c48038ed6bb0ae6af5cb7d
Reviewed-on: https://code.wireshark.org/review/20196
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2de30dd18d86ddd7dd0f5aab636f36…
commit 2de30dd18d86ddd7dd0f5aab636f36d1f4a37cc1
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 14:05:15 2017 +0100
wsutil: fix bugs in plugins_cleanup().
If plugin_list was NULL, plugin_types didn't get cleaned.
Add test and set of open_info_arr.
Change-Id: I7669e3ba86039fb2b26ff2da64f51896053c5e68
Reviewed-on: https://code.wireshark.org/review/20195
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dcfc288130e0576249f3ba7f8db7ad…
commit dcfc288130e0576249f3ba7f8db7ad1681ff70f5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Feb 24 09:26:40 2017 -0800
Qt: Enable/disable Capture Interfaces buttons consistently.
The "Compile BPFs" and "Start" buttons need to be enabled and
disabled
at the same time and according to the same criteria. Make sure we do so.
Change-Id: I708886564dcf569cd71f936119195209ef6dcbd5
Reviewed-on: https://code.wireshark.org/review/20265
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=74f4664f93d94c4d160cc73366b9d5…
commit 74f4664f93d94c4d160cc73366b9d5c4fb86a463
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Feb 25 20:00:40 2017 +0100
Remove executable bit, from not executable files.
Change-Id: I8afa246172cd8d5a86513ade2f482566e3f9957a
Reviewed-on: https://code.wireshark.org/review/20272
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d8e16b79da8d5fb41c33beea26c35c…
commit d8e16b79da8d5fb41c33beea26c35c4617481f4d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Feb 26 08:11:41 2017 -0800
[Automatic update for 2017-02-26]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I3094033ff26c1d8da5abcc22a25e4075f6bc087f
Reviewed-on: https://code.wireshark.org/review/20285
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b3539fdf86988b0b8dae71d5de6983…
commit b3539fdf86988b0b8dae71d5de6983066903d5ff
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 26 09:42:40 2017 +0100
apply_line_edit(.h): fix extra ';' inside a class [-Wextra-semi] (clang) /
extra ‘;’ [-Wpedantic] (gcc)
Change-Id: Ie75da8de308a5fe3a063cf929d0bb2ab739ad96f
Reviewed-on: https://code.wireshark.org/review/20276
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8202dd37efccdf02a4543fddd5f9ab…
commit 8202dd37efccdf02a4543fddd5f9ab3f1996067f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 26 10:12:56 2017 +0100
plugin_if: fix no previous prototype for ‘ext_toolbar_find_item’
[-Wmissing-prototypes]
Change-Id: Ie11bc347b609bce754b85516601b57f6b0174f7b
Reviewed-on: https://code.wireshark.org/review/20279
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=eff417364c21eef3dba22c91fe6bf6…
commit eff417364c21eef3dba22c91fe6bf661a1a85004
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 26 10:03:14 2017 +0100
preferences_dialog (Qt): fix commas at the end of enumerator lists are a C++11
extension [-Wc++11-extensions]
Change-Id: I9781fea02e7578f7d940c050a6f405bfe4b347dd
Reviewed-on: https://code.wireshark.org/review/20278
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2cfac2c681607a0c4e3cd3457cffd4…
commit 2cfac2c681607a0c4e3cd3457cffd415c84a4959
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Feb 26 10:41:50 2017 +0100
pluginif: Adapt code for Qt4.8
Change-Id: I663bb39cc6b186228bee01946c705eb6e12a8a0a
Reviewed-on: https://code.wireshark.org/review/20280
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f3d52cb534c67df8a811578d9387c4…
commit f3d52cb534c67df8a811578d9387c41c05b714dd
Author: Kim Bäckström <kim.backstrom(a)gmail.com>
Date: Sat Feb 25 23:44:15 2017 +0100
Bugfix for extcap fileselect functionality, start button in extcap options dialog
wouldn't
get enabled if the user had selected a file (and mustexist=true wasn't
specified).
This commit also contains minor fixes to doc/README.extcap, it's now more aligned
to the
actual implementation.
Added example usage of fileselect, radio and multiselect to doc/extcap_example.py.
Change-Id: Ibfe40a35a26f49322fbe64c0594506a2163f7e20
Reviewed-on: https://code.wireshark.org/review/20274
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9782d5596a123c812a932965bd2c70…
commit 9782d5596a123c812a932965bd2c708829b7d90e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 26 10:01:53 2017 +0100
plugin_if(.h): fix commas at the end of enumerator lists are a C++11 extension
[-Wc++11-extensions]
Change-Id: I09fa357dbf9fee44a83ae9e9d78d8512b1aa9ee8
Reviewed-on: https://code.wireshark.org/review/20277
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=043ed1f6b3aba51331c7129e25934c…
commit 043ed1f6b3aba51331c7129e25934c440e32f4e9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Feb 25 20:49:43 2017 -0500
androiddump: Set connect socket to non-blocking on Windows
Bug: 13104
Change-Id: I05248dad8e72272cf0933c766ec0bf5160075e1e
Reviewed-on: https://code.wireshark.org/review/20275
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3cc899a428a9203d774987c333dab0…
commit 3cc899a428a9203d774987c333dab0edaca6e6e1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Feb 22 07:14:05 2017 +0100
smb2: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ib1a74394195a945c8c723299f08dc9709233a5af
Reviewed-on: https://code.wireshark.org/review/20245
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b91207017f0800836e664e1f91a703…
commit b91207017f0800836e664e1f91a70364a6d167b3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:01:18 2017 +0000
RADIUS: add cnergee dictionary (from FreeRADIUS)
commit e37987492b0d575a8ef41900ef916244112b2468
Author: Alan T. DeKok <aland(a)freeradius.org>
Date: Sat Feb 18 12:11:05 2017 -0500
Dictionary from cnergee.
Which modifications so that the names don't conflict with
existing ones.
Change-Id: I4fed7f38300dd8bcf526e5a07eec6c7812991d95
Reviewed-on: https://code.wireshark.org/review/20258
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d464d9cb5c94003f2a0938ab05d6a1…
commit d464d9cb5c94003f2a0938ab05d6a184dc2a8b94
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Feb 25 19:23:39 2017 +0000
Revert "Qt: call cleanup from destructor in WiresharkApplication."
Calling cleanup() twice (via exit signal and via destructor) results in a
use-after-free on exit via write_profile_recent.
This reverts commit e47f9fbeb090a68f9229b0f03c3f76a6285d2dff.
Change-Id: Ic3ca0742c03a345fd8cb7f3f782942872a3057f5
Reviewed-on: https://code.wireshark.org/review/20273
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=cd7d159c2ee180be6654a7acbf7c83…
commit cd7d159c2ee180be6654a7acbf7c83f902216462
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Mon Feb 13 09:36:02 2017 +0100
json2pcap support added
Modified tshark -T json -x output
Added tshark -T jsonraw output
json2pcap.py (can be used for basic packet editing by modifying json)
The modification in tshark -T json -x and new tshark -T jsonraw output
add into hex-data output in JSON also information on which position
each field is dissected in the original frame, what is the field length,
bitmask (for not byte aligned fields) and type. This information can be
used for latter processing. One use-case is json2pcap script which
assembles the protocol layers back together from upper to lowers layers,
which allows the basic packet modification/editing/rewriting.
Change-Id: Ibf948eb8fc7e3b0b51c12df6c3855f705a9c7925
Reviewed-on: https://code.wireshark.org/review/19990
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d00dae7af9c590a8100e54dba06852…
commit d00dae7af9c590a8100e54dba0685271bd8b1165
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Feb 24 08:24:25 2017 +0000
RADIUS: update nomadix dictionary (from FreeRADIUS)
commit ade4a571ad959d54faa4844df2305e5d5ccbb86
Author: Mark Johnson <mark(a)sunray.net>
Date: Thu Feb 9 12:15:37 2017 -0800
Updating Nomadix dictionary with missing attributes.
commit 4400bf37add2e1fb29a9dcf18ad76d2b8001db7b
Author: Ethan Hayon <ehayon(a)gmail.com>
Date: Tue Jun 4 13:27:58 2013 -0400
Updated VSAs for Nomadix Access Gateway
Change-Id: I015418dc1ac808a128f12146ff8468a5eb8b6c5f
Reviewed-on: https://code.wireshark.org/review/20259
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dfc26accc0672e2d2e287ef51adba0…
commit dfc26accc0672e2d2e287ef51adba04b32340de6
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Feb 25 12:00:26 2017 +0100
Fix compilation without plugins:
filesystem.c: In function ‘free_progdirs’:
filesystem.c:2209:12: error: ‘plugin_dir’ undeclared (first use in this function)
g_free(plugin_dir);
Change-Id: Ib52b86d41be79b8ed7e42f5fdfaddcae6b0ca5c8
Reviewed-on: https://code.wireshark.org/review/20270
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7227728fced5dad3205bf307492e90…
commit 7227728fced5dad3205bf307492e9035453f92da
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Feb 24 19:46:49 2017 -0500
Convert a few more dissectors to use wmem_hash instead of GHashtable.
Change-Id: I86c9e485b447b380f00195bf407ce28c05bb1822
Reviewed-on: https://code.wireshark.org/review/20268
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=924e6d2b49adf8eee1b13dba0feeda…
commit 924e6d2b49adf8eee1b13dba0feedadcc531245a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Feb 24 22:11:22 2017 -0500
packet-fw1.c: header should be packet scoped, not epan scoped
Subtle memory leak
Change-Id: I39e3f2d35de5a8c48469f3e0992cdfec09ff0755
Reviewed-on: https://code.wireshark.org/review/20269
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=762bf10834da9f8a5d51f2ff035970…
commit 762bf10834da9f8a5d51f2ff035970942d9070bf
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Feb 13 00:09:16 2017 +0100
Configuration dump for webshark.
Change-Id: Ideaedaaa7bf5f1244d7f6845a08e4dc36a2c798f
Reviewed-on: https://code.wireshark.org/review/20083
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=faaff7d180fd0ba3994871b1a1a121…
commit faaff7d180fd0ba3994871b1a1a121da91d0377b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Feb 24 12:20:51 2017 -0800
Replace "n/a" with an em dash.
Replace occurrences of "n/a" with an em dash. It matches what we do
elsewhere and reduces the need for translation.
Change-Id: Ib5b63be765b7da9ae3e66ab19bd25cb497fd722d
Reviewed-on: https://code.wireshark.org/review/20267
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=42cf565b50badec2b23e0a38bfff37…
commit 42cf565b50badec2b23e0a38bfff3749448ac98f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 24 18:56:52 2017 +0100
dtd: fix build due to -Wtypedef-redefinition
dtd.h defines the type, so avoid redefining to avoid this warning:
epan/dtd_preparse.l:113:3: warning: redefinition of typedef
'Dtd_PreParse_scanner_state_t' is a C11 feature [-Wtypedef-redefinition]
Change-Id: Id6dddb8fe082717b483a6eeae08dfde468c19c89
Fixes: v2.3.0rc0-2505-ge1282f2875 ("dtd: free memory on shutdown.")
Reviewed-on: https://code.wireshark.org/review/20266
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=e1282f28751fefc437280b4cb8b2e1…
commit e1282f28751fefc437280b4cb8b2e1b5df016752
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Feb 21 16:37:29 2017 +0100
dtd: free memory on shutdown.
Change-Id: I502e505730b9310066563bfd9c8df9fceddd0301
Reviewed-on: https://code.wireshark.org/review/20229
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=43487d825b9974c0406c940810e1af…
commit 43487d825b9974c0406c940810e1afac371230df
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 24 16:38:08 2017 +0100
udpdump: fix help.
Change-Id: Iad0e802f8c5d3920104751fab5135d71f02b29b8
Reviewed-on: https://code.wireshark.org/review/20264
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=147d0c2e36822afa17df686d8634b7…
commit 147d0c2e36822afa17df686d8634b7918614a80a
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Jan 23 15:51:58 2017 +0100
androiddump: Use nonblocking connect
Release as version 1.0.5:
All connects to ADB are now non-blocking.
Try to connect up to 10 times with 1ms delays,
so in worst-case it takes ~10ms (for example 14ms)
Bug: 13104
Change-Id: I791909c9c951b62195b48acd82490e1b9ebf2be0
Reviewed-on: https://code.wireshark.org/review/19968
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f22c7139e06f46685384d7ac22f4c0…
commit f22c7139e06f46685384d7ac22f4c0279cc13195
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 16:35:32 2017 +0100
tools: add options validation.
This prevents to call the apps with incongruent options.
Change-Id: I76919a2da141bd277c06e708548c971c19dd7af7
Reviewed-on: https://code.wireshark.org/review/20211
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8e6b5c14fadafa9541347b715f0fea…
commit 8e6b5c14fadafa9541347b715f0fead2eb4702f7
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Fri Feb 24 10:50:39 2017 +0000
Developers Guide typo
Change-Id: I125f8d9171ebdfaf7528d784e69d9768e6b1b8b7
Reviewed-on: https://code.wireshark.org/review/20262
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=beea6736abfcd27176ba19954141cc…
commit beea6736abfcd27176ba19954141cc4654c08f03
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Feb 24 09:49:11 2017 +0100
Qt: Code cleanup
Remove whitespace to match coding style used in file.
Change-Id: I4c1649aa02087cd39b2f516db6e40749899c5125
Reviewed-on: https://code.wireshark.org/review/20260
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=3697192ea2097d867aab61faa966f4…
commit 3697192ea2097d867aab61faa966f4c938be8199
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Fri Feb 24 09:58:49 2017 +0100
pluginif: Add documentation for toolbar interface
Add the documentation for the new toolbar interface
to the README file
Change-Id: I9dd37dc4f31760ccd1c9a3e6ae379cd6f9ca1db9
Reviewed-on: https://code.wireshark.org/review/20261
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=321386e9f49d88b64f48868c6e4079…
commit 321386e9f49d88b64f48868c6e4079b2073547a1
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Jan 24 17:34:07 2017 +0100
PluginIF: AdditionalToolbar
Creates an interface for plugins and other parts of the code, to
add a new toolbar to the system and have various widget types interact
with this toolbar.
All toolbars added via this interface, will be added to an additional
submenu called "Additional Toolbars" within Wireshark.
Also a demo plugin is being provided, demonstrating various features
of the toolbar, including updating the gui elements. It also demonstrates
how to update toolbar items.
Change-Id: I8d0351224b3d7f4b90220d58970b51695551d7e3
Reviewed-on: https://code.wireshark.org/review/19803
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bd9afdddfe45b4c9c6e966df7264d1…
commit bd9afdddfe45b4c9c6e966df7264d12cdfd85f42
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Feb 23 09:27:50 2017 +0100
Reduce number of fwrite when writing pcap-ng EPB.
According to callgrind with the patch dumping 3000 pakets the number of
calls to write_to_file is reduced from 11541 to 9000 reducing the number
of lr from 4 681 518 to 4 314 101.
If the buffer holding the packet was guaranteed to be padded to 32 bit
boundary the code could be simplified and if there was space "in front"
for the packet header it would be even better.
Change-Id: Ie991c05fa9d831ee4d703bd47b8123f2b1f83277
Reviewed-on: https://code.wireshark.org/review/20256
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d347a608c9b55628d00e17dc029170…
commit d347a608c9b55628d00e17dc029170876ae496dd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 22 17:41:36 2017 -0500
Make MIPv6 options into a dissector table.
This provides external access for dissectors and plugins to provide their
own implementation of MIPv6 options.
Also cleaned up some of the "offset defines" and just went with relative
increments for the option functions.
Change-Id: I40db0b316eec37ee2045e6d663829ce69e3dac37
Reviewed-on: https://code.wireshark.org/review/20257
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eef155561037790e58b9e39cfd9d0c…
commit eef155561037790e58b9e39cfd9d0cd5b7690349
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Feb 22 01:12:16 2017 +0100
Fix sharkd compilation on some <glibc-2.16 or <gcc-4.8
- use printf() instead of fwrite().
- don't shadow stat()
Bug: 13424
Change-Id: Idc8931bcc5b1387f0ce3a3bfa146ffeb5b4edc82
Reviewed-on: https://code.wireshark.org/review/20234
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: John Thacker <johnthacker(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=99929f727477cd5ddf74d991fa3fa5…
commit 99929f727477cd5ddf74d991fa3fa52cba9c6b7d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 17:01:51 2017 +0100
sharkd: fix redundant redeclaration of ‘cfile’ [-Wredundant-decls]
Change-Id: I6ffe2d21cabfe326568b5f090c322d4dafd92d9d
Reviewed-on: https://code.wireshark.org/review/20181
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=453cccd1c38346894357b49caf2209…
commit 453cccd1c38346894357b49caf22091bbe6f2601
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Feb 22 21:41:13 2017 +0100
USB COM: highlight the bytes of the communications descriptor
Change-Id: Ia3aa1f5e35945ff8bf500508a67731b6ad3e28e3
Reviewed-on: https://code.wireshark.org/review/20252
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=26512328ae5a491d19db3f1c27f4d0…
commit 26512328ae5a491d19db3f1c27f4d09053c461aa
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 15 07:17:56 2017 -0500
Make IP options into a dissector table.
This provides external access for dissectors and plugins to provide their
own implementation of IP options.
Change-Id: I40ce17ce408217769e3b86e364f372a5181888e1
Reviewed-on: https://code.wireshark.org/review/20163
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67f4673ce5af374b74994c8a8c488a…
commit 67f4673ce5af374b74994c8a8c488aab4dbfdca0
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 22 09:54:53 2017 +0100
geoip_db: replace g_free with free.
Fix also a const cast by using the proper constness.
Change-Id: Ifcf1854051c7f5dec911331d9cfc809e6b2dd42e
Reviewed-on: https://code.wireshark.org/review/20246
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=785a0d8e75560a9a8733f667751ea4…
commit 785a0d8e75560a9a8733f667751ea403f6400d53
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Wed Feb 22 19:04:07 2017 +0100
g_malloc -> g_malloc0 where not all struct elements are initialized or
when combined with memset.
Change-Id: I5148a65bee6d4d00c140113ffb1e228adefae93f
Reviewed-on: https://code.wireshark.org/review/20251
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=936a4c1eb95384bca8563d2b210d24…
commit 936a4c1eb95384bca8563d2b210d243167f4fe20
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Feb 22 17:39:26 2017 +0100
GPRS-NS: display nsip.cause and nsip.pdu_type as BASE_HEX
Bug: 13428
Change-Id: I82ffab61cd59bbd39d82b92c6eebf8800dc2f5be
Reviewed-on: https://code.wireshark.org/review/20250
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=68f94bd91876721c59b5df417463f0…
commit 68f94bd91876721c59b5df417463f067f0a13a02
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 14:42:42 2017 +0100
mergecap: free memory on shutdown.
Change-Id: I65445cca6b16f750bf3a98fdfea228a51b46106c
Reviewed-on: https://code.wireshark.org/review/20203
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=955cf0ba370494ecbf4ec9e0e81e1c…
commit 955cf0ba370494ecbf4ec9e0e81e1c02966d0b53
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 15:30:27 2017 +0100
editcap: use single exit point.
Change-Id: I9ed9a7effdcfdb660616f5199a8227b466e91ad4
Reviewed-on: https://code.wireshark.org/review/20204
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=23c83358f26226f01d30eafe0ded45…
commit 23c83358f26226f01d30eafe0ded4597d82269b6
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 15:36:54 2017 +0100
reordercap: free memory on exit
Change-Id: Ie81de7c185589fa7ba4c25cada5ef0e1435ef0e0
Reviewed-on: https://code.wireshark.org/review/20208
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e47f9fbeb090a68f9229b0f03c3f76…
commit e47f9fbeb090a68f9229b0f03c3f76a6285d2dff
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 16:18:14 2017 +0100
Qt: call cleanup from destructor in WiresharkApplication.
This allow the correct cleanup routine to be called both when user
exits and when application exits by itself (like in WIRESHARK_QUIT_AFTER_CAPTURE=1).
Change-Id: I88e468bde029b4247ac90616f3aba0065a2b8e00
Reviewed-on: https://code.wireshark.org/review/20210
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f977dddb10f22e40fabe92823024b9…
commit f977dddb10f22e40fabe92823024b9e3b9098f02
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 20 16:16:26 2017 +0100
Qt: free memory used by rtd_tables.
Change-Id: Ibb6e3327127840fd01c5410c145ccec07efa4c73
Reviewed-on: https://code.wireshark.org/review/20209
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6dce310305686c56b2502201c6aecc…
commit 6dce310305686c56b2502201c6aecc18f6ff760a
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Feb 21 17:28:32 2017 +0100
extcap: Reduce number of scans and storage
Reduce the number of storage arrays and the number
of necessary loads. Also include cleaner methods for
reloading the interfaces and cleanly reload if asked by
the overall system
Change-Id: I529465ec2593d40c955c6cdeaf3a85e3021c0596
Reviewed-on: https://code.wireshark.org/review/20230
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=73ac6974c4db73846c37d811a02d17…
commit 73ac6974c4db73846c37d811a02d17c1436eab47
Author: Diederik de Groot <dkgroot(a)talon.nl>
Date: Sun Feb 19 18:05:20 2017 +0100
[skinny]: Fix tvb struct size guard value
The struct size guard value was used incorrectly, causing message with short
content to be only partially dissected.
Minor:
- Renamed OffHookWithCgpn to OffHookWithCalingPartyNumber
- Added SetHookFlashDetect Message
- Removed some of the debug logging when parse_xml2skinny_dissector.py:debug=0
Change-Id: If4f20d2412f8775fac3d0a2979200e8369cea6f2
Reviewed-on: https://code.wireshark.org/review/20186
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a4d7793b4cfc2e6d578bf4723fd334…
commit a4d7793b4cfc2e6d578bf4723fd334f24cf453ec
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 21 12:38:28 2017 +0100
Qt: Avoid flicker in filter expressions toolbar
Calling adjustSize() on the display filter toolbar causes flicker
in the filter expression toolbar when switching between profiles
without buttons and in some cases changing to a profile without buttons.
Only calling adjustSize() if adding buttons should be fine to avoid
this issues, even if they may be caused by something else.
Change-Id: I8cca84a51dbbc8244dc4342ac0466e35884c294d
Reviewed-on: https://code.wireshark.org/review/20222
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e88d4459811f8cc4715b462d08e0c5…
commit e88d4459811f8cc4715b462d08e0c5bca8875a19
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Tue Feb 21 20:54:01 2017 +0200
Faking different U-RNTIs for different CCCH streams.
Change is in the FP dissector but it's effect is in the RLC dissector's
conversation finding logic (which uses the U-RNTI).
Bug: 13423
Change-Id: Ice2302a07e644d0cc744e9925df03acb722d3184
Reviewed-on: https://code.wireshark.org/review/20232
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=882fa722c02059ed5d59d77a5e3a5d…
commit 882fa722c02059ed5d59d77a5e3a5d6578eed828
Author: Chris Bontje <cbontje(a)gmail.com>
Date: Tue Feb 21 12:54:58 2017 -0700
L&G 8979 - Fix 'flags' display and RTU->master echoed responses from
SBO commands
Change-Id: I7bf8ce24ded164d547c739b00299f292bc4237cf
Reviewed-on: https://code.wireshark.org/review/20233
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c1ab23d64b3276fec5e3a33a4fa945…
commit c1ab23d64b3276fec5e3a33a4fa945067bac77e1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Feb 21 20:05:29 2017 -0800
Clean up the get_if_capabilities_ routines a bit.
Allocate the interface capabilities structure only if we succeed in
getting a pcap_t handle for it.
For remote devices, explicitly set caps->can_set_rfmon and
caps->data_link_types, to be a little bit more like what we do for local
devices.
Change-Id: I985c05f85f165fce4dfe0392569ec51ed1eeb91e
Reviewed-on: https://code.wireshark.org/review/20242
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0327078837bb5189c53080ef259d99…
commit 0327078837bb5189c53080ef259d99e6c7075e6b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Feb 21 17:41:55 2017 -0800
Only do save_errno = errno and errno = save_errno around g_free();
There is *no* need to do it around an assignment statement. (We
*probably* don't need to do it around g_free(), but better safe than
sorry - maybe some memory allocator makes system calls to hand regions
of the address space back.)
Change-Id: Ib57540cc36b505aadf4a5e8885b9a744a35b1f75
Reviewed-on: https://code.wireshark.org/review/20236
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=50dff6eac41bbe22e1436af1301628…
commit 50dff6eac41bbe22e1436af1301628eb3462bf8a
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Wed Feb 22 01:25:53 2017 +0100
Make sure we zero out the newly allocated list, otherwise g_list append may
dereference ->next containing an arbitrary value.
Bug: 13418
Change-Id: I240bc03e652ede557083379cc81b81ae83d720e5
Reviewed-on: https://code.wireshark.org/review/20235
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=b9851c740836760ab36c4862f82f3f…
commit b9851c740836760ab36c4862f82f3f8cc83fde27
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Feb 19 02:32:04 2017 -0800
Snort: use GRegex to find pcre matches
Change-Id: Ie08bc1f3139ebe5564365e662f89257ad8d5b129
Reviewed-on: https://code.wireshark.org/review/20177
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=012a179785abada629fa324652755c…
commit 012a179785abada629fa324652755c6acb51be74
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Feb 21 09:57:16 2017 -0800
Fix a double free.
In create_persconffile_profile, pf_dir_path_copy needs to be allocated
separately since the subsequent call to get_dirname is destructive. Add
back a call to g_strdup. This should hopefully fix a crash in the Win32
buildbot.
Change-Id: I591b5845032c9b8a5324bf6ac60fc43d1e92ac2e
Reviewed-on: https://code.wireshark.org/review/20231
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f04e7702c48f1c57568f1c6c21a093…
commit f04e7702c48f1c57568f1c6c21a093e71513b2c2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Feb 21 15:21:20 2017 +0100
[GSM A BSSMAP] Correct a cause value according to TS 48.008 V13.2.0
Change-Id: Ie1983530ed7e3606aa7b21ea91fb1c0867c50759
Reviewed-on: https://code.wireshark.org/review/20228
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6814cf4fa7c42a95417a52ddef4abe…
commit 6814cf4fa7c42a95417a52ddef4abedd554b300e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 21 13:18:55 2017 +0100
Qt: Handle cancel in import coloring rules
Change-Id: I450cfc41d19c0dcb4aa59c0515d8d0834cfee60b
Reviewed-on: https://code.wireshark.org/review/20223
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=4b722f2e515750311606745a2807be…
commit 4b722f2e515750311606745a2807be70def6ed97
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Feb 21 10:07:03 2017 +0100
[GSM RLCMAC] Fix column info.
Change-Id: Ib9dc9de7da088ab14e5f52b706e0c367c576b978
Reviewed-on: https://code.wireshark.org/review/20221
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c2589891e3263d1bbc1e3fb4fb2a39…
commit c2589891e3263d1bbc1e3fb4fb2a39b56a749ad7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 16:53:20 2017 +0100
DNS: Add Edwards-Curve Digital Security Algorithm (EdDSA) for DNSSEC (RFC 8080)
Change-Id: I39a8c6639174e73f90bc4c3d8bccf628c3a477c3
Reviewed-on: https://code.wireshark.org/review/20179
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c5ce5a835a1447f33fccf7e2719541…
commit c5ce5a835a1447f33fccf7e2719541a8edf78ff0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 19:04:54 2017 +0100
couchbase: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I9f5f91925607582f40855ca1a08875e83d62f4eb
Reviewed-on: https://code.wireshark.org/review/20205
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed8b549e1c9344799789a4cd0f3b64…
commit ed8b549e1c9344799789a4cd0f3b64c147303ca5
Author: olivermd <oliver.downard(a)couchbase.com>
Date: Tue Feb 14 15:07:46 2017 +0000
Couchbase: Add SSL support
Change-Id: I468f92c20184a6e5f5bd1f07d94c0b605c0593dc
Reviewed-on: https://code.wireshark.org/review/20149
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fdecfa6c30adc71222e71001637429…
commit fdecfa6c30adc71222e710016374299f01f7e7ad
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:54:16 2017 +0100
cmake: Add some missing SET_FEATURE_INFO
for nghttp2, lz4, snappy
Change-Id: I0788c2105b69ba2ae781709fb5e16e13b5ca1533
Reviewed-on: https://code.wireshark.org/review/20200
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66e45419b16b2c742625d667c241ac…
commit 66e45419b16b2c742625d667c241ac4d05429b3f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:47:20 2017 +0100
cmake: SET_FEATURE_INFO don't need to add www: for URL
Change-Id: If01c008690dc1956b42d63d67942414063f3e76c
Reviewed-on: https://code.wireshark.org/review/20199
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=86cc732c37099a4c65d1643ad4612d…
commit 86cc732c37099a4c65d1643ad4612d5f12479f87
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 15:48:19 2017 +0100
tns(.h): Remove unneeded h file
Change-Id: I11ccaa73e2ea58ffbfb897ee54bbdf89068e36dc
Reviewed-on: https://code.wireshark.org/review/20207
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c46f8b6fb33bd34d6086f6d64650c8…
commit c46f8b6fb33bd34d6086f6d64650c8287fc220ee
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Feb 20 19:21:28 2017 -0800
Get rid of unused variable.
Change-Id: I684ce34b33e8abc596b9109068e302db57f85115
Reviewed-on: https://code.wireshark.org/review/20220
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=987244e16896d481d45f3ba9c1dcf9…
commit 987244e16896d481d45f3ba9c1dcf9ab65106ced
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Feb 20 18:58:03 2017 -0800
New/updated reference URLs.
Add an IBM link for SNA, they being its creators.
Point to Wayback Machine archives for the protocols.com page, as that
doesn't seem to be available on protocols.com any more.
Change-Id: I33633c838707f13afacde7a207a06f87b9f99bbb
Reviewed-on: https://code.wireshark.org/review/20219
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2798f7c9c4a691a91b19c9ed50dbcf…
commit 2798f7c9c4a691a91b19c9ed50dbcf1c151325af
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Feb 20 18:46:08 2017 -0800
Have all the remote host list routines' names begin with recent_.
Some did, some didn't - make it consistent.
Clean up some header comments while we're at it.
Change-Id: I978c84167cce3c8f1c0280898aa4d0b60958325b
Reviewed-on: https://code.wireshark.org/review/20218
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=72e2c3acfac3f56d1b6276d6cbbf55…
commit 72e2c3acfac3f56d1b6276d6cbbf55695da849b4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Feb 20 18:31:15 2017 -0800
Have a routine to iterate over the remote host list.
Have a routine that iterates over the remote host list if it exists.
Remove the routine to get the remote host list; all accesses should be
through functions in ui/remote.c.
Change-Id: Idddceba76b50ce85ef8557e132d7552191c2fddc
Reviewed-on: https://code.wireshark.org/review/20217
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e18ad46ad06cbde22a4319a1a73f73…
commit e18ad46ad06cbde22a4319a1a73f73be76051171
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Tue Feb 21 00:03:54 2017 +0100
Don't use identical log messages for non-identical error cases.
Change-Id: Ia80f112bef5f0c10e54223d3b57570fa53f7e867
Reviewed-on: https://code.wireshark.org/review/20216
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=b82f7c5b7d30241dd190cd243111b2…
commit b82f7c5b7d30241dd190cd243111b224c2813c90
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Mon Feb 20 21:44:27 2017 +0100
Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL.
This fixes the first issue appearing in the log of
Bug: 13418
Change-Id: I2fe68a06dd4a19be8300ec34be65a8dc47d0f8b3
Reviewed-on: https://code.wireshark.org/review/20214
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=124807e59debe31754092caacedfb2…
commit 124807e59debe31754092caacedfb29ccb14efd0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Feb 20 13:26:04 2017 -0800
Fix a typo and a copy-and-pasteo.
Change-Id: I6688658698efb2588520f0ef3ffbe8e6e38aedec
Reviewed-on: https://code.wireshark.org/review/20215
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3aa88877e03c67a802dd56ea50ad33…
commit 3aa88877e03c67a802dd56ea50ad3367a9e7ded1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Feb 20 16:49:10 2017 +0100
[GTP] Make flag fields boolean.
Change-Id: I491a2f03babfae34750efa2a57a64392b4558f13
Reviewed-on: https://code.wireshark.org/review/20213
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=05cda4058c5ebc649bf358436bb8cf…
commit 05cda4058c5ebc649bf358436bb8cfe50f1d2850
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Feb 20 16:41:54 2017 +0100
[BSSGP] Dissect new Extended Feature Bitmap fields.
Change-Id: I6993a1b0d0a5056c3c2a3af0f5bc5eef6a36cde1
Reviewed-on: https://code.wireshark.org/review/20212
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dfb05b9423e9172b7a687738b82b6b…
commit dfb05b9423e9172b7a687738b82b6b715fd0e47c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:24:30 2017 +0100
wtap_opttypes(.h): fix commas at the end of enumerator lists are a C++11 extension
[-Wc++11-extensions]
Change-Id: Ie7f67510ea948fb72b57fe08d9f95d135c5855a5
Reviewed-on: https://code.wireshark.org/review/20194
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9f47916d758b1e67bfc3f1334d6cdd…
commit 9f47916d758b1e67bfc3f1334d6cdd0b815f05ba
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:23:18 2017 +0100
print(.h): fix commas at the end of enumerator lists are a C++11 extension
[-Wc++11-extensions]
Change-Id: Iedffbd72c855340ab77157df954366c8e479c7df
Reviewed-on: https://code.wireshark.org/review/20193
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d84577fe1aeb8e3b06d922258ccb48…
commit d84577fe1aeb8e3b06d922258ccb482e5a2201cc
Author: Gerald Combs <gerald(a)zing.org>
Date: Sun Feb 19 10:58:47 2017 -0800
Yell at the user less.
Our user-facing messages should have a helpful (or at the very least
neutral) tone. In English, exclamation points are neither. Replace a
bunch of them with periods.
Change-Id: I29c3b2f84c25e06aae5b559860224559053a0378
Reviewed-on: https://code.wireshark.org/review/20189
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e8066cc287e0f93f23714d1c45371…
commit 6e8066cc287e0f93f23714d1c453714e5d38f9c5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Feb 20 14:32:42 2017 +0100
stats_tree: fix no previous prototype for ‘stats_tree_cfg_free’
[-Wmissing-prototypes]
Change-Id: Iddf63fabec9a2abb5b3d75fb5289f769e0175b55
Reviewed-on: https://code.wireshark.org/review/20197
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=94559de84901d6ae1104472cf11def…
commit 94559de84901d6ae1104472cf11defdc38444bcd
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Feb 20 15:49:53 2017 +0100
[Diameter] Add 3GPP AVPs
Change-Id: I53c2298584b53943924da417ac407e13f7c23d40
Reviewed-on: https://code.wireshark.org/review/20206
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=52ce1b03e04e9a941b1df599214ce2…
commit 52ce1b03e04e9a941b1df599214ce205aeafe3e0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Feb 19 22:02:04 2017 +0100
SNMP: fix insertion of first entry in SNMP Users UAT
when using the GUI to add the first entry, num_ueas is still 0.
Change-Id: Iea03495a2e5e39b71391a01454aec5fb6e2b05eb
Reviewed-on: https://code.wireshark.org/review/20191
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1089211c0b0aca7d95b4f54ca0e61d…
commit 1089211c0b0aca7d95b4f54ca0e61d070555e896
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Feb 19 21:41:55 2017 +0100
SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue()
Otherwise you can end up freeing twice the same memory blocks
(from localized_ues and unlocalized_ues lists)
Bug: 13420
Change-Id: I7e6f1f8d740b0e5ffca851f3f5b1928a7686c069
Reviewed-on: https://code.wireshark.org/review/20190
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e2e4415c9fefbe3c8b840c3207c8e1…
commit e2e4415c9fefbe3c8b840c3207c8e1197e9b385e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Feb 17 16:19:56 2017 +0100
Add some glib functions not available in older glibs
Change-Id: I6526d799447a3b6c0b9bb42f8d0f8c3415299ed0
Reviewed-on: https://code.wireshark.org/review/20158
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6c654861d94869e32536c19c500166…
commit 6c654861d94869e32536c19c5001666c1faf96c7
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Feb 19 19:46:13 2017 +0100
Qt: Mystery pixel issue is solved
The mystery pixel issue has probably been mysteriously solved earlier
because the adjustments does not work as expected now.
This fixes an issue where one of the panes increases with 1 pixel at
startup and when changing profile using layout type 3, 4, 5 and 6
(selection number 1, 4, 5 and 6 in “Preferences -> Appearance -> Layout”).
Change-Id: Iab36fa5303dc8628b21e5cf920e7c70a7167d76e
Reviewed-on: https://code.wireshark.org/review/20188
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b3f435ef54686718aea652a6d6725b…
commit b3f435ef54686718aea652a6d6725b3cd62dd1e0
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Feb 18 22:40:49 2017 +0100
Qt: Add "Reset Layout"
Add menu item "Reset Layout" to manually reset panes to equal sizes.
Change-Id: I1efbf655462e25053062e03f8038dc20f9f555c0
Reviewed-on: https://code.wireshark.org/review/20173
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d1b943dd7d39fa663e9bf9100b3053…
commit d1b943dd7d39fa663e9bf9100b30537a67b2e8ba
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 13 16:37:39 2017 +0100
stat_tap_ui: skip duplicate keys.
Change-Id: If2a2d6af94458a72dc304eae3cacac0a4af2d25a
Reviewed-on: https://code.wireshark.org/review/20092
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=29733ad8745770d13335faef8b5e3c…
commit 29733ad8745770d13335faef8b5e3ce5521fd609
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 17:00:47 2017 +0100
DNS: Don't display DNSSEC Protocol and Algo in flag tree
Change-Id: Ifbee604f25c27076750f41ada9dfef6157ac7819
Reviewed-on: https://code.wireshark.org/review/20180
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=351e8924d35edabb052dced5f5e703…
commit 351e8924d35edabb052dced5f5e7039b2fd0f777
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 18:31:58 2017 +0100
BGP: Update some draft to final RFC
draft-ietf-idr-aigp -> RFC7311
draft-ietf-idr-ls-distribution -> RFC7752
draft-ietf-idr-large-community -> RFC8092
Change-Id: Ia05809ed88514f3a0c221af2aaea779f24be99e7
Reviewed-on: https://code.wireshark.org/review/20187
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9ce32f995c2513fd4d236055739489…
commit 9ce32f995c2513fd4d236055739489b88e3f9665
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 19 17:11:09 2017 +0100
BGP: add Deprecated BGP Path Attribute (RFC 8093)
Change-Id: I18f01f8c989a8d25a168761f22b4cf6e2b51bf18
Reviewed-on: https://code.wireshark.org/review/20182
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9b008282c4ee79c696d435a42af724…
commit 9b008282c4ee79c696d435a42af7243c20482a40
Author: Alexandr Savca <s.alex08(a)mail.ru>
Date: Sat Feb 18 14:34:22 2017 +0200
packet-tns.c: Add Sesskey, Auth (SQLNET_RETURN_OPI_PARAM)
I added a few TNS pcaps on the SampleCaptures wiki and tested with all
of them.
With this patch I get an error (malformed packet) on 'Set Protocol'
response. Peter Wu fixed it by this patch:
https://code.wireshark.org/review/#/c/20098/
Change-Id: Ia41ba7d229a5332740c57853b1929764604eda03
Reviewed-on: https://code.wireshark.org/review/20165
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dc173f97c0701ddaf4bd978c3b0222…
commit dc173f97c0701ddaf4bd978c3b02225b69ea1d4d
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Feb 19 15:54:55 2017 +0100
tap: use g_new0() instead of g_new() and memset()
Change-Id: Ib6b7424ac38a08efebc3b86aca4dc6641f6c7585
Reviewed-on: https://code.wireshark.org/review/20178
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=ef20188bf6b7170cef5f0d0b86f929…
commit ef20188bf6b7170cef5f0d0b86f929f74e852dc4
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Feb 19 08:12:05 2017 -0800
[Automatic update for 2017-02-19]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I2796bfe2a186adfe14adaf09c0fef65e765c474a
Reviewed-on: https://code.wireshark.org/review/20183
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=e2951a2ca8dd10c7c9e514c45ba8d4…
commit e2951a2ca8dd10c7c9e514c45ba8d4b2204b0b71
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 12 00:04:31 2017 +0100
stat_tap_ui: remove leaks.
Change-Id: If7a28ba305bed9f63f200f8a8a27a796f2df9c07
Reviewed-on: https://code.wireshark.org/review/20015
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=897c75012792cbfdfd275f56b9b4c4…
commit 897c75012792cbfdfd275f56b9b4c4418c7354ad
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Feb 18 10:46:24 2017 -0500
Clean up some memory leaks in wsutil/filesystem.c
The fixes involve functions always returning a string that needs to be
freed by the caller. That way the static string pointers within the functions
don't end up leaking at program end.
Change-Id: I35a8dc37536c2927d88f33217887f62efafcc8ca
Reviewed-on: https://code.wireshark.org/review/20175
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7e70311a4ff6e0b4cc08a481fdf0f1…
commit 7e70311a4ff6e0b4cc08a481fdf0f1cc422b13cd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Feb 18 17:29:52 2017 -0500
Fix ieee80211_tag_ssid
Was still using tag type + length when doing offset calculations.
Change-Id: I778f56f28fa1ccec57c5192df4f8e4aa99e45e45
Reviewed-on: https://code.wireshark.org/review/20174
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f7724c319e97e03eac547db410c697…
commit f7724c319e97e03eac547db410c6971fbb61d68d
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sat Feb 18 13:28:43 2017 -0500
file-pcapng: Undo some unnecessary changes.
In commit 35cf66d8bd2d225ab4dad39f5af5253ab6c8caa9 four existing
objects were renamed for no good reason. Restore original names.
Also remove unnessary Darwin options from packet block options
and remove leftover include.
Change-Id: I9dfa642639af13e73b519438b82b1b2a77546c7c
Reviewed-on: https://code.wireshark.org/review/20171
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jim Young <jim.young.ws(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0a4273f338a038da541e9f647e41f9…
commit 0a4273f338a038da541e9f647e41f928fdc44338
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Feb 18 15:29:56 2017 -0500
Only cleanup open_routines if not NULL
Change-Id: I76ea675625ef2812f51bad0c37f6c58060897f55
Reviewed-on: https://code.wireshark.org/review/20172
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8c758f06c3b9de7aaaad2ca5fdb5f8…
commit 8c758f06c3b9de7aaaad2ca5fdb5f8b0ed0a4116
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Feb 18 16:17:31 2017 +0100
roofnet: display always reserved field
Change-Id: I22d91cad10f925e7634c246ef9d22abe59fd9b51
Reviewed-on: https://code.wireshark.org/review/20170
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=45a216eb526cfa976616d6a2bb393f…
commit 45a216eb526cfa976616d6a2bb393fcede7c8aa3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Feb 18 10:07:32 2017 +0100
roofnet: always declare variable on the top
i known... not longer recommanded but i prefer
Change-Id: I0114202a2f1d7045524aa9fe254209c93d510b7d
Reviewed-on: https://code.wireshark.org/review/20169
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=279dc61df158c52f436bc136d0fca6…
commit 279dc61df158c52f436bc136d0fca6ec4f91c5d9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Feb 18 10:00:40 2017 +0100
roofnet: fix indent (add some missing space)
Change-Id: Iecd662a60ffc96e5d4900c716766fd376a6b2c14
Reviewed-on: https://code.wireshark.org/review/20168
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fcc9cf2e454be68348f19cb4416702…
commit fcc9cf2e454be68348f19cb4416702a208da5fb3
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 14 10:05:01 2017 +0100
proto: ensure that length is set for proto_tree_add_item_new_ret_length
A user reported that the TNS dissector would show "Malformed Packet" in
the Info column in Qt. The actual packet details and Expert Info dialog
however had no trace of the issue.
It turns out that proto_tree_add_item_new_ret_length did not correctly
set the length. Test case (based on pcap from SampleCaptures wiki):
tshark -r TNS_Oracle1.pcap -w 19.pcap -Y frame.number==19
tshark -r 19.pcap -Y tcp
Change-Id: I82cb1ccbc7c3b33d2bcdb22f89a1754c1a4575e7
Fixes: v2.1.0rc0-1394-gc67c6e8f30 ("Add routines to add an item and return the
item's real length.")
Reviewed-on: https://code.wireshark.org/review/20098
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=64d0133e8811102f153253e42385d9…
commit 64d0133e8811102f153253e42385d992da072911
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 12 16:52:11 2017 +0100
plugins: free list on cleanup.
Change-Id: Idff606297f72238f8539cb00ea394ee80fcb502c
Reviewed-on: https://code.wireshark.org/review/20074
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f792625b1df21a6fb6bdf5dff6a1c7…
commit f792625b1df21a6fb6bdf5dff6a1c7bc4019e34d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 10 18:04:20 2017 +0100
epan/wsutil: free memory on exit.
Change-Id: I1cf3a4ce3b21b2e10887cbef5576e5e028e55bab
Reviewed-on: https://code.wireshark.org/review/20052
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6d79055ba651c6f1e45b22960c5fd3…
commit 6d79055ba651c6f1e45b22960c5fd34c75c95133
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 8 14:25:57 2017 +0100
wsutil: remove leaks from filesystem and plugins code.
Change-Id: Iac2805c0130bd2ba6cdb3c9dd997050274d58d99
Reviewed-on: https://code.wireshark.org/review/20020
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=19b97fbfb0b7aac19c2a2817f4e2cc…
commit 19b97fbfb0b7aac19c2a2817f4e2cc0f295d4352
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Feb 18 00:41:53 2017 -0800
Why you only get 16 bytes of process name.
Change-Id: I719706e04668aa50ed0eb6184681943718b67f00
Reviewed-on: https://code.wireshark.org/review/20164
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3d02987272d43c01cd506786c5068f…
commit 3d02987272d43c01cd506786c5068fdbe02e211e
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Fri Feb 10 18:42:29 2017 -0800
roofnet: decode framed ethernet frames.
Change-Id: I4881bf8e16c75d34ff3421230b763803c1d2f43b
Reviewed-on: https://code.wireshark.org/review/20055
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=35cf66d8bd2d225ab4dad39f5af525…
commit 35cf66d8bd2d225ab4dad39f5af5253ab6c8caa9
Author: Jim Young <jyoung(a)gsu.edu>
Date: Thu Feb 16 21:27:05 2017 -0500
file-pcapng: Add support for inspecting Apple's PKTAP enhanced pcapng files
This patch augments the MIME based file-pcapng dissector to allow one to
more easily examine pcapng blocks that contain Darwin Process Information.
With this patch one can dissect and inspect, albeit as a MIME object, the
Darwin process information elements contained within an Apple augmented
pcapng file:
$ wireshark -X read_format:'MIME Files Format' -r bug12587.pktap.pcapng
$ tshark -V -X read_format:'MIME Files Format' -r bug12587.pktap.pcapng |
egrep '^ Block:|Darwin .* =' | less
Apple's macOS provides an enhanced tcpdump with a pktap interface option
that supports the collection, display and storing of Darwin process and/or
service class information related to each captured packet. Using Apple's
pktap interface during a live capture the process information may be
revealed using Apple's tcpdump -k [metadata] option.
Apple's tcpdump -k option augments tcpdump's standard report with an
additional parenthesized () set of information inserted after the packet
timestamp. If the capture file actually contains Darwin process
information, Apple's tcpdump -k could include the interface name (or
interface id), process id, process name, process_uuid, service, and/or
direction for each packet depending on the value of the -k's [metadata]
argument provided (if any).
If the Apple tcpdump trace is captured to disk, the Darwin based process
and service information is saved in pcapng format augmented with several
new Enhanced Packet Block options (32779, 32780, 32781) along with a new
block type (0x80000001) called here a Darwin Process Event Block (DPEB).
The Darwin Process Event Block is used in a manner similar to a pcapng
IDB in that it contains process event information that is referenced by
later EPB's via the EPB options Darwin DPEB ID (32769) and Darwin EDPEB
ID (32871). EPBs may also include the Darwin Service Class option (32770)
which includes a numeric value that maps to a mnemonic service class.
A PKTAP enhanced pcapng file can later be read back in with Apple's tcpdump
along and the help of its -k option to display the original Darwin Process
Information. Packets collected using Apple's remote virtual interface
(rvictl)[1] from iOS devices can also contain Darwin Process Information.
Note: This is a first step to help determine what will be necessary to
eventually display any available Darwin Process Information within
the Frame tree when an Apple PKTAP enhanced pcapng file is opened
naturally in Wireshark and not as a MIME object.
[1] https://developer.apple.com/library/content/qa/qa1176/_index.html
Ping-Bug: 13096
Ping-Bug: 12587
Change-Id: I180e661dab0b0096a711603b53270105390d05e2
Reviewed-on: https://code.wireshark.org/review/20157
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7ccc55123982ec5bef7bc843f1db6d…
commit 7ccc55123982ec5bef7bc843f1db6d97c57f55e1
Author: Chris Bontje <cbontje(a)gmail.com>
Date: Fri Jan 20 10:32:33 2017 -0700
Modbus - Add ability to filter by holding/input register number OR value
Bug: 13337
Change-Id: I695530c29b9b0f76eab65503dcba97d19af343fb
Reviewed-on: https://code.wireshark.org/review/19706
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7d8306829b7253aa4c6a6067d7062a…
commit 7d8306829b7253aa4c6a6067d7062a7fc368a358
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 12 17:21:38 2017 +0100
user_encap: Don't allocate duplicate strings for user_encap2
All is does is lead to memory leaks.
Change-Id: Ia20b95c9a7ae36df5b902cf59b33fbd046c2da56
Reviewed-on: https://code.wireshark.org/review/20076
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d3d96cac4e4ad0d0e11a85e646891…
commit 5d3d96cac4e4ad0d0e11a85e64689105cc7e53c7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Feb 12 12:35:46 2017 -0500
transum: Add protections against NULL trees.
proto_find_finfo doesn't have NULL tree protection, so protect it from
transum dissector.
Bug: 13395
Change-Id: I1037c675cf10b959f116b20b12cc7b388c175cd3
Reviewed-on: https://code.wireshark.org/review/20077
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2c3dda5126e37c36a0176e8d4df712…
commit 2c3dda5126e37c36a0176e8d4df712538decf470
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Fri Feb 17 14:27:35 2017 +0200
SMB2 ioctl FSCTL_STORAGE_QOS_CONTROL dissector
Format of the data is described by MS-SQOS document -
see https://msdn.microsoft.com/en-us/library/mt226249.aspx
Both v1.0 and v1.1 are handled.
Also few cosmetic fixes for
dissect_smb2_FSCTL_QUERY_SHARED_VIRTUAL_DISK_SUPPORT
Bug: 13417
Change-Id: If7b793042257112d8f16f739d09aafe168443960
Reviewed-on: https://code.wireshark.org/review/20156
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=46ae4acf2d61b900d6db9ed05a214c…
commit 46ae4acf2d61b900d6db9ed05a214c5d756e3623
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Mon Feb 13 12:10:26 2017 +0200
RSVD TUNNEL_SCSI bugfix: SCSI payload is not dissected for request packets
For SCSI packets tunnelled via RSVD, the logic of
SCSI Payload dissection should be:
-For SCSI IN transfer type (DataIn=1), display SCSI Payload of reply packet only.
-For SCSI OUT transfer type (DataOut=0), display SCSI Payload of request packet only.
-For non-data transfer type (DataIn=2) don't display SCSI payload even if
DataBuffer is non-empty.
Minor fix: display RSVD DataBuffer BEFORE SCSI Payload in response packets.
If SCSI dissector failed (malformad packet), binary DataBuffer blob
will be still displayed in SVHDX_TUNNEL_SCSI_RESPONSE subtree.
Bug: 13403
Change-Id: Ia4fec817ae30799b763ae9d96c312fb7771d1618
Reviewed-on: https://code.wireshark.org/review/20089
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=67d8830f2f16cafb0e2fba941d4517…
commit 67d8830f2f16cafb0e2fba941d4517c2f56270df
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Feb 4 17:01:00 2017 +0100
wiretap: add open_routines cleanup function.
Change-Id: Id88fe84189b8baa597eaa69159395cdc4bc56195
Reviewed-on: https://code.wireshark.org/review/19951
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=52637ad6f637c4dbef60cb8ae5aaff…
commit 52637ad6f637c4dbef60cb8ae5aaff40bbc89c40
Author: Masashi Honma <masashi.honma(a)gmail.com>
Date: Sat Jan 28 00:17:58 2017 -0500
Dissector: Add IEEE802.11 mesh awake window dissector
Change-Id: I0275228c3f3e03d817ce886fc949a65426dbc9cf
Signed-off-by: Masashi Honma <masashi.honma(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/19737
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9e1232ee9e7ac3e7a7cb38a099dae6…
commit 9e1232ee9e7ac3e7a7cb38a099dae66a7b425b4e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jan 18 23:15:51 2017 -0500
Convert IEEE802.11 tagged fields into a dissector table
One GIANT switch statement is a little difficult to maintain, so convert each
case into its own function and add them to a dissector table. Many of the
case statements were already their own function, but signatures needed to
be converted into dissector_handle_t
-1 was uses as the protocol for the dissector handles because there isn't
a need to be associated with a protocol. This also allows third-parties
and plugins to add tagged fields outside of Wireshark using the new
dissector table.
Change-Id: I5e4c705dd6a7d99549a27ae684dbde4c47774123
Reviewed-on: https://code.wireshark.org/review/19670
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b59c87f94a0752efcf4a90b3f8c61a…
commit b59c87f94a0752efcf4a90b3f8c61a08bcddde8f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Feb 17 12:20:58 2017 -0800
CMake: Move the search for libgcc_s to GLib.
Move the search for the libgcc_s_seh and _sjlj DLLs to the GLib directory.
That's the only place it currently exists on the 64-bit builder.
Change-Id: Icf55dacf061d9423e78cabeaf16aa539ccb619bb
Reviewed-on: https://code.wireshark.org/review/20162
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=560a6c3823cf560b883e29db0a4035…
commit 560a6c3823cf560b883e29db0a403517def86639
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Feb 16 15:31:56 2017 -0800
Rawshark: Try to avoid a VC runtime crash.
The MSDN documentation for _read says
"If fd is invalid, the file is not open for reading, or the file is
locked, the invalid parameter handler is invoked, as described in
Parameter Validation."
This means that on Windows, if our parent has closed stdin when we call
_read we'll crash. Add a check to bail out early if that's happened.
Fix a sign cast while we're here.
Change-Id: I8afb75f6e56c6a6c2b62103ba7e2fb635dc85702
Reviewed-on: https://code.wireshark.org/review/20153
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=48eff6a36bac1526756bbb42a8c984…
commit 48eff6a36bac1526756bbb42a8c9841641792938
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Wed Oct 19 14:54:02 2016 +0200
Bluetooth: AD: Add dissector for Apple iBeacon
iBeacon is manufacturer specific (Apple) data in advertising packets.
Based on: https://developer.apple.com/ibeacon/Getting-Started-with-iBeacon.pdf
Use DecodeAs on advertise packet using field "BT EIR/AD Manufacturer Company
ID"
then select this dissector "Apple iBeacon".
Change-Id: Ie3e50a391914054f33144d99734cf59fbda9683e
Reviewed-on: https://code.wireshark.org/review/19970
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=16c3ecbd4c903815f4797f4f69daff…
commit 16c3ecbd4c903815f4797f4f69daff98e9cb8807
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Feb 16 16:13:41 2017 +0100
g_slist_free_full requires glib 2.28
Change-Id: I4f9ce7f65da0349b962f6be317635c5acb2daf73
Reviewed-on: https://code.wireshark.org/review/20148
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=14e19128dca1b318896ab7768d4527…
commit 14e19128dca1b318896ab7768d4527723dbefd17
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Feb 16 10:41:58 2017 +0100
Qt: Disable pane menu items if not used in layout
If a pane is not used in the layout it should not be possible to show
and hide this from the menu, as this may give unexpected results.
Change-Id: I335168e66e1dffc89992cad480dd7daaea7e9d59
Reviewed-on: https://code.wireshark.org/review/20140
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=384c26622b0adc7eda415ba6e2a9fc…
commit 384c26622b0adc7eda415ba6e2a9fc704cd27794
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Feb 16 15:08:06 2017 +0100
Qt: Preserve pane sizes when layout content changed
Preserve pane sizes when rearranging layout content in the
preferences dialog.
Change-Id: I2af2a60424a7bf94f1f92e7c63e6a1823985b60d
Reviewed-on: https://code.wireshark.org/review/20145
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=7e9b7b596728e6d1ab1ab5dc01e6a2…
commit 7e9b7b596728e6d1ab1ab5dc01e6a24a3bfafd6b
Author: Hannes Mezger <hannes.mezger(a)ascolab.com>
Date: Thu Feb 16 16:09:59 2017 +0100
opcua: display abort messages correctly
Change-Id: I795fc3a3cf4ca93483f870d229668d7f747bb799
Reviewed-on: https://code.wireshark.org/review/20147
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a5a8fce06ecb5aff1dfcf101bb2b54…
commit a5a8fce06ecb5aff1dfcf101bb2b5455bd776569
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 3 12:14:23 2016 -0700
Qt: Warn the user about DBAR 1.8 on Windows.
At startup, dig through the registry looking for shell extensions. If
any of them match known Dell Backup and Recovery DLL names and the DLL
version matches 1.8.*.*, show the user a warning dialog.
This is a bit extreme but I'm not sure what else to do. Dell is a popular
computer manufacturer and bug reports keep trickling in.
Change-Id: I6d1bd6c56850279356570154d231b07facb30cff
Bug: 12036
Ping-bug: 12701
Ping-bug: 13414
Reviewed-on: https://code.wireshark.org/review/16861
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=815916b174ce48d65aace9852629f6…
commit 815916b174ce48d65aace9852629f63f45e12704
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Feb 16 14:37:01 2017 +0100
[GTPv2] Add dissection of Node Identifier.
Change-Id: Icb2198e4f32ad7e6993bd80c2bf38ed323fb9ba0
Reviewed-on: https://code.wireshark.org/review/20144
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a467f63216a2226eede03491bfda2d…
commit a467f63216a2226eede03491bfda2d2a397659b1
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Mon Feb 13 00:44:21 2017 -0500
packet-nvme-rdma: Present keep alive timeout in decimal.
This patch presents Keep alive time out value in decimal as its ready to
read time in decimal.
Its adds (msec) string as its unit is in millisecond.
Change-Id: Ia7a1fc6e9cdbba86f8dae14d5fbb07a509d6b30f
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/20087
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d33f7b9fb5589169fda6dfb5ac17e9…
commit d33f7b9fb5589169fda6dfb5ac17e951ea06effb
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Feb 16 15:49:10 2017 +0100
[GSM RLCMAC] Use rtlli_vals
Change-Id: I491bdfd3c206971244f26dfc2cfd8172347313c6
Reviewed-on: https://code.wireshark.org/review/20146
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=656da8a49838302852b26d2a828943…
commit 656da8a49838302852b26d2a8289437e42ca9aa9
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Feb 16 13:22:19 2017 +0100
ifdef g_list_free_full it requires glib 2.28
Change-Id: I86292b3d736bb08b21c034bb45f1dcac19196740
Reviewed-on: https://code.wireshark.org/review/20142
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ba643d670b2166279dda57c5c0c0b2…
commit ba643d670b2166279dda57c5c0c0b2fc2e6e37e1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Feb 16 10:59:05 2017 +0100
[GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data messages.
Change-Id: Ia7c74a834d2384642cac7f9a2899313b9bac7c26
Reviewed-on: https://code.wireshark.org/review/20141
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e2cef4cbbd8afe64b446f16443e1e8…
commit e2cef4cbbd8afe64b446f16443e1e80478117327
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Feb 16 10:03:41 2017 +0100
Qt: Improved pane size auto detect
Split panes in exactly equal sizes.
Change-Id: I4b984931e860160791497a299011489aa26ad4ef
Reviewed-on: https://code.wireshark.org/review/20139
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=6efc0f4ea62b22e289fa22e6f1735f…
commit 6efc0f4ea62b22e289fa22e6f1735f2e89302165
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Feb 16 00:29:57 2017 -0800
Updated URL for STANAG 4607 documentation.
Change-Id: Ib25ab0ba5b9d613d55fc54c0f3ef84cb7698754f
Reviewed-on: https://code.wireshark.org/review/20136
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c7042bedbb3b12c5f4e19e59e52da3…
commit c7042bedbb3b12c5f4e19e59e52da370d4ffe62f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Feb 16 00:18:30 2017 -0800
Report an error for too-short packets.
The packet length field gives the length of the *entire* packet, so, by
definition, it must not be zero. Make sure it's at least big enough for
the packet header itself plus one segment header.
Bug: 13416
Change-Id: I625bd5c0ce75ab1200b3becf12fc1c819fefcd63
Reviewed-on: https://code.wireshark.org/review/20133
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bc2b135677110d8065ba1174f09bc7…
commit bc2b135677110d8065ba1174f09bc7f5ba73b9e9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 15 19:10:10 2017 -0500
Add follow "types" by protocol short name, not filter name
This is what the GUI is expecting.
Change-Id: Ia51800fc7df2f978cf727dc326254b28d01ac9a2
Reviewed-on: https://code.wireshark.org/review/20126
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=54c0a6d23bb233af11c980e22ec88a…
commit 54c0a6d23bb233af11c980e22ec88a21c4f005f7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Feb 15 23:27:31 2017 -0800
Cast away some compiler warnings.
Change-Id: Ia8b68a718b6cee77b479594be09542fd7133ebe1
Reviewed-on: https://code.wireshark.org/review/20131
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1077e9afcc72d312e194169c259831…
commit 1077e9afcc72d312e194169c2598319be38b7f29
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Feb 15 22:41:51 2017 -0800
Squelch a compiler warning.
All we care about is whether the bit in question is set or not, so just
test whether (value & BIT) != 0.
Change-Id: I6a1eb6b09a7e64d4da9cf92423a44be17625310f
Reviewed-on: https://code.wireshark.org/review/20129
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=34b983666da4358bc38fd025e3e079…
commit 34b983666da4358bc38fd025e3e0793a81256451
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Feb 15 23:35:19 2017 +0100
Qt: Reset pane sizes when layout type changed
Reset pane sizes when layout type has changed in the preferences
dialog to avoid “random” sizes.
Change-Id: I9ca830572e3d21cb4227de3d5d05449b759aec7e
Reviewed-on: https://code.wireshark.org/review/20122
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a98eb3c3125d0b353f2b571890f585…
commit a98eb3c3125d0b353f2b571890f5854e2b977f42
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Feb 15 21:41:08 2017 +0100
Qt: Auto detect pane size when configured zero
The recent file configuration for pane sizes states that
“pane size of zero will auto detect”, so ensure we do this in
all cases where the settings may be zero.
This affects initial startup, Default profile reset and new profiles.
Change-Id: I1430ec1a83b7fb294b92837476f2bf9472384e45
Reviewed-on: https://code.wireshark.org/review/20121
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=989b9d51883467024d8d3fa546916d…
commit 989b9d51883467024d8d3fa546916d9f6cad5e59
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 15 17:05:49 2017 +0100
ssl: fix misdetection of HelloRequest handshake message
The encrypted "Finished" message was wrongly decoded as two
"HelloRequest" messages due to the presence of GCM nonce.
Bug: 10235
Change-Id: I44f9bb5d927ac0d3c604e4125034cd34981d3943
Reviewed-on: https://code.wireshark.org/review/20119
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d718b1d7e17a230f6c4329aa9b8ea7…
commit d718b1d7e17a230f6c4329aa9b8ea798ea6a48ec
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Feb 15 14:32:45 2017 +0100
Qt: Preserve pane sizes when changing profile
When changing between profiles having certain different layout types
the size of the last pane was calculated wrong.
This involves switching between this layout types:
2 -> 3 2 -> 5 3 -> 1 3 -> 2 3 -> 4 3 -> 5
4 -> 3 4 -> 5 5 -> 2 5 -> 3 5 -> 4 5 -> 6
Change-Id: I6ee3ed92c4c639b720587c0771be0a242e5a8793
Reviewed-on: https://code.wireshark.org/review/20116
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c529e9110a211bc445a94c2ed68acc…
commit c529e9110a211bc445a94c2ed68acc14fe108384
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 15 00:09:48 2017 +0100
TLS: add Signed Certificate Timestamp support (RFC 6962)
Adds support for dissecting the Signed Certificate Timestamp List
in the TLS Hello, X.509v3 Certificate and OCSP Response extensions.
Tested with tls-sct.pcap (TLS extension, OCSP) and x509-sct.pcap (cert).
Bug: 13372
Change-Id: I127dbf5cfe9a8dd9ed13741322273c4841b0f582
Reviewed-on: https://code.wireshark.org/review/20110
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=23d3a3021655f3d70bf5e26aa4d5cd…
commit 23d3a3021655f3d70bf5e26aa4d5cdf471cf1688
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 15 01:52:12 2017 +0100
ssl-utils: refactor DigitallySigned
Refactor DigitallySigned dissection to return the length and make it
accept a version integer instead of Session pointer. Hopefully this
makes it easier to use the routine for SCT dissection in X.509 certs.
While at it, convert it to use ssl_add_vector.
Change-Id: I64afecc65ff597fda50d208d8f96ca0b97bfcbde
Reviewed-on: https://code.wireshark.org/review/20111
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9a22102d352a5f51eb92eaa43cafb8…
commit 9a22102d352a5f51eb92eaa43cafb8f28ad1503b
Author: Diederik de Groot <dkgroot(a)talon.nl>
Date: Mon Feb 13 17:50:53 2017 +0100
[skinny]: Added conversation and request_response handling
Improvements:
- added conversation
- added request/response handling
Change-Id: Ia670eb23c0671b195108876a30ff3ff5eb4a152c
Reviewed-on: https://code.wireshark.org/review/20094
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e6c51e7badca002fadbb9fdcab3e54…
commit e6c51e7badca002fadbb9fdcab3e54c3b2910705
Author: Oliver Downard <oliver.downard(a)couchbase.com>
Date: Wed Feb 1 17:04:56 2017 +0000
Couchbase: Add support for XATTRs
Please see https://issues.couchbase.com/browse/MB-22004
Alters subdoc dissecting to support XATTRs
Accomodates for the addition of the XATTR HELLO flag
Changes SET_WITH_META to support XATTRs
Changes DCP mutation/deletion to support XATTRs
Change-Id: I4ff6e498b96c329d51167daf58a6d85c1f0c77c4
Reviewed-on: https://code.wireshark.org/review/20062
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cd1d90e99435cfd6b1097267d2ae13…
commit cd1d90e99435cfd6b1097267d2ae13ffdaac049c
Author: John Viklund <john.viklund(a)effnet.com>
Date: Mon Feb 13 10:40:33 2017 +0100
ROHC: Basic support for RTP extension 3
Change-Id: Ifcc9d3791c54c484a2ec6f6e566a07e7dfc9fe7e
Reviewed-on: https://code.wireshark.org/review/20088
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=724dc1cf5c7a2eaef10ebb4aec399d…
commit 724dc1cf5c7a2eaef10ebb4aec399d5f06fc4ed3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Feb 15 16:46:42 2017 -0800
"NULL" is not what you use for a null pointer.
It's a non-null pointer to a character string with the value "NULL".
You want just NULL, with no quotes.
Change-Id: I51bfb73a3002f46f13a8f513d07b1ddc009a14cb
Reviewed-on: https://code.wireshark.org/review/20123
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=64f83641ad1ddd8969b08ccb64975d…
commit 64f83641ad1ddd8969b08ccb64975daa582427f5
Author: Mark Phillips <mark.phil(a)samsung.com>
Date: Thu Oct 20 18:50:26 2016 +0100
Cleanup runlex.sh to use builtin POSIX functions instead of sed
Bug: 13412
Change-Id: If43b30a33dcc4f23ba2bcb3cce3d0feea0d9fe40
Reviewed-on: https://code.wireshark.org/review/20120
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0f5948015d96fdb198fb4b26a81040…
commit 0f5948015d96fdb198fb4b26a810404b1225462c
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Feb 15 16:46:05 2017 +0100
ifdef g_list_free_full it requires glib 2.28
Change-Id: I390d602c6caaa5daa2928dcd37f5f476195a685f
Reviewed-on: https://code.wireshark.org/review/20118
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0b8a12fd51c3d9fde677b42bc37db4…
commit 0b8a12fd51c3d9fde677b42bc37db49e61669abd
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Feb 15 14:01:23 2017 +0100
Windows: update GnuTLS to 3.4.11 and Libgcrypt to 1.7.6
Also switch some third party libraries to stripped version to reduce size
Change-Id: If0fd06a85fb17fb3e35543bcc714c8a8a1ce20c6
Reviewed-on: https://code.wireshark.org/review/20117
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a691315652b3bc805d9d358fad60ac…
commit a691315652b3bc805d9d358fad60ac975ea9f051
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 14 19:09:31 2017 +0100
TLS13: handle message-specific TLS extensions
Some extensions from the client are processed differently than those
sent by the server. In TLS 1.3 the Encrypted Extensions section took
over most of the Server Hello extensions and some appear in Certificate.
Based on https://tlswg.github.io/tls13-spec/#rfc.section.4.2
Change-Id: I40d98bae21fe7933563df4a79b0cec4bf02a76f8
Reviewed-on: https://code.wireshark.org/review/20109
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=3e7f32e328e8c9ad06f80551f1dffb…
commit 3e7f32e328e8c9ad06f80551f1dffb0c8e7b8844
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 14 18:42:41 2017 +0100
ssl-utils: sort extensions cases
Sort cases to match the extension numbers. No functional change.
Change-Id: I648ecce9037511cc19721e81b434645d61560dd2
Reviewed-on: https://code.wireshark.org/review/20108
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=e207506cabe1f66b7192588c9431b9…
commit e207506cabe1f66b7192588c9431b91c33a357ff
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 14 13:32:00 2017 +0100
TLS13: dissect NewSessionTicket and CertificateRequest extensions
Process NewSessionTicket and CertificateRequest extensions for TLS 1.3.
CertificateExtension in draft -18 is replaced by Extension in the next
draft, so anticipate for that and start decoding this extensions vector.
Rename ssl_dissect_hnd_hello_ext to reflect extended functionality.
(Certificate Extensions SCT is still not dissected though, but at least
OCSP (status_request(_v2)) is supported now.)
Change-Id: I3cae58dbde600e82598b3c2f8e29e92e38cd1db1
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20104
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bb1450b017226b0da892c7c3ebba0f…
commit bb1450b017226b0da892c7c3ebba0fe1621e38d9
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 14 11:18:24 2017 +0100
ssl,dtls: fix wrong expert info for overly large records
The plaintext length is limited to 2^14, but the actual record length
(TLSCiphertext) may be larger due to expansion from compression and the
cipher (like AEAD auth tags). The wrong check led to false expert infos.
Change-Id: I3a56f1b0af05ecc1d97c4f1f0bcf35ff4d0fad42
Fixes: v2.3.0rc0-1584-gff0371e898 ("ssl,dtls: add expert info for overly large
record lengths")
Reviewed-on: https://code.wireshark.org/review/20099
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=efcb5c07f04210ee89e57347c867a6…
commit efcb5c07f04210ee89e57347c867a64d3486ebc4
Author: John Viklund <john.viklund(a)effnet.com>
Date: Wed Feb 15 07:49:08 2017 +0100
Display 4 octets SDVL with 3 bits in ROHC
Four octets self-describing variable-length in ROHC has three bits
discriminator, not four as previously displayed.
Change-Id: Ibe366aed3ac822abd0046efe71e9b4e4c633524f
Reviewed-on: https://code.wireshark.org/review/20112
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=78ce70e908ff4609587b6a0179ee0e…
commit 78ce70e908ff4609587b6a0179ee0e8ae5e29421
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 14 22:36:52 2017 +0100
Qt: Indicate profile created from system provided
Indicate when a profile is created from a system provided profile.
Change-Id: Iaabe5a2dbf17c7baa14e888dfab5f2aeadaedb67
Reviewed-on: https://code.wireshark.org/review/20107
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=6f18fed9abfecc65044219b0a11622…
commit 6f18fed9abfecc65044219b0a11622c4115c5ef2
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Feb 14 18:41:25 2017 +0100
wiretap: fix wtap_opttypes_cleanup() function
Change-Id: I475e2bc54af470e380e23e5dd98198885e189d6f
Reviewed-on: https://code.wireshark.org/review/20106
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c01cdd4e47687bf6be505f989ff5e5…
commit c01cdd4e47687bf6be505f989ff5e5b54b089ac4
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Feb 13 23:00:00 2017 +0100
Qt: Reset Default profile support
Add support for resetting the Default profile by deleting it in
the Profile Dialog. All profile files will be deleted and all
other files will be kept.
Change-Id: I795a6db3ee7b2c29e7aba461183e6cc411798b75
Reviewed-on: https://code.wireshark.org/review/20097
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=fe78e1302f6076291e7270de2e8443…
commit fe78e1302f6076291e7270de2e8443ddb2c082af
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Feb 14 18:04:02 2017 +0100
BT LE LL: fix invalid memory access reported by valgrind
- broadcast_addr shoudl be static and not on call stack
- set the AT_STRINGZ address length with the string length and not the buffer length
Bug: 13381
Change-Id: I86e15ccaa9b5d7779c266ab24b637476e983664c
Reviewed-on: https://code.wireshark.org/review/20103
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bc29b8c9b616840af5322639f9ccc2…
commit bc29b8c9b616840af5322639f9ccc24bfb865844
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Feb 14 18:22:57 2017 +0100
androiddump: fix compilation with ANDROIDDUMP_USE_LIBPCAP define
Change-Id: I6edc4ff9f4db5fab9b80cb0be56639443ab22518
Reviewed-on: https://code.wireshark.org/review/20105
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0ed10658cf527bfaac51fe3dd70a3d…
commit 0ed10658cf527bfaac51fe3dd70a3dd81ae48dc8
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Feb 14 13:36:07 2017 +0100
rawshark: add initializer.
Change-Id: I696b1cfd7cf226d07918cca708a3463db3114333
Reviewed-on: https://code.wireshark.org/review/20100
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=319de13b89c0445dcb7d444c26fb16…
commit 319de13b89c0445dcb7d444c26fb16e13cdb5aa1
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Sun Feb 12 22:03:24 2017 +0200
Handle NSAP IPv4 addresses in NBAP's TransportLayerAddress field which aren't
padded to 20 bytes (= max NSAP address length, expected by NSAP dissector).
Bug: 13399
Change-Id: Ife0b3bbaf851e821dbfde15610eee69e9e7a6e62
Reviewed-on: https://code.wireshark.org/review/20069
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=415580b060541217798b272faf53aa…
commit 415580b060541217798b272faf53aaaf4f483df8
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Feb 4 16:37:08 2017 +0100
tshark: free capture file filename on exit.
Change-Id: I561bc7b46ad8582013d3897ae19801d2fc5a7f49
Reviewed-on: https://code.wireshark.org/review/19950
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4b423c5fb1fdc6a329dc74f0f8a192…
commit 4b423c5fb1fdc6a329dc74f0f8a1920e13c5f933
Author: Jan Spevak <jan.spevak(a)nokia.com>
Date: Fri Feb 3 14:52:08 2017 +0100
gtp: changed display format of a FQDN from BYTES to STRING
as suggested on https://code.wireshark.org/review/#/c/19930/
Change-Id: Ia340b733fb87b3e139b165ff701ff0ba25c1cf44
Reviewed-on: https://code.wireshark.org/review/19931
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7c0c580c4b0093437ee81e11934ef5…
commit 7c0c580c4b0093437ee81e11934ef5b8d27a5bb4
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Feb 4 16:26:34 2017 +0100
wiretap: add cleanup routine.
The cleanup routine has been added to exit section of the applications.
Those which required a exit restyle have been patched as well.
Change-Id: I3a8787f0718ac7fef00dc58176869c7510fda7b1
Reviewed-on: https://code.wireshark.org/review/19949
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ae0bdcc78c6cb2719e7aa5ae24e805…
commit ae0bdcc78c6cb2719e7aa5ae24e80584dec488a3
Author: AndersBroman <a.broman(a)bredband.net>
Date: Mon Feb 13 22:36:45 2017 +0100
[Diameter AVPs] Add 3GPP AVP 1664 to 1680 from TS 29.272
Change-Id: Iccc98e4bb6f7923c9ed0720d6fc469f5c3f74d39
Reviewed-on: https://code.wireshark.org/review/20096
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=993e0989f9abcaafb073cb0ae005de…
commit 993e0989f9abcaafb073cb0ae005de9bda475452
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Thu Feb 2 19:25:10 2017 +0100
Change Qt setup from 5.5.0 to 5.8.0
Change-Id: Ic98922a9e3bf784487512c28921eb5c7d9914e53
Reviewed-on: https://code.wireshark.org/review/19962
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=6b84ddee83e70aff944da084129624…
commit 6b84ddee83e70aff944da084129624226b7a32fa
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Feb 9 15:00:19 2017 +0100
Make Libgcrypt a mandatory dependency
Removed all guards for HAVE_LIBGCRYPT, change autotools and CMake to
error out if it is not available. Update release notes, developer
documentation and README with the new status. Clarify relation with
GnuTLS in macosx-setup.sh. Install Libgcrypt via brew script.
Motivation for this change is that many dissectors depend on Libgcrypt
and having it optional increases the maintenance burden (there have been
several compile issues in the past due to the optional status).
Furthermore, wsutil has crypto code that can be replaced by Libgcrypt.
Change-Id: Idf0021b8c4cd5db70b8766f7dcc2a8b3acbf042f
Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html
Reviewed-on: https://code.wireshark.org/review/20030
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=b5610a0436f332c664a91b86cb5326…
commit b5610a0436f332c664a91b86cb5326f24601bbf1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Feb 13 15:25:43 2017 +0100
[ISAKMP] Dissect 3GPP private error and status messages in NOTIFY.
Change-Id: Iaa65c1cf9f358e36e77b4a5cad2543dcbb98072e
Reviewed-on: https://code.wireshark.org/review/20090
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=119bf86366000e2836216b3ae3faee…
commit 119bf86366000e2836216b3ae3faeea4fa8299ea
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 13 17:27:10 2017 +0100
tools: add suppressions to valgrind.
Remove leaks from libgcrypt.
Change-Id: I920e504cfcb45c41510f3edc65d2dbeefda5c5a1
Reviewed-on: https://code.wireshark.org/review/20093
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=940c758ef66fcfc9a7a225d1c4cb89…
commit 940c758ef66fcfc9a7a225d1c4cb896a9212a434
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 19:33:35 2017 -0800
Further explanation in comments.
Change-Id: If88220dc39b2a6baeeefc244639992271b7f0464
Reviewed-on: https://code.wireshark.org/review/20086
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b0090953ca981cb7358faea86a0fe4…
commit b0090953ca981cb7358faea86a0fe444b3664c17
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 19:30:17 2017 -0800
Fix a comment to reflect (and better explain) reality.
Change-Id: I4d87438046c18419cea775c547c49cd3abb2089e
Reviewed-on: https://code.wireshark.org/review/20085
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ece6e7c1a4c2305ece68264810765d…
commit ece6e7c1a4c2305ece68264810765d4e54ff9f49
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Feb 12 22:59:32 2017 +0100
Fix compilation without plugins.
proto.c:667:6: error: ‘dissector_plugins’ undeclared (first use in this function)
tap.c:773:20: error: ‘tap_plugins’ undeclared (first use in this function)
Change-Id: I8feaec4219dc97202bdb79d72399c5fd1d383e27
Reviewed-on: https://code.wireshark.org/review/20081
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=ad2eb833c8f646c7bd8000dec30350…
commit ad2eb833c8f646c7bd8000dec30350f2fe743a33
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 10:58:57 2017 -0800
Set the partial AID in the radio metadata structure.
Change-Id: I2d5a1cd7d264e8df7f4520272d6310e49cf8126d
Reviewed-on: https://code.wireshark.org/review/20080
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8bc29d187dfd4f3bcdef12489f3775…
commit 8bc29d187dfd4f3bcdef12489f3775c9fe20deb1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Feb 12 17:34:45 2017 +0100
sharkd: fix a memory leak on Windows introduced in gfe06aad
Change-Id: I907dbc924574b02d2f1b8d7668158b5b6d2c87cf
Reviewed-on: https://code.wireshark.org/review/20073
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc3b7722cd05bf7d77d24411682792…
commit dc3b7722cd05bf7d77d244116827925dc417212f
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Sat Feb 11 15:55:05 2017 +0100
tshark removed empty line in -T ek output
Change-Id: Id4c1ab258308ecc8421a5c82b6e937a9d35bf58e
Reviewed-on: https://code.wireshark.org/review/20061
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6322f9ce613032ed590aa2175f8685…
commit 6322f9ce613032ed590aa2175f86851bd3fd06b6
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 12 17:21:24 2017 +0100
uat: add missing parameter to documentation.
Change-Id: Ic39b00e0800c123083a6583d78eb96154b93e49f
Reviewed-on: https://code.wireshark.org/review/20075
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea0a7f211ce5d503de6a46502f98c8…
commit ea0a7f211ce5d503de6a46502f98c80cec205d7e
Author: Diederik de Groot <dkgroot(a)talon.nl>
Date: Sat Feb 11 13:41:58 2017 +0100
[skinny]: Add struct/union guards to multi-part message handlers
Improve multi-part message handling
- Calculate (sub) structure/union length
- Add a guard when iterating over multi-part message
- For fixed length messages, advance the cursor when iteration falls short of max
length
Change-Id: Id2af3aa1a878328f105e173cabe2b68dd0343507
Reviewed-on: https://code.wireshark.org/review/20057
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fb3a7caa1746e4e33b21a90cce5921…
commit fb3a7caa1746e4e33b21a90cce5921ded621a0b9
Author: Diederik de Groot <dkgroot(a)talon.nl>
Date: Sat Feb 11 13:41:58 2017 +0100
[skinny] Fix ConnectionStatRes and DialedNumber Messages protocol version >20
- ConnectionStatisticsResponse Comes in three different forms
- DialedNumber Message has variable length
Minor:
- Pass ipv4or6 connection address back to calling function (using this later on in
seperate commit)
- Correct spelling mistakes
- Remove duplicates from DeviceType[]
Change-Id: Ib1619b163c12b6a4c6c86972186d828be3fd94e2
Reviewed-on: https://code.wireshark.org/review/20056
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6550b104226ab9625345dcc395bd54…
commit 6550b104226ab9625345dcc395bd54ff3055cd66
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Feb 12 08:12:26 2017 -0800
[Automatic update for 2017-02-12]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I84ecfdd35a8f2935f950f72c01a69b70a6a80c07
Reviewed-on: https://code.wireshark.org/review/20070
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1e1ceeb7636fb50a3f35f6933407e4…
commit 1e1ceeb7636fb50a3f35f6933407e4f32a118bb8
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sun Feb 12 12:32:10 2017 +0100
Put the definitions first
To help compilers that don't like mixed definitions, put the definitions
first.
Bug: 13398
Change-Id: I7f011feef7c7574df7a03cec87693e664be559ca
Reviewed-on: https://code.wireshark.org/review/20067
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6bbbc3456b132a8ba62202b988bf9a…
commit 6bbbc3456b132a8ba62202b988bf9abb1d923d0f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 02:03:13 2017 -0800
Fill in pseudo-header fields in order, and add the group ID for 11ac.
Change-Id: I0011917b77b1adc0cb6effd5d9d902f541675d78
Reviewed-on: https://code.wireshark.org/review/20066
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6a3762576b88e5ecbd1ce1019d40b9…
commit 6a3762576b88e5ecbd1ce1019d40b96c6dd1da1d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 01:50:28 2017 -0800
Add a comment about wired-to-little-endian fields.
Other fields in the Prism header are in the same byte order as the magic
number; if the host generating those fields is big-endian, are these
fields little-endian or big-endian?
Change-Id: Ieb857db3ea63a673d9224cb2a7be3ff2bfb5861c
Reviewed-on: https://code.wireshark.org/review/20065
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e2c92fa99ea7b8d94b347d62316b22…
commit e2c92fa99ea7b8d94b347d62316b22f7df83b924
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 01:46:09 2017 -0800
White space/style cleanup and consistency.
Go with 4-space indentation.
Also, get rid of some unnecessary brackets.
Change-Id: I07b4f126ba58ef3d013db7741d91484ae32e60d7
Reviewed-on: https://code.wireshark.org/review/20064
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=386a286d7dfa3ed59ae5a3e753d696…
commit 386a286d7dfa3ed59ae5a3e753d69629e02f0313
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Feb 12 01:32:41 2017 -0800
signal() is defined on some UN*Xes; don't use it as a variable name.
Change-Id: Iec68f35eefdc3ce17112c04477eae99e5aa58eb8
Reviewed-on: https://code.wireshark.org/review/20063
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4125aa14c3722129015ddcf7b3f9bb…
commit 4125aa14c3722129015ddcf7b3f9bb5f485032d4
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Thu Sep 15 15:46:06 2016 -0700
Decode QCA sniffer PRISM extensions, and populate some wlan_radio
fields.
Patch received from QCA, and fixed up to build on master and pass
some fields on to wlan_radio.
Bug: 12978
Change-Id: I65ba7d07fbd76e98bb13399e46b400109387764c
Reviewed-on: https://code.wireshark.org/review/17720
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b8ead953758304c638e2cc8c671a8c…
commit b8ead953758304c638e2cc8c671a8ce3ebf144de
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Sat Feb 11 15:40:24 2017 +0100
tshark print_indent function
Modified epan/print.c to use function print_indent
Change-Id: Iefcb1e3c7813919c6af70d57a4f8a6f921595360
Reviewed-on: https://code.wireshark.org/review/20060
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a2b48ad1203bb5fd102029666f6594…
commit a2b48ad1203bb5fd102029666f65941aa212dc6e
Author: S. Shapira <sswsdev(a)gmail.com>
Date: Fri Feb 10 16:42:38 2017 +0200
Fixing the MAC tvb creation in FP's tb dissection method
Bug: 13392
Change-Id: I387a6715164180487606ba3e9e4aaf64695aa543
Reviewed-on: https://code.wireshark.org/review/20050
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6cc7a7031d039facf4e3d39a322589…
commit 6cc7a7031d039facf4e3d39a322589ec39807424
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Feb 11 12:02:40 2017 +0100
TLS13: handle Key Update for decryption
Generate new key upon receipt of Key Update message. Untested.
Note that the "traffic_secret" field in SslDecryptSession was unused and
since the client and server have two different encryption states, store
the application traffic secret in SslDecoder.
Change-Id: Iefca3f6cb75745a996fecb0fe7769c876dc9c4ee
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/20013
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=eb1a63f3bcd30e8e844f2a72ac9c3e…
commit eb1a63f3bcd30e8e844f2a72ac9c3e7a82871638
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 8 02:04:18 2017 +0100
TLS13: add Key Update dissection
Actual decryption support will be added later.
Ping-Bug: 12779
Change-Id: I3ff1f243fd0bd1467e84d8a6a5433c1fe71bbebf
Reviewed-on: https://code.wireshark.org/review/20012
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=746bbe7abf4bad74b78db0282d8962…
commit 746bbe7abf4bad74b78db0282d8962eb891eb502
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 22:45:55 2017 +0100
ssl-utils: add length validation for Certificate handshake message
This also introduces a new macro, "G_MAXUINT24" as symbol for 2^24-1
(this name does not exist in GLib and uncommon in Google).
Change-Id: If000f41f6286161e3a7697357fc33ae16c1e11db
Reviewed-on: https://code.wireshark.org/review/20003
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=b659c76c320de2d66c369f88d400a9…
commit b659c76c320de2d66c369f88d400a98aeb56d2d7
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 8 00:48:28 2017 +0100
TLS13: fix length of Finished message
Select the full message instead of just the first 12 bytes (as was the
case in previous TLS versions. No check is added since it is too much
work for little gain (it would require looking up the hash length for
the cipher suite).
Change-Id: Iea13d5abe6a7e55b04fabacfa8919a02acd8517d
Reviewed-on: https://code.wireshark.org/review/20011
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=813625883c109cd0fce3257872faa4…
commit 813625883c109cd0fce3257872faa4a87dcfae55
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 8 00:38:52 2017 +0100
ssl-utils: add length validation to CertificateRequest
Add length validation to several fields in CertificateRequest. Clarify
specification, remove unnecessary length check and add TODO for TLS 1.3.
Change-Id: Ic3aca62d90e5fad6930beb371adf10d7b7b9fbe2
Reviewed-on: https://code.wireshark.org/review/20010
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=0e0851891559c3aebc35f31c4ba199…
commit 0e0851891559c3aebc35f31c4ba199cfecdbe7e1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 8 00:01:13 2017 +0100
TLS13: add length validation for Pre-Shared Key Exchange Modes
Add length validation for expert info and add a reference.
Change-Id: Id21916b11ca924b517ea45294798692a010e7541
Reviewed-on: https://code.wireshark.org/review/20009
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=738f4b72cc7fc0d08f7d55a039bb29…
commit 738f4b72cc7fc0d08f7d55a039bb29ae061ac3db
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 23:55:32 2017 +0100
TLS13: add length validation for Pre-Shared Key Extension
Use "ssl_add_vector" for length validation and expert info.
Change-Id: Ib38d36dfd82b78580035415d0924f1fae6cbe96d
Reviewed-on: https://code.wireshark.org/review/20008
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=b29582966e46a12c4db9d060c84277…
commit b29582966e46a12c4db9d060c842776c8c609bc6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 23:35:29 2017 +0100
ssl-utils: update supported_groups extension
Update references, rename the old "elliptic_curves" name to
"supported_groups". Fix a wrong field name (EC Point Format now has its
own hf). Add length validation for "elliptic_curve_list".
Change-Id: I554ebb259ba7561b48dfe1cc9162a0b3b3bcdba4
Reviewed-on: https://code.wireshark.org/review/20007
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=a77b69092901e4ae882f8ea72058ab…
commit a77b69092901e4ae882f8ea72058abfd6c5b1223
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 21:41:23 2017 +0100
TLS13: add length validation for SupportedVersions
Also add reference to specification.
Change-Id: I5619ce175711f6768949f8b7eec789320100573c
Reviewed-on: https://code.wireshark.org/review/20002
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=efed7b5ab6bb0f3a6ca8a2368964df…
commit efed7b5ab6bb0f3a6ca8a2368964df3a3917ee85
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 21:39:08 2017 +0100
ssl-utils: stylistic changes for ServerHello, HelloRetryRequest
Change "length" to "offset_end" parameter for consistency.
Clarify
applicable TLS version in comments. Remove unnecessary check for length.
Change-Id: Icdc7edff9c8fdaf4c7d7349f65fed42f5344f2c3
Reviewed-on: https://code.wireshark.org/review/20001
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d13da6c408bd3b8fe908bc90ea2b60…
commit d13da6c408bd3b8fe908bc90ea2b60f6059c388d
Author: Jan Spevak <jan.spevak(a)nokia.com>
Date: Fri Feb 3 11:07:12 2017 +0100
diameter_3gpp: added decoding of TWAN-Identifier AVP
Change-Id: Ib3adec4f7abbdd0313e0017f540044ac45a8883a
Reviewed-on: https://code.wireshark.org/review/19930
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0bf7ba3de5a3d3b9de81506820dc33…
commit 0bf7ba3de5a3d3b9de81506820dc3301cb96be0f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Feb 9 20:17:33 2017 +0100
wmem_list: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ibbbe9fb0165eaa297c2b70bf7e478cf538e2cc33
Reviewed-on: https://code.wireshark.org/review/20040
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9ced31a2d7a78e22454aba5fa1a0f2…
commit 9ced31a2d7a78e22454aba5fa1a0f2655e2a57cf
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:15:56 2017 +0100
filter_list: add cleanup function and call it on exit.
Change-Id: I51d8074cc5a63d4fd3af8852df120d6b4163217f
Reviewed-on: https://code.wireshark.org/review/19942
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=59fc668845e57cf988226c3c19984c…
commit 59fc668845e57cf988226c3c19984c8bd83458d3
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 22:41:31 2017 +0100
Clean columns on exit.
Change-Id: I950295c35fc67193d9825ebc741da151ad99e077
Reviewed-on: https://code.wireshark.org/review/19941
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b54c43801112711dcba341f3eb4701…
commit b54c43801112711dcba341f3eb4701678a0e1916
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Feb 9 12:28:14 2017 -0500
Convert conversation hash tables to use wmem.
Simplifies cleanup because wmem can handle the memory cleanup.
Change-Id: Idc6a9bfe5f23c83b59a5278a64b9fb706862342d
Reviewed-on: https://code.wireshark.org/review/20042
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8bbf0341e13b28f76a2e0d9c31bc09…
commit 8bbf0341e13b28f76a2e0d9c31bc0912aba36327
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Feb 10 08:09:38 2017 +0100
service_response_time_table (GTK) fix parameter 'data' not found in the
function declaration [-Wdocumentation]
Change-Id: I6079399be6a94d3b718b31c6a21076d092adf580
Reviewed-on: https://code.wireshark.org/review/20049
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=424fef1a57549f404a8f6f59da2be2…
commit 424fef1a57549f404a8f6f59da2be22e3908bf11
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Feb 10 08:05:47 2017 +0100
response_time_delay_dialog (Qt): Fix warning: parameter 'user_data/data' not
found in the function declaration [-Wdocumentation]
Change-Id: I592b35a3ceec477a8269f5cda0c5c363681a36aa
Reviewed-on: https://code.wireshark.org/review/20048
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=5c7cc28a6c3974d65bf2cb2066f072…
commit 5c7cc28a6c3974d65bf2cb2066f072778a992010
Author: Noel Power <noel.power(a)suse.com>
Date: Thu Feb 2 15:59:22 2017 +0000
mswsp: Align parse_CAggregSpec function with MS-WSP specification.
Fix some errors in the parsing of the CAggregSpec structure, see
2.2.1.24 in the MS-WSP specification.
Change-Id: Ib281c10ab897e5c0282aa1b0d304df97a2fd14a3
Signed-off-by: Noel Power <noel.power(a)suse.com>
Reviewed-on: https://code.wireshark.org/review/20036
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b18245a60c5dc3532d144699dd00f3…
commit b18245a60c5dc3532d144699dd00f36d84c4e176
Author: Noel Power <noel.power(a)suse.com>
Date: Thu Jan 12 05:52:23 2017 -0500
mswsp: Numerous bugfixes
1. Fix display of CTableColumn.StatusUsed & CTableColumn.LengthUsed
Both StatusUsed and LenghtUsed members were displayed as 2 byte length
values instead of single byte values.
2. Fix minor spelling mistake
3. display correct address(s) for array of address values
4. Use correct minimum CTableColumn size
This is followup patch for patch already provided for bug 13299.
The previous minimum value neglated to take into account the
CFullPropSpec structure (which is on the wire) but is represtented
as a string in the internal CTableColumn structure. Note: this doesn't
make any difference to the effectiveness of the previous patch but should
avoid confusion if someone later actually investigates the correct minimum
size.
5. Fix CPMCREATEQUERY message parsing
Following a query and subsequent clarification from dochelp(a)microsoft.com
the MS-WSP specification document was found to be incorrect.
CPMCreateQueryIn
|
---> CSortSet
should instead eventually point to CSortSet via the following msg structure
CPMCreateQueryIn
|
---> CInGroupSortAggregSets
|
---> CInGroupSortAggregSet
|
---> CSortSet
Change-Id: I7da6c7db817113f5542f25f078626030ad30d737
Signed-off-by: Noel Power <noel.power(a)suse.com>
Reviewed-on: https://code.wireshark.org/review/20031
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e0fafa54758c8d0e19df39728df079…
commit e0fafa54758c8d0e19df39728df0792d512c068c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 8 19:32:13 2017 -0500
Convert conversation data_list from GSList to wmem_tree.
Change-Id: I7eac4b4da86d1ac1ce8753f424b698a9949df00b
Reviewed-on: https://code.wireshark.org/review/20041
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f8b69fb349986dce4ae77da9455cd1…
commit f8b69fb349986dce4ae77da9455cd12ba804797d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Feb 9 12:25:43 2017 -0500
Add wmem_map_get_keys.
Mimic functionality of g_hash_table_get_keys
Change-Id: I7702854ed771a5b3bf7ea5295a67c42f0f477cdf
Reviewed-on: https://code.wireshark.org/review/20039
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e3128d98060017bd08ec6bcb17290c…
commit e3128d98060017bd08ec6bcb17290c7ffa7784ed
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Feb 9 10:14:46 2017 -0500
Add wmem_map_steal
Mimic functionality of g_hash_table_steal
Change-Id: Iaf4aeef951b60934569143b2d119f782aeefe380
Reviewed-on: https://code.wireshark.org/review/20038
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cd3855225935c13e8db71ca73688aa…
commit cd3855225935c13e8db71ca73688aadd6445a710
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 8 19:28:25 2017 -0500
Add wmem_tree_remove32
Change-Id: Ic79fd0a2a13341dd7ba563cf3a056c51e9d16960
Reviewed-on: https://code.wireshark.org/review/20037
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6d9f7fb303f090f1809c7f6971d72…
commit f6d9f7fb303f090f1809c7f6971d72f31e3a8d8e
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Feb 9 09:48:04 2017 +0100
dof: free more memory on shutdown.
Change-Id: Ic4604cc2f999f4e669af00e37dad9b60cb06e599
Reviewed-on: https://code.wireshark.org/review/19977
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d03b6c09dae861d3349fded9cc7bc1…
commit d03b6c09dae861d3349fded9cc7bc1647da79da6
Author: Günther Deschner <gd(a)samba.org>
Date: Tue Feb 7 16:25:38 2017 +0100
dissectors: update list of controls in CTDB dissector.
Note that although some of the controls have been removed from the
protocol in upstream CTDB versions they are still present here in order
to dissect older protocol variants.
Guenther
Signed-off-by: Guenther Deschner <gd(a)samba.org>
Change-Id: I67d8f69a7e920f4b1eeed21caab4d2b0b104d669
Reviewed-on: https://code.wireshark.org/review/20023
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=80e8f7dd801a1240635231bf4237ed…
commit 80e8f7dd801a1240635231bf4237ed5752a537f9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 8 22:31:11 2017 -0500
Add wtap_init to dftest.
Bug: 13387
Change-Id: I7dfae550f814cdc15924357996e2086eea58ecf4
Reviewed-on: https://code.wireshark.org/review/20026
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=520a1b20660f6ce071d8b4e535f12c…
commit 520a1b20660f6ce071d8b4e535f12c93a5699d6f
Author: Jim Young <jyoung(a)gsu.edu>
Date: Mon Jan 30 02:45:15 2017 -0500
Make the capture file's interface description filterable
This patch introduces the frame.interface_description field.
While testing this new functionality it became obvious that we have
a non-optimal interaction between the existing cfile.c's
cap_file_get_interface_name(), the recently added frame.interface_name
field and this new frame.interface_description field.
The string returned from cap_file_get_interface_name() may in fact
come from one of three different sources: the idb's interface name
(if it exists) or the idb's interface description (if that exists)
or a default text of "unknown". The string ultimately becomes the
rame.interface_name whether or not the idb had an interface name
option to begin with. This behavior does not allow one to test for
the simple presence of frame.interface_name. The new peer function
cap_file_get_interface_description() added by this patch returns
NULL instead of "unknown" if the idb does not have an interface
description. Should cap_file_get_interface_name() be similarly
modified to return NULL if the idb does not have an interface name?
Bug: 9781
Change-Id: Ie479f373c5080c004dd22bd88919838feca71e95
Reviewed-on: https://code.wireshark.org/review/19861
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9e2366a2e505791a5dde59f5563aaa…
commit 9e2366a2e505791a5dde59f5563aaad68af71885
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 8 16:42:05 2017 -0500
Don't duplicate memory for key values when passing into wmem_tree_insert_string.
Change-Id: Ib9d8f23faa7a9f83a975396a1be8f85078223feb
Reviewed-on: https://code.wireshark.org/review/20024
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b28b07379fe966f0a89ead9fe2fa30…
commit b28b07379fe966f0a89ead9fe2fa30ac05e19e9c
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Feb 7 23:35:50 2017 +0100
editcap: handle too short frames in frame comparison
With option -I one can ignore the first number of bytes from the frame
while doing duplicate frame removal. This doesn't handle shorter frames
correctly. Add safeguards for this, and update the help text.
Bug: 13378
Change-Id: Ia6b65d0797f4069f0b89fa134114d88d80988211
Reviewed-on: https://code.wireshark.org/review/20004
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=edf5ae3fba16c8ed761ec5a55095e5…
commit edf5ae3fba16c8ed761ec5a55095e59fe96c7647
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 8 16:15:18 2017 +0100
proto: destroy list on cleanup.
Change-Id: Icc46f1078cda4597f5a70760c96b866659092006
Reviewed-on: https://code.wireshark.org/review/20022
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2e0ea97a819148dcafece244941975…
commit 2e0ea97a819148dcafece2449419756f8d7eea1f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 8 15:58:47 2017 +0100
tap: destroy list on cleanup.
Change-Id: I24ab3d07721d338edf910b9fa8864306cbfe9dfa
Reviewed-on: https://code.wireshark.org/review/20021
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=19ba947d9abbd372c98dc1339e045e…
commit 19ba947d9abbd372c98dc1339e045e30c0a4d72f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Jan 22 21:36:39 2017 +0100
dof: add shutdown routine.
Change-Id: I91bc792302f61fd8f20fa41ec067534316e26074
Reviewed-on: https://code.wireshark.org/review/19742
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=523c09f31f59f074b1e727a32951cd…
commit 523c09f31f59f074b1e727a32951cd65a83d9ada
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 5 22:28:26 2017 +0100
addr_resolv: remove leak.
Change-Id: If4676b2982efae593084dbe951d8e0bb97189917
Reviewed-on: https://code.wireshark.org/review/19966
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bfe07161a5db3db7c71ecc3a8c55a7…
commit bfe07161a5db3db7c71ecc3a8c55a791e830e107
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:06:35 2017 +0100
sharkd: make the way it returns more similar to other apps.
The clean_exit block allows deallocation of memory on exit.
Change-Id: I52078f0e4e851b6aa5f34cbbd15eba0a4f37cae0
Reviewed-on: https://code.wireshark.org/review/19940
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=70381f774c1f8b272b18f9a5403a02…
commit 70381f774c1f8b272b18f9a5403a02e6bb05125d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 23:07:27 2017 -0500
Switch stat tap to use wmem_tree_t instead of (sorted) GSList.
Change-Id: I172167eb20793113562b69d1e0e93a4882200404
Reviewed-on: https://code.wireshark.org/review/20019
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c5483f4213ea5fa7709e529d993487…
commit c5483f4213ea5fa7709e529d99348734bbfe5daf
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 21:51:43 2017 -0500
Switch follow (tables) to use wmem_tree_t instead of (sorted) GSList.
Change-Id: Iabf354d2533ae429c002b115c5de33b592019997
Reviewed-on: https://code.wireshark.org/review/20018
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=89dfa6bdf4051bc0f7ae64925814d8…
commit 89dfa6bdf4051bc0f7ae64925814d811a37c628a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 20:18:33 2017 -0500
Switch rtd and srt tables to use wmem_tree_t instead of (sorted) GSList.
Change-Id: I54fec10801eb8f359414f34bf705767964c9725e
Reviewed-on: https://code.wireshark.org/review/20017
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=243c09fa06bf7646b577e2baf02410…
commit 243c09fa06bf7646b577e2baf024106432ec1bd9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Feb 7 19:44:19 2017 -0500
Switch export objects to use wmem_tree_t instead of (sorted) GSList.
Change-Id: Iaaa7b44954337c7857dbb541b727924e2de57c9d
Reviewed-on: https://code.wireshark.org/review/20016
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=64a00dc0a81f13d033cc1e7f532a99…
commit 64a00dc0a81f13d033cc1e7f532a99cdda14cca8
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:23:42 2017 +0100
xml: replace g_strdup with wmem_strdup.
Change-Id: Ib16bd79e117cbb54d1a8d98e79924b6bb20703a8
Reviewed-on: https://code.wireshark.org/review/19943
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=db5c8e1ae185730cb83d2175841e4a…
commit db5c8e1ae185730cb83d2175841e4a5314b04c32
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Feb 6 16:51:57 2017 +0100
wmem_list: add wmem_list_insert_sorted.
This mimics the function g_list_insert_sorted.
Change-Id: I6f7ac01155588006662c8c0c138d88cea753868c
Reviewed-on: https://code.wireshark.org/review/19978
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=40fe50fbed4a16b29aaafd2e46712e…
commit 40fe50fbed4a16b29aaafd2e46712e657d3baabd
Author: Volodymyr Khomenko <Khomenko.Volodymyr(a)gmail.com>
Date: Mon Feb 6 19:15:09 2017 +0200
RSVDv2 support - 1st stage
Added META_OPERATION_START (Resize, ConvertToVHDSet)
Added META_OPERATION_QUERY_PROGRESS
Added QUERY_SAFE_SIZE
Minor fixes:
Using GUID data type for LinkageID, VirtualDiskId and InitiatorId, not binary blob
Fixed length for SVHDX_TUNNEL_OPERATION_HEADER
Cosmetic: unused var, code makeup
Ping-Bug: 11232
Change-Id: I4ea598367a1c12586501555f4a23d6249057484a
Reviewed-on: https://code.wireshark.org/review/19979
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=64984b7a59ca52ec32d6608ad6ca29…
commit 64984b7a59ca52ec32d6608ad6ca298c054ff49e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 7 21:35:16 2017 +0100
Qt: Add check for valid profile name
Add check for a valid profile name in the Profile dialog and disable
the Ok button and mark the invalid profile if error.
The GTK dialog does not close on errors but the Qt dialog does, so
ensure the user is informed beforehand.
Change-Id: If31ffe75183066cf49e2b5a082112bfe62d6c06e
Reviewed-on: https://code.wireshark.org/review/19995
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b3068a0d1bfa8b8eec2bcf0f851e5f…
commit b3068a0d1bfa8b8eec2bcf0f851e5feae118fbec
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Feb 7 18:21:00 2017 -0800
Fix a comment to match we-run-on-Windows-too reality.
Change-Id: I68a299afd1d8228e7c842f66ffd3b4ee1ffb3798
Reviewed-on: https://code.wireshark.org/review/20014
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ddd83806f081090f4112f2bff81b03…
commit ddd83806f081090f4112f2bff81b03ac42b9c2c6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Feb 7 21:16:37 2017 +0100
ldap (asn1): fix indent (use 2 spaces)
Change-Id: I62d3e966928eba75dc26c2c3b6993175fe0f133e
Reviewed-on: https://code.wireshark.org/review/19994
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3f0e6d51ba4af8a84ad94a8a45bfc9…
commit 3f0e6d51ba4af8a84ad94a8a45bfc98fcba9efc5
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 20:15:08 2017 +0100
ssl-utils: add vector length validation for Client Hello
Use ssl_add_vector to process DTLS Cookie, cipher_suites,
compression_methods, client_hello_extension_list. Removed some checks
(like cipher_suite_length > 0) since (per specification) these must be
non-empty (if this is not the case, then at worst an empty tree is
visible).
Change-Id: I7ab2ef12e210d5878769478c7dfba33a799fb567
Reviewed-on: https://code.wireshark.org/review/19993
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=0e74fbb4281d3b4fac812d04004c16…
commit 0e74fbb4281d3b4fac812d04004c1668cbf903ab
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Feb 7 13:35:41 2017 -0800
Make sure pid_t is defined.
Just as we include <windows.h> on Windows to get HANDLE defined, include
<sys/types.h> on UN*X to get pid_t defined.
We don't seem to need this (yet) on the master and 2.2 branches, but it
looks as if it might be necessary on the 2.0 branch. Do it everywhere.
Change-Id: I9535fa9944265746d332f8dc337e42a020b503d3
Reviewed-on: https://code.wireshark.org/review/19998
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1185fbab426830a04a5fa2042c6566…
commit 1185fbab426830a04a5fa2042c656666efc3a3f3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Feb 7 15:30:43 2017 +0100
ui: Write recent file when applying profile changes
Write the recent file for the current profile before copying or renaming
the profile to ensure the latest changes are not lost.
Change-Id: Ib07881925b398314da0a9b2ec875da7650b84712
Reviewed-on: https://code.wireshark.org/review/19984
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=cecf9f13fe4aa283bba131e53ae2c8…
commit cecf9f13fe4aa283bba131e53ae2c84a4a68ccfb
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 18:05:44 2017 +0100
TLS13: update NewSessionTicket dissection
The new ticket_age_add field resulted in a dissector exception. With
this fixed, the tls13-18-picotls-earlydata.pcap capture can now be fully
decrypted.
Also add validation for the ticket length (using ssl_add_vector).
Change-Id: I167038f682b47b2d1da020a8f241daaf7af22017
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19992
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f958dd5acecda5a9f38500687718dc…
commit f958dd5acecda5a9f38500687718dce3ece26ed4
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 16:15:01 2017 +0100
TLS13: support Early Data and accept CLIENT_EARLY_TRAFFIC_SECRET
Update "early_data" extension to draft 18 (context field is gone).
Add support for "client_early_traffic_secret" to the keylog.
Support decryption of 0-RTT data (required handling cipher in Client
Hello and handling of "end_of_early_data" alert).
Tested with tls13-18-picotls-earlydata.pcap, early data decrypts
correctly. (The server data is messed up, but that is possibly the
result of broken NewSessionTicket handling which throws a dissector
exception and thus breaks the record sequence number.)
Ping-Bug: 12779
Change-Id: I9e6aeeb08111d5d977f2c0ab855f14d6d86ca87d
Reviewed-on: https://code.wireshark.org/review/19989
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6d08a0e4c7f2c4c9ec10bca8a3d02c…
commit 6d08a0e4c7f2c4c9ec10bca8a3d02c9442e5f8d9
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Feb 7 17:15:17 2017 +0100
[H248 Annex C] hf variable imported from packet-sdp,c is uint16 not int
Change-Id: I8122a88b9b203b9535e8f69f8b71d2e11dc7dac6
Reviewed-on: https://code.wireshark.org/review/19988
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=829b68115132ca74acc85b7ce34dc7…
commit 829b68115132ca74acc85b7ce34dc748bcdca96d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Feb 7 12:36:47 2017 +0100
Update symbols
Change-Id: I4a868eb276af26ffc38e5c66f47bc9cc32f1d4de
Reviewed-on: https://code.wireshark.org/review/19985
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2a4a6f689330cc6b73baaf55a07146…
commit 2a4a6f689330cc6b73baaf55a07146c861d4a2a2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Feb 7 16:29:11 2017 +0100
Ubuntu 14.04 complains about unititialized variable proto_name_length
Change-Id: I325e98c9eeafaa53b5f757f4b8e5e903a31e1cc2
Reviewed-on: https://code.wireshark.org/review/19987
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=c31b8da7214496d1469abe9b7eee8a…
commit c31b8da7214496d1469abe9b7eee8a6834df1ddf
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 5 23:00:51 2017 +0100
stats_tree: add cleanup function.
Change-Id: Iefd264bdd79af172c245c3a30119999cca9d56c0
Reviewed-on: https://code.wireshark.org/review/19976
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a2ce68451ebbe8ad67e5bf07ec98de…
commit a2ce68451ebbe8ad67e5bf07ec98de95120c1b8c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 13:34:16 2017 +0100
prefs: free memory on cleanup.
Change-Id: I723032974e34940715ccde5c3744f8c572c6dfda
Reviewed-on: https://code.wireshark.org/review/19895
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=96c756cc6f2748a96d330c3a726164…
commit 96c756cc6f2748a96d330c3a7261648e51cf4f6c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Feb 7 12:58:18 2017 +0100
ssl-utils: fix false warning about empty SNI
Server Hello can contain an empty extension, so restore the check.
Change-Id: I7d1ccfa113cd8a568def6915a80fd2791fd361df
Fixes: v2.3.0rc0-2284-g420b9e061e ("ssl-utils: add length validation for SNI
extension")
Reviewed-on: https://code.wireshark.org/review/19983
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=02190e7554f3b6dfcad6ffb81defcd…
commit 02190e7554f3b6dfcad6ffb81defcd5a85dc2cea
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 5 14:55:46 2017 +0000
.mailmap: Update (of January and February )
Change-Id: If1034d7aad02640adc45b4f276e180433e901e50
Reviewed-on: https://code.wireshark.org/review/19965
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e761f0ac00395ed8c964ac0414e0d…
commit 6e761f0ac00395ed8c964ac0414e0dc704f54d23
Author: Allan Møller Madsen <almomadk(a)gmail.com>
Date: Sun Feb 5 16:03:34 2017 +0100
Add dissection of Bluetooth 5.0 AE related HCI commands
Added the following batch of HCI commands:
LE Read Maximum Advertising Data Length
LE Read Number of Supported Advertising Sets
LE Remove Advertising Set
LE Set Periodic Advertising Data
LE Set Periodic Advertising Enable
LE Set Extended Scan Parameters
LE Set Extended Scan Enable
LE Extended Create Connection
Corrected min/max interval field sizes of LE Set Extended
Advertising Parameters command and updated LE Set Extended
Advertising Enable command to use subtree for each set.
Change-Id: Id9c08189a76a0a4adc89b669b50d832f68a929aa
Signed-off-by: Allan Møller Madsen <almomadk(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/19958
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1ec2a69c8a133d1f524bd146bbf3d9…
commit 1ec2a69c8a133d1f524bd146bbf3d9814bd62077
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Thu Feb 2 19:31:39 2017 +0100
Bluetooth: EIR/AD: Add support for LE Features and Channel Map
Based on CSS7 specification.
Change-Id: Ibf00e3add7fcb1a2b3a22574bb63b0fddaf4adcb
Reviewed-on: https://code.wireshark.org/review/19972
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5d1c478bc15c3b4d843506da4d6f88…
commit 5d1c478bc15c3b4d843506da4d6f880a0cc32f66
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Wed Feb 1 18:31:39 2017 +0100
Bluetooth: AD: Add support for AltBeacon
Another format of beacon in advertising packet.
Based on: https://github.com/AltBeacon/spec
User needs to use DecodeAs to use this dissector - any manufacturer's
company id may be valid.
Change-Id: I5656d9dbb70b648b2fadba7f3b525d38a2fe8e57
Reviewed-on: https://code.wireshark.org/review/19971
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=912aaf0304b2bc8e7a559825a379f2…
commit 912aaf0304b2bc8e7a559825a379f262bffca129
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Feb 6 12:53:18 2017 -0800
Adjust startup count for extcap.
The number of extcap splash items is the number of extcap binaries plus
RA_EXTCAP.
Change-Id: I9702da5a94e244ddd95a845a67da9302ee41c826
Reviewed-on: https://code.wireshark.org/review/19981
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e9cf760c0cc3fea14404ab6e43b72d…
commit e9cf760c0cc3fea14404ab6e43b72d52fd016483
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Feb 6 10:50:22 2017 -0800
GTK: Wrap static preference labels.
In the GTK+ prefrences dialog, enable wrapping and set a maximum width.
This should keep labels from making the dialog unusably wide.
Make a couple of enum preferences drop-downs instead of radio buttons.
Note that we might want to make the drop-down vs radio button behavior
automatic.
Change-Id: Ib72a2c8d5cfb99324be86f2218b6d57a395fa22c
Reviewed-on: https://code.wireshark.org/review/19980
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=420b9e061e018cfd3d8799e16ebcfe…
commit 420b9e061e018cfd3d8799e16ebcfef347f0d528
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 18:44:36 2017 +0100
ssl-utils: add length validation for SNI extension
Add copy of the definition in a comment, remove check for empty
extension such that export info can be added if the extension is empty.
Remove check for empty HostName, this cannot happen (and is caught by
ssl_add_vector).
Change-Id: Ie63b97e89dc7254f159abb338b52f5f894a8564d
Reviewed-on: https://code.wireshark.org/review/19939
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6c1d140f6cb15e5328ee5ff344aadc…
commit 6c1d140f6cb15e5328ee5ff344aadc7ee257a3c3
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 17:19:32 2017 +0100
ssl-utils: add length validation for Cookie extension
Also adds the definition from TLS 1.3 draft 18 spec.
Change-Id: Ic7910874507e76dcbe7ae15aff99c91496a2b590
Reviewed-on: https://code.wireshark.org/review/19938
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bdbe1e2ed740efe21f8e1bae69159e…
commit bdbe1e2ed740efe21f8e1bae69159eb03ff94270
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 17:14:52 2017 +0100
ssl-utils: add length validation for renegotiation_info extension
Add description from spec, remove zero-length extension check since it
is not allowed by specification.
Change-Id: I4bf85b36d933db3658f7788768fd794b6199187e
Reviewed-on: https://code.wireshark.org/review/19937
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f3eb00a31d3bf0ae20ea912216dce4…
commit f3eb00a31d3bf0ae20ea912216dce426917ece85
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 17:06:40 2017 +0100
ssl-utils: add length validation to NPN extension
Add the definition from draft 4 as well (which describes the structure
in text). Remove the check for zero length name since this is normally
not the case (according to draft specification).
Change-Id: I72c3f04a5146d4c4fa291383258246d9ba2b14be
Reviewed-on: https://code.wireshark.org/review/19936
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e19084f4cd16f9a6b3124b2643c396…
commit e19084f4cd16f9a6b3124b2643c3963d89e21adf
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 15:51:31 2017 +0100
ssl-utils: add validation for ALPN
Use ssl_add_vector to ensure that the lengths are checked for validity
and that expert info is added when invalid data is encountered.
Change-Id: I5d03dce988f695cdc305f1bfff9d19ae90c5f6e2
Reviewed-on: https://code.wireshark.org/review/19935
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=658253ba34e569313f8fec0d2e4ed7…
commit 658253ba34e569313f8fec0d2e4ed7367501c7a3
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 15:15:10 2017 +0100
(D)TLS: simplify SignatureAndHashAlgorithm dissection
Merge the length parsing into the SignatureAndHashAlgorithm vector
parsing. Remove extra expert info which are replaced by the generic
ones.
Tested with a mutated pcap where the signature length field is off by
one (too large = expert error, too small = expert warning, as expected).
Change-Id: I43350352ae00eb42bbe5c2ee81289fb592b88f86
Reviewed-on: https://code.wireshark.org/review/19933
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4623b05cd54e323047f6b426665310…
commit 4623b05cd54e323047f6b4266653107f57a88684
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 14:31:08 2017 +0100
ssl-utils: refactor "length" parameter into "offset_end" for
extensions
Change all Hello extension dissector functions to accept the end of the
extension rather than the extension length. The changes are quite
mechanical: change "ext_len" to "ext_len = offset_end - offset".
Remove some "offset += ext_len" to ensure that additional unparsed data
is warned for.
The intent is that (extension) dissectors can easier check for overflow
(offset + 2 < offset_end). Later changes should remove "guint ext_len"
with appropriate changes (like replacing by ssl_add_vector).
Change-Id: Ic4846e6fd6164685c4704984136f701bec3afa58
Reviewed-on: https://code.wireshark.org/review/19932
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f6b7857890bd785f1670193fe89673…
commit f6b7857890bd785f1670193fe896733171071c2d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Feb 3 01:13:32 2017 +0100
ssl-utils: add helper for validating Variable Length Vectors
Currently variable length vectors are mostly unchecked with issues
ignored (see various "XXX - expert info"). In order to detect possible
attacks (and catch dissector issues), add helpers that extract the
vector length and that validate that a vector is correctly terminated.
Further dissection of a vector stops when not enough data is available.
The KeyShare extension and Extension itself are modified as a start,
more should follow. Future work should also ensure that the return value
represents the length after dissection (which should not exceed the
length). Also, the length field needs to be converted to an "offset_end"
value to ease overflow checking (length = offset_end - offset).
Change-Id: I6d757da2eb028f08a7b18661660313a6afd417e0
Reviewed-on: https://code.wireshark.org/review/19926
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4f532f56ce0a4fc876319b9f605f60…
commit 4f532f56ce0a4fc876319b9f605f6025e61ac8eb
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sun Feb 5 11:14:56 2017 +0100
Bluetooth: Update Assign Numbers
Updated on 5th February 2017:
- UUIDs
- Company Ids
Change-Id: I9868891ee2bdcdaa687bd45c76429f2b476889cc
Reviewed-on: https://code.wireshark.org/review/19973
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=015adf808cbc6e7fe22b8280d9714b…
commit 015adf808cbc6e7fe22b8280d9714b6be0da66ff
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Feb 5 19:51:31 2017 +0100
rawshark: fix err code.
Change-Id: I5aec3ad14eb0f0d591691f2aa7eb8ce09341e020
Reviewed-on: https://code.wireshark.org/review/19963
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b774638092153ea51b0d4a2cfdb1a8…
commit b774638092153ea51b0d4a2cfdb1a8b7421ce445
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sun Feb 5 12:16:02 2017 +0100
Bluetooth: ATT: Implement "Resolvable Private Address"
"Resolvable Private Address" comes in Core 5.
Also fix expert infos (usage) for all GAP characteristics are
described in Core 5.
Change-Id: I8386f5908b64cb758e2a973fb6f92fabcb30885a
Reviewed-on: https://code.wireshark.org/review/19974
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0eda452415c728a69a65d13c297d47…
commit 0eda452415c728a69a65d13c297d477001440d60
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sun Feb 5 13:04:56 2017 +0100
Bluetooth: SDP: Add HDP MDEP Data Type values for ISO/IEEE 11073-20601
Values found at Bluetooth SIG: Assign Number:
https://www.bluetooth.com/specifications/assigned-numbers/health-device-pro…
Change-Id: Ic99129e717f1de22162f5e398fa5b81ff3dcdc5a
Reviewed-on: https://code.wireshark.org/review/19975
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cde0937efc8280943c0d1ff4f8c439…
commit cde0937efc8280943c0d1ff4f8c4397decc48391
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Feb 4 23:53:10 2017 +0100
llc: replace GHashTable and glib allocator with wmem.
Change-Id: Ia7736e0faff16dd73d56a91b5a96cc715e3ce75d
Reviewed-on: https://code.wireshark.org/review/19953
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=850393b57bdd7011780f4cf897d4a2…
commit 850393b57bdd7011780f4cf897d4a2467f58a673
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Feb 4 23:41:10 2017 +0100
geoip_db: remove leak.
Change-Id: I40911820fa09111c167a5c526027f10381038dbb
Reviewed-on: https://code.wireshark.org/review/19952
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5df6983486bdb3dbf6b55b547f31b5…
commit 5df6983486bdb3dbf6b55b547f31b5465e73e296
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Tue Jan 31 19:27:51 2017 +0100
checkfiltername: Add llc.bluetooth_pid to the whitelist
"llc.bluetooth_pid" is now placed in bluetooth-file, it seems to be
fine, but there is a need to avoid terrible/horrible scream from
this script.
Change-Id: I0bf3f5b5f6459ab1f13a8c2c6ad12859af608e85
Reviewed-on: https://code.wireshark.org/review/19969
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=60edcb18298f6fee6492fa90ad3ea0…
commit 60edcb18298f6fee6492fa90ad3ea0a1610fae06
Author: Oliver Downard <oliver.downard(a)couchbase.com>
Date: Fri Feb 3 12:42:32 2017 +0000
Couchbase: Add decoding for create_bucket config
Change-Id: I7d84e67723196d9b39f6007950ec8fb95fe9a50e
Reviewed-on: https://code.wireshark.org/review/19934
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9ffff86e8d40e210b479bf57ff7617…
commit 9ffff86e8d40e210b479bf57ff7617a2ba9d12bc
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Sun Feb 5 21:03:04 2017 +0200
RSVD dissector: minor fixes
DataIn field should be three-state enum (not boolean)
See https://msdn.microsoft.com/en-us/library/dn393496.aspx
Fixed HandleStateShared value of QUERY_SHARED_VIRTUAL_DISK_SUPPORT reply
See https://msdn.microsoft.com/en-us/library/dn409282.aspx
Added VHDSET disk format (used by RSVD v2).
Change-Id: I7a9528e680dd4fede7e982d98316af5ef40cff3b
Reviewed-on: https://code.wireshark.org/review/19964
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a69d0b1fba9a73a8d1869c16091495…
commit a69d0b1fba9a73a8d1869c16091495cb7eee3030
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Thu Feb 2 08:41:52 2017 +0100
GTK: Add 'in' operator in display filter expression dialog
Add the 'in' operator to the list of available operators, where 'eq'
operator would be present also. Setup the curly bracket expression in
the filter and allow for multiple enums to be selected.
Bug: 12808
Change-Id: I42b328bcb3328521d193d9cdae56577eb66f8e15
Reviewed-on: https://code.wireshark.org/review/19913
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e35c21c64466c1e07288e4dd22e94d…
commit e35c21c64466c1e07288e4dd22e94d56e4dc8ba5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Feb 5 08:11:59 2017 -0800
[Automatic update for 2017-02-05]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: Ic3553d0e987fc7c0eafbe42a517f46212d137edc
Reviewed-on: https://code.wireshark.org/review/19959
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=19f07216fd061a74871cd16f3439b9…
commit 19f07216fd061a74871cd16f3439b9da24abbcf7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 5 15:17:54 2017 +0100
ieee802.11: fix indent
Change-Id: I8d521200b645b7a7b73c1da1d466bfd992c70c17
Reviewed-on: https://code.wireshark.org/review/19957
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5511386f16b0727463238b4b0bf800…
commit 5511386f16b0727463238b4b0bf800f1a1317b8d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Feb 5 15:10:58 2017 +0100
iee80211: fix typo on some tag define
Change-Id: Ib3c35d332ef4c4b1b6d66d5fb9de7f87bcf15461
Reviewed-on: https://code.wireshark.org/review/19956
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c9d8c1c8c518f5c5b9eebb6a922c0e…
commit c9d8c1c8c518f5c5b9eebb6a922c0eb410356dad
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Thu Jan 19 15:37:54 2017 +0100
PDML: protocol filter incorrectly filters desired subfields
Bug: 12847
Change-Id: I8a560dc44dceb06123d8bcecd512d132ee4ebb0d
Reviewed-on: https://code.wireshark.org/review/19671
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a8ceeca444c97033e630d56d6a6fb0…
commit a8ceeca444c97033e630d56d6a6fb096e696163b
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Sat Feb 4 21:09:59 2017 +0000
DNP3: Fix reassembly of out of order fragments
Rework Application Layer fragment reassembly to handle
out of order fragments (seen over UDP).
Change-Id: Ifd2bffba30f0a419a5f82ea6b9d2d221f7d6d276
Reviewed-on: https://code.wireshark.org/review/19947
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=fd2bd2b154730f88d968648cc5705c…
commit fd2bd2b154730f88d968648cc5705c86681ca14c
Author: AndersBroman <a.broman(a)bredband.net>
Date: Sun Feb 5 09:23:44 2017 +0100
[GSA RR] Dissect System Information Type 21
Change-Id: I85535dfdb7b064ba81f44ed08c3b1e84e7204e9e
Reviewed-on: https://code.wireshark.org/review/19954
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c7622c9559dde206917990edc46dc1…
commit c7622c9559dde206917990edc46dc1992e434f53
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Feb 3 23:06:48 2017 -0500
pint(.h): Add Modelines and fix indent (use spaces)
Change-Id: Icadbf65ad186c775b2a0ca8596d5bf4ba66e4c68
Reviewed-on: https://code.wireshark.org/review/19873
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4248a97a9b1730ee7b7c09e889c3b8…
commit 4248a97a9b1730ee7b7c09e889c3b8d415624a68
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Feb 4 14:23:23 2017 -0800
There's an RFC for that.
Change-Id: If9a3ba7fbd93374b4c63be7ce37510be5c2848f0
Reviewed-on: https://code.wireshark.org/review/19948
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=55b3de86c2ea4e47e660820e78cd44…
commit 55b3de86c2ea4e47e660820e78cd4434eede8b34
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Feb 2 11:23:24 2017 +0000
IPv6: Update SRH dissection to draft-*-05
Change-Id: Ia61e8ffb4499e2ea25e66e9e05a6d2881f15d6ae
Reviewed-on: https://code.wireshark.org/review/19914
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0b25b1ab072c559fc897348dce286e…
commit 0b25b1ab072c559fc897348dce286ee32ff7308b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jan 24 14:19:22 2017 +0100
tap: add cleanup routine.
Change-Id: I460b053880ed43a7377b7696531bbaeb0fd0d68b
Reviewed-on: https://code.wireshark.org/review/19764
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e59583624cec7a3bed0aab95a365af…
commit e59583624cec7a3bed0aab95a365afe0f3e64397
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:37:44 2017 +0100
tap-stats_tree: use wmem allocator.
Change-Id: I17e652bf9c6e8a17c57afa0bc7bb909636152d15
Reviewed-on: https://code.wireshark.org/review/19945
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9a47f5cd19b90a3a7592a0d305e860…
commit 9a47f5cd19b90a3a7592a0d305e860e421d59957
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:31:01 2017 +0100
conversation_table: replace g_string with wmem allocated string.
Change-Id: I54402822ee24214d13e052c0379514a39de16980
Reviewed-on: https://code.wireshark.org/review/19944
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=92601c411a9780d7a343f2fd50817d…
commit 92601c411a9780d7a343f2fd50817d318977abf9
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Feb 3 23:49:27 2017 +0100
srt_table: add cleanup function.
Change-Id: I8d1e9d587f7d47a9064d7b2e0c89f31dc41854ea
Reviewed-on: https://code.wireshark.org/review/19946
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6311657ff9104b517bde3c079d4bff…
commit 6311657ff9104b517bde3c079d4bff3066ba9321
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Dec 11 21:32:55 2016 +0100
.mailmap: Update (of december)
Change-Id: Id96ce391b9957ac37705c503bea35395ee3d358d
Reviewed-on: https://code.wireshark.org/review/19207
Reviewed-by: Paul Williamson <paul(a)mustbeart.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=22ab06525d40c74fd144c88ce39d26…
commit 22ab06525d40c74fd144c88ce39d260e0d738ece
Author: olivermd <oliver.downard(a)couchbase.com>
Date: Thu Feb 2 15:28:59 2017 +0000
Add support for Couchbase LWW *_with_meta commands
Decodes the options and meta length fields added with LWW for
{set,del}_with_meta request commands.
Decodes get_meta responses extra field.
Please see https://issues.couchbase.com/browse/MB-22003
Change-Id: Ie5205e8188a32d59145c4f9c499b16c7a7997274
Reviewed-on: https://code.wireshark.org/review/19928
Reviewed-by: Dave Rigby <daver(a)couchbase.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a3bd6059ca819e126da5ffda35dda1…
commit a3bd6059ca819e126da5ffda35dda19e54304050
Author: samsaha <ssahasamiran(a)gmail.com>
Date: Wed Feb 1 17:20:38 2017 +0530
MKA: Padding support for basic-param-set dissection added
* It must be multiple of 4 Octets otherwise NULL padding should be there
Change-Id: I7563b0407bd70d1f0b7aac8597ce3a757a08925e
Reviewed-on: https://code.wireshark.org/review/19893
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1a1e7e4b8df3915c2569f9933ef226…
commit 1a1e7e4b8df3915c2569f9933ef226784632e498
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Feb 3 09:13:26 2017 +0100
BTLE: check connection_info presence before trying to perform reassembly
Bug: 13379
Change-Id: Idafa780f24bf9f181c0913cbe16a0cfa9bce382e
Reviewed-on: https://code.wireshark.org/review/19927
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3481ca8733601f88c3c4c535d19b43…
commit 3481ca8733601f88c3c4c535d19b43ea99a35bbb
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Feb 2 17:10:51 2017 +0100
extcap: destroy hash tables on exit.
Change-Id: Ia6a1d8a45c36aff7f2bea8bde2ed5f308bddd2e1
Reviewed-on: https://code.wireshark.org/review/19919
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe06aad460d7525cc6196019b18bf9…
commit fe06aad460d7525cc6196019b18bf9972e078231
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Feb 2 22:59:21 2017 +0100
sharkd: fix warning C4090: 'function' : different 'const' qualifiers
According to
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).…
the lpCommandLine argument must not be const as is may cause an access violation.
Change-Id: Iedd77663cd21ca8df542595890fbc7023f2c9c2b
Reviewed-on: https://code.wireshark.org/review/19922
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7c69ae929dbe39b3fa94034dec6519…
commit 7c69ae929dbe39b3fa94034dec65198d39111166
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Feb 2 16:43:22 2017 +0100
dfilter-macro: add cleanup routine.
Change-Id: I3de59c0366e9bec058de144eb136abaca24b5911
Reviewed-on: https://code.wireshark.org/review/19918
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=370d13026a4c6abf23178681ea27f4…
commit 370d13026a4c6abf23178681ea27f438f0daa5b6
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Feb 2 14:41:46 2017 +0100
stream: clean up reassembly table.
Change-Id: I71bc19eed5de342cd794938e3eb21545249d4853
Reviewed-on: https://code.wireshark.org/review/19917
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=60317123837a1a9c7d858ec579a368…
commit 60317123837a1a9c7d858ec579a368275de87109
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Feb 2 16:12:23 2017 -0800
Fix builds without libpcap.
capture_opts_cleanup() doesn't exist if we're building without libpcap,
so don't call it if we're building without libpcap.
Change-Id: I9ae33b0c13af2785b5adb380a5b03e89116f67df
Reviewed-on: https://code.wireshark.org/review/19925
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=14fba80f0f478d9c167685ca2be74c…
commit 14fba80f0f478d9c167685ca2be74c72e46d2664
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Feb 2 16:00:49 2017 -0800
Fix builds without libpcap.
capture_opts_cleanup() doesn't exist if we're building without libpcap,
so don't call it if we're building without libpcap.
Change-Id: I6c9defea15fac7df5533269c4945b965d9a67c25
Reviewed-on: https://code.wireshark.org/review/19924
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=93a5c83f0a6e609ec4ba3e55872f99…
commit 93a5c83f0a6e609ec4ba3e55872f9924d59ba38a
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jan 25 10:16:35 2017 +0100
capture_opts: free memory on exit to avoid leak.
This required a restyle of the way the different apps exit.
Change-Id: Iedf728488954cc415b620ff0284d2e60f38f87d2
Reviewed-on: https://code.wireshark.org/review/19780
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=844cf1ac9063553b08444c0d56b96d…
commit 844cf1ac9063553b08444c0d56b96ddf09fcc558
Author: Andreas Gruenbacher <andreas.gruenbacher(a)gmail.com>
Date: Thu Feb 2 19:40:15 2017 +0100
NFSv4.2 mode_umask support
Add support for the NFSV4.2 mode_umask attribute which will be initially
supported by Linux v4.10.
Change-Id: Id98e20cd0ed93bf7ad9b2246e9e05299f3d7a9fc
Reviewed-on: https://code.wireshark.org/review/19921
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0da95c129e0d10486ca6badce657db…
commit 0da95c129e0d10486ca6badce657db20e8dc02e0
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 19:33:09 2017 +0100
dtls: Support Decode As for selecting appdata dissector
Being able to override (set) the application data dissector without
hacks (RSA keys dialog) would be nice. Modelled after
v2.3.0rc0-481-gafa2605e43 ("Support Decode As for {SSL,TLS}-over-TCP.")
Change-Id: Ic4c5ca55e8f20ad599c41c1df58b24f3bced2281
Reviewed-on: https://code.wireshark.org/review/19869
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=7893ffa478bdbd4cd48aa438569a0b…
commit 7893ffa478bdbd4cd48aa438569a0bd32fada99b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 1 13:12:01 2017 +0100
wsutil/sober128: remove unused macros and functions
Removed unused macros/functions that are apparently imported from
LibTomCrypt, only LOAD32L and STORE32L are needed. Remove code that
tries to distinguish between little/big endian, since WORDS_BIGENDIAN
was never defined, this would never have worked on big endian anyway.
Remove the special ROR "optimization" for GCC on i386, modern compilers
are able to optimize it to exactly the same thing. The generic
LOAD32L/STORE32L macros are less optimized (as can be seen in the
generated code), but this was not noticable in the mean running time.
Tested with the packet capture from bug 3232, the result is the same:
tshark -ocorosync_totemnet.private_keys:example.com -r
corosync-totemsrp--key:example.com--2nodes.pcap -Vx
Bug: 13368
Change-Id: I59bf27d7dd990bbcd5ad34a1797f4a6c8a04512d
Reviewed-on: https://code.wireshark.org/review/19894
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f15d5dde0b5cc0532b70279e7a7492…
commit f15d5dde0b5cc0532b70279e7a7492fafe94ed3c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 13 11:32:20 2017 +0100
xml: use wmem allocators and replace GHashTable with wmem_map_t.
Change-Id: I9dbddc6fd4a5eaa458843343b3e9b8e1832bde8f
Reviewed-on: https://code.wireshark.org/review/19630
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=f6e88944c3f2cb8691b04a8195dc0d…
commit f6e88944c3f2cb8691b04a8195dc0d735fd3838f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jan 31 17:30:02 2017 +0100
sharkd: make it compile without libGeoIP.
Change-Id: Ief867ce8552136298bd6bd6879ec482cc5b38b6f
Reviewed-on: https://code.wireshark.org/review/19887
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=179e0fbc11fda7a2643097d4c67685…
commit 179e0fbc11fda7a2643097d4c67685953fdf5e2f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 14:40:56 2017 +0100
imf: convert GHashTable to wmem_map
Change-Id: Ia5bd6af88db76bbe4e0a267c30b6f7749b23e299
Reviewed-on: https://code.wireshark.org/review/19903
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=47ad059bd78ecf94542293e8eb97ae…
commit 47ad059bd78ecf94542293e8eb97aedcf5f808f8
Author: Gianluca Borello <g.borello(a)gmail.com>
Date: Mon Jan 23 08:57:32 2017 -0800
Rawshark: Add a memory limit (-m) option.
Add an option to rawshark that lets the user set a maximum memory limit.
Change-Id: Ie102ee5f6ba5aec90a35bd63297184c7dc37662c
Reviewed-on: https://code.wireshark.org/review/19911
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=c0d25e8a5d093c448dde610873d216…
commit c0d25e8a5d093c448dde610873d216cf3d3fb060
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 14:22:43 2017 +0100
ncp: convert GHashTable to wmem_map_t.
Change-Id: I0de1c332a6052c20f6afbe1e51dfb14e18485891
Reviewed-on: https://code.wireshark.org/review/19899
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=577d21e35c1ca19e245014ea2b65d0…
commit 577d21e35c1ca19e245014ea2b65d09709c9cca3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Feb 1 23:13:42 2017 -0500
GHashtable -> wmem_map conversions
Many of the register_init_routine/register_cleanup_routine functions
are for initializing and cleaning up a GHashtable.
wmem_map_new_autoreset can do that automatically, so convert many
of the simple cases.
Change-Id: I93e1f435845fd5a5e5286487e9f0092fae052f3e
Reviewed-on: https://code.wireshark.org/review/19912
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=36892d8a4ca2f6019dc00b0f254009…
commit 36892d8a4ca2f6019dc00b0f2540097499da2e11
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 14:29:30 2017 +0100
iso15765: convert GHashTable to wmem_map.
Change-Id: I25fd598f3c2bd75548213140e93198b611f30d4b
Reviewed-on: https://code.wireshark.org/review/19900
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=30266527aacf4b3cbc7d07a0c56a8b…
commit 30266527aacf4b3cbc7d07a0c56a8ba100b19f49
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 21:59:14 2017 +0100
tools: add a Gtk/GNOME suppression file.
As described here https://wiki.gnome.org/Valgrind valgrind can be
tuned for Gtk/GNOME (glib) software by this official (or so) suppression
file. Add it to the standard valgrind script to reduce the output
for those functions out of Wireshark scope.
Change-Id: I5dbc91ce82a890c9c02b624289ced96909be5f84
Reviewed-on: https://code.wireshark.org/review/19910
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=efb5c1537de616826408660f8d9aca…
commit efb5c1537de616826408660f8d9aca659d5297c3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Dec 7 13:30:26 2015 +0100
Qt: Add extcap placeholder parameter
Added a parameter to set placeholder text in textBox.
Change-Id: Iccf92fe60abc78be8f0fa112c0c9eb78890674b5
Reviewed-on: https://code.wireshark.org/review/12463
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bd3c2d2954e58829d44bc4319fbfa9…
commit bd3c2d2954e58829d44bc4319fbfa921f5bffc9f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 1 09:40:58 2017 -0500
Make some more protocols into pinos.
Change-Id: I87d842e3efe9f82eaaab81347dfb79d6c0932792
Reviewed-on: https://code.wireshark.org/review/19491
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=28d7753972cb88be18916091b9900c…
commit 28d7753972cb88be18916091b9900c2cc31df1f4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Feb 1 11:04:54 2017 -0800
Use INVALID_SOCKET for an invalid socket handle.
-1 is fine on UN*X, but, on Windows, it's INVALID_SOCKET. We define
INVALID_SOCKET as (-1) on UN*X, so it can be used on both platforms.
Change-Id: Ib2269ddf98c352a1d3c85e44006cc49d80750a78
Reviewed-on: https://code.wireshark.org/review/19909
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c46ea01374d2c1d4ddb1568936244c…
commit c46ea01374d2c1d4ddb1568936244c8bc5888300
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Feb 1 10:17:48 2017 -0800
Fix some more UN*X-vs-Windows issues.
Change-Id: Ie9ad31289f0572a7e7249fcb3305849673536f05
Reviewed-on: https://code.wireshark.org/review/19908
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ed6c961441f5f070e60b5c708f1736…
commit ed6c961441f5f070e60b5c708f1736abc947adde
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 15:11:15 2017 +0100
frame: use wmem instead of glib allocator.
Change-Id: Ibed5c2418d1dd400fe586d40681fb5ba90efbd9f
Reviewed-on: https://code.wireshark.org/review/19906
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=226377fa8c39496b2e5cb2f9e7b664…
commit 226377fa8c39496b2e5cb2f9e7b6642cb61dc706
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 15:34:15 2017 +0100
h460: use wmem for strdup.
Change-Id: Iac6027e4b1449a77bc6b0a3d089634a296b8e802
Reviewed-on: https://code.wireshark.org/review/19904
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=96b8da738d497c1eaea98762aca277…
commit 96b8da738d497c1eaea98762aca277a3f3493851
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 15:25:16 2017 +0100
h248: convert GTree to wmem_tree.
Change-Id: Ia8d1a7ca4ce7e8754ab97ffe5f6e11181f08b264
Reviewed-on: https://code.wireshark.org/review/19905
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=add6cb3976a479e406eb9d0a1128dd…
commit add6cb3976a479e406eb9d0a1128ddabf9a1db9b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 14:37:30 2017 +0100
ipmi: use wmem instead of glib allocator.
Change-Id: I739e0cd9ebe35049b6633a9cfa0f793d66823f9a
Reviewed-on: https://code.wireshark.org/review/19901
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0a200b2cde1abc67428dba3711f529…
commit 0a200b2cde1abc67428dba3711f52918882bf34b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 14:39:10 2017 +0100
hdcp2: convert GHashTable to wmem_map.
Change-Id: If68a73c05bfc301e1cfdba75c090305a5b454979
Reviewed-on: https://code.wireshark.org/review/19902
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2cdc1ec3a53653914cf309fa7de46a…
commit 2cdc1ec3a53653914cf309fa7de46a50199cc074
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 13:40:11 2017 +0100
proto: free memory on cleanup.
Change-Id: Ia6cb39cbf6d5b50d39746f38758433a7541219a2
Reviewed-on: https://code.wireshark.org/review/19896
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=401a20dbd43feab18931d4baa5984d…
commit 401a20dbd43feab18931d4baa5984daf8806a7e8
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 13:53:19 2017 +0100
ieee802a: add shutdown routine.
Change-Id: I21d0ab5619cde9a43b96eaff351fa338e317f4f9
Reviewed-on: https://code.wireshark.org/review/19897
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=57d270549b68738dd2c10e8fa6c600…
commit 57d270549b68738dd2c10e8fa6c600455e9bc72c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Feb 1 13:57:35 2017 +0100
ndps: convert GHashtable to wmem_map.
Change-Id: Id1f46ed533980e67bf18aa13fcc828bf1f5e7f6e
Reviewed-on: https://code.wireshark.org/review/19898
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bf14d8faf8d6de5e841fe8f5ab5210…
commit bf14d8faf8d6de5e841fe8f5ab5210b1b7a426a4
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Feb 1 11:49:30 2017 +0100
dtls: avoid possible NULL deref
"decoder->flow" could result in a NULL pointer dereference if a null
cipher was in use (caught by Clang static analyzer).
Answering the questions:
- DTLS records fragments do not need to be reassembled, thus there is no
flow. The Handshake messages have their own fragment_offset field and
thus there is no need to maintain an extra flow.
- Actually one datagram can contain multiple records (RFC 6347, 4.1.1),
but this is not implemented yet. The key can however not be "0"
though, it must match the offsets from ssl_get_record_info.
Fixes: v2.3.0rc0-2152-g77404250d5 ("(D)TLS: consolidate and simplify decrypted
records handling")
Change-Id: Iac367a68a2936559cd5d557f877c5598114cadca
Reviewed-on: https://code.wireshark.org/review/19892
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5dde07c8fdb2e17c4d4142427fe29f…
commit 5dde07c8fdb2e17c4d4142427fe29f7db66c1965
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 27 18:20:40 2017 +0100
GSM A / NAS-EPS: detect missing mandatory information elements
Current code is not able to detect missing mandatory information elements
because the macro will return once the end of the payload is reached.
Remove this check from all mandatory IE macros, and put it at the beginning
of optional IE ones. It should allow to detect any missing mandatory IE
while still stopping message dissection in case optional IEs are not
present.
Change-Id: Ie820740e25c1d03ee3462fa4a913c3a7870fcc2d
Reviewed-on: https://code.wireshark.org/review/19816
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=275594231dc1f4a08f24123e4413ac…
commit 275594231dc1f4a08f24123e4413acfd11b59d4e
Author: Allan Møller Madsen <almomadk(a)gmail.com>
Date: Sun Jan 29 22:40:42 2017 +0100
Bluetooth 5.0, HCI command/event PHY update dissection
Dissection of all new HCI command/events related with
Bluetooh 5.0 feature 'PHY update - LE 2M and LE Coded'
Change-Id: I212cb368d3295ba36eb0ca34329df566cae1611b
Signed-off-by: Allan Møller Madsen <almomadk(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/19849
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=20bce6f63a3f62d07741f1feb2561b…
commit 20bce6f63a3f62d07741f1feb2561b27b42f93d9
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 31 23:48:27 2017 -0500
packet-btle.c: If frame information is missing, provide a default.
"default" frame information sets no retransmission or more fragments.
Bug: 13015
Change-Id: I1c8a29fe06d0b38abc789c8e454dc484490186f9
Reviewed-on: https://code.wireshark.org/review/19891
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=11ce17f0a66365ece3c5cf043c4dcc…
commit 11ce17f0a66365ece3c5cf043c4dccf5cdf8df9f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 31 20:41:38 2017 -0800
Expand a comment to give more details.
(Dear Microsoft: why did you choose not to support line buffering in
the MSVC "standard I/O library" routines?)
Change-Id: I5add94d2c83e73e9845fea0f355a1923fddf2deb
Reviewed-on: https://code.wireshark.org/review/19890
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2b91f04008530039e830da5f820c6d…
commit 2b91f04008530039e830da5f820c6d449a9d5c4d
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Jan 28 22:40:17 2017 +0100
sharkd: windows support
Change-Id: I6581bacdea49416cc26431f66b093f36b39c5a67
Reviewed-on: https://code.wireshark.org/review/19829
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e25c45866e275ed156b7c31303e27e…
commit e25c45866e275ed156b7c31303e27e1c8cfe48cc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Jan 31 20:38:58 2017 +0100
ssl-utils: fix format specifies type 'void *' but the argument has type
'SslFlow *' (aka 'struct _SslFlow *') [-Wformat-pedantic]
Change-Id: Iec574db8c28d2e02136e6c4119e5688b21112299
Reviewed-on: https://code.wireshark.org/review/19889
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fcf2eb4230cce739f5f91ca105df07…
commit fcf2eb4230cce739f5f91ca105df074ac54aa35d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 22 15:17:57 2017 +0100
Openflow (v5): fix redundant redeclaration of ‘dissect_openflow_message_v5’
[-Wredundant-decls]
Change-Id: I6340f0b903af1371e69172b05650c49fc18b8890
Reviewed-on: https://code.wireshark.org/review/19888
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fe72fe0ca7a96f50d3bef353b7714c…
commit fe72fe0ca7a96f50d3bef353b7714cd0466c0747
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Mon Jan 30 22:13:58 2017 +0100
Don't provide GTK setup by default.
Update comments to reflect the behaviour as well.
Update comment inside the
Change-Id: Id3629b217a2adc096fd6b0cb0221270e92ebd5da
Reviewed-on: https://code.wireshark.org/review/19875
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=6ab483ffe33d1fc13e1da0ebd28807…
commit 6ab483ffe33d1fc13e1da0ebd2880736d4afda4c
Author: Justin Helgesen <justinhelgesen(a)gmail.com>
Date: Sun Jan 29 15:06:49 2017 -0600
Add Decode As capabilities to MoldUDP dissector
Per the Nasdaq TotalView-ITCH v2/3 protocol specifications the
NASDAQ-ITCH dissector needs be able to dissect a MoldUDP payload.
Change-Id: Id5194930025a9abdfb1663234233fd51e525a34b
Reviewed-on: https://code.wireshark.org/review/19847
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4a1150acdd9fca7eded7ddf06443c3…
commit 4a1150acdd9fca7eded7ddf06443c3f18f03c6f8
Author: Arjen Zonneveld <arjen(a)bz2.nl>
Date: Tue Jan 31 14:35:29 2017 +0100
Also show BGP Shutdown communication on admin reset
Shutdown communication is now also allowed on Admin Reset NOTIFICATION messages:
https://tools.ietf.org/rfcdiff?url2=draft-ietf-idr-shutdown-04.txt
Change-Id: I6450d3d5de5aef4bd709ba2b211ca717784b00a7
Reviewed-on: https://code.wireshark.org/review/19886
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=30baa456b11aa8300d39d8c1487c4b…
commit 30baa456b11aa8300d39d8c1487c4bf910df09dc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu May 26 13:02:07 2016 +0200
PAPI: Add dissection of Licence Manager
Change-Id: I1b7dd1835fe60852b8c90f0ce5e240813cad89d1
Reviewed-on: https://code.wireshark.org/review/15574
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=148fb1acf46e205801e4e06f4f3f75…
commit 148fb1acf46e205801e4e06f4f3f755a13bd2a48
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 31 08:29:53 2017 -0500
Add wmem allocator parameter to format_uri
Change-Id: Ic6de84a37b501e9c62a7d37071b2b081a1a1dd50
Reviewed-on: https://code.wireshark.org/review/19885
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=51a30142251e377ec28eb8584c5638…
commit 51a30142251e377ec28eb8584c56386c2481d6c0
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 31 07:51:19 2017 -0500
format_text_wmem -> format_text
All cases of the "original" format_text have been handled to add the
proper wmem allocator scope. Remove the "original" format_text
and replace it with one that has a wmem allocator as a parameter.
Change-Id: I278b93bcb4a17ff396413b75cd332f5fc2666719
Reviewed-on: https://code.wireshark.org/review/19884
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0165b8c40cfd6ca529408862095c12…
commit 0165b8c40cfd6ca529408862095c1213bdf1ebd5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 30 12:51:19 2017 -0800
Enable some more tests.
The "Microsecond pcap-ng via stdin" and "Nanosecond pcap-ng via
stdin"
tests work here on macOS and Windows (likely due to g8a141fe), so
enable them.
Change-Id: I148d02f0cc23162d782457e1d8f0e7c2c0dc6932
Reviewed-on: https://code.wireshark.org/review/19877
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8938a311eae723568d314dabe749c3…
commit 8938a311eae723568d314dabe749c33b8a9a7917
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 18:10:00 2017 +0100
TLS13: partial update of CertificateRequest for draft -18
Document structure, did not put much effort in there as the format is
subject to change (untested, no pcap available).
Change-Id: I2da8c4e005d65314158d038bc0af7411773d8fba
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19865
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cf4f44e7a5453010cecfe8ad094f44…
commit cf4f44e7a5453010cecfe8ad094f4482a0191c0e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 05:28:21 2017 +0100
TLS13: add Encrypted Extensions
See https://tools.ietf.org/html/draft-ietf-tls-tls13-18#section-4.3.1
Change-Id: I35e049d991be4c242ef2b84db3a322c6a13d2f96
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19860
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=69ee6ec3d8e33c860d0c9e16bcfa44…
commit 69ee6ec3d8e33c860d0c9e16bcfa4401ce506d8e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 05:25:11 2017 +0100
TLS13: handle content type from decrypted record
Extract the content type and handle padding per
https://tools.ietf.org/html/draft-ietf-tls-tls13-18#section-5.2
When TLS 1.3 is detected, rename the "Content Type" field to "Opaque
[Content] Type" and add a new generated field for the content type that
was extracted from the decrypted contents.
Change-Id: I149a5d7e2493dded6e2c0190e170fa350f76466e
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19859
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aaa655106af794258215b97292abd4…
commit aaa655106af794258215b97292abd4452d21b6fa
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 17:51:46 2017 +0100
TLS13: update Certificate for draft -18
Note that RPK (RFC 7250) is not well-defined and is left untouched.
https://github.com/tlswg/tls13-spec/issues/722
Certificate extensions dissections remains a task for later.
Change-Id: I62276e59db94429e4c09058aca3c08f390ec3af7
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19864
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c5adada79e1b10154b22c32b243bb3…
commit c5adada79e1b10154b22c32b243bb3140bc903d8
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 18:16:06 2017 +0100
TLS13: fix CertificateVerify dissection for -18
digitally-signed is gone in TLS 1.3. ClientKeyExchange/ServerKeyExchange
are gone, so effectively modifying this function is good enough to cover
CertificateVerify dissection (ssl_dissect_hnd_cli_cert_verify).
See https://tools.ietf.org/html/draft-ietf-tls-tls13-18#page-58
Change-Id: I07f621bc088d810a3f35343bec7a0a3303b1426b
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19866
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ec383306e52b16f117556804443fd2…
commit ec383306e52b16f117556804443fd217007cb5c9
Author: Jaime Caamaño Ruiz <jaime.caamano.ruiz(a)ericsson.com>
Date: Mon Jan 30 19:13:20 2017 +0100
Support for NSH with Ethernet encapsulation
Change-Id: I88bc4924add4d89c1386cb1be9d27233cef861f1
Reviewed-on: https://code.wireshark.org/review/19867
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=52d62a60017be02ac7b1dec16c2048…
commit 52d62a60017be02ac7b1dec16c2048f7534083f8
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 30 16:30:45 2017 -0800
WSDG: Update some of the NSIS text.
Recommend v3 instead of v2.
Change-Id: I13260611dd6b12372aba8938a87574cd9a8e1a47
Reviewed-on: https://code.wireshark.org/review/19880
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=58fb6e1acd67957eefa27de96c8ddb…
commit 58fb6e1acd67957eefa27de96c8ddb7de612e1e7
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Jan 29 23:19:48 2017 +0100
test: add (D)TLS test for AEAD ciphers
TLS and DTLS share the same code for decryption of AEAD ciphers.
Add tests for all possible AEAD cipher modes (GCM, CCM, CCM_8).
PSK is used to reduce the handshake size (removing certificates).
The decryption suite passes these tests on:
* Libgcrypt 1.6.5 (Ubuntu 14.04)
* Libgcrypt 1.7.6 (Arch Linux)
* Libgcrypt 1.4.5 (CentOS 6). Note that the GnuTLS packages are too old,
so tests that depend on RSA keys fail here (but the new tests pass).
Change-Id: If0dc5b94223fb247062e23960ff66dfdd4f7a902
Reviewed-on: https://code.wireshark.org/review/19850
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d4e3975ee7e5a2b826af988764c78c…
commit d4e3975ee7e5a2b826af988764c78c7d507d320d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jan 27 07:55:55 2017 +0100
BGP: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I0569326140c88a6dd2d7e2b8819c9f5323a98670
Reviewed-on: https://code.wireshark.org/review/19810
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a402c1ca2221c019b5b25471cefd25…
commit a402c1ca2221c019b5b25471cefd25fdc864e09d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Jan 30 22:38:20 2017 -0500
format_text -> format_text_wmem for wlan dialogs
format_text_wmem uses NULL scope in GUI dialogs
Change-Id: Ifaa342e034de9f99b59169cdf0c7ddc52ff67597
Reviewed-on: https://code.wireshark.org/review/19882
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cc479321c387a8684248bf7dde9695…
commit cc479321c387a8684248bf7dde969535f9ebcfad
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Jan 30 23:18:51 2017 -0500
Have tvb_format_text use wmem_packet_scope() memory.
It's only use is in dissectors or other tree creation APIs (where
packet scope is valid), so have it use format_text_wmem with
wmem_packet_scope().
Change-Id: I1f34e284a870c9844c6b27f4ae08a1e7efe54098
Reviewed-on: https://code.wireshark.org/review/19883
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=93e71032418045884280c7d081da2d…
commit 93e71032418045884280c7d081da2d6c0030985c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 14:29:12 2017 +0100
TLS: add bare essentials for TLS 1.3 decryption support
The bare essentials are now in place to perform decryption
(HKDF-Expand-Label, calculation of traffic secrets, AEAD integration).
Can successfully decrypt the initial handshake message. Only AES ciphers
are supported, ChaCha20-Poly1305 still needs to be added.
Note: "decryption" indeed works, but dissection needs to be updated. The
padding must be stripped and the content type extracted.
Ping-Bug: 12779
Change-Id: I3869c9ae5131e57519be99c5f439c4fa68841bae
Reviewed-on: https://code.wireshark.org/review/19858
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=17b98fe759be92019af9b870b0f1bc…
commit 17b98fe759be92019af9b870b0f1bc00f0337972
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 02:00:18 2017 +0100
ssl-utils: add AEAD authentication check
Unauthenticated data should not be displayed as valid. Validate the
authentication tag, similar like how MAC checks are done for block
ciphers. This requires Libgcrypt 1.6 or newer.
Tested against the (D)TLS AEAD tests on Libgcrypt 1.4.5 (CentOS 6),
1.6.5 (Ubuntu 14.04), 1.7.6 (Arch Linux). Compile-tested w/o Libgcrypt.
Change-Id: Iee15f4ccc5bbe01a50677167fa9c50c1ffe382d3
Reviewed-on: https://code.wireshark.org/review/19853
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f0edb2ebacb6eedf81066e0738c03…
commit 5f0edb2ebacb6eedf81066e0738c03cc8e564e96
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Sep 20 21:26:43 2016 +0200
ssl-utils: refactor AEAD decryption handling
The current ssl_decrypt_record is hard to understand due to mixing CBC
concepts (MAC, padding) with AEAD. Extract the AEAD functionality and
use better variable naming.
The "Plaintext" debug print now includes just the plaintext (the auth
tag is stripped). A write_iv.data_len check is added just to be sure and
more prep work is done for auth tag validation and TLS 1.3 support.
Tested against the (D)TLS AEAD tests on Libgcrypt 1.4.5 (CentOS 6),
1.6.5 (Ubuntu 14.04), 1.7.6 (Arch Linux). Compile-tested w/o Libgcrypt.
Change-Id: I94dd2fd70e1281d85c954abfe523f7483d9ac68b
Reviewed-on: https://code.wireshark.org/review/19852
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7e7445cc75b239c86253860e5ef7b5…
commit 7e7445cc75b239c86253860e5ef7b5b38c6a5fed
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 29 22:19:57 2017 -0500
Have hfinfo_format_text use format_text_wmem.
Use NULL scope to be safe.
Change-Id: I1967737cf6a1c90cc2e0476d3f2ace63aa0c9153
Reviewed-on: https://code.wireshark.org/review/19857
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ad5cb2eb72996c28bcd3e8f421e6dd…
commit ad5cb2eb72996c28bcd3e8f421e6dd410841e647
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 29 22:00:39 2017 -0500
Have tvb_format_stringzpad use wmem_packet_scope() memory.
It's only use is in dissectors, so have it use
format_text_wmem with wmem_packet_scope().
Change-Id: I22121324fd47aee32174b65104458ad2ef329bd7
Reviewed-on: https://code.wireshark.org/review/19856
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d802b5b0ec8e10fbf64f6c76815b75…
commit d802b5b0ec8e10fbf64f6c76815b759323029bb4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 29 21:53:49 2017 -0500
Add format_text_wmem.
This allows for a wmem_allocator for users of format_text who want
it (dissectors for wmem_packet_scope()). This lessens the role of
current format_text functionality in hopes that it will eventually
be replaced.
Change-Id: I970557a65e32aa79634a3fcc654ab641b871178e
Reviewed-on: https://code.wireshark.org/review/19855
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=60a877167f05644a5a756767980840…
commit 60a877167f05644a5a75676798084027accd1c3d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Jan 30 21:33:44 2017 +0100
ISAKMP: Add Forticlient (connect License and EndPoint Control) from Fortinet Vendor
ID
Change-Id: Idf40de8bfa76cbe4437a157fc90bd994d4b2233e
Reviewed-on: https://code.wireshark.org/review/19872
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4d506a0a0ddb5b57cac302df2dc85b…
commit 4d506a0a0ddb5b57cac302df2dc85b6f12e28ab7
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 19:41:29 2017 +0100
coap: add support for coaps (DTLS-secured CoAP)
coaps port is defined in RFC 7252, section 12.7.
CoAP (RFC 7252) is defined only for UDP, not TCP. For TCP, the frame
format is slightly different (draft-ietf-core-coap-tcp-tls-05) and
needs more dissector changes, so remove registration for now.
Change-Id: I1fc7163086f8fe66986565aa24b579ef24f72550
Ping-Bug: 13370
Reviewed-on: https://code.wireshark.org/review/19870
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=977d0769bd454e39ebaf60fe51a0eb…
commit 977d0769bd454e39ebaf60fe51a0eb590d2b7b95
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Jan 30 19:13:01 2017 +0100
dtls: fallback to data dissector if nothing took care of it
Also unconditionally show the encrypted appdata record, matching the SSL
dissector. Now the bytes are always linked to a field.
Change-Id: Ie65cd5fc6620d53da46a94cdb1972863702b452c
Reviewed-on: https://code.wireshark.org/review/19868
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bd86a45006c20bcce4e5754fc57536…
commit bd86a45006c20bcce4e5754fc575363ab7b33f66
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 30 12:52:35 2017 -0800
Dumpcap: Improve an error message.
Dumpcap doesn't yet support capturing pcapng from stdin. On Windows,
make sure we invalidate our file handle so that instead of printing
"Error reading from pipe: The operation completed successfully. (error
0)"
we show the more useful
"Capturing from a pipe doesn't support pcapng format."
Change-Id: I472c1bf5c8520c9ee3fe4b6299a6e0250262ea51
Reviewed-on: https://code.wireshark.org/review/19876
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d5b053d26c2e7638d6d35af97b4c8c…
commit d5b053d26c2e7638d6d35af97b4c8c7b7fe9f3ea
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Jan 30 14:07:55 2017 +0100
Qt: Use system DateTimeFormat in QDateTimeEdit
In extcap argument ExtArgTimestamp set DisplayFormat to system DateTimeFormat.
Change-Id: I281d6cc1aa59e785a75d6f1c8ff9780ba5ad9eba
Reviewed-on: https://code.wireshark.org/review/19863
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=07c1832e8522ee81db804d301d525e…
commit 07c1832e8522ee81db804d301d525e22284bf62d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Jan 30 11:07:36 2017 +0100
Remove unused variable initialization.
Change-Id: I674afef24938f3b860171d87640a6228ee042e82
Reviewed-on: https://code.wireshark.org/review/19862
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=bde544196edc5d47edfcb4d243fb73…
commit bde544196edc5d47edfcb4d243fb7349f1f1fa2a
Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Date: Wed Jan 11 19:49:14 2017 +0100
ZigBee: Add attribute and command names from Metering used with GBCS.
The Great Britain Companion Specification specifies how energy meters
will communicate in the UK. This patch adds names for attributes and
commands from the Smart Energy Metering cluster that are used within
that specification.
Futhermore take care of Change 19481 for ZigBee Smart Energy.
Bug: 13360
Change-Id: Ia229265f9dc2168c8977303f3540c2ffc1bb5a0a
Reviewed-on: https://code.wireshark.org/review/19768
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f789c91a5ebbbefba51aa3da983fe8…
commit f789c91a5ebbbefba51aa3da983fe836ebc860d6
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 29 18:51:00 2017 -0500
Have format_text_wsp use wmem allocated memory.
format_text_wsp is fed into by tvb_format_text_wsp and tvb_format_stringzpad_wsp
so those functions need to add a wmem allocated parameter as well.
Most of the changes came from tvb_format_text_wsp and tvb_format_stringzpad_wsp
being changed more so than format_text_wsp.
Change-Id: I52214ca107016f0e96371a9a8430aa89336f91d7
Reviewed-on: https://code.wireshark.org/review/19851
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9365fd3d3a4cdac07d70bd77f7a42f…
commit 9365fd3d3a4cdac07d70bd77f7a42f3260b33b5e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 28 22:29:32 2017 -0500
Convert GHashTable -> wmem_map_t for ASN.1 disseectors
Change-Id: Id749c41947c6300f2c82ed947352c336f9e45b72
Reviewed-on: https://code.wireshark.org/review/19838
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=984d78da13608b7cba3cd8144d1285…
commit 984d78da13608b7cba3cd8144d1285b33277b0d3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jan 29 17:16:53 2017 -0800
Clean up indentation.
Change-Id: I0815bf008ed056e3cd400a24fb10abb4ca88c3ce
Reviewed-on: https://code.wireshark.org/review/19854
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c44c8f9e6c7b633eae3129c58aab99…
commit c44c8f9e6c7b633eae3129c58aab991ddc8678ed
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 29 14:19:25 2017 -0500
Have format_text_chr use wmem allocated memory.
Change-Id: Idcea59f6fc84238f04d9ffc11a0088ef97beec0c
Reviewed-on: https://code.wireshark.org/review/19844
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b3035df88796e0e9058b315791861b…
commit b3035df88796e0e9058b315791861b03b3b59af7
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Jan 27 22:30:34 2017 +0100
(D)TLS: fix type of record sequence number
The record sequence number is 64-bit, not 32-bit. This applies to all
SSLv3/TLS/DTLS versions. Without this fix, after about four million
records, the wrong MAC is calculated (for TLS 1.2) or decryption will
fail (for TLS 1.3).
Change-Id: I05e5e8bc4229ac443a1b06c5fe984fb885eab1ca
Reviewed-on: https://code.wireshark.org/review/19824
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=9fb9bc52bbed0b8be199e0f3ea21c6…
commit 9fb9bc52bbed0b8be199e0f3ea21c6e543cde2ab
Author: AndersBroman <a.broman(a)bredband.net>
Date: Sun Jan 29 22:09:15 2017 +0100
Use g_list_prepend, it's more efficient.
Change-Id: Ic13f60a3e700f3d8325063079f032eda47eaf22f
Reviewed-on: https://code.wireshark.org/review/19848
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9b7ccdc8cc94a813ceee0b64844289…
commit 9b7ccdc8cc94a813ceee0b6484428951580f3d0d
Author: Moshe Kaplan <me(a)moshekaplan.com>
Date: Sun Jan 29 14:04:26 2017 -0500
Fix typo in autogen.sh
Change-Id: I7048dc9bf49a1e83302563db269c6a89a17c6df0
Reviewed-on: https://code.wireshark.org/review/19843
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=4aa8d58911615f4649ad8bf0c2d8b0…
commit 4aa8d58911615f4649ad8bf0c2d8b0e164f14583
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Jan 29 08:10:45 2017 -0800
[Automatic update for 2017-01-29]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I4a55af48f03ec5940c2a5fd902a57c7b06ac0e37
Reviewed-on: https://code.wireshark.org/review/19839
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=af54b292e60fcdd8d03ec583e2b46c…
commit af54b292e60fcdd8d03ec583e2b46c9c51f259a5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 28 19:53:36 2017 -0500
Register reassembly tables
Register all reassembly tables with a central unit, allowing the
central unit to have the callback that initializes and destroys
the reassembly tables, rather than have dissectors do it individually.
Change-Id: Ic92619c06fb5ba6f1c3012f613cae14982e101d4
Reviewed-on: https://code.wireshark.org/review/19834
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ed8ac81497c890bc82f161be727c0b…
commit ed8ac81497c890bc82f161be727c0bb5285dcf12
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jan 24 13:53:57 2017 +0100
ipx: Convert GHashtable to wmem_map
Change-Id: If7994b2bc5d341f381e0f15a0d6179ad73bf9367
Reviewed-on: https://code.wireshark.org/review/19763
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3dd6e2c84900d208309157f7d07fe1…
commit 3dd6e2c84900d208309157f7d07fe17d7787259f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Jan 26 14:11:35 2017 +0100
ssl: add expert info for unexpected messages in TLS 1.3
This will also avoid invoking ssl_finalize_decryption which will not be
used for TLS 1.3.
Change-Id: I958508276488764ad1a82e6412504bcd72f3b995
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19823
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4de1983b6db70dfba9edac08aef8df…
commit 4de1983b6db70dfba9edac08aef8df67641ac4eb
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 22 17:54:35 2016 -0500
Bugfix MPEG descriptor Logon Initialize Descriptor tag.
Do length checks in case not all fields are present to prevent
malformed packets.
Bug: 13237
Change-Id: Ie7cc3006fa33f1dedeffb09a4f35adb8dee8e9f6
Ping-Bug: 13238
Reviewed-on: https://code.wireshark.org/review/19390
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=55703ad80dfed25db348796c725782…
commit 55703ad80dfed25db348796c7257827e0765779b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 28 17:44:50 2017 -0800
Fix decoding of T.30 over T.38.
In change 9bcac48403de9aff6435d0f48028ae1f72f64528, "t30.hdlc" was
inadvertently changed to "t30.hdlc""rtp"; this meant that we
didn't
actually find the T.30 dissector, as we were looking for it under the
name "t30.hdlcrtp".
Change-Id: Ic1c1daf558926afdb43ac9220940f3ac0159d247
Reviewed-on: https://code.wireshark.org/review/19835
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=39e30aa51d99073d0730a53591cb69…
commit 39e30aa51d99073d0730a53591cb692d71b6bb6c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 28 16:51:32 2017 -0800
Allow Decode As for T.38-over-TCP and T.38-over-UDP.
This got lost as part of change 9132706b2dca67c4991edf0f3779d1d43d4b3f65
- that removed the explicit registering, with a port number, in the
tcp.port and udp.port dissector tables, *without* replacing it with a
dissector_add_for_decode_as() registering it *without* a port number.
Change-Id: I9ae22418553c143d51f9a78f5c0901f2f6490351
Reviewed-on: https://code.wireshark.org/review/19832
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e4c1e42a169f6f4214ff25be75d6b1…
commit e4c1e42a169f6f4214ff25be75d6b108ba4f1281
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 28 21:55:52 2017 +0000
Revert "Check whether we need -lm for fmod."
This reverts commit aaac50cfde090f4c7e71472ae8bf8e8ea67a1d44.
Not clear that this is the problem.
Change-Id: I5a0547eb4fda1a1ac7a6548c75ba6bc5e4b82d61
Reviewed-on: https://code.wireshark.org/review/19830
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=aaac50cfde090f4c7e71472ae8bf8e…
commit aaac50cfde090f4c7e71472ae8bf8e8ea67a1d44
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 28 13:07:27 2017 -0800
Check whether we need -lm for fmod.
Apparently, fmod may be in -lm even if cos isn't.
Change-Id: Ifef1246ccd1ae1e17e4bbbab120c6181092c7786
Reviewed-on: https://code.wireshark.org/review/19827
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9bf42ae4dc0f7d5dcb6b61754777e9…
commit 9bf42ae4dc0f7d5dcb6b61754777e968ee43ba02
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Jan 22 21:30:41 2017 +0100
tcap: convert GHashTables into wmem.
Change-Id: I95509cada53d363320a5a5d9e36612d7a85d7ef3
Reviewed-on: https://code.wireshark.org/review/19741
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d94d7fc3a09e1c64349588950e8b64…
commit d94d7fc3a09e1c64349588950e8b644e130b0845
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 28 09:34:04 2017 -0500
wmem_map_new -> wmem_map_new_autoreset
A few dissectors can benefit from the conversion.
Change-Id: I3b7d54926b79314009e271960aff61870a115390
Reviewed-on: https://code.wireshark.org/review/19826
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=120a1ebb2264c7b13cf20a9c8e9db3…
commit 120a1ebb2264c7b13cf20a9c8e9db37e9a125743
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 28 12:31:29 2017 -0500
wmem: Delay creation of map table until its needed
wmem_map_new_autoreset(wmem_epan_scope(), wmem_file_scope(), ...)
doesn't have "file" scope ready at startup to create hash table
and will assert.
Change-Id: I3437f45ef42bf8635e4d504cf073fc3fb0c9a8cd
Reviewed-on: https://code.wireshark.org/review/19825
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8f81dd4f8274c2bd9b8438a59cbe23…
commit 8f81dd4f8274c2bd9b8438a59cbe232c09f5e573
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Jan 25 21:52:27 2017 +0100
TLS: fix decryption of renegotiated sessions
Renegotiated sessions may interleave application data with handshake
records. These handshake records should however not be included in the
flow associated with the application data. This fixes a regression in
the previous patch, now the "1.12 Step: SSL Decryption (renegotiation)"
test passes again.
Also remove duplicate DTLS data sources for decrypted records.
Change-Id: I46d416ffba11a7c25c5a682b3b53f06d10d4ab79
Fixes: v2.3.0rc0-2152-g77404250d5 ("(D)TLS: consolidate and simplify decrypted
records handling")
Reviewed-on: https://code.wireshark.org/review/19822
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0ce7b55fb4e3a3819135702f8c2baf…
commit 0ce7b55fb4e3a3819135702f8c2baf88b979df73
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 24 08:27:58 2017 -0500
qsig: Remove unnecessary hash table functionality
The information from qsig_opcode2oid_hashtable could be derived directly from
qsig_op_tab, and get_op() can serve as a lookup instead of qsig_oid2op_hashtable.
Change-Id: Ibc5b20ff9ff46b1644c6a6c2c90ee1c4ac131e45
Reviewed-on: https://code.wireshark.org/review/19743
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6cff5c6776f08eb3d580eba9c9441c…
commit 6cff5c6776f08eb3d580eba9c9441c64f267923b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jan 25 23:07:23 2017 -0500
Add wmem_map_new_autoreset
This can be used similarly to wmem_tree_new_autoreset for hash tables that need
reset after capture file change.
Change-Id: I3a2f0b0a0cad3eca46266523c594d3d7aac17489
Reviewed-on: https://code.wireshark.org/review/19794
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Evan Huus <eapache(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=618df2460abdb0ee2d3e934f63de6b…
commit 618df2460abdb0ee2d3e934f63de6b6a526e5800
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Jan 28 12:47:47 2017 +0100
decode_as: Initialize decode_as_list after free
Initialize decode_as_list = NULL after free to avoid random crashes
in g_list functions after changing profile.
This bug was introduced in g5c7b0b96
Change-Id: Ibc752f245115c5a426989e20e0ab9d0f0faac43d
Reviewed-on: https://code.wireshark.org/review/19821
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=a949d7887cd60ebfe1d81e1adbab92…
commit a949d7887cd60ebfe1d81e1adbab920bb1d288d2
Author: Anders Broman <a.broman58(a)gmail.com>
Date: Sat Jan 28 10:29:52 2017 +0000
Revert "MPLS: relax pw_eth_heuristic and improve 1st nibble logic"
This reverts commit 01ddd93a7296b54a2048de74691984a7e78e4cb9.
Change-Id: I90f19fec52d3f1edc63fd00e614173a0154503d4
Reviewed-on: https://code.wireshark.org/review/19820
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1bfa581529e8edcaeaf842a87726ad…
commit 1bfa581529e8edcaeaf842a87726ad6734d72292
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Jan 22 09:01:33 2017 -0800
Snort: add a preference to show alert in reassembled frame
Change-Id: Ia29d451857995b186c88193c9722ae156eb3f66d
Reviewed-on: https://code.wireshark.org/review/19729
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=01ddd93a7296b54a2048de74691984…
commit 01ddd93a7296b54a2048de74691984a7e78e4cb9
Author: Francesco Fondelli <francesco.fondelli(a)gmail.com>
Date: Tue Jan 10 08:54:52 2017 +0000
MPLS: relax pw_eth_heuristic and improve 1st nibble logic
relax pw_eth_heuristic and, at the same time, improve
the 1st nibble logic in dissect_mpls in order to disambiguate
between Ethernet pseudo-wire without a control word, with the MAC
address's first nibble being 4/6 and IPv4/6 packet.
Bug: 13301
Change-Id: If4697c2e40271d84e2db11a9f64ee60a8657e164
Signed-off-by: Francesco Fondelli <francesco.fondelli(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/19599
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ac68c43414ddd12cdfc24ea459846f…
commit ac68c43414ddd12cdfc24ea459846fc86a2d135c
Author: Adam Mitz <mitza(a)ociweb.com>
Date: Mon Jan 23 14:16:08 2017 -0600
Updated parsing of ParticipantMessageData submessages.
Zero-length octet sequences don't need to show <MISSING> for their
contents.
Change-Id: I89662ff8cd29563981ba9e1b34dc82023b6a070e
Reviewed-on: https://code.wireshark.org/review/19755
Reviewed-by: Juan Jose Martin Carrascosa <juanjo(a)rti.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ee185445f410b6bc54831ea0923af0…
commit ee185445f410b6bc54831ea0923af08cbcd75d00
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 24 23:06:04 2017 -0500
rtmpt: Ensure sequence count is incremented for stored fragments
Bug: 13347
Change-Id: I351c80dea8ac7a9f2540b40782b1cc5c0b8fdaed
Reviewed-on: https://code.wireshark.org/review/19777
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=77404250d53a4b123f05c834108e23…
commit 77404250d53a4b123f05c834108e231a8885305a
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Jan 25 21:52:27 2017 +0100
(D)TLS: consolidate and simplify decrypted records handling
Previously there was a distinction between decrypted handshake
Application Data records ("Decrypted SSL data") and some others (like
Alerts, Handshake and Heartbeat, "Decrypted SSL record"). Remove this
distinction and always decrypt the payload before passing it on and
always display a data sources for decrypted contents ("Decrypted SSL").
This is prepatory work for TLS 1.3 support where the content type is
located in the encrypted record, having the record decryption in one
place makes it easier to adapt.
Change-Id: I92c51c7f9e87e5c93231d28c39a8e896f5afd1ef
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19789
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=990b5dc14c41fc3be69f9f8894f73d…
commit 990b5dc14c41fc3be69f9f8894f73d375d0d7db9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Jan 27 21:20:51 2017 +0100
Qt: Add exported packet files to the recent files
Update the recent files list when exporting specified packets to file.
Change-Id: I4e7dd7f943aa99ab9d5f3fd88444d730434970e9
Reviewed-on: https://code.wireshark.org/review/19818
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=26d930f147f55945febabf450d8077…
commit 26d930f147f55945febabf450d8077fbf7565a67
Author: Jordan Keister <grokspawn(a)gmail.com>
Date: Thu Jan 26 16:55:51 2017 -0600
GPTv2: add CIoT optim support indication and ePCO IEs dissection
Change-Id: I87239a5af8476c1285e68cfbd45e62b89f1440eb
Reviewed-on: https://code.wireshark.org/review/19808
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=784bd04e417395c3b54e51b5179c35…
commit 784bd04e417395c3b54e51b5179c352a26c959cb
Author: Thomas PORTASSAU <thomas.portassau(a)hotmail.fr>
Date: Fri Jan 27 09:31:57 2017 +0100
Delete unsed variable in ccid
Change-Id: I4c9eff4248f25c15ef4d525e0a4360bf3bdb480c
Reviewed-on: https://code.wireshark.org/review/19813
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=6d4e340de32e062b00be505188edf1…
commit 6d4e340de32e062b00be505188edf15d13111632
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jan 27 08:10:56 2017 +0100
sharkd(session): Fix Value stored to 'frame' during its initialization is
never read
Change-Id: Ia7e351167edc0ca5c48e284bee0c940bba12c6d7
Reviewed-on: https://code.wireshark.org/review/19812
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b5fe13f57dd5622035f3b5465d32c0…
commit b5fe13f57dd5622035f3b5465d32c0f2a016bec8
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jan 27 07:02:34 2017 +0000
dicto (RFC5580) fix typo
From FreeRADIUS
typo. Fixes https://github.com/FreeRADIUS/freeradius-server/pull/1882
Alan T. DeKok@2017-01-18T18:09:05Z
Files modified:
* share/dictionary.rfc5580
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f22f1bf53c3a316865cc…
Change-Id: I7f64d97352a453ff22dac45e9e9737af80fc1b2c
Reviewed-on: https://code.wireshark.org/review/19811
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6313e96e27e56f3a1d2bfd977487d9…
commit 6313e96e27e56f3a1d2bfd977487d998565f8c2e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Jan 25 10:57:49 2017 +0100
Qt: Hide "Go to Packet" frame when closing capture file.
The "Go to Packet" frame cannot be used without a capture file so
ensure we hide this when closing a capture file.
Change-Id: I339bc90b87181a8361e9f0bf27dfdf26d2f05333
Reviewed-on: https://code.wireshark.org/review/19783
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7f4d8491f32a0bb8ea37376443429e…
commit 7f4d8491f32a0bb8ea37376443429e162ea6cd86
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Jan 23 09:18:53 2017 +0100
prefs: Preserve UTF-8 characters in preferences.
When saving preferences the strings in string lists must not be
escaped with g_strescape() because this will destroy UTF-8 characters.
Because this strings only should use printable characters we manually
escape quote and backslash, and skip non-printable.
Bug: 13342
Change-Id: I57e492dff746a5ecc0aee809f946a615ad110b4d
Reviewed-on: https://code.wireshark.org/review/19738
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87f4dc0a9d22060d379db2daa3f427…
commit 87f4dc0a9d22060d379db2daa3f4271137a4edcc
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Jan 25 20:28:34 2017 +0100
Qt: Preference editor improvements.
Use correct disconnect() signature to ensure everything is disconnected
before connecting new signals. Without this all previous connects() are
still active. This leads to gradually more and more syntax checks being
called for each change, and possibility of a wrong syntax check
(especially for strings which has no syntax check).
Use the textEdited() signal to trigger a syntax check at startup.
This gives consistency.
Do not clear preferenceLineEdit when done because it looks weird when
the preference text disappears while the widget is hiding. The entry
is cleared before next show anyway.
Change-Id: I21c6fd8ec6bb0ecff1b2c0b66fe97dc3eaecf9b3
Reviewed-on: https://code.wireshark.org/review/19788
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc86242e3e158adbc99371acf4c99d…
commit dc86242e3e158adbc99371acf4c99d4e06e57a1a
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Jan 26 12:07:49 2017 +0100
ssl-utils: recognize new TLS 1.3 keylog format
Implemented by BoringSSL, an older description can be found at:
https://github.com/google/boringssl/commit/e776cc29568e520aaabc83188cc7db79…
Implementation pending at OpenSSL:
https://github.com/openssl/openssl/pull/2287
NSS bug (still open):
https://bugzilla.mozilla.org/show_bug.cgi?id=1287711
Proposal for PicoTLS:
https://github.com/h2o/picotls/issues/6
Change-Id: Ib597f48e296d286d8f6d30873ca03e7d6324a3c4
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/19801
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9f600384e8c113c43a069d491a7482…
commit 9f600384e8c113c43a069d491a7482c402c1ea8d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Jan 25 15:35:09 2017 +0100
sharkd: fix potential division-by-zero issue
The interval parameter is user-supplied and is used as divisor.
Change-Id: I9cbbecb71da3991c1712cb87e93de072cc950224
Reviewed-on: https://code.wireshark.org/review/19787
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=69c29d77cf9d4b4b852f0ecabc8a0b…
commit 69c29d77cf9d4b4b852f0ecabc8a0b67b2954c33
Author: Thomas PORTASSAU <thomas.portassau(a)hotmail.fr>
Date: Tue Jan 24 03:26:58 2017 -0500
CCID added dwFeatures, bStatus bitmasks and IFSD in class description
Change-Id: I2855c83c6b5e9add3f34d72a2f2ed3394bf79b78
Reviewed-on: https://code.wireshark.org/review/19761
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ffea2f8a24947a9293e3d4986440ed…
commit ffea2f8a24947a9293e3d4986440edf5e4589685
Author: dsrsupport <eugene.exarevsky(a)dsr-company.com>
Date: Thu Jan 26 13:09:54 2017 +0300
ZigBee: fix endian for File Version field in OTA
That field parsed as Big Endian, while all data in ZigBee is Little Endian.
Not change to LE.
Change-Id: I782ba5d17ca9f2208dc4e2f08ca2c731f4d683e4
Reviewed-on: https://code.wireshark.org/review/19800
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d66ee141af70df7809ef9f48d19f75…
commit d66ee141af70df7809ef9f48d19f75469f64a0b4
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Thu Jan 26 09:25:25 2017 +0100
Qt: Signal number of active captures
Adds a signal, which emits the number of active captures
Change-Id: I637106294e331e7fc7607f6fd7704492e22fa7ac
Reviewed-on: https://code.wireshark.org/review/19799
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=795b5d44e5a091b9f87d7ea8aac470…
commit 795b5d44e5a091b9f87d7ea8aac4701077807bc3
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Jan 24 19:42:18 2017 +0100
Add 'in' operator in display filter expression dialog
Add the 'in' operator to the list of available operators, where 'eq'
operator would be present also. Setup the curly bracket expression in
the filter and allow for multiple enums to be selected.
Ping-Bug: 12808
Change-Id: Ibeef52ba9d41549d0684b0069270ff09f5a93e81
Reviewed-on: https://code.wireshark.org/review/19767
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6a99a2ce431a1b9188cd83c70dc16c…
commit 6a99a2ce431a1b9188cd83c70dc16cd62cefead4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 25 23:15:13 2017 -0800
Cast arguments to socklen_t.
That should squelch some warnings on Windows.
Change-Id: I55b394be12203e14af023fdcc5d46564d0fcfa34
Reviewed-on: https://code.wireshark.org/review/19797
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5fbcfd632a7446da946a8b1e27004a…
commit 5fbcfd632a7446da946a8b1e27004a401b8d74f3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 25 22:20:07 2017 -0800
Clean up some UN*X-vs-Windows socket issues.
Have a wsutil/socket.h file, for inclusion by everything that uses
sockets, that contains the UN*X-vs-Windows #includes and #defines to
hide some UN*X-sockets vs. Winsock API differences. That stuff mostly
comes from from extcap/extcap-base.h; have that file just include
wsutil/socket.h rather than defining that stuff itself.
Include it in sharkd_daemon.c. Use socklen_t for the size of things to
pass to bind() as the last argument; wsutil/socket.h defines it as int
on Windows.
Ignore sharkd in Git.
Change-Id: I3f2171b7aa613717f52305f62bfd7d43e0172dc6
Reviewed-on: https://code.wireshark.org/review/19796
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1165dfc8f6b2feead7c989508f38c8…
commit 1165dfc8f6b2feead7c989508f38c83f788b5afb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 25 21:29:54 2017 -0800
Make some variables 64-bit, to avoid overflows.
Assume that the relative milliseconds could be 64-bit, and make the
indices calculated from it 64-bit as well.
Change-Id: Ie1248c9440172b85ffbb05461ef1ee07c371fc3c
Reviewed-on: https://code.wireshark.org/review/19795
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=19028ebab4f3c097c8e87d3b532b80…
commit 19028ebab4f3c097c8e87d3b532b80a5c1369eae
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jan 25 20:27:13 2017 -0500
Fix sharkd compiling on Windows
Change-Id: I8c614189159f1263d9452d495cee34d1a2c1bfcb
Reviewed-on: https://code.wireshark.org/review/19790
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=eeab554cf2e1d893f144081a762cc5…
commit eeab554cf2e1d893f144081a762cc52782271e2e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 24 22:17:49 2017 -0500
ldss: Ensure ldss_file_request_t structure gets allocated
Bug: 13346
Change-Id: I83175fefeef5035039e378dd68ffdcd0787970b8
Reviewed-on: https://code.wireshark.org/review/19775
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ee177fedb4cdafe5c788b6972bac66…
commit ee177fedb4cdafe5c788b6972bac66ad6b316c94
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jan 25 12:21:06 2017 +0100
x11: add shutdown routine.
Change-Id: I22b64a10ab3d0dcaccbea775b03ef3f82797697f
Reviewed-on: https://code.wireshark.org/review/19784
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0385a09739d24f1b7b47ee07ee26fd…
commit 0385a09739d24f1b7b47ee07ee26fd91d18b7d55
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Jan 25 10:38:49 2017 +0100
Qt: Use preference editor for port number entries
After converting port preferences to use Decode As entries the preference
editor was no longer used when changing port number pereferences from the
Packet Details popup menu.
Change-Id: Ifeff3b88bfd96a122b6a58d8917304eb69cf0c38
Reviewed-on: https://code.wireshark.org/review/19781
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=53c7f0a25ee5b1419c1a87045e25ca…
commit 53c7f0a25ee5b1419c1a87045e25ca11ec12f9b1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Jan 25 15:06:42 2017 +0100
CMake,autotools: remove unneeded files, fixes build
sharkd does not perform any capturing, so do not include related
libraries and files. This fixes the CMake build too.
Change-Id: Ie002b09dbf60070e34dacc8ae7dadee6690d4db8
Reviewed-on: https://code.wireshark.org/review/19786
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bceb614d15126f3903839c78987574…
commit bceb614d15126f3903839c789875745548730015
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jan 25 10:53:16 2017 +0100
sharkd: add cmake option.
Change-Id: I4f961061f67aab86270f03c8f320245cf80ab70e
Reviewed-on: https://code.wireshark.org/review/19782
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cfe7b85b86455e1d62f4c914836ee5…
commit cfe7b85b86455e1d62f4c914836ee5baf18831d4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 24 22:40:07 2017 -0500
wsp: Sanity check capability length
Bug: 13348
Change-Id: I64abc79475087f1c971419629b5c86e646123f3f
Reviewed-on: https://code.wireshark.org/review/19776
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=29d0f40d44d21f539f8d0a94725812…
commit 29d0f40d44d21f539f8d0a94725812cdb9a9435d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 25 00:08:16 2017 -0800
Put sharkd.h into the distribution.
Change-Id: I0e831a5448fc6247ccca033ae512a3fa74351c63
Reviewed-on: https://code.wireshark.org/review/19779
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e2930f3b78cd47ac4044f3ece059e7…
commit e2930f3b78cd47ac4044f3ece059e7dbe83f3f02
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Oct 15 20:48:17 2016 +0200
Add sharkd - daemon variant
sharkd listens on UNIX socket and allows external clients
to run commands like: loading file, analysing frames or running TAP(s).
Change-Id: I443b2865e4adfd1c11f4f57d09ff7fce6b1e8766
Reviewed-on: https://code.wireshark.org/review/18208
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=11574208e7f11d76bb1dbe46057739…
commit 11574208e7f11d76bb1dbe460577396b8c06e3fb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 19:42:11 2017 -0800
Clean up EVPN NLRIs dissection.
Do the NLRI length checks in the switch cases for each route type, and
do them for *all* route types, rather than throwing a random check in
for one particular route type.
There is no need to fail up front for unknown route types; at least
dissect the type and length, and fail in the switch statement.
Dissect the route descriptor in each of the switch cases, after the
length check, rather than doing it up front.
Add a comment noting where the prefix route type comes from.
Change-Id: Iae26ecd467d4b36dbcf52e7998bd2881405281aa
Reviewed-on: https://code.wireshark.org/review/19774
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=538b6fc206e202ea666444b77f98b4…
commit 538b6fc206e202ea666444b77f98b4f19947f8ec
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 18:48:19 2017 -0800
Add URL for the AoE spec.
Change-Id: I6e4fc624e6b4270a1db2b680e4d449c504bd56ee
Reviewed-on: https://code.wireshark.org/review/19773
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2e01a940287b37195712f7c534dd18…
commit 2e01a940287b37195712f7c534dd18d9aeb0f45c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 17:30:00 2017 -0800
That field is a route type, not an address family identifier.
Change-Id: I547dd12479b9634d8176eca9fd2ae6c9e1f87981
Reviewed-on: https://code.wireshark.org/review/19772
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=61de3e581f911dccc2b4c4df73a467…
commit 61de3e581f911dccc2b4c4df73a467d06a86362a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 16:50:45 2017 -0800
Clean up and update list of RFCs and I-Ds supported.
Change-Id: Ided8496b1d57a7906c805bca4ed848903d553721
Reviewed-on: https://code.wireshark.org/review/19771
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7c014c044e2716b0a3dfa832ecad83…
commit 7c014c044e2716b0a3dfa832ecad83262c93fbc0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 16:40:13 2017 -0800
Update comment, clean up identation.
Change-Id: I30812657e3fa5dc21e64ed2fb7605e5f2a36ab03
Reviewed-on: https://code.wireshark.org/review/19770
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1ee1e14a78a7d77ba85274f9eba380…
commit 1ee1e14a78a7d77ba85274f9eba380b6b06242a6
Author: Erik de Jong <erikdejong(a)gmail.com>
Date: Mon Dec 12 21:49:39 2016 +0100
Dissector: IndigoCare nursecall protocols support
Adds support for IndigoCare nursecall protocols
Bug: 13241
Change-Id: I83098c15d467ea42da8301c6b6a5568d9892fc60
Reviewed-on: https://code.wireshark.org/review/19224
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4e2b2d4292243f13e5fe1638a12704…
commit 4e2b2d4292243f13e5fe1638a12704d43dbd07df
Author: Adam Mitz <mitza(a)ociweb.com>
Date: Mon Jan 23 14:15:42 2017 -0600
RTPS: avoid errors when encountering empty sequences of strings
Change-Id: Ida9d2e6d632104ec3c6594f5ec500fec49a971a4
Reviewed-on: https://code.wireshark.org/review/19754
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87f24a78e62431bbe0e22c1e7f42e1…
commit 87f24a78e62431bbe0e22c1e7f42e1e94c1d79b0
Author: Adam Mitz <mitza(a)ociweb.com>
Date: Mon Jan 23 14:15:19 2017 -0600
RTPS: updated ContentFilterProperty field names to match the spec
Change-Id: I17a8b51dbcb502624a83177135b31fdbe72fa118
Reviewed-on: https://code.wireshark.org/review/19753
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=68fd576529f6d4804b22fe18f59bb1…
commit 68fd576529f6d4804b22fe18f59bb1f411fe8cea
Author: ruengeler <ruengeler(a)wireshark.org>
Date: Mon Jan 23 17:04:50 2017 +0100
Fix segfault, when only one TSN is captured
Change-Id: Ibb6494e1f180ec8187d260245731d33ac16085eb
Reviewed-on: https://code.wireshark.org/review/19745
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d284cfd4a622922f37bd964575b7d3…
commit d284cfd4a622922f37bd964575b7d3a0e78b7db5
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Jan 22 21:25:13 2017 +0100
dvbci: add shutdown routine.
Change-Id: I3f950ce227818b6dae11ac89e4a8ec636294a6ec
Reviewed-on: https://code.wireshark.org/review/19740
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7b69c8702b30e76189a652b7853643…
commit 7b69c8702b30e76189a652b7853643fdbc506a22
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 24 01:15:24 2017 -0800
Add a comment talking about the dictionary file format.
Point to the FreeRADIUS man page for the dictionary file format, and
mention features we don't support - including features *not* documented
in the man page.
Change-Id: I08085062a6abcafb9dd0abe5b1edee53187ea23f
Reviewed-on: https://code.wireshark.org/review/19762
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c3013565b14df28251bd2f51c1af94…
commit c3013565b14df28251bd2f51c1af9418833996e4
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Mon Jan 23 21:58:10 2017 +0100
WSUG: Display filter: add matches, contains, bitwise_and
Added examples for the matches, contains and bitwise_and operators.
Most of the text and the examples have been taken from the wiki and the
wireshark-filter manpage.
Bug: 13320
Change-Id: Icd9a325c05ecd4ecd1cbde8162a4c88cae335d1d
Reviewed-on: https://code.wireshark.org/review/19758
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=288fb5e9b43c34271be3be0ca7c0c2…
commit 288fb5e9b43c34271be3be0ca7c0c287323e7834
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 23 12:11:51 2017 -0800
Fuzz: Fix the capinfos check (again).
Capinfos might return 1 *or* 2 for an invalid capture.
Change-Id: I1ff2ed2a5b252a77a894ad3fe10c983e9a2a1bc0
Reviewed-on: https://code.wireshark.org/review/19752
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=57894f741f7cc98b46c9fdce7eee82…
commit 57894f741f7cc98b46c9fdce7eee8256d2a4ae3f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 23 10:09:33 2017 -0800
DHCPv6: Avoid integer overflows.
Count using ints instead of guint16s.
Make sure dissect_packetcable_ccc_option and
dissect_packetcable_cccV6_option return positive values while we're
here.
Bug: 13345
Change-Id: Ic303ddc266f46ee3144e079731742c85808faf37
Reviewed-on: https://code.wireshark.org/review/19747
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=9cece7c081c476020ebec28934b72f…
commit 9cece7c081c476020ebec28934b72f04fe39d1d1
Author: Gerald Combs <gerald(a)zing.org>
Date: Mon Jan 23 07:43:59 2017 -0800
GTK+: Yell at the user less.
Change some exclamation points in error and warning messages to periods.
Change-Id: Ie084c40cf54362b43462bf4f6a29134caa101387
Reviewed-on: https://code.wireshark.org/review/19744
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=781f03580c81339513bb1238b202b7…
commit 781f03580c81339513bb1238b202b72469a1240b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jan 23 09:43:33 2017 -0800
ASTERIX: Avoid an integer overflow.
Count using a guint instead of a guint8.
Bug: 13344
Change-Id: Ic7d337dbb29b92ebb8332f50fd47b5ba2aa3f41e
Reviewed-on: https://code.wireshark.org/review/19746
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b70929e95b719627163495eeae4233…
commit b70929e95b719627163495eeae4233549188d34d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Jan 23 07:52:24 2017 +0100
tcp_graph (Gtk) Fix Dereference of null pointer
Change-Id: Ie07ed9f2bcf719340ea607d679620916aa93ba72
Reviewed-on: https://code.wireshark.org/review/19736
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6eca591de622092c428b27ccd24854…
commit 6eca591de622092c428b27ccd248548097d73d6a
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 23:27:17 2017 +0100
tools: allow multiple suppression file for valgrind.
Change-Id: I7074705230deb3d24df8f2ea694a3a485c848efd
Reviewed-on: https://code.wireshark.org/review/19711
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=110ffacdb34e895d92764428519baf…
commit 110ffacdb34e895d92764428519baf385695142f
Author: MustBeArt <paul(a)mustbeart.com>
Date: Fri Jan 20 13:04:59 2017 -0800
DVB-S2-BB: Support all four MA modes
Support all four mode adaptation input and output interfaces defined in
SatLabs reference document sl_561, "Mode Adaptation Input and Output
Interfaces for DVB-S2 equipment", instead of only the two modes that use
a sync byte.
There is nothing in the packet format that specifies which format is in
use, so we have to guess based on the possible occurrence of a sync byte
and the CRC-protected BBHEADER that follows the mode adaptation header,
which is a different length for each format. This is a heuristic dissector,
so if none of the four formats match, we just return.
Unfortunately, the BBHEADER CRC is only 8 bits, so there can be false
matches rather often. We detect when the packet matches more than one format,
and issue an expert info diagnostic. It is also possible for a UDP packet
that isn't DVB-S2 at all to match spuriously, with probability around 1%
(assuming random data). This is acceptable for a heuristic dissector,
especially one that is initially disabled.
Standardize spelling per sl_561: adaption -> adaptation
Change-Id: Iffc73ed01c72d1247e2378d648ffe0d7c1f21612
Reviewed-on: https://code.wireshark.org/review/19708
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=82b61bb40486ba851aee082e6b5915…
commit 82b61bb40486ba851aee082e6b59155dd38e724d
Author: Gerald Combs <gerald(a)zing.org>
Date: Sun Jan 22 12:14:33 2017 -0800
Qt: Reject drag and drop if we're capturing.
Ignore drag enter events in the main window and warn the user if we
can't open files (which presumably means we're in the middle of a
capture).
Don't yell at the user in the corresponding GTK+ code.
Change-Id: Iffb5df5969c7ff76a854247b4b8d10d0e4b02e70
Reviewed-on: https://code.wireshark.org/review/19734
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=936ebfe2ed549f59027905520412d3…
commit 936ebfe2ed549f59027905520412d31d5cdde1f7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jan 19 23:52:25 2017 +0100
ISAKMP: Add Fortigate (Fortinet) Vendor ID
Display also release (and build)
Change-Id: Ib97f47a0b0179712a82f0aee0ca079a05b8b590c
Reviewed-on: https://code.wireshark.org/review/19730
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=308e1de5ebba8bae4a7294f0f7e24e…
commit 308e1de5ebba8bae4a7294f0f7e24ed4c82de2be
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 22 11:19:13 2017 +0100
DNS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ib376127546aa15806ed37a7c26fe29b0fa80225c
Reviewed-on: https://code.wireshark.org/review/19722
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=59d2081cbb051d34b43240f5310a49…
commit 59d2081cbb051d34b43240f5310a494d45213996
Author: Benoît Canet <benoit(a)scylladb.com>
Date: Sun Jan 22 15:57:10 2017 +0100
CQL: Add support for prepared batch statement
This portion of the code was never completed.
Complete it.
Change-Id: Iaa139b8c6d50a5ce3a7039000e9af38fab3d6124
Signed-off-by: Benoît Canet <benoit(a)scylladb.com>
Reviewed-on: https://code.wireshark.org/review/19725
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=73182229a07958bbfde10ab113c13c…
commit 73182229a07958bbfde10ab113c13c734098d27e
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Fri Jan 20 15:02:22 2017 +0200
SMB2: better RSVD flow
Fixed FSCTL_QUERY_SHARED_VIRTUAL_DISK_SUPPORT dissector
to show fields of response properly - see
https://msdn.microsoft.com/en-us/library/dn409282.aspx
Mapped few SMB2 IOCTL codes related to RSVD to names
(like FSCTL_STORAGE_QOS_CONTROL that is defined by MS-SQOS
as a helper for RSVD protocol)
Added RSVD-specific SMB2 status codes
(used in SMB2 transport when RSVD is in use or inited)
See https://msdn.microsoft.com/en-us/library/dn392518.aspx
Change-Id: I04d80df234505e8b32773ac95cf0b73f07cc5581
Reviewed-on: https://code.wireshark.org/review/19693
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=79f3d8f40d8bb5e5465e4954dbe54b…
commit 79f3d8f40d8bb5e5465e4954dbe54beadef5dba7
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun Jan 22 13:20:56 2017 +0100
MAN wireshark-filter: Add ~ operator
The tilde (~) operator was missing as an alternative for matches.
Bug: 13320
Change-Id: Idb96c802145dcdd0d9ffc196b32370cadd8735b3
Reviewed-on: https://code.wireshark.org/review/19723
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=013125af034ea2282e15b80be4beeb…
commit 013125af034ea2282e15b80be4beeb9f19330f7a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 22 15:14:46 2017 +0100
reassemble: fix no previous prototype for ‘reassembly_table_free’
[-Wmissing-prototypes]
Change-Id: Idb4b821e013a79777897d2f837cb8c3861e3c85f
Reviewed-on: https://code.wireshark.org/review/19724
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=73d3f7965eedaeb398f19f3031f1bb…
commit 73d3f7965eedaeb398f19f3031f1bb16abe75ccd
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Jan 22 08:11:54 2017 -0800
[Automatic update for 2017-01-22]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I75ec9ed3b0ef02d18dee79f629291e7bc1c81467
Reviewed-on: https://code.wireshark.org/review/19726
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=799827b503a61d1b7c0306f2c987e4…
commit 799827b503a61d1b7c0306f2c987e42e7280b0a3
Author: Kevin Hogan <kwabena(a)google.com>
Date: Fri Jan 20 20:57:09 2017 -0800
Qt: Add Goodput graph (ACK rate), and minor bug fixes
Add Goodput graph:
- measures rate of ACKed bytes (including SACKed bytes)
- useful to compare to throughput during slow-start to estimate
bottleneck rate
Add graph selection checkboxes to multi-plot graphs:
- most important for Throughput, since there are good cases
for showing a subset of graphs at once
- also added for Window Scale, since the addition is similar
to that for Throughput
Minor bug fixes:
- allow zoom rect to work when growing in any direction
(not just right and up)
- keep stray mouse clicks from re-doing a previous zoom
- hide rubber band if active when keypress changes mouse mode
to drag
- allow mouse clicks on open space or grpah to return to default focus
(i.e. focus on graph)
Change-Id: Id29356ceec810ebdbed9c3c0d8415416401fe643
Reviewed-on: https://code.wireshark.org/review/19718
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=21a3b8cc71ac127e21375c62e0a738…
commit 21a3b8cc71ac127e21375c62e0a738db8f3ea286
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 7 08:52:23 2017 -0500
Internalize struct preference
Move "struct preference" into prefs.c, essentially creating a
"private"
structure to handle preferences. The 2 motivating factors were:
1. Better memory management so that clients/users of API don't have to worry
about it.
2. Hide the ugliness of the union stuff and make it transparent to the API.
A few bugs related to preference <-> Decode As integration were fixed
while in the neighborhood.
Change-Id: I509b9a236235d066b139c98222b701475e0ed365
Reviewed-on: https://code.wireshark.org/review/19578
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=76cf1d0b0a0b804b24bea6afb4a462…
commit 76cf1d0b0a0b804b24bea6afb4a4620a1607b144
Author: Roland Knall <rknall(a)gmail.com>
Date: Fri Jan 6 11:56:09 2017 +0100
Qt: Implement Custom CMake
Implement the custom cmake calls analog to the gtk version
Change-Id: I426d2a2df5a4bfb6fc385b970e3944415d3c8afd
Reviewed-on: https://code.wireshark.org/review/19563
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4ff9bddc4608cd6de1c729d1fbc39c…
commit 4ff9bddc4608cd6de1c729d1fbc39c9b49740c13
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Mon Jan 16 22:14:26 2017 +0100
wmem: fix rb-tree data printer feed
When using a data printer for the red/black tree it is fed with the
nodes of the tree. But nodes can be either subtree or data nodes.
Don't feed the subtree nodes to the data printer. The data printer can't
recognize it as such, can't handle it, or worse, could break stuff.
Change-Id: Ibbc1311d901c0d0c52e710f951dd53620f2c3d0f
Reviewed-on: https://code.wireshark.org/review/19652
Reviewed-by: Evan Huus <eapache(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b83bbd92b5763a29ef352fa2162496…
commit b83bbd92b5763a29ef352fa2162496c6ba3640b0
Author: Jim Young <jyoung(a)gsu.edu>
Date: Fri Jan 20 07:59:12 2017 -0500
packet-frame: Make interface_name a filterable field.
Change-Id: I1cc180abd7e73e5aea55b1b7eef9dc4b0e66e164
Reviewed-on: https://code.wireshark.org/review/19692
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7722003908ade4d36365c0a11e8a37…
commit 7722003908ade4d36365c0a11e8a37895edfc066
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 20 23:10:43 2017 +0100
DNS: use formatted text in add_rr_to_tree() and add_opt_rr_to_tree
Since the fix for bug 13289, an empty string can be returned by get_dns_name.
Ensure that:
- a malformed encoding with no characters and a length > 1 triggers an exception
- the formatted version is used to add info in tree.
Bug: 13339
Change-Id: I88125a351904eabb5cededfbfe1d5ef14ea61ecc
Reviewed-on: https://code.wireshark.org/review/19714
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=02127395981932bd6262d2107b7882…
commit 02127395981932bd6262d2107b78820ca4ace45b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 21 00:21:18 2017 -0800
One more cf_merge_files_to_tempfile() call needed to be changed.
Change-Id: Id109e316714fd1c4843f9ffe1b866ec0e5f5c126
Reviewed-on: https://code.wireshark.org/review/19719
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a5fe96e50a2e9602855f1b7f7507ed…
commit a5fe96e50a2e9602855f1b7f7507edff8aa381e6
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Jan 20 12:26:32 2017 -0800
Qt: Fixup drag and drop merging.
Make the behavior of MainWindow::dropEvent match the documentation and
dnd_open_file_cmd. If we've been passed a single file, open it. If we've
been passed multiple files, merge them first. Add an is_tempfile
parameter to openCaptureFile.
Add a note about setting the drop description on Windows.
Bug: 12129
Change-Id: I325a4da5a29e940b4efa7654627d8bcafba15b57
Reviewed-on: https://code.wireshark.org/review/19717
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=05fbb4826bcb182cc3895874a15585…
commit 05fbb4826bcb182cc3895874a15585a96703ce1f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Jan 20 16:05:56 2017 -0800
Qt: Show merge progress.
Add "file merge" callback plumbing. Use it to display "Merging
files" in
the main statusbar.
Make sure we have a usable window pointer when we merge files.
Change-Id: I236b6edb30685f0b06703ab8304bc88ae592f83c
Reviewed-on: https://code.wireshark.org/review/19716
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=317649f94984cf3d17f2a57badebb7…
commit 317649f94984cf3d17f2a57badebb78d7703cdb5
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 17:02:52 2017 +0100
reassemble: add cleanup routine.
Change-Id: I948d342a29aacc2212076359e5b073113c50c5de
Reviewed-on: https://code.wireshark.org/review/19697
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d020990f0356f4793e00209ae99e9f…
commit d020990f0356f4793e00209ae99e9f2dd7b843c9
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 14:52:05 2017 +0100
conversation_table: add cleanup function.
Change-Id: Icea963384c16b1ad5387a885219d0621b470181b
Reviewed-on: https://code.wireshark.org/review/19699
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fecf0d847e012bf4e73aa66da02166…
commit fecf0d847e012bf4e73aa66da02166774acba65d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 12:19:18 2017 +0100
dissector_filters: add cleanup function.
Change-Id: I9694a8e817e357061a60c425fb5881d525ed8143
Reviewed-on: https://code.wireshark.org/review/19695
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7e03647c9d756f8290fcc0c81eb1e4…
commit 7e03647c9d756f8290fcc0c81eb1e4df0fc1c80c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 12:01:56 2017 +0100
dcerpc: add shutdown routine.
Also use g_hash_table_new_full to ease the free procedure.
Change-Id: I0a411cccbd651cca18e94a048722bf5520903deb
Reviewed-on: https://code.wireshark.org/review/19691
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5c7b0b96878c269b4e1852c797f548…
commit 5c7b0b96878c269b4e1852c797f548e40af8f836
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 10:30:59 2017 +0100
decode_as: clean memory on exit.
Change-Id: Ifbbfc1ff71c32c2e9b758b55d32bff9a1ccd1576
Reviewed-on: https://code.wireshark.org/review/19689
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5235c2ec72ff3211bb05369e8d0c8b…
commit 5235c2ec72ff3211bb05369e8d0c8b43c7c55c23
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 22:37:55 2017 +0100
atalk: add check in shutdown routine
Change-Id: I52c00fa143c8562cdb195679f28590d7f2bb30c8
Reviewed-on: https://code.wireshark.org/review/19709
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d6b19f59b722e85365653867578fb7…
commit d6b19f59b722e85365653867578fb7e5305f53aa
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 12:33:18 2017 +0100
packet: add post_dissectors cleanup.
Change-Id: I9924425f1754c151552f41e23d20c7d4e6f1bf29
Reviewed-on: https://code.wireshark.org/review/19696
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=76d9d3dc5a0d69070a99d6d1304726…
commit 76d9d3dc5a0d69070a99d6d1304726028e1d7c2a
Author: Chris Bontje <cbontje(a)gmail.com>
Date: Fri Jan 20 11:30:31 2017 -0700
Identify Ethertype 0x892B (Schweitzer Engineering Labs layer 2 traffic).
Change-Id: I5479ed21116dd8f91f231ebd1ec230892df9a404
See: http://standards-oui.ieee.org/ethertype/eth.txt
Reviewed-on: https://code.wireshark.org/review/19707
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d6282d59a7263277b3ea6f952a2e95…
commit d6282d59a7263277b3ea6f952a2e9566a831cb77
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:19:15 2017 +0100
infiniband: add shutdown routine.
Change-Id: I3e7c1b8f589662a81c665b8b43056f20c17428ca
Reviewed-on: https://code.wireshark.org/review/19704
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3cf4f8a823550a8cb95607db489dd4…
commit 3cf4f8a823550a8cb95607db489dd41a60d100e3
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 17:08:57 2017 +0100
corosync-totemnet: add shutdown routine.
Change-Id: Ib2e93c012ec0547d4eb5968d1bf47b0e1489f3df
Reviewed-on: https://code.wireshark.org/review/19649
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cc30ba1d70db7f8258e0edf587b898…
commit cc30ba1d70db7f8258e0edf587b8985685aab9e4
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:07:10 2017 +0100
gssapi: add shutdown routine.
Change-Id: If4d474b3c94019c6ef46f4ed5753a6a90625b1b1
Reviewed-on: https://code.wireshark.org/review/19650
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f7392323ef22451f5c1505ff6d75ef…
commit f7392323ef22451f5c1505ff6d75ef5f391f1b50
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 19 22:53:35 2017 +0100
giop: add shutdown routine.
Change-Id: I954dd66d38390a1f67e8a0604bfdebb062a6f644
Reviewed-on: https://code.wireshark.org/review/19682
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=712d2aef72cc290c56c687e13fa470…
commit 712d2aef72cc290c56c687e13fa4702f269bfca9
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:04:44 2017 +0100
ber: add shutdown routine.
Change-Id: Idc494f6be0f2fd2187f21bccb870d24655ce1da5
Reviewed-on: https://code.wireshark.org/review/19647
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=81cbd4c5d1ccf720d938c46ae45c53…
commit 81cbd4c5d1ccf720d938c46ae45c537ac8df35e6
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 14:51:47 2017 +0100
aim: add shutdown routine.
Change-Id: Ide2f6f55902a42baa3c36f9c3ad6fd392b6a48c3
Reviewed-on: https://code.wireshark.org/review/19698
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d865d984657b2790d879b31f8893f6…
commit d865d984657b2790d879b31f8893f6f67e2bdbf5
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:12:49 2017 +0100
zvt: add shutdown routine.
Change-Id: Ied5ab457a372a74c1a7216002f5ea615ea2a5252
Reviewed-on: https://code.wireshark.org/review/19701
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=83d83dfdd48c75bba8fe0969215a60…
commit 83d83dfdd48c75bba8fe0969215a60d58f41c0ba
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 15:23:46 2017 +0100
zbee: add shutdown routine
Change-Id: I12ed488a26bde3a85cd75f61dad8f78412cd52ac
Reviewed-on: https://code.wireshark.org/review/19700
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=98718aa10704b07009b88954d60606…
commit 98718aa10704b07009b88954d606064767da1369
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:17:10 2017 +0100
6lowpan: add shutdown routine.
Change-Id: I1e324f9d7fdf4d96d8d9d53cbf1932458a2ea1a5
Reviewed-on: https://code.wireshark.org/review/19703
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6afcb1133a0ab76f493a343e4da854…
commit 6afcb1133a0ab76f493a343e4da8542c5f88f38f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 16:15:11 2017 +0100
atalk: add shutdown routine.
Change-Id: Ie35e457ba69fccc3ff45df76a21c747249788a20
Reviewed-on: https://code.wireshark.org/review/19702
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=db8b81b7a4f04903f3b6e606cc46f4…
commit db8b81b7a4f04903f3b6e606cc46f48da4e2b3f7
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 20 10:59:01 2017 +0100
rpc: add shutdown routine.
Change-Id: Ic00dae4b73ef89d6108c8c3085b7ce5a99d88574
Reviewed-on: https://code.wireshark.org/review/19690
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6cb16bef6b0cec9cf1f779f33e4af…
commit c6cb16bef6b0cec9cf1f779f33e4af2b85a0316d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 19 16:21:20 2017 +0100
sshdump: add sudo option.
Basic installation of tcpdump (the default remote capture binary)
don't have setcap option. Give the user the option to run tcpdump
with sudo (already possible with a custom remote capture command).
Change-Id: I273798b5f7dc63b468b03eb633bfc60f53e30743
Reviewed-on: https://code.wireshark.org/review/19672
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=132cd6dbace220a62e3083e67d859a…
commit 132cd6dbace220a62e3083e67d859a77cc832163
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 20 09:58:09 2017 +0100
DNS: update name_len variable when replacing name string
Bug: 13334
Change-Id: I07248747f678d4f89bbde33280b4d596462a4429
Reviewed-on: https://code.wireshark.org/review/19688
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5c0003a980f2f6de474b225aa99229…
commit 5c0003a980f2f6de474b225aa99229701e7f3c11
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 19 22:32:51 2017 +0100
disabled_protos: add cleanup function.
Change-Id: I7d585404463691946e2aa67e14e53edb813d9be8
Reviewed-on: https://code.wireshark.org/review/19681
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=387e7af2180327774beaa86cee3f95…
commit 387e7af2180327774beaa86cee3f9528146141cf
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 20 08:08:52 2017 +0100
tap-tcp-stream.h: fix double declaration introduced in g73b5e3d
Change-Id: I2656e323b9ea6d41566ab0cef1e4a94e3591b08c
Reviewed-on: https://code.wireshark.org/review/19687
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f2c0248c2872314897f5bf16665985…
commit f2c0248c2872314897f5bf16665985dff62129ba
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 19 21:57:08 2017 +0100
follow-stream: add cleanup function.
Change-Id: Icfe7de118bc49da57f537601c2f256e4a028b4e2
Reviewed-on: https://code.wireshark.org/review/19680
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6bf8e5bf9eb33598b276c704d237d4…
commit 6bf8e5bf9eb33598b276c704d237d430f261d08d
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Jan 16 09:53:56 2017 +0100
Bluetooth: HCI_EVT: Implement "LE Direct Advertising Report"
It is part of Bluetooth Core 4 specification.
Change-Id: I7a1e542285d65452d99f753b27777fff80ad1c59
Reviewed-on: https://code.wireshark.org/review/19646
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c38f2be9907eb24d50ac29e9bd9c4c…
commit c38f2be9907eb24d50ac29e9bd9c4c3e54805979
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Jan 19 15:23:29 2017 -0800
Qt: Fix a sequence dialog crash.
If gui.geom.SequenceDialog.maximized is TRUE, loadGeometry will trigger
a resize event, which will in turn call resetAxes. Call loadGeometry
after we've initialized our various QCustomPlot bits so that resetAxes
doesn't crash.
Bug: 13329
Change-Id: I4d27683fb3eee0a7c897800401bfa3869e97662b
Reviewed-on: https://code.wireshark.org/review/19683
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=96f07a0f56d5edbb0498a263e7dc13…
commit 96f07a0f56d5edbb0498a263e7dc13a618595d48
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Jan 19 17:36:50 2017 -0800
Fix typo.
Change-Id: I46be1220c8e789e1006cfbf7cff60e9556ff2caf
Reviewed-on: https://code.wireshark.org/review/19685
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=73b5e3d0082cc7ca65e5a085bd8026…
commit 73b5e3d0082cc7ca65e5a085bd80264e5a0b1082
Author: Kevin Hogan <kwabena(a)google.com>
Date: Tue Jan 17 20:30:26 2017 -0800
Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixes
Modifications to RTT graph:
- change x-axis to time (s) rather than sequence number
[ avoids sequence number wraparound ambiguity, plus
easier to correlate RTT changes to tcptrace graph ]
- change RTT computation to properly handle acks to GSO packets
- change RTT computation to take SACK blocks into account
Bug fixes:
- eliminate potential memory leak if some packets are unacked
- ensure RTT graph is shown if TCPGraph window is opened to it directly
Change-Id: I2bdcab97399ebde0f15c78fa19c882529a814580
Reviewed-on: https://code.wireshark.org/review/19662
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=069a5329887b9195f7994de00fe46c…
commit 069a5329887b9195f7994de00fe46c9fd055ca71
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Jan 19 22:34:26 2017 +0100
LDAP: fix wrong use of g_strlcpy introduced in gc397add
Last parameter is the destination buffer size, not the number of bytes to copy.
Bug: 13332
Change-Id: I9a6f5231d2d7a94fd5e692e8bbf4f5dba30b7c1a
Reviewed-on: https://code.wireshark.org/review/19677
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5df8d09cdc72eb7e94ae4c5b53ba19…
commit 5df8d09cdc72eb7e94ae4c5b53ba196795e95710
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 19 22:58:32 2017 +0100
packet: clean shutdown routines.
Change-Id: I620c683d77c724181a506e10f9d06a3944878690
Reviewed-on: https://code.wireshark.org/review/19679
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=27960cc6aba46a9d48923ee0d4c641…
commit 27960cc6aba46a9d48923ee0d4c641201e44b590
Author: Ashish Shukla <shukla.a(a)gmail.com>
Date: Thu Jan 19 08:30:56 2017 -0500
Always display vht mcs data rate, but mark invalid assuming BCC encoding.
Bug: 12859
Change-Id: Iaf2242b0dcf16f211d5a7565b96099cc44e8bf3d
Reviewed-on: https://code.wireshark.org/review/17899
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=07541f1f680c2dbbfe8a33f81102c7…
commit 07541f1f680c2dbbfe8a33f81102c711d768ac63
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 13 12:40:22 2016 +0100
epan: add shutdown function for dissectors.
Dissectors can register shutdown functions, that will be called
just before program exit. Those function will free the memory
allocated during the init function.
Change-Id: Id88228af2cc916bfb316fe7b36d46499f6e4f8d4
Reviewed-on: https://code.wireshark.org/review/19282
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=86c4808518b4a3929f2bdc4b6bab59…
commit 86c4808518b4a3929f2bdc4b6bab59b87b67b6bd
Author: MustBeArt <paul(a)mustbeart.com>
Date: Fri Jan 13 22:47:25 2017 -0800
DVB-S2-BB: Obey frame format from BB Header fields
Interpret packet contents according to the descriptive fields contained
in the BB header. Instead of always assuming a Generic Stream frame format,
use the TS/GS field to detect Generic Stream, Generic Packetized, Transport
Stream, or (reserved) frame formats and decode accordingly.
In the case of Generic Stream frames, check the validity of header fields
ISSYI, NPD, and UPL, and issue expert info if they are invalid for Generic
Stream frames. Then dissect as GSE (as before).
For other frame formats, just dump them as bytes for now.
Change-Id: I6b040207f83369110eb704c543861c887f77baa7
Reviewed-on: https://code.wireshark.org/review/19634
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d691b0ef7ad01da6ff04d6ba152daa…
commit d691b0ef7ad01da6ff04d6ba152daa680290dc90
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Jan 19 10:28:35 2017 -0500
Remove space character from ETHERWATCH magic key
V6.0 only has one space after "ETHERWATCH", not two so heuristics fail.
"ETHERWATCH " (one space) still seems like enough of a distinction.
Bug: 13093
Change-Id: Ib8786f6e2f5f595a4cab710b91cf78d175a6ab88
Reviewed-on: https://code.wireshark.org/review/19673
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=af073d45cd98e35b19d2eb17c59e69…
commit af073d45cd98e35b19d2eb17c59e690c785ea46a
Author: Radhashyam Behera <radhashyambehera(a)gmail.com>
Date: Fri Jan 6 17:22:09 2017 +0530
IEEE80211: Updated VHT Group ID Management
Detailed decode of Membership status & User Position in GroupID Mamagement frame.
Bug: 13322
Change-Id: I74b1d93757e3e10a2a0d4423fcfdcd2265e1bd62
Reviewed-on: https://code.wireshark.org/review/19564
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=259a3e508f37bb3c9b6d18cdacf7a1…
commit 259a3e508f37bb3c9b6d18cdacf7a18aa6dbd8f8
Author: Kevin Hogan <kwabena(a)google.com>
Date: Tue Jan 17 16:53:42 2017 -0800
Qt: add graph of unacked (outstanding) bytes to window scale graph
This metric is commonly used as an estimate of the sender's congestion window.
[ when examining a capture taken from the sender ]
Change-Id: I812d5556cef477c08ef1e5d396fbdddda9a6751e
Reviewed-on: https://code.wireshark.org/review/19661
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c397adda8a7af8374ba1355f8c221f…
commit c397adda8a7af8374ba1355f8c221f48abfac42a
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jan 4 15:53:56 2017 +0100
dns: change get_dns_name to return consumed bytes + actual name len.
Because of the DNS name encoding, the consumed bytes in the tvb and
the length of the string of the dns name can be different. We need
to handle them separately for the purpose they are. Moreover the
name string can contain null bytes, then we can't rely on strlen()
but we need the actual length.
Subsequent calls to proto_tree_add_string() will require to pass
the string to format_text() in order have non-printable characters
printed.
Bug: 13289
Change-Id: I6d0b295867ece265f8995f82da2c629992aeb703
Reviewed-on: https://code.wireshark.org/review/19539
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a056b685760340e2a3d83014f618ba…
commit a056b685760340e2a3d83014f618ba567fc8355b
Author: Simon Zhong <szhong.jnpr(a)gmail.com>
Date: Sun Jan 15 14:31:42 2017 -0500
pcep: Add support of draft-ietf-pce-pcep-service-aware-13
update support of draft-ietf-pce-segment-routing-08
Change-Id: I4d25268bb331462fbe219f242ff8278b017de37b
Reviewed-on: https://code.wireshark.org/review/19642
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=755ccae9bf0cc9e32a845fc36bbeaa…
commit 755ccae9bf0cc9e32a845fc36bbeaadc885fab6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jan 13 13:49:41 2017 +0100
QUIC: fix dissection of ACK Frame
First Ack Block is always present in ACK Frame (don't depend of present of NACK)
Change-Id: I702151a6ccb236272ace9dfdf0f4b507a549871e
Reviewed-on: https://code.wireshark.org/review/19627
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7f52ff06a4c40661c3c57a33bfe499…
commit 7f52ff06a4c40661c3c57a33bfe499589de8d0ca
Author: Volodymyr Khomenko <Khomenko.Volodymyr(a)gmail.com>
Date: Tue Jan 17 19:15:05 2017 +0200
RSVD dissector: added RSVD v2 verbs
Improved operation_code map to resolve RSVD v2 codes.
Changed GET_FILE_INFO -> GET_INITIAL_INFO for spec conformance.
See https://msdn.microsoft.com/en-us/library/dn392322.aspx
SMB2 IOCTL FSCTL_SVHDX_ASYNC_TUNNEL_REQUEST must be handled in the same way as
FSCTL_SVHDX_SYNC_TUNNEL_REQUEST:
RSVD dissector must be used (new async flow used by RSVDv2).
See https://msdn.microsoft.com/en-us/library/dn366375.aspx
Ping-Bug: 11232
Change-Id: Ie51773fc2199a7674538101b87cec398354bd97a
Reviewed-on: https://code.wireshark.org/review/19657
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3b6fe2bfb4d62326dc647f5dc49016…
commit 3b6fe2bfb4d62326dc647f5dc4901621b2fcae03
Author: Frank Carpenter <frank.carpenter(a)spectralink.com>
Date: Tue Jan 17 13:21:56 2017 -0700
Populate logcat year based on localtime
Change-Id: If7c790c25ed24da1b1442ee86e3a2f75bd3f8856
Reviewed-on: https://code.wireshark.org/review/19658
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b3432de4cfc496948921bc83840fef…
commit b3432de4cfc496948921bc83840fefbdef22c28c
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Jan 18 22:03:54 2017 +0100
packet.c: use call_routine() for all lists
For running through the postseq cleanup and final registration lists, we
can use the same dummy function call_routine() that is used for the init
and the cleanup lists. We don't need our own copies.
Change-Id: Ia1ea647d5831adda26dab86eceba8fcf704ce122
Reviewed-on: https://code.wireshark.org/review/19668
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d04b5cd362be82bf685fde65af67e7…
commit d04b5cd362be82bf685fde65af67e73c5a8ca0e4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jan 17 11:35:36 2017 -0500
Use dissector tables for PPP protocols' options.
Create pinos for all of the PPP protocols options and a dissector table to store
them all. Adapt a new version of dissect_ip_tcp_options, (now ppp_dissect_options)
that uses the dissector tables for name of options and dissection function.
Also standardize the dissectors for all protocols so that all include type and
length in the dissection.
Change-Id: I0033574e2831789040a1ce2857bf0e825d791cbe
Reviewed-on: https://code.wireshark.org/review/19656
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=37f4e42e98b0a57d709d5f87400cc1…
commit 37f4e42e98b0a57d709d5f87400cc1b2b0dea25f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jan 18 14:01:06 2017 +0100
packet: free postseq_cleanup_routines list.
Change-Id: Ic1972399b706407ce8f15a3e554f1304a36d1009
Reviewed-on: https://code.wireshark.org/review/19663
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=ddb0f7d23c5b6d00592e7046577dd1…
commit ddb0f7d23c5b6d00592e7046577dd16a6f29d015
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Jan 18 09:17:46 2017 -0800
Update fuzz-test to match capinfos behavior.
As of gebd3dc6, capinfos returns 2 for invalid capture files.
Change-Id: I00c1ab44c9929a9e922ac2a1ee8904632c1e460f
Reviewed-on: https://code.wireshark.org/review/19667
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=cf941613da659ce2590ae51cdf90b7…
commit cf941613da659ce2590ae51cdf90b78e8a5116c9
Author: Paul Offord <paul.offord(a)advance7.com>
Date: Tue Jan 17 17:25:24 2017 +0000
Fix Access Violation in plugin_if_mainwindow_get_ws_info(...)
Call to plugin_if_get_ws_info when no packets are being displayed
causes an Access Violation in plugin_if_mainwindow_get_ws_info
as the pointer in cf->current_frame is NULL.
Bug: 12973
Change-Id: I33e8fe6f3894963a6f1f1ec9aa9169f85e1e3b18
Reviewed-on: https://code.wireshark.org/review/19659
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3138dad72815d59da5f970354e77b8…
commit 3138dad72815d59da5f970354e77b81ed6cb3726
Author: Sandeep Dahiya <sdahiya(a)gmail.com>
Date: Tue Jan 17 14:52:20 2017 -0800
Gigamon Trailer support for new chassis types
Change-Id: Ib24cd2c701c0e158c07eff4dffe0bbf9937d132b
Reviewed-on: https://code.wireshark.org/review/19660
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e021f74ed2200fc99e0850044e3edf…
commit e021f74ed2200fc99e0850044e3edf739b6a5b6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Jan 16 08:15:03 2017 +0100
OpenFlow (v5/1.4): Add complete dissection of error messages
Like for OpenFlow (v4/1.3) (g4b7c2781fb)
Change-Id: I61cfea015e548e5eaa37856df86e96bd0ba21795
Ping-Bug: 13221
Reviewed-on: https://code.wireshark.org/review/19644
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe89424160a3ebf52a02b2b68ee3ff…
commit fe89424160a3ebf52a02b2b68ee3ff4ab3426431
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Jan 16 22:41:53 2017 +0100
stat_tap_ui: add cleanup function.
Change-Id: I0275a6e0d5d151f086d96c6388b9fa647ea0085c
Reviewed-on: https://code.wireshark.org/review/19654
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ae03fc73539e0ca65edaea0e37a724…
commit ae03fc73539e0ca65edaea0e37a724ff8169de9f
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Mon Jan 16 09:53:27 2017 +0100
Bluetooth: HCI_EVT: Implement some commands from Core 4
Now all unimplemented commands are in /* TODO */
Change-Id: I53c8dd0a660b62403214a3c75297e627337ed5fb
Reviewed-on: https://code.wireshark.org/review/19645
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=57f530a7fe06ff7325804a4a2a2aac…
commit 57f530a7fe06ff7325804a4a2a2aac6cd657ba02
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Jan 16 22:49:28 2017 +0100
packet: free init/cleanup functions lists.
Change-Id: Ia28ceef189f8fe16105da88c01e1a159d5029c0a
Reviewed-on: https://code.wireshark.org/review/19655
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=baaff60b3be77a12f952b08b8d7b53…
commit baaff60b3be77a12f952b08b8d7b535f2f91949d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Jan 16 22:08:12 2017 +0100
exported_object: add cleanup function.
Change-Id: If4c35d18db1dc982e981004838e0eabbf4479e78
Reviewed-on: https://code.wireshark.org/review/19653
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=baf2612d9e23cb2d992f75b0a21e26…
commit baf2612d9e23cb2d992f75b0a21e26a28f3985cc
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Jan 16 21:51:39 2017 +0100
exported_pdu: add cleanup function.
Change-Id: Iafc9f1c4b2a0210d8098b37eefc095e740182258
Reviewed-on: https://code.wireshark.org/review/19648
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1551f018147cfc097059eaf701909a…
commit 1551f018147cfc097059eaf701909a412c72164b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Jan 14 09:30:48 2017 +0100
profinet (pn): Fix Dead Store (Dead assignement/Dead increment) Warning found by
Clang
Change-Id: Id00e7dc1b23f7fce31845f024671a05fe06fc660
Reviewed-on: https://code.wireshark.org/review/19635
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=93df6be934268548600fe497d20ed1…
commit 93df6be934268548600fe497d20ed16ac40008df
Author: Volodymyr Khomenko <Volodymyr_Khomenko(a)DellTeam.com>
Date: Fri Jan 13 15:54:51 2017 +0200
RSVD: fix TUNNEL_SCSI_REQUEST
Length of CDBBuffer must be always 16 bytes
If CDBLength is less than 16, add padding bytes
Change-Id: I241a10325ebe17b32469eaf7dc530fc7fe2105de
Reviewed-on: https://code.wireshark.org/review/19628
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fb0d51aa66a38b5ef1331839785719…
commit fb0d51aa66a38b5ef133183978571957ba506393
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 19:29:35 2017 +0100
802.11(ad): not longer need to use p_add_proto_data/p_get_proto_data for pass isGrant
to beamforming control function
Change-Id: I719ff48a1992904c80c602f9706697e71b93ccba
Reviewed-on: https://code.wireshark.org/review/19640
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f76627ef26505f55d8fcbe8073279…
commit 5f76627ef26505f55d8fcbe8073279515f3b7304
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Sat Jan 14 00:11:28 2017 -0500
packet-nvme-rdma: Support Dissecting connect cmd & inline data.
This patch adds support to dissect data of the connect command which
comes along with the cmd in same packet.
It also removed unwanted tvb addition for rdma fabric commands,
completion and nvme commands.
Bug: 13201
Change-Id: I33062f67a69cdca4b909ed8c08201dea5e0aa095
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19632
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f27734f3a2747a150a6bc4d22bb2d2…
commit f27734f3a2747a150a6bc4d22bb2d212a8322c63
Author: Alexandr Savca <s.alex08(a)mail.ru>
Date: Sat Jan 14 23:12:14 2017 +0200
packet-tns.c: Add Version2 (SQLNET_RETURN_OPI_PARAM)
I've tested with pcaps from SampleCaptures (wiki).
Change-Id: Ifa1b628fbc675843c54dfd4b993809fd072dc69c
Reviewed-on: https://code.wireshark.org/review/19636
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b8ae1b14926af6a0177b4b7764ff33…
commit b8ae1b14926af6a0177b4b7764ff33e52b5f14a5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 15 19:46:58 2017 +0100
xml(.h): fix indent (use spaces) and modelines
use same indent like packet-xml.c
Change-Id: I687b0306ba1d3559ce4a299a0e66c55e3f04fdfd
Reviewed-on: https://code.wireshark.org/review/19641
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=024cf942c65bf0316d97fe5f2b558d…
commit 024cf942c65bf0316d97fe5f2b558d05c4334ccc
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Jan 15 08:12:09 2017 -0800
[Automatic update for 2017-01-15]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: Ia487718c34913b5bb8297184fedb6c7ecaf604e6
Reviewed-on: https://code.wireshark.org/review/19637
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=990d2a9a4ab0a31536abdb5d625051…
commit 990d2a9a4ab0a31536abdb5d625051b79b273225
Author: MustBeArt <paul(a)mustbeart.com>
Date: Fri Jan 13 16:43:54 2017 -0800
DVB-S2-BB: Use proto_tree_add_bitmask()
Change-Id: I1a4b50873a183c0f6051dc0db3fecf5e62c92cbb
Reviewed-on: https://code.wireshark.org/review/19633
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=298085def885f4dc1a8edc1dff15fa…
commit 298085def885f4dc1a8edc1dff15fa6c8ba081d5
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Jan 10 23:46:31 2017 +0100
Qt: fix memory leaks in UatDialog
Avoid leaking memory for the stringified UAT field values (tostr) and
for copies of rows.
Change-Id: I1bf20035fabe92da8216c820bc47ebce7dd73951
Reviewed-on: https://code.wireshark.org/review/19604
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=dc647f115e69bc578bc6e40a6111e7…
commit dc647f115e69bc578bc6e40a6111e7f0aebeb7b1
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 13 10:43:54 2017 +0100
geoip: free resources to avoid leak.
Change-Id: Ia4a938e8a6b3856959c375f4bfcdf565a21eabef
Reviewed-on: https://code.wireshark.org/review/19629
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=15deb6073409ac7523b1b9ad04003b…
commit 15deb6073409ac7523b1b9ad04003b56b02e7974
Author: MustBeArt <paul(a)mustbeart.com>
Date: Sat Jan 7 08:09:07 2017 -0800
DVB-S2 BB: Handle GSE Padding in BB frames
GSE Padding is outside of any GSE Packet and continues to the end of the
Baseband Frame, per 4.2.1 of ETSI TS 102 606-1.
Added dvb-s2_gse.padding as an integer representing the length in bytes
of the padding field.
Change-Id: I9ed22c37a1969059a09ba44d9e3473cb9d0a1880
Reviewed-on: https://code.wireshark.org/review/19579
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c2ddc300f35d4cf9c1a3d9088b9f2b…
commit c2ddc300f35d4cf9c1a3d9088b9f2bcf4ad78645
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 13 13:46:08 2017 +0100
X2AP: replace non ASCII characters in ASN.1 source files
Change-Id: I114ba3fc68dccf9f791488920f602906d2d8c124
Reviewed-on: https://code.wireshark.org/review/19626
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b357353f35f90445ef7532f86f4f32…
commit b357353f35f90445ef7532f86f4f324a03638c37
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 13 11:38:17 2017 +0100
LTE RRC: upgrade dissector to v13.4.0
Change-Id: I5f7de78f0be320781091e17ec8c471a3fd482b14
Reviewed-on: https://code.wireshark.org/review/19625
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=05fad31ea494a3ae409f49517f5073…
commit 05fad31ea494a3ae409f49517f50730d3785b5f1
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jan 13 10:15:51 2017 +0100
tools: add options documentation to valgrind-wireshark.sh
Change-Id: Id0bb85b9499f1e6f327b711d38deefe295e92c1a
Reviewed-on: https://code.wireshark.org/review/19624
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b34d93ad0e6fc63c43c220fd28ed1d…
commit b34d93ad0e6fc63c43c220fd28ed1d7e2892f14b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jan 13 09:11:53 2017 +0100
SSL: fix compilation without libgcrypt or gnutls
Change-Id: I785db404969f89a3f90eddbda5542ee6b676ddb8
Reviewed-on: https://code.wireshark.org/review/19623
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c303679d999f38d92a00f0cf99ba0a…
commit c303679d999f38d92a00f0cf99ba0a000a9ff92f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Jan 12 23:14:44 2017 -0800
Decode TBCD strings in GSM MAP as per the GSM MAP spec.
Hex digits 0xa through 0xe are '*', '#', 'a', 'b', and
'c',
respectively.
Constify the dgt_set_t argument to tvb_bcd_dig_to_wmem_packet_str(),
while we're at it.
Bug: 13316
Change-Id: I7586f35d23fd262453779d99946e7ccad4b6ffab
Reviewed-on: https://code.wireshark.org/review/19620
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a4bbd3cc775acbbba7f876816ca017…
commit a4bbd3cc775acbbba7f876816ca0173efb9838ee
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Thu Jan 12 18:23:45 2017 -0500
packet-infiniband: Pass read request packets to ULP dissectors
This patch passes RDMA read request packets to ULP dissectors similar to
other RDMA packets so that ULP dissector can have opportunity to show as
upper layer protocol instead of IB or RRoCE.
Change-Id: I594d8eada858b7f77fc94be44e3639526789779e
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19619
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aa76d58dd5967836e5b25d115cf0ff…
commit aa76d58dd5967836e5b25d115cf0ff10a76f35a1
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jan 12 15:53:25 2017 +0100
uat: fix build error without libgcrypt/gnutls
Change-Id: I00fea4d2e8c4d7fc8fc54627ced21796d40b854a
Reviewed-on: https://code.wireshark.org/review/19616
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4f01e93161714dfa7a8b5b5831e601…
commit 4f01e93161714dfa7a8b5b5831e6014224b2af49
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Jan 12 12:09:40 2017 -0800
Make sure ui/qt/variant_pointer.h gets distributed.
Change-Id: I3bbfaf392da346e937b5a1914c140d1114e3091e
Reviewed-on: https://code.wireshark.org/review/19618
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=259989ac1ade9cf60db9e5a78ceb40…
commit 259989ac1ade9cf60db9e5a78ceb404123d57fe9
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Jan 8 18:04:56 2017 +0100
camins: improve the heuristics
The current mechanism that reads the first 20 blocks looking for a headerd
oesn't work in all cases. I was given sample files that consist of
data blocks only and have no header.
Use a new approach to detect a .camins file by searching for pairs of
size high + size low blocks, either read or write. Go through the
entire file. If we have significantly more pairs than single, non-matching
blocks, this is a camins file.
Change-Id: Ic91e7db7149b105e26896d1a89cad4a2a73d0f13
Reviewed-on: https://code.wireshark.org/review/19603
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3df81a055064e2e2c8c9548f1c6837…
commit 3df81a055064e2e2c8c9548f1c6837ddef5e5034
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Jan 11 13:55:23 2017 +0100
Qt: Remove unneccessary Q_DECLARE_METATYPE
Remove unnecessary Q_DECLARE_METATYPE macros and replace calls
to QVariant conversions with VariantPointer where necessary
Change-Id: Ia4690590095f930bf94644197de7fa30b00ee7ec
Reviewed-on: https://code.wireshark.org/review/19611
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d6d516888122a26d477dcaa39a52fc…
commit d6d516888122a26d477dcaa39a52fc9cd8b24479
Author: Jan Spevak <jan.spevak(a)nokia.com>
Date: Thu Jan 12 15:11:33 2017 +0100
Diameter: decode Emergency-Indication AVP (1538)
Change-Id: Ie40d61944fd47eb532b759cb122367c18840feff
Reviewed-on: https://code.wireshark.org/review/19615
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8dc2346dfa5df67749583a428f9a7…
commit f8dc2346dfa5df67749583a428f9a76b2f61acb1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Jan 11 00:33:46 2017 +0100
Qt: fix memleak of PointList in interface statistics
The list of points (for interface traffic statistics) is part of the
interface tree model/view. Remove the pointer indirection to simplify
cleanup and avoid leaking a PointList.
Note that the SparkLineDelegate is used in two different places
(CaptureInterfacesDialog and InterfaceTreeModel).
Change-Id: I5fef7dadd44fdf58c07844fee269f509c712a36f
Reviewed-on: https://code.wireshark.org/review/19606
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4b3b3f587726bf055c252b4497d103…
commit 4b3b3f587726bf055c252b4497d10375c08b5993
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jan 11 19:34:38 2017 -0500
Extcap: Restore previously created preference from hash table, not preference pointer
Change-Id: Ie68a5c6c193f362e78d4f4b1f20edf7747e2313f
Reviewed-on: https://code.wireshark.org/review/19614
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=805ddd1addbea96308fe3b790043ec…
commit 805ddd1addbea96308fe3b790043ec511c73bbfa
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Dec 21 11:50:47 2016 +0100
uat: add a reset callback.
This function will free the resources allocated by the caller.
Change-Id: Ib486c14e4fd3c321662fb71f7fd06733ce9a64a4
Reviewed-on: https://code.wireshark.org/review/19375
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=01c8028add4099ad8707302efd9207…
commit 01c8028add4099ad8707302efd9207b82daa7f81
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Jan 11 22:36:37 2017 +0100
X2AP: upgrade dissector to v13.6.0
Change-Id: Ie312d354cadadba693ea5320c5bbc0957bde6514
Reviewed-on: https://code.wireshark.org/review/19613
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9414f56152c007f3ee2965ffd0b2cd…
commit 9414f56152c007f3ee2965ffd0b2cd0bff82c238
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Jan 11 19:16:12 2017 +0100
S1AP: upgrade dissector to v13.5.0
Change-Id: Ic65ae88af37f0e82207c093827755f93934d9424
Reviewed-on: https://code.wireshark.org/review/19612
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d8be254a51f8c4bfb3a726868c1b03…
commit d8be254a51f8c4bfb3a726868c1b03371526a0db
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Jan 2 13:48:41 2017 -0500
packet-btatt.c: Use protocol information from dissector handle instead of pinfo data
for attributes.
Instead of using a dissector function placed in a dissector table, just use the
protocol information registered with the dissector table to create the desired
dissector tree.
Change-Id: Ic32b15e3c05d73df6e8f69890c47172e991bda6f
Reviewed-on: https://code.wireshark.org/review/19509
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2d6f87623b9cf2a209d4145f7c31fc…
commit 2d6f87623b9cf2a209d4145f7c31fc13dbc24dd3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Jan 10 21:12:28 2017 +0100
OpenFlow (v4/1.3): rename dissect_openflow_payload_v4 to dissect_openflow_message_v4
Like OpenFlow (v5/1.4) dissector
and include dissect_openflow_header_v4
Ping-Bug: 13221
Change-Id: I123fad871bcb1c9d54946500505525d55a81f8f3
Reviewed-on: https://code.wireshark.org/review/19602
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=39389a12e5acfa2f43b3ac30b69dea…
commit 39389a12e5acfa2f43b3ac30b69deacd61411b6a
Author: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Date: Tue Jan 10 21:57:53 2017 -0500
Run libtoolize before aclocal.
libtoolize installs files in m4/ which aclocal is going to include.
Prior to this change this sequence:
1) ./autogen.sh
2) ./configure
3) make
Results in aclocal (and subsequently ./configure) being rerun in step 3
(because there are files in m4/ that are are newer than aclocal.m4).
Change-Id: I70589ab3cede6b7cd48e089c8be4d4c98dab3b6a
Reviewed-on: https://code.wireshark.org/review/19609
Petri-Dish: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=97b3f75c0fc2e1f46f7a4511acdec9…
commit 97b3f75c0fc2e1f46f7a4511acdec9e433b4ce16
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Jan 8 16:10:11 2017 +0100
iso14443: use proto_tree_add_checksum()
replace our own function for dissecting the CRC with
the generic proto_tree_add_checksum()
Change-Id: I569c877836a7b771b01a37b57b6c50fc0183e9a7
Reviewed-on: https://code.wireshark.org/review/19601
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ebd198979f3b334688914e631a8899…
commit ebd198979f3b334688914e631a8899f5090e4503
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Jan 10 23:47:29 2017 +0100
Qt: check NULL before dereference (CID 1394324)
Move the NULL check before the assignment with the dereference.
Change-Id: Ifcd4fb89c059ad2f4b6606fc1e83dc67a7d7373d
Reviewed-on: https://code.wireshark.org/review/19605
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=37790e90f52b4c08d2a5dd8c4ff0e0…
commit 37790e90f52b4c08d2a5dd8c4ff0e0cab4913880
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Jan 10 14:03:55 2017 +0100
cmake: fix empty data (Global Configuration) directory
Color filters were somehow not loaded. It turns out that the
BUILD_TIME_DATAFILE_DIR macro (for filesystem.c) was empty because
DATAFILE_DIR was defined after adding the wsutil directory. Fix it by
defining the variable before wsutil (but after epan).
Change-Id: I0d002b79499c80a90d8fcc14b06ced26c30b0453
Fixes: v2.3.0rc0-1830-gd5fdbef7f4 ("cmake,wslua,wsutil: load files from run/
instead of source tree")
Reviewed-on: https://code.wireshark.org/review/19600
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=0ecfc7280cf3d793a754722b276922…
commit 0ecfc7280cf3d793a754722b27692216e5a2986f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jan 9 22:40:07 2017 -0800
Use tvb_new_subset_remaining() rather than tvb_new_subset_length_caplen().
Any call of the form tvb_new_subset_length_caplen(tvb, offset, -1, -1)
should instead be tvb_new_subset_remaining(tvb, offset).
Change-Id: I4bc95b028103ea4fc82453ef3460c147d7ccabd6
Reviewed-on: https://code.wireshark.org/review/19598
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7cd6906056922e4b8f68f1216d94ea…
commit 7cd6906056922e4b8f68f1216d94eaa0809896fe
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jan 9 22:18:49 2017 -0800
Rename tvb_new_subset() to tvb_new_subset_length_caplen().
This emphasizes that there is no such thing as *the* routine to
construct a subset tvbuff; you need to choose one of
tvb_new_subset_remaining() (if you want a new tvbuff that contains
everything past a certain point in an existing tvbuff),
tvb_new_subset_length() (if you want a subset that contains everything
past a certain point, for some number of bytes, in an existing tvbuff),
and tvb_new_subset_length_caplen() (for all other cases).
Many of the calls to tvb_new_subset_length_caplen() should really be
calling one of the other routines; that's the next step. (This also
makes it easier to find the calls that need fixing.)
Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b
Reviewed-on: https://code.wireshark.org/review/19597
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2a3b2360e15d49defde55240a5c1e1…
commit 2a3b2360e15d49defde55240a5c1e171c7cade89
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 17:14:15 2017 +0100
ieee80211: Add Extreme (Zebra) Vendor Specific TLV
Only decode subtype 1 : AP Name with unknown data (7 bytes)
Change-Id: I4fc0c6fff1a931075ab333a8527251f12acb2827
Reviewed-on: https://code.wireshark.org/review/19586
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8604ed2ef8dabce9abc384b5583ec5…
commit 8604ed2ef8dabce9abc384b5583ec573348bc920
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jan 9 15:13:35 2017 -0800
Consistently use tvb_reported_length_remaining().
That's the amount of data left in the packet; perhaps not all of it was
*captured*, and using tvb_reported_length_remaining() will throw an
exception, but that's what *should* happen ("packet cut short"
notification and all).
Use tvb_new_subset_remaining() to get a tvbuff with everything after a
certain point in the packet.
Change-Id: I2512e58e23600f7e7bbce0126732b05997692a65
Reviewed-on: https://code.wireshark.org/review/19596
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2b482cd0c3f85b0cb20819ad0ce1d6…
commit 2b482cd0c3f85b0cb20819ad0ce1d612c72f4abd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jan 9 14:25:33 2017 -0800
Use tvb_new_subset_length(); no need to do its work ourselves.
Change-Id: I581e14af2981c723a81e9c0340de0229b832e51a
Reviewed-on: https://code.wireshark.org/review/19595
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=49b2a1cdb7358ca3316a4cdc436685…
commit 49b2a1cdb7358ca3316a4cdc436685a0e8b54465
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sun Jan 8 23:58:12 2017 +0100
Restore FCoIB frame marker handling (CID 1397701)
It seems that somewhere in the last few years the changes for FCoIB
have caused it to loose its frame marker processing. This change puts
that back.
Also there is an ambiguity in EOF handling, which is solved.
Change-Id: Iefbb42726e4e5491a50d7ce96626c906fb5ea857
Reviewed-on: https://code.wireshark.org/review/19594
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=d5abca0cf570e6debe2569555fe525…
commit d5abca0cf570e6debe2569555fe5252e2c4409b6
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sun Jan 8 02:09:23 2017 +0100
Fix TCP stream graph (throughput) reset axes logic (CID-1398438)
The code seems to be ment to latch the reset axes flag for graph update.
Change-Id: I7b47346c45aa7576c98a251eb3ebcd9188407000
Reviewed-on: https://code.wireshark.org/review/19581
Reviewed-by: Kevin Hogan <kwabena(a)google.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=21c203e154d3f49216eaa0bc55f3d3…
commit 21c203e154d3f49216eaa0bc55f3d3c138ba98ba
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 19:16:59 2017 +0100
802.11(ad): Add reserved field of Grant ACK frame
Change-Id: I0bb982403fb7f36ad166234b16dbe8ad9b8b8eb8
Ping-Bug: 13244
Reviewed-on: https://code.wireshark.org/review/19592
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f2f8f6ac82064e46ef2210cbb833c8…
commit f2f8f6ac82064e46ef2210cbb833c85fe5763406
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 18:55:14 2017 +0100
802.11(ad): Remove comment about clang warning and set directly the value
Change-Id: Ie64608597c7d6a5b9a2fec9de8e8983233e0e10e
Reviewed-on: https://code.wireshark.org/review/19591
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cbb5068b006881e93d134ab925ae21…
commit cbb5068b006881e93d134ab925ae21ca6b166861
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 18:46:14 2017 +0100
802.11(ad): Fix SSW Feedback dissection when Sector Sweep Direction = Responder
For the Sector Sweep Frame in which the Sector Sweep Direction = Responder, the format
of the Sector Sweep Feedback Field should be the one in the standard (Figure 8-431d—SSW
Feedback field format when not transmitted as part of an ISS) i.e. similar to the one in
Sector Sweep Feedback Frame and Acknowledgement.
Issue reported by Hany ASSASA
bug: 13244
Change-Id: Ic8c6d83fc32d017fb73116a54759608498f99452
Reviewed-on: https://code.wireshark.org/review/19590
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9a1dfcca6022b825fc8ac72d8eddab…
commit 9a1dfcca6022b825fc8ac72d8eddaba6a9ea1dab
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 8 18:23:24 2017 +0100
802.11(ad) fix typo : ambiguous assignment (CID 1398212)
Introducte in g62a54cb77
Ping-Bug: 13244
Bug: 13309
Change-Id: I2e3411cfd38685c08fd669fad1313663ba879936
Reviewed-on: https://code.wireshark.org/review/19589
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=86a5bf5abe53457dd5cfbde33b4670…
commit 86a5bf5abe53457dd5cfbde33b4670b6bf3efc94
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Dec 29 20:17:18 2016 +0100
TLS(1.3): update PSK extension for draft -18
Removed ke_modes and auth_modes fields, add
identity.obfuscated_ticket_age and binders fields. (Note that binders
field is not dissected further at this moment due to the lack of a pcap
for verification.)
Ping-Bug: 12779
Change-Id: I9af7d93feb2352a494be2d5bda66d124267cf464
Reviewed-on: https://code.wireshark.org/review/19462
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=45d967c803324a50852d4c4615a521…
commit 45d967c803324a50852d4c4615a521e6e245a5dd
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Sun Jan 8 21:02:46 2017 +0000
profinet: Skip comments in GSD file
Bug: 13303
Change-Id: I9ab17ec25917723be06b36ab4c11fe67e6792715
Reviewed-on: https://code.wireshark.org/review/19593
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ffa239950a3180f103d8d1b6db8550…
commit ffa239950a3180f103d8d1b6db8550b1b4359566
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Jan 8 08:14:14 2017 -0800
[Automatic update for 2017-01-08]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I91668647c50e78b29bbb28f2348dc8e52c3a66c5
Reviewed-on: https://code.wireshark.org/review/19585
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3952052426fbf063585b57aefe6b1b…
commit 3952052426fbf063585b57aefe6b1b2fa57d651d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jan 7 21:31:05 2017 -0500
Restore some MPLS registered dissectors.
Per https://ask.wireshark.org/questions/58532/missing-dissector-pw_eth_cw
it appears some MPLS dissectors are still referenced by name and
not just for the dissector table created in
I1e0c3ae784b71c0145b1f1730a97feae8e9f488f.
Change-Id: I27be132f56c879be16f78f76ac0e9688673a47c1
Reviewed-on: https://code.wireshark.org/review/19582
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ebd3dc6907c44d642a76f2a459395f…
commit ebd3dc6907c44d642a76f2a459395ffdb728143b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sat Jan 7 21:57:57 2017 +0100
Fix exit code for non-existent file.
The patched command line utilities have been aligned to tshark
behavior.
Change-Id: I0cb764b37792e882e182681124341893b3958c59
Reviewed-on: https://code.wireshark.org/review/19580
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e29d874f8b5e6ebc59f661a0bb0da…
commit 6e29d874f8b5e6ebc59f661a0bb0dab8e56f122a
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Jan 6 23:17:19 2017 +0100
Qt: fix crash on undecodable RTP stream
When the sample rate is zero, a floating point exception (FPE) occurs in
QAudioDeviceInfo::nearestFormat. Detect the error condition instead and
show an error.
Change-Id: Ie2eaa57847938fe15607fa26d0f4e08e7ddd23d1
Fixes: v2.3.0rc0-1664-gd59653f8d5 ("Qt: Make the RTP player output device
selectable.")
Reviewed-on: https://code.wireshark.org/review/19569
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=082ba063efd2a7faf6bd25d73b0819…
commit 082ba063efd2a7faf6bd25d73b08197708e117b8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Jan 7 18:32:59 2017 -0800
Comments on the first nibble stuff.
If you don't have control words - and several MPLS pseudo-wire RFCs say
"in these cases, a control word isn't necessary, and isn't useful, so
you might want to leave it out" - the first nibble values of 0, 1, 4,
and 6 could just be part of the packet header.
Explain some other stuff as well.
Change-Id: I2f1aae2ab8653bdd7f8b3b52ef450f6d43a1afcd
Reviewed-on: https://code.wireshark.org/review/19583
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2009dcc98dc46712c8b64ae30408c4…
commit 2009dcc98dc46712c8b64ae30408c4d53c64980b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Jan 7 00:14:23 2017 +0100
extcap: fix memleak via data_file_url
Commit v2.1.0rc0-2181-ga4e2263ac4 introduced a helppage parameter, but
all callers were NULL. In a later change, callers would use the
data_file_url() function, but this needs to be freed, so do that.
Fixes: v2.3.0rc0-1825-ge5596b74bd ("extcap: set help page for all
extcaps.")
Change-Id: I967c0f8c6b50d9e78ac227575de24a81f97d376a
Reviewed-on: https://code.wireshark.org/review/19570
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=03a8884989035400316b03913b6878…
commit 03a8884989035400316b03913b68787c50308082
Author: Eliot Lear <lear(a)cisco.com>
Date: Mon Jan 2 17:29:10 2017 +0100
Add MUD-URL manufacturer usage description certificate extension.
See draft-ietf-opsawg-mud for details. File changes include addition
of new asn1 directory and associated files, as well as edits to various
other files to support the change.
Change-Id: Ib910980e1ddcafaa31aa07cf049562520b61a3aa
Reviewed-on: https://code.wireshark.org/review/19505
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=165c8b04227df05a0ae329e92adff7…
commit 165c8b04227df05a0ae329e92adff7bd314b9d4b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jan 4 10:57:25 2017 -0500
Refactor range preference.
Refactored so that all handling of ranges in struct preference
can be internal to prefs.c
Change-Id: I68577909f9c07b23a16ab3443a523355d4645314
Reviewed-on: https://code.wireshark.org/review/19577
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
-----------------------------------------------------------------------
hooks/post-receive
--
wireshark with Osmocom specific dissectors
2975
days inactive
2975
days old
osmocom-commitlog@lists.osmocom.org
0 comments
1 participants
participants (1)
-
gitosis＠osmocom.org