This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT".
The branch, jerlbeck/master has been updated discards 0c0ed3e98aecb331d67910dad28842e97ece7ec8 (commit) via 377250f3ada5701a104ccb5388bfe13640b53eb7 (commit) via e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 (commit) via 07111668d4b4bfe44c02077b29ed7d3cb8415134 (commit) via 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce (commit) via 5cd496d2083bef03d9f2425cabec9ec51c8e9254 (commit) via 83426b20a30832cbacd8165f5b757910e98f5417 (commit) via 617c7127f434fc866ca370e8812f1ad01ad90d27 (commit) via 23f93a15ca759b55b4713148f06d9a2d152278ab (commit) via ec478756ccc8e8df264811741bfc9c362cb9233d (commit) via 9380f5d2181c63922627cbff6abe5e3cd05523e4 (commit) via ac89a555fa73b24a77bb861811774a5af885bc84 (commit) via 699b8dca49df30b7bf6db7090eb416d1ad4fd46d (commit) via ccc34e4d30b962a2963c004d003d3851801ffb3b (commit) via c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 (commit) via 9ec49e2411abb206c82af643d18e2ada82e865e2 (commit) via fa464bbce90130a7f429cdbafac7b64b1fdacd32 (commit) via e565564bc9d74e09ec1962f86aa5155e97377e1f (commit) via cb1b494c896243a92a1969bb4c0ee4baddad2423 (commit)
This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this:
* -- * -- B -- O -- O -- O (0c0ed3e98aecb331d67910dad28842e97ece7ec8) \ N -- N -- N (377250f3ada5701a104ccb5388bfe13640b53eb7)
When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B.
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=377250f3ada5701a104ccb5388bfe136...
commit 377250f3ada5701a104ccb5388bfe13640b53eb7 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Thu Jul 2 12:54:26 2015 +0200
tbf: Add Poll Timeout counters
This commits adds three poll timeout counters
- RLC Assign Timeout - RLC Ack Timeout - RLC Release Timeout
to help diagnosing to cause for these events. There seems to be an increased rate of these when a PDCH is shared by multiple TBFs.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e0c734dcfe6501198e56bd3a89ad03ce...
commit e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Fri Jul 3 14:03:33 2015 +0200
Revert "tbf: Add GprsMs* argument to update() and use it in reuse_tbf"
This reverts commit 2272a83a13b57ea7e99fe96ac76e4ad892e19e90.
The modification is no longer needed, since the call to update has been removed from reuse_tbf().
Conflicts: src/tbf_dl.cpp
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=07111668d4b4bfe44c02077b29ed7d3c...
commit 07111668d4b4bfe44c02077b29ed7d3cb8415134 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 13:30:43 2015 +0200
tbf: Remove call to update() in reuse_tbf
Since both TBF are based on the same reservation which means that they should be compatible with respect to the slot usage, and since the new TBF has not been forced to single slot usage, an update of the allocation is not necessary now.
This commit removes the call to update() from within reuse_tbf().
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=4944c195d4a71f4aa5d9a3274907fa0b...
commit 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Thu Jul 2 12:04:20 2015 +0200
tbf: Set ms in call to tbf_alloc_dl_tbf
The call to tbf_alloc_dl_tbf misses the pointer to the GprsMs object which is already known in that case (tbf_reuse). This leads to a full reallocation of the PDCH slots, which is possibly incompatible with the old set of slots. This can result in hanging TCP connections and TCP connection failures.
This commit replaces the old NULL value by the actual GprsMs object. Since the set_ms() is also done within the tbf_alloc_dl_tbf method, that call is removed.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5cd496d2083bef03d9f2425cabec9ec5...
commit 5cd496d2083bef03d9f2425cabec9ec51c8e9254 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Tue Jun 30 10:24:37 2015 +0200
alloc: Base algo A on reserved PDCHs
Currently algorithm A bases its time slots selection on the number of TBF actively using the PDCHs. This statistically prefers the first time slots, especially with short living TBFs. So when the first TBF is triggered by an uplink transfer (which generally results in a short-lived TBF) the potentially longer living DL TBF will be bound to the same slot. When another MS then requests an uplink TBF, it will get the same slot (no UL TBF currently active).
This commit changes the algorithm to base its selection on reserved slots instead.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=83426b20a30832cbacd8165f5b757910...
commit 83426b20a30832cbacd8165f5b757910e98f5417 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Tue Jun 30 09:44:05 2015 +0200
alloc: Ignore slots with differing TSC if multiple slots are requested
According to TS 45.002, 6.4.2 the training sequence (TSC) must be the same for all slots in a multi-slot set.
This commit updates find_possible_pdchs() to only consider slots with the same TSC if more that 1 slot shall be assigned.
Note that the first PDCH's TSC will be used as reference, so if two or more groups with a common TSC are configured, only the first will be used. This restriction does not apply to algorithm A, since it will not assign more than one slot and therefore sets the max_slots parameter to 1.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=617c7127f434fc866ca370e8812f1ad0...
commit 617c7127f434fc866ca370e8812f1ad01ad90d27 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Tue Jun 30 09:18:30 2015 +0200
ms: Get the set of slots currently active
This commits adds methods to GprsMs and gprs_rlcmac_tbf to retrieve the slots that are actively used.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=23f93a15ca759b55b4713148f06d9a2d...
commit 23f93a15ca759b55b4713148f06d9a2d152278ab Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Tue Jun 30 08:52:54 2015 +0200
ms: Add support for slot reservation
In contrast to the slots currently used by existing TBFs, the reserved slots refer to the time slots that can be used for newly allocated TBFs without causing conflicts (given that the first common TS does not change). They correspond to the potential use of the PDCHs and can be used to achieve a more uniform slot allocation.
This commit adds bit set based methods to GprsMs and gprs_rlcmac_trx and a counter to gprs_rlcmac_pdch. The current TRX will also be stored in the MS object.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ec478756ccc8e8df264811741bfc9c36...
commit ec478756ccc8e8df264811741bfc9c362cb9233d Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Fri Jun 19 16:35:38 2015 +0200
alloc: Load balancing for algo A
Currently only the first enabled PDCH will be used. Beside the throughput this will also limit the number of TBFs:
- number of UL TBFs <= 7 - number of DL TBFs <= 32
This commit changes the allocation algorithm to use the PDCH with the least number of attached TBFs. This will improve the troughput in both directions and the UL limits:
- number of UL TBFs <= min(32, N_PDCH * 7) UL TBFs
Ticket: #1794 Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=9380f5d2181c63922627cbff6abe5e3c...
commit 9380f5d2181c63922627cbff6abe5e3cd05523e4 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Fri Jul 3 12:38:59 2015 +0200
tbf: Add GprsMs* argument to update() and use it in reuse_tbf
Since set_ms() is caled on the new DL TBF, the old DL TBF loses the reference to the MS object. This will lead to a segfault, when update() is called in reuse_tbf().
This commit adds an optional GprsMs* parameter to update() and uses it for the slot allocation.
This fixes a TbfTest crash that would otherwise occur after applying the next commit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ac89a555fa73b24a77bb861811774a5a...
commit ac89a555fa73b24a77bb861811774a5af885bc84 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 14:18:46 2015 +0200
ms: Add tbf() method to get the TBF based on the direction
To avoid the need for a switch or conditional statement when needing a TBF from an MS object in direction independant code, this method contains that case distinction. For additional flexibility, a reverse() function is added to get the opposite direction.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=699b8dca49df30b7bf6db7090eb416d1...
commit 699b8dca49df30b7bf6db7090eb416d1ad4fd46d Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 14:05:55 2015 +0200
ms: Add first_common_ts method to GprsMs
This method gets the index (0 based) of first common time slot used by the TBFs attach to it. It expects that all of them have the same notion of this. If no TBF is attached, -1 will be returned.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ccc34e4d30b962a2963c004d003d3851...
commit ccc34e4d30b962a2963c004d003d3851801ffb3b Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 13:45:05 2015 +0200
tbf: Maintain the number of TBF per PDCH
Currently the PDCH object do not know anything about the TBFs using them. To make the slot allocation load dependant, at least some numbers are required.
This commit adds TBF counters (one per direction) and the related methods attach_tbf, detach_tbf, and num_tbfs to gprs_rlcmac_pdch.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=c6d4ceeda6e6b96cc5bbc07fb9489587...
commit c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 13:03:46 2015 +0200
tbf/test: Add assertions
These assertions check for the TBF allocation result before the tbf object is dereferenced the first time.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=9ec49e2411abb206c82af643d18e2ada...
commit 9ec49e2411abb206c82af643d18e2ada82e865e2 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 13:00:20 2015 +0200
alloc/test: Use LOGL_DEBUG environment variable
When this environment variable is set, the logging level is set to LOGL_DEBUG to help debugging without putting everything into AllocTest.err.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=fa464bbce90130a7f429cdbafac7b64b...
commit fa464bbce90130a7f429cdbafac7b64b1fdacd32 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 12:45:11 2015 +0200
alloc/test: Enhance test_alloc_a
This commit adds: - an assertion to check that count is valid, - an assertion the verify that tbf_alloc did not fail - a slots parameter to specify the enabled slots - additional test invocations with more slots enabled
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e565564bc9d74e09ec1962f86aa5155e...
commit e565564bc9d74e09ec1962f86aa5155e97377e1f Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Mon Jun 29 12:19:52 2015 +0200
alloc/test: Add test for successive allocation
This test allocates as many as possible UL/DL TBF pairs, shows their PDCH usage, and checks how many of them has been created successfully.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes: src/bts.cpp | 48 ++++++ src/bts.h | 37 +++++ src/gprs_ms.cpp | 83 +++++++++- src/gprs_ms.h | 29 ++++ src/gprs_rlcmac_ts_alloc.cpp | 153 +++++++++++++++++-- src/tbf.cpp | 59 ++++++- src/tbf.h | 7 + src/tbf_dl.cpp | 6 +- tests/alloc/AllocTest.cpp | 222 ++++++++++++++++++++++++++- tests/alloc/AllocTest.err | 19 ++- tests/alloc/AllocTest.ok | 355 +++++++++++++++++++++++++++++++++++++++++++ tests/ms/MsTest.cpp | 3 + tests/tbf/TbfTest.cpp | 14 ++ tests/tbf/TbfTest.err | 210 ++++++++++++++++++++++--- tests/tbf/TbfTest.ok | 2 + 15 files changed, 1188 insertions(+), 59 deletions(-)
hooks/post-receive
osmocom-commitlog@lists.osmocom.org
-
gitosis＠osmocom.org