This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 55a43b801385e07a484217925ecf2379b9f54fcf (commit) via 8352d31a8666e328e399ba1d2ae581c8f0021e48 (commit) from 4a7f87cdc848891f7306109a009e51684b6c5c0e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=55a43b801385e07a484217925ecf… commit 55a43b801385e07a484217925ecf2379b9f54fcf Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Feb 2 20:27:55 2017 +0100 gsm48: add UMTS AKA res+sync IEIs, msg type and cause val According to 3GPP TS 24.008 9.2.3a, 9.2.3, 10.5.3.6 Change-Id: I745061ce8eb88aa23080dadcdbfe2d703c362a30 http://cgit.osmocom.org/libosmocore/commit/?id=8352d31a8666e328e399ba1d2ae5… commit 8352d31a8666e328e399ba1d2ae581c8f0021e48 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Feb 2 20:05:14 2017 +0100 GSUP, OAP, osmo-gen-vec: fix AUTS length to 14, not 16 GSUP transmits AUTS for UMTS authentication procedures, and OAP uses the same procedures to authenticate. osmo-gen-vec is a utility program that passes AUTS to our osmo_auth_gen_vec_auts() API. According to 3GPP 33.102 6.3.3, AUTS = SQN^AK || MAC-S, which are 6 || 8 == 14 bytes. This is confirmed by 24.008 9.2.3a where the TLV has 16 bytes, TL = 2 and AUTS being the V = 14. It is not harmful for milenage_gen_vec_auts() to pass two more AUTS bytes. But writing 16 bytes to a GSUP struct is a potential problem when passing in a 14 byte long AUTS buffer to the GSUP API, which then reads past the AUTS buffer. The API implies the length, so far to be 16, so passing in a 14 byte buffer to GSUP would require copying to a larger buffer first. Fix this by using a length of 14 for AUTS everywhere instead. This constitues an ABI breakage, we may handle it as a "fix before an official release", otherwise we need a version bump. The OAP protocol document has also been updated, needs an update in the osmo-gsm-manuals as well. Change-Id: If25b173d9ec57ea4c504d860954912b7d82af455 ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 3 +++ doc/osmocom-authn-protocol.txt | 2 +- include/osmocom/gsm/oap.h | 2 +- include/osmocom/gsm/protocol/gsm_04_08.h | 4 ++++ src/gsm/gsup.c | 2 +- tests/oap/oap_test.c | 4 ++-- tests/oap/oap_test.ok | 2 +- utils/osmo-auc-gen.c | 2 +- 8 files changed, 14 insertions(+), 7 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications