This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated via 8b4e58462167493e31109e965b4ad6c32d2215f1 (commit) via 7a77d0155f154b88d768832932b8b2c35681782f (commit) via a174a47811f2168d63f6f021d3ed2f156bff9951 (commit) via 615ed46a6ab25f71a7ab0d8201d33b4dbf8fc5b0 (commit) via 11cb7a9fd9d853aaf5ff3d34c179fa3afc9a80a4 (commit) from 130be40c3e1bd7a1c7003c71cbae071a3d51cf62 (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8b4e58462167493e31109e965b4ad6c32...
commit 8b4e58462167493e31109e965b4ad6c32d2215f1 Merge: 130be40 7a77d01 Author: Holger Hans Peter Freyther holger@moiji-mobile.com Date: Fri Oct 2 15:30:38 2015 +0200
Merge branch 'zecke/features/amr'
Fix AMR support for the BSC, remove code duplication, make it less prone to error.
http://cgit.osmocom.org/openbsc/commit/?id=7a77d0155f154b88d768832932b8b2c35...
commit 7a77d0155f154b88d768832932b8b2c35681782f Author: Holger Hans Peter Freyther holger@moiji-mobile.com Date: Thu Sep 24 16:26:01 2015 +0200
amr: Attempt to unbreak the AMR support in the BSC
The signature of mr_config and the BSC implementation didn't match and the compiler was warning about it:
osmo_bsc_api.c:530:2: warning: initialization from incompatible pointer type .mr_config = bsc_mr_config, ^ osmo_bsc_api.c:530:2: warning: (near initialization for ‘bsc_handler.mr_config’)
Change the mr_config again and provide an implementation that will set the ms and bts data structure. It would be better to put the size outside of the IE but I am not going to change it right now. It would also be nice to either move the AMR setting into the "nitb" structure or have the msc data be used _after_ the bts settings. This needs to be cleaned up in the next step.
Manually verified by placing a MO call and checking that both the channel mode modify and the mode modify request contain the multi rate config with the rate mr config (length two bytes, version 1, icmi==1, no start mode being set).
http://cgit.osmocom.org/openbsc/commit/?id=a174a47811f2168d63f6f021d3ed2f156...
commit a174a47811f2168d63f6f021d3ed2f156bff9951 Author: Holger Hans Peter Freyther holger@moiji-mobile.com Date: Thu Sep 24 11:39:38 2015 +0200
amr: Kill more duplication and let the code work one of the modes
http://cgit.osmocom.org/openbsc/commit/?id=615ed46a6ab25f71a7ab0d8201d33b4db...
commit 615ed46a6ab25f71a7ab0d8201d33b4dbf8fc5b0 Author: Holger Hans Peter Freyther holger@moiji-mobile.com Date: Thu Sep 24 11:30:58 2015 +0200
amr: Instead of putting ms/bts into the same struct.. use it twice
This way a lot of if/else can just be killed by the caller deciding which of the two instances to use.
I have copied both branches to new files, replace bts for ms in one of them and ran diff on it. There is no difference.
http://cgit.osmocom.org/openbsc/commit/?id=11cb7a9fd9d853aaf5ff3d34c179fa3af...
commit 11cb7a9fd9d853aaf5ff3d34c179fa3afc9a80a4 Author: Holger Hans Peter Freyther holger@moiji-mobile.com Date: Thu Aug 20 19:32:46 2015 +0200
amr: Remove some code duplication in preparation
Merge two copies into a local static helper function. The format of the message will change and then it is easier to modify it in one place than in two.
Sadly the original patch was merged before this clean-up so do the clean-up as second step.
Conflicts: openbsc/src/libbsc/abis_rsl.c openbsc/src/libbsc/gsm_04_08_utils.c
-----------------------------------------------------------------------
Summary of changes: openbsc/include/openbsc/bsc_api.h | 2 +- openbsc/include/openbsc/gsm_04_08.h | 3 +- openbsc/include/openbsc/gsm_data_shared.h | 10 +++--- openbsc/src/libbsc/abis_rsl.c | 18 +++++----- openbsc/src/libbsc/bsc_api.c | 6 ++-- openbsc/src/libbsc/bsc_vty.c | 59 +++++++++++++------------------ openbsc/src/libbsc/gsm_04_08_utils.c | 57 ++++++++++++----------------- openbsc/src/osmo-bsc/osmo_bsc_api.c | 36 +++++++++++++------ 8 files changed, 93 insertions(+), 98 deletions(-)
hooks/post-receive
osmocom-commitlog@lists.osmocom.org