This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 37f9252361c85249b59d5a9202147136782b5415 (commit) via 2fa74faf927ed1ca9fc311a206c1e18a7295be7a (commit) via 3cbc05210192324592cc8b79e12d3095be302f90 (commit) via 73ed45599b94f666fedd043028daad9427c241bd (commit) via 2e109f08c07ca7ca5bc0f134d561cad42840b27c (commit) via 28786bb2098d404d5f5eb40fc6bafa866c54b0c1 (commit) via 2c1f8c8cebe41b30deca29c55290fef7a61e5343 (commit) via 3d6b9f4fe99c4351ba8937f6d7df6030986b8a92 (commit) via 11ecc9320c168d22ee89f84b75007420020b8356 (commit) via 49012f14dd5480573943e5d8cd5e9908f3eabb16 (commit) via 736474ce451a92cdc17db5f290f55f8cf22a13a2 (commit) via ef022783c37c459d0ccb5aa6f165d4d4dc6c0815 (commit) via eaaee92db5f29fa280ad89ef8b89d9062abcfa48 (commit) via 814fef04b02a915412920b85bd44c25f8e47a79c (commit) via 3df5d53a0400a03a510f9d61a61368229e142d52 (commit) via 4f8e34b226aeae221119c1d5ea659c3f087132aa (commit) via 08586c68dba6c2ae0fb19e2c6e5a1269c7bf4a7c (commit) from bd33f544441300ec8e9a16f6ebec2ba7a0cffebe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=37f9252361c85249b59d5a9202147136… commit 37f9252361c85249b59d5a9202147136782b5415 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 23:58:31 2016 +0100 oap_client: make use of OAP optional: disable for NULL config When passing a NULL config to osmo_oap_client_init(), set OAP to disabled state. Along with the previous fix that ensures message rejection in the disabled state, this makes use of OAP in the GSUP client optional. oap_client_test: expect null config to set state to disabled. Related: OS#1592 Change-Id: Ie4d622fcfd24cb7d89d19f93e4b2571d8fadd1a3 http://cgit.osmocom.org/openbsc/commit/?id=2fa74faf927ed1ca9fc311a206c1e18a… commit 2fa74faf927ed1ca9fc311a206c1e18a7295be7a Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 23:12:17 2016 +0100 oap_client: reject all messages in disabled/uninitialized state Fixes the bug indicated in oap_client_test.c: adjust to actually expect the proper behavior. Also adjust for modified return value for message rejection. Instead of -1, just expect < 0. Adjust experr for new error messages. Related: OS#1592 Change-Id: I16165d228653e8a2689f9df94b77b470c06480c6 http://cgit.osmocom.org/openbsc/commit/?id=3cbc05210192324592cc8b79e12d3095… commit 3cbc05210192324592cc8b79e12d3095be302f90 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 23:13:29 2016 +0100 oap_client_test: show bug: disabled state does not reject message There is a hole in OAP where a disabled OAP still accepts at least a Registration Reject message, after which it will do things it shouldn't. Show this by expecting the bugs, to be adjusted with the upcoming fix. Related: OS#1592 Change-Id: I4a5fde308b876946fea2571ea1a550f0cc7ee136 http://cgit.osmocom.org/openbsc/commit/?id=73ed45599b94f666fedd043028daad94… commit 73ed45599b94f666fedd043028daad9427c241bd Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Fri Dec 9 00:01:56 2016 +0100 oap_client: move logging to DLOAP logging category Use libosmocore's DLOAP logging category for OAP. oap_client_test.c: make sure DLOAP is in DEBUG level to not lose any logging messages from experr. Todo: we're using a "Library" logging category, which is not really what the library category was intended for. Instead, the OAP client should probably be given a logging category like DVLR or DGPRS in its initialization API. Related: OS#1592 Change-Id: Ic765c19381b0d983da90a5d8aee9cd17e31cf34a http://cgit.osmocom.org/openbsc/commit/?id=2e109f08c07ca7ca5bc0f134d561cad4… commit 2e109f08c07ca7ca5bc0f134d561cad42840b27c Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 23:35:20 2016 +0100 oap_client_test: print test descr to stderr, check stderr Related: OS#1592 Change-Id: If1696c8e7bfa696b250f7eac24f08f85f8f492a2 http://cgit.osmocom.org/openbsc/commit/?id=28786bb2098d404d5f5eb40fc6bafa86… commit 28786bb2098d404d5f5eb40fc6bafa866c54b0c1 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Fri Dec 9 00:05:50 2016 +0100 oap_test.c: rename to avoid clash with libosmocore oap_test.c Rename to oap_client_test.c, which is also a more accurate name. Related: OS#1592 Change-Id: I3ca333141a15940df07a1ae77a30bc54885db41f http://cgit.osmocom.org/openbsc/commit/?id=2c1f8c8cebe41b30deca29c55290fef7… commit 2c1f8c8cebe41b30deca29c55290fef7a61e5343 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 22:27:22 2016 +0100 move grps_gsup_client.c to libcommon/gsup_client.c This is in preparation for libvlr. Related: OS#1592 Change-Id: I9ad7dc7f17f3b033c779de9ae8bc120655502fce http://cgit.osmocom.org/openbsc/commit/?id=3d6b9f4fe99c4351ba8937f6d7df6030… commit 3d6b9f4fe99c4351ba8937f6d7df6030986b8a92 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 22:29:27 2016 +0100 move gprs/oap.c to libcommon/oap_client.c This is in preparation for libvlr. Related: OS#1592 Change-Id: Ib526df6d9de55a1e59a379d5e2c8541ed0ef67e3 http://cgit.osmocom.org/openbsc/commit/?id=11ecc9320c168d22ee89f84b75007420… commit 11ecc9320c168d22ee89f84b75007420020b8356 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:29:23 2016 +0100 rename oap.h to oap_client.h Related: OS#1592 Change-Id: I05bd65ff81b0f70f68217b2e0a9466e160bdbdec http://cgit.osmocom.org/openbsc/commit/?id=49012f14dd5480573943e5d8cd5e9908… commit 49012f14dd5480573943e5d8cd5e9908f3eabb16 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:30:34 2016 +0100 oap: rename public API from oap_ to oap_client_ Mainly to differentiate the OAP messaging API (osmo_oap_ in libosmocore) from the OAP client. This is in preparation for moving the oap client to libcommon, which is in turn preparation for libvlr. Add the osmo_ prefix, as all public Osmocom API should have. We also have OAP messages code in libosmocore, so clarify by naming this osmo_oap_client, and by also renaming the oap_test to oap_client_test. This reshuffling will allow an easy move of OAP to libosmocore if we should want to do that. A number of patches will follow up on this. Related: OS#1592 Change-Id: Id447d2bebc026a375567654adafa5f82439ea7e1 http://cgit.osmocom.org/openbsc/commit/?id=736474ce451a92cdc17db5f290f55f8c… commit 736474ce451a92cdc17db5f290f55f8cf22a13a2 Author: Harald Welte &lt;laforge(a)gnumonks.org&gt; Date: Fri May 6 23:28:52 2016 +0200 move OAP messages implementations to libosmocore This corresponds to change-id If5099e60681a215e798b6675f21813f26769c253 in libosmocore, which is now required to build openbsc. Related: OS#1592 Change-Id: I2f06aaa6eb54eafa860cfed8e72e41d82ff1c4cf http://cgit.osmocom.org/openbsc/commit/?id=ef022783c37c459d0ccb5aa6f165d4d4… commit ef022783c37c459d0ccb5aa6f165d4d4dc6c0815 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:28:29 2016 +0100 gsup client, gsup_test_client: move logging to DLGSUP category Use the DLGSUP logging category for GSUP. Bump the required version of libosmocore to 0.9.5 to benefit from the DLGSUP logging category fix in core/logging.[hc]. (Id974c7be158e4d60421a98110f5c807aefd31119) Todo: we're using a "Library" logging category, which is not really what the library category was intended for. Instead, the GSUP client should probably be given a logging category like DVLR or DGPRS in its initialization API. Related: OS#1592 Change-Id: Id3938267fa062e1a997d3704cd678874306f86ee http://cgit.osmocom.org/openbsc/commit/?id=eaaee92db5f29fa280ad89ef8b89d906… commit eaaee92db5f29fa280ad89ef8b89d9062abcfa48 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:22:58 2016 +0100 rename gprs_gsup_client.h to gsup_client.h This is in preparation for moving gsup to libcommon, which is in turn preparation for libvlr. Related: OS#1592 Change-Id: I9c95d00f1a9420887a44c938b1d0ee3e20586f4c http://cgit.osmocom.org/openbsc/commit/?id=814fef04b02a915412920b85bd44c25f… commit 814fef04b02a915412920b85bd44c25f8e47a79c Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:19:57 2016 +0100 gprs_gsup_client*: remove the gprs_ prefix Make sure everything is named gsup_client_ / GSUP_CLIENT_. Rename static gsup_client_send() to client_send() to avoid clash with public gprs_gsup_client_send() being renamed to gsup_client_send(). This is in preparation for moving gsup to libcommon, which is in turn preparation for libvlr. libvlr and osmo-sgsn will use the same GSUP client code. A number of patches will follow up on this, also for the the OAP client. Related: OS#1592 Change-Id: I57433973b1c4f6cc1e12e7b1c96b5f719f418b51 http://cgit.osmocom.org/openbsc/commit/?id=3df5d53a0400a03a510f9d61a6136822… commit 3df5d53a0400a03a510f9d61a61368229e142d52 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Thu Dec 8 21:17:01 2016 +0100 comments: gsup client: rename to Generic, adjust copyright and authors Related: OS#1592 Change-Id: I2c5d145e05aa4afd43ef1341d22563448f1c3577 http://cgit.osmocom.org/openbsc/commit/?id=4f8e34b226aeae221119c1d5ea659c3f… commit 4f8e34b226aeae221119c1d5ea659c3f087132aa Author: Harald Welte &lt;laforge(a)gnumonks.org&gt; Date: Fri May 6 23:27:38 2016 +0200 add gsup_test_client program Related: OS#1592 Change-Id: Iafd844393dd90b899f84ed61c875c1eb533436d7 http://cgit.osmocom.org/openbsc/commit/?id=08586c68dba6c2ae0fb19e2c6e5a1269… commit 08586c68dba6c2ae0fb19e2c6e5a1269c7bf4a7c Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Mon Dec 12 13:04:58 2016 +0100 build: bump required libosmocore, libosmogsm to 0.9.4, for GSUP GSUP was added to libosmocore in 0.9.4. We're using it here, so make up for a previously missing bump. (BTW: I'm pretty sure that other dependencies are also in dire need of a bump, but leaving that for another patch) Change-Id: I4f245a7d78d0889b37084c52478372bddb8289d6 ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 4 +- openbsc/include/openbsc/Makefile.am | 5 +- .../openbsc/{gprs_gsup_client.h => gsup_client.h} | 43 +-- openbsc/include/openbsc/{oap.h => oap_client.h} | 32 ++- openbsc/include/openbsc/oap_messages.h | 70 ----- openbsc/include/openbsc/sgsn.h | 6 +- openbsc/src/gprs/Makefile.am | 3 - openbsc/src/gprs/gprs_subscriber.c | 12 +- openbsc/src/gprs/oap_messages.c | 178 ------------ openbsc/src/gprs/sgsn_vty.c | 2 +- openbsc/src/libcommon/Makefile.am | 18 ++ .../gprs_gsup_client.c => libcommon/gsup_client.c} | 102 +++---- openbsc/src/libcommon/gsup_test_client.c | 299 +++++++++++++++++++++ openbsc/src/{gprs/oap.c => libcommon/oap_client.c} | 67 +++-- openbsc/tests/oap/Makefile.am | 13 +- .../tests/oap/{oap_test.c => oap_client_test.c} | 157 ++++++----- openbsc/tests/oap/oap_client_test.err | 35 +++ openbsc/tests/oap/oap_client_test.ok | 2 + openbsc/tests/oap/oap_test.ok | 7 - openbsc/tests/sgsn/Makefile.am | 5 +- openbsc/tests/sgsn/sgsn_test.c | 30 +-- openbsc/tests/testsuite.at | 5 +- 22 files changed, 622 insertions(+), 473 deletions(-) rename openbsc/include/openbsc/{gprs_gsup_client.h => gsup_client.h} (53%) rename openbsc/include/openbsc/{oap.h => oap_client.h} (67%) delete mode 100644 openbsc/include/openbsc/oap_messages.h delete mode 100644 openbsc/src/gprs/oap_messages.c rename openbsc/src/{gprs/gprs_gsup_client.c => libcommon/gsup_client.c} (67%) create mode 100644 openbsc/src/libcommon/gsup_test_client.c rename openbsc/src/{gprs/oap.c => libcommon/oap_client.c} (78%) rename openbsc/tests/oap/{oap_test.c => oap_client_test.c} (55%) create mode 100644 openbsc/tests/oap/oap_client_test.err create mode 100644 openbsc/tests/oap/oap_client_test.ok delete mode 100644 openbsc/tests/oap/oap_test.ok hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)