This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 89009751ea7ceda542c254633f4ceef23b3f8f90 (commit) via 14598ac88d816168e037d701b6f43a2a4cf02f42 (commit) via eddf339871559f282fe615f9c618a1220bd97743 (commit) from 65774d447d8623257e1cbf3694542f4a421017d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=89009751ea7ceda542c254633f4ce… commit 89009751ea7ceda542c254633f4ceef23b3f8f90 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Nov 16 17:11:28 2017 +0100 mobile: Avoid msg_ref going out of sync It seemed like msg_ref could go out of sync. In some places we are using sms->msg_ref in other cases we pass it as parameter (e.g. when sending the SMS) or we get it out of the gsm411_rp_hdr. Instead of hardcoding 42 for all messages make it configurable and pass the parameter from the caller. Change-Id: I4bac5f06921b5fd85a98d97770d42d4858ca1c42 http://cgit.osmocom.org/osmocom-bb/commit/?id=14598ac88d816168e037d701b6f43… commit 14598ac88d816168e037d701b6f43a2a4cf02f42 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Nov 15 16:18:28 2017 +0100 mobile: Change started and shutdown state through function Instead of changing the field all over the place, do the state change in a function. This will allow us to emit a notification when things change. It is similar to the lchan_state. Change-Id: I6a0591bb2785232681b23e41368323f16d3c960c http://cgit.osmocom.org/osmocom-bb/commit/?id=eddf339871559f282fe615f9c618a… commit eddf339871559f282fe615f9c618a1220bd97743 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Nov 15 12:25:47 2017 +0100 mobile: Instead of putting semantic in a comment, use an enum The enum was created to understand the different states during the shutdown and find places where it is used. The normal transitions are like. Idle -> Imsi Detach -> L1 Reset -> Done Idle -> L1 Reset -> Done The shutdown can get stuck in case: * Out of memory situation while handling IMSI detach (timeout) * Never receiving l1 reset acknnowledgment. The code could benefit from the move to osmo fsm to deal with proper timeouts. Change-Id: Iee1140e4848923c7270495c381bf87b7e3fddee1 ----------------------------------------------------------------------- Summary of changes: .../include/osmocom/bb/common/osmocom_data.h | 7 +++++ .../layer23/include/osmocom/bb/mobile/app_mobile.h | 5 ++++ .../layer23/include/osmocom/bb/mobile/gsm411_sms.h | 3 +- src/host/layer23/src/mobile/app_mobile.c | 35 ++++++++++++++-------- src/host/layer23/src/mobile/gsm411_sms.c | 21 +++++++------ src/host/layer23/src/mobile/gsm480_ss.c | 2 +- src/host/layer23/src/mobile/gsm48_cc.c | 2 +- src/host/layer23/src/mobile/gsm48_mm.c | 4 +-- src/host/layer23/src/mobile/vty_interface.c | 24 +++++++-------- 9 files changed, 61 insertions(+), 42 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack