This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated via 03ab9a650068c758c1102f074606a747827583a8 (commit) from 18d65be080591f08e4c48118c140069c8cf6114f (commit)

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=03ab9a650068c758c1102f074606a...

commit 03ab9a650068c758c1102f074606a747827583a8 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Feb 3 05:00:24 2017 +0100

osmo_auth*: fix ordering of function args

milenage_gen_vec() has parameter ordering of (..., auts, rand_auts, rand).

osmo_auth_gen_vec_auts() has (..., rand_auts, auts, rand), but actually feeds args in the same order, so that its rand_auts becomes auts, and its auts becomes rand_auts.

Interestingly enough, API user osmo-gen-vec.c also adheres to this misordering and in turn passes auts for osmo_auth_gen_vec_auts()'s rand_auts and vice versa, so that it matches milenage_gen_vec().

So both the implementation (milenage_*) and the API user use the same ordering, just osmo_auth_gen_vec_auts() and osmo_auth_impl{ .gen_vec_auts() } in-between have the argument names swapped.

Any current user of this API would need to adhere to this swapping or will not get successful AUTS resolution to a SQN. So the least impact fix is to rename the args without any actual functional change.

So swap the names rand_auts and auts for osmo_auth_gen_vec_auts() and osmo_auth_impl{ .gen_vec_auts() }. (Also adjust API doc ordering)

Change-Id: I0dcbd49759fc32d3b8974102dbd1d6703364ebf4

-----------------------------------------------------------------------

Summary of changes: include/osmocom/crypt/auth.h | 4 ++-- src/gsm/auth_core.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)

hooks/post-receive